yangguo [Wed, 22 Apr 2015 14:16:32 +0000 (07:16 -0700)]
Blacklist mjsunit/es6/generators-debug-scopes.js from turbofan.
TBR=mstarzinger@chromium.org
NOTRY=true
BUG=v8:4055
LOG=N
Review URL: https://codereview.chromium.org/
1098293002
Cr-Commit-Position: refs/heads/master@{#28012}
yangguo [Wed, 22 Apr 2015 14:14:01 +0000 (07:14 -0700)]
Revert of Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/
1098223004/)
Reason for revert:
Test failure was not due to this.
Original issue's description:
> Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/
1094383004/)
>
> Reason for revert:
> GC stress failure (custom snapshot)
>
> Original issue's description:
> > Always optimize for adding properties to native objects.
> >
> > R=jkummerow@chromium.org
> >
> > Committed: https://crrev.com/
c715098e85b93def76c0b3f54290c811dea04f01
> > Cr-Commit-Position: refs/heads/master@{#28003}
>
> TBR=jkummerow@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
bb6958ceff221e66adbc4581471a8ce1b41a4684
> Cr-Commit-Position: refs/heads/master@{#28009}
TBR=jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1100123002
Cr-Commit-Position: refs/heads/master@{#28011}
Michael Achenbach [Wed, 22 Apr 2015 13:29:42 +0000 (15:29 +0200)]
Whitespace change for greenification.
Cr-Commit-Position: refs/heads/master@{#28010}
yangguo [Wed, 22 Apr 2015 13:23:43 +0000 (06:23 -0700)]
Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/
1094383004/)
Reason for revert:
GC stress failure (custom snapshot)
Original issue's description:
> Always optimize for adding properties to native objects.
>
> R=jkummerow@chromium.org
>
> Committed: https://crrev.com/
c715098e85b93def76c0b3f54290c811dea04f01
> Cr-Commit-Position: refs/heads/master@{#28003}
TBR=jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1098223004
Cr-Commit-Position: refs/heads/master@{#28009}
dslomov [Wed, 22 Apr 2015 13:22:37 +0000 (06:22 -0700)]
Stack allocate lexical locals + hoist stack slots
Review URL: https://codereview.chromium.org/
981203003
Cr-Commit-Position: refs/heads/master@{#28008}
erikcorry [Wed, 22 Apr 2015 13:21:27 +0000 (06:21 -0700)]
Experiment with smaller minimum elements dictionary size
BUG=
Review URL: https://codereview.chromium.org/
1094243004
Cr-Commit-Position: refs/heads/master@{#28007}
dcarney [Wed, 22 Apr 2015 12:44:58 +0000 (05:44 -0700)]
[turbofan] make live ranges stateless
this is necessary for the greedy allocator to use the relevant functions, as well as the sanity of someone looking at the code
BUG=
Review URL: https://codereview.chromium.org/
1056063004
Cr-Commit-Position: refs/heads/master@{#28006}
dslomov [Wed, 22 Apr 2015 12:35:05 +0000 (05:35 -0700)]
Introduce "expression classifier" to the parser.
R=marja@chromium.org,rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1065983005
Cr-Commit-Position: refs/heads/master@{#28005}
svenpanne [Wed, 22 Apr 2015 12:24:29 +0000 (05:24 -0700)]
Add an --omit-quit flag to d8 for Emscripten's sake.
Review URL: https://codereview.chromium.org/
1101683002
Cr-Commit-Position: refs/heads/master@{#28004}
yangguo [Wed, 22 Apr 2015 12:11:18 +0000 (05:11 -0700)]
Always optimize for adding properties to native objects.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1094383004
Cr-Commit-Position: refs/heads/master@{#28003}
titzer [Wed, 22 Apr 2015 11:34:43 +0000 (04:34 -0700)]
[turbofan] Add a debug_name to Parameter operators.
R=bmeurer@chromium.org, mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1090303004
Cr-Commit-Position: refs/heads/master@{#28002}
machenbach [Wed, 22 Apr 2015 11:04:25 +0000 (04:04 -0700)]
Revert of Revert of [strong] checking of this & super in constructors (patchset #1 id:1 of https://codereview.chromium.org/
1105453002/)
Reason for revert:
Was an infrastructure problem.
Original issue's description:
> Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/
1024063002/)
>
> Reason for revert:
> [Sheriff] Breaks mac gc stress:
> http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024
>
> Original issue's description:
> > [strong] checking of this & super in constructors
> >
> > R=dslomov@chromium.org, marja@chromium.org
> > BUG=v8:3956
> > LOG=N
> >
> > Enforces for constructors that
> > - the only use of 'super' is the super constructor call
> > - the only use of 'this' is a property assignment
> > - both of these must happen at the top-level of the body
> > - 'this' may only be assigned after the 'super' call
> > - 'return' may only be used after the last assignment to 'this'
> >
> > Not yet working for arrow functions (there might be deeper bugs with those).
> >
> > Committed: https://crrev.com/
580d66bcda66220d2f3062ac58daf925436df74c
> > Cr-Commit-Position: refs/heads/master@{#27977}
>
> TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3956
TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3956
Review URL: https://codereview.chromium.org/
1073103004
Cr-Commit-Position: refs/heads/master@{#28001}
machenbach [Wed, 22 Apr 2015 10:35:23 +0000 (03:35 -0700)]
Revert of Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #1 id:1 of https://codereview.chromium.org/
1099203004/)
Reason for revert:
This was probably an infrastructure problem caused by the mac ninja/goma switch.
Original issue's description:
> Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/
1092043002/)
>
> Reason for revert:
> MAC GCSTRESS failure on new test.
>
> Original issue's description:
> > Protect the emptiness of Array prototype elements with a PropertyCell.
> >
> > Not just emptiness, but also a particular structure.
> >
> > BUG=v8:4044
> > LOG=N
>
> TBR=jkummerow@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:4044
TBR=jkummerow@chromium.org,mvstanton@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4044
Review URL: https://codereview.chromium.org/
1052253003
Cr-Commit-Position: refs/heads/master@{#28000}
machenbach [Wed, 22 Apr 2015 10:33:48 +0000 (03:33 -0700)]
Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/
1103473003/)
Reason for revert:
This was probably an infrastructure problem caused by the mac ninja/goma switch.
Original issue's description:
> Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/
1011823003/)
>
> Reason for revert:
> [Sheriff] breaks mac gc stress:
> http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029
>
> Original issue's description:
> > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
> >
> > BUG=v8:3965, v8:3966
> > R=arv@chromium.org
> > LOG=N
> >
> > Committed: https://crrev.com/
b09c048f693d280052ac63c7d6b3baf27b3bf271
> > Cr-Commit-Position: refs/heads/master@{#27985}
>
> TBR=arv@chromium.org,caitpotter88@gmail.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3965, v8:3966
TBR=arv@chromium.org,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3965, v8:3966
Review URL: https://codereview.chromium.org/
1098243002
Cr-Commit-Position: refs/heads/master@{#27999}
mvstanton [Wed, 22 Apr 2015 09:56:39 +0000 (02:56 -0700)]
Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/
1092043002/)
Reason for revert:
MAC GCSTRESS failure on new test.
Original issue's description:
> Protect the emptiness of Array prototype elements with a PropertyCell.
>
> Not just emptiness, but also a particular structure.
>
> BUG=v8:4044
> LOG=N
TBR=jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4044
Review URL: https://codereview.chromium.org/
1099203004
Cr-Commit-Position: refs/heads/master@{#27998}
machenbach [Wed, 22 Apr 2015 09:43:32 +0000 (02:43 -0700)]
Revert of Revert of [es6] implement Array.prototype.copyWithin() (patchset #1 id:1 of https://codereview.chromium.org/
1084183004/)
Reason for revert:
Check if this CL fails independently of https://chromium.googlesource.com/v8/v8/+/
580d66bcda66220d2f3062ac58daf925436df74c
Original issue's description:
> Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/
376623004/)
>
> Reason for revert:
> [Sheriff] This causes test failures on mac gc stress:
> http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027
>
> Original issue's description:
> > [es6] implement Array.prototype.copyWithin()
> >
> > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin
> >
> > BUG=v8:4039
> > R=adamk@chromium.org
> > LOG=N
>
> TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:4039
>
> Committed: https://crrev.com/
9283fc89710e59445bdc4479454fba97ab9ebdd7
> Cr-Commit-Position: refs/heads/master@{#27984}
TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4039
Review URL: https://codereview.chromium.org/
1072193005
Cr-Commit-Position: refs/heads/master@{#27997}
Benedikt Meurer [Wed, 22 Apr 2015 09:33:45 +0000 (11:33 +0200)]
[mjsunit] Import asm.js test case for poppler.
R=hablich@chromium.org
Review URL: https://codereview.chromium.org/
1105483002
Cr-Commit-Position: refs/heads/master@{#27996}
jochen [Wed, 22 Apr 2015 09:19:38 +0000 (02:19 -0700)]
Remove the weak list of views from array buffers
Instead, views have to check their array buffer for whether
it's neutered or not.
BUG=v8:3996
R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1094863002
Cr-Commit-Position: refs/heads/master@{#27995}
dcarney [Wed, 22 Apr 2015 09:17:47 +0000 (02:17 -0700)]
add StdGlobalValueMap
BUG=
Review URL: https://codereview.chromium.org/
1104463002
Cr-Commit-Position: refs/heads/master@{#27994}
mvstanton [Wed, 22 Apr 2015 08:50:30 +0000 (01:50 -0700)]
Protect the emptiness of Array prototype elements with a PropertyCell.
Not just emptiness, but also a particular structure.
BUG=v8:4044
LOG=N
Review URL: https://codereview.chromium.org/
1092043002
Cr-Commit-Position: refs/heads/master@{#27993}
machenbach [Wed, 22 Apr 2015 08:35:32 +0000 (01:35 -0700)]
[mjsunit] Skip newly added tests under asan.
TBR=svenpanne@chromium.org, titzer@chromium.org, bmeurer@chromium.org,
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1101653002
Cr-Commit-Position: refs/heads/master@{#27992}
machenbach [Wed, 22 Apr 2015 08:00:39 +0000 (01:00 -0700)]
Revert of [strong] checking of this & super in constructors (patchset #7 id:110001 of https://codereview.chromium.org/
1024063002/)
Reason for revert:
[Sheriff] Breaks mac gc stress:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1024
Original issue's description:
> [strong] checking of this & super in constructors
>
> R=dslomov@chromium.org, marja@chromium.org
> BUG=v8:3956
> LOG=N
>
> Enforces for constructors that
> - the only use of 'super' is the super constructor call
> - the only use of 'this' is a property assignment
> - both of these must happen at the top-level of the body
> - 'this' may only be assigned after the 'super' call
> - 'return' may only be used after the last assignment to 'this'
>
> Not yet working for arrow functions (there might be deeper bugs with those).
>
> Committed: https://crrev.com/
580d66bcda66220d2f3062ac58daf925436df74c
> Cr-Commit-Position: refs/heads/master@{#27977}
TBR=dslomov@chromium.org,marja@chromium.org,conradw@chromium.org,rossberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3956
Review URL: https://codereview.chromium.org/
1105453002
Cr-Commit-Position: refs/heads/master@{#27991}
machenbach [Wed, 22 Apr 2015 07:58:00 +0000 (00:58 -0700)]
Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/
1011823003/)
Reason for revert:
[Sheriff] breaks mac gc stress:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029
Original issue's description:
> [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
>
> BUG=v8:3965, v8:3966
> R=arv@chromium.org
> LOG=N
>
> Committed: https://crrev.com/
b09c048f693d280052ac63c7d6b3baf27b3bf271
> Cr-Commit-Position: refs/heads/master@{#27985}
TBR=arv@chromium.org,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3965, v8:3966
Review URL: https://codereview.chromium.org/
1103473003
Cr-Commit-Position: refs/heads/master@{#27990}
Benedikt Meurer [Wed, 22 Apr 2015 07:44:58 +0000 (09:44 +0200)]
[mjsunit] Add custom tests based on SQLite 3.8.9.
Also adjust the test runner to remove --always-opt for FAST_VARIANTS.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1056423004
Cr-Commit-Position: refs/heads/master@{#27989}
yangguo [Wed, 22 Apr 2015 07:40:05 +0000 (00:40 -0700)]
Compact weak fixed arrays before serializing.
R=ulan@chromium.org
BUG=v8:4050
LOG=N
Review URL: https://codereview.chromium.org/
1099103003
Cr-Commit-Position: refs/heads/master@{#27988}
Benedikt Meurer [Wed, 22 Apr 2015 04:32:05 +0000 (06:32 +0200)]
Revert "[test] Initial import of an emscripten test suite."
This reverts commit
bb346227dbff1a2281032878b21d4a4164d87480 because it
adds a lot of overhead without significantly increasing our test
coverage. We need a different approach to deal with this.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1099813007
Cr-Commit-Position: refs/heads/master@{#27987}
v8-autoroll [Wed, 22 Apr 2015 03:29:27 +0000 (20:29 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
442f528de2269272de9610e9c7186047ce4aaadb
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1065783004
Cr-Commit-Position: refs/heads/master@{#27986}
caitpotter88 [Tue, 21 Apr 2015 21:46:11 +0000 (14:46 -0700)]
[es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
BUG=v8:3965, v8:3966
R=arv@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
1011823003
Cr-Commit-Position: refs/heads/master@{#27985}
machenbach [Tue, 21 Apr 2015 21:11:45 +0000 (14:11 -0700)]
Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/
376623004/)
Reason for revert:
[Sheriff] This causes test failures on mac gc stress:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027
Original issue's description:
> [es6] implement Array.prototype.copyWithin()
>
> https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin
>
> BUG=v8:4039
> R=adamk@chromium.org
> LOG=N
TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4039
Review URL: https://codereview.chromium.org/
1084183004
Cr-Commit-Position: refs/heads/master@{#27984}
caitpotter88 [Tue, 21 Apr 2015 19:05:49 +0000 (12:05 -0700)]
[es6] implement Array.prototype.copyWithin()
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin
BUG=v8:4039
R=adamk@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
376623004
Cr-Commit-Position: refs/heads/master@{#27983}
machenbach [Tue, 21 Apr 2015 18:03:11 +0000 (11:03 -0700)]
Revert of track global accesses to constant types (patchset #15 id:280001 of https://codereview.chromium.org/
1062163005/)
Reason for revert:
[Sheriff] Speculative revert for maybe breaking layout tests, e.g.
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/2589
Will reland if it doesn't help.
Original issue's description:
> track global accesses to constant types
>
> BUG=
TBR=verwaest@chromium.org,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1094313003
Cr-Commit-Position: refs/heads/master@{#27982}
machenbach [Tue, 21 Apr 2015 18:01:35 +0000 (11:01 -0700)]
Revert of fix bad rebase in r27966 (patchset #1 id:1 of https://codereview.chromium.org/
1083923005/)
Reason for revert:
Needed to revert https://chromium.googlesource.com/v8/v8/+/
7bcc3d10835105fadc8ecf42a877dec479f0f80d
Original issue's description:
> fix bad rebase in r27966
>
> TBR=verwaest@chromium.org
>
> BUG=
TBR=verwaest@chromium.org,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1093043003
Cr-Commit-Position: refs/heads/master@{#27981}
caitpotter88 [Tue, 21 Apr 2015 17:43:22 +0000 (10:43 -0700)]
[es6] stage harmony_spreadcalls
BUG=v8:3018
R=dslomov@chromium.org, arv@chromium.org, rossberg@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
1096363002
Cr-Commit-Position: refs/heads/master@{#27980}
titzer [Tue, 21 Apr 2015 17:05:19 +0000 (10:05 -0700)]
[turbofan] --turbo implies --turbo-type-feedback and disable fast properties.
Note: can't be landed until LoadProperty => LoadNamed is fixed.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1101473004
Cr-Commit-Position: refs/heads/master@{#27979}
caitpotter88 [Tue, 21 Apr 2015 17:04:12 +0000 (10:04 -0700)]
[es6] stage harmony_rest_parameters
BUG=v8:2159
R=arv@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
1099813005
Cr-Commit-Position: refs/heads/master@{#27978}
rossberg [Tue, 21 Apr 2015 16:34:42 +0000 (09:34 -0700)]
[strong] checking of this & super in constructors
R=dslomov@chromium.org, marja@chromium.org
BUG=v8:3956
LOG=N
Enforces for constructors that
- the only use of 'super' is the super constructor call
- the only use of 'this' is a property assignment
- both of these must happen at the top-level of the body
- 'this' may only be assigned after the 'super' call
- 'return' may only be used after the last assignment to 'this'
Not yet working for arrow functions (there might be deeper bugs with those).
Review URL: https://codereview.chromium.org/
1024063002
Cr-Commit-Position: refs/heads/master@{#27977}
mvstanton [Tue, 21 Apr 2015 16:03:25 +0000 (09:03 -0700)]
VectorICs: support converting keyed loads into named loads in crankshaft.
This was a TODO for a while in crankshaft, now ready to address.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1093413002
Cr-Commit-Position: refs/heads/master@{#27976}
jochen [Tue, 21 Apr 2015 15:58:20 +0000 (08:58 -0700)]
Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/
1094333002/)
Reason for revert:
Breaks gbemu
Original issue's description:
> Reland "LayoutDescriptor should inherit from JSTypedArray"
>
> Original issue's description:
> > LayoutDescriptor should inherit from JSTypedArray
> >
> > It can't just inherit from a FixedTypedArray-like type, as we soon
> > assume that a FixedTypedArray-like type is always held by an
> > ArrayBufferView-like type
> >
> > BUG=v8:3996
> > R=ishell@chromium.org,verwaest@chromium.org
> > LOG=n
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n
TBR=ishell@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/
1080403004
Cr-Commit-Position: refs/heads/master@{#27975}
mstarzinger [Tue, 21 Apr 2015 15:43:31 +0000 (08:43 -0700)]
[turbofan] Use FastCloneShallow[Array|Object]Stub if possible.
This allows the JSIntrinsicLowering to optimize the cloning of literal
boilerplate objects using either the FastCloneShallowArrayStub or the
FastCloneShallowObjectStub when applicable.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1097963002
Cr-Commit-Position: refs/heads/master@{#27974}
jochen [Tue, 21 Apr 2015 15:21:57 +0000 (08:21 -0700)]
Reland "LayoutDescriptor should inherit from JSTypedArray"
Original issue's description:
> LayoutDescriptor should inherit from JSTypedArray
>
> It can't just inherit from a FixedTypedArray-like type, as we soon
> assume that a FixedTypedArray-like type is always held by an
> ArrayBufferView-like type
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n
BUG=v8:3996
R=ishell@chromium.org,verwaest@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1094333002
Cr-Commit-Position: refs/heads/master@{#27973}
titzer [Tue, 21 Apr 2015 15:13:13 +0000 (08:13 -0700)]
[turbofan] Fix reduction of LoadProperty/StoreProperty to LoadNamed/StoreNamed.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1095313002
Cr-Commit-Position: refs/heads/master@{#27972}
wingo [Tue, 21 Apr 2015 14:44:18 +0000 (07:44 -0700)]
Allow eval/arguments in arrow functions
Originally landed in https://codereview.chromium.org/
1061983004;
re-landing after re-landing formal parameter parsing refactors.
R=marja@chromium.org
BUG=v8:4020
LOG=N
Review URL: https://codereview.chromium.org/
1077153005
Cr-Commit-Position: refs/heads/master@{#27971}
dcarney [Tue, 21 Apr 2015 14:40:16 +0000 (07:40 -0700)]
fix bad rebase in r27966
TBR=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1083923005
Cr-Commit-Position: refs/heads/master@{#27970}
yangguo [Tue, 21 Apr 2015 14:39:09 +0000 (07:39 -0700)]
Wrap promise implementation in a function.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1054763003
Cr-Commit-Position: refs/heads/master@{#27969}
jochen [Tue, 21 Apr 2015 14:03:09 +0000 (07:03 -0700)]
Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1 of https://codereview.chromium.org/
1084793004/)
Reason for revert:
breaks mjsunit on debug bots
Original issue's description:
> LayoutDescriptor should inherit from JSTypedArray
>
> It can't just inherit from a FixedTypedArray-like type, as we soon
> assume that a FixedTypedArray-like type is always held by an
> ArrayBufferView-like type
>
> BUG=v8:3996
> R=ishell@chromium.org,verwaest@chromium.org
> LOG=n
TBR=ishell@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3996
Review URL: https://codereview.chromium.org/
1073053006
Cr-Commit-Position: refs/heads/master@{#27968}
yangguo [Tue, 21 Apr 2015 13:44:09 +0000 (06:44 -0700)]
Reintroduce %GetRootNaN to fix MIPS.
R=dusan.milosavljevic@imgtec.com
Review URL: https://codereview.chromium.org/
1101503003
Cr-Commit-Position: refs/heads/master@{#27967}
dcarney [Tue, 21 Apr 2015 13:37:16 +0000 (06:37 -0700)]
track global accesses to constant types
BUG=
Review URL: https://codereview.chromium.org/
1062163005
Cr-Commit-Position: refs/heads/master@{#27966}
jkummerow [Tue, 21 Apr 2015 13:22:09 +0000 (06:22 -0700)]
Drop unused field from PrototypeInfo
Review URL: https://codereview.chromium.org/
1097313002
Cr-Commit-Position: refs/heads/master@{#27965}
jochen [Tue, 21 Apr 2015 13:07:32 +0000 (06:07 -0700)]
LayoutDescriptor should inherit from JSTypedArray
It can't just inherit from a FixedTypedArray-like type, as we soon
assume that a FixedTypedArray-like type is always held by an
ArrayBufferView-like type
BUG=v8:3996
R=ishell@chromium.org,verwaest@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1084793004
Cr-Commit-Position: refs/heads/master@{#27964}
dcarney [Tue, 21 Apr 2015 13:05:05 +0000 (06:05 -0700)]
[turbofan] split all functions off of LinearScanAllocator which are unrelated to LinearScan
this is in preparation for landing the GreedyAllocator
BUG=
Review URL: https://codereview.chromium.org/
1100713003
Cr-Commit-Position: refs/heads/master@{#27963}
Benedikt Meurer [Tue, 21 Apr 2015 12:24:01 +0000 (14:24 +0200)]
[test] Initial import of an emscripten test suite.
These tests are based on individual tests from the Emscripten benchmark
suite, which are used to test Emscripten itself. We adopt them to test
asm.js code paths in V8.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1101493002
Cr-Commit-Position: refs/heads/master@{#27962}
dcarney [Tue, 21 Apr 2015 12:01:45 +0000 (05:01 -0700)]
[turbofan] Split ConstraintBuilder off of LiveRangeBuilder.
Plus some driveby cleanup.
Review URL: https://codereview.chromium.org/
1099093002
Cr-Commit-Position: refs/heads/master@{#27961}
wingo [Tue, 21 Apr 2015 11:09:53 +0000 (04:09 -0700)]
Factor formal argument parsing into ParserBase
This commit is a precursor to making lazy arrow function parsing use
similar logic to function(){} argument parsing.
Originally landed in these three CLs:
https://codereview.chromium.org/
1078093002
https://codereview.chromium.org/
1083623002
https://codereview.chromium.org/
1083953002
These were rolled out due to a performance regression on CodeLoad. This
patchset will fix that by avoiding creation of a DuplicateFinder in the
full parser.
R=marja@chromium.org
BUG=
LOG=N
Review URL: https://codereview.chromium.org/
1100713002
Cr-Commit-Position: refs/heads/master@{#27960}
yangguo [Tue, 21 Apr 2015 11:07:44 +0000 (04:07 -0700)]
Change hash table capacity heuristics when serializing.
Also extract non-templated parts of HashTable class into HashTableBase.
Review URL: https://codereview.chromium.org/
1095273002
Cr-Commit-Position: refs/heads/master@{#27959}
svenpanne [Tue, 21 Apr 2015 10:21:50 +0000 (03:21 -0700)]
Removed src/{isolate,property-details,utils}-inl.h
Baby steps towards saner #includes...
Review URL: https://codereview.chromium.org/
1051393003
Cr-Commit-Position: refs/heads/master@{#27958}
jochen [Tue, 21 Apr 2015 10:06:17 +0000 (03:06 -0700)]
Add myself to include/OWNERS
BUG=none
R=danno@chromium.org
LOG=n
NOTRY=true
Review URL: https://codereview.chromium.org/
1098873002
Cr-Commit-Position: refs/heads/master@{#27957}
jochen [Tue, 21 Apr 2015 10:05:12 +0000 (03:05 -0700)]
Don't assert that no incremental marking happened during a non-incremental GC
If a scavenge is triggered during the GC (via a weak callback or the GC
prologue/epilogue), and another mark-compact is triggered (via the same
unfortunate code path), we end up doing some incremental steps.
BUG=v8:4048
R=dcarney@chromium.org,hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1096693011
Cr-Commit-Position: refs/heads/master@{#27956}
yangguo [Tue, 21 Apr 2015 09:42:16 +0000 (02:42 -0700)]
Wrap harmony implementations in functions.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1100673002
Cr-Commit-Position: refs/heads/master@{#27955}
dcarney [Tue, 21 Apr 2015 09:06:45 +0000 (02:06 -0700)]
[turbofan] Cleanup register allocator a little after split.
Review URL: https://codereview.chromium.org/
1087983007
Cr-Commit-Position: refs/heads/master@{#27954}
yangguo [Tue, 21 Apr 2015 09:03:24 +0000 (02:03 -0700)]
Migrate error messages, part 4 (v8natives.js).
Goal is to reduce native context size.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1099573002
Cr-Commit-Position: refs/heads/master@{#27953}
machenbach [Tue, 21 Apr 2015 08:17:19 +0000 (01:17 -0700)]
[test-runner] Add dedicated test mode for tryserver.
BUG=
Review URL: https://codereview.chromium.org/
1098883002
Cr-Commit-Position: refs/heads/master@{#27952}
dcarney [Tue, 21 Apr 2015 08:16:12 +0000 (01:16 -0700)]
make Handle a synonym of Local
R=svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
679143002
Cr-Commit-Position: refs/heads/master@{#27951}
ishell [Mon, 20 Apr 2015 23:45:15 +0000 (16:45 -0700)]
Avoid having untyped slots for objects embedded into code because it breaks slots filtering.
BUG=chromium:478747,chromium:478811
LOG=N
Review URL: https://codereview.chromium.org/
1096053002
Cr-Commit-Position: refs/heads/master@{#27950}
yangguo [Mon, 20 Apr 2015 19:18:56 +0000 (12:18 -0700)]
Small polishing changes to the native js.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1096763003
Cr-Commit-Position: refs/heads/master@{#27949}
Daniel Vogelheim [Mon, 20 Apr 2015 18:14:44 +0000 (20:14 +0200)]
Disable mjsunit/es7/object-observe on gc-stress, due to flakiness.
TBR=machenbach@chromium.org
CC=adamk@chromium.org
BUG=478788
LOG=N
Review URL: https://codereview.chromium.org/
1092323003
Cr-Commit-Position: refs/heads/master@{#27948}
svenpanne [Mon, 20 Apr 2015 16:24:52 +0000 (09:24 -0700)]
Import Reversed adapter from Chromium and use it in v8.
Review URL: https://codereview.chromium.org/
1098863003
Cr-Commit-Position: refs/heads/master@{#27947}
dcarney [Mon, 20 Apr 2015 16:15:34 +0000 (09:15 -0700)]
[turbofan] split register allocator into little pieces
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1094063002
Cr-Commit-Position: refs/heads/master@{#27946}
titzer [Mon, 20 Apr 2015 15:22:02 +0000 (08:22 -0700)]
Reland "Refactor compilation dependency handling."
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1099473004
Cr-Commit-Position: refs/heads/master@{#27945}
jkummerow [Mon, 20 Apr 2015 15:19:43 +0000 (08:19 -0700)]
Revert of Fix logic for doing incremental marking steps on tenured allocation. (patchset #4 id:60001 of https://codereview.chromium.org/
1040233003/)
Reason for revert:
Suspected of triggering memory corruption issues, e.g. crbug.com/478401.
Original issue's description:
> Fix logic for doing incremental marking steps on tenured allocation.
>
> R=hpayer@chromium.org
> BUG=
>
> Committed: https://crrev.com/
9716468ae63500adb74f5188c47de847e195d71b
> Cr-Commit-Position: refs/heads/master@{#27883}
TBR=hpayer@chromium.org,erikcorry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1099633002
Cr-Commit-Position: refs/heads/master@{#27944}
mvstanton [Mon, 20 Apr 2015 15:16:50 +0000 (08:16 -0700)]
Make sure builtins preserve guarantees about empty element array prototypes.
We have a bottleneck around storing elements in the array and object prototypes,
but the Push() and Unshift() builtins don't respect them.
Fix this exactly to the level of existing support for stores.
BUG=v8:4043
LOG=N
NOTRY=true
Review URL: https://codereview.chromium.org/
1066003003
Cr-Commit-Position: refs/heads/master@{#27943}
jochen [Mon, 20 Apr 2015 15:01:55 +0000 (08:01 -0700)]
Allow for accessing an ArrayBuffer contents without externalizing it
The embedder has to take appropriate steps to ensure that the
ArrayBuffer doesn't die while it's accessing the pointer, e.g. keep a
Local handle to it around
BUG=none
R=dslomov@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
1095083002
Cr-Commit-Position: refs/heads/master@{#27942}
yangguo [Mon, 20 Apr 2015 14:41:00 +0000 (07:41 -0700)]
Throw when attaching a stack trace to an object fails.
R=jarin@chromium.org
BUG=chromium:478011
LOG=N
Review URL: https://codereview.chromium.org/
1077153003
Cr-Commit-Position: refs/heads/master@{#27941}
yangguo [Mon, 20 Apr 2015 14:12:39 +0000 (07:12 -0700)]
Wrap array implementation in a function.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1067523003
Cr-Commit-Position: refs/heads/master@{#27940}
jochen [Mon, 20 Apr 2015 13:31:38 +0000 (06:31 -0700)]
Remove support for externally backed elements from the API
Embedders should use ArrayBuffers instead
BUG=v8:3996
LOG=y
R=verwaest@chromium.org,dslomov@chromium.org,kbr@chromium.org
Review URL: https://codereview.chromium.org/
1092923002
Cr-Commit-Position: refs/heads/master@{#27939}
jochen [Mon, 20 Apr 2015 13:26:38 +0000 (06:26 -0700)]
Deprecate 3-args ResourceConstraints::ConfigureDefaults
Embedders should use the 2-args version. Number of cores is just
ignored.
BUG=none
R=dcarney@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
1080633006
Cr-Commit-Position: refs/heads/master@{#27938}
Ross McIlroy [Mon, 20 Apr 2015 13:08:11 +0000 (14:08 +0100)]
Replace OVERRIDE->override and FINAL->final since we now require C++11.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
1088993003
Cr-Commit-Position: refs/heads/master@{#27937}
machenbach [Mon, 20 Apr 2015 12:23:29 +0000 (05:23 -0700)]
Temporarily skip slow test.
TBR=bmeurer@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1093143002
Cr-Commit-Position: refs/heads/master@{#27936}
Ben L. Titzer [Mon, 20 Apr 2015 11:46:39 +0000 (13:46 +0200)]
Always wrap AllocationSiteContext::current() in a new handle in Crankshaft.
R=mvstanton@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1086863003
Cr-Commit-Position: refs/heads/master@{#27935}
jochen [Mon, 20 Apr 2015 10:23:57 +0000 (03:23 -0700)]
Indicate that low-memory-notificatin triggered GCs are "forced"
BUG=none
R=hpayer@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
1095043002
Cr-Commit-Position: refs/heads/master@{#27934}
yangguo [Mon, 20 Apr 2015 10:22:21 +0000 (03:22 -0700)]
Correctly name header macros for src/snapshot/*.h.
R=mvstanton@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1091983002
Cr-Commit-Position: refs/heads/master@{#27933}
yangguo [Mon, 20 Apr 2015 09:57:15 +0000 (02:57 -0700)]
Serializer: assert that we deserialize only one native context.
R=mvstanton@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/
1097893002
Cr-Commit-Position: refs/heads/master@{#27932}
yangguo [Mon, 20 Apr 2015 08:55:17 +0000 (01:55 -0700)]
Fix serialization statistics for external strings.
External strings are serialized as internal strings. The current way
of collecting stats is slightly wrong. We ought to use the map and
size passed to SerializePrologue.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1092253003
Cr-Commit-Position: refs/heads/master@{#27931}
Benedikt Meurer [Mon, 20 Apr 2015 07:58:30 +0000 (09:58 +0200)]
[mjsunit] Import test case based on the Massive/SQLite benchmark.
This adds a stripped down version of the SQLite benchmark (running with
--size 1) to the mjsunit suite. We might want to move that to a
dedicated slow/stress/whatever test suite once an appropriate decision
is made.
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1094043002
Cr-Commit-Position: refs/heads/master@{#27930}
ulan [Sat, 18 Apr 2015 09:21:15 +0000 (02:21 -0700)]
Clean up output of heap object tracing
BUG=
Review URL: https://codereview.chromium.org/
1097683002
Cr-Commit-Position: refs/heads/master@{#27929}
v8-autoroll [Sat, 18 Apr 2015 03:48:39 +0000 (20:48 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
d3e6123fdadc4bf98b8c676173f77f8f8eed363f
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1096893002
Cr-Commit-Position: refs/heads/master@{#27928}
adamk [Fri, 17 Apr 2015 22:45:15 +0000 (15:45 -0700)]
[modules] Parsing: add ModuleRequests where missing
Two last forms supported in this patch:
- 'import' ModuleSpecifier
- 'export' '*' 'from' ModuleSpecifier.
BUG=v8:1569
LOG=n
Review URL: https://codereview.chromium.org/
1094963002
Cr-Commit-Position: refs/heads/master@{#27927}
ssid [Fri, 17 Apr 2015 19:33:18 +0000 (12:33 -0700)]
Adding missing V8_EXPORT flag in SpaceStatistics class in v8.h
This class was added in crrev.com/
1058253003 and missed V8_EXPORT in
definition.
BUG=466141, 476013
LOG=Y
Review URL: https://codereview.chromium.org/
1090333002
Cr-Commit-Position: refs/heads/master@{#27926}
rmcilroy [Fri, 17 Apr 2015 18:00:24 +0000 (11:00 -0700)]
Turn off SupportsFlexibleFloorAndRound for Arm64 due to a bug.
There is a bug with SupportsFlexibleFloorAndRound on Arm64. Turn it off for
now until we figure out a proper solution.
BUG=chromium:476477
LOG=Y
Review URL: https://codereview.chromium.org/
1093863002
Cr-Commit-Position: refs/heads/master@{#27925}
hpayer [Fri, 17 Apr 2015 16:57:34 +0000 (09:57 -0700)]
Initialize idle old generation allocation limit in constructor.
BUG=478082
NOTRY=true
LOG=n
Review URL: https://codereview.chromium.org/
1093853002
Cr-Commit-Position: refs/heads/master@{#27924}
mbrandy [Fri, 17 Apr 2015 15:56:22 +0000 (08:56 -0700)]
PPC: Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations"
Port
8098253562c7585405f435145e7acf74ff0123f8
R=verwaest@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1057413003
Cr-Commit-Position: refs/heads/master@{#27923}
danno [Fri, 17 Apr 2015 15:46:23 +0000 (08:46 -0700)]
[visualizer]: Add types to visualizer output
Review URL: https://codereview.chromium.org/
1083083006
Cr-Commit-Position: refs/heads/master@{#27922}
jkummerow [Fri, 17 Apr 2015 14:21:32 +0000 (07:21 -0700)]
Fix GC-induced DCHECK failure in Runtime_GetWeakMapEntries
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
1091253002
Cr-Commit-Position: refs/heads/master@{#27921}
yangguo [Fri, 17 Apr 2015 14:10:05 +0000 (07:10 -0700)]
Wrap object observe implementation in a function.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1086813005
Cr-Commit-Position: refs/heads/master@{#27920}
ssid [Fri, 17 Apr 2015 14:04:32 +0000 (07:04 -0700)]
Adding V8 api to get memory statistics of spaces in V8::Heap.
This is first step towards adding V8 heap statistics to the memory
tracing infrastructure. For being able to get useful memory number into
the memory dump, v8 needs to provide an external api needs to obtain
more information about the heap. So, this Cl extends the api to give
information about the memory allocated and used in the spaces.
BUG=466141, 476013
LOG=Y
Review URL: https://codereview.chromium.org/
1058253003
Cr-Commit-Position: refs/heads/master@{#27919}
yangguo [Fri, 17 Apr 2015 13:53:15 +0000 (06:53 -0700)]
Wrap JSON and generator implementation in functions.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1097703002
Cr-Commit-Position: refs/heads/master@{#27918}
yangguo [Fri, 17 Apr 2015 13:27:41 +0000 (06:27 -0700)]
Migrate error messages, part 3 (runtime.js).
Motivation for this is reducing the size of the native context.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
1089303003
Cr-Commit-Position: refs/heads/master@{#27917}
jkummerow [Fri, 17 Apr 2015 12:16:12 +0000 (05:16 -0700)]
Don't use normalized map cache for prototype maps
BUG=chromium:477924
LOG=n
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
1090193002
Cr-Commit-Position: refs/heads/master@{#27916}
jkummerow [Fri, 17 Apr 2015 11:46:02 +0000 (04:46 -0700)]
Bump limit in PushStackTraceAndDie
To increase the chances of minidumps containing enough useful information
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
1068783006
Cr-Commit-Position: refs/heads/master@{#27915}
erikcorry [Fri, 17 Apr 2015 11:17:33 +0000 (04:17 -0700)]
Rename some things around incremental marking triggers
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1094843002
Cr-Commit-Position: refs/heads/master@{#27914}
Michael Achenbach [Fri, 17 Apr 2015 11:01:53 +0000 (13:01 +0200)]
Whitespace commit to trigger bots.
Cr-Commit-Position: refs/heads/master@{#27913}