Dmitry Ilyin [Fri, 17 May 2019 08:38:48 +0000 (11:38 +0300)]
yet another one revertion
Dmitry Ilyin [Thu, 16 May 2019 14:00:25 +0000 (17:00 +0300)]
revert entire file.c
Dmitry Ilyin [Thu, 16 May 2019 13:35:45 +0000 (16:35 +0300)]
revert entire generic.c
Dmitry Ilyin [Thu, 16 May 2019 13:32:12 +0000 (16:32 +0300)]
remove dead code in generic.c
Dmitry Ilyin [Wed, 15 May 2019 19:41:25 +0000 (22:41 +0300)]
format after VS2010
Dmitry Ilyin [Wed, 15 May 2019 19:33:35 +0000 (20:33 +0100)]
VS2010 adaptation
Dmitry Ilyin [Wed, 15 May 2019 17:12:33 +0000 (20:12 +0300)]
proper code format
Dmitry Ilyin [Tue, 14 May 2019 18:44:33 +0000 (21:44 +0300)]
fix for loop for ancient compilers
Dmitry Ilyin [Tue, 14 May 2019 18:02:31 +0000 (21:02 +0300)]
Artur Zaprzala's rdp2tcp channel driver
Martin Fleisz [Thu, 9 May 2019 12:49:21 +0000 (14:49 +0200)]
Merge pull request #5394 from akallabeth/settings_update
Updated settings getter/setter for RemoteApplicationSupportMask
Armin Novak [Thu, 9 May 2019 12:24:58 +0000 (14:24 +0200)]
Updated settings getter/setter for RemoteApplicationSupportMask
Martin Fleisz [Thu, 9 May 2019 12:23:31 +0000 (14:23 +0200)]
Merge pull request #5314 from akallabeth/setting_getter_setter_generator
Added python generator for freerdp_[g|s]et_param*
Armin Novak [Thu, 9 May 2019 11:50:39 +0000 (13:50 +0200)]
Fixed remaining getter/setter return checks.
Martin Fleisz [Thu, 9 May 2019 11:45:37 +0000 (13:45 +0200)]
Merge pull request #5393 from akallabeth/rails_memleak_fix
Fixed window order cleanup for NOTIFY_ICON_STATE_ORDER
Armin Novak [Thu, 9 May 2019 11:23:25 +0000 (13:23 +0200)]
Fixed window order cleanup for NOTIFY_ICON_STATE_ORDER
Martin Fleisz [Thu, 9 May 2019 11:21:36 +0000 (13:21 +0200)]
Merge pull request #5327 from akallabeth/sign_compare_fixes_v3
Leak and warning fixes for 2.0
Martin Fleisz [Thu, 9 May 2019 11:16:08 +0000 (13:16 +0200)]
Merge pull request #5392 from akallabeth/gfx_avc_flag_fixes
Fixed GFX flags and CapsConfirm return checks
Martin Fleisz [Thu, 9 May 2019 10:49:55 +0000 (12:49 +0200)]
Merge pull request #5386 from akallabeth/rails_spec_update
Rails spec update
Armin Novak [Thu, 9 May 2019 10:46:10 +0000 (12:46 +0200)]
Fixed GFX flags and CapsConfirm return checks
Armin Novak [Thu, 9 May 2019 10:28:27 +0000 (12:28 +0200)]
Fixed rails set_caretwidth
David Fort [Thu, 9 May 2019 08:33:18 +0000 (10:33 +0200)]
Merge pull request #5388 from akallabeth/nightly_cairo
Nightly: activate cairo software scaling
Armin Novak [Wed, 8 May 2019 15:54:27 +0000 (17:54 +0200)]
Enable cairo support for software scaling.
Armin Novak [Wed, 8 May 2019 13:36:20 +0000 (15:36 +0200)]
Updated RAILS implementation
* Implement new messages and callbacks
* Announce most recent channel features
* Added settings to configure flags to announce
akallabeth [Wed, 8 May 2019 15:19:27 +0000 (17:19 +0200)]
Merge pull request #5387 from mfleisz/image_from_icon
core: Move image conversion of icon data into the library
Martin Fleisz [Wed, 8 May 2019 13:03:06 +0000 (15:03 +0200)]
core: Move image conversion for icon data into the library
Armin Novak [Wed, 8 May 2019 13:35:07 +0000 (15:35 +0200)]
Fixed warnings and cleaned up gfx related xfreerdp code.
Armin Novak [Fri, 5 Apr 2019 11:27:57 +0000 (13:27 +0200)]
For smartcard trace functions use const arguments
Armin Novak [Fri, 5 Apr 2019 11:17:28 +0000 (13:17 +0200)]
Fixed uninitialized value
Armin Novak [Fri, 5 Apr 2019 11:17:24 +0000 (13:17 +0200)]
Fixed memory leak
Armin Novak [Fri, 5 Apr 2019 11:02:08 +0000 (13:02 +0200)]
Fixed memory leak
Armin Novak [Fri, 5 Apr 2019 11:01:59 +0000 (13:01 +0200)]
Fixed memory leak
Armin Novak [Fri, 5 Apr 2019 09:40:10 +0000 (11:40 +0200)]
Fixed possible memory leak.
Armin Novak [Fri, 5 Apr 2019 09:40:02 +0000 (11:40 +0200)]
Fixed index data type
Martin Fleisz [Wed, 8 May 2019 13:05:05 +0000 (15:05 +0200)]
Merge pull request #5266 from akallabeth/file_list_synth
Added a proper synthesizer for FileGroupDescriptorW to text/uri-list
Armin Novak [Wed, 8 May 2019 12:41:22 +0000 (14:41 +0200)]
Fixed error checks and uninitialized values in convert_filedescriptors_to_uri_list
Armin Novak [Wed, 8 May 2019 12:35:25 +0000 (14:35 +0200)]
Refactored settings getter/setter to stay compatible.
Armin Novak [Mon, 6 May 2019 07:51:42 +0000 (09:51 +0200)]
Fixed use of settings getter/setter
Armin Novak [Thu, 21 Mar 2019 12:08:59 +0000 (13:08 +0100)]
Added python generator for freerdp_[g|s]et_param*
The settings getters and setters are now automatically generated.
Added a test case to check if all available options can be retrieved.
Martin Fleisz [Wed, 8 May 2019 12:16:05 +0000 (14:16 +0200)]
Merge pull request #5385 from akallabeth/some_unused_parameter_silenced
Some unused parameter silenced
Martin Fleisz [Wed, 8 May 2019 11:42:50 +0000 (13:42 +0200)]
Merge pull request #5383 from akallabeth/gfx_spec_update
Updated GFX to 10.6 spec
Armin Novak [Wed, 8 May 2019 10:58:01 +0000 (12:58 +0200)]
Fixed doulbe semicolon in C files.
Armin Novak [Wed, 8 May 2019 10:26:04 +0000 (12:26 +0200)]
Silenced unused parameter warnings in smartcard trace
Armin Novak [Wed, 8 May 2019 10:20:43 +0000 (12:20 +0200)]
Silenced some unused parameter warnings.
Armin Novak [Wed, 8 May 2019 10:05:58 +0000 (12:05 +0200)]
Fixed memory leak and return values in rdpgfx_recv_caps_advertise_pdu
Armin Novak [Wed, 8 May 2019 09:43:22 +0000 (11:43 +0200)]
Added gfx capability filter option.
With this new option it is possible to selectively disable certain
GFX capability versions. This way buggy behaviour can be addressed
at runtime.
Armin Novak [Wed, 8 May 2019 08:32:01 +0000 (10:32 +0200)]
Fixed alignment requirements for surface sizes.
David Fort [Tue, 7 May 2019 19:50:13 +0000 (21:50 +0200)]
Merge pull request #5384 from m4ntis/fix-readme
Add .md file extention to README
Martin Fleisz [Tue, 7 May 2019 13:49:58 +0000 (15:49 +0200)]
Merge pull request #5339 from akallabeth/update_paint_lock
Unified update->BeginPaint and update->EndPaint
Mati Shabtay [Tue, 7 May 2019 13:11:05 +0000 (16:11 +0300)]
Add .md file extention to README
Armin Novak [Tue, 7 May 2019 11:46:24 +0000 (13:46 +0200)]
Fixed missing argument checks.
The arguments for rdpgfx_send_frame_acknowledge_pdu must be checked
as in some call stacks they might be NULL.
Armin Novak [Tue, 7 May 2019 10:10:23 +0000 (12:10 +0200)]
Optimized image scaling, copy if factor is 1.0
Armin Novak [Tue, 7 May 2019 08:22:02 +0000 (10:22 +0200)]
Updated GFX to 10.6 spec
Martin Fleisz [Tue, 7 May 2019 09:07:50 +0000 (11:07 +0200)]
Merge pull request #5381 from akallabeth/swscale
Added image scaling api for software drawing.
Armin Novak [Mon, 6 May 2019 11:18:31 +0000 (13:18 +0200)]
Added image scaling api for software drawing.
For future GFX channel functions an image scaling function is required.
This moves the implementation from wayland client to core library
and adds support for the much faster SWScale library.
akallabeth [Mon, 6 May 2019 13:32:32 +0000 (15:32 +0200)]
Merge pull request #5376 from kubistika/bugfix/rdpgfx-server-v10.6-PDUs
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
akallabeth [Mon, 6 May 2019 10:51:23 +0000 (12:51 +0200)]
Merge pull request #5377 from m4ntis/gfx/fix-caps-confirm-recv
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
David Fort [Mon, 6 May 2019 06:07:32 +0000 (08:07 +0200)]
Merge pull request #5378 from m4ntis/gfx/manual-frame-ack-caps-sync
rdpgfx/client: Add callbacks for manual caps sending and frame acking
Mati Shabtay [Sun, 5 May 2019 13:27:11 +0000 (16:27 +0300)]
client/rdpgfx_main.h: Formatting
Armin Novak [Thu, 2 May 2019 05:03:16 +0000 (07:03 +0200)]
Fixed const correctness of gfx function pointer
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
Mati Shabtay [Sun, 5 May 2019 12:31:18 +0000 (15:31 +0300)]
rdpgfx/client: Add callbacks for manual caps sending and frame acking
Mati Shabtay [Sun, 5 May 2019 10:39:04 +0000 (13:39 +0300)]
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
kubistika [Sun, 5 May 2019 09:34:57 +0000 (12:34 +0300)]
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
Bernhard Miklautz [Fri, 3 May 2019 10:01:51 +0000 (12:01 +0200)]
Merge pull request #5308 from akallabeth/fix_win32_overlinking
Fixed windows overlinking.
r-barnett [Thu, 2 May 2019 04:11:57 +0000 (23:11 -0500)]
Fix smartcard segfault when no devices are present (#5364)
* Don't assume smartcard reader list is not empty.
* Check status of retrieval of smartcard device list before trying to filter it
* style fixes
amratsingh [Thu, 2 May 2019 03:59:52 +0000 (09:29 +0530)]
android_freerdp.c: fixed wrong registered signature (#5371)
Martin Fleisz [Mon, 29 Apr 2019 09:27:26 +0000 (11:27 +0200)]
Merge pull request #5260 from akallabeth/rail_spec_update
Rail spec update
Martin Fleisz [Mon, 29 Apr 2019 09:27:06 +0000 (11:27 +0200)]
Merge pull request #5306 from akallabeth/gfx_server_caps_input_checks
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
Armin Novak [Fri, 26 Apr 2019 11:14:30 +0000 (13:14 +0200)]
Fixed typo in RAIL_ZORDER_SYNC
Armin Novak [Fri, 15 Mar 2019 07:39:46 +0000 (08:39 +0100)]
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
Pascal J. Bourguignon [Fri, 26 Apr 2019 07:10:41 +0000 (09:10 +0200)]
5360 segfault using smartcard without any readers (#5361)
* Fix: corrected test for astyle.
* Fix: added test for NULL readers returned by ConvertFromUnicode.
Mati Shabtay [Thu, 25 Apr 2019 08:55:24 +0000 (11:55 +0300)]
rail_orders.c: Fix wrong callback call on server handshake ex recv (#5345)
sgtatham [Thu, 25 Apr 2019 08:54:10 +0000 (09:54 +0100)]
xf_cliprdr: detect null terminators more reliably. (#5353)
Clipboard formats containing plain text are specified to be terminated
by a \0 character in MS's documentation on standard clipboard formats:
https://docs.microsoft.com/en-us/windows/desktop/dataxchg/standard-clipboard-formats
xf_cliprdr_server_format_data_response receives pasted data from the
server to transfer to the client, in a sufficiently raw form that the
\0 terminator is still present, so it has to remove it. It does so by
checking only at the very end of the data. But I've observed that when
pasting out of at least one Windows program (namely Outlook 1903 on
Windows 10), the intended paste data arrives in this function followed
by \0 and then a spurious \n. In that situation the null-terminator
removal will fail to notice the \0, and will leave both bogus
characters on the end of the paste.
Fixed by using memchr to find the _first_ \0 in the paste data, which
should not lose any actually intentional data because it's in
accordance with the spec above.
David Fort [Tue, 23 Apr 2019 07:56:16 +0000 (09:56 +0200)]
Merge pull request #5354 from ffontaine/master
xf_floatbar.c: fix build without Xfixes
Fabrice Fontaine [Thu, 18 Apr 2019 21:40:52 +0000 (23:40 +0200)]
xf_floatbar.c: fix build without Xfixes
Remove unneeded include on Xfixes.h as it is not always available and
not used in xf_floatbar.c
Fixes:
- http://autobuild.buildroot.org/results/
69245e574787bada718c52c805ec137041dc233d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Armin Novak [Thu, 11 Apr 2019 13:30:05 +0000 (15:30 +0200)]
Unified update->BeginPaint and update->EndPaint
Since these functions were called from 2 different threads
(main thread or dynamic channel) depending on fastpath or
gfx channel use lock between these.
If not locked the invalid region may be accessed from both
threads and lead to crashes as experienced with nightly
df280a7ff
byteboon [Mon, 8 Apr 2019 07:42:02 +0000 (00:42 -0700)]
FreeRDP#5329 if using OldLicenseBehaviour, don't try to save the Cal since we're not going to try to load it (#5330)
Kubistika [Mon, 8 Apr 2019 07:26:46 +0000 (10:26 +0300)]
Fix segfault when IniFile_Load is called with invalid input (#5331)
* Fix segfault when IniFile_Load is called with invalid input
* Fix leak in TestIni.c third testcase
* TestIni.c: Refactor in order to avoid some old compilers errors
David Fort [Fri, 5 Apr 2019 12:13:03 +0000 (14:13 +0200)]
Merge pull request #5240 from akallabeth/sign_compare_fixes_v2
Sign compare fixes v2
Mati Shabtay [Fri, 5 Apr 2019 11:37:51 +0000 (14:37 +0300)]
Added optional PreFrameAck callback to RdpgfxClientContext (#5303)
* RdpgfxClientContext: Add PreFrameAck callback
* client/rdpgfx_main.c: Call PreFrameAck callback before acking frame
* client/rdpgfx_main.c: Fix windows_msbuild_vs2010 CI build
* client/rdpgfx_main.c: Fix error logs log level
Armin Novak [Fri, 5 Apr 2019 08:04:01 +0000 (10:04 +0200)]
Remove unnecessary clipboard data copy.
David Fort [Fri, 5 Apr 2019 07:36:53 +0000 (09:36 +0200)]
clipboard: correctly handle flags during renegociatiion (#5323)
Armin Novak [Fri, 5 Apr 2019 07:28:09 +0000 (09:28 +0200)]
Fixed ntlm_av_pair_get_len return, no signed value required
Armin Novak [Fri, 5 Apr 2019 07:22:50 +0000 (09:22 +0200)]
Fixed argument pointer type cast
Armin Novak [Fri, 5 Apr 2019 07:22:35 +0000 (09:22 +0200)]
Fixed sign issues
Armin Novak [Thu, 21 Feb 2019 15:32:19 +0000 (16:32 +0100)]
Fixed unnecessary casts in freerdp_image_copy.
Armin Novak [Wed, 20 Feb 2019 12:53:25 +0000 (13:53 +0100)]
Disabled -Wimplicit-fallthrough for instances where its use is intended.
Armin Novak [Wed, 20 Feb 2019 12:52:39 +0000 (13:52 +0100)]
Fixed broken implicit fallthrough
Armin Novak [Fri, 8 Feb 2019 12:45:01 +0000 (13:45 +0100)]
Removed duplicate argument checks.
Armin Novak [Fri, 8 Feb 2019 11:19:57 +0000 (12:19 +0100)]
Fixed GetModuleFileNameW.
Armin Novak [Fri, 8 Feb 2019 11:01:33 +0000 (12:01 +0100)]
Fixed review remarks.
Armin Novak [Fri, 8 Feb 2019 10:46:02 +0000 (11:46 +0100)]
Fixed SleepEx return value and added log messages for unimplemented features.
Armin Novak [Fri, 8 Feb 2019 08:18:16 +0000 (09:18 +0100)]
Fixed unused argument warnings for tests.
Armin Novak [Fri, 8 Feb 2019 08:15:04 +0000 (09:15 +0100)]
Fixed NULL argument warning.
Armin Novak [Fri, 8 Feb 2019 08:05:59 +0000 (09:05 +0100)]
Added event name to handle.
Armin Novak [Fri, 8 Feb 2019 08:05:36 +0000 (09:05 +0100)]
Fixed NULL argument warning.
Armin Novak [Thu, 7 Feb 2019 16:53:32 +0000 (17:53 +0100)]
Fixed unused argument warnings.
Armin Novak [Thu, 7 Feb 2019 16:53:21 +0000 (17:53 +0100)]
Fixed unused argument warnings.
Armin Novak [Thu, 7 Feb 2019 16:42:11 +0000 (17:42 +0100)]
Silenced unused parameter warnings, added log messages.
Armin Novak [Thu, 7 Feb 2019 16:41:34 +0000 (17:41 +0100)]
Silenced unused parameter warnings, added log messages.
Armin Novak [Thu, 7 Feb 2019 16:41:01 +0000 (17:41 +0100)]
Implemented GetModuleFileNameW