platform/upstream/dotnet/runtime.git
7 years agoFix issue dotnet/coreclr#11447.
Pat Gavlin [Mon, 8 May 2017 19:17:42 +0000 (12:17 -0700)]
Fix issue dotnet/coreclr#11447.

This issue was caused by the code for PInvoke frame initialization reading
from the stub argument register after it had been trashed by prior
instructions. This change fixes this issue by inserting the PInvoke
frame initialization at the beginning of the scratch block into which it
is inserted rather than at the end.

Note that a more correct fix here would be to represent the stub
argument as a lclVar rather than a physical register; that work is
tracked by dotnet/coreclr#11450.

Commit migrated from https://github.com/dotnet/coreclr/commit/673242edd0a0939e0e4cd22d6a217dbd9295ba00

7 years agoMinor typo corrected (dotnet/coreclr#11444)
Sebastian Lauber [Mon, 8 May 2017 16:08:27 +0000 (18:08 +0200)]
Minor typo corrected (dotnet/coreclr#11444)

Commit migrated from https://github.com/dotnet/coreclr/commit/4a9af731456a2b72e90d34f79824602cb455f5cd

7 years agoMake Debugger class static (dotnet/coreclr#11439)
Justin Van Patten [Mon, 8 May 2017 03:42:41 +0000 (20:42 -0700)]
Make Debugger class static (dotnet/coreclr#11439)

* Make Debugger class static

It's static in the .NET Standard and .NET Core refs, and in CoreRT's
implementation, so make it static in the CoreCLR implementation as well.
Also, minor cleanup while making changes here.

Commit migrated from https://github.com/dotnet/coreclr/commit/487cb23e80d8cc02e21f1497d1c3c16b5ff1f367

7 years agoLog Events to EventPipe on Linux (dotnet/coreclr#11433)
Brian Robbins [Sat, 6 May 2017 19:36:08 +0000 (12:36 -0700)]
Log Events to EventPipe on Linux (dotnet/coreclr#11433)

* Implement the EventPipe object model for providers and events.

* Plumb Runtime Events into EventPipe (dotnet/coreclr#11145)

Plumb runtime ETW events into the EventPipe.

* Fix bug where all events except for SampleProfiler events were never enabled.

* Plumb EventPipeEventInstance through the EventPipe.

* Implement EventPipeFile and FastSerializer.

* Write event contents to the EventPipeFile.

* Only build EventPipe on Linux.

* Conditionally add a sentinel value marking event end.

* Send SampleProfiler events to the EventPipeFile.

* Fix provider ID printing to JSON file.

* Write the start date/time, timestamp, and clock frequency into the trace file.

* Support unloading of EventPipeProviders.

* Handle failure cases when we can't walk the stack or are shutting down.

* Fix a bug where we pass a null src pointer to memcpy.

Commit migrated from https://github.com/dotnet/coreclr/commit/72ac46450bec8ea88ed023d9c1faf5a04556c834

7 years agoDelete dead code (dotnet/coreclr#11431)
Jan Kotas [Sat, 6 May 2017 18:03:27 +0000 (11:03 -0700)]
Delete dead code (dotnet/coreclr#11431)

Commit migrated from https://github.com/dotnet/coreclr/commit/3ababc21ab334a2e37c6ba4115c946ea26a6f2fb

7 years agoDelete moved file
Jan Kotas [Sat, 6 May 2017 14:18:56 +0000 (07:18 -0700)]
Delete moved file

Commit migrated from https://github.com/dotnet/coreclr/commit/278837ee1072f60a01663dcf09367bd2fd86dcae

7 years agoDelete moved files and fix build breaks
Jan Kotas [Sat, 6 May 2017 03:48:28 +0000 (20:48 -0700)]
Delete moved files and fix build breaks

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/c853b030a2701b39cb098ea1facfd8721bba1cf1

7 years agoMove more files to shared CoreLib partition (dotnet/coreclr#11429)
Jan Kotas [Sat, 6 May 2017 03:32:38 +0000 (20:32 -0700)]
Move more files to shared CoreLib partition (dotnet/coreclr#11429)

Commit migrated from https://github.com/dotnet/coreclr/commit/7babb04d94c58b8639ecbe6f9c8bef0a5d88cf05

7 years agoRemove ArrayList (dotnet/coreclr#11426)
Justin Van Patten [Fri, 5 May 2017 23:56:49 +0000 (16:56 -0700)]
Remove ArrayList (dotnet/coreclr#11426)

Also cleanup FEATURE_NONGENERIC_COLLECTIONS while on it.

Commit migrated from https://github.com/dotnet/coreclr/commit/bb70a71ee1aa9c5ff6b4ff0851a8e622bb23c1ac

7 years agoMerge pull request dotnet/coreclr#11428 from DrewScoggins/LeanRuns
Drew Scoggins [Fri, 5 May 2017 23:44:00 +0000 (08:44 +0900)]
Merge pull request dotnet/coreclr#11428 from DrewScoggins/LeanRuns

Fix typo in perf.groovy

Commit migrated from https://github.com/dotnet/coreclr/commit/99143691275477103b8ec0b4bc283b1062ee91fd

7 years agoFix typo in perf.groovy
Drew Scoggins [Fri, 5 May 2017 23:07:27 +0000 (16:07 -0700)]
Fix typo in perf.groovy

Had a typo where I was passing deafult instead of default as a flag to
the collection harness.  This fixes that.

Commit migrated from https://github.com/dotnet/coreclr/commit/1e14842f722c9e9335c0e709fc6ffbbd9cb81381

7 years ago[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (dotnet/coreclr...
Steve MacLean [Fri, 5 May 2017 23:16:37 +0000 (19:16 -0400)]
[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (dotnet/coreclr#11375)

* [Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP
* [Arm64/Unix] Enable FEATURE_MANUALLY_MANAGED_CARD_BUNDLES

Commit migrated from https://github.com/dotnet/coreclr/commit/060dc1d1e6d89d999f0741e5daf99f5fa564772f

7 years agoAdd a GC Reliability Framework job to the CI (dotnet/coreclr#11280)
Sean Gillespie [Fri, 5 May 2017 22:57:25 +0000 (15:57 -0700)]
Add a GC Reliability Framework job to the CI (dotnet/coreclr#11280)

* Add GC Reliability Framework CI job

* Three changes:
  1) To address offline feedback, update the CI trigger phase document
  and the GC testing instructions
  2) Set the timeout for GC RF CI jobs to 24 hours, so they don't time
  out (they will run for 15 hours by default)
  3) Refactor "scenario == 'gc_reliability_framework' to its own method
  so that new GC RF scenarios can easily and cleanly be added if
  desired in the future

Commit migrated from https://github.com/dotnet/coreclr/commit/30a09322644a5512315d34bbb4fccfddf5795f0f

7 years agoMerge pull request dotnet/coreclr#11425 from jashook/build_arm64_tests
Jarret Shook [Fri, 5 May 2017 21:35:56 +0000 (14:35 -0700)]
Merge pull request dotnet/coreclr#11425 from jashook/build_arm64_tests

Build tests for arm64 runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/624378eb5a90386777d05acda5d374af925f2756

7 years agoAdd compact entry points for ARM (dotnet/coreclr#11109)
gbalykov [Fri, 5 May 2017 20:07:44 +0000 (23:07 +0300)]
Add compact entry points for ARM (dotnet/coreclr#11109)

Commit migrated from https://github.com/dotnet/coreclr/commit/980c1204d68f54be77eb840cc3f2e4fe2df42a26

7 years agoBuild tests for arm64 runs.
jashook [Fri, 5 May 2017 20:06:31 +0000 (13:06 -0700)]
Build tests for arm64 runs.

This has been separated to allow coreclr dotnet/coreclr#11423 to be tested
incrementally in the PR.

Commit migrated from https://github.com/dotnet/coreclr/commit/c1f8ef3fea431070e836ce2fff9141d3e5af865d

7 years agoUpdate CoreClr to preview2-25305-03 (dotnet/coreclr#11421)
dotnet bot [Fri, 5 May 2017 19:54:49 +0000 (12:54 -0700)]
Update CoreClr to preview2-25305-03 (dotnet/coreclr#11421)

Commit migrated from https://github.com/dotnet/coreclr/commit/f32af15fd8c5ceae9ac10b5d2ef0eed9c66ca4e3

7 years agoReturn null from CultureData.GetLocaleInfoEx (dotnet/coreclr#11422)
Pedro Lamas [Fri, 5 May 2017 19:30:05 +0000 (20:30 +0100)]
Return null from CultureData.GetLocaleInfoEx (dotnet/coreclr#11422)

Commit migrated from https://github.com/dotnet/coreclr/commit/1a3dfa8c8405fa56ea3de897c43d79650463e74c

7 years agoFix build breaks
Jan Kotas [Fri, 5 May 2017 15:47:11 +0000 (08:47 -0700)]
Fix build breaks

Commit migrated from https://github.com/dotnet/coreclr/commit/712cd0668801e2db3e78a49bbf9c5cb53011bc5f

7 years agoSwitch over to shared Interop.Globalization.cs on Windows (dotnet/coreclr#3528)
Jan Kotas [Fri, 5 May 2017 15:03:16 +0000 (08:03 -0700)]
Switch over to shared Interop.Globalization.cs on Windows (dotnet/coreclr#3528)

- Match CoreCLR refactoring done for invariant culture
- Use actual unsafe types in the interop signatures instead of opaque IntPtr
- Use Unsafe.As to get a pointer to stack allocated structure instead of allocating GCHandles
- Remove use of NativeCallable for enumeration to make the same code work on both CoreRT and CoreCLR. (I have kelp the NativeCallable annotations commented out so that we can switch back to them once C# gets the intrinsics to make it possible.)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/8026a02a3abb3f83f666e5eac8a6ddce20c70e77

7 years agoMerge pull request dotnet/coreclr#11405 from rartemev/issue_10857_addingseq
Roman Artemev [Fri, 5 May 2017 18:17:42 +0000 (11:17 -0700)]
Merge pull request dotnet/coreclr#11405 from rartemev/issue_10857_addingseq

Fixed memory instruction selection for integer register which contants  simd8 type in ELT hook prolog

Commit migrated from https://github.com/dotnet/coreclr/commit/d37d98054f535fcaba161cd533c034dfb80342f1

7 years agoPath.GetDirectoryName() throw exception when path is empty or has only white spaces...
Santiago Fernandez Madero [Fri, 5 May 2017 18:12:21 +0000 (11:12 -0700)]
Path.GetDirectoryName() throw exception when path is empty or has only white spaces (dotnet/coreclr#11403)

* Throw exception when path is empty or has only white spaces

Commit migrated from https://github.com/dotnet/coreclr/commit/d9722358f905a6ed0edcb0fccded66bb6a64fa0c

7 years agoRemoved Dictionary<TKey, TValue>.GetValueOrDefault Methods (dotnet/coreclr#11388)
Tarun Pothulapati [Fri, 5 May 2017 17:49:59 +0000 (17:49 +0000)]
Removed Dictionary<TKey, TValue>.GetValueOrDefault Methods (dotnet/coreclr#11388)

* Removed Dictionary.GetValueOrDefault Methods and the method calls in Rtpe.cs,CustomAttribute.cs

* Replaced the Dictionary.GetValueOrDefault Methods

* Used !s_pca.ContainsKey(caType) instead of s_pca.ContainsKey(caType) == false

Commit migrated from https://github.com/dotnet/coreclr/commit/0581f34ca9b0cd27abf03a4d0232ca59250ab9f0

7 years agoAdd lean run support to CoreCLR perf (dotnet/coreclr#11347)
Drew Scoggins [Fri, 5 May 2017 17:39:15 +0000 (02:39 +0900)]
Add lean run support to CoreCLR perf (dotnet/coreclr#11347)

In the xunit performance harness we added support for a "lean" run which
only runs the stopwatch to collect duration and none of the ETW
providers are turned on.  This adds support in the automation for doing
runs that use this lean feature.

Commit migrated from https://github.com/dotnet/coreclr/commit/803b48ca0f6e3097a3453d1d15d3765704461651

7 years agoMerge pull request dotnet/coreclr#11411 from justinvp/delegate_opequality
Stephen Toub [Fri, 5 May 2017 16:35:21 +0000 (12:35 -0400)]
Merge pull request dotnet/coreclr#11411 from justinvp/delegate_opequality

Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks

Commit migrated from https://github.com/dotnet/coreclr/commit/c84237673b6167ee964ba6bea00041dac9dca3e2

7 years agoUpdate CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (dotnet...
dotnet bot [Fri, 5 May 2017 15:19:07 +0000 (08:19 -0700)]
Update CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (dotnet/coreclr#11384)

Commit migrated from https://github.com/dotnet/coreclr/commit/5011a33a24866e14dc7b953bec798ff03901bc2b

7 years agoFixed issue dotnet/coreclr#11383 (dotnet/coreclr#11385)
sergey ignatov [Fri, 5 May 2017 15:12:07 +0000 (18:12 +0300)]
Fixed issue dotnet/coreclr#11383 (dotnet/coreclr#11385)

Commit migrated from https://github.com/dotnet/coreclr/commit/f0a850b785d73740add815329409183de23a2c35

7 years agoMerge pull request dotnet/coreclr#11361 from mikedn/imp-strlen-except
Bruce Forstall [Fri, 5 May 2017 14:24:49 +0000 (07:24 -0700)]
Merge pull request dotnet/coreclr#11361 from mikedn/imp-strlen-except

Add missing GTF_EXCEPT when importing string length intrinsic

Commit migrated from https://github.com/dotnet/coreclr/commit/f3bf62697c63e1bc4c383b9af82d0d3e42ac2afd

7 years agoFix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395) again (dotnet/corecl...
Mike McLaughlin [Fri, 5 May 2017 05:48:21 +0000 (22:48 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395) again (dotnet/coreclr#11415)

There was a simple msbuild property.

Issue dotnet/coreclr#11381

Commit migrated from https://github.com/dotnet/coreclr/commit/f1b1172f132acb9a6d8280eb9088ce52868c8956

7 years agoAdd missing GTF_EXCEPT when importing string length intrinsic
Mike Danes [Wed, 3 May 2017 05:35:13 +0000 (08:35 +0300)]
Add missing GTF_EXCEPT when importing string length intrinsic

Commit migrated from https://github.com/dotnet/coreclr/commit/331c37eb26ca29413dffe6997d5514492d5dbba8

7 years agoMove UnmanagedMemoryStream and related types to shared CoreLib partition (dotnet...
Jan Kotas [Fri, 5 May 2017 04:12:20 +0000 (21:12 -0700)]
Move UnmanagedMemoryStream and related types to shared CoreLib partition (dotnet/coreclr#11409)

Commit migrated from https://github.com/dotnet/coreclr/commit/ceb81e1a78e8415cddb79f5aaba96108fe7cb2e7

7 years agoAdd new test for COMPlus_TailcallStress=1 bug, currently disabled (dotnet/coreclr...
Bruce Forstall [Fri, 5 May 2017 03:55:26 +0000 (20:55 -0700)]
Add new test for COMPlus_TailcallStress=1 bug, currently disabled (dotnet/coreclr#11410)

Add new test for COMPlus_TailcallStress=1 bug, currently disabled

Commit migrated from https://github.com/dotnet/coreclr/commit/4d12501d34d327d5cb7347f1b3af1c21f20a3c1c

7 years agoMerge pull request dotnet/coreclr#11401 from wtgodbe/DeleteNis
William Godbe [Fri, 5 May 2017 02:54:53 +0000 (19:54 -0700)]
Merge pull request dotnet/coreclr#11401 from wtgodbe/DeleteNis

Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs

Commit migrated from https://github.com/dotnet/coreclr/commit/6952aaaec5f6ff760e1281b3e56b4af29639b13b

7 years agoFixed memory instruction selector for integer register which contants simd8 type
Roman Artemev [Thu, 4 May 2017 20:14:15 +0000 (13:14 -0700)]
Fixed memory instruction selector for integer register which contants simd8 type

Commit migrated from https://github.com/dotnet/coreclr/commit/27e1de2e2da551a5ed64c411bbeb6ba59ec155ac

7 years agoUpdate contributing-workflow.md
Karel Zikmund [Thu, 4 May 2017 23:23:21 +0000 (16:23 -0700)]
Update contributing-workflow.md

Commit migrated from https://github.com/dotnet/coreclr/commit/4ce7c65a1c0ccb457abaf38217d8ca6f5383bd49

7 years agoRefactor arm32/arm64 per-node codegen into functions (dotnet/coreclr#11377)
Bruce Forstall [Thu, 4 May 2017 23:07:26 +0000 (16:07 -0700)]
Refactor arm32/arm64 per-node codegen into functions (dotnet/coreclr#11377)

These new functions can sometimes be shared, as they are identical or
virtually so.

In addition, the driver function genCodeForTreeNode() has been
made common.

Commit migrated from https://github.com/dotnet/coreclr/commit/1aa7ca424deb65c510bc8b7e3ee34039c9f0e6a1

7 years agoRename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
wtgodbe [Thu, 4 May 2017 18:57:51 +0000 (11:57 -0700)]
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs

Commit migrated from https://github.com/dotnet/coreclr/commit/cd37819de42a5f208c9d7b9bcf08b9f6d928e1a2

7 years agoFix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395)
Mike McLaughlin [Thu, 4 May 2017 22:19:57 +0000 (15:19 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (dotnet/coreclr#11395)

Issue dotnet/coreclr#11381

Commit migrated from https://github.com/dotnet/coreclr/commit/78b34158ef2048e3559a8ca782be609b94d98ed4

7 years agoUpdate first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:09:55 +0000 (15:09 -0700)]
Update first-class-structs.md

Commit migrated from https://github.com/dotnet/coreclr/commit/2928ea3a1c0cfbcb6945f1c4146b6fbee117d942

7 years agoUpdate first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:07:37 +0000 (15:07 -0700)]
Update first-class-structs.md

Commit migrated from https://github.com/dotnet/coreclr/commit/c45a32f9fe9fbbde5e33acab90785a36ffdacfd4

7 years agoUse ReferenceEquals instead of Delegate.op_Equality for sentinel checks
Justin Van Patten [Thu, 4 May 2017 22:05:38 +0000 (15:05 -0700)]
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks

The reference equality check is more efficient than
Delegate.op_Equality.

Commit migrated from https://github.com/dotnet/coreclr/commit/e42e2ce0d6422fc74175e032842aaa5bb38e2112

7 years agoRemove UnmanagedMemoryStream overflow checks. (dotnet/coreclr#11376)
Ian Hays [Thu, 4 May 2017 22:01:16 +0000 (15:01 -0700)]
Remove UnmanagedMemoryStream overflow checks. (dotnet/coreclr#11376)

* Remove UnmanagedMemoryStream overflow checks.
* Catch negative UMS PositionPointers
* Switch UMS PositionPointer exception order

Commit migrated from https://github.com/dotnet/coreclr/commit/07efb266175e96ebf1c455d2524b410f26b7385e

7 years agoFix ProjectN build break (dotnet/corertdotnet/coreclr#3517)
Jan Kotas [Thu, 4 May 2017 19:37:39 +0000 (12:37 -0700)]
Fix ProjectN build break (dotnet/corertdotnet/coreclr#3517)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/3c17dbc325de61c7899af9d9f019e6d0f561fd19

7 years agoSystem.IO.Path.GetPathRoot string.Empty or whitespace character string should throw...
Viktor Hofer [Thu, 4 May 2017 21:11:33 +0000 (23:11 +0200)]
System.IO.Path.GetPathRoot string.Empty or whitespace character string should throw ArgumentException (dotnet/coreclr#11387)

* GetPathRoot string.Empty and string whitespace throws ArgumentException

* throw in next line

* Refined method description

* Unix impl adjusted

* Indentation

* pr feedback

* Delete Path.Unix.cs

* Adding param to ArgumentException

Commit migrated from https://github.com/dotnet/coreclr/commit/8e99cd8031b2f568ea69116e7cf96d55e32cb7f5

7 years agoReenable MapViewOfFile PAL test1 (dotnet/coreclr#11393)
Jan Vorlicek [Thu, 4 May 2017 20:19:53 +0000 (13:19 -0700)]
Reenable MapViewOfFile PAL test1 (dotnet/coreclr#11393)

This change reenables the test that was having problems on systems when the /tmp
is created on tmpfs file system which doesn't support direct access (unbuffered).
The fix is to explicitly use /var/tmp instead (and /data/local/tmp/ on Android).

Commit migrated from https://github.com/dotnet/coreclr/commit/bae3ded1b302abdb1d0b46346f03162bddadba40

7 years agoRemove stale section on managed debugging. (dotnet/coreclr#11392)
Mike McLaughlin [Thu, 4 May 2017 17:58:58 +0000 (10:58 -0700)]
Remove stale section on managed debugging. (dotnet/coreclr#11392)

Commit migrated from https://github.com/dotnet/coreclr/commit/1ff9062d235630a3a47bffa6459549c669432c4a

7 years agoMerge pull request dotnet/coreclr#11370 from CarolEidt/ILOffsetDump
Carol Eidt [Thu, 4 May 2017 17:49:09 +0000 (10:49 -0700)]
Merge pull request dotnet/coreclr#11370 from CarolEidt/ILOffsetDump

Dump GT_IL_OFFSET value in hex

Commit migrated from https://github.com/dotnet/coreclr/commit/e9582650e72e9b100d2bff187a50005daa0231a9

7 years agoDocument Linux libnuma dependency (dotnet/coreclr#11367)
Tom Deseyn [Thu, 4 May 2017 15:13:22 +0000 (17:13 +0200)]
Document Linux libnuma dependency (dotnet/coreclr#11367)

Commit migrated from https://github.com/dotnet/coreclr/commit/e3b89a4abce3afb23ef92757cb77c7ade8d77862

7 years agoDisable symbol package MyGet publish on release/* (dotnet/coreclr#11372)
Davis Goodin [Thu, 4 May 2017 14:17:24 +0000 (09:17 -0500)]
Disable symbol package MyGet publish on release/* (dotnet/coreclr#11372)

Commit migrated from https://github.com/dotnet/coreclr/commit/4eb6cb798ef238d8a09e8b85d94da281ba95acf7

7 years agoDelete moved file
Jan Kotas [Thu, 4 May 2017 03:35:14 +0000 (20:35 -0700)]
Delete moved file

Commit migrated from https://github.com/dotnet/coreclr/commit/9ca09de5f54e5edb2733523fad3a52b01700e3de

7 years agoMerge pull request dotnet/corertdotnet/coreclr#3506 from dotnet/nmirror
Jan Kotas [Thu, 4 May 2017 01:58:57 +0000 (18:58 -0700)]
Merge pull request dotnet/corertdotnet/coreclr#3506 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/48a8b9dcddaee0cf74731db3590d1d4c645954df

7 years agoUpdate CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (dotnet...
dotnet bot [Thu, 4 May 2017 04:58:52 +0000 (21:58 -0700)]
Update CoreClr, CoreFx to preview2-25303-03, preview2-25303-04, respectively (dotnet/coreclr#11354)

Commit migrated from https://github.com/dotnet/coreclr/commit/e8eb00ebe44dffda27959fc0913fd2b8bb2667d2

7 years agoCreatedump fixes and cleanup. (dotnet/coreclr#11368)
Mike McLaughlin [Thu, 4 May 2017 00:17:22 +0000 (17:17 -0700)]
Createdump fixes and cleanup. (dotnet/coreclr#11368)

Fixed "with heap" option to actually include all the heaps. The way /proc/$pid/maps
was parsed missed most of the RW data/heap regions.

Added -u/--full full core dump options.

Removed the useless m_memStatus variable in enummem.cpp.

Commit migrated from https://github.com/dotnet/coreclr/commit/3fb9d8d2fe094f09a914d31a551e14fe8a1f2215

7 years ago[Arm64/Unix] Revise JIT_MemSet (dotnet/coreclr#11217)
Steve MacLean [Wed, 3 May 2017 22:52:42 +0000 (18:52 -0400)]
[Arm64/Unix] Revise JIT_MemSet (dotnet/coreclr#11217)

* [Arm64/Unix] Revise JIT_MemSet

Use DC ZVA
Use stp
Correctly handle short set lengths
Simplify code & pseudo code
Use uint*_t to make pseudo code more readable

Commit migrated from https://github.com/dotnet/coreclr/commit/cac4e2e82e63c3d892c935262cfb2b04090acae9

7 years agoAdding System\Runtime\CompilerServices\IsByRefLikeAttribute type (dotnet/coreclr...
Vladimir Sadov [Wed, 3 May 2017 22:22:32 +0000 (15:22 -0700)]
Adding System\Runtime\CompilerServices\IsByRefLikeAttribute type (dotnet/coreclr#11369)

described in: https://github.com/dotnet/corefx/issues/19212

Commit migrated from https://github.com/dotnet/coreclr/commit/8ba07fc124eee6a0fbb6f886e90ffd0628e86e48

7 years agoFix some static analysis warnings
Russ Keldorph [Sun, 30 Apr 2017 13:17:30 +0000 (06:17 -0700)]
Fix some static analysis warnings

Most fixes are just addressing the use of (signed) enum-typed variables
as array indices.  Casting to unsigned allows us to cheaply include the
lower bound checks in the existing upper bound checks.  I would prefer
to force the underlying types of enumerations to be unsigned, but that
is a relatively new C++ feature and could have broader consequences than
I want to risk at this point.

The one other fix to asmparse.cpp just suppresses a warning that, while
technically valid, is not causing a real problem.  Perhaps this will get
better if/when dotnet/coreclr#2305 is addressed.

Commit migrated from https://github.com/dotnet/coreclr/commit/1c7e1f4e0b9d338c209a8e73a00c8e9ab42b22e3

7 years agoDump GT_IL_OFFSET value in hex
Carol Eidt [Wed, 3 May 2017 21:01:44 +0000 (14:01 -0700)]
Dump GT_IL_OFFSET value in hex

Commit migrated from https://github.com/dotnet/coreclr/commit/7409f38936dd332d4b5c08752fc961b2827cf758

7 years agoRemove COMCoverage::nativeCoverBlock (dotnet/coreclr#11364)
Jan Vorlicek [Wed, 3 May 2017 18:57:04 +0000 (11:57 -0700)]
Remove COMCoverage::nativeCoverBlock (dotnet/coreclr#11364)

Remove this unused function and the corresponding references in
ecalllist.h

Commit migrated from https://github.com/dotnet/coreclr/commit/e85c2b298e89147d71605c36d9109f87be2b3079

7 years agoFix Binder NI to IL fallback (dotnet/coreclr#11341)
Steve MacLean [Wed, 3 May 2017 18:24:21 +0000 (14:24 -0400)]
Fix Binder NI to IL fallback (dotnet/coreclr#11341)

* Fix Binder NI to IL fallback

Always try NI first

* Fix Windows warning as error

* [Arm64/Unix] Revise PR per feedback

* More cleanup

Commit migrated from https://github.com/dotnet/coreclr/commit/ef8d1522eb15cb0371f31a9392891c942547a91f

7 years agoPlace precompiled SPC.dll in native assets folder. (dotnet/coreclr#11359)
Gaurav Khanna [Wed, 3 May 2017 17:50:34 +0000 (10:50 -0700)]
Place precompiled SPC.dll in native assets folder. (dotnet/coreclr#11359)

Place precompiled SPC.dll in native assets folder.

Commit migrated from https://github.com/dotnet/coreclr/commit/b16c8c73ce17c4ffb6189467def30c2e70f57a91

7 years agoFix load from (dotnet/coreclr#11342)
Gaurav Khanna [Wed, 3 May 2017 15:35:56 +0000 (08:35 -0700)]
Fix load from (dotnet/coreclr#11342)

* Add LoadFrom dependencies to the LoadFrom list

* Add a comment

Commit migrated from https://github.com/dotnet/coreclr/commit/45132a72dce3aeadff09ce8fbee6a663456cda99

7 years agoImplement Type.IsTypeDefinition property on CoreCLR (dotnet/coreclr#11355)
Atsushi Kanamori [Wed, 3 May 2017 13:40:42 +0000 (06:40 -0700)]
Implement Type.IsTypeDefinition property on CoreCLR (dotnet/coreclr#11355)

This api was just approved.

https://github.com/dotnet/corefx/issues/17345

Commit migrated from https://github.com/dotnet/coreclr/commit/ff2455e3bc3bf39301b71eea234f11c5d56b395d

7 years agoRevert "[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest"
Russ Keldorph [Wed, 3 May 2017 03:59:24 +0000 (20:59 -0700)]
Revert "[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest"

This reverts commit dotnet/coreclr@2ec8b5c2cc6d68ca02eb743e679997a8f11c90aa.

Commit migrated from https://github.com/dotnet/coreclr/commit/01fbb88b8c3fc2bcfa06508c5d18567026ccdd26

7 years agoMerge pull request dotnet/coreclr#11362 from DrewScoggins/FixSmoketest
Drew Scoggins [Wed, 3 May 2017 07:08:18 +0000 (16:08 +0900)]
Merge pull request dotnet/coreclr#11362 from DrewScoggins/FixSmoketest

Fix triggering of perf correctness runs

Commit migrated from https://github.com/dotnet/coreclr/commit/e43d3798c1cf07a65b67880459140d25ead13a4e

7 years agoFix triggering of perf correctness runs
Drew Scoggins [Wed, 3 May 2017 06:55:33 +0000 (23:55 -0700)]
Fix triggering of perf correctness runs

When I made the change to have the correctness runs fire in a PR without
the trigger phrase I accidentally did it for all PR's not just for the
smoketest runs.  This change fixes that.

Commit migrated from https://github.com/dotnet/coreclr/commit/a9900197ac9b92e164523d6675d1c65015bc8eba

7 years agoMerge pull request dotnet/coreclr#11180 from DrewScoggins/AddCorrectnessRuns
Drew Scoggins [Wed, 3 May 2017 04:44:46 +0000 (13:44 +0900)]
Merge pull request dotnet/coreclr#11180 from DrewScoggins/AddCorrectnessRuns

Add smoketest for performance tests

Commit migrated from https://github.com/dotnet/coreclr/commit/2a105be2593752afb338ad5e02b2031f6e40d679

7 years agoAdd smoketest for performance tests
Drew Scoggins [Mon, 24 Apr 2017 18:36:27 +0000 (11:36 -0700)]
Add smoketest for performance tests

This adds a run that will fire on the set of Azure VMs and will only run
for one interation.  This along with the changes to fail a performance
run if a test fails will allow us to start gating checkins on the
performance tests still running.

Commit migrated from https://github.com/dotnet/coreclr/commit/6ed8e17a41891b9d149cbe423eea5f779f8591d9

7 years agoMerge pull request dotnet/coreclr#11340 from ericstj/fixCrossTargetFolder
Eric StJohn [Tue, 2 May 2017 23:39:14 +0000 (16:39 -0700)]
Merge pull request dotnet/coreclr#11340 from ericstj/fixCrossTargetFolder

Fix folder name for cross-targeting assets

Commit migrated from https://github.com/dotnet/coreclr/commit/0ac3a15303769277d73d6c57bf1714c649fb1fec

7 years ago[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest
Hyeongseok Oh [Wed, 26 Apr 2017 06:44:16 +0000 (15:44 +0900)]
[ARM32/Linux] Copy tests.zip only for CI test and use x86 unittest

- Copy tests.zip only from x86 Windows build for CI test
- Use x86 unittest instead of x64: 32bit architecture

Commit migrated from https://github.com/dotnet/coreclr/commit/2ec8b5c2cc6d68ca02eb743e679997a8f11c90aa

7 years agoEnable Marshal.SecureStringToBSTR and Marshal.ZeroFreeBSTR on Unix (dotnet/coreclr...
John Bottenberg [Tue, 2 May 2017 20:54:52 +0000 (13:54 -0700)]
Enable Marshal.SecureStringToBSTR and Marshal.ZeroFreeBSTR on Unix (dotnet/coreclr#11234)

Commit migrated from https://github.com/dotnet/coreclr/commit/746495f70725ed14ffbbc4ec53f32dc4010c0b0a

7 years agoMerge pull request dotnet/coreclr#11336 from wtgodbe/TestingOnLinux
William Godbe [Tue, 2 May 2017 20:34:51 +0000 (13:34 -0700)]
Merge pull request dotnet/coreclr#11336 from wtgodbe/TestingOnLinux

Update Unix test instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/12d91f215cdba670a954c841a3fbb026215ccbe0

7 years agoUpdate Unix test instructions
wtgodbe [Tue, 2 May 2017 19:10:00 +0000 (12:10 -0700)]
Update Unix test instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/3a045cbb0e5abd8af2c0310fc3db9f68b9d4aa13

7 years agoFix folder name for cross-targeting assets
Eric St. John [Tue, 2 May 2017 20:16:52 +0000 (13:16 -0700)]
Fix folder name for cross-targeting assets

Commit migrated from https://github.com/dotnet/coreclr/commit/7c53fc2cee6f0a37db8a7d797c8cd2482c96cef6

7 years agoEnable LoadFrom to pickup assemblies next to requesting assembly (dotnet/coreclr...
Gaurav Khanna [Tue, 2 May 2017 20:14:01 +0000 (13:14 -0700)]
Enable LoadFrom to pickup assemblies next to requesting assembly (dotnet/coreclr#11333)

* Enable LoadFrom to pickup assemblies from next to requestor

* Make early out explicit

Commit migrated from https://github.com/dotnet/coreclr/commit/6fe0bf5cd4921c9c3f0c183c04653d711fd442b0

7 years agoMerge pull request dotnet/coreclr#11329 from BruceForstall/RefactorArmCodegen
Bruce Forstall [Tue, 2 May 2017 18:28:38 +0000 (11:28 -0700)]
Merge pull request dotnet/coreclr#11329 from BruceForstall/RefactorArmCodegen

Refactor arm32/arm64 codegen

Commit migrated from https://github.com/dotnet/coreclr/commit/46d03758b52d43d35b54038472c5942762aa8c18

7 years agoUpdate CoreFx to preview2-25302-03 (dotnet/coreclr#11331)
dotnet bot [Tue, 2 May 2017 18:21:36 +0000 (11:21 -0700)]
Update CoreFx to preview2-25302-03 (dotnet/coreclr#11331)

Commit migrated from https://github.com/dotnet/coreclr/commit/622c6a097d94341d354938ea9014c4f279c9f405

7 years agoSurgically remove unsupported tailcall cases
Russ Keldorph [Mon, 1 May 2017 16:57:21 +0000 (09:57 -0700)]
Surgically remove unsupported tailcall cases

Rather than disabling tailcall tests entirely, surgically remove the
failing cases so the remaining cases can be enabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/c8b635f1e0058b4147d6d89efeb7464e97d03dc3

7 years agoUpdate CoreClr, CoreFx to preview2-25302-02, preview2-25302-01, respectively (dotnet...
dotnet bot [Tue, 2 May 2017 14:23:21 +0000 (07:23 -0700)]
Update CoreClr, CoreFx to preview2-25302-02, preview2-25302-01, respectively (dotnet/coreclr#11326)

Commit migrated from https://github.com/dotnet/coreclr/commit/503c1d3fb0fcf7cdec24e28dd4f7d66b8c8d88e7

7 years agoAdded missing icu headers for Android (dotnet/coreclr#11325)
Cyd Haselton [Tue, 2 May 2017 11:52:46 +0000 (06:52 -0500)]
Added missing icu headers for Android (dotnet/coreclr#11325)

urename.h and ustring.h contain the u_stncpy and its definition.
If they are not in the list of icushim.h headers, Android build fails.

Commit migrated from https://github.com/dotnet/coreclr/commit/eefe7a195cd1e36b9b0d16761b711061b5f3705f

7 years agoFix assert
Bruce Forstall [Tue, 2 May 2017 06:52:12 +0000 (23:52 -0700)]
Fix assert

Commit migrated from https://github.com/dotnet/coreclr/commit/942c5ac3bb1f73f2262dd828c74faf59b932f88a

7 years agoFix rgTail corruption in rare scavenging cases [Desktop port]. (dotnet/coreclr#11327)
Aditya Mandaleeka [Tue, 2 May 2017 05:03:25 +0000 (22:03 -0700)]
Fix rgTail corruption in rare scavenging cases [Desktop port]. (dotnet/coreclr#11327)

Commit migrated from https://github.com/dotnet/coreclr/commit/363206f312a73bbf6c2093d78acad58c060ca0c7

7 years agoPartial revert "Move a few more files to shared CoreLib partition" (dotnet/coreclr...
Jan Kotas [Tue, 2 May 2017 03:10:26 +0000 (20:10 -0700)]
Partial revert "Move a few more files to shared CoreLib partition" (dotnet/coreclr#11328)

Revert change from Hashtable to Dictionary

Commit migrated from https://github.com/dotnet/coreclr/commit/9501a3b59923bf9c1fea780dc97a342692a8c2ea

7 years agoFormatting
Bruce Forstall [Tue, 2 May 2017 01:50:16 +0000 (18:50 -0700)]
Formatting

Commit migrated from https://github.com/dotnet/coreclr/commit/121da5fd07ca2034cef5e6f73d65901039cd79c6

7 years agoRefactor GT_NEG/GT_NOT
Bruce Forstall [Tue, 2 May 2017 01:49:13 +0000 (18:49 -0700)]
Refactor GT_NEG/GT_NOT

Commit migrated from https://github.com/dotnet/coreclr/commit/0c9f07fffb14476d904e0fad3bbfec8071c4ad4d

7 years agoRefactor compares
Bruce Forstall [Tue, 2 May 2017 01:35:27 +0000 (18:35 -0700)]
Refactor compares

Commit migrated from https://github.com/dotnet/coreclr/commit/3bb29c3765f23911c3fefc072a11b3bc45a9fd77

7 years agoRefactor GT_PUTARG_REG
Bruce Forstall [Tue, 2 May 2017 01:19:46 +0000 (18:19 -0700)]
Refactor GT_PUTARG_REG

Commit migrated from https://github.com/dotnet/coreclr/commit/eb7ba2c82eebf6f2d3326b1e95acd6b2e1bd64f8

7 years agoRefactor GT_SWAP
Bruce Forstall [Tue, 2 May 2017 01:10:23 +0000 (18:10 -0700)]
Refactor GT_SWAP

Commit migrated from https://github.com/dotnet/coreclr/commit/5c3d453277d2ecd7954de1c0e613b20639ba4b4b

7 years agoRefactor GT_RETURNTRAP
Bruce Forstall [Tue, 2 May 2017 00:59:38 +0000 (17:59 -0700)]
Refactor GT_RETURNTRAP

Commit migrated from https://github.com/dotnet/coreclr/commit/9dd6896c63be093b785014ace188d7c1927be7de

7 years agoRefactor GT_STOREIND
Bruce Forstall [Tue, 2 May 2017 00:49:21 +0000 (17:49 -0700)]
Refactor GT_STOREIND

Commit migrated from https://github.com/dotnet/coreclr/commit/ab0582bd7c6666e7889f062a9584d7ecf788a883

7 years agoRefactor GT_LCL_VAR and GT_STORE_LCL_VAR
Bruce Forstall [Tue, 2 May 2017 00:32:15 +0000 (17:32 -0700)]
Refactor GT_LCL_VAR and GT_STORE_LCL_VAR

Commit migrated from https://github.com/dotnet/coreclr/commit/e316b4ae0829fd75c225effe77934ef0d614158e

7 years agoRefactor GT_STORE_LCL_FLD
Bruce Forstall [Tue, 2 May 2017 00:06:55 +0000 (17:06 -0700)]
Refactor GT_STORE_LCL_FLD

Commit migrated from https://github.com/dotnet/coreclr/commit/5a8bec34ae8b8679ce03134cfed4ee35d120dead

7 years agoRefactor ARM/ARM64 GT_LCL_FLD codegen
Bruce Forstall [Mon, 1 May 2017 23:48:28 +0000 (16:48 -0700)]
Refactor ARM/ARM64 GT_LCL_FLD codegen

Commit migrated from https://github.com/dotnet/coreclr/commit/c882f9c1242cdc9db7ba95075cf8fbdd5fbee3ac

7 years agoMerge pull request dotnet/coreclr#11323 from dotnet-bot/master-UpdateDependencies
Wes Haggard [Mon, 1 May 2017 22:37:14 +0000 (15:37 -0700)]
Merge pull request dotnet/coreclr#11323 from dotnet-bot/master-UpdateDependencies

Update CoreClr to preview2-25301-03 (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/1969aa224e70a697d1622f7830df7b894b703189

7 years agoMerge pull request dotnet/coreclr#11067 from sjsinju/model_kill_set
Bruce Forstall [Mon, 1 May 2017 21:12:19 +0000 (14:12 -0700)]
Merge pull request dotnet/coreclr#11067 from sjsinju/model_kill_set

[WIP][RyuJIT/ARM32] Implement the model kill for CORINFO_HELP_ASSGN_BYREF helper

Commit migrated from https://github.com/dotnet/coreclr/commit/f891a8ee019af67e4521b1d46ae02716eba943da

7 years agoUpdate CoreClr to preview2-25301-03
dotnet-bot [Mon, 1 May 2017 21:03:47 +0000 (21:03 +0000)]
Update CoreClr to preview2-25301-03

Commit migrated from https://github.com/dotnet/coreclr/commit/b2d4864dd998af8f9467c16cbcadf008942491a9

7 years agoMerge pull request dotnet/coreclr#11304 from pgavlin/GH11273
Pat Gavlin [Mon, 1 May 2017 19:31:25 +0000 (12:31 -0700)]
Merge pull request dotnet/coreclr#11304 from pgavlin/GH11273

Fix dotnet/coreclr#11273 by adjusting the fix for VSO 406163.

Commit migrated from https://github.com/dotnet/coreclr/commit/4a860230bd709a3bec1262156d5efe8e992c3e6f

7 years agoMove a few more files to shared CoreLib partition
Jan Kotas [Sun, 16 Apr 2017 22:14:48 +0000 (15:14 -0700)]
Move a few more files to shared CoreLib partition

Commit migrated from https://github.com/dotnet/coreclr/commit/b11928aa219f3caded8ba39a946cf4bec9b7b5ed

7 years ago[ARM] Update rootfs for Tizen armel (dotnet/coreclr#11202)
Hyung-Kyu Choi [Mon, 1 May 2017 19:00:01 +0000 (04:00 +0900)]
[ARM] Update rootfs for Tizen armel (dotnet/coreclr#11202)

* [ARM] Update cross rootfs for armel Tizen

Update cross rootfs for armel Tizen

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* [ARM] Update cmake file and CI for armel Tizen

Update CI and cmake file for armel Tizen, because rootfs for Tizen is updated.
And rootfs for Tizen is embedded in Docker image for CI as Ubuntu for arm does.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/a23cd5287f9be53f47c78cf99dfc114518a506d0

7 years agoFix current publish build warnings (dotnet/coreclr#11317)
Davis Goodin [Mon, 1 May 2017 18:35:13 +0000 (13:35 -0500)]
Fix current publish build warnings (dotnet/coreclr#11317)

* Make VSTS Drop metadata distinct

* Remove PublishLogs artifact publish: no matches

Commit migrated from https://github.com/dotnet/coreclr/commit/e695a6df23ebd73c0b397fb8057175ef928ddd36

7 years agoMerge pull request dotnet/coreclr#11309 from dotnet-bot/master-UpdateDependencies
William Godbe [Mon, 1 May 2017 17:49:46 +0000 (10:49 -0700)]
Merge pull request dotnet/coreclr#11309 from dotnet-bot/master-UpdateDependencies

Update CoreClr, CoreFx to preview2-25301-01, preview2-25301-02, respectively (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/1b049e4aa79941cc994cfcf2beec3ed9ad883193