Armin Novak [Thu, 18 Jun 2015 10:24:22 +0000 (12:24 +0200)]
UPN syntax fix: domain must be empty, not NULL.
Armin Novak [Thu, 18 Jun 2015 10:01:17 +0000 (12:01 +0200)]
Added user setting if no domain provided.
Armin Novak [Thu, 18 Jun 2015 09:49:16 +0000 (11:49 +0200)]
Fixed variable parsed.
Armin Novak [Thu, 18 Jun 2015 09:35:22 +0000 (11:35 +0200)]
Using last @ for domain split.
Command line parser splits username after
parsing all options.
Armin Novak [Mon, 15 Jun 2015 07:47:16 +0000 (09:47 +0200)]
Allowing UPN syntax for user.
Vic Lee [Fri, 12 Jun 2015 12:52:53 +0000 (12:52 +0000)]
Merge pull request #2687 from akallabeth/known_hosts_v2
Store SSL fingerprints with host and port
Norbert Federa [Fri, 12 Jun 2015 08:52:52 +0000 (10:52 +0200)]
Merge pull request #2692 from nfedera/add-16bit-cursor-conversion
codec/color: support for 8bpp and 16bpp color pointer
Bernhard Miklautz [Fri, 12 Jun 2015 07:48:53 +0000 (09:48 +0200)]
Merge pull request #2688 from hardening/fix_packaging
Correct the included files to have a working freerdp-nightly-dev package
Armin Novak [Fri, 12 Jun 2015 07:30:01 +0000 (09:30 +0200)]
Renamed file to known_hosts2.
Norbert Federa [Thu, 11 Jun 2015 16:40:41 +0000 (18:40 +0200)]
xfreerdp: xfc->palette wasn't updated with /gdi:sw
When using software gdi (/gdi:sw) the rdp update PDU callback
gdi_palette_update() is used which writes the new colors to
the rdpContext's gdi->palette buffer.
The X11 functions however access xfc->palette which gets only
updated by xf_gdi_palette_update() which is the callback if
/gdi:hw is used.
This commit changes xfc->palette to a pointer which points to
xfc's private buffer with /gdi:hw or to the gdi->palette if
software gdi is used.
Norbert Federa [Thu, 11 Jun 2015 14:34:42 +0000 (16:34 +0200)]
codec/color: support for 8bpp color pointer
Norbert Federa [Thu, 11 Jun 2015 11:12:21 +0000 (13:12 +0200)]
codec/color: support for 16bpp color pointer
Bernhard Miklautz [Thu, 11 Jun 2015 10:47:10 +0000 (12:47 +0200)]
Merge pull request #2682 from nfedera/fix-hresult-winpr-path
winpr/path: more PathCch* fixes
MartinHaimberger [Thu, 11 Jun 2015 10:34:03 +0000 (12:34 +0200)]
Merge pull request #2690 from llyzs/autodetect_fix
Fix timer precision for network autodetection on Windows
Armin Novak [Thu, 11 Jun 2015 09:34:36 +0000 (11:34 +0200)]
Updated tests.
Armin Novak [Thu, 11 Jun 2015 09:34:22 +0000 (11:34 +0200)]
Added NULL pointer checks, fixed warnings.
Armin Novak [Thu, 11 Jun 2015 09:16:45 +0000 (11:16 +0200)]
Added subject and issuer to saved data.
When a certificate has changed, display not only the
fingerprint but also subject and issuer of old certificate.
Armin Novak [Thu, 11 Jun 2015 07:58:34 +0000 (09:58 +0200)]
Fixed fingerprint comparison, return value was inverted.
Armin Novak [Thu, 11 Jun 2015 07:57:30 +0000 (09:57 +0200)]
Fixed formatting.
Armin Novak [Thu, 11 Jun 2015 07:23:50 +0000 (09:23 +0200)]
Added test for fingerprint read.
Armin Novak [Thu, 11 Jun 2015 07:23:32 +0000 (09:23 +0200)]
Fixed data replace.
Armin Novak [Wed, 10 Jun 2015 21:33:58 +0000 (23:33 +0200)]
Added certificate_get_fingerprint function to read out old one.
Vic Lee [Thu, 11 Jun 2015 07:12:27 +0000 (15:12 +0800)]
autodetect: use high-precision timer.
Vic Lee [Thu, 11 Jun 2015 07:11:19 +0000 (15:11 +0800)]
winpr: add high-precision GetTickCountPrecise for Windows.
David FORT [Wed, 10 Jun 2015 19:33:40 +0000 (21:33 +0200)]
Correct the included files to have a working freerdp-nightly-dev package
Armin Novak [Wed, 10 Jun 2015 08:59:14 +0000 (10:59 +0200)]
Added port to certificate warnings.
Armin Novak [Wed, 10 Jun 2015 08:47:59 +0000 (10:47 +0200)]
Using binary mode for fopen.
Armin Novak [Wed, 10 Jun 2015 08:40:01 +0000 (10:40 +0200)]
Opening correct file.
Armin Novak [Wed, 10 Jun 2015 08:34:02 +0000 (10:34 +0200)]
Opening file on use now.
Armin Novak [Wed, 10 Jun 2015 07:15:38 +0000 (09:15 +0200)]
Working unit test for known_hosts functions.
Armin Novak [Wed, 10 Jun 2015 07:15:28 +0000 (09:15 +0200)]
Fixed bugs found due to test.
Armin Novak [Tue, 9 Jun 2015 16:03:32 +0000 (18:03 +0200)]
Added unit test.
Armin Novak [Tue, 9 Jun 2015 14:12:41 +0000 (16:12 +0200)]
Added legacy known_hosts support.
If no entry for the <host> <port> combination
was found in the v2 file and there is a legacy file
check if a matching <host> entry can be found.
In case there is a matching entry and the <fingerprint>
also matches, create a new entry in the v2 file using the
current port.
Armin Novak [Tue, 9 Jun 2015 13:33:13 +0000 (15:33 +0200)]
Using '<host> <port> <fp>' format for known hosts.
Armin Novak [Tue, 9 Jun 2015 13:32:50 +0000 (15:32 +0200)]
Added StrSep function.
Bernhard Miklautz [Tue, 9 Jun 2015 10:35:45 +0000 (12:35 +0200)]
Merge pull request #2670 from akallabeth/windows_config_paths
Adjusted config paths
Norbert Federa [Mon, 8 Jun 2015 15:57:24 +0000 (17:57 +0200)]
Merge pull request #2683 from nfedera/fix-shadow-server
server/shadow: resuscitate shadow server
Norbert Federa [Mon, 8 Jun 2015 14:34:45 +0000 (16:34 +0200)]
server/shadow: prevent memcopy of NULL area
Norbert Federa [Mon, 8 Jun 2015 13:55:11 +0000 (15:55 +0200)]
server/shadow: resuscitate shadow server
shadow_client_refresh_rect returned FALSE if the areas parameter
was NULL. It may only do so if the count parameter is > 0.
Norbert Federa [Mon, 8 Jun 2015 12:32:19 +0000 (14:32 +0200)]
winpr/path: Denounce PathAllocCombine and more
Note: This commit does NOT really fix PathAllocCombine!
- print a warning message that the function is buggy and added a code
comment describing the issues
- fix misuse of the S_FALSE HRESULT in error conditions
- prevent some segfaults
- check result of HeapAlloc
Fortunately PathAllocCombine is unused in FreeRDP
Norbert Federa [Mon, 8 Jun 2015 12:03:32 +0000 (14:03 +0200)]
winpr/path: PathCchConvertStyle used S_FALSE
Use E_FAIL instead of S_FALSE which was used to indicate errors
although it is a HRESULT success code.
Norbert Federa [Mon, 8 Jun 2015 10:06:46 +0000 (12:06 +0200)]
winpr/path: umimplemented tests print a warning
Norbert Federa [Mon, 8 Jun 2015 09:56:46 +0000 (11:56 +0200)]
winpr/path: unimpl. functions should not succeed
Unimplemented PathCch* functions now return E_NOTIMPL instead of the
HRESULT S_OK and print an error message.
Norbert Federa [Mon, 8 Jun 2015 08:24:38 +0000 (10:24 +0200)]
winpr: fix PathCchFindExtension
Fix multiple inplementation errors including the incorrect usage of S_FALSE.
Make this function behave like the Windows 8 implementation and
the according MSDN specification.
- return S_OK if the extension was NOT found
- if no extension was found, ppszExt must point to the string's terminating null
- return E_INVALIDARG if pszPath is not null-terminated within the cchPath range
- return E_INVALIDARG if pszPath is NULL
- return E_INVALIDARG if ppszExt is NULL
- return E_INVALIDARG if cchPath is Zero
- return E_NOTIMPL instead of S_OK in PathPathCchFindExtensionW()
Also extended/fixed the TestPathCchFindExtension ctest
Bernhard Miklautz [Mon, 8 Jun 2015 12:17:50 +0000 (14:17 +0200)]
Merge pull request #2676 from nfedera/fix-hresult-xxx
winpr: fixed some misuses of S_FALSE
Norbert Federa [Wed, 3 Jun 2015 14:05:19 +0000 (16:05 +0200)]
winpr: fix PathCchAppend
Fix incorrect usage of S_FALSE which was used to indicate errors
although it is a HRESULT success code.
Make this function behave like the Windows 8 implementation and
the according MSDN specification.
- return E_INVALIDARG instead of S_FALSE if pszPath is NULL
- return E_INVALIDARG instead of S_FALSE if pszMore is NULL
- return E_INVALIDARG if cchPath is zero
- return E_INVALIDARG if cchPath is greater than PATHCCH_MAX_CCH
- return HRESULT_FROM_WIN32(ERROR_FILENAME_EXCED_RANGE) if the combined
path size exceeds cchPath (this is the same HRESULT which the Windows
implementation returns in this case and which is referred to as
PATHCCH_E_FILENAME_TOO_LONG on msdn)
Also extended/fixed the TestPathCchAppend ctest
Norbert Federa [Wed, 3 Jun 2015 11:53:39 +0000 (13:53 +0200)]
winpr: fix PathCchStripPrefix
And again S_FALSE was incorrectly used to indicate an error.
Fix this and be more compatible to the Windows 8 implementation of
this function:
- return E_INVALIDARG instead of S_FALSE if pszPath is NULL
- return E_INVALIDARG instead of S_FALSE if cchPath < 4
- return E_INVALIDARG if cchPath > PATHCCH_MAX_CCH
- allow stripping of "\\?\c:" and don't require "\\?\c:\"
- verify that the character at the drive letter position is
actually an alphabetic character
- since the passed pszPath must not necessarily be null terminated
and we always have enough space after the memmove we can always
ensure the null termination of the stripped result
Also extended/fixed the TestPathCchStripPrefixctest
Norbert Federa [Tue, 2 Jun 2015 20:21:57 +0000 (22:21 +0200)]
winpr: fix PathCchAddExtension
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
Norbert Federa [Tue, 2 Jun 2015 19:38:49 +0000 (21:38 +0200)]
winpr: fix PathCchAddBackslashEx
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
Norbert Federa [Tue, 2 Jun 2015 19:36:31 +0000 (21:36 +0200)]
winpr: fix PathCchAddBackslash
The HRESULT S_FALSE does not indicate an error:
- return E_INVALIDARG instead of S_FALSE
- return HRESULT_FROM_WIN32(ERROR_INSUFFICIENT_BUFFER) instead of S_FALSE
Also extended/fixed the corresponding ctest
Norbert Federa [Tue, 2 Jun 2015 19:15:46 +0000 (21:15 +0200)]
client/windows: invalid usage of S_FALSE HRESULT
S_FALSE is a success code and not an error (note the S_)
Bernhard Miklautz [Wed, 3 Jun 2015 08:05:09 +0000 (10:05 +0200)]
Merge pull request #2673 from nfedera/fix-hresult
winpr: fixed HRESULT & SCODE types, added a ctest
Norbert Federa [Tue, 2 Jun 2015 17:52:52 +0000 (19:52 +0200)]
winpr: fixed HRESULT & SCODE types, added a ctest
- HRESULT was unsigned which means that until now all usages of the
SUCCEDED(hr) and FAILED(hr) macros never detected any errors
- Also fixed the (unused) SCODE typedef
- Added new ctest TestTypes
Hardening [Tue, 2 Jun 2015 17:22:29 +0000 (19:22 +0200)]
Merge pull request #2672 from akallabeth/img_test_fix
Fixed for TestImage unit test
Armin Novak [Tue, 2 Jun 2015 15:54:27 +0000 (17:54 +0200)]
Writing failure to stderr.
Armin Novak [Tue, 2 Jun 2015 15:53:16 +0000 (17:53 +0200)]
Fixed image test.
Armin Novak [Tue, 2 Jun 2015 13:17:54 +0000 (15:17 +0200)]
Fixed image test.
Marc-André Moreau [Tue, 2 Jun 2015 13:15:29 +0000 (09:15 -0400)]
Merge pull request #2649 from xhaakon/cross-monitor-subrect
shadow_screen: allow sub-rectangle to span multiple monitors
Armin Novak [Tue, 2 Jun 2015 10:45:14 +0000 (12:45 +0200)]
Fixed size of string buffer.
MartinHaimberger [Tue, 2 Jun 2015 10:38:21 +0000 (12:38 +0200)]
Merge pull request #2669 from llyzs/h264
h264: add encoder constant QP rate control.
Armin Novak [Tue, 2 Jun 2015 09:53:25 +0000 (11:53 +0200)]
Added config compatibility for default builds.
Armin Novak [Tue, 2 Jun 2015 08:10:13 +0000 (10:10 +0200)]
Added missing NULL check.
Armin Novak [Tue, 2 Jun 2015 08:00:43 +0000 (10:00 +0200)]
Fixed directory creation checks.
Armin Novak [Tue, 2 Jun 2015 07:48:32 +0000 (09:48 +0200)]
Fixed settings path creation.
Armin Novak [Tue, 2 Jun 2015 07:45:46 +0000 (09:45 +0200)]
Fixed static function arguments.
Armin Novak [Tue, 2 Jun 2015 07:07:17 +0000 (09:07 +0200)]
Using vendor/product scheme for settings now.
Armin Novak [Tue, 2 Jun 2015 07:02:29 +0000 (09:02 +0200)]
Fixed windows known path locations.
Vic Lee [Tue, 2 Jun 2015 07:28:36 +0000 (15:28 +0800)]
h264: add encoder constant QP rate control.
Hardening [Fri, 29 May 2015 15:58:30 +0000 (17:58 +0200)]
Merge pull request #2658 from hardening/fix_2657
Fix for #2657
Hardening [Fri, 29 May 2015 12:38:58 +0000 (14:38 +0200)]
Merge pull request #2647 from hardening/fix_message_queue
Fixed MessageQueue and callers
David FORT [Wed, 27 May 2015 15:35:25 +0000 (17:35 +0200)]
Take in account nfedera's remarks
David FORT [Tue, 26 May 2015 13:49:38 +0000 (15:49 +0200)]
Check some return values
David FORT [Tue, 26 May 2015 12:50:13 +0000 (14:50 +0200)]
Added misc checks in rdg.c
David FORT [Mon, 25 May 2015 20:55:37 +0000 (22:55 +0200)]
Fixed nfedera's remarks
David FORT [Sat, 23 May 2015 20:47:18 +0000 (22:47 +0200)]
Fixed MessageQueue and callers
Hardening [Fri, 29 May 2015 12:12:59 +0000 (14:12 +0200)]
Merge pull request #2661 from MartinHaimberger/mh-stream-fix
stream: check stream_new in winpr and libfreerdp
Martin Haimberger [Fri, 29 May 2015 11:46:50 +0000 (04:46 -0700)]
stream: check stream_new in winpr and libfreerdp
also fixed a few things
Hardening [Fri, 29 May 2015 08:49:42 +0000 (10:49 +0200)]
Merge pull request #2608 from oshogbo/master
Add check to protect memcpy(3) from using NULL pointer.
Hardening [Thu, 28 May 2015 20:58:15 +0000 (22:58 +0200)]
Merge pull request #2642 from hardening/shadow_fix
Specify to skip compression with remoteFx frames
Hardening [Thu, 28 May 2015 20:57:17 +0000 (22:57 +0200)]
Merge pull request #2659 from oshogbo/unused
Remove unused variable.
Hardening [Thu, 28 May 2015 09:09:07 +0000 (11:09 +0200)]
Merge pull request #2660 from nfedera/fix-tsmf-channel
tsmf: fix invalid check and a potential segfault
Hardening [Thu, 28 May 2015 08:51:53 +0000 (10:51 +0200)]
Merge pull request #2646 from eledoux/thread_list
fixed a synchronization issue on thread_list
Norbert Federa [Thu, 28 May 2015 08:49:38 +0000 (10:49 +0200)]
tsmf: fix invalid check and a potential segfault
This resuscitates tsmf which was accidently broken in commit
f8120919
Emmanuel Ledoux [Wed, 27 May 2015 16:24:56 +0000 (18:24 +0200)]
winpr-thread: added HP's copyright
Emmanuel Ledoux [Wed, 27 May 2015 16:15:17 +0000 (18:15 +0200)]
winpr-thread: thread_list's synchronization based on a pthread_cond_t
Mariusz Zaborski [Wed, 27 May 2015 14:04:06 +0000 (16:04 +0200)]
Remove unused variable.
David FORT [Wed, 27 May 2015 13:13:43 +0000 (15:13 +0200)]
Fix for #2657
Marc-André Moreau [Wed, 27 May 2015 13:00:22 +0000 (09:00 -0400)]
Merge pull request #2653 from bmiklautz/lzcnt
winpr: add intrin.h
Bernhard Miklautz [Wed, 27 May 2015 08:32:08 +0000 (10:32 +0200)]
winpr/test: incorporate comments from pull request
* Fix TestIntrinsics - always returned 0
* rename TestWinpr to TestWinPR for consistency
* update gitignores accordingly
Emmanuel Ledoux [Tue, 26 May 2015 16:15:57 +0000 (18:15 +0200)]
winpr-thread: a better error message and comments about thread_list
Emmanuel Ledoux [Tue, 26 May 2015 15:55:27 +0000 (17:55 +0200)]
winpr-thread: added an assertion to enforce that thread_list is correctly set
Emmanuel Ledoux [Tue, 26 May 2015 15:40:34 +0000 (17:40 +0200)]
winpr-thread: thread_list's synchronization based on an Event
Bernhard Miklautz [Tue, 26 May 2015 14:41:29 +0000 (16:41 +0200)]
winpr: add intrin.h
Exposing lzcnt in crt.h might causes compiler errors (redefinition) with
recent versions of gcc (>=4.9) when winpr is included in other projects.
As lzcnt isn't part of crt according to MSDN and also shouldn't be
exported by default it was moved to intrin.h.
The related test was also moved to the top level directory of winpr.
Mariusz Zaborski [Tue, 26 May 2015 13:33:12 +0000 (15:33 +0200)]
In c file the name is channelId.
Hardening [Tue, 26 May 2015 14:10:41 +0000 (16:10 +0200)]
Merge pull request #2654 from oshogbo/typos
Typo
Hardening [Tue, 26 May 2015 06:39:08 +0000 (08:39 +0200)]
Merge pull request #2652 from nfedera/fix-ios-context-new
client/iOS: fix ios_context_new
Norbert Federa [Mon, 25 May 2015 20:21:53 +0000 (22:21 +0200)]
client/iOS: fix ios_context_new
- fixed wrong signature since ContextNew is BOOL now
- added error checking
Jakub Adam [Mon, 25 May 2015 11:44:51 +0000 (13:44 +0200)]
shadow_screen: allow sub-rectangle to span multiple monitors
When we share a sub-rectangle of our desktop, allow it to span over
multiple monitors. Previously it was possible to export an area larger
than one display, however the contents were always cropped to
the boundaries of the selected monitor and the rest was visible for
the client only as a black area .
Mariusz Zaborski [Mon, 11 May 2015 14:21:02 +0000 (16:21 +0200)]
Add check to protect memcpy(3) from using NULL pointer.
The ntlm_construct_challenge_target_info function can potentially pass NULL as
argument to the ntlm_av_pair_add function (for example DnsDomainName.Buffer).
This NULL finally lands in the CopyMemory (which is macro to the memcpy(3)
function) which can't handle NULL.
Marc-André Moreau [Fri, 22 May 2015 18:30:11 +0000 (14:30 -0400)]
Merge pull request #2639 from awakecoding/master
WLog, server-side rdpdr, remote assistance, byteswap, etc