Joseph Huber [Wed, 12 Apr 2023 20:08:59 +0000 (15:08 -0500)]
[OpenMP] Remove duplicates from the list if using 'auto'
Summary:
We can detect the user's GPUs via the `auto` option. But if the user has
multiple GPUs installed or set the list incorrectly, we need to remove
the duplicates.
Joseph Huber [Fri, 14 Apr 2023 20:05:40 +0000 (15:05 -0500)]
[libc] Remove duplicate architecture from the detected list
Summary:
When we detect the architectures via `native` we can have systems with
multiple of the same GPU. We need to remove duplicates or else we will
try to build the same target multiple times.
Nick Desaulniers [Fri, 14 Apr 2023 20:09:01 +0000 (13:09 -0700)]
[StringView] remove popFront
Towards converting our use of llvm::StringView to std::string_view,
remove a method that std::string_view doesn't have.
llvm::StringView::popFront is similar to std::string_view::remove_prefix
but with a reference to std::string_view::front taken first.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D148363
Jingu Kang [Fri, 14 Apr 2023 19:42:53 +0000 (20:42 +0100)]
[AArch64] Precommit a test
This patch precommits a test for:
https://reviews.llvm.org/D148347
max [Fri, 14 Apr 2023 19:20:33 +0000 (14:20 -0500)]
[MLIR][python bindings] implement `PyValue` subclassing to enable operator overloading
Differential Revision: https://reviews.llvm.org/D147758
Chia-hung Duan [Fri, 14 Apr 2023 19:12:48 +0000 (19:12 +0000)]
[scudo] The BaseAddr should be MappedBase in releasePagesToOS()
This is used to make MemMapDefault be compliant with legacy APIs.
Reviewed By: fabio-d
Differential Revision: https://reviews.llvm.org/D148141
Alex Brachet [Fri, 14 Apr 2023 19:15:02 +0000 (19:15 +0000)]
Reland "[clang-scan-deps] Migrate to OptTable"
Differential Revision: https://reviews.llvm.org/D139949
Dimitry Andric [Sun, 12 Mar 2023 18:53:12 +0000 (19:53 +0100)]
test-release.sh: build projects and runtimes lists with semicolons
While doing a test-release.sh run on FreeBSD, I ran into a sed error due
to the introduction of the GNU extension '\s' in commit
500587e23dfd.
Scanning for blanks (spaces and tabs) could be done in a more portable
fashion using the [[:blank:]] character class. But it is easier to avoid
the original problem, which is that the projects and runtime lists have
to be separated by semicolons, and cannot start with a semicolon.
Instead, use the shell's alternate value parameter expansion mechanism,
which makes it easy to append items to lists with separators in between,
and without any leading separator. This also avoids having to run sed on
the end result.
In addition, build any selected runtimes in the second phase, otherwise
the third phase can fail to find several symbols in compiler-rt, if that
has been built. This is because the host's compiler-rt is not guaranteed
to have those symbols.
Reviewed By: tstellar
Differential Revision: https://reviews.llvm.org/D145884
Thurston Dang [Wed, 12 Apr 2023 20:53:49 +0000 (20:53 +0000)]
Fix tls_get_addr handling for glibc >=2.25
This changes the sanitizers' tls_get_addr handling from
a heuristic check of __signal_safe_memalign allocations
(which has only been used in a since deprecated version
of Google's runtime), to using the sanitizers' interface
function to check if it is a malloc allocation (used
since glibc >= 2.25).
This is one of the approaches proposed by Keno in
https://github.com/google/sanitizers/issues/1409#issuecomment-
1214244142
This moves the weak annotation of __sanitizer_get_allocated_size/begin from the header to sanitizer_tls_get_addr.cpp, as suggested by Vitaly in D148060.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D147459
Christian Sigg [Fri, 14 Apr 2023 18:44:19 +0000 (20:44 +0200)]
[bazel] Fix build after 33468a5
Add missing dependency.
Matt Arsenault [Sun, 9 Apr 2023 11:18:07 +0000 (07:18 -0400)]
ValueTracking: Handle fptrunc in computeKnownFPClass
Handle nan.
Matt Arsenault [Mon, 10 Apr 2023 13:49:06 +0000 (09:49 -0400)]
ValueTracking: Add computeKnownFPClass baseline test for fptrunc
Matt Arsenault [Tue, 11 Apr 2023 20:39:39 +0000 (16:39 -0400)]
InstSimplify: Perform cheaper check first
Matt Arsenault [Wed, 12 Apr 2023 23:09:17 +0000 (19:09 -0400)]
ValueTracking: Handle extractelement and extractvalue in computeKnownFPClass
Matt Arsenault [Sat, 8 Apr 2023 23:15:26 +0000 (19:15 -0400)]
ValueTracking: Implement computeKnownFPClass for sin/cos
Shivam Gupta [Fri, 14 Apr 2023 18:14:39 +0000 (23:44 +0530)]
[Docs] Update ClangFormatStyleOptions.rst's versionbadge's to have min-width
This fix https://github.com/llvm/llvm-project/issues/61934
By default, the width property is used to set the width of a table column.
However, if the content of a cell in that column is wider than the width
specified by the width property, the cell's content will overflow the
column and the table will become wider than the specified width.
This causes the version numbers to be displayed outside of their table cells.
Using the min-width property instead of width ensures that the column is
wide enough to accommodate the content of its cells. If a cell's content is
wider than the specified min-width, the column will expand to fit the content.
Hanhan Wang [Fri, 14 Apr 2023 18:23:16 +0000 (11:23 -0700)]
[mlir][linalg] Fix a bug in lower_pack when there are no padding values.
Reviewed By: chelini
Differential Revision: https://reviews.llvm.org/D148061
Nick Desaulniers [Fri, 14 Apr 2023 18:11:25 +0000 (11:11 -0700)]
[StringView] remove ctor incompatible with std::string_view
Towards replacing llvm::StringView with std::string_view, remove ctor
that std::string_view doesn't have an analog for.
Reviewed By: erichkeane, MaskRay
Differential Revision: https://reviews.llvm.org/D148353
Noah Goldstein [Fri, 14 Apr 2023 17:35:14 +0000 (12:35 -0500)]
[InstCombine] Make `FoldOpIntoSelect` handle non-constants and use condition to deduce constants.
Make the fold use the information present in the condition for deducing constants i.e:
```
%c = icmp eq i8 %x, 10
%s = select i1 %c, i8 3, i8 2
%r = mul i8 %x, %s
```
If we fold the `mul` into the select, on the true side we insert `10` for `%x` in the `mul`.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D146349
Noah Goldstein [Fri, 14 Apr 2023 17:34:53 +0000 (12:34 -0500)]
[InstCombine] Add tests for deducing constants based on condition in select; NFC
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D148180
Noah Goldstein [Fri, 14 Apr 2023 17:34:27 +0000 (12:34 -0500)]
[LIBC] Actually assert no errors in `pthread_call_once` in its test; NFC
Just seemed to be missing an assertion.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D148289
Noah Goldstein [Fri, 14 Apr 2023 17:33:59 +0000 (12:33 -0500)]
[LIBC] Clarify namespace of `thread_exit` in `pthread_exit`
Just add `__llvm_libc::` to makes things clearer.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D148292
Craig Topper [Fri, 14 Apr 2023 17:37:14 +0000 (10:37 -0700)]
[TableGen] Replace std::shared_ptr with InstrusiveRefCntPtr for TreePatternNode. NFC
An intrusive reference counter uses less memory than the control
block of std::shared_ptr.
This should allow some additional code simplifications if we
don't need to pass around shared_ptr in order to create new
shared_ptrs.
LLVM GN Syncbot [Fri, 14 Apr 2023 17:45:35 +0000 (17:45 +0000)]
[gn build] Port
5abe338f2a7f
Jorge Pinto Sousa [Fri, 14 Apr 2023 17:22:47 +0000 (17:22 +0000)]
[clang-tidy][NFC] Remove reference to Visual studio native plugin
The clang-tidy documentation contained:
> MS Visual Studio has a native clang-tidy-vs plugin
This plugin was removed via 559ae14.
Fixes: https://github.com/llvm/llvm-project/issues/62142
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D148354
Douglas Chen [Fri, 14 Apr 2023 17:22:36 +0000 (17:22 +0000)]
[clang-tidy][NFC] Improved hungarian notation regression test at post-commit review
Improve the (`D144510`)[https://reviews.llvm.org/D144510] patch with prefix string. Using "my" instead of "cust" would increase
readability.
Take some examples:
- const char* `custszNamePtr` = "Name"; --> `myszNamePtr`
- uint8_t `custu8ValueU8` = 0; --> `myu8ValueU8`
- DWORD `custdwMsDword` = 0; --> `mydwMsDword`
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D148314
AMS21 [Fri, 14 Apr 2023 17:06:30 +0000 (17:06 +0000)]
[clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor
Previously a struct like this:
template <typename>
struct A { A(A&&) = default; };
Would trigger a false positive, since even though it is not marked as
noexcept it still is due to the `= default`.
Now we only give a warning if the defaulted move constructor is
actually declared as throwing and correctly resolve it if they are
defaulted.
This fixes llvm#56026, llvm#41414, llvm#38081
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D146922
Nick Desaulniers [Fri, 14 Apr 2023 17:24:07 +0000 (10:24 -0700)]
[StringView] remove dropFront
Towards converting our use of llvm::StringView to std::string_view,
remove a method that std::string_view doesn't have.
llvm::StringView::dropFront is semantically similar to
std::string_view::substr but with the input clamped to the size. No code
was relying on clamping other than the rust demangler, which I fixed in
https://reviews.llvm.org/D148272. Removing this method makes it easier
to switch over code later.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D148348
Fangrui Song [Fri, 14 Apr 2023 17:18:54 +0000 (10:18 -0700)]
[lsan] Move allocator base to avoid conflict with high-entropy ASLR for x86-64 Linux
This ports D148280 for ASan.
On x86-64 Linux, when mmap_rnd_bits is set to 32 (the maximum `ARCH_MMAP_RND_BITS_MAX`),
the allocator space `[kAllocatorSpace,kAllocatorSpace+kAllocatorSize)`
collides with the PIE load base range (0x555555554000 upto `2**mmap_rnd_bits * pagesize` away),
which can cause the allocation to fail.
Using 0x500000000000ULL as the base address avoids this problem and works with
AArch64 Linux and FreeBSD as well.
While here, change s390x to use 0x500000000000ULL as well. See D78644
discussions that the address works.
Reviewed By: thurston, vitalybuka
Differential Revision: https://reviews.llvm.org/D148193
Arthur Eubanks [Thu, 13 Apr 2023 20:25:08 +0000 (13:25 -0700)]
[Pipeline] Don't limit ArgumentPromotion to -O3
This is a cheap pass so there's no need to limit to -O3.
This removes some differences between various pipelines.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D148269
Bjorn Pettersson [Fri, 14 Apr 2023 13:04:10 +0000 (15:04 +0200)]
[passes] Remove the legacy PM version of IRCE
Differential Revision: https://reviews.llvm.org/D148338
Bjorn Pettersson [Fri, 14 Apr 2023 13:00:36 +0000 (15:00 +0200)]
[passes] Remove the legacy PM version of AlignmentFromAssumptions
Differential Revision: https://reviews.llvm.org/D148337
Bjorn Pettersson [Thu, 13 Apr 2023 11:25:43 +0000 (13:25 +0200)]
[Passes] Remove the legacy DemandedBitsWrapperPass
Last user of DemandedBitsWrapperPass was the BDCE pass. Since
the legacy PM version of BDCE was removed in an earlier commit, this
patch removes the now unused DemandedBitsWrapperPass.
Differential Revision: https://reviews.llvm.org/D148336
Bjorn Pettersson [Thu, 13 Apr 2023 08:42:16 +0000 (10:42 +0200)]
[Passes] Remove legacy PM version of BDCE (aka BitTrackingDCEPass)
BDCE is not used by the codegen pipeline so we should not need the
legacy PM version of the pass any longer.
Differential Revision: https://reviews.llvm.org/D148335
Nathan James [Fri, 14 Apr 2023 16:51:44 +0000 (17:51 +0100)]
[clangd] Handle destructors in DefineOutline tweak
Fix destructors being incorrectly defined in the DefineOutline tweak
Currently it doesn't prepend the class name to the destructor
```lang=c++
class A { ~A() {} };
// Destructor definition after outline
~A() {}
// After this fix
A::~A() {}
```
Reviewed By: kadircet
Differential Revision: https://reviews.llvm.org/D147802
Cameron McInally [Fri, 14 Apr 2023 16:26:16 +0000 (09:26 -0700)]
[AArch64] Combine SELECT_CC patterns that match smin(a,0) and smax(a,0)
With a previous patch to canonicalize SPF to min/max intrinsics (
a266af721153),
we saw a performance regression on the AArch64 backend.
This patch recovers from the SPF canonicalization by combining smin(a,0) and
smax(a,0) SELECT_CC patterns during AArch64ISelLowering.
GitHub Issue: #61767
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D148249
Nicolas Vasilache [Fri, 31 Mar 2023 15:00:39 +0000 (08:00 -0700)]
[mlir][Linalg] Make HoistRedundantTensorSubsetsOp not a FunctionalStyleTransformOpTrait
Differential Revision: https://reviews.llvm.org/D148350
Valentin Clement [Fri, 14 Apr 2023 16:43:44 +0000 (09:43 -0700)]
[flang][openacc] Add kernels construct lowering
Lower the parse tree to acc dialects operations. Make use
of the compute construct lowering.
Depends on D148277
Reviewed By: PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D148278
Nicolas Vasilache [Fri, 14 Apr 2023 12:44:41 +0000 (05:44 -0700)]
[mlir][Tensor] Add support for insert_slice in FoldTensorSubsetOps
Differential Revision: https://reviews.llvm.org/D148334
Nick Desaulniers [Fri, 14 Apr 2023 16:18:04 +0000 (09:18 -0700)]
[RustDemangle] remove StringView::dropFront
Toward the goal of replacing llvm::StringView with std::string_view,
first replacing users of llvm::StringView::dropFront, this case in the
Rust demangling scheme seemed worth its own commit+review.
Reviewed By: erichkeane, MaskRay
Differential Revision: https://reviews.llvm.org/D148272
Michael Buch [Mon, 3 Apr 2023 10:09:23 +0000 (11:09 +0100)]
[lldb][ClangExpression] Filter out non-root namespaces in FindNamespace
**Summary**
In a program such as:
```
namespace A {
namespace B {
struct Bar {};
}
}
namespace B {
struct Foo {};
}
```
...LLDB would run into issues such as:
```
(lldb) expr ::B::Foo f
error: expression failed to parse:
error: <user expression 0>:1:6: no type named 'Foo' in namespace 'A::B'
::B::Foo f
~~~~~^
```
This is because the `SymbolFileDWARF::FindNamespace` implementation
will return *any* namespace it finds if the `parent_decl_ctx` provided
is empty. In `FindExternalVisibleDecls` we use this API to find the
namespace that symbol `B` refers to. If `A::B` happened to be the one
that `SymbolFileDWARF::FindNamespace` looked at first, we would try
to find `struct Foo` in `A::B`. Hence the error.
This patch proposes a new `SymbolFileDWARF::FindNamespace` API that
will only find a match for top-level namespaces, which is what
`FindExternalVisibleDecls` is attempting anyway; it just never
accounted for multiple namespaces of the same name.
**Testing**
* Added API test-case
Differential Revision: https://reviews.llvm.org/D147436
Joseph Huber [Fri, 14 Apr 2023 16:09:33 +0000 (11:09 -0500)]
[OpenMP][Docs] Replace broken design document link with the git repo
Summary:
At some point we stopped copying this file to the server, but
realistically this is just a static `.pdf` hosted in the LLVM repository
so we can link it directly.
Shreyansh Chouhan [Fri, 14 Apr 2023 16:11:05 +0000 (17:11 +0100)]
[AArch64] Teach the AArch64 backend patterns to generate the RAX1 instruction.
Differential Revision: https://reviews.llvm.org/D147887
Michael Buch [Fri, 14 Apr 2023 16:01:49 +0000 (17:01 +0100)]
[lldb] Allow evaluating expressions in C++20 mode
This patch allows users to evaluate expressions using
`expr -l c++20`. Currently DWARF keeps the CU's at
`DW_AT_language` at `DW_LANG_C_plus_plus_14` even
when compiling with `-std=c++20`. So even in "C++20
programs" expression evaluation will by default be
performed in `C++11` mode for now.
Enabling `C++14` has been previously attempted at
https://reviews.llvm.org/D80308
There are some remaining issues around evaluating C++20
expressions. Mainly, lack of support for C++20 AST nodes in
`clang::ASTImporter`. But these can be addressed in follow-up
patches.
Michael Buch [Wed, 1 Feb 2023 03:58:05 +0000 (03:58 +0000)]
[lldb][Language] Add more language types
Adds more languages to the `language_names` list in
preparation for adding support for C++20 expression
evaluation.
The language constants were taken from the DWARFv5
constants defined in LLVM's `Dwarf.def`. Two vendor
constants overlap with the DWARFv5 constants so bump
their values. Their actual value is not important,
whereas keeping the enum values consecutive is (since
they are used for array lookups).
Differential Revision: https://reviews.llvm.org/D143061
Antoine Moynault [Fri, 14 Apr 2023 15:32:41 +0000 (15:32 +0000)]
[fuzzer][test] Disable noasan-strncmp test for AArch64
This test fails on several aarch64 bots
clang-aarch64-lld-2stage ( https://lab.llvm.org/buildbot/#/builders/185/builds/3525 )
clang-aarch64-full-2stage ( https://lab.llvm.org/buildbot/#/builders/179/builds/5904 )
clang-aarch64-sve-vla ( https://lab.llvm.org/buildbot/#/builders/197/builds/4519 )
Disable it while this is analyzed.
Reviewed By: DavidSpickett
Differential Revision: https://reviews.llvm.org/D148332
Valentin Clement [Fri, 14 Apr 2023 15:29:39 +0000 (08:29 -0700)]
[mlir][openacc] Add acc.kernels operation
The acc.kernels operation models the OpenACC kernels construct.
The kernels construct defines a region of a program that is
compiled into a sequence of kernels to be executed on the current device.
The operation is modelled on the acc.parallel operation and will
receive similar updates when the data operands operations will
be implemented.
Reviewed By: PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D148277
Louis Dionne [Tue, 11 Apr 2023 16:53:39 +0000 (17:53 +0100)]
[libc++] Remove redundant assertion in std::span::subspan
That is already checked later in the function as `__count <= size() - __offset`.
rdar://
107884996
Differential Revision: https://reviews.llvm.org/D148030
Kevin P. Neal [Wed, 12 Apr 2023 15:42:44 +0000 (11:42 -0400)]
[FPEnv][LangRef] Update doc for strictfp attribute
Based on the direction of IR Verifier changes in D146845, this documentation
needs to be updated.
Differential Revision: https://reviews.llvm.org/D148138
Dave Lee [Wed, 12 Apr 2023 21:44:19 +0000 (15:44 -0600)]
[lldb] Add `operator StringRef` to ConstString
Add a `StringRef` conversion function to `ConstString`.
This will make using llvm, and other non-ConstString, APIs more convenient.
For demonstration, this updates Module.cpp.
Differential Revision: https://reviews.llvm.org/D148175
Christian Sigg [Fri, 14 Apr 2023 15:04:14 +0000 (17:04 +0200)]
[mlir] Fix test after 2d4e856
The test CHECKs for `-nan`, but printing the sign is optional.
This change removes the sign because it has no meaning.
Zain Jaffal [Fri, 14 Apr 2023 14:37:06 +0000 (15:37 +0100)]
[ConstraintElimination] Add tests to check for transfering facts from sgt to ugt.
If we have a >s b and we know that b >s 0 then we also can infer that a >u b.
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D148321
Joseph Huber [Thu, 6 Apr 2023 16:18:47 +0000 (11:18 -0500)]
[OpenMP] Replace HeapToShared's initial value with `poison`
There's a desire to move away from `undef` in LLVM. Currently we want to
have the `addressspace(3)` variables use `poison` instead.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D147719
Joseph Huber [Mon, 10 Apr 2023 14:50:40 +0000 (09:50 -0500)]
[OpenMP][Docs] Add documentation for using configuration files
We recently reverted a patch that automatically set the rpath on OpenMP
executables. This was used because the `libomptarget.so` library is only
expected to work with the same version of compiler that will be using
it. This patch adds some documentation for how to get similar behaviour
as before using a clang configuration file.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D147943
Kiran Chandramohan [Fri, 14 Apr 2023 14:23:30 +0000 (14:23 +0000)]
[Flang] Add code owner for the Driver
Andrzej proposed the design and led the work for the Flang Driver
over the past couple of years. He is continuing to function as
the primary reviewer and gate-keeper of the Driver.
Reviewed By: sscalpone
Differential Revision: https://reviews.llvm.org/D147573
Simon Pilgrim [Fri, 14 Apr 2023 14:37:40 +0000 (15:37 +0100)]
[X86] combineSetCCMOVMSK - fold anyof/noneof movmskps/movmskpd -> testps/testpd
Another part of Issue #60007
Nikita Popov [Fri, 14 Apr 2023 14:28:03 +0000 (16:28 +0200)]
[X86] Add additional add of mul test (NFC)
Balaji V. Iyer [Fri, 14 Apr 2023 13:52:17 +0000 (13:52 +0000)]
[mlir][math] Expand math.powf to exp, log and multiply
Powf functions are pushed directly to libm. This is problematic for
situations where libm is not available. This patch will decompose the
powf function into log of exponent multiplied by log of base and raise
it to the exp.
Reviewed By: rsuderman
Differential Revision: https://reviews.llvm.org/D148164
Nikita Popov [Fri, 14 Apr 2023 13:56:42 +0000 (15:56 +0200)]
[X86] Add test for foldable add of mul (NFC)
Krasimir Georgiev [Fri, 14 Apr 2023 13:55:20 +0000 (13:55 +0000)]
Revert " [sanitizer] adapt for
75f1f158812dabc03e70697b6b9c272230bce63d"
This reverts commit
de4c038c7ba2c6a8d529cb094f1a7c3deaae9b75.
The change that triggered this fix got reverted.
pvanhout [Fri, 7 Apr 2023 12:54:50 +0000 (14:54 +0200)]
[AMDGPU] Less aggressively break large PHIs
In some cases, breaking large PHIs can very negatively affect
performance (3x more instructions observed in a particular test case).
This patch adds some basic profitability heuristics to help with some of these issues without affecting the "good" cases.
e.g. avoid breaking PHIs if it causes back-and-forth between vector/scalar form for no good reason.
Fixes SWDEV-392803
Fixes SWDEV-393781
Fixes SWDEV-394228
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D147786
Nicolas Vasilache [Fri, 14 Apr 2023 12:43:07 +0000 (05:43 -0700)]
[mlir][Linalg] Support tensor.parallel_insert_slice in transform.insert_slice_to_copy
Differential Revision: https://reviews.llvm.org/D148333
Luke Lau [Thu, 13 Apr 2023 15:43:36 +0000 (16:43 +0100)]
[VP] Mark llvm.vp.copysign as a binary op
I was working on legalising vector binary ops to their VP counterparts when I noticed that `vp_copysign` wasn't marked as a binary op. It looks like this might have been an oversight, so this marks it as one.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D148241
Pavel Labath [Fri, 14 Apr 2023 12:36:27 +0000 (14:36 +0200)]
[lldb] Add a sleep to TestObjectFileJSON
The test fails when the two generated files have the same timestamp
(lldb uses second granularity).
Dmitry Makogon [Wed, 12 Apr 2023 08:15:47 +0000 (15:15 +0700)]
[SCEV] Preserve NSW for AddRec multiplied by -1 if it cannot be signed minimum
This preserves NSW flag for AddRecs multiplied by -1 if we can prove
via constant ranges that the AddRec cannot be signed minimum.
An explanation:
Let M be signed minimum. If AddRec's range contains M, then M * (-1) will
stay M and (M + 1) * (-1) will be signed maximum, so we get a signed overflow.
In all other cases if an AddRec didn't signed overflow,
then AddRec * (-1) wouldn't too.
Differential Revision: https://reviews.llvm.org/D148084
Ivan Butygin [Thu, 13 Apr 2023 16:28:57 +0000 (18:28 +0200)]
[mlir][scf] WhileOp patterns cleanup
Fix review comments from https://reviews.llvm.org/D146252
Merge `WhileRemoveUnusedArgs` pattern with (unused) `WhileUnusedArg`,
use `getConditionOp`, use `SmallPtrSet` and early check, move tests
Differential Revision: https://reviews.llvm.org/D148256
Christian Sigg [Fri, 14 Apr 2023 11:24:15 +0000 (13:24 +0200)]
[bazel] Fix build after e5f50bd and 62ef97e
Christian Ulmann [Fri, 14 Apr 2023 11:09:54 +0000 (11:09 +0000)]
[mlir][Analysis] CFGLoopInfo instantiation in C++
This commit moves the CFGLoopInfo instantiation into the C++ file to
ensure that it is only compiled once. Instantiating the template
explicitly revealed two missing functions that this commit also adds.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D148219
Aaron Ballman [Fri, 14 Apr 2023 11:18:46 +0000 (07:18 -0400)]
Model list initialization more directly; fixes an assert with coverage mapping
Instead of using the validity of a brace's source location as a flag
for list initialization, this now uses a PointerIntPair to model it so
we do not increase the size of the AST node to track this information.
This allows us to retain the valid source location information, which
fixes the coverage assertion.
Fixes https://github.com/llvm/llvm-project/issues/62105
Differential Revision: https://reviews.llvm.org/D148245
Dmitry Makogon [Fri, 14 Apr 2023 11:12:25 +0000 (18:12 +0700)]
[Test] Fix tests showing flags improvement for SCEV sub expressions (NFC)
This fixes a failing check in tests added by
05a142cc6fd1.
Simon Pilgrim [Fri, 14 Apr 2023 11:03:38 +0000 (12:03 +0100)]
[X86] SimplifyDemandedBitsForTargetNode - improve TESTPS/TESTPD handling for duplicated operands
We often repeat the vector operand in TESTPS(X,X)/TESTPD(X,X) for anyof comparisons - ensure we still only demand the sign bits when the TESTP is the only user of that operand
Kito Cheng [Fri, 14 Apr 2023 10:46:52 +0000 (18:46 +0800)]
[RISCV][NFC] Add test case for accept hexadecimal floating-point for fli instructions
Zfa provide fli instruction to load a floating point immediate value,
and some of those are not easy to write and read by human, so
hexadecimal floating-point format should be a good alternative way to write:
Consider this case: 1^-16 = 1.
52587890625e-05 (decimal) vs 0x1p-16 (hexadecimal)
The hexadecimal format is easier to write for human.
Fortunately hexadecimal floating-point constants already supported in
C99, so actually we don't need to add any extra code to support that.
This patch added test case for demonstrate we support that and also make
sure this will be supported in future.
I also gonna to talk with ISA folks to adding hexadecimal floating-point
to the ISA spec, so that user will know fli accept value in this format.
Reviewed By: asb
Differential Revision: https://reviews.llvm.org/D148077
Serge Pavlov [Fri, 14 Apr 2023 10:37:25 +0000 (17:37 +0700)]
Revert "[symbolizer] Change error message if module not found"
This reverts commit
75f1f158812dabc03e70697b6b9c272230bce63d.
It caused fail on https://lab.llvm.org/buildbot#builders/37/builds/21461
Florian Hahn [Fri, 14 Apr 2023 10:35:01 +0000 (11:35 +0100)]
[Matrix] Refine cost estimate for dot-product.
Adjust lowerDotProduct cost estimate to include the cost benefits of:
* emitting a wide load
* emitting a wide multiply.
Reviewed By: thegameg
Differential Revision: https://reviews.llvm.org/D147330
Simon Pilgrim [Fri, 14 Apr 2023 10:07:37 +0000 (11:07 +0100)]
[X86] Add AVX2 test coverage to TESTPS/TESTPD combines
Simon Pilgrim [Fri, 14 Apr 2023 10:05:51 +0000 (11:05 +0100)]
[X86] Add TESTPS/TESTPD test coverage showing failure to simplify demanded sign bit when the operands has multiple uses
Dmitry Makogon [Fri, 14 Apr 2023 10:12:17 +0000 (17:12 +0700)]
[Test] Add tests showing flags improvement for SCEV sub expressions (NFC)
Chen Zheng [Fri, 14 Apr 2023 10:16:01 +0000 (06:16 -0400)]
[AIX] enable the cases that are excluded by XCOFF 64 integrated-as support
These case are excluded in https://reviews.llvm.org/D113049.
Now AIX XCOFF 64 integrated-as support improves a lot and all these
cases pass now, so enable them.
Nikita Popov [Wed, 1 Mar 2023 08:41:59 +0000 (09:41 +0100)]
[llvm-c] Remove PassRegistry and initialization APIs
Remove C APIs for interacting with PassRegistry and pass
initialization. These are legacy PM concepts, and are no longer
relevant for the new pass manager.
Calls to these initialization functions can simply be dropped.
Differential Revision: https://reviews.llvm.org/D145043
Nico Weber [Fri, 14 Apr 2023 10:08:51 +0000 (06:08 -0400)]
[gn] Port
fcc5f9ef50e1 (GenVT)
Nikita Popov [Thu, 6 Apr 2023 08:49:42 +0000 (10:49 +0200)]
[FunctionAttrs] Fix nounwind inference for landingpads
Currently, FunctionAttrs treats landingpads as non-throwing, and
will infer nounwind for functions with landingpads (assuming they
can't unwind in some other way, e.g. via resum). There are two
problems with this:
* Non-cleanup landingpads with catch/filter clauses do not
necessarily catch all exceptions. Unless there are catch ptr null
or filter [0 x ptr] zeroinitializer clauses, we should assume
that we may unwind past this landingpad. This seems like an
outright bug.
* Cleanup landingpads are skipped during phase one unwinding, so
we effectively need to support unwinding past them. Marking these
nounwind is technically correct, but not compatible with how
unwinding works in reality.
Fixes https://github.com/llvm/llvm-project/issues/61945.
Differential Revision: https://reviews.llvm.org/D147694
Florian Hahn [Fri, 14 Apr 2023 09:40:47 +0000 (10:40 +0100)]
[Matrix] Add dot product tests with builtin loads with variable strides
Extra tests for D147330.
Kai Luo [Fri, 14 Apr 2023 09:24:30 +0000 (17:24 +0800)]
[PowerPC] Update `incr` after resetting the register in MI
After performing signed extension, we update the register in MI. We should also update `incr` register which is tracking the register in `MI`.
Fixes https://github.com/llvm/llvm-project/issues/61882.
Reviewed By: #powerpc, shchenz
Differential Revision: https://reviews.llvm.org/D147594
Nikita Popov [Mon, 20 Feb 2023 14:55:17 +0000 (15:55 +0100)]
[InstCombine] Support multiple comparisons in foldAllocaCmp()
foldAllocaCmp() needs to fold all comparisons of an alloca at the
same time, to ensure that there is a consistent view of the alloca
address. Currently, it folds "all" comparisons by limiting to the
case where there is only one. This patch switches the algorithm to
instead actually collect and fold all comparisons.
Something we need to be careful about here is that there may be
comparisons where both sides of the icmp are based on the alloca.
Such comparisons are comparing offsets of the alloca, and as such
can be ignored here, but shouldn't be folded to false.
Differential Revision: https://reviews.llvm.org/D144492
Nikita Popov [Fri, 14 Apr 2023 09:18:18 +0000 (11:18 +0200)]
[InstSimplify] Add MaxRecurse argument to simplifyInstructionWithOperands (NFC)
Christian Sigg [Fri, 14 Apr 2023 09:11:39 +0000 (11:11 +0200)]
Fix bazel build after
e5f50bd26807
Peter Smith [Tue, 11 Apr 2023 17:14:40 +0000 (18:14 +0100)]
[LLD][ARM] Handle .ARM.exidx sections at non-zero output sec offset
Embedded systems that do not use an ELF loader locate the
.ARM.exidx exception table via linker defined __exidx_start and
__exidx_end rather than use the PT_ARM_EXIDX program header. This
means that some linker scripts such as the picolibc C library's
linker script, do not have the .ARM.exidx sections at offset 0 in
the OutputSection. For example:
.except_unordered : {
. = ALIGN(8);
PROVIDE(__exidx_start = .);
*(.ARM.exidx*)
PROVIDE(__exidx_end = .);
} >flash AT>flash :text
This is within the specification of Arm exception tables, and is
handled correctly by ld.bfd.
This patch has 2 parts. The first updates the writing of the data
of the .ARM.exidx SyntheticSection to account for a non-zero
OutputSection offset. The second part makes the PT_ARM_EXIDX program
header generation a special case so that it covers only the
SyntheticSection and not the parent OutputSection. While not strictly
necessary for programs locating the exception tables via the symbols
it may cause ELF utilities that locate the exception tables via
the PT_ARM_EXIDX program header to fail. This does not seem to be the
case for GNU and LLVM readelf which seems to look for the
SHT_ARM_EXIDX section.
Differential Revision: https://reviews.llvm.org/D148033
Kristof Beyls [Wed, 12 Apr 2023 13:01:00 +0000 (15:01 +0200)]
[docs] Clarify that CoC docs are under a CC-BY license.
Differential Revision: https://reviews.llvm.org/D148121
David Stuttard [Mon, 20 Feb 2023 17:11:22 +0000 (17:11 +0000)]
[AMDGPU] Add backend support for new PAL ELF Metadata 3.0
PAL Metadata 3.0 introduces an explicit structure in metadata for the
programmable registers written out by the compiler backend.
Rather than using opaque registers which can change between different
architectures and requires encoding the bitfield information in the backend,
which may change between versions.
This is the initial minimal implementation that enables the use of PAL Metadata
3.0.
The change itself should be NFC for non-PAL, although the way RSRC2 register is
handled has been changed slightly.
The test is fairly minimal, but checks that the metadata format looks as
expected and verifies a couple of special cases such as tgid_[xyz]_en handling
and PsInputAddr/Ena which also change to explicit fields.
Differential Revision: https://reviews.llvm.org/D147143
Nikita Popov [Thu, 13 Apr 2023 08:38:56 +0000 (10:38 +0200)]
[LangRef][Local] dereferenceable metadata violation is UB
I believe !dereferencable violation is immediate undefined behavior,
but this was not explicitly spelled out in LangRef. We already
assume that !dereferenceable is implicitly !noundef and cannot
return poison in isGuaranteedNotToBeUndefOrPoison().
The reason why we made dereferenceable implicitly noundef is that
the purpose of this metadata is to allow speculation, and that
would not be legal on a potential poison pointer.
Differential Revision: https://reviews.llvm.org/D148202
Nikita Popov [Fri, 14 Apr 2023 08:35:17 +0000 (10:35 +0200)]
[InstSimplify] Remove unused ORE argument (NFC)
Diana Picus [Wed, 12 Apr 2023 09:52:44 +0000 (11:52 +0200)]
[AMDGPU] Don't S_MOV_B32 into $scc
The peephole optimizer tries to replace
```
%n:sgpr_32 = S_MOV_B32 x
$scc = COPY %n
```
with a `S_MOV_B32` directly into `$scc`.
This crashes because `S_MOV_B32` cannot take `$scc` as input.
We currently generate code like this from GlobalISel when lowering a
G_BRCOND with a constant condition. We should probably look into
removing this kind of branch altogether, but until then we should at
least not crash.
This patch fixes the issue by making sure we don't apply the peephole
optimization when trying to move into a physical register that
doesn't belong to the correct register class.
Differential Revision: https://reviews.llvm.org/D148117
Nikita Popov [Thu, 13 Apr 2023 15:34:30 +0000 (17:34 +0200)]
[Coroutines] Directly remove unnecessary lifetime intrinsics
The insertSpills() code will currently skip lifetime intrinsic users
when replacing the alloca with a frame reference. Rather than
leaving behind the dead lifetime intrinsics working on the old
alloca, directly remove them. This makes sure the alloca can be
dropped as well.
I noticed this as a regression when converting tests to opaque
pointers. Without opaque pointers, this code didn't really do
anything, because there would usually be a bitcast in between.
The lifetimes would get rewritten to the frame pointer. With
opaque pointers, this code now triggers and leaves behind users
of the old allocas.
Differential Revision: https://reviews.llvm.org/D148240
Krasimir Georgiev [Fri, 14 Apr 2023 08:18:43 +0000 (08:18 +0000)]
[sanitizer] adapt for
75f1f158812dabc03e70697b6b9c272230bce63d
No functional changes intended.
Tobias Gysi [Fri, 14 Apr 2023 07:10:15 +0000 (07:10 +0000)]
[mlir][llvm] Move the LLVM dialect definition (NFC).
The revision separates out the LLVM dialect definition in a separate
tablegen file and ensures the LLVMOpBase.td can include the attributes
defined by LLVMAttrDefs.td. The change allows us to use LLVM dialect
attributes in the definition of the intrinsic and memory operation
base classes, e.g. to represent alias analysis metadata using
attributes.
Reviewed By: Dinistro
Differential Revision: https://reviews.llvm.org/D148007
Tobias Hieta [Fri, 14 Apr 2023 07:44:35 +0000 (09:44 +0200)]
Revert "[clang-format] Handle object instansiation in if-statements"
This reverts commit
70de684d44135b4025d92b2b36ad387cf5ab8b5a.
This causes a regression as described in #61785
Jie Fu [Fri, 14 Apr 2023 07:46:09 +0000 (15:46 +0800)]
[llvm-exegesis] Fix -Wc++98-compat-extra-semi in BenchmarkRunner.cpp (NFC)
/data/llvm-project/llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp:66:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-W
c++98-compat-extra-semi]
};
^
1 error generated.
Aiden Grossman [Fri, 14 Apr 2023 07:19:10 +0000 (07:19 +0000)]
[llvm-exegesis] Refactor common parts out of FunctionExecutorImpl
This patch refactors some code out of FunctionExecutorImpl into the base
class that should be common across all implementations of
FunctionExecutor. Particularly, this patch factors out
accumulateCounterValues, and also factors out runAndSample, moving
implementation specific code into a new runWithCounter function. This
makes adding new implementations of FunctinExecutor easier.
Reviewed By: gchatelet
Differential Revision: https://reviews.llvm.org/D148079
Nathan Ridge [Fri, 14 Apr 2023 07:25:40 +0000 (03:25 -0400)]
[clangd] Fix test failure in initialize-params.test
Aiden Grossman [Fri, 14 Apr 2023 07:05:37 +0000 (07:05 +0000)]
[llvm-exegesis][NFC] remove runAndMeasure
This completes the FIXME listed in FunctionExecutor in regards to
deprecating this function. It simply makes the appropriate call into
runAndSample and grabs the first counter value. This patch completely
removes the function, moving that logic into the callers (currently only
uopsBenchmarkRunner). This makes creating new FunctionExecutors easier
as an implementation no longer needs to worry about this detail.
Reviewed By: gchatelet
Differential Revision: https://reviews.llvm.org/D147878