Chris Forbes [Wed, 21 Nov 2018 23:00:40 +0000 (15:00 -0800)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: If32356da37d199deaa38a127d317e936aadbd437
rie kanazawa [Wed, 21 Nov 2018 19:36:48 +0000 (11:36 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours am:
67fddf713c -s ours am:
e31f01c1e2 -s ours am:
2510d0d22d -s ours am:
151cae7dfb -s ours am:
6bb25b4e2a -s ours
am:
b99352ecbc -s ours
Change-Id: Ice009f7f6db7acbfc333acc5abad9b5e0f173ec5
rie kanazawa [Wed, 21 Nov 2018 19:29:45 +0000 (11:29 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours am:
67fddf713c -s ours am:
e31f01c1e2 -s ours am:
2510d0d22d -s ours am:
151cae7dfb -s ours
am:
6bb25b4e2a -s ours
Change-Id: I276fc018922f87d1dce48fd405b65c43294554cb
rie kanazawa [Wed, 21 Nov 2018 19:19:19 +0000 (11:19 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours am:
67fddf713c -s ours am:
e31f01c1e2 -s ours am:
2510d0d22d -s ours
am:
151cae7dfb -s ours
Change-Id: I9e4e516939407b1913cee168032d44b28ca766de
rie kanazawa [Wed, 21 Nov 2018 19:14:16 +0000 (11:14 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours am:
67fddf713c -s ours am:
e31f01c1e2 -s ours
am:
2510d0d22d -s ours
Change-Id: Ieb354df86d75ab4cbbf657d2c73bf296dc98084c
rie kanazawa [Wed, 21 Nov 2018 19:09:11 +0000 (11:09 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours am:
67fddf713c -s ours
am:
e31f01c1e2 -s ours
Change-Id: Iefca908d69c5bd402494b1d7a97adac5074a8f1d
rie kanazawa [Wed, 21 Nov 2018 19:05:09 +0000 (11:05 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1 am:
7d112535f4 -s ours
am:
67fddf713c -s ours
Change-Id: I0c2837dcf5546e5f04bf7f5f9014422944aa443a
rie kanazawa [Wed, 21 Nov 2018 19:00:06 +0000 (11:00 -0800)]
[automerger skipped] DO NOT MERGE: Make the tests permissive for Lollipop MR1
am:
7d112535f4 -s ours
Change-Id: Ice9443c7c783c7d047a0cb43cf8a51344ee4d414
Chad Versace [Mon, 19 Nov 2018 02:45:45 +0000 (18:45 -0800)]
[automerger skipped] Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass am:
af28fc7cd4 am:
f534ecf88b -s ours am:
835d2b641a am:
f218ba9a91
am:
2079615c03
Change-Id: I61ce1f65a5df44dda6c18d45963a179364982936
Chad Versace [Mon, 19 Nov 2018 02:41:35 +0000 (18:41 -0800)]
[automerger skipped] Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass am:
af28fc7cd4 am:
f534ecf88b -s ours am:
835d2b641a
am:
f218ba9a91
Change-Id: Ib65d14b6ddbf210d58dbab5977c9798b3e19cf11
Chad Versace [Mon, 19 Nov 2018 02:35:31 +0000 (18:35 -0800)]
[automerger skipped] Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass am:
af28fc7cd4 am:
f534ecf88b -s ours
am:
835d2b641a
Change-Id: Ib5e99b3c0a5a732e0d28e8745f13cf23ad348811
Chad Versace [Mon, 19 Nov 2018 02:30:15 +0000 (18:30 -0800)]
[automerger skipped] Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass am:
af28fc7cd4
am:
f534ecf88b -s ours
Change-Id: I87173be738c4f6b989b95cf526bd4ae3f70fe632
Chris Forbes [Fri, 16 Nov 2018 19:32:07 +0000 (11:32 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Iccdbde76e6b4282877b4b329cc0f9400c8e334e6
Alexander Galazin [Thu, 15 Nov 2018 12:13:40 +0000 (13:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: Ia8831045cbcd2ec8efe1089d624a24d24eaa19ff
Alejandro Piñeiro [Mon, 29 Oct 2018 17:42:40 +0000 (18:42 +0100)]
Fix ARB_gl_spirv multiple shader object test
Right now it fails when calling glslangUtils::spirvValidate. Note that
this test is using a custom SPIR-V shader in assembly text format,
that is then assembled for the test itself. So it seems that became
outdated.
Affects:
KHR-GL46.gl_spirv.spirv_modules_shader_binary_multiple_shader_objects_test
Components: OpenGL
VK-GL-CTS issue: 1445
Change-Id: I04b841fb3fba80537346da06bf889b21902e8da5
Toni Merilehti [Fri, 2 Nov 2018 12:13:50 +0000 (14:13 +0200)]
Split same_module tests
Test dEQP-VK.spirv_assembly.instruction.graphics.module.same_module
currently uses tessellation and geometry stages, and will only run if
the device has tessellation and geometry support. This will split
the test into four different variations and allows the test to run
without tessellation and/or geometry stages.
Components: Vulkan
VK-GL-CTS issue: 1052
New tests:
dEQP-VK.spirv_assembly.instruction.graphics.module.same_module*
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.module.same_module*
Change-Id: I10a62a313afe17cfc37360eec53102c7b06ea103
Jeff Bolz [Tue, 30 Oct 2018 19:39:14 +0000 (14:39 -0500)]
Add tests for OpSpecConstantOp INotEqual
This was the only spec constant operation missing tests.
Components: Vulkan
New Tests: dEQP-VK.spirv_assembly.instruction.*.opspecconstantop.inotequal*
Change-Id: I5549880871d9afbc95ad239f0622562e21a4312d
Jeff Bolz [Wed, 7 Nov 2018 17:37:16 +0000 (11:37 -0600)]
Update glslang/spirv-tools/spirv-headers to TOT github.
There was a revlock between these components due to the raytracing
extension rename. This updates all three to past that point. It also
picks up some updated precompiled header performance.
Components: Vulkan
Change-Id: I86a4ff8b50e4cd7ff4ddbf0dc351112d7e21d4d1
Alexander Galazin [Thu, 15 Nov 2018 10:35:52 +0000 (11:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I95716dc2f4ae3cb6bce8299415734d69337a6e68
Alexander Galazin [Thu, 15 Nov 2018 09:20:24 +0000 (10:20 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I5345587323415ff836b8b6f66a0d6fa8716107dd
Alexander Galazin [Thu, 15 Nov 2018 08:39:17 +0000 (09:39 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I93bd8195bc88e16a631bd26fc75095d3b2bbf43c
Leif-Julian Ovrelid [Thu, 8 Nov 2018 09:16:10 +0000 (10:16 +0100)]
Fix missing self dependency in renderpass tests
The dEQP-VK.renderpass.suballocation.formats and
dEQP-VK.renderpass.dedicated_allocation.formats tests were missing self
dependencies in some cases where they read then write one attachment
in one subpass. In cases with overlapping rendering this would give a
read-write-then-read-write situation, which neads a self dependency to
work reliably. Some of the tests were missing the self dependency, some
of them had the color attachment bits set when depending on depth, and
one case had a self dependency where it should not.
This patch adds a self dependency to two test cases that need it,
removes self dependency from a case that does not need it, and fixes
the depth tests to have the correct bits set.
Affects:
dEQP-VK.renderpass.suballocation.formats.*.input.*
dEQP-VK.renderpass.dedicated_allocation.formats.*.input.*
dEQP-VK.renderpass2.suballocation.formats.*.input.*
dEQP-VK.renderpass2.dedicated_allocation.formats.*.input.*
Components: Vulkan
VK-GL-CTS Issue: 1454
Change-Id: I4a9bec3ef6b088ab3a50d7f658867076f68788b9
Martin Freebody [Wed, 7 Nov 2018 12:40:32 +0000 (12:40 +0000)]
Fixes for Protected Memory
This change removes errors reported by core validation layer.
Affects: dEQP-VK.protected_memory.*
Components: Vulkan
Change-Id: Id7223e5777747345778babe83b0d9c3605a4ce1f
Graeme Leese [Thu, 8 Nov 2018 13:59:27 +0000 (13:59 +0000)]
Further validation fixes for renderpass tests
All the VkInputAttachmentAspectReference structures were pointing to
incorrect subpasses.
The multisample_resolve tests were transitioning the multisample images
to TRANSFER_SRC, which was invalid but also superfluous, so remove it.
Components: Vulkan
Affects: dEQP-VK.renderpass.*
dEQP-VK.renderpass2.*
Change-Id: I9356f9d4ee0dfa8938cd2fe9a062c732706e3a3f
Dae Kim [Thu, 1 Nov 2018 10:17:00 +0000 (10:17 +0000)]
Fix invalid color values in image.mutable tests
The color values used in the tests ended up reinterpreted as f16/f32 denorms
for some combinations of image/imageview formats (e.g. rgba16_uint -> f16/f32).
With this patch the tests select color values depending on the formats under
test and avoids denorms.
Affects:
dEQP-VK.image.mutable.*
Components: Vulkan
VK-GL-CTS issue: 1285
Change-Id: Idd7ec555261109c54af865adb344f3239e49064d
rie kanazawa [Fri, 9 Nov 2018 02:07:43 +0000 (11:07 +0900)]
DO NOT MERGE: Make the tests permissive for Lollipop MR1
dEQP-GLES3.functional.dither.disabled#gradient_white
dEQP-GLES3.functional.dither.disabled#gradient_red
dEQP-GLES3.functional.dither.disabled#gradient_green
dEQP-GLES3.functional.dither.disabled#gradient_blue
dEQP-GLES3.functional.dither.disabled#gradient_alpha
Bug:
117302647
Test: Build CTS
Test: run cts --plan CTS-DEQP --disable-reboot
https://android.googlesource.com/platform/external/deqp/+/
8c44b09211d253dfc09bc8b7dfbc1f60c277d9f6%5E%21/#F0
modules/gles2/functional/es2fDitheringTests.cpp
modules/gles3/functional/es3fDitheringTests.cpp
Bug:
23219552
+
https://android.googlesource.com/platform/external/deqp/+/
085b52b2cda2eb522aa80f207d814dfc96bac84b%5E%21/#F0
Bug:
37477346
Change-Id: I013c970e84e764ce9ac49f1ecc7620369162388c
Signed-off-by: rie kanazawa <rie.kanazawa.sd@kyocera.jp>
rie kanazawa [Tue, 13 Nov 2018 17:59:54 +0000 (09:59 -0800)]
Merge "Fixes AHB image tests feature check" into pie-cts-dev
am:
75df06fe5b
Change-Id: Ibe27329f6292965a360a6153f1c4a9ac89212dae
Treehugger Robot [Tue, 13 Nov 2018 17:54:25 +0000 (17:54 +0000)]
Merge "Fixes AHB image tests feature check" into pie-cts-dev
Chris Forbes [Tue, 13 Nov 2018 00:55:39 +0000 (16:55 -0800)]
Merge remote-tracking branch 'aosp/master' into HEAD
Change-Id: I5293daab2672e663e07ee88e522b2d56ccb0e226
Pierre Couillaud [Wed, 31 Oct 2018 11:57:40 +0000 (04:57 -0700)]
Add watchdog touches to dEQP-VK.api.descriptor_pool#repeated_reset_long
On some low-end devices, this test would hit the dEQP watchdog. Add some
watchdog touches to avoid this.
Google Bug: b/
116847904
Component: Vulkan
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
VK-GL-CTS Issue: 1464
Change-Id: I18181aa274ab1dc191b5f0acbb58b41465b5cdad
Chris Forbes [Sat, 10 Nov 2018 02:19:37 +0000 (18:19 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: I9fb09ca034ae6ad506df24a8c49cca6a0fb0edec
Mika Väinölä [Wed, 3 Oct 2018 13:03:46 +0000 (16:03 +0300)]
Suppress Clang 7 self-assignment warnings
Clang 7 warns on two intentional self-assignments. According to the
release notes "the warning can be suppressed by adding *& to the
right-hand side or casting it to the appropriate reference type."
Component: Framework
VK-GL-CTS issue: 1401
Change-Id: I3145b1965d46f617eb10ff8a60d038ce9bbb5cbf
(cherry picked from commit
3aa55b5b9bd903f279e234304a2affd409b18e8d)
Chris Forbes [Fri, 9 Nov 2018 18:16:07 +0000 (10:16 -0800)]
Merge remote-tracking branch 'aosp/master' into HEAD
Change-Id: I0a5e228d7357f3041ab4b1d22937171943922196
Chris Forbes [Fri, 9 Nov 2018 17:25:40 +0000 (09:25 -0800)]
[automerger skipped] RESTRICT AUTOMERGE: Remove accidentally introduced tests from mustpass am:
a7471afa4b -s ours
am:
4136a69fa6 -s ours
Change-Id: I53cec3231e4e61db6b1455d0b69b6d39d64a3ea3
Chris Forbes [Fri, 9 Nov 2018 17:21:36 +0000 (09:21 -0800)]
[automerger skipped] RESTRICT AUTOMERGE: Remove accidentally introduced tests from mustpass
am:
a7471afa4b -s ours
Change-Id: I4e22b26921b16eb10bd9ad11beb78dd9bad1c56f
Piers Daniell [Thu, 8 Nov 2018 18:57:05 +0000 (11:57 -0700)]
Update SPIR-V compiler wrapper for OpenGL
This copies the change for Vulkan made in:
https://gerrit.khronos.org/#/c/2980/
Change-Id: I30ebb4cc9c131480df5c27a4846d7cb664df4cb9
Components: OpenGL
Graeme Leese [Thu, 10 May 2018 11:11:48 +0000 (12:11 +0100)]
Use the correct type for image creation flags
Components: Vulkan
Affects: dEQP-VK.api.info.image_format_properties2.*
Change-Id: I73fe492be9da52f9feb1aa32a1d161c9214b767d
Chris Forbes [Fri, 9 Nov 2018 06:23:00 +0000 (22:23 -0800)]
Merge remote-tracking branch 'khronos/vulkan-cts-1.1.0' into pie-cts-dev
am:
2c584d1656
Change-Id: I51626c152df4d664f6c47e02e3dca5aefd600c84
rie kanazawa [Fri, 9 Nov 2018 01:28:32 +0000 (10:28 +0900)]
Fixes AHB image tests feature check
Test now checks for protected feature
before adding protected flag to test set.
Components: Vulkan
VK-GL-CTS issue: 1396
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.*
https://android.googlesource.com/platform/external/deqp/+/
7a014a8de760c111e14ad21c851acadc27358562%5E%21/#F0
Change-Id: I050ef6501bad37b8169a333040c937ac1ce49eb3
Signed-off-by: rie kanazawa <rie.kanazawa.sd@kyocera.jp>
Chris Forbes [Thu, 8 Nov 2018 16:21:59 +0000 (08:21 -0800)]
Merge remote-tracking branch 'khronos/vulkan-cts-1.1.0' into pie-cts-dev
Regular merge, including upstream fix for b/
118452882
Bug: b/
118452882
Change-Id: I966a995914bfa905814ce653857c27335e825624
Alexander Galazin [Thu, 8 Nov 2018 13:55:15 +0000 (14:55 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I16aa60e3d83febd0e9268ed51eebe8d0671768e7
Alexander Galazin [Thu, 8 Nov 2018 12:40:50 +0000 (13:40 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I07c6dba293349d24486832cbd2288c765f647003
Ari Suonpaa [Thu, 4 Oct 2018 09:26:29 +0000 (12:26 +0300)]
Added framework function for image to buffer copy
Several existing tests have their own implementation for
copying image to a buffer. Use a framework function where
it leads to a cleaner code.
Affects:
dEQP-VK.api.buffer_view.access.*
dEQP-VK.api.command_buffers.*
dEQP-VK.api.smoke.*
dEQP-VK.binding_model.shader_access.*
dEQP-VK.compute.basic.*
dEQP-VK.draw.shader_layer.*
dEQP-VK.draw.shader_viewport_index.*
dEQP-VK.fragment_operations.early_fragment.*
dEQP-VK.fragment_operations.scissor.multi_viewport.*
dEQP-VK.fragment_operations.scissor.*
dEQP-VK.geometry.*
dEQP-VK.memory.binding.*
dEQP-VK.memory.external_memory_host.*
dEQP-VK.pipeline.multisample.sampled_image.*
dEQP-VK.pipeline.multisample.storage_image.*
dEQP-VK.pipeline.shader_stencil_export.*
dEQP-VK.rasterization.*
dEQP-VK.renderpass*.multisample_resolve.*
dEQP-VK.renderpass*.multisample.*
dEQP-VK.renderpass*.sampleread.*
dEQP-VK.renderpass*.sparserendertarget.*
dEQP-VK.glsl.*
dEQP-VK.sparse_resources.buffer.*
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.*
dEQP-VK.subgroups.*
dEQP-VK.tessellation.common_edge.*
dEQP-VK.tessellation.geometry_interaction.scatter.*
dEQP-VK.tessellation.geometry_interaction.passthrough.*
dEQP-VK.tessellation.geometry_interaction.point_size.*
dEQP-VK.tessellation.misc_draw.*
dEQP-VK.tessellation.primitive_discard.*
dEQP-VK.tessellation.shader_input_output.*
dEQP-VK.tessellation.user_defined_io.*
dEQP-VK.tessellation.winding.*
dEQP-VK.texture.*
dEQP-VK.ubo.*
Components: Vulkan
VK-GL-CTS issue: 1375
Change-Id: Ib2041e801446ea78d8591c348c3b438061de9a67
Alexander Galazin [Thu, 8 Nov 2018 11:52:47 +0000 (12:52 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I7e4ffa1e9b7956f0c77ee9b8dfc3d958743c0929
Thomas Spurden [Thu, 1 Nov 2018 17:56:19 +0000 (17:56 +0000)]
Correct invalidate->flush after writing to host-mapped memory
Affects:
dEQP-VK.pipeline.push_constant.graphics_pipeline.*
Change-Id: Iee43b30343581efe94b606811d2dc90c0bcd6993
Components: Vulkan
Dae Kim [Tue, 6 Nov 2018 10:01:43 +0000 (10:01 +0000)]
Specify PointSize when drawing point lists
Test cases for vertex stages are using VK_PRIMITIVE_TOPOLOGY_POINT_LIST without
specifying a value for gl_PointSize in the vertex shader.
Affects:
dEQP-VK.binding_model.descriptorset_random.*vert*
dEQP-VK.memory_model.message_passing.*vert*
Components: Vulkan
VK-GL-CTS issue: 1450
Change-Id: If1279a0b2a5989a267c57d72f2495c790dcdc4bb
Chad Versace [Mon, 15 Oct 2018 19:45:46 +0000 (12:45 -0700)]
Fix swapchain creation in dEQP-VK.wsi.*.swapchain.*
In the Vulkan 1.1.87 spec release, the release fixed a bug in
VkSwapchainCreateInfoKHR by adding the following VU:
* imageFormat, imageUsage, imageExtent, and imageArrayLayers must be
supported for VK_IMAGE_TYPE_2D VK_IMAGE_TILING_OPTIMAL images as
reported by vkGetPhysicalDeviceImageFormatProperties.
Jesse Hall authored the fix in response to behavior discovered by Chad
Versace while debugging failures in dEQP-VK.wsi.android.swapchain.* on
Intel Chrome OS devices. This patch fixes the failing tests to comply
with the spec bugfix.
Components: Vulkan
VK-GL-CTS Issue: 1395
Affects: dEQP-VK.wsi.*.swapchain.*
See-Also: https://gitlab.khronos.org/vulkan/vulkan/issues/1029
Change-Id: I959774833d03b63eb6e23fbd3a7ff33378b44110
(cherry picked from commit
49eab80e4a8b3af1790b9ac88b096aa9bffd193f)
Chris Forbes [Wed, 7 Nov 2018 22:27:40 +0000 (14:27 -0800)]
RESTRICT AUTOMERGE: Remove accidentally introduced tests from mustpass
Upstream change to fix these tests only altered the Khronos mustpass
files; I missed the corresponding Android CTS change. Exclude the tests
now.
Change-Id: If3a49291330b0021559e2a9efc54b74b1f3c2af1
Components: AOSP mustpass
Bug: b/
118828237
Ari Suonpaa [Thu, 27 Sep 2018 10:05:47 +0000 (13:05 +0300)]
Utilize copyBufferToImage framework function where possible
Several existing tests have their own implementation for
copying buffer to an image. Use a framework function where
it leads to a cleaner code.
Affects:
dEQP-VK.binding_model.shader_access.*
dEQP-VK.compute.basic.copy_image_to_ssbo*
dEQP-VK.geometry.basic.*
dEQP-VK.image.atomic_operations.*
dEQP-VK.multiview.*
dEQP-VK.glsl.*
dEQP-VK.spirv_assembly.instruction.graphics.*
dEQP-VK.texture.explicit_lod.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1376
Change-Id: Icfda7bdde1e8e0a7bf77ccb36bf4ca948d45a200
Ari Suonpaa [Thu, 25 Oct 2018 10:46:17 +0000 (13:46 +0300)]
Fixed unused attachment tests to properly use renderpass2
Unused attachment tests under renderpass group were still
using a legacy renderpass API. Now the tests under
renderpass2 group properly use the correct functions and
structures. Also removed final layout parameter from tests
since they are generating a validation error. It was
confirmed the validator is correctly checking the final
layout even when the attachment is unused.
Affects:
dEQP-VK.renderpass*.unused_attachment.*
Components: Vulkan
VK-GL-CTS issue: 1397
Change-Id: Ib14828ee37371a702303cc5c6a91a4fb76a74724
Graeme Leese [Wed, 25 Apr 2018 20:15:24 +0000 (21:15 +0100)]
SubgroupBallot: Don't test 0 <= id
Since id is a uint this is always true.
Components: Vulkan
Affects: dEQP-VK.subgroups.ballot_broadcast.*
Change-Id: I57065c9748126c71e22ee7d38b7501c2db175396
Graeme Leese [Tue, 17 Apr 2018 16:45:09 +0000 (17:45 +0100)]
Rationalise the 'check*' functions in subgroups
There are loads of these and they all do the same thing. Move them to
the common subgroups utils section and reuse them throughout the tests.
Components: Vulkan
Affects: dEQP-VK.subgroups.*
Change-Id: Ie2373d53b77234eba7a8afa6acdbbaf12c89e9f8
Graeme Leese [Tue, 30 Oct 2018 16:54:58 +0000 (16:54 +0000)]
Remove one copy of the clustered test sources
We really shouldn't have duplicates of test code like this.
Components: Vulkan
Affects: dEQP-VK.subgroups.clustered.*
Change-Id: I3b32d6d7f3762d2d21375aa9b8095b0f64543942
Graeme Leese [Wed, 24 Oct 2018 10:59:48 +0000 (11:59 +0100)]
Further validation fixes for renderpass tests
Correct synchronisation for multisample tests and include stencil usage
in pipline barriers.
Component: Vulkan
Affects: dEQP-VK.renderpass.*
dEQP-VK.renderpass2.*
Change-Id: I481dca4a2544911a36cdb9773efe4e7ad1a94c7f
Kacper Kleczewski [Tue, 23 Oct 2018 12:50:51 +0000 (13:50 +0100)]
Fix case when unsuported create flag was used for AHB
Additional validation step is added to ValidateAHardwareBuffer function
which return false if API level is lower than 28 and
VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT create flag is requested.
Components: Vulkan
Affects: dEQP-VK.api.external.memory.android_hardware_buffer.image_formats
VK-GL-CTS Issue: 1439
Change-Id: Iadaa5c1d584bbf3d3335952c501799aff3c5b2d6
Alexander Galazin [Tue, 6 Nov 2018 13:01:44 +0000 (08:01 -0500)]
Merge "Merge vk-gl-cts/github-master into vk-gl-cts/master"
Alexander Galazin [Tue, 6 Nov 2018 12:12:37 +0000 (13:12 +0100)]
Merge vk-gl-cts/github-master into vk-gl-cts/master
Change-Id: I6e7da6cfd1fe7d69bccf4231f4b04d9d3fdbd30b
Alexander Galazin [Tue, 6 Nov 2018 11:44:00 +0000 (12:44 +0100)]
Merge pull request #131 from werman/vulkan/VK_EXT_conditional_rendering
Add tests for VK_EXT_conditional_rendering
Alexander Galazin [Tue, 6 Nov 2018 11:41:45 +0000 (12:41 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I0bc9d40f5467c3fcef1840984651ed3cdb953e5c
Alexander Galazin [Tue, 6 Nov 2018 10:59:01 +0000 (11:59 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ia532a2dca73418c4dda309ff8f3b58c5d7da15e7
Alexander Galazin [Thu, 1 Nov 2018 10:24:35 +0000 (11:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I5874225ecf8aae48bd833a15492668a83f985f38
Yogesh Gole [Wed, 17 Oct 2018 11:21:19 +0000 (16:51 +0530)]
Terminate EGL display after use
Previously function getDefaultEglConfigList destroyed native
display but did not terminate the EGL display. It may happen
that next create call will allocate native display at same
address as previous and as per spec multiple calls made to
eglGetPlatformDisplayEXT with the same <platform> and
<native_display> will return the same EGLDisplay handle. But
returned EGLDisplay will have references to stale data.
To fix this destroy the EGL Display along with native display.
Affects: CTS-Configs.*
Components: OpenGL and Framework
VK-GL-CTS Issue: 1426
Change-Id: I8e4c7d693d26bd9be6d7f892d0b5162d9b2b245c
Alexander Galazin [Thu, 1 Nov 2018 09:53:29 +0000 (10:53 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I587d40c09a99e93dd4cccf359ceba1dbf9ff47a9
Slawomir Cygan [Tue, 4 Sep 2018 10:16:20 +0000 (12:16 +0200)]
Extend push desriptors test to 128 compute dispatches
This adds new test case with 128 compute dispatches,
each with different pushed descriptor offset being pushed.
Component: Vulkan
VK-GL-CTS Issue: 1429
New Tests: dEQP-VK.pipeline.push_descriptor.compute.binding1_numcalls128_storage_buffer
Change-Id: Ib5914e034679c962fadf6dcadfb722a85a468c6d
Piotr Byszewski [Thu, 25 Oct 2018 14:50:20 +0000 (16:50 +0200)]
Correct vertex input tests on null driver
On Null driver all features are enabled and this triggered execution
of tests for 128 vertex attributes that are not commonly supported.
Tests allocate buffer for verification which is not big enough for
128 attributes. This causes memory corruption and crash.
This change resolves those issues.
Components: Vulkan
VK-GL-CTS issue: 1443
Affects:
dEQP-VK.pipeline.vertex_input.*
Change-Id: I9a89cc62fdd34f9da40ebf9d84e6cf5b5aed07d5
Slawomir Cygan [Wed, 24 Oct 2018 14:19:20 +0000 (16:19 +0200)]
Use GENERAL image layout for images used as STORAGE image
The test was using VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
which is not valid for STORAGE images.
Components: Vulkan
VK-GL-CTS Issue: 1441
Affects:
dEQP-VK.pipeline.push_descriptor.*
Change-Id: Ic858ba32ce04601541a224aecbc105f42a36687d
Piotr Byszewski [Tue, 23 Oct 2018 09:42:49 +0000 (11:42 +0200)]
Correct image properties tests on Null driver
On Null driver all features are enabled and this trigered some issues
with YCBCR format in image_format_properties tests. This change
resolves those issues.
VK-GL-CTS issue: 1438
Components: Vulkan
Change-Id: I3d1707438909ae4f5e828092a97a6380b615beca
Affects: dEQP-VK.api.info.image_format_properties.*
Jari Komppa [Wed, 24 Oct 2018 09:18:40 +0000 (12:18 +0300)]
Fix for unnormalized coordinate test using mipmaps
The unnormalized coodinate test used textures with mipmaps, while
unnormalized coordinates are only defined for single mip level textures.
This required adding new constructors to the texture framework that
allow explicit setting of mip levels.
Affects:
dEQP-VK.texture.filtering.unnormal.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1390
Change-Id: Ibd049a04d143979624d10148e3911728579b3a2c
Ilkka Saarelainen [Thu, 25 Oct 2018 13:06:58 +0000 (16:06 +0300)]
Fix API usage errors in dEQP-VK.geometry.basic.*
Fixes API usage errors caused by unsafe memory flush
and unsupported combinations of image memory barrier
dstAccessMask and dstStageMask.
Components: Vulkan
Affects:
dEQP-VK.geometry.basic.*
VK-GL-CTS issue: 1418
Change-Id: Iaa226bff5728a711b79f863b990b950cf95dd1c6
Chad Versace [Mon, 15 Oct 2018 19:45:46 +0000 (12:45 -0700)]
Fix swapchain creation in dEQP-VK.wsi.*.swapchain.*
In the Vulkan 1.1.87 spec release, the release fixed a bug in
VkSwapchainCreateInfoKHR by adding the following VU:
* imageFormat, imageUsage, imageExtent, and imageArrayLayers must be
supported for VK_IMAGE_TYPE_2D VK_IMAGE_TILING_OPTIMAL images as
reported by vkGetPhysicalDeviceImageFormatProperties.
Jesse Hall authored the fix in response to behavior discovered by Chad
Versace while debugging failures in dEQP-VK.wsi.android.swapchain.* on
Intel Chrome OS devices. This patch fixes the failing tests to comply
with the spec bugfix.
Components: Vulkan
VK-GL-CTS Issue: 1395
Affects: dEQP-VK.wsi.*.swapchain.*
See-Also: https://gitlab.khronos.org/vulkan/vulkan/issues/1029
Change-Id: I959774833d03b63eb6e23fbd3a7ff33378b44110
Danylo Piliaiev [Fri, 12 Oct 2018 15:19:55 +0000 (18:19 +0300)]
Add tests for VK_EXT_conditional_rendering
All functions affected by VK_EXT_conditional_rendering are tested:
- vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect
- vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR (VK_KHR_draw_indirect_count)
- vkCmdDispatch, vkCmdDispatchIndirect, vkCmdDispatchBase
- vkCmdClearAttachments
The only limitation of these tests is that combination of different functions in one render
pass are not tested - only several calls of the same functions. Due to the different hardware
specific support of conditional rendering some implementations may have exhibit issues in such cases,
especially when combining conditional rendering with functions from VK_KHR_draw_indirect_count.
Components: Vulkan
New Tests: dEQP-VK.conditional_rendering.*
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Tim Van Patten [Fri, 5 Oct 2018 22:14:47 +0000 (16:14 -0600)]
Add option for Android dEQP builds to link against and embed ANGLE shared object libraries
Add the option '--angle-path' to scripts/android/build_apk.py to point
to the directory containing ANGLE shared object libraries for the
specified ABI. This will cause dEQP to link against and embed the ANGLE
shared object libraries and use them during the dEQP test execution.
Components: Android dEQP
Google bug:
80239516
Change-Id: I04043d03b7837601656690126296e61b8ed9e658
Jeff Bolz [Fri, 19 Oct 2018 04:00:34 +0000 (23:00 -0500)]
Use precompiled headers on MSVC
This is a significant improvement in build time on MSVC,
maybe 25% overall. Qualitatively, compile time is about 2x
faster, but link time, lack of parallelism for the whole
duration of the build, and some unaccelerated components
(e.g. glslang and some internal modules) reduce the total
wall clock time improvement from 50% down to that 25%.
This also helps a lot with performance of the builds for
generating mustpass lists.
Components: Vulkan, OpenGL, Framework
Change-Id: I6013d9728444d9892e9a5ec8f31a574c10ca06b2
Chad Versace [Tue, 30 Oct 2018 22:04:00 +0000 (15:04 -0700)]
[automerger skipped] Merge "DO NOT MERGE: Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass" into oreo-cts-dev am:
6ce6b470e8 -s ours am:
b052cc76eb -s ours
am:
be0cc29007 -s ours
Change-Id: If90fc129cd86fa0cdb688322a8998427785dc1e1
Chad Versace [Tue, 30 Oct 2018 21:56:13 +0000 (14:56 -0700)]
[automerger skipped] Merge "DO NOT MERGE: Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass" into oreo-cts-dev am:
6ce6b470e8 -s ours
am:
b052cc76eb -s ours
Change-Id: Ie1f6a56414bb43e3f4c5b984bd4d872c95fda0f8
Chad Versace [Tue, 30 Oct 2018 21:47:33 +0000 (14:47 -0700)]
[automerger skipped] Merge "DO NOT MERGE: Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass" into oreo-cts-dev
am:
6ce6b470e8 -s ours
Change-Id: I900438ef0c942d45cdf2daeb23dfc7f41819b54b
Treehugger Robot [Tue, 30 Oct 2018 21:36:20 +0000 (21:36 +0000)]
Merge "DO NOT MERGE: Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass" into oreo-cts-dev
Chad Versace [Wed, 3 Oct 2018 16:49:01 +0000 (09:49 -0700)]
DO NOT MERGE: Drop dEQP-VK.image.qualifiers.{coherent,volatile}.* from mustpass
The 'coherent' and 'volatile' tests fail on some drivers due to glslang
issues. Fixed by commit
8e6e8fd31fe4c4f162db07c632da345c0e17cc7d, which
updates glslang in external/fetch_sources.py.
Bug:
113541746
See-Also: https://b.corp.google.com/issues/
113541746#comment17
Change-Id: I9c9e8bb08d5e23769c6ad36def6356f06d8ba382
Chris Forbes [Fri, 26 Oct 2018 21:58:04 +0000 (14:58 -0700)]
[automerger skipped] RESTRICT AUTOMERGE: Relax composite-to-present latency requirement am:
2b6581ff37 -s ours am:
ab1d7892bc -s ours
am:
8a6117ca3f -s ours
Change-Id: I595afdfb67a3e6bedaa995825250eb6f8174cbb2
Chris Forbes [Fri, 26 Oct 2018 21:51:34 +0000 (14:51 -0700)]
[automerger skipped] RESTRICT AUTOMERGE: Relax composite-to-present latency requirement am:
2b6581ff37 -s ours
am:
ab1d7892bc -s ours
Change-Id: I0ff93a883aa47511d94e67dc10db54899e1a1951
Chris Forbes [Fri, 26 Oct 2018 21:48:24 +0000 (14:48 -0700)]
[automerger skipped] RESTRICT AUTOMERGE: Relax composite-to-present latency requirement
am:
2b6581ff37 -s ours
Change-Id: I67b1715bd1c85f8ab2199a5e9e4fba67693279fd
Chris Forbes [Fri, 26 Oct 2018 18:45:08 +0000 (11:45 -0700)]
RESTRICT AUTOMERGE: Relax composite-to-present latency requirement
Some very low end devices can't reliably do this. Relax in 8.0 CTS; will
keep the 3-frame requirement for 8.1 CTS and later.
Bug: b/
70334851
Change-Id: I330b8a48af95e4d76cb5f7d06cacc458649dba25
Piotr Byszewski [Fri, 24 Aug 2018 16:05:26 +0000 (18:05 +0200)]
Extend transcoding tests to 1D/3D images
Previously implementation assumed that
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT feature is
only for 2D images. This change executes most of the tests
aslo for 1D and 3D images.
Components: Vulkan
VK-GL-CTS issue: 1209
Affects:
dEQP-VK.image.texel_view_compatible.*
Change-Id: Iefc2b4f5658b39836cb28a62e9d38d3c4662cfbe
Alexander Galazin [Thu, 25 Oct 2018 19:17:25 +0000 (21:17 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: Idfc653d433d9eaadcf155da6e3ab94f76662e8e9
Alexander Galazin [Thu, 25 Oct 2018 15:27:30 +0000 (17:27 +0200)]
Add 1.1.2.2 to known conformance versions
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I4bcd1140981c7eac4b5e3a97da3cfc8458520448
Steve Hill [Thu, 25 Oct 2018 09:36:50 +0000 (10:36 +0100)]
Fix uninitialised variable warning for some compilers
Some compilers seem to get confused as to whether the scope
string-variable is initialised properly.
This change makes the switch that sets it up consistent with the
other switches and pacifies those compilers.
Components: Vulkan
Affects: dEQP-VK.memory_model.*
VK-GL-CTS issue: 1442
Change-Id: Id5ff742c85510af173020cf1bbfc16429a33f29f
Alexander Galazin [Thu, 25 Oct 2018 16:33:14 +0000 (18:33 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ic2ef309419e39a4b2baf634017e25979d743a607
Mika Väinölä [Thu, 27 Sep 2018 14:03:15 +0000 (17:03 +0300)]
Test 2D texture swizzles with VkComponentMappings
Add an optional VkComponentMapping parameter to TextureRenderer and
new tests that verify quads rendered with given component mapping are
swizzled correctly.
New tests:
dEQP-VK.texture.swizzle.component_mapping.*
Components: Vulkan
VK-GL-CTS issue: 1394
Change-Id: I33601e8eaed134462defabfa007fe0c9103c869a
Alexander Galazin [Thu, 25 Oct 2018 15:03:10 +0000 (17:03 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I2d8288ee3b75ef786496453b0efa6591f4f5c0ad
Alexander Galazin [Thu, 25 Oct 2018 13:52:47 +0000 (15:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: Ic87368f606cb8ec126d42ec9f72b1baffcdcf950
Noah Fredriks [Wed, 11 Jul 2018 21:56:05 +0000 (17:56 -0400)]
Fix incomplete VkImageSubresourceRange
Pipeline image barrier arraySize doesn't include the entire image.
Affects: dEQP-VK.api.copy_and_blit.core.resolve_image.whole_array*
Components: Vulkan
VK-GL-CTS Issue: 910
Change-Id: I9974c9390478cf70f2238e03a7180fc81166f84e
Alexander Galazin [Thu, 25 Oct 2018 12:46:24 +0000 (14:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I52a560f1c5cbd065182b36b6e8bff7d3a9c81879
Alexander Galazin [Thu, 25 Oct 2018 12:20:14 +0000 (14:20 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ie74a921aba656d271738734379ad7bf5ff596fa4
Alexander Galazin [Thu, 25 Oct 2018 11:51:47 +0000 (13:51 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I116b300bfdd3ee78827aa671a737de007eb241ef
Slawomir Cygan [Mon, 22 Oct 2018 11:12:16 +0000 (13:12 +0200)]
Fix spelling on NotSupported error message
Components: Vulkan
VK-GL-CTS Issue: 1433
Affects: dEQP-VK.api.info.device_group.peer_memory_features
Change-Id: I42e2d7a50d2f74d706e42f0f196ff76c8446fa1c
Ari Suonpaa [Wed, 17 Oct 2018 10:33:03 +0000 (13:33 +0300)]
Added tests for out-of-order attribute locations
Extended vertex input tests to issue attribute locations
out-of-order.
New tests:
dEQP-VK.pipeline.vertex_input.*.out_of_order.*
Components: Vulkan
VK-GL-CTS issue: 1416
Change-Id: I2e0a90a14c3c663bbf4dd3b4d0b9a73cbdb859a3
Connor Abbott [Thu, 18 Oct 2018 12:20:31 +0000 (14:20 +0200)]
Make VK_KHR_shader_subgroup_vote tests work with sparse dispatch
The voteallequal tests created a value which was supposed to be
different for some threads in the subgroup, and then called
voteAllEqual() on it expecting it to return false. However, because the
entire expression was reduced modulo 2, if the implementation dispatched
threads in a sparse manner so that some subgroup indices were skipped,
then all the active threads could have wound up with the same value. In
particular, this caused the graphics voteallequal tests to fail in the
fragment stage on AMD due to how the hardware dispatches single-pixel
point sprites.
Fix this by just using gl_SubgroupIndex directly, so that every thread
is guaranteed to get a unique value. Some care has to be taken for
boolean values -- I've just made them use subgroupElect() instead, as
that's the simplest way to get a guaranteed-divergent boolean value.
Affected tests:
dEQP-VK.subgroups.vote.*
Components: Vulkan
VK-GL-CTS Issue: 1437
Change-Id: I10ddc438db4cd4925bdbc4f458a082fcab9c9155
Gary Sweet [Mon, 22 Oct 2018 11:39:09 +0000 (12:39 +0100)]
Fix unaligned host accesses in UBO and SSBO tests
Prevent uniform blocks from starting unaligned.
Previously these tests would end up casting
non-4-byte aligned addresses to float*. On 32-bit
ARM CPUs this can cause unaligned access faults.
Components: Vulkan
Affects:
dEQP-VK.ubo.*
dEQP-VK.ssbo.*
VK-GL-CTS issue: 1434
Change-Id: Ied437b150b61f11630b5c1511ccedd410308b004
Steve Hill [Mon, 22 Oct 2018 08:48:57 +0000 (09:48 +0100)]
Add flush to binding descriptor set random tests
Components: Vulkan
Affects: dEQP-VK.binding_model.descriptorset_random.*
VK-GL-CTS issue: 1432
Change-Id: I56df9fefbeb511e441310df9f52d0e9a897bcbef
Mohd Faisal [Fri, 19 Oct 2018 09:35:36 +0000 (10:35 +0100)]
Fix the device_group test failure by allowing same number of tries to
create object as device test.
Components: Vulkan
Affects: dEQP-VK.api.object_management.alloc_callback_fail.device_group
VK-GL-CTS Issue: 1431
Change-Id: I099a05f3109c1997cad323a0577f66c95755b151