Johann [Tue, 25 Jan 2011 21:40:28 +0000 (13:40 -0800)]
Merge "update sse2 regular quantizer"
Johann [Tue, 25 Jan 2011 21:09:05 +0000 (13:09 -0800)]
Merge "move new neon subpixel function"
Johann [Tue, 25 Jan 2011 20:49:52 +0000 (12:49 -0800)]
Merge "Fix issue 262, vp8cx_pack_tokens_into_partitions_armv5"
Johann [Tue, 25 Jan 2011 20:11:39 +0000 (15:11 -0500)]
move new neon subpixel function
previously wasn't guarded with ifdef ARMV7, causing a link error with
ARMV6
Change-Id: I0526858be0b5f49b2bf11e9090180b2a6c48926d
Yunqing Wang [Tue, 25 Jan 2011 17:54:23 +0000 (09:54 -0800)]
Merge "Modify calling of NEON code in sub-pixel search"
Attila Nagy [Mon, 17 Jan 2011 11:00:08 +0000 (13:00 +0200)]
Fix issue 262, vp8cx_pack_tokens_into_partitions_armv5
http://code.google.com/p/webm/issues/detail?id=262
Function was asuming that partitions have equal amount of mb_rows,
which is not always true.
Change-Id: I59ed40117fd408392a85c633beeb5340ed2f4b25
Paul Wilkins [Tue, 25 Jan 2011 13:32:26 +0000 (05:32 -0800)]
Merge "Incorrect bit allocation in forced KF groups."
Paul Wilkins [Tue, 25 Jan 2011 12:29:06 +0000 (12:29 +0000)]
Incorrect bit allocation in forced KF groups.
The old 2 pass code estimated error distribution when coding a
forced (by interval) key frame. The result of this was that in some
cases, when allocating bits at the GF group level within a KF
group there was either a glut of bits or starvation of bits at the end
of the KF group.
Added code to rescan and get the correct data once the position of
a forced key frame has been determined.
Change-Id: I0c811675ef3f9e4109d14bd049d7641682ffcf11
James Berry [Mon, 24 Jan 2011 21:48:21 +0000 (16:48 -0500)]
configure.sh fix for visual studio
-For targets with external build systems like visual
studio CC is not set so check_add_cflags will fail.
Only call this function if extra_cflags is set.
Change-Id: I3531bad69e9b6a59c5be1b0e8b6053ccccbc332c
Scott LaVarnway [Wed, 29 Dec 2010 19:30:57 +0000 (14:30 -0500)]
Added vp8_update_zbin_extra
vp8cx_mb_init_quantizer was being called for every mode checked
in vp8_rd_pick_inter_mode. zbin_extra is the only value that
really needs to be recalculated. This calculation is disabled
when using the fast quantizer for mode selection.
This gave a small performance boost (~.5% to 1%).
Note: This needs to be verified with segmentation_enabled.
Change-Id: I62716a870b3c82b4a998bdf95130ff0b02106f1e
Yunqing Wang [Fri, 21 Jan 2011 19:07:17 +0000 (11:07 -0800)]
Merge "Modify sub-pixel filters to eliminate unnecessary calculations"
Yunqing Wang [Thu, 20 Jan 2011 18:01:30 +0000 (13:01 -0500)]
Modify sub-pixel filters to eliminate unnecessary calculations
In sub-pixel calculation, xoffset and yoffset mostly take some
specific values. Modified sub-pixel filter functions according to
these possible values to improve performance.
Change-Id: I83083570af8b00ff65093467914fbb97a4e9ea21
Paul Wilkins [Fri, 21 Jan 2011 17:52:00 +0000 (17:52 +0000)]
Modified static scene check.
Added code to scan ahead a few frames when we see what
we think is a static scene in the two pass GF loop to see if the
conditions persist.
Moved calculation of decay rate out into a fuunction.
Change-Id: I6e9c67e01ec9f555144deafc8ae67ef25bffb449
Paul Wilkins [Thu, 20 Jan 2011 18:01:20 +0000 (18:01 +0000)]
Further work to reduce pulsing.
These changes are specifically targeted at fade transitions to
static scenes. Here we want to place a GF/ARF immediately
after the fade and prevent an ARF just before the fade.
Also some code lines and comment lines shortened to 80 chars
while I was there.
Change-Id: Iefdc09a4fa7b265048fc017246b73e138693950f
Attila Nagy [Thu, 20 Jan 2011 12:46:57 +0000 (14:46 +0200)]
Update configure scripts
Add --extra-cflags as config parameter for user defined extra CFLAGS.
Add -g to asflags when debug enabled for arm targets.
Change-Id: Ibdde7cfdda6736c1c1db45e6466bd08504a51f15
Adrian Grange [Thu, 20 Jan 2011 13:13:33 +0000 (13:13 +0000)]
Fixed use of motion percentage in KF/GF group calc
In both vp8_find_next_key_frame and define_gf_group,
motion_pct was initialised at the top of the loop before
next_frame stats had been read in.
This fix sets motion_pct after next_frame stats have
been read.
Change-Id: I8c0bebf372ef8aa97b97fd35b42973d1d831ee73
Paul Wilkins [Wed, 19 Jan 2011 16:33:34 +0000 (08:33 -0800)]
Merge "First pass loop bug."
Paul Wilkins [Wed, 19 Jan 2011 15:50:22 +0000 (15:50 +0000)]
First pass loop bug.
Incorrect value loop_decay_rate used in GF loop.
The intent was to test the cumulative value decay_accumulator.
Change-Id: I62928c63eb09f4f6936a45ebd1c23784d1c9681b
John Koleszar [Wed, 19 Jan 2011 13:51:00 +0000 (05:51 -0800)]
Merge "Implement error tracking in the decoder"
Henrik Lundin [Thu, 16 Dec 2010 15:46:31 +0000 (16:46 +0100)]
Implement error tracking in the decoder
A new vpx_codec_control called VP8D_GET_FRAME_CORRUPTED. The output
from the function is non-zero if the last decoded frame contains
corruption due to packet losses.
The decoder is also modified to accept encoded frames of zero length.
A zero length frame indicates to the decoder that one or more frames
have been completely lost. This will mark the last decoded reference
buffer as corrupted. The data pointer can be NULL if the length is
zero.
Change-Id: Ic5902c785a281c6e05329deea958554b7a6c75ce
John Koleszar [Tue, 18 Jan 2011 20:54:57 +0000 (12:54 -0800)]
Merge "fix last frame buffer copy logic regression"
Yunqing Wang [Tue, 18 Jan 2011 19:19:52 +0000 (14:19 -0500)]
Modify calling of NEON code in sub-pixel search
In vp8_find_best_sub_pixel_step_iteratively(), many times xoffset
and yoffset are specific values - (4,0) (0,4) and (4,4). Modified
code to call simplified NEON version at these specific offsets to
help with the performance.
Change-Id: Iaf896a0f7aae4697bd36a49e182525dd1ef1ab4d
Jim Bankoski [Tue, 18 Jan 2011 16:14:17 +0000 (11:14 -0500)]
vp8e -removed undefined max call
Change-Id: I42a86b0488f44115f09551fc5ad6d711fd470f0d
Paul Wilkins [Tue, 18 Jan 2011 16:04:46 +0000 (08:04 -0800)]
Merge "Further CQ, Key frame and ARF changes"
Paul Wilkins [Tue, 18 Jan 2011 15:19:05 +0000 (15:19 +0000)]
Further CQ, Key frame and ARF changes
This code fixes a bug in the calculation of
the minimum Q for alt ref frames.
It also allows an extended gf/arf interval for sections
of clips that completely static (or nearly so).
Change-Id: I1a21aaa16d4f0578e5f99b13bebd78d59403c73b
Attila Nagy [Mon, 10 Jan 2011 09:14:10 +0000 (11:14 +0200)]
Fix encoder real-time only configuration.
Remove allocation/deallocation of stats storage.
Remove full search functions in machine specific encoder inits.
Remove last pass validation in validate_config.
Change-Id: I7f29be69273981a4fef6e80ecdb6217c68cbad4e
Paul Wilkins [Mon, 17 Jan 2011 17:23:11 +0000 (17:23 +0000)]
Fix CQ range and experimental KF sizing changes.
The CQ level was not using the q_trans[] array to convert
to a 0-127 range as per min and maxq
Experimental change to try and match the reconstruction
error for forced key frames approximately to that of the
previous frame by means of the recode loop. Though this
may cause extra recodes and the recode behavior has not
been optimized, it can only happen on forced key frames.
Change-Id: I1f7e42d526f1b1cb556dd461eff1a692bd1b5b2f
Johann [Tue, 11 Jan 2011 14:41:57 +0000 (09:41 -0500)]
update sse2 regular quantizer
about ~5% gain on 32bit. disabled for 64bit
unset executable bit on ssse3 version (cosmetic)
Change-Id: I1a5860839eb294ce4261f819caea2dcfa78e57ca
Paul Wilkins [Fri, 14 Jan 2011 17:20:37 +0000 (09:20 -0800)]
Merge "KF/GF Pulsing"
Paul Wilkins [Fri, 14 Jan 2011 15:26:37 +0000 (07:26 -0800)]
Merge "Testing of modes with Alt Ref frame"
Paul Wilkins [Fri, 14 Jan 2011 15:26:01 +0000 (07:26 -0800)]
Merge "Experimental change to help with ARNR problem."
Paul Wilkins [Fri, 14 Jan 2011 14:52:15 +0000 (14:52 +0000)]
Testing of modes with Alt Ref frame
Previously when a frame was being overlaid on a previously coded
alt ref frame we only checked the alt ref 0,0 mode. Where there is
a possibility that the alt ref buffer is a filtered frame we should allow
the other prediction modes as normal or at the least allow use of
the last frame buffer.
Change-Id: I4d6227223d125c96b4f3066ec6ec9484fee7768c
Adrian Grange [Fri, 14 Jan 2011 15:04:39 +0000 (15:04 +0000)]
ARNR filter pointer update bug fix
In cases where the frame width is not a multiple of 16 the
ARNR filter would go wrong.
In vp8_temporal_filter_iterate_c when updating pointers
at the end of a row of MBs, the image size was
incorrectly used rather than using Num_MBs_In_Row
times 16 (Y) or 8 (U,V).
This worked when width is multiple of 16 but failed
otherwise.
Change-Id: I008919062715bd3d17c7aa2562ab58d1cb37053a
Paul Wilkins [Fri, 14 Jan 2011 12:07:12 +0000 (12:07 +0000)]
Experimental change to help with ARNR problem.
Allow use of other reference frames for the ARF overlay frame
when ARNR filtering is enabled
Change-Id: Icd6a9fb38977a88fbe7cc9b9c18198eb454c0273
Paul Wilkins [Fri, 14 Jan 2011 11:34:53 +0000 (11:34 +0000)]
KF/GF Pulsing
This change is designed to try and reduce pulsing effects when moving
with a complex transition like a fade, into an easy or static section in
an otherwise difficult clip in CQ mode.
The active CQ level is relaxed down to the user entered level for frames that
are generating less than the passed in minimum bandwidth.
Change-Id: Id6d8b551daad4f489c087bd742bc95418a95f3f0
Scott LaVarnway [Thu, 13 Jan 2011 14:59:28 +0000 (06:59 -0800)]
Merge "Moved ref frame calculations"
Paul Wilkins [Thu, 13 Jan 2011 12:45:00 +0000 (12:45 +0000)]
One pass rate control correction.
Fixed discrepancy cpi->ni_frames vs cm->current_video_frame > 150.
Make one pass path explicit.
There is still scope for some odd behaviour around the transition
point at cpi->ni_frames > 150.
Change-Id: Icdee130fe6e2a832206d30e45bf65963edd7a74d
Paul Wilkins [Wed, 12 Jan 2011 17:08:42 +0000 (17:08 +0000)]
Limit key frame quantizer for forced key frames.
Where a key frame occurs because of a minimum interval
selected by the user, then these forced key frames ideally need
to be more closely matched in quality to the surrounding frame.
Change-Id: Ia55b1f047e77dc7fbd78379c45869554f25b3df7
Scott LaVarnway [Tue, 11 Jan 2011 20:00:00 +0000 (15:00 -0500)]
Moved ref frame calculations
Moved ref frame calculations to outside of the
mode_index loop.
Change-Id: I06103fc7e8af88b54b84443acf6691d29b1272ac
Yunqing Wang [Tue, 11 Jan 2011 16:34:24 +0000 (08:34 -0800)]
Merge "Add no_skip_block4x4_search flag in SPLITMV mode"
Johann [Tue, 11 Jan 2011 16:25:22 +0000 (08:25 -0800)]
Merge "use unaligned load"
Johann [Tue, 11 Jan 2011 16:22:29 +0000 (11:22 -0500)]
use unaligned load
source buffer is not guaranteed to be aligned for odd size buffers
Change-Id: Id0b1fd40ba3bd6c994bcfada788feccd2b53c5a9
Yunqing Wang [Mon, 10 Jan 2011 22:21:55 +0000 (17:21 -0500)]
Add no_skip_block4x4_search flag in SPLITMV mode
Add a flag to always enable block4x4 search for speed=0 (good
quality) to guarantee no quality loss for speed0.
Change-Id: Ie04bbc25f7e6a33a7bfa30e05775d33148731c81
Henrik Lundin [Tue, 11 Jan 2011 12:01:24 +0000 (13:01 +0100)]
Remove unused local variables
Removing unused local variables causing compiler warnings in
Visual Studio.
Change-Id: I0e2096303be1fdbc01428a6e57cca9796bb32c8a
Yunqing Wang [Mon, 10 Jan 2011 21:16:59 +0000 (16:16 -0500)]
Fix bug in motion search
The maximum possible MV in 1/8 pel units is (1<<11), which could
cause mvcost out of its range that is 1023. Change maximum
possible MV in 1/8 pel units to (1<<11)-8 will fix this problem.
Change-Id: I5788ed1de773f66658c14f225fb4ab5b1679b74b
Paul Wilkins [Mon, 10 Jan 2011 16:41:53 +0000 (16:41 +0000)]
Two Pass VBR change
Further experiment with restriction of the Q range.
This uses the average non KF/GF/ARF quantizer, instead
of just relying on the initial value. It is not such a strong constraint
but there may be a reduced risk of rate misses.
Change-Id: I424fe782a37a2f4e18c70805e240db55bfaa25ec
Paul Wilkins [Mon, 10 Jan 2011 16:02:51 +0000 (16:02 +0000)]
Revert BASE_ERRPERMB
Constant value reverted pending more tests
on different video formats.
Change-Id: I07d11a0e0185e60724698c835416caf2e0774e61
Paul Wilkins [Fri, 7 Jan 2011 19:05:56 +0000 (11:05 -0800)]
Merge "CQ Mode"
Paul Wilkins [Fri, 7 Jan 2011 18:29:37 +0000 (18:29 +0000)]
CQ Mode
The merge includes hooks to for CQ mode and other code
changes merged from the test branch.
CQ mode attempts to maintain a more stable quantizer within a clip
whilst also trying to adhere to a guidline maximum bitrate.
The existing target data rate parameter is used to specify the
guideline maximum bitrate.
A new parameter allows the user to specify a target CQ level.
For normal (non kf/gf/arf) frames, the quantizer will not drop BELOW the
user specified value (0-63). However, in some cases the encoder may
choose to impose a target CQ that is above that specified by the user,
if it estimates that consistent use of the target value is not compatible
with guideline maximum bitrate.
Change-Id: I2221f9eecae8cc3c431d36caf83503941b25e4c1
Paul Wilkins [Fri, 7 Jan 2011 17:32:29 +0000 (09:32 -0800)]
Merge "Limit Q variability in two pass."
Paul Wilkins [Fri, 7 Jan 2011 16:33:59 +0000 (16:33 +0000)]
Limit Q variability in two pass.
In two pass encoding each frame is given an active
Q range to work with. This change limits how much this
Q range can be altered over time from the initial estimate
made for the clip as a whole.
There is some danger this could lead to overshoot or undershoot
in some corner cases but it helps considerably in regard to
clips where either there is a glut or famine of bits in some sections,
particularly near the end of a clip.
Change-Id: I34fcd1af31d2ee3d5444f93e334645254043026e
Paul Wilkins [Fri, 7 Jan 2011 16:34:27 +0000 (08:34 -0800)]
Merge "Disable some features for first pass."
Scott LaVarnway [Fri, 7 Jan 2011 14:46:45 +0000 (06:46 -0800)]
Merge "Removed cpi->target_bits_per_mb"
Scott LaVarnway [Fri, 7 Jan 2011 14:41:13 +0000 (09:41 -0500)]
Removed cpi->target_bits_per_mb
cpi->target_bits_per_mb is currently not being used,
so delete it. Also removed other unused code in rdopt.c.
Change-Id: I98449f9030bcd2f15451d9b7a3b9b93dd1409923
Johann [Wed, 22 Dec 2010 16:23:51 +0000 (11:23 -0500)]
x86 sse2 temporal_filter_apply
count can be reduced to short because the max number of filtered frames
is set to 15. the max value for any frame is 32 (modifier = 16,
filter_weight = 2). 15*32 = 480 which requires 9 bits
this function goes from about 7000 us / 1000 iterations for the C code
to < 275 us / 1000 iterations for sse2 for block_size = 16 and from
about 1800 us / 1000 iters to < 100 us / 1000 iters for block_size = 8
Change-Id: I64a32607f58a2d33c39286f468b04ccd457d9e6e
John Koleszar [Thu, 6 Jan 2011 18:07:39 +0000 (13:07 -0500)]
fix last frame buffer copy logic regression
Commit 0ce3901 introduced a change in the frame buffer copy logic where
the NEW frame could be copied to the ARF or GF buffer through the
copy_buffer_to_{arf,gf}==1 flags, if the LAST frame was not being
refreshed. This is not correct. The intent of the
copy_buffer_to_{arf,gf}==1 flag is to copy the LAST buffer. To copy the
NEW buffer, the refresh_{alt_ref,golden}_frame flag should be used.
The original buffer copy logic is fairly convoluted. For example:
if (cm->refresh_last_frame)
{
vp8_swap_yv12_buffer(&cm->last_frame, &cm->new_frame);
cm->frame_to_show = &cm->last_frame;
}
else
{
cm->frame_to_show = &cm->new_frame;
}
...
if (cm->copy_buffer_to_arf)
{
if (cm->copy_buffer_to_arf == 1)
{
if (cm->refresh_last_frame)
vp8_yv12_copy_frame_ptr(&cm->new_frame, &cm->alt_ref_frame);
else
vp8_yv12_copy_frame_ptr(&cm->last_frame, &cm->alt_ref_frame);
}
else if (cm->copy_buffer_to_arf == 2)
vp8_yv12_copy_frame_ptr(&cm->golden_frame, &cm->alt_ref_frame);
}
Effectively, if refresh_last_frame, then new and last are swapped, so
when "new" is copied to ARF, it's equivalent to copying LAST to ARF. If
not refresh_last_frame, then LAST is copied to ARF. So LAST is copied to
ARF in both cases.
Commit 0ce3901 removed the first buffer swap but kept the
refresh_last_frame?new:last behavior, changing the sense since the first
swap wasn't done to the more readable refresh_last_frame?last:new, but
this logic is not correct when !refresh_last_frame.
This commit restores the correct behavior from v0.9.1 and prior. This
case is missing from the test vector set.
Change-Id: I8369fc13a37ae882e31a8a104da808a08bc8428f
Paul Wilkins [Thu, 6 Jan 2011 17:10:07 +0000 (17:10 +0000)]
Disable some features for first pass.
The following features don't make sense for the first
pass in its current form and have a significant impact on its
speed (up to 50%).
Slow quantizer, slow dct and trellis optimization.
Change-Id: Id9943f6765ffbd71fc0084ec7dfbc9d376fd6fcd
Paul Wilkins [Tue, 4 Jan 2011 17:55:49 +0000 (17:55 +0000)]
Adjustment to boost calculation in two pass.
Calculate a minimum intra value to be used in determining the
IIratio scores used in two pass, second pass.
This is to make sure sections that are low complexity" in the
intra domain are still boosted appropriately for KF/GF/ARF.
For now I have commented out the Q based adjustment of
KF boost.
Change-Id: I15deb09c5bd9b53180a2ddd3e5f575b2aba244b3
Scott LaVarnway [Wed, 29 Dec 2010 21:28:24 +0000 (16:28 -0500)]
Fixed encoder crash when mult-threading is enabled.
Happens in real-time mode. Will happen in good quality, speed 1.
Change-Id: I3e5b68827b1a5798d0431b088a709256d1ce2c95
Yunqing Wang [Wed, 29 Dec 2010 15:28:35 +0000 (10:28 -0500)]
Always update last_frame_type
Scott pointed out that last_frame_type only gets updated while
loopfilter exists. Since last_frame_type is also needed in
motion search now, it needs to be updated every frame.
Change-Id: I9203532fd67361588d4024628d9ddb8e391ad912
Scott LaVarnway [Tue, 28 Dec 2010 19:56:11 +0000 (11:56 -0800)]
Merge "Use the fast quantizer for inter mode selection"
Scott LaVarnway [Tue, 28 Dec 2010 19:51:46 +0000 (14:51 -0500)]
Use the fast quantizer for inter mode selection
Use the fast quantizer for inter mode selection and the
regular quantizer for the rest of the encode for good quality,
speed 1. Both performance and quality were improved. The
quality gains will make up for the quality loss mentioned in
I9dc089007ca08129fb6c11fe7692777ebb8647b0.
Change-Id: Ia90bc9cf326a7c65d60d31fa32f6465ab6984d21
Yunqing Wang [Tue, 28 Dec 2010 18:23:07 +0000 (13:23 -0500)]
Adjust MV borders for SPLITMV mode
Add limits to avoid MV going out of range.
Change-Id: I8a5deb40bf393488d29f694b5a56804d578e68b5
Yunqing Wang [Tue, 28 Dec 2010 16:12:26 +0000 (08:12 -0800)]
Merge "Modify motion estimation for SPLITMV mode"
Yunqing Wang [Thu, 23 Dec 2010 16:23:03 +0000 (11:23 -0500)]
Modify motion estimation for SPLITMV mode
1. Search for block8x16/block16x8 uses block8x8's search results.
2. Check block4x4 only if block8x8 is chosen. (This hurts quality,
which will be improved in another check-in.)
3. In block4x4 search, the previous block's result is used as
MV predictor for next block.
This change improves performance.
Change-Id: I9dc089007ca08129fb6c11fe7692777ebb8647b0
Yaowu Xu [Sun, 26 Dec 2010 21:45:37 +0000 (13:45 -0800)]
Merge "adjusted sad_per_bit to correlate with quantizer"
Yaowu Xu [Fri, 24 Dec 2010 03:59:12 +0000 (19:59 -0800)]
adjusted sad_per_bit to correlate with quantizer
Re-calibrated sad_per_bit16 and sad_per_bit4 tables to linearly
correlated to quantizer values, these two variables are used in
motion search for costing motion vectors. This change has an small
positive effect on compression.
Change-Id: Ic9b5ea6fb8d5078ef663ba4899db019cc51f4166
James Berry [Thu, 23 Dec 2010 19:47:56 +0000 (14:47 -0500)]
vpxenc stats_close() memleak fix
stats_close() was not freeing memory for
single pass runs. It now takes in arg_passes
to determine when it should free memory.
Change-Id: I6623b7e30b76f9bf2e16008490f9b20484d03f31
Johann [Thu, 23 Dec 2010 14:14:28 +0000 (06:14 -0800)]
Merge "improve integer version of filter"
Johann [Thu, 23 Dec 2010 14:14:20 +0000 (06:14 -0800)]
Merge "temporal filter naming changes"
Johann [Thu, 23 Dec 2010 14:14:07 +0000 (06:14 -0800)]
Merge "abstract apply_temporal_filter"
John Koleszar [Wed, 22 Dec 2010 19:11:08 +0000 (11:11 -0800)]
Merge "make yasm generate cv8 debug data on win32"
John Koleszar [Fri, 17 Dec 2010 20:06:23 +0000 (15:06 -0500)]
make yasm generate cv8 debug data on win32
Native Windows targets should use CV8 format debugging symbols, not
DWARF.
Change-Id: I9489163fcd9d749b72f6c70ecbce67a6f0790802
Johann [Wed, 22 Dec 2010 16:15:56 +0000 (11:15 -0500)]
improve integer version of filter
the lookup table is based on floating point calculations (see source)
by moving the *3 before the downshift and adding the rounding bit, the
delta (LUT - integer) goes from:
______________________________________
__ 1__ 1______________________________
__ 1__ 1______________________________
____ 1______ 1________________________
____ 1 2__ 2 1________________________
______ 1 1 2__ 2__ 2__ 2 1 1__________
________ 1 1 2 2__ 1 2 3 1 2__ 2__ 2__
to:
__-1__-1______________________________
______________________________________
____-1______-1________________________
______________________________________
________-1______________-1____________
______________________________________
it's important to be able to use the integer version because the LUT
more or less precludes SIMD optimizations
Change-Id: I45a81127dc7b72a06fba951649135d9d918386c0
Johann [Tue, 30 Nov 2010 15:23:43 +0000 (10:23 -0500)]
temporal filter naming changes
be more consistant with the naming pattern, especially wrt rtcd
Change-Id: I3df50686a09f1dab0a9620b5adbb8a1577b40f2f
Johann [Mon, 29 Nov 2010 19:21:11 +0000 (14:21 -0500)]
abstract apply_temporal_filter
allow for optimized versions of apply_temporal_filter
(now vp8_apply_temporal_filter_c)
the function was previously declared as static and appears to have been
inlined. with this change, that's no longer possible. performance takes
a small hit.
the declaration for vp8_cx_temp_filter_c was moved to onyx_if.c because
of a circular dependency. for rtcd, temporal_filter.h holds the
definition for the rtcd table, so it needs to be included by onyx_int.h.
however, onyx_int.h holds the definition for VP8_COMP which is needed
for the function prototype. blah.
Change-Id: I499c055fdc652ac4659c21c5a55fe10ceb7e95e3
Jim Bankoski [Mon, 20 Dec 2010 17:32:13 +0000 (09:32 -0800)]
Merge "Add psnr/ssim tuning option"
John Koleszar [Fri, 17 Dec 2010 16:34:02 +0000 (11:34 -0500)]
propagate user private data on decode
The pointer passed in the user_priv argument to vpx_codec_decode()
should be propagated through to the corresponding output frame and
made available in the image's user_priv member. Fixes issue #252
Change-Id: I182746a6882c8549fb146b4a4fdb64f1789eb750
John Koleszar [Fri, 17 Dec 2010 15:08:21 +0000 (07:08 -0800)]
Merge "Inform caller of decoder about updated references"
John Koleszar [Fri, 17 Dec 2010 14:43:39 +0000 (09:43 -0500)]
Add psnr/ssim tuning option
Add a new encoder control, VP8E_SET_TUNING, to allow the application
to inform the encoder that the material will benefit from certain
tuning. Expose this control as the --tune option to vpxenc. The args
helper is expanded to support enumerated arguments by name or value.
Two tunings are provided by this patch, PSNR (default) and SSIM.
Activity masking is made dependent on setting --tune=ssim, as the
current implementation hurts speed (10%) and PSNR (2.7% avg,
10% peak) too much for it to be a default yet.
Change-Id: I110d969381c4805347ff5a0ffaf1a14ca1965257
Henrik Lundin [Tue, 14 Dec 2010 13:05:06 +0000 (14:05 +0100)]
Inform caller of decoder about updated references
Inform the caller of the decoder if a decoded frame updated last,
golden, or altref frames, required for realtime communication
proposed in document VP8 RTP payload format.
Added a new vpx_codec_control called VP8D_GET_LAST_REF_UPDATES, to be
called after vpx_codec_decode. The control will indicate which of the
reference frames that were updated by setting the 3 LSBs in the input
int (pointer).
Change-Id: Iac9db60dac414356c7ffa0b0fede88cb91e11bd7
Scott LaVarnway [Thu, 16 Dec 2010 22:01:27 +0000 (17:01 -0500)]
Changed segmentation check order
In SPLITMV, the 8x8 segment will be checked first. If the 8x8 rd
is better than the best, we check the other segments. Otherwise
bail. Adjustments to the thresh_mult were necessary to make
up for the initial quality loss.
The performance improved by 20% (average) for good quality,
speed 0 and speed 1, while the overall quality remained the same.
Change-Id: I717aef401323c8a254fba3e9777d2a316c774cc3
Scott LaVarnway [Thu, 16 Dec 2010 14:38:02 +0000 (09:38 -0500)]
Adjusted breakout RD for SPLITMV
vp8_rd_pick_best_mbsegmentation looks at y only. The new
breakout does not include the frame cost, the prob_skip_false
cost, or the uv rate. Performance improved by a few percent
and the quality remained the same.
Change-Id: I94ff013998ac51e8ecce7130870f7b6600758e15
Yunqing Wang [Wed, 15 Dec 2010 16:10:34 +0000 (08:10 -0800)]
Merge "Fix a bug in motion search code(2)"
Yunqing Wang [Tue, 14 Dec 2010 22:39:25 +0000 (17:39 -0500)]
Fix a bug in motion search code(2)
This fix added MV range checks for NEWMV mode as suggested by Jim.
To reduce unnecessary MV range checks, I tried Yaowu's suggestion.
Update UMV borders in NEWMV mode to also cover MV range check.
Also, in this way, every MV that is valid gets checked in diamond
search function.
Change-Id: I95a89ce0daf6f178c454448f13d4249f19b30f3a
Yaowu Xu [Tue, 14 Dec 2010 21:32:04 +0000 (13:32 -0800)]
Merge "fix a bug that "optimize" flag is not set for sub-threads"
Yunqing Wang [Tue, 14 Dec 2010 21:25:34 +0000 (13:25 -0800)]
Merge "Fix a bug in motion search code"
Yunqing Wang [Tue, 14 Dec 2010 16:00:25 +0000 (11:00 -0500)]
Fix a bug in motion search code
The MV's range is 256. Since the new motion search uses a different
starting MV than the center ref MV, a MV range checking needs to
be done to avoid corruption.
Change-Id: I8ae0721d1bd203639e13891e2e54a2e87276f306
Yaowu Xu [Tue, 14 Dec 2010 18:12:21 +0000 (10:12 -0800)]
fix a bug that "optimize" flag is not set for sub-threads
The flag for quantization optimization was not properly propagated to
mb row encoding threads.
Change-Id: Ic561599c35acd94cd5698c9b314bccd596ac2deb
Johann [Tue, 14 Dec 2010 14:35:18 +0000 (09:35 -0500)]
shrink TOKENEXTRA and vp8_extra_bit_struct
Per John's previous change, shrink TOKENEXTRA from 20 to 8 bytes
original:
b7b1e6fb
reverted:
41f4458a
Also drop unused field from vp8_extra_bit_struct
Update ARM ASM to deal with this change. In particular, Extra is signed
and needs to be sign-extended when loaded.
Change-Id: Ibd0ddc058432bc7bb09222d6ce4ef77e93a30b41
John Koleszar [Mon, 13 Dec 2010 22:11:48 +0000 (17:11 -0500)]
Revert "Reduce size of TOKENEXTRA struct"
This reverts commit
b7b1e6fb55c6b12ccd078a20cb9855f6734931b5. Previous
fix is incomplete, breaks ARM. Itchy submit finger.
Change-Id: I939dc0d3bf4173cf951c1d152338ab6ea2184bb9
John Koleszar [Mon, 13 Dec 2010 21:57:59 +0000 (13:57 -0800)]
Merge "remove unused temporal preproc code"
John Koleszar [Mon, 13 Dec 2010 21:57:55 +0000 (13:57 -0800)]
Merge "Reduce size of TOKENEXTRA struct"
John Koleszar [Mon, 13 Dec 2010 21:47:34 +0000 (16:47 -0500)]
remove unused temporal preproc code
This code is unused, as the current preproc implementation uses the
same spatial filter that postproc uses.
Change-Id: Ia06d5664917d67283f279e2480016bebed602ea7
John Koleszar [Mon, 13 Dec 2010 15:11:42 +0000 (10:11 -0500)]
Reduce size of TOKENEXTRA struct
Change the size of structure elements to reduce memory utilization.
Removed the 'section' member entirely, as it is set but never read.
Change-Id: Iad043830392fb4168cb3cd6075fb0eb70c7f691c
James Berry [Mon, 13 Dec 2010 18:10:58 +0000 (13:10 -0500)]
fixed vpxenc bug where ivf files would be read incorrectly
read_frame would incorrectly insert detect->buf into img
for ivf files. detect->position now set to 4 if input file is
detected to be ivf in file_is_ivf to keep this from occuring.
Change-Id: I5e235dd3033985bc62707a35c13af5984620208e
Yaowu Xu [Fri, 10 Dec 2010 18:48:30 +0000 (10:48 -0800)]
fix a bug in multithreaded encoding with active_map enabled
Added the initialization of the pointer to active map. Also added the
same logic for cyclic refresh in mbrow encoding threads.
Change-Id: Ic48d0849dc706b27fba72d07dcc498075725663d
Fritz Koenig [Fri, 10 Dec 2010 17:25:04 +0000 (09:25 -0800)]
Merge "vp8 fast quantizer sse2 optimizations for eob."
Fritz Koenig [Thu, 9 Dec 2010 23:00:30 +0000 (15:00 -0800)]
vp8 fast quantizer sse2 optimizations for eob.
Changed the end of block computation to use pmaxw. Removed
additional pushing and popping of registers that was not needed.
Change-Id: I08cb9b424513cd8a2c7ad8cea53b4e2adc66ef98
John Koleszar [Thu, 9 Dec 2010 20:59:22 +0000 (15:59 -0500)]
fix uninitialized read in encode breakout
Change I3430820 performed an uninitialized read when
encode_breakout == 0, since the sum and sse wouldn't be set:
if(x->encode_breakout)
VARIANCE_INVOKE(..., get16x16var)(..., &sum, &sse);
if (cpi->active_map_enabled && x->active_ptr[0] == 0) {
...
} else if (sse < x->encode_breakout)
Change-Id: I915eb76d1227b4b6d1137a0dedf2c143860098a2