Joseph Tremoulet [Tue, 18 Apr 2017 16:47:25 +0000 (12:47 -0400)]
Run-xunit-perf: update TraceEvents version number
The perf harness needs 1.0.3-alpha-experimental now.
Bruce Forstall [Tue, 18 Apr 2017 14:18:10 +0000 (07:18 -0700)]
Merge pull request #11035 from BruceForstall/NumSuccImprovement
Hoist calls to NumSucc() out of loops
ragmani [Tue, 18 Apr 2017 10:01:55 +0000 (19:01 +0900)]
[x86/Linux] changed to the AT&T syntax to solve a problem related broken stack. (#10932)
This is a problem similar to #10383.
Signed-off-by: ragmani <ragmani0216@gmail.com>
Buyduck [Tue, 18 Apr 2017 08:02:14 +0000 (11:02 +0300)]
* fixed class size calculation (#10916)
Tarek Mahmoud Sayed [Tue, 18 Apr 2017 05:02:08 +0000 (22:02 -0700)]
Fix String.Replace implementation (#11039)
* Fix String.Replace implementation
String.Replace was callin ga low level CompareInfo method IndexOfCore which cannot be called in some conditions like when using ordinal ignore case option or when running in invariant mode.
The fix is to call a higher level method in CompareInfo which can handle such cases becfore calling the lower level method
* fix typo
Andy Ayers [Tue, 18 Apr 2017 04:47:38 +0000 (21:47 -0700)]
Merge pull request #10995 from svick/patch-1
Update Viewing JIT dumps to 2.0 and csproj
William Godbe [Tue, 18 Apr 2017 03:16:22 +0000 (20:16 -0700)]
Fix error caused by passing -TargetsWindows at end of Command Line (#11031)
Michael Letterle [Fri, 31 Mar 2017 15:32:32 +0000 (11:32 -0400)]
Do not throw an assertion on no mscorlib
It's okay to use debuggable attributes from other BaseAsmRef's
Fixes #10608
Brian Robbins [Tue, 18 Apr 2017 01:35:37 +0000 (18:35 -0700)]
Merge pull request #11036 from brianrob/remove_eventcounter
Remove EventCounter from System.Private.CoreLib
danmosemsft [Mon, 17 Apr 2017 23:58:10 +0000 (16:58 -0700)]
Fix build break
Omar Tawfik [Mon, 17 Apr 2017 23:33:09 +0000 (16:33 -0700)]
Rename attribute to IsReadOnlyAttribute (#11026)
Bruce Forstall [Mon, 17 Apr 2017 23:32:36 +0000 (16:32 -0700)]
Use isInternalRegDelayFree to avoid temp reg overallocation (#11025)
Use isInternalRegDelayFree to avoid temp reg overallocation
Brian Robbins [Mon, 17 Apr 2017 23:16:22 +0000 (16:16 -0700)]
Remove EventCounter from System.Private.CoreLib.
Bruce Forstall [Mon, 17 Apr 2017 23:00:51 +0000 (16:00 -0700)]
Hoist calls to NumSucc() out of loops
Should be a minor throughput improvement.
Jan Kotas [Mon, 17 Apr 2017 22:37:09 +0000 (17:37 -0500)]
Improve performance of Object.GetType for arrays (#10992)
* Improve performance of Object.GetType for arrays
Cache managed Type object on MethodTable for arrays. Makes Object.GetType for arrays about 5x faster.
Viktor Hofer [Mon, 17 Apr 2017 21:39:21 +0000 (23:39 +0200)]
Merge pull request #11028 from danmosemsft/api.zone
Add SecurityZone stub
Sergey Andreenko [Mon, 17 Apr 2017 21:05:11 +0000 (14:05 -0700)]
Format spmi sources with clang-format (#11027)
Apply jit style format on spmi sources.
Andy Ayers [Mon, 17 Apr 2017 20:04:23 +0000 (13:04 -0700)]
Jit intrinsics for Span<T>.get_Item and ReadOnlySpan<T>.get_Item. (#10910)
Implement these two methods as optional-expand jit intrinsics.
Uses `GT_ARR_BOUNDS_CHECK` for the bounds check so in some cases
downstream code is able to eliminate redundant checks. Fully general
support (on par with arrays in most cases) is still work in progress.
Update one bit of code in the optimizer that assumed it knew the
tree types that appeared in a `GT_ARR_BOUNDS_CHECK`.
Add benchmark tests for Span and ReadOnlySpan indexers.
Tests ability of jit to reason about indexer properties with respect
to loop bounds and related indexer uses. Some cases inspired by span
indexer usage in Kestrel.
Closes #10785.
Also addresses lack of indexer inlining noted in #10031. Span indexers
should now always be inlined, even when invoked from shared methods.
Swaroop Sridhar [Fri, 14 Apr 2017 03:07:41 +0000 (20:07 -0700)]
Add scenario-based tests
Modified Xunit runner to run Scenario Benchmarks
Updating xunit-performance packages
danmosemsft [Mon, 17 Apr 2017 19:15:07 +0000 (12:15 -0700)]
Add SecurityZone stub
Rahul Kumar [Mon, 17 Apr 2017 18:47:47 +0000 (11:47 -0700)]
In function Assembly.Load ignore AssemblyName.CodeBase even if it is set (#11010)
Gaurav Khanna [Mon, 17 Apr 2017 18:29:35 +0000 (11:29 -0700)]
Remove Alpine for pipe builds (#11022)
Jonghyun Park [Mon, 17 Apr 2017 18:21:45 +0000 (03:21 +0900)]
Support FEATURE_EVENT_TRACE override (#10961)
Jonghyun Park [Mon, 17 Apr 2017 18:20:21 +0000 (03:20 +0900)]
Allow build.sh to have multiple cmakeargs options (#10962)
dotnet bot [Mon, 17 Apr 2017 18:17:42 +0000 (11:17 -0700)]
Update CoreClr, CoreFx to preview1-25215-03, preview1-25214-03, respectively (#10952)
Sujin Kim [Mon, 17 Apr 2017 17:18:39 +0000 (02:18 +0900)]
[RyuJit/ARM32] Fix assertion of failure on "Instruction cannot be encoded" (#10789)
Fix assertion of failure on "Instruction cannot be encoded"
I figured out the bit set mask for '0xffffff00' which is the imm is not supportted on ARM.
So at first, It would be checked the validation of using instruction with immediate constants.
If not, it would be use the instruction with registers.
Bruce Forstall [Mon, 17 Apr 2017 17:14:13 +0000 (10:14 -0700)]
Merge pull request #11013 from mskvortsov/nullcheck
[RyuJIT/ARM32] Update nullcheck codegen
Bruce Forstall [Mon, 17 Apr 2017 16:53:15 +0000 (09:53 -0700)]
Merge pull request #11016 from alpencolt/ryu-arm-localloc-fix
[RyuJIT/ARM32] Fix amount of allocated registers for Localloc.
Hyeongseok Oh [Mon, 17 Apr 2017 15:56:19 +0000 (00:56 +0900)]
Fix ARM32/Linux release CI test failure (#11008)
* Fix ARM32/Linux release CI test failure
Fix ARM32/Linux release CI test failure by removing libcoreclrptprovider.so from CoreFX build results.
* Fix typo
Fix typo in netci.groovy
Jan Kotas [Tue, 14 Mar 2017 16:06:56 +0000 (09:06 -0700)]
Add Span and ReadOnlySpan from CoreCLR
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Alexander Soldatov [Mon, 17 Apr 2017 13:10:36 +0000 (16:10 +0300)]
[RyuJIT/ARM32] Fix amount of allocated registers for Localloc.
Now for small allocation (up to 4 store instructions) we always have
1 temporary register which is different from register where result
of stackalloc is returned. Also one additional register will be allocated
for PSP if needed.
Mikhail Skvortcov [Mon, 17 Apr 2017 09:48:09 +0000 (12:48 +0300)]
RyuJIT/ARM32: update nullcheck codegen
303248153 [Mon, 17 Apr 2017 03:01:52 +0000 (11:01 +0800)]
Fix comment about pinning bit in object.h (#11004)
Yi Zhang (CLR) [Mon, 17 Apr 2017 02:21:55 +0000 (19:21 -0700)]
Fix warning in LPTSTRTestNative (#10973)
* Fix warning in LPTSTRTestNative and add support for wcsncmp in xplatform.h
Hugh Bellamy [Sun, 16 Apr 2017 18:36:47 +0000 (01:36 +0700)]
Fix OOM exception thrown in case insensitive replace for an empty string (#11001)
Cyd Haselton [Sun, 16 Apr 2017 18:36:17 +0000 (13:36 -0500)]
Fixed CI link (#11003)
Updated link referenced in CI builds; old link was broken
Jan Kotas [Sat, 15 Apr 2017 20:32:58 +0000 (13:32 -0700)]
Move Span/ReadOnlySpan to shared CoreLib partition (#10988)
Fix a few method names to better names used in CoreRT
Contributes to https://github.com/dotnet/corert/issues/2966
mikedn [Sat, 15 Apr 2017 19:11:51 +0000 (22:11 +0300)]
Make some Dictionary code smaller (#10993)
Store a reference to the relevant entry at the start of the loop to avoid indexing `entries` multiple times.
This avoids some redundant range checks in `Remove` and allows the elimination of a duplicate `index++` in `Enumerator.MoveNext`.
Saves ~7KB of code.
Michelle McDaniel [Sat, 15 Apr 2017 18:40:09 +0000 (11:40 -0700)]
Merge pull request #10983 from danmosemsft/revert.jeremy
Revert "Strip out unused reg code. (#10741)"
Petr Onderka [Sat, 15 Apr 2017 17:22:00 +0000 (19:22 +0200)]
Update Viewing JIT dumps to 2.0 and csproj
Mike McLaughlin [Sat, 15 Apr 2017 18:09:03 +0000 (11:09 -0700)]
Make createdump build and work on Centos (#10985)
Steve MacLean [Sat, 15 Apr 2017 15:39:02 +0000 (11:39 -0400)]
[Arm64] Fix assembly errors (#10977)
* [Arm64] Fix assembly errors
* [Arm64] Static use ldrb w2, [x2, w1, UXTW]
* Revert changes to src/vm/arm64/asmhelpers.asm
Pat Gavlin [Sat, 15 Apr 2017 05:16:44 +0000 (22:16 -0700)]
Merge pull request #10958 from pgavlin/VSO397793
Preserve VNs in fgMorphIntoHelperCall.
danmosemsft [Fri, 14 Apr 2017 22:53:33 +0000 (15:53 -0700)]
Revert "Strip out unused reg code. (#10741)"
This reverts commit
ed4f594abf41a71b126152bb8755051d0831e12d.
Bruce Forstall [Fri, 14 Apr 2017 22:47:58 +0000 (15:47 -0700)]
Merge pull request #10936 from BruceForstall/TempRegApi
Introduce API for codegen getting temp registers from gtRsvdRegs
Pat Gavlin [Fri, 14 Apr 2017 22:18:12 +0000 (15:18 -0700)]
Add a brief comment to the new test.
Sergey Andreenko [Fri, 14 Apr 2017 20:58:25 +0000 (13:58 -0700)]
Small clean up of stackEntry (#10820)
Make all stackDepth equal unsigned int.
Delete possible wrong function (the comment said : "// used in the inliner, where we can assume typesafe code. please don't use in the importer!!", but it was used).
Delete methods, that used arguments as output buffers.
* delete code without effects
Bruce Forstall [Thu, 13 Apr 2017 00:16:46 +0000 (17:16 -0700)]
Introduce API for codegen getting temp registers from gtRsvdRegs
LSRA puts a set of temporary registers needed by a node in the
gtRsvdRegs register mask. Currently, evey codegen function that
needs to use a temporary register manually manipulates this mask.
Introduce a few functions to make this simpler and more regular:
1. GetSingleTempReg() // Gets a temp; asserts there is exactly one temp reg.
2. ExtractTempReg() // Gets the lowest temp, removes it from gtRsvdRegs so subsequent calls don't see it.
3. AvailableTempRegCount() // Returns a count of available temp registers.
All take an optional register mask, so you can extract a register from
just the set specified by the mask (typically RBM_ALLINT or RBM_ALLFLOAT).
Aditya Mandaleeka [Fri, 14 Apr 2017 20:03:22 +0000 (13:03 -0700)]
Merge pull request #10955 from adityamandaleeka/makeHandleStoreClass
Make a GCHandleStore class and interface for use by the VM
Andy Ayers [Fri, 14 Apr 2017 19:46:22 +0000 (12:46 -0700)]
Merge pull request #10956 from AndyAyersMS/FixMorphUnnecessaryNullCheck
Jit: fix unnecessary null checks in some field accesses
Aditya Mandaleeka [Fri, 14 Apr 2017 03:49:04 +0000 (20:49 -0700)]
Make HandleStores contain their underlying bucket directly.
Sean Gillespie [Fri, 14 Apr 2017 16:51:10 +0000 (09:51 -0700)]
[Local GC] Move operations on CLREventStatic to the EE interface (#10813)
* [Local GC] Move operations on CLREventStatic to the EE and add their functionality to the interface
* Fix a missed case
* Split GetWaitForGCEvent into two smaller interface methods to avoid exposing the event itself on the interface
* Initial implementation for Unix
* Complete unix implementation
* Make it work on Windows
* Remove redudant methods from GCToEEInterface
* Fix the Linux build
* First part of code review feedback: make GCEvent dispatch statically (Windows)
* Second part of code review feedback: make GCEvent dispatch statically (Unix)
* Standardize implementation across Windows/Unix (apparently MSVC is more lenient about constructor names than clang)
* Address code review feedback: Add Create*Event methods back onto GCEvent and remove them from GCToOSInterface
* Address code review feedback: remove a dead define
* Remove a bad comment, remove an unnecessary friend class, fix some formatting issues
* Fix an issue when initializing a GCEvent on Linux (should not be allocating an Impl in the constructor)
* Fix the same issue on Windows (less bad, just leaks memory instead of asserting)
Jonghyun Park [Fri, 14 Apr 2017 14:34:07 +0000 (23:34 +0900)]
[x86/Linux] Use appropriate FCALL macro for DoToDecimal (#10963)
Jan Vorlicek [Fri, 14 Apr 2017 12:13:48 +0000 (05:13 -0700)]
Implement MEM_RESET handling in VirtualAlloc on Unix (#10939)
Aditya Mandaleeka [Fri, 14 Apr 2017 02:19:58 +0000 (19:19 -0700)]
Rename IGCHandleTable to IGCHandleManager.
Omar Tawfik [Fri, 14 Apr 2017 03:07:27 +0000 (20:07 -0700)]
Merge pull request #10945 from OmarTawfik/update-runtimefeature-docs
Update comment to reflect how RuntimeFeature members should be defined
Gaurav Khanna [Fri, 14 Apr 2017 00:58:21 +0000 (17:58 -0700)]
Reenable incremental linking (#10943)
Pat Gavlin [Thu, 13 Apr 2017 23:37:33 +0000 (16:37 -0700)]
Preserve VNs in fgMorphIntoHelperCall.
This method is used to transform a node into a semantically-equivalent
helper call, and should preserve any value numbers that are present on
the the node.
Sean Gillespie [Thu, 13 Apr 2017 22:35:42 +0000 (15:35 -0700)]
[Local GC] Handle table low-hanging interface violations (#10929)
Andy Ayers [Thu, 13 Apr 2017 22:17:44 +0000 (15:17 -0700)]
Jit: fix unnecessary null checks in some field accesses
Morph was sometimes passing the existing MorphAddressContext down
to fgMorphField even when the field access was for a field value.
If that context contained indefinite offsets, morph would then
insert an explicit null check on the object pointer for the field
access.
Typically the field offset is small enough that this explicit check
is not needed. The implicit check done when fetching the field's value
is sufficient protection.
The fix is to have `fgMorphSmpOp` clear out the context for child
`GT_FIELD` nodes, unless the field parent is a `GT_ADDR`. Note
if there is an `op2` node the parent cannot be `GT_ADDR` so these
field children always get an empty context.
No tests added since this kicks in reasonably frequently in corelib and
elsewhere in frameworks.
Closes #10942.
Aditya Mandaleeka [Wed, 12 Apr 2017 02:34:15 +0000 (19:34 -0700)]
Make a GCHandleStore class and interface for use by the VM.
William Godbe [Thu, 13 Apr 2017 21:36:14 +0000 (14:36 -0700)]
Merge pull request #10953 from wtgodbe/crossImage
Use updated Docker images for Crossbuild
wtgodbe [Thu, 13 Apr 2017 21:29:56 +0000 (14:29 -0700)]
Use updated Docker images for Crossbuild
William Godbe [Thu, 13 Apr 2017 20:56:26 +0000 (13:56 -0700)]
Merge pull request #10927 from wtgodbe/PortableOSXWin
Enable building Core_Root for any RID against packages
William Godbe [Thu, 13 Apr 2017 20:28:08 +0000 (13:28 -0700)]
Merge pull request #10949 from wtgodbe/ImageVersion
Update Ubuntu14.04 Cross Docker image
wtgodbe [Thu, 13 Apr 2017 20:27:50 +0000 (13:27 -0700)]
Update Ubuntu14.04 Cross Docker image
Omar Tawfik [Thu, 13 Apr 2017 19:33:10 +0000 (12:33 -0700)]
Update comment to reflect how RuntimeFeatures should be defined
Michelle McDaniel [Thu, 13 Apr 2017 17:29:36 +0000 (10:29 -0700)]
Merge pull request #10922 from adiaaida/fixXUnitPerf
Fix run-xunit-perf.cmd for local use
Jonghyun Park [Thu, 13 Apr 2017 17:23:48 +0000 (02:23 +0900)]
[x86/Linux] Use appropriate FCALL macro for SafeBuffer methods (#10935)
Mike McLaughlin [Thu, 13 Apr 2017 16:28:23 +0000 (09:28 -0700)]
Remove distro specific RIDs from SOS.NETCore's project.json. (#10925)
Jim Ma [Thu, 13 Apr 2017 15:50:05 +0000 (23:50 +0800)]
Ensure Environment.ExitCode works correctly after app domain unloaded. (#10842)
* Ensure Environment.ExitCode works correctly after app domain unloaded.
This PR addresses 2 problems of Environment.ExitCode:
1. Can't get correct exit code of main function.
2. Can't set %errorlevel%.
Details can be found on #6206
Fix #6206
dotnet bot [Thu, 13 Apr 2017 14:56:52 +0000 (07:56 -0700)]
Update CoreClr to preview1-25213-02 (#10937)
Rahul Kumar [Thu, 13 Apr 2017 14:20:52 +0000 (07:20 -0700)]
Merge pull request #10875 from rahku/fix_x86_gcstress
modify lastAvAddress when adjusting context for Stub
Hyeongseok Oh [Thu, 13 Apr 2017 11:09:32 +0000 (20:09 +0900)]
[ARM32/Linux] Build libcoreclrtraceptprovider.so (#10406)
* Build libcoreclrtraceptprovider.so for ARM32 and modify cmake
- Build libcoreclrtraceptprovider.so for ARM32
- Include libcoreclrtraceptprovider.so in nuget package
- Don't build libcoreclrtraceptprovider.so for
Tizen: lttng is not supported in Tizen
- Exclude packaging libcoreclrtraceptprovider.so based on os-name
excluded for tizen
* Remove libcoreclrtraceptprovider.so before test for ARM32/Linux
Remove libcoreclrtraceptprovider.so before test for ARM32/Linux in CI
CI test environment using docker with qemu has some problem to use lttng library
Mike McLaughlin [Thu, 13 Apr 2017 07:34:01 +0000 (00:34 -0700)]
Create ELF core dump on coreclr exceptions and signals. (#10902)
* Create ELF core dump on coreclr exceptions and signals.
When coreclr aborts because of a unhandled managed exception or hardware signal, the
"createdump" utility is launched if the "COMPlus_DbgEnableMiniDump" environment
variable is set to "1".
This utility uses the DAC enumerate memory interface to determine what memory regions
should be written for the managed state plus all the normal Linux memory regions for
the native state like threads, stacks, DSO, etc.
There still needs some to configure some of the "policies" like the name/location of
the core dump and the type of minidump (MiniDumpNormal, MiniDumpWithFullAuxiliaryState,
MiniDumpWithPrivateReadWriteMemory, etc.).
Currently only supported on Ubuntu Linux.
Make createdump smaller by using PAL in DAC module.
Rahul Kumar [Thu, 13 Apr 2017 05:33:40 +0000 (22:33 -0700)]
Add platform (x64 & arm64) specific optimized jit helpers for statics access (#10912)
Rahul Kumar [Thu, 13 Apr 2017 01:22:18 +0000 (18:22 -0700)]
Merge pull request #10930 from rahku/marshalfix
HelperMethodFrame missing at certain places in method MarshalNative::PtrToStructureHelper
Rahul Kumar [Wed, 12 Apr 2017 23:13:04 +0000 (16:13 -0700)]
HelperMethodFrame missing at certain places in method MarshalNative::PtrToStructureHelper
Bruce Forstall [Wed, 12 Apr 2017 22:28:36 +0000 (15:28 -0700)]
Merge pull request #10914 from hqueue/jit/remove_unused_fuction
Remove unused function in BasicBlock
dotnet bot [Wed, 12 Apr 2017 22:27:09 +0000 (15:27 -0700)]
Merge changes from TFS (#10926)
* Fix desktop build break
[tfs-changeset:
1654125]
* JIT formatting
Stephen Toub [Wed, 12 Apr 2017 22:23:26 +0000 (18:23 -0400)]
Merge pull request #10917 from stephentoub/fix_badges
Fix build badges in OfficialAndDailyBuilds.md
Jonghyun Park [Wed, 12 Apr 2017 22:09:33 +0000 (07:09 +0900)]
[x86/Linux] Fix ResumeEsp before resume (#10749)
* [x86/Linux] Correctly unwind FCALL frames
* Fix Up ResumeEsp inside ProcessCLRException
* Fix Context Before PC Update
Jonghyun Park [Wed, 12 Apr 2017 22:07:56 +0000 (07:07 +0900)]
[x86/Linux] 16-byte aligned BackPatchWorkerAsmStub (#10759)
* [x86/Linux] 16-byte aligned BackPatchWorkerAsmStub
* Use fixed alignment padding
* Do NOT push ebx (no longer required)
Pat Gavlin [Wed, 12 Apr 2017 21:57:32 +0000 (14:57 -0700)]
Merge pull request #10905 from pgavlin/VSO406158
Fix a number of reordering issues in shift decomposition.
Jonghyun Park [Wed, 12 Apr 2017 21:44:20 +0000 (06:44 +0900)]
[x86/Linux] 16-byte aligned DelayLoad_MethodCall (#10760)
wtgodbe [Wed, 12 Apr 2017 19:47:28 +0000 (12:47 -0700)]
Enable building Core_Root for any RID against packages
Jarret Shook [Wed, 12 Apr 2017 21:37:04 +0000 (14:37 -0700)]
Merge pull request #10706 from sdmaclea/PR-ARM64-GC-EmitInsLdStOp
[Arm64] Fix GC Holes in emitInsLoadStoreOp
William Godbe [Wed, 12 Apr 2017 20:27:52 +0000 (13:27 -0700)]
Merge pull request #10923 from wtgodbe/ImproveReporting
Improve reporting parameters for pipebuild
Aditya Mandaleeka [Wed, 12 Apr 2017 19:05:11 +0000 (12:05 -0700)]
Merge pull request #10911 from adityamandaleeka/handle_table_local_gc_hide_internals
[Local GC] Hide handle table internals from VM side
wtgodbe [Wed, 12 Apr 2017 18:35:42 +0000 (11:35 -0700)]
Improve reporting parameters for pipebuild
Koundinya Veluri [Wed, 12 Apr 2017 17:33:52 +0000 (10:33 -0700)]
Fix closed delegate deserialization to account for extension methods (#10901)
Functional fix for #9597:
- The code was incorrectly assuming that the serialized target type info refers to the target object's type; it actually refers to the method's reflected type, which may not be the same type when it's an extension method
Bruce Forstall [Wed, 12 Apr 2017 17:12:18 +0000 (10:12 -0700)]
Merge pull request #10243 from sdmaclea/PR-CALLI-LOWERING-ALLOWED
Allow target of calli to be lowered to ldc.i4
Michelle McDaniel [Wed, 12 Apr 2017 16:56:33 +0000 (09:56 -0700)]
Fix run-xunit-perf.cmd for local use
run-xunit-perf.cmd specifies the full path to the benchmark using
%WORKSPACE%, which a user may not set locally. This change modifies it to
use %CORECLR_ROOT%.
Atsushi Kanamori [Wed, 12 Apr 2017 16:50:26 +0000 (09:50 -0700)]
NS2.0 AssemblyName.ReferenceMatchesDefinition() (#10919)
This api was broken from its debut in 2.0 (and yet somehow
scored a 2.9% on .NET api catalog)
https://connect.microsoft.com/VisualStudio/feedback/details/752902/assemblyname-referencematchesdefinition-returns-true-even-though-the-parameters-dont-match
In 2012, the MSDN docs were changed to match its broken behavior:
Return Value
Type: System.Boolean
true if the simple assembly names are the same; otherwise, false.
Remarks
The comparison depends only on the simple assembly name. It ignores version, culture, and public key token.
A more accurate description would be:
This api takes the simple names of the ref and def.
Then it parses the simple names *as if they were*
full-blown assembly names with optional Version, Culture
and PKT (!)
Then it applies a RefToDef test to that name using a test
that's quite separate from the one used by the actual
CoreCLR loader (so any similarities between
it and the actual binding rules is purely coincidental.)
Oh, and that code assumes the Def name came from trusted
sources so if it's has a null Culture property, it NULL-AV's.
We could replicate this behavior on CoreRT (relying on
its own AssemblyBinder) but the more I progressed, the
more the venture failed to pass the laugh test (though
at least we got a nice AssemblyBinder cleanup
as a side effect.)
So what we'll do is make the api behavior match the
MSDN description (and likely come close enough to the compat bar)
but in a more straightforward fashion.
(The RefMatchesDef routine is used on one case - to
match assembly refs against a list of friend-access
assembly defs. So it's not quite dead code though
it probably should be.)
Bruce Forstall [Wed, 12 Apr 2017 16:17:17 +0000 (09:17 -0700)]
Merge pull request #10904 from BruceForstall/ArmMergeCodegenFuncs
Merge similar arm32/arm64 codegen functions
Jonghyun Park [Wed, 12 Apr 2017 16:02:35 +0000 (01:02 +0900)]
[x86/Linux] Funclet-based synchronization (#10791)
* [x86/Linux] Funclet-based synchronization
* Fix x86/Windows build error
* Revise per feedback
* Fix format error
Bruce Forstall [Wed, 12 Apr 2017 16:00:34 +0000 (09:00 -0700)]
Merge pull request #10852 from mskvortsov/ryujit-arm32-ldst-offset
[RyuJIT/ARM32] Encodable offsets for ld/st
Pat Gavlin [Wed, 12 Apr 2017 15:53:00 +0000 (08:53 -0700)]
Format code.
dotnet bot [Wed, 12 Apr 2017 15:05:37 +0000 (08:05 -0700)]
Update CoreClr to preview1-25212-04 (#10879)
Jan Kotas [Wed, 12 Apr 2017 02:33:08 +0000 (19:33 -0700)]
Fix resource string name