platform/upstream/dotnet/runtime.git
8 years agoFix some typos in comments
Bruce Forstall [Fri, 8 Jul 2016 21:24:24 +0000 (14:24 -0700)]
Fix some typos in comments

Commit migrated from https://github.com/dotnet/coreclr/commit/a8896b3b90d14830b9205ea2ed0824cd0591213a

8 years agoMerge pull request dotnet/coreclr#6163 from josteink/resolve-python
Aditya Mandaleeka [Fri, 8 Jul 2016 18:35:42 +0000 (11:35 -0700)]
Merge pull request dotnet/coreclr#6163 from josteink/resolve-python

Resolve Python2.7 when executable is not called 'python'.

Commit migrated from https://github.com/dotnet/coreclr/commit/1eb421cefab252f69dd7b54c03eed1c3011ee44c

8 years agoUpdate contributor guidelines (dotnet/coreclr#6183)
Rich Lander [Fri, 8 Jul 2016 18:34:50 +0000 (11:34 -0700)]
Update contributor guidelines (dotnet/coreclr#6183)

Commit migrated from https://github.com/dotnet/coreclr/commit/64ab292948fff4244517fa632f758e1d06a10e52

8 years agoMerge pull request dotnet/coreclr#6177 from BruceForstall/FixMultiregStructArgNyi
Bruce Forstall [Fri, 8 Jul 2016 17:45:10 +0000 (10:45 -0700)]
Merge pull request dotnet/coreclr#6177 from BruceForstall/FixMultiregStructArgNyi

Fix RyuJIT/x86 fgMorphMultiregStructArg NYI

Commit migrated from https://github.com/dotnet/coreclr/commit/db5635455e3472044975052894915233af09303a

8 years agoResolve Python2.7 when executable is not called 'python'.
Jostein Kjønigsen [Thu, 7 Jul 2016 08:49:20 +0000 (10:49 +0200)]
Resolve Python2.7 when executable is not called 'python'.

Commit migrated from https://github.com/dotnet/coreclr/commit/38c683c17a19bb7119d7334061f18257d9d6ccbb

8 years agoFix RyuJIT/x86 fgMorphMultiregStructArg NYI
Bruce Forstall [Fri, 8 Jul 2016 00:55:27 +0000 (17:55 -0700)]
Fix RyuJIT/x86 fgMorphMultiregStructArg NYI

The code leading to the fgMorphMultiregStructArg NYI shouldn't have been taken for x86.
In fgMorphArgs, I put the setting of `hasMultiregStructArgs = true` in one case under `#ifdef`.

Disable tests failing with a newly exposed assert, `'isPhiDefn || type != TYP_STRUCT'`,
tracked by dotnet/coreclr#6180.

I also fixed a number of asserts on strings that would never fail the way they were
written -- `assert("string")` instead of `assert(!"string")` -- and fixed some typos/grammar.

Commit migrated from https://github.com/dotnet/coreclr/commit/5cd421355052cbd96dc841aa845f95858909e014

8 years agoMerge pull request dotnet/coreclr#6081 from adityamandaleeka/virtual_temp
Aditya Mandaleeka [Fri, 8 Jul 2016 00:26:40 +0000 (17:26 -0700)]
Merge pull request dotnet/coreclr#6081 from adityamandaleeka/virtual_temp

Clean up unused code related to memory mapping

Commit migrated from https://github.com/dotnet/coreclr/commit/6f26329518b08055c090315eee5db533e42f39ae

8 years agoMerge pull request dotnet/coreclr#6021 from CarolEidt/LessConservativeGtObj
Carol Eidt [Thu, 7 Jul 2016 23:29:34 +0000 (16:29 -0700)]
Merge pull request dotnet/coreclr#6021 from CarolEidt/LessConservativeGtObj

Less conservative gt obj

Commit migrated from https://github.com/dotnet/coreclr/commit/aab8856ce0365ede77bb8ca8c208538a72185a54

8 years agoMerge pull request dotnet/coreclr#6175 from tijoytom/master
tijoytom [Thu, 7 Jul 2016 23:26:34 +0000 (16:26 -0700)]
Merge pull request dotnet/coreclr#6175 from tijoytom/master

MarshalAs(UnManaged.ByValArray) overflow.[Resubmitting the PR]

Commit migrated from https://github.com/dotnet/coreclr/commit/fd1a7b4bd11fdc7f2f6621976f74233ba1a74556

8 years agoMerge pull request dotnet/coreclr#6150 from sivarv/lsraRefactor
Sivarv [Thu, 7 Jul 2016 23:23:56 +0000 (16:23 -0700)]
Merge pull request dotnet/coreclr#6150 from sivarv/lsraRefactor

Outstanding code review feedback from reg-optional PR dotnet/coreclr#6092

Commit migrated from https://github.com/dotnet/coreclr/commit/1e3545729c1ca318d5f3001be3cdf77e567359ae

8 years agoMerge pull request dotnet/coreclr#6170 from wtgodbe/signarm
William Godbe [Thu, 7 Jul 2016 22:32:04 +0000 (15:32 -0700)]
Merge pull request dotnet/coreclr#6170 from wtgodbe/signarm

Revert sign.builds so that arm64 bins can be signed

Commit migrated from https://github.com/dotnet/coreclr/commit/59680a5204c468a54882f8c9eef7cd674b1fdadd

8 years agoMerge pull request dotnet/coreclr#6173 from kyulee1/gc03
Kyungwoo Lee [Thu, 7 Jul 2016 22:20:20 +0000 (15:20 -0700)]
Merge pull request dotnet/coreclr#6173 from kyulee1/gc03

ARM64: Enable Daily Job for GcStress0x3

Commit migrated from https://github.com/dotnet/coreclr/commit/105d08676202058b3b3f7392a45cee3937882211

8 years agoMarshalAs(UnManaged.ByValArray) overflow.
Tijoy Tom Kalathiparambil [Thu, 7 Jul 2016 22:03:01 +0000 (15:03 -0700)]
MarshalAs(UnManaged.ByValArray) overflow.
For non-blittable embedded array in structs we ignored the SizeConst and wrote past the
buffer when number of elementsin the arrayis greater than SizeConst.Fix is to truncate
the array at SizeConst
MarshalAs(UnManaged.ByValTStr)
Very subtle case when the SizeConst == Number of bytes required to marshal , we
write the null one past the buffer.This happens only on  machine with non-english
(multi-byte) locale as default. Fix is to check the number of bytes required and
truncate the correctly leaving space for the terminating null.

Commit migrated from https://github.com/dotnet/coreclr/commit/8d51b631b3f582a093a108acfa28c2390fe85f41

8 years agoARM64: Enable Daily Job for GcStress0x3
Kyungwoo Lee [Thu, 7 Jul 2016 21:45:02 +0000 (14:45 -0700)]
ARM64: Enable Daily Job for GcStress0x3

Commit migrated from https://github.com/dotnet/coreclr/commit/81003fbf84cd8882a63e29a15d381ecab375fbc0

8 years agoMerge pull request dotnet/coreclr#6090 from kyulee1/gctest3
Kyungwoo Lee [Thu, 7 Jul 2016 21:41:34 +0000 (14:41 -0700)]
Merge pull request dotnet/coreclr#6090 from kyulee1/gctest3

ARM64: Test Update for GcStress0x3

Commit migrated from https://github.com/dotnet/coreclr/commit/b567823b332c347ebfc7bf5726df16dc6c38690a

8 years agoAvoid box allocation in Encoding.EncodingName (dotnet/coreclr#6142)
Justin Van Patten [Thu, 7 Jul 2016 21:18:47 +0000 (14:18 -0700)]
Avoid box allocation in Encoding.EncodingName (dotnet/coreclr#6142)

`Encoding.EncodingName` concatenates a `string` with an `int` via
`string.Concat(object, object)`, which results in the `int` being
boxed.

This change avoids the box by calling `int.ToString()`,
allowing `string.Concat(string, string)` to be used.

Commit migrated from https://github.com/dotnet/coreclr/commit/a73353e66181706bc98a65b92a921d476bfd322d

8 years agoRevert sign.builds so that arm64 bins can be signed
wtgodbe [Thu, 7 Jul 2016 20:38:49 +0000 (13:38 -0700)]
Revert sign.builds so that arm64 bins can be signed

Commit migrated from https://github.com/dotnet/coreclr/commit/00d943c1e3bee5d467d410b5941eb1751d3e2162

8 years agoCode review feedback.
sivarv [Wed, 6 Jul 2016 18:29:36 +0000 (11:29 -0700)]
Code review feedback.

Commit migrated from https://github.com/dotnet/coreclr/commit/cc23275388ec304aeca054b9a255c87a502c2bcd

8 years agoMerge pull request dotnet/coreclr#6114 from jamesqo/encodingforwarder
Tarek Mahmoud Sayed [Thu, 7 Jul 2016 18:35:03 +0000 (11:35 -0700)]
Merge pull request dotnet/coreclr#6114 from jamesqo/encodingforwarder

Consolidate much of the duplicated code across Encoding implementations

Commit migrated from https://github.com/dotnet/coreclr/commit/00eca9ab295420873a551d3a9e0acde0da20338a

8 years agoMerge pull request dotnet/coreclr#6152 from mikedn/x86-addsub-lo
Carol Eidt [Thu, 7 Jul 2016 15:55:28 +0000 (08:55 -0700)]
Merge pull request dotnet/coreclr#6152 from mikedn/x86-addsub-lo

[WIP] Introduce GT_ADD_LO and GT_SUB_LO

Commit migrated from https://github.com/dotnet/coreclr/commit/840a6ca79d4643cd0cfed9444e5658933d901618

8 years agoARM64: Test Update for GcStress0x3
Kyungwoo Lee [Wed, 6 Jul 2016 16:16:02 +0000 (09:16 -0700)]
ARM64: Test Update for GcStress0x3

Commit migrated from https://github.com/dotnet/coreclr/commit/81fc669a8c302a5628811682173c2ae379bfe7df

8 years agoMerge pull request dotnet/coreclr#6161 from dotnet-bot/UpdateDependencies20160707062011
Gaurav Khanna [Thu, 7 Jul 2016 13:43:17 +0000 (06:43 -0700)]
Merge pull request dotnet/coreclr#6161 from dotnet-bot/UpdateDependencies20160707062011

Updating External dependencies to beta-24307-00

Commit migrated from https://github.com/dotnet/coreclr/commit/49f97a102c9859258832688e4cea1963aa56b011

8 years agoAvoid heap allocating in char.ConvertFromUtf32 (dotnet/coreclr#6141)
James Ko [Thu, 7 Jul 2016 10:41:09 +0000 (06:41 -0400)]
Avoid heap allocating in char.ConvertFromUtf32 (dotnet/coreclr#6141)

Commit migrated from https://github.com/dotnet/coreclr/commit/ebbff97a9712ae1e625a9a7c26586f8f21070b5c

8 years agoUpdating External dependencies to beta-24307-00
dotnet-bot [Thu, 7 Jul 2016 06:20:11 +0000 (06:20 +0000)]
Updating External dependencies to beta-24307-00

Commit migrated from https://github.com/dotnet/coreclr/commit/a2ef8a06d6566ae39f30bd45fe2df79a6fd8310b

8 years agoConvert SymbolType.m_format to be a string (dotnet/coreclr#6133)
James Ko [Thu, 7 Jul 2016 06:03:59 +0000 (02:03 -0400)]
Convert SymbolType.m_format to be a string (dotnet/coreclr#6133)

Commit migrated from https://github.com/dotnet/coreclr/commit/de7eaa720b309f3cea66e2e276392a60e363c2cc

8 years agoAvoid box allocation in DateTimeFormat.FormatCustomized (dotnet/coreclr#6147)
Justin Van Patten [Thu, 7 Jul 2016 05:39:34 +0000 (22:39 -0700)]
Avoid box allocation in DateTimeFormat.FormatCustomized (dotnet/coreclr#6147)

The current implementation calls `string.Concat(object, object)`, which
results in an `int` box allocation.

Avoid the box allocation by calling `int.ToString()`, allowing
`string.Concat(string, string)` to be used.

Commit migrated from https://github.com/dotnet/coreclr/commit/62482f58b025eebd05101e33f2d2253fee070ab5

8 years agoAvoid box allocation in TypeBuilder.DefineDataHelper (dotnet/coreclr#6148)
Justin Van Patten [Thu, 7 Jul 2016 05:37:53 +0000 (22:37 -0700)]
Avoid box allocation in TypeBuilder.DefineDataHelper (dotnet/coreclr#6148)

The current implementation calls `string.Concat(object, object)`, which
results in a box allocation.

Avoid the box allocation by calling `int.ToString()`, allowing
`string.Concat(string, string)` to be used.

Commit migrated from https://github.com/dotnet/coreclr/commit/953d38321f817dffe18261ce77d508947ed4b4fb

8 years agoAvoid box allocation in ActivityTracker (dotnet/coreclr#6149)
Justin Van Patten [Thu, 7 Jul 2016 05:37:02 +0000 (22:37 -0700)]
Avoid box allocation in ActivityTracker (dotnet/coreclr#6149)

The current implementation calls
`string.Concat(object, object, object)`, which results in a box
allocation.

Avoid the box allocation by calling `long.ToString()`, allowing
`string.Concat(string, string, string)` to be used.

Commit migrated from https://github.com/dotnet/coreclr/commit/e6ca607e9dfa0718270aec74b9c9ff6ae3296f3c

8 years agomake all public properties of DebuggableAttribute visible outside mscorlib (dotnet...
Adam Sitnik [Thu, 7 Jul 2016 05:35:34 +0000 (07:35 +0200)]
make all public properties of DebuggableAttribute visible outside mscorlib (dotnet/coreclr#6153)

Commit migrated from https://github.com/dotnet/coreclr/commit/245ea79a84481d3d2b66c860b3d74e3251586cfb

8 years agoMerge pull request dotnet/coreclr#6157 from rahku/crossgen
Rahul Kumar [Thu, 7 Jul 2016 01:39:02 +0000 (18:39 -0700)]
Merge pull request dotnet/coreclr#6157 from rahku/crossgen

Do not clean tests folder when skiptests option is used along with clean

Commit migrated from https://github.com/dotnet/coreclr/commit/103598b7a612f0225170fea7d6b4430c87b843e4

8 years agoMerge pull request dotnet/coreclr#6151 from mikedn/runbench-coreclr
Aditya Mandaleeka [Wed, 6 Jul 2016 21:41:57 +0000 (14:41 -0700)]
Merge pull request dotnet/coreclr#6151 from mikedn/runbench-coreclr

Fix incorrect RunBenchmarks help text

Commit migrated from https://github.com/dotnet/coreclr/commit/c29547fc1559c9d90735efab1253c8cbf259319b

8 years agoDo not clean tests folder when skiptests option is used along with clean
Rahul Kumar [Wed, 6 Jul 2016 21:39:21 +0000 (14:39 -0700)]
Do not clean tests folder when skiptests option is used along with clean

Commit migrated from https://github.com/dotnet/coreclr/commit/14ae2d54a4d37303d4a3a4d52c300596559ef41a

8 years agoMerge pull request dotnet/coreclr#6130 from rahku/crossgen
Rahul Kumar [Wed, 6 Jul 2016 21:00:04 +0000 (14:00 -0700)]
Merge pull request dotnet/coreclr#6130 from rahku/crossgen

ARM64: Fix incremental build problem for cross-components

Commit migrated from https://github.com/dotnet/coreclr/commit/5a95caf62c33b61e1c4deab47101d92a386bab2a

8 years agoFix incremental build problem for cross-components
Rahul Kumar [Tue, 5 Jul 2016 22:04:59 +0000 (15:04 -0700)]
Fix incremental build problem for cross-components

Commit migrated from https://github.com/dotnet/coreclr/commit/74870facf4fa0f70a0c2ba5ff7ec2bd349faeb32

8 years agoMerge pull request dotnet/coreclr#6139 from mkborg/fix_lldb_search_order
Aditya Mandaleeka [Wed, 6 Jul 2016 19:32:47 +0000 (12:32 -0700)]
Merge pull request dotnet/coreclr#6139 from mkborg/fix_lldb_search_order

Fix LLDB search order

Commit migrated from https://github.com/dotnet/coreclr/commit/85574fc06c334c1cdcaddfa2167988ccea818709

8 years agoMerge pull request dotnet/coreclr#6146 from ellismg/fix-sign-targets-syntax-error
Matt Ellis [Wed, 6 Jul 2016 18:38:36 +0000 (11:38 -0700)]
Merge pull request dotnet/coreclr#6146 from ellismg/fix-sign-targets-syntax-error

Fix syntax error in sign.builds

Commit migrated from https://github.com/dotnet/coreclr/commit/585f3e1672ebf8f5486b200ab998a3cc229df75c

8 years agoFix incorrect RunBenchmarks help text
Mike Danes [Wed, 6 Jul 2016 18:29:06 +0000 (21:29 +0300)]
Fix incorrect RunBenchmarks help text

RunBenchmark's help text claims that there's a -coreclr option when in fact the option is -runner.

Commit migrated from https://github.com/dotnet/coreclr/commit/17aebd846b202d4b19f1adfad79eefdaf57bd244

8 years agoIntroduce GT_ADD_LO and GT_SUB_LO
Mike Danes [Wed, 6 Jul 2016 17:23:42 +0000 (20:23 +0300)]
Introduce GT_ADD_LO and GT_SUB_LO

Commit migrated from https://github.com/dotnet/coreclr/commit/77f1603b268452bc49ccd69ae8930e5e5357ca39

8 years agoFix syntax error in sign.builds
Matt Ellis [Wed, 6 Jul 2016 16:55:23 +0000 (09:55 -0700)]
Fix syntax error in sign.builds

Commit migrated from https://github.com/dotnet/coreclr/commit/ce4950e101a96a7f39f14aaf49ef8f8d87c79b3b

8 years agoMerge pull request dotnet/coreclr#6015 from kouvel/NamedMutexMoreFlockCases
Koundinya Veluri [Wed, 6 Jul 2016 16:50:12 +0000 (09:50 -0700)]
Merge pull request dotnet/coreclr#6015 from kouvel/NamedMutexMoreFlockCases

Named mutex: Use flock instead of pthread process-shared mutex in som…

Commit migrated from https://github.com/dotnet/coreclr/commit/66b6219f6e1c0e0162d52e1c098554e73777a52d

8 years agoMerge pull request dotnet/coreclr#6135 from dotnet-bot/UpdateDependencies20160706051943
Gaurav Khanna [Wed, 6 Jul 2016 14:19:00 +0000 (07:19 -0700)]
Merge pull request dotnet/coreclr#6135 from dotnet-bot/UpdateDependencies20160706051943

Updating External dependencies to beta-24306-00

Commit migrated from https://github.com/dotnet/coreclr/commit/b799cf9626020a0b67676e34cc9e6aeac798a87e

8 years agoFix LLDB search order
Mikhail I. Krivtsov [Wed, 6 Jul 2016 11:37:39 +0000 (14:37 +0300)]
Fix LLDB search order

By default 'find_library' without 'NO_DEFAULT_PATH' keyword searches
first in default locations specified by '${CMAKE_SYSTEM_PREFIX_PATH}'
and only then in locations specified via 'PATHS' keyword
('${WITH_LLDB_LIBS}' in our case). As result it always picks-up default
LLDB ignoring the one explicitly specified via '${WITH_LLDB_LIBS}'.
This change modifies search order giving priority to '${WITH_LLDB_LIBS}'
and '${WITH_LLDB_INCLUDES}' over default locations.

Commit migrated from https://github.com/dotnet/coreclr/commit/c1b65bdc225386e4f2af4c49512fbb93579c0973

8 years agoUpdating External dependencies to beta-24306-00
dotnet-bot [Wed, 6 Jul 2016 05:19:43 +0000 (05:19 +0000)]
Updating External dependencies to beta-24306-00

Commit migrated from https://github.com/dotnet/coreclr/commit/fd3d4a336e51e75058239d35447d18d3591ac92c

8 years agoNamed mutex: Use flock instead of pthread process-shared mutex in some more cases
Koundinya Veluri [Mon, 27 Jun 2016 17:53:28 +0000 (10:53 -0700)]
Named mutex: Use flock instead of pthread process-shared mutex in some more cases

Workaround for dotnet/coreclr#5456:
- Sometimes, a timed wait operation is not getting released, causing a hang
- Due to the hang, it is not possible to detect this issue with code
- Temporarily disabled the use of pthread process-shared mutexes on ARM/ARM64. File locks will be used instead.

Workaround for dotnet/coreclr#5872:
- On Alpine Linux, a pthread process-shared robust mutex is detecting the case where a process abandons the mutex when it exits while holding the lock, but is putting the mutex into an unrecoverable state (ENOTRECOVERABLE) instead of assigning lock ownership to the next thread that is released from a wait for a lock and notifying of abandonment (EOWNERDEAD).
- Added a test case to detect this issue, to have it use file locks instead

Close dotnet/coreclr#5456

Commit migrated from https://github.com/dotnet/coreclr/commit/f63816767aee67509ac3c61e94ff95d371471493

8 years agoMerge pull request dotnet/coreclr#6098 from CarolEidt/BlkNodeRefactors
Carol Eidt [Tue, 5 Jul 2016 22:55:48 +0000 (15:55 -0700)]
Merge pull request dotnet/coreclr#6098 from CarolEidt/BlkNodeRefactors

More Blk Op Refactoring

Commit migrated from https://github.com/dotnet/coreclr/commit/9990ac928903d556c635a8d4162a4907c4e41eb1

8 years agoMerge pull request dotnet/coreclr#6102 from briansull/inliner-dump
Brian Sullivan [Tue, 5 Jul 2016 22:48:14 +0000 (15:48 -0700)]
Merge pull request dotnet/coreclr#6102 from briansull/inliner-dump

Improve the dump for inline return expressions

Commit migrated from https://github.com/dotnet/coreclr/commit/63d50adfee9fb3cf31ca09ac2c9c33e11ef4b076

8 years agoMerge pull request dotnet/coreclr#6101 from BruceForstall/RyuJITx86EH
Bruce Forstall [Tue, 5 Jul 2016 21:58:31 +0000 (14:58 -0700)]
Merge pull request dotnet/coreclr#6101 from BruceForstall/RyuJITx86EH

RyuJIT/x86: add support for EH

Commit migrated from https://github.com/dotnet/coreclr/commit/5e4d41cfb115f6c4b662a5df46eba759b56dae20

8 years agoMerge pull request dotnet/coreclr#6094 from mikedn/x86-uncontained-long
Sivarv [Tue, 5 Jul 2016 21:47:48 +0000 (14:47 -0700)]
Merge pull request dotnet/coreclr#6094 from mikedn/x86-uncontained-long

Allow uncontained GT_LONG nodes

Commit migrated from https://github.com/dotnet/coreclr/commit/ec8157edd52146b108b02d821d88d295048d5212

8 years agoMerge pull request dotnet/coreclr#6124 from dotnet-bot/from-tfs
Bruce Forstall [Tue, 5 Jul 2016 20:33:28 +0000 (13:33 -0700)]
Merge pull request dotnet/coreclr#6124 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/e18245844cc8400400fc05c01ecf311cb9bdf019

8 years agoMerge pull request dotnet/coreclr#6100 from BruceForstall/BotrX86EHUpdate
Bruce Forstall [Tue, 5 Jul 2016 20:29:59 +0000 (13:29 -0700)]
Merge pull request dotnet/coreclr#6100 from BruceForstall/BotrX86EHUpdate

Add information on x86 EH to CLR ABI

Commit migrated from https://github.com/dotnet/coreclr/commit/b94ccd123439f86bf6a29b9f9c905b42ca737cb1

8 years agoMerge pull request dotnet/coreclr#6093 from rahku/arm64retbuf
Rahul Kumar [Tue, 5 Jul 2016 18:49:29 +0000 (11:49 -0700)]
Merge pull request dotnet/coreclr#6093 from rahku/arm64retbuf

Revert Pinvoke ILStub calli signature for desktop clr

Commit migrated from https://github.com/dotnet/coreclr/commit/7782e7db223d2a90792546d715f88648c600c5a3

8 years agoonly use config on coreclr
Maoni Stephens [Tue, 5 Jul 2016 18:47:29 +0000 (11:47 -0700)]
only use config on coreclr

[tfs-changeset: 1616092]

Commit migrated from https://github.com/dotnet/coreclr/commit/0881ab88c6b219aa2325543f3b180337cba3fd3c

8 years agoRemove TODO on throwing exception
James Ko [Tue, 5 Jul 2016 16:45:15 +0000 (12:45 -0400)]
Remove TODO on throwing exception

Commit migrated from https://github.com/dotnet/coreclr/commit/467f06d6f01deb4905a901a9d337a8dfdef817e1

8 years agoMerge pull request dotnet/coreclr#6106 from mikedn/modopt-feedback
Bruce Forstall [Tue, 5 Jul 2016 16:31:21 +0000 (09:31 -0700)]
Merge pull request dotnet/coreclr#6106 from mikedn/modopt-feedback

Address div/mod CR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/59c6500f2f10b6e3f55b43e549ddc0293d9ee4fc

8 years agoMore Blk Op Refactoring
Carol Eidt [Sat, 2 Jul 2016 00:03:52 +0000 (17:03 -0700)]
More Blk Op Refactoring

Code refactoring in preparation for 1st Class Structs:
Factor out the legacy code generation for CpObj.
Abstract some functionality to member methods.
Move some block-related method definitions.
Make fgOrderBlockOps legacy-only (it is unused in RyuJIT).
Factor out the code to create a block init value.
Add a new IsLocalExpr() method.
Change some variable names to distinguish between objects and their addresses.

Commit migrated from https://github.com/dotnet/coreclr/commit/12ea758226379d60a6b7fe3c36c1ae687c13012b

8 years agoMove the SecuritySafeCritical attributes to EncodingForwarder
James Ko [Tue, 5 Jul 2016 14:58:26 +0000 (10:58 -0400)]
Move the SecuritySafeCritical attributes to EncodingForwarder

Commit migrated from https://github.com/dotnet/coreclr/commit/a64020c8825770ccc8a83d200783a979fbac6434

8 years agoMerge pull request dotnet/coreclr#6120 from dotnet-bot/UpdateDependencies20160705051942
Stephen Toub [Tue, 5 Jul 2016 11:59:03 +0000 (07:59 -0400)]
Merge pull request dotnet/coreclr#6120 from dotnet-bot/UpdateDependencies20160705051942

Updating External dependencies to beta-24305-00

Commit migrated from https://github.com/dotnet/coreclr/commit/5e0cb3af80d85290c5db416d8886c83d7b5d7621

8 years agoBetter performance for MulticastDelegate.Equals (dotnet/coreclr#6113)
James Ko [Tue, 5 Jul 2016 09:50:52 +0000 (05:50 -0400)]
Better performance for MulticastDelegate.Equals (dotnet/coreclr#6113)

Better performance for MulticastDelegate.Equals

Commit migrated from https://github.com/dotnet/coreclr/commit/a8cdb489463200598631c5acacc5aa521e10b139

8 years agoOne of the flags MAP_SHARED or MAP_PRIVATE has to be specified. MAP_PRIVATE seems...
Viacheslav Nikolaev [Tue, 5 Jul 2016 06:33:46 +0000 (09:33 +0300)]
One of the flags MAP_SHARED or MAP_PRIVATE has to be specified. MAP_PRIVATE seems to fit here. (dotnet/coreclr#6089)

Commit migrated from https://github.com/dotnet/coreclr/commit/ad40ed696dbc696733e09422d57622ed574ecec8

8 years agoUpdating External dependencies to beta-24305-00
dotnet-bot [Tue, 5 Jul 2016 05:19:42 +0000 (05:19 +0000)]
Updating External dependencies to beta-24305-00

Commit migrated from https://github.com/dotnet/coreclr/commit/0f68aa835593de8a788092b37d6a481d676f3934

8 years agoAdd note on UTF8Encoding.GetByteCount to EncodingForwarder
James Ko [Tue, 5 Jul 2016 00:20:43 +0000 (20:20 -0400)]
Add note on UTF8Encoding.GetByteCount to EncodingForwarder

Commit migrated from https://github.com/dotnet/coreclr/commit/a4192dc80352345be2c250b4c33b5b72680069d6

8 years agoFix CoreFX test failures
James Ko [Tue, 5 Jul 2016 00:16:44 +0000 (20:16 -0400)]
Fix CoreFX test failures

Commit migrated from https://github.com/dotnet/coreclr/commit/4fd1bfef80fbd4ccb7625196cd841f4fa6415282

8 years ago[UTF8Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:53:34 +0000 (15:53 -0400)]
[UTF8Encoding] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/1f9cd6744fcc4c14ee402ba24e26a1b9e4ce8fcc

8 years ago[UTF7Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:52:00 +0000 (15:52 -0400)]
[UTF7Encoding] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/e1818e622933da083a241963e69f36d5d6d89063

8 years ago[UTF32Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:49:54 +0000 (15:49 -0400)]
[UTF32Encoding] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/ad1ad35dc03aad4822db57bcbbe1ce7b9f4958ce

8 years ago[UnicodeEncoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:48:20 +0000 (15:48 -0400)]
[UnicodeEncoding] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/f09b521e334fcdf6c279466724a2e6b8f4642cce

8 years ago[EncodingNLS] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:45:19 +0000 (15:45 -0400)]
[EncodingNLS] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/95ff597b07cf40532f6af52beab076bd80332b0f

8 years ago[ASCIIEncoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:41:17 +0000 (15:41 -0400)]
[ASCIIEncoding] Remove unncessary comments

Commit migrated from https://github.com/dotnet/coreclr/commit/77fa0fb69c9113909fbbe3f896779eab26d9e250

8 years agoUse EncodingForwarder for GetString(byte[], int, int)
James Ko [Mon, 4 Jul 2016 19:17:25 +0000 (15:17 -0400)]
Use EncodingForwarder for GetString(byte[], int, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/372fcd3cfc8115233040a787e36d020edd919a22

8 years agoUse EncodingForwarder for GetChars(byte*, int, char*, int)
James Ko [Mon, 4 Jul 2016 19:04:43 +0000 (15:04 -0400)]
Use EncodingForwarder for GetChars(byte*, int, char*, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/ab47c2281299f464ecddb1d04c292a37b96646dc

8 years agoUse EncodingForwarder for GetChars(byte[], int, int, char[], int)
James Ko [Mon, 4 Jul 2016 18:55:39 +0000 (14:55 -0400)]
Use EncodingForwarder for GetChars(byte[], int, int, char[], int)

Commit migrated from https://github.com/dotnet/coreclr/commit/860434db541daf533b43491280774dc4274590b8

8 years agoUse EncodingForwarder for GetCharCount(byte*, int)
James Ko [Mon, 4 Jul 2016 17:08:37 +0000 (13:08 -0400)]
Use EncodingForwarder for GetCharCount(byte*, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/f83ecbead207000825555393287dafbca8259137

8 years agoUse EncodingForwarder for GetCharCount(byte[], int, int)
James Ko [Mon, 4 Jul 2016 16:55:41 +0000 (12:55 -0400)]
Use EncodingForwarder for GetCharCount(byte[], int, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/6de8ede4e8ca98a382b066ba45a172e3f8ce2821

8 years agoUse EncodingForwarder for GetBytes(char*, int, byte*, int)
James Ko [Mon, 4 Jul 2016 16:45:52 +0000 (12:45 -0400)]
Use EncodingForwarder for GetBytes(char*, int, byte*, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/7c771b8b8462d0b95130cabfe0de5efbf64278bc

8 years agoUse EncodingForwarder for GetBytes(char[], int, int, byte[], int)
James Ko [Mon, 4 Jul 2016 16:39:03 +0000 (12:39 -0400)]
Use EncodingForwarder for GetBytes(char[], int, int, byte[], int)

Commit migrated from https://github.com/dotnet/coreclr/commit/088943185a0469d936a8c0b6e235bdc715e6fc25

8 years agoUse EncodingForwarder for GetBytes(string, int, int, byte[], int)
James Ko [Mon, 4 Jul 2016 16:25:21 +0000 (12:25 -0400)]
Use EncodingForwarder for GetBytes(string, int, int, byte[], int)

Commit migrated from https://github.com/dotnet/coreclr/commit/fa55fd74ae3e9374468d32db7371c82e6ae13593

8 years agoUse EncodingForwarder for GetByteCount(char*, int)
James Ko [Mon, 4 Jul 2016 16:05:22 +0000 (12:05 -0400)]
Use EncodingForwarder for GetByteCount(char*, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/56c687e0afefc6c223dc0d296a4c64ab5465ebdd

8 years agoRename the chars parameter in a comment
James Ko [Mon, 4 Jul 2016 15:58:44 +0000 (11:58 -0400)]
Rename the chars parameter in a comment

Commit migrated from https://github.com/dotnet/coreclr/commit/9668b5f6275f9dbf24ecd0767d5d4817cde16322

8 years agoUse EncodingForwarder for GetByteCount(string)
James Ko [Mon, 4 Jul 2016 15:57:58 +0000 (11:57 -0400)]
Use EncodingForwarder for GetByteCount(string)

Commit migrated from https://github.com/dotnet/coreclr/commit/e61479088e1ba1f1d8756b8da1a352d518c015c8

8 years agoUse EncodingForwarder for GetByteCount(char[], int, int)
James Ko [Mon, 4 Jul 2016 15:44:55 +0000 (11:44 -0400)]
Use EncodingForwarder for GetByteCount(char[], int, int)

Commit migrated from https://github.com/dotnet/coreclr/commit/ebfc3ce64205a2a5b14c9fe487659ed02c1f3486

8 years agoMerge pull request dotnet/coreclr#6109 from dotnet-bot/UpdateDependencies20160704051959
Stephen Toub [Mon, 4 Jul 2016 10:09:55 +0000 (06:09 -0400)]
Merge pull request dotnet/coreclr#6109 from dotnet-bot/UpdateDependencies20160704051959

Updating External dependencies to beta-24304-00

Commit migrated from https://github.com/dotnet/coreclr/commit/c92870088bbb38c843751bb571198430a0e555ec

8 years agoShort-circuit on the count, not the array length, in common Encoding methods (dotnet...
James Ko [Mon, 4 Jul 2016 05:39:12 +0000 (01:39 -0400)]
Short-circuit on the count, not the array length, in common Encoding methods (dotnet/coreclr#6108)

* Short-circuit using count instead of array.Length
* Use Array.Empty in default Reset implementation

Commit migrated from https://github.com/dotnet/coreclr/commit/a1e785dccf35af4305f2536b1e25cb719e8f1943

8 years agoUpdating External dependencies to beta-24304-00
dotnet-bot [Mon, 4 Jul 2016 05:19:58 +0000 (05:19 +0000)]
Updating External dependencies to beta-24304-00

Commit migrated from https://github.com/dotnet/coreclr/commit/5325bfbebc71341c6f96ab9bf6c5231b5d4d525b

8 years agoMerge pull request dotnet/coreclr#6104 from Maoni0/config
Maoni Stephens [Sun, 3 Jul 2016 20:06:03 +0000 (13:06 -0700)]
Merge pull request dotnet/coreclr#6104 from Maoni0/config

Added 2 configs for Server GC

Commit migrated from https://github.com/dotnet/coreclr/commit/c3e09ed993019ab3a1645cfd78f77112b442f4e8

8 years agoAddress div/mod CR feedback
Mike Danes [Sun, 3 Jul 2016 16:46:15 +0000 (19:46 +0300)]
Address div/mod CR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/56c425835dcb35bbdaf1f7639a6580ea4a8215e9

8 years agoAdded 2 configs for Server GC
Maoni0 [Sun, 3 Jul 2016 04:07:23 +0000 (21:07 -0700)]
Added 2 configs for Server GC

complus var GCNoAffinitize or project.json System.GC.NoAffinitize - specify 1/true to disable hard affinity of Server GC threads to CPUs
complus var GCHeapCount or project.json System.GC.HeapCount - specify the # of Server GC threads/heaps, must be smaller than the # of logical CPUs the process is allowed to run on, ie, if you don't specifically affinitize your process it means the # of total logical CPUs on the machine; otherwise this is the # of logical CPUs you affinitized your process to.

Commit migrated from https://github.com/dotnet/coreclr/commit/d088712003e8d483872754d6b3c72aa2d4443a93

8 years agoMerge pull request dotnet/coreclr#6099 from adityamandaleeka/remove_virtual_owned
Aditya Mandaleeka [Sun, 3 Jul 2016 01:11:31 +0000 (18:11 -0700)]
Merge pull request dotnet/coreclr#6099 from adityamandaleeka/remove_virtual_owned

Remove VIRTUALOwnedRegion

Commit migrated from https://github.com/dotnet/coreclr/commit/339d991562c404417bfbc741f7d02e107cadf23d

8 years agoLess Conservative GtObj
Carol Eidt [Tue, 28 Jun 2016 00:26:02 +0000 (17:26 -0700)]
Less Conservative GtObj

Don't mark GT_OBJ with GTF_EXCEPT or GTF_GLOB_REF if it is a local struct.
Also, fix changes needed in arm register allocation and code generation
to handle the case where a struct argument is promoted, which appears to
be code that was never exercised.
Also, handle the x86/RyuJIT case where we keep re-copying struct args.
Note that in some cases we still treat an address-taken lclVar as a GTF_GLOB_REF;
this is really overloading the meaning, but teasing that apart is more complex.

Commit migrated from https://github.com/dotnet/coreclr/commit/0ce4dda421e6452ffb6ed76b01f413d271a59ff3

8 years agoMerge pull request dotnet/coreclr#6086 from dotnet-bot/UpdateDependencies20160701051708
Gaurav Khanna [Sat, 2 Jul 2016 16:12:54 +0000 (09:12 -0700)]
Merge pull request dotnet/coreclr#6086 from dotnet-bot/UpdateDependencies20160701051708

Updating External dependencies to beta-24301-00

Commit migrated from https://github.com/dotnet/coreclr/commit/efcd68cffbcb1e9f88105036a781b74b1e5d2237

8 years agoMerge pull request dotnet/coreclr#6092 from sivarv/lsrawork
Sivarv [Sat, 2 Jul 2016 13:06:44 +0000 (06:06 -0700)]
Merge pull request dotnet/coreclr#6092 from sivarv/lsrawork

Lower, LSRA and Codegen support for reg optional operands

Commit migrated from https://github.com/dotnet/coreclr/commit/e9f06e041b379f3919455ca005681a9fcac72ea6

8 years agoAllow uncontained GT_LONG nodes
Mike Danes [Fri, 1 Jul 2016 19:54:04 +0000 (22:54 +0300)]
Allow uncontained GT_LONG nodes

When the result of a TYP_LONG operation is not used the GT_LONG node inserted during decomposition remains in the tree and unlike other GT_LONG nodes is not contained and needs special handling.

This usually happens with arithmetic operations that require overflow checks,  the result of the operation may be ignored but the operation itself cannot be eliminated because it has a side-effect.

Commit migrated from https://github.com/dotnet/coreclr/commit/6f8f2154825b1cf17fbbba8ccb365069e2d7d15f

8 years agoImprove the dump for inline return expressions
Brian Sullivan [Sat, 2 Jul 2016 01:31:16 +0000 (18:31 -0700)]
Improve the dump for inline return expressions

Also don't do a deep copy of the inline return expression

Commit migrated from https://github.com/dotnet/coreclr/commit/29499d15bdf274d8a849c2dcdc7392ebe218d290

8 years agoAdd information on x86 EH to CLR ABI
Bruce Forstall [Sat, 2 Jul 2016 00:57:57 +0000 (17:57 -0700)]
Add information on x86 EH to CLR ABI

Commit migrated from https://github.com/dotnet/coreclr/commit/74db9d7c20e4927b2a129f762c3006de8e5bb49a

8 years agoRemove VIRTUALOwnedRegion.
Aditya Mandaleeka [Sat, 2 Jul 2016 00:09:47 +0000 (17:09 -0700)]
Remove VIRTUALOwnedRegion.

Commit migrated from https://github.com/dotnet/coreclr/commit/52d7750b124d5c2425a5e975a98ce8720dfcbd2c

8 years agoConsider spilled lcl var as contained memory operands for codegen purpose.
sivarv [Fri, 1 Jul 2016 18:41:02 +0000 (11:41 -0700)]
Consider spilled lcl var as contained memory operands for codegen purpose.

Commit migrated from https://github.com/dotnet/coreclr/commit/d92b629cdb742c42ef7b6a35f3ba55104539c9bd

8 years agoRyuJIT/x86: add support for EH
Bruce Forstall [Fri, 1 Jul 2016 23:55:01 +0000 (16:55 -0700)]
RyuJIT/x86: add support for EH

This change implements the necessary x86 support in RyuJIT for exception handling.
It removes the EH-related NYI. The number of NYI fallbacks in an x86 test run drops
by about 13000. There are 10 new asserts which are now suppressed: 6 appear to be
new and 4 are new instances of existing known asserts.

The various changes are:
1. Implement code generation for BBJ_CALLFINALLY/BBJ_ALWAYS blocks for invoking a finally.
This requires appropriately modifying the ShadowSP slot structure before the call.
2. Implement BBJ_EHFINALLYRET/BBJ_EHFILTERRET control transfer. The related GT_RETFILT
code was already implemented.
3. Implement GT_END_LFIN for handling return-from-finally cleanup, namely, clearing the
appropriate slot in the ShadowSP structure.

Commit migrated from https://github.com/dotnet/coreclr/commit/239856a9e4ea33d94e15a9822bbd070e425c3b85

8 years agoMerge pull request dotnet/coreclr#6096 from dotnet-bot/from-tfs
Bruce Forstall [Fri, 1 Jul 2016 23:47:51 +0000 (16:47 -0700)]
Merge pull request dotnet/coreclr#6096 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/ce97aac437beb855a794155147d08ab94f60c1fe

8 years agoFixed build breaks related to perf counter code on desktop. perf counters are only...
Maoni Stephens [Fri, 1 Jul 2016 21:47:30 +0000 (14:47 -0700)]
Fixed build breaks related to perf counter code on desktop. perf counters are only enabled on desktop.

[tfs-changeset: 1615834]

Commit migrated from https://github.com/dotnet/coreclr/commit/30720bc0aa5aa242da615fdcd7f64ffff8581884

8 years agoRevert Pinvoke ILStub calli signature for desktop clr
Rahul Kumar [Fri, 1 Jul 2016 19:20:39 +0000 (12:20 -0700)]
Revert Pinvoke ILStub calli signature for desktop clr

Commit migrated from https://github.com/dotnet/coreclr/commit/e1946b9917fa85b362897b5a1b0eb7ae73abb317

8 years agoMerge pull request dotnet/coreclr#6083 from adityamandaleeka/upload_ci_dumps
Aditya Mandaleeka [Fri, 1 Jul 2016 20:11:10 +0000 (13:11 -0700)]
Merge pull request dotnet/coreclr#6083 from adityamandaleeka/upload_ci_dumps

Start using dumpling service to upload dumps from CI runs

Commit migrated from https://github.com/dotnet/coreclr/commit/2af325078b02d95b44ae08baa356e7cbd1cd4748