David Fort [Thu, 4 Apr 2019 16:02:41 +0000 (18:02 +0200)]
Merge pull request #5319 from akallabeth/clip_file_fix
Fixed \0 terimination of clipboard file list
Armin Novak [Wed, 3 Apr 2019 08:17:51 +0000 (10:17 +0200)]
Fixed \0 terimination of clipboard file list
David Fort [Thu, 28 Mar 2019 18:05:48 +0000 (19:05 +0100)]
Merge pull request #5249 from akallabeth/mac_timer_crash_fix
Mac timer crash fix
David Fort [Thu, 28 Mar 2019 18:04:25 +0000 (19:04 +0100)]
Merge pull request #5281 from akallabeth/assistance_ssl_init_fix
Fixed #5276: Enable SSL before parsing assistance file.
David Fort [Thu, 28 Mar 2019 18:02:19 +0000 (19:02 +0100)]
Merge pull request #5295 from akallabeth/stream_macro_fix
Fixed Stream_* macros, bracing arguments.
David Fort [Wed, 20 Mar 2019 20:28:37 +0000 (21:28 +0100)]
Merge pull request #5313 from m4ntis/fix-end-paint-log-level
Fix update_end_paint wrong log level
kubistika [Wed, 20 Mar 2019 20:01:08 +0000 (22:01 +0200)]
update.c: Fix update_end_paint wrong log level
Bernhard Miklautz [Tue, 19 Mar 2019 11:38:00 +0000 (12:38 +0100)]
Merge pull request #5307 from akallabeth/flatpak_dep_fix
Updated flatpak udev build script
David Fort [Tue, 19 Mar 2019 08:38:40 +0000 (09:38 +0100)]
Merge pull request #5311 from m4ntis/bugfix/gfx-w2s2-decode
Fix Wire to Surface 2 pixel format decode on client
Mati Shabtay [Mon, 18 Mar 2019 14:05:07 +0000 (16:05 +0200)]
client/rdpgfx_main.c: Fix wire to surface 2 pixel format decode
cerg2010cerg2010 [Mon, 18 Mar 2019 13:57:00 +0000 (16:57 +0300)]
Close file handle correctly. (#5310)
Armin Novak [Fri, 15 Mar 2019 07:52:07 +0000 (08:52 +0100)]
Fixed flatpak pcsd build
Armin Novak [Fri, 15 Mar 2019 07:47:20 +0000 (08:47 +0100)]
Updated flatpak udev build script
Mati Shabtay [Fri, 15 Mar 2019 07:37:35 +0000 (09:37 +0200)]
server/rdpgfx_main.c: Fixed caps advertise PDU recv (#5304)
Martin Fleisz [Fri, 8 Mar 2019 09:44:09 +0000 (10:44 +0100)]
Merge pull request #5297 from akallabeth/nla_server_functions
Exposing NLA functions to impersonate and revert context.
Armin Novak [Fri, 8 Mar 2019 09:10:43 +0000 (10:10 +0100)]
Exposing NLA functions to impersonate and revert context.
Armin Novak [Thu, 7 Mar 2019 08:21:04 +0000 (09:21 +0100)]
Fixed Stream_* macros, bracing arguments.
David Fort [Mon, 4 Mar 2019 08:28:15 +0000 (09:28 +0100)]
Merge pull request #5294 from akallabeth/gfx_temporary_disable_new
Temporarily disable GFX version >= 10.3
Ilya Shipitsin [Mon, 4 Mar 2019 08:17:10 +0000 (13:17 +0500)]
client/Windows/wf_event.c: add missing "break" (#5293)
found by cppcheck
[client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?
Armin Novak [Mon, 4 Mar 2019 08:07:27 +0000 (09:07 +0100)]
Temporarily disable GFX version >= 10.3
Martin Fleisz [Fri, 1 Mar 2019 09:06:56 +0000 (10:06 +0100)]
Merge pull request #5252 from akallabeth/big_endian_fix
Fixed endianess issue with GETPIXEL16 and GETPIXEL32
Martin Fleisz [Thu, 28 Feb 2019 12:58:10 +0000 (13:58 +0100)]
Merge pull request #5289 from akallabeth/gfx_crash_fix
Disabled RDPGFX_CAPVERSION_106 for good.
Armin Novak [Thu, 28 Feb 2019 12:43:11 +0000 (13:43 +0100)]
Disabled RDPGFX_CAPVERSION_106 for good.
MartinHaimberger [Thu, 28 Feb 2019 09:55:12 +0000 (10:55 +0100)]
Merge pull request #5027 from akallabeth/wlog_off_fix
Fix #5024: Update inherited log level for all child loggers when setting a new one.
Martin Fleisz [Thu, 28 Feb 2019 08:35:15 +0000 (09:35 +0100)]
Merge pull request #5288 from akallabeth/rdp_spec_updates
Rdp spec updates
Armin Novak [Wed, 27 Feb 2019 16:15:43 +0000 (17:15 +0100)]
Fixed EGFX capability parsing, respect length fields.
Disable RDPGFX_CAPVERSION_106 as we currently do not support scaled
outputs.
Armin Novak [Wed, 27 Feb 2019 15:36:15 +0000 (16:36 +0100)]
Updated EGFX support to 10.6
Armin Novak [Wed, 27 Feb 2019 15:30:55 +0000 (16:30 +0100)]
Fixed version magic mismatch with [MS-RDPBCGR]
DraganNSDK [Mon, 25 Feb 2019 11:44:51 +0000 (06:44 -0500)]
potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280)
* xk_keyboard_update_modifier_keys fixed to clear the buffer.
* removed the xf_keyboard_clear(xfc) fix comments
Armin Novak [Mon, 25 Feb 2019 09:37:30 +0000 (10:37 +0100)]
Fixed #5276: Enable SSL before parsing assistance file.
The assistance file requires primitives from the ssl wrapper.
Enable these before parsing the file.
Additionally split the FIPS mode enablement from the one time
initializer to avoid ignoring that flag.
Jiajun Wang [Fri, 22 Feb 2019 16:31:42 +0000 (00:31 +0800)]
Fixed TS_INFO_PACKET (#5275)
Those fields exclude the length of the mandatory null terminator:
* cbDomain
* cbUserName
* cbPassword
* cbAlternateShell
* cbWorkingDir
akallabeth [Fri, 22 Feb 2019 12:43:10 +0000 (13:43 +0100)]
Merge pull request #5274 from chipitsine/master
libfreerdp/codec/include/bitmap.c: resolve possible NULL pointer arithmetic
Ilya Shipitsin [Fri, 22 Feb 2019 12:18:19 +0000 (17:18 +0500)]
libfreerdp/codec/include/bitmap.c: resolve possible NULL pointer arithmetic
found by cppcheck
[libfreerdp/codec/include/bitmap.c:112] -> [libfreerdp/codec/include/bitmap.c:95]: (warning) Either the condition '!pbSrcBuffer' is redundant or there is pointer arithmetic with NULL pointer.
[libfreerdp/codec/include/bitmap.c:112] -> [libfreerdp/codec/include/bitmap.c:96]: (warning) Either the condition '!pbDestBuffer' is redundant or there is pointer arithmetic with NULL pointer.
Martin Fleisz [Fri, 22 Feb 2019 11:47:06 +0000 (12:47 +0100)]
Merge pull request #5271 from akallabeth/create_event_exa_scanbuild_fix
Create event exa scanbuild fix
Martin Fleisz [Thu, 21 Feb 2019 15:36:00 +0000 (16:36 +0100)]
Merge pull request #5272 from akallabeth/ssl_api_warning_fixes
Ssl api warning fixes
Armin Novak [Thu, 21 Feb 2019 13:01:42 +0000 (14:01 +0100)]
Silenced unused-const-variables for test cases.
Armin Novak [Thu, 21 Feb 2019 12:52:11 +0000 (13:52 +0100)]
Fixed cast warnings from freerdp_load_channel_addin_entry
Armin Novak [Thu, 21 Feb 2019 12:50:16 +0000 (13:50 +0100)]
Silenced function pointer cast warnings for BIO_callback_ctrl
Armin Novak [Thu, 21 Feb 2019 11:20:25 +0000 (12:20 +0100)]
Ignore INVALID_HANDLE_VALUE during clang scanbuild runs.
The value INVALID_HANDLE_VALUE could in theory be a valid memory address,
so the analyzer is confused and thinks either we have a memroy leak
or we try to free a fixed address.
Armin Novak [Thu, 21 Feb 2019 11:20:06 +0000 (12:20 +0100)]
Respect return value from SetEvent and abort creation.
David Fort [Thu, 21 Feb 2019 11:16:31 +0000 (12:16 +0100)]
Merge pull request #5270 from akallabeth/warning_fixes_more_more_more
Warning fixes more more more
Armin Novak [Thu, 21 Feb 2019 10:42:06 +0000 (11:42 +0100)]
Fixed conversion warnings.
Range checks and type casts to remove all warnings in printer channel.
Armin Novak [Thu, 21 Feb 2019 10:36:50 +0000 (11:36 +0100)]
Fixed all integer conversion warnings for OpenH264.
Added range checks and casts to integer where necessary
to remove warnings.
Armin Novak [Thu, 21 Feb 2019 10:35:48 +0000 (11:35 +0100)]
Fixed xrealloc argument type
Using a void* as arugment instead of char* removes warnings when
allocating something beside a string.
David Fort [Thu, 21 Feb 2019 10:22:40 +0000 (11:22 +0100)]
Merge pull request #5269 from anbukart/master
Embedded window client
anbukart [Thu, 21 Feb 2019 05:33:52 +0000 (11:03 +0530)]
Embedded window local fix
Client width and height getting set as 0 when embedded using ParentWindowId setting
David Fort [Wed, 20 Feb 2019 09:24:16 +0000 (10:24 +0100)]
Merge pull request #5265 from akallabeth/wayland_mouse_wheel_adjust
Fixed #5262: Vertical mouse wheel direction and whell step
Armin Novak [Wed, 20 Feb 2019 07:56:36 +0000 (08:56 +0100)]
Fixed #5262: Vertical mouse wheel direction and whell step
* Vertical wheel uses the inverted direction of horizontal wheel.
* The wheel step is now calculated from the value provided by wayland.
David Fort [Wed, 13 Feb 2019 17:45:17 +0000 (18:45 +0100)]
Merge pull request #5248 from akallabeth/naming_fixes
Replace hard coded xfreerdp program name
Armin Novak [Wed, 13 Feb 2019 08:30:34 +0000 (09:30 +0100)]
Fixed endianess issue with GETPIXEL16 and GETPIXEL32
akallabeth [Wed, 13 Feb 2019 07:45:19 +0000 (08:45 +0100)]
Merge pull request #5246 from wintersandroid/master
Resolve Gfx mode missing surface updates from cache.
Armin Novak [Tue, 12 Feb 2019 10:16:36 +0000 (11:16 +0100)]
Fixed #5234: Added timer invalidate on application willresignactive
Armin Novak [Tue, 12 Feb 2019 09:53:46 +0000 (10:53 +0100)]
Replaced hardcoded xfreerdp program name
Armin Novak [Tue, 12 Feb 2019 09:53:42 +0000 (10:53 +0100)]
Replaced hardcoded xfreerdp program name
Armin Novak [Tue, 12 Feb 2019 09:53:37 +0000 (10:53 +0100)]
Replaced hardcoded xfreerdp program name
Armin Novak [Tue, 12 Feb 2019 09:53:30 +0000 (10:53 +0100)]
Replaced hardcoded xfreerdp program name
David Fort [Tue, 12 Feb 2019 08:17:18 +0000 (09:17 +0100)]
Merge pull request #5245 from akallabeth/uwac_zero_init
Fix 5243: Allocate buffers zero in uwac.
Mathew Winters [Tue, 12 Feb 2019 01:27:11 +0000 (14:27 +1300)]
Resolve Gfx mode missing surface updates from cache.
Armin Novak [Mon, 11 Feb 2019 10:54:19 +0000 (11:54 +0100)]
Fix 5243: Allocate buffers zero in uwac.
David Fort [Fri, 8 Feb 2019 15:47:01 +0000 (16:47 +0100)]
Merge pull request #5219 from akallabeth/wayland_smart_sizing
Wayland smart sizing
Armin Novak [Fri, 8 Feb 2019 14:22:06 +0000 (15:22 +0100)]
Destroying released cursor buffers.
Armin Novak [Fri, 8 Feb 2019 12:42:45 +0000 (13:42 +0100)]
Don't destroy wayland buffer attached to a surface.
Armin Novak [Fri, 8 Feb 2019 11:49:32 +0000 (12:49 +0100)]
Added support for /smart-sizing:<width>x<height> syntax in wayland client.
Armin Novak [Fri, 8 Feb 2019 10:50:34 +0000 (11:50 +0100)]
Fixed duplicate log tag definition in wayland client.
Armin Novak [Tue, 29 Jan 2019 16:47:41 +0000 (17:47 +0100)]
Fixed conversion range checks and cast for use with cairo
Armin Novak [Tue, 29 Jan 2019 16:47:30 +0000 (17:47 +0100)]
Fixed missing initializer.
Armin Novak [Tue, 29 Jan 2019 16:38:33 +0000 (17:38 +0100)]
Removed unused variables.
Armin Novak [Tue, 29 Jan 2019 14:37:49 +0000 (15:37 +0100)]
Fixed color format for wayland mouse pointer.
Armin Novak [Tue, 29 Jan 2019 12:14:45 +0000 (13:14 +0100)]
Added mouse pointer scaling.
Armin Novak [Fri, 25 Jan 2019 10:47:15 +0000 (11:47 +0100)]
Implements #5215: Smart sizing using libcairo
Martin Fleisz [Fri, 8 Feb 2019 10:02:26 +0000 (11:02 +0100)]
Merge pull request #5242 from akallabeth/rail_regression_fix
Fixed broken checks in X11 event (RAIL mode)
Armin Novak [Fri, 8 Feb 2019 09:46:26 +0000 (10:46 +0100)]
Fixed broken checks in X11 event (RAIL mode)
Martin Fleisz [Fri, 8 Feb 2019 08:35:50 +0000 (09:35 +0100)]
Merge pull request #5230 from akallabeth/sign_compare_fixes
Sign compare fixes
Armin Novak [Fri, 8 Feb 2019 08:20:58 +0000 (09:20 +0100)]
Fixed wide character comparison.
Martin Fleisz [Fri, 8 Feb 2019 08:14:33 +0000 (09:14 +0100)]
Merge pull request #5152 from akallabeth/gw_logging_ext
Gw logging ext
Martin Fleisz [Fri, 8 Feb 2019 08:11:35 +0000 (09:11 +0100)]
Merge pull request #5131 from akallabeth/cmd_line_error_logging
Added extended error logging for assistance, rdp file and command line parser
Martin Fleisz [Fri, 8 Feb 2019 08:05:27 +0000 (09:05 +0100)]
Merge pull request #5225 from akallabeth/rdprd_caps_read_fix
Fixed size checks when reading rdpdr capabilities.
Bernhard Miklautz [Thu, 7 Feb 2019 09:20:50 +0000 (10:20 +0100)]
Merge pull request #5151 from akallabeth/new_cache_defaults
Updates to default settings
Armin Novak [Fri, 14 Dec 2018 11:40:18 +0000 (12:40 +0100)]
Enable server heartbeat PDU by default.
Armin Novak [Fri, 14 Dec 2018 10:51:50 +0000 (11:51 +0100)]
Disabled offscreen and bitmap cache by default.
Bernhard Miklautz [Thu, 7 Feb 2019 09:08:41 +0000 (10:08 +0100)]
Merge pull request #5139 from akallabeth/drive_hotplug_shutdown_crash_fix
Fixed crash on drive hotplug shutdown.
akallabeth [Thu, 7 Feb 2019 08:41:46 +0000 (09:41 +0100)]
Merge pull request #5237 from chipitsine/master
client/common/cmdline.c: remove redundant check
Ilya Shipitsin [Sat, 2 Feb 2019 05:22:19 +0000 (10:22 +0500)]
client/common/cmdline.c: remove redundant check
found by cppcheck
[client/common/cmdline.c:390] -> [client/common/cmdline.c:399]: (warning) Identical inner 'if' condition is always true.
akallabeth [Fri, 1 Feb 2019 07:37:24 +0000 (08:37 +0100)]
Merge pull request #5236 from chipitsine/master
client/Wayland/wlf_cliprdr.c: resolve possible null pointer dereference
Ilya Shipitsin [Thu, 31 Jan 2019 22:50:51 +0000 (03:50 +0500)]
client/Wayland/wlf_cliprdr.c: resolve possible null pointer dereference
found by cppcheck
[client/Wayland/wlf_cliprdr.c:143] -> [client/Wayland/wlf_cliprdr.c:158]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
[client/Wayland/wlf_cliprdr.c:163] -> [client/Wayland/wlf_cliprdr.c:178]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.
David Fort [Wed, 30 Jan 2019 17:22:45 +0000 (18:22 +0100)]
Merge pull request #5223 from akallabeth/scanbuild_null_fixes
Scanbuild null fixes
Armin Novak [Wed, 30 Jan 2019 14:12:08 +0000 (15:12 +0100)]
Fixed BipBuffer Read/Write, limit to SSIZE_MAX.
Armin Novak [Wed, 30 Jan 2019 14:11:51 +0000 (15:11 +0100)]
Added missing SSIZE_MAX define
Armin Novak [Wed, 30 Jan 2019 08:51:39 +0000 (09:51 +0100)]
Fixed sign-compare warning
Armin Novak [Wed, 30 Jan 2019 08:51:24 +0000 (09:51 +0100)]
Fixed use of ASCII function on WCHAR
Armin Novak [Wed, 30 Jan 2019 08:38:19 +0000 (09:38 +0100)]
Fixed sign-compare warning
Armin Novak [Wed, 30 Jan 2019 08:36:21 +0000 (09:36 +0100)]
Fixed sign-compare warning
Armin Novak [Wed, 30 Jan 2019 08:29:56 +0000 (09:29 +0100)]
Fixed sign-compare warning
Armin Novak [Wed, 30 Jan 2019 08:24:52 +0000 (09:24 +0100)]
Fixed sign-compare warning
Bernhard Miklautz [Wed, 30 Jan 2019 15:26:41 +0000 (16:26 +0100)]
Merge pull request #5147 from jphein/master
Clarified defaults of /floatbar flag
Armin Novak [Mon, 28 Jan 2019 09:56:48 +0000 (10:56 +0100)]
Fixed NULL dereferences and uninitialized values
Armin Novak [Mon, 28 Jan 2019 09:56:23 +0000 (10:56 +0100)]
Fixed NULL dereferences and uninitialized values
Armin Novak [Mon, 28 Jan 2019 09:55:56 +0000 (10:55 +0100)]
Fixed NULL dereferences and uninitialized values
Armin Novak [Mon, 28 Jan 2019 09:55:24 +0000 (10:55 +0100)]
Fixed NULL dereferences and uninitialized values
Armin Novak [Wed, 30 Jan 2019 14:43:46 +0000 (15:43 +0100)]
Fix FindNextFileA path termination with a single separator.