Sudarshan Prasad [Tue, 24 Mar 2015 03:01:15 +0000 (20:01 -0700)]
Addressed magic strings, incorrect logging
- This changeset is put up to address comments from the full
code review of RI-CA integration
Change-Id: If89b482b3d13584529a399b761ef8d8d0a36caa7
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/551
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 24 Mar 2015 22:08:03 +0000 (15:08 -0700)]
Fixed memory leak from Observer
The observer delete mechanism was not properly deleting the token
that was created for it in the AddObserver method and was identified
in the RI code review in ocstack.c line 2109.
Change-Id: I56ba9c89a1890e28c79efb2d76b0783c037cd6e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sashi Penta [Tue, 24 Mar 2015 07:44:49 +0000 (00:44 -0700)]
Defined OC_MULTICAST_PORT instead of using const 5683
Change-Id: I6b73a795f02d244d9e0b417a2b7b2f3aa7fc91a3
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/553
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Mon, 23 Mar 2015 18:49:12 +0000 (14:49 -0400)]
Removed a single instance of the usage of a "magic number" in the stack.
After walking through the logic in ValidateQuery() its clear that there
was an intention add a second #define, but this must have been over-
looked at that time. There a single #define to avoid usage of a
"magic number" (or a raw value, ie. "2") but it was actually being used
in the wrong spot in the code.
Change-Id: I2ff045005ccacc9822280d93e6b20bfac8df1cbd
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/539
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Tue, 24 Mar 2015 22:47:43 +0000 (18:47 -0400)]
Cleaned up some static initialization and casting errors in one function.
Cleaned up function to ensure that different scopes within the stack don't
act negatively on eachother by malloc'ing space for each caller to
obtain their own copy of the address.
Change-Id: I7ebdfde0fb6edbbe57f0d52b541fc252e7509b17
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/541
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Erich Keane [Tue, 24 Mar 2015 19:36:01 +0000 (12:36 -0700)]
Implemented OCRepresentation::setChildren
As reported in IOT 410, setChildren had a header entry, and
no implementation. This patch implements setChildren
Change-Id: I0f881dab27c09d72fd068c0b2d446bbfcc77a42b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/561
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Tue, 24 Mar 2015 19:36:01 +0000 (12:36 -0700)]
Implemented OCRepresentation::setChildren
As reported in IOT 410, setChildren had a header entry, and
no implementation. This patch implements setChildren
Change-Id: I0f881dab27c09d72fd068c0b2d446bbfcc77a42b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/562
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sakthivel Samidurai [Mon, 23 Mar 2015 21:00:11 +0000 (14:00 -0700)]
Clean up OCStop in C stack
Cleanup OCStop method in the C stack. Remove unnecessary
error check.
Change-Id: I4a1618c684c685a32f70b3087f08fca0961d3461
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/545
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Mon, 23 Mar 2015 18:13:04 +0000 (11:13 -0700)]
Address RI Code review comments
Remove duplicate code to convert qualityOfService to
CAMessageType.
Change-Id: Icfc7365587cd4306d619544acfa9e6e70bea5d8e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/537
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Thu, 19 Mar 2015 22:16:31 +0000 (15:16 -0700)]
Fixed KW Warnings based on using uninitialized values
The values adjusted here were improperly initialized, so these
fixes ensure that they are only used when properly initialized.
Note that in the second case, we were checking for NULL, but
dereferencing anyway. This adds an else case to avoid that.
Change-Id: I34cb292267f6ba21d3849fa5ad06b89eca02b557
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Wed, 18 Mar 2015 21:06:09 +0000 (14:06 -0700)]
Fixed memory issues related to AddClientCB
AddClientCB had a weak memory-guarantee that caused 3 values to be
leaked in certain conditions. This will prevent those from happening.
The result-setting is done in order to ensure that the values are always
properly free'd.
Change-Id: I027fab84ddf62526d51a6e7e35dd54a96acbb48d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/502
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 17 Mar 2015 22:19:38 +0000 (15:19 -0700)]
Fixed build warnings in stack
OCException's string handling was missing a few items.
ocstack used some creative casting to get a 16 bit value out
of an 8 bit array that could likely result in bad-optimizations
or undefined behavior.
Removed an unused variable.
Change-Id: I9af5d22f450f72d15b793cec57630e8c81f7b5de
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/496
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
sanjaysh [Mon, 23 Mar 2015 21:34:45 +0000 (14:34 -0700)]
isListOfObservers replaced with ObserveType in simpleserverHQ.cp
Signed-off-by: Sanjay Sharma<sanjay1.sharma@intel.com>
Change-Id: I733fd8e7e051ebf747dac58259df31c45546889e
Reviewed-on: https://gerrit.iotivity.org/gerrit/547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 23 Mar 2015 20:21:36 +0000 (16:21 -0400)]
Cleaned up some misdirection when copying a string's value.
A weird case occurred where a char* string was referencing array location
'0', then was being pass-by reference to appear as a "char*" which simply
returned the origin char* string.
Change-Id: I014207a4050d69cf5b8e2360f6c8d9d82a6c628e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/542
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 23 Mar 2015 19:26:34 +0000 (15:26 -0400)]
Added const keyword to several function parameters.
This file was considered in need of re-examination with regards to making
parameters const "where necessary" during the RI Code Review process (be-
fore merging the connectivity-abstraction and master branch).
Change-Id: I12db60e5404a0a5ce7811d53efc637815160a012
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/540
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 23 Mar 2015 19:14:23 +0000 (12:14 -0700)]
Fixed presence payload parsing logic (IOT-406)
Updated method parsePresencePayload to handle scenarios
when payload is not in the expected presence format.
Also added unit test to verify parsing functionality.
Change-Id: I47d995b8f49cc96805bf837ac2c2f77c1859da82
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/538
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Ossama Othman [Tue, 17 Mar 2015 21:43:18 +0000 (14:43 -0700)]
Automatically detect C99 flags for supported compilers.
This patch set allows the required C99 command line flags to be
automatically set earlier in the build process. Currently only gcc is
supported, but adding support for other compilers is straightforward.
Hard-coded '-std=c99' and '-std=gnu99' CFLAGS found throughout
iotivity SConscript files have been removed. Feature test macros have
been added where needed to enable extensions that were disabled by
automatic addition of '-std=c99' to the CFLAGS build variable.
Change-Id: I6d05313aefff1911d1aaa2097954a1878874e73a
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/495
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Caiwen Zhang [Mon, 23 Mar 2015 09:32:52 +0000 (17:32 +0800)]
fix boost library cross-compiling error
Make sure the cross compile toolchain path is added into the 'PATH' key
of the environment.
Change-Id: Iebe881052d5f9c351a86311d86536e5038b1e53d
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/533
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Caiwen Zhang [Tue, 3 Mar 2015 07:13:20 +0000 (15:13 +0800)]
Update scons build readme and howto document
Change-Id: I3a9e7dd82ad98f969449da42acadfad2e0eb4705
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/432
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit
f7c465f6d306179b4244591cfe0be73a14feb047)
Reviewed-on: https://gerrit.iotivity.org/gerrit/472
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Fri, 20 Mar 2015 06:53:15 +0000 (23:53 -0700)]
Add missing c flag.
Adding missing c99 flag to arduino scons files to match other builds.
Change-Id: I118374979c448981ae2a7ca59648a1d30ca33f5b
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 21:34:18 +0000 (17:34 -0400)]
Enable build process for Arduino Mega on CA Branch for the CI System.
I believe this was previously mistakenly disabled. By re-enabling this,
we can ensure that all new commits to the CA Branch are validated
correctly.
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Change-Id: Icc882206bc3e2b8dc8dd5955bfa518e361f95b2b
Reviewed-on: https://gerrit.iotivity.org/gerrit/527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 22:08:36 +0000 (18:08 -0400)]
Enable ability to build for Arduino with debug enabled.
The changes in this commit were required because for some reason the
function to log out a buffer's value was fully commented out for
the Arduino platform, while calls for it still existed for the Arduino
platform when running in debug mode.
Change-Id: Ia84761503627b05856819cca672f72ff7f897582
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Fri, 20 Mar 2015 22:39:57 +0000 (18:39 -0400)]
Disable default to auto install to Arduino device after build.
By defaulting auto-upload to false, this will allow developers to build
for the Arduino platform and remove any need to actually have an Arduino
device plugged in to their machine to see a successful build output from
Scons.
Change-Id: I804bb8cc03f38bf4d79206905bcf4bdf23ee7bb9
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/530
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Fri, 20 Mar 2015 20:42:21 +0000 (13:42 -0700)]
Fixed RI-CA review integration changes
Updated files for some issues identified in Gerrit Patch 401.
Change-Id: I5b6bfb60e10d9ae4af358e03aaf8c5a4d8854911
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/486
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Wed, 18 Mar 2015 23:01:26 +0000 (16:01 -0700)]
Update C++ unit test
Integrate OCRepresentation tests to C++ unit test.
Change-Id: I65a3bd0066d084fb51a062005e8da39a6e9e5bdc
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/503
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Doug Hudson [Thu, 19 Mar 2015 22:02:22 +0000 (18:02 -0400)]
Fix potential memcpy buffer overruns.
Change-Id: Ia43054f29a3f3b3ac8118848847a06046822615e
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/516
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
HyunJun Kim [Fri, 20 Mar 2015 02:35:46 +0000 (11:35 +0900)]
Fix and Add join/leaveGroup function for stability.
We provided leaveGroup in Thingsmanager.
But it has obscurities.
So, we have to separate two leaveGroup functions which
it had different arguments.
Now, We can select join/leaveGroup function to match our situation.
Change-Id: I0a570a4685e833e4e55ced50e1f37971b7076b26
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/522
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
minsuk1.choi [Fri, 20 Mar 2015 07:04:55 +0000 (16:04 +0900)]
Implement: Notification Manager - Resource Hosting
Problem: Not implemented
How: resource hosting feature added.
All review comments fixed.
Change-Id: I5e980f4c16519ba30a6c10313c50ab436fc99810
Signed-off-by: minsuk1.choi <minsuk1.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jk13 [Fri, 20 Mar 2015 07:58:31 +0000 (16:58 +0900)]
[SSM] Fix code license comments
1. Fix license string with format
Change-Id: If8da57a8a9252ffc4c5a5db5e48189847e167dd6
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/523
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Rami jung [Fri, 20 Mar 2015 08:58:51 +0000 (17:58 +0900)]
[SSM] adding sample SoftSensor plugin & appls . V.02
BMISensor : SoftSensor plugin. after receiving height(m) and weight(kg) , it shows BMI(Body Mass Index)
Weight Seonsr : A dummy pseudo thing sending the weight(kg)
Height Seonsr : A dummy pseudo thing sending the height(m)
Change-Id: I5b16643113569bdaa69cf709ee9335b3b3e80e08
Signed-off-by: Rami jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/524
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jk13 [Fri, 20 Mar 2015 02:14:58 +0000 (11:14 +0900)]
[SSM] Add Java SDK comments and fix formatting
1. Add Java SDK description
2. Fix existing comments format
Change-Id: I6d02e63a0c1afc9cab30d8103bc240bb4b890898
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/521
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Younghyun Joo [Fri, 20 Mar 2015 04:55:39 +0000 (13:55 +0900)]
[PPM] Modify Protocol Plugin Manager for Android platform.
1. Modify Protocol Plugin Manager for Android platform.
2. Change the rapidxml directory from "service/protocol-plugin/lib" to "extlibs"
Change-Id: I045269f3522e9e69b502e1e4706331ff4f991647
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/497
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Thu, 19 Mar 2015 12:39:28 +0000 (21:39 +0900)]
Update a resource model of configuration/diagnostics resources
We decide to change a resource model from IPSO model to OIC
(resource-attribute)model. By this decision, configuration/diagnostics
resource's server applications utilized by Things Manager are changed.
And ThingsConfiguration and ThingsDiagnostics SDK implementations are also
slightly changed.
Additionally, fix an exception problem in con-server application, which
is refered in [IoT-392]
Change-Id: I267885d710390b3aee7fdd4852c2de33c9300f87
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/514
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Doug Hudson [Mon, 16 Mar 2015 19:24:30 +0000 (15:24 -0400)]
Fixed CA logging issues.
- Fixed incorrect use of DEBUG label for logging error conditions.
Mod done as part of fixing unresolved CA issues.
- Fixed incorrect use of OIC_LOG_V in connectivity/src and
for single thread files that might affect Arduino stack size.
This issue was not listed in CA review.
Change-Id: I38cc2310bf3a7c91d0dd8b457a237c7f930e6646
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sachin Agrawal [Thu, 19 Mar 2015 19:26:19 +0000 (12:26 -0700)]
Fix OCInit review comments identified in CA-RI Integration Review
Updated OCInit to correctly handle all error situations and also
improved logging in case of failures.
Change-Id: I946255883a26b4afe96ee9d2b00ba775f7250fb1
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Thu, 19 Mar 2015 21:00:06 +0000 (14:00 -0700)]
Do not try to build OICMiddle examples on arduino.
When the target OS is arduino, avoid attempting to build the OICMiddle
example since it is C++ and not supported for that platform.
Change-Id: I054ab220214c707954f4bf3cf17b6667ee9a82a6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 19 Mar 2015 16:43:04 +0000 (12:43 -0400)]
Made changes required to get the RI layer to build properly for Arduino.
Changes made in the RI Code Review(
49ead758a03c532e7c95f5b6eb88c1d979cd36a0)
introduced build warnings on Linux. Due to the use of an older and more
verbose compiler when building for Arduino, these warnings are errors in the
build process for Arduino. This commit enables Arduino compilation by fixing
those errors.
Change-Id: I36643b4769a65badad5fc69b6fc18dbce18e22fa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 19 Mar 2015 00:44:18 +0000 (17:44 -0700)]
Removed potential buffer overflow.
Malloc based on strlen() did not acount for the null character.
Change-Id: Iff9fed3e684e26576d24d9607ebd5afefec32ef0
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/504
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 19 Mar 2015 14:57:59 +0000 (10:57 -0400)]
Added proper doxygen documentation to the file ocresourcehandler.h.
Change-Id: Iaef7aa463856615bfe4696cb3ec517e18188f28d
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Wed, 18 Mar 2015 18:23:53 +0000 (11:23 -0700)]
Added logging of tokens as hex for readability.
Tokens being printed as hex.
Removed printing of ASCII tokens as token not guranteed to be null
terminated. There seems to be some discussion about this issue in
IOT-380.
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Change-Id: I9756c552f3abc3acdadb9e9fe4b9eb20d7ecf3eb
Reviewed-on: https://gerrit.iotivity.org/gerrit/501
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Harish Kumara Marappa [Mon, 16 Mar 2015 15:25:25 +0000 (20:55 +0530)]
Protocol plugin service tizen sample application
Change-Id: If0ec6e5882ee303512e641f9996a7cd99d817d5c
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/481
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jk13 [Wed, 18 Mar 2015 07:05:13 +0000 (16:05 +0900)]
[SSM] Fix IoT-382, 383 issues
1. Fix IoT-382
-> Tizen ssm sample app crashed when start with disabling wifi
: add ip check routine
2. Fix IoT-383
-> Register query failed when greater than(>) or less than(<)
operator is used in query using tizen ssm sample app
: add text unescape function
Change-Id: I1966e122763e31e7b67c0bfded6a8231ed0a401a
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Minji Park [Thu, 19 Mar 2015 03:58:45 +0000 (12:58 +0900)]
[SSM] Fix IOT-384 issue
Android sample app crashes when invalid cqid is given in cqid textfield
-> Add editform exception handler for validating input data
Change-Id: I0319b0375f1bd90f5122c34a5ada86d454851983
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/505
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Mon, 16 Mar 2015 20:38:00 +0000 (13:38 -0700)]
Fixed InitializeException issues
InitializeException had a number of minor issues that are repaired in
this fix. Note that the interface of InitializeException changes a bit,
however it seems that no one is actually catching InitializeException
anywhere, so they wouldn't be able to use the old version.
This fix switches InitializeException to inherit from OCException,
permitting us to catch it properly, rather than being a different exception
type. This results in the reason, code, and 'what' methods working properly
in both cases, rather than differing slightly by behavior.
Change-Id: If41377af1b1c4ef7297ae9644ef2e7e7e4f8b603
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/483
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Erich Keane [Tue, 17 Mar 2015 21:05:51 +0000 (14:05 -0700)]
Removed Dead FormOCResponse Code
The function FormOCResponse was previously only used in one place,
and had no side effects other than allocating memory and filling an
object with a bunch of different values.
The calling site (OCProcessPresence) only refers to the OCResponse
object in this single call, then leaks it immediately after.
This changeset removes the function, the variable, and the call to
this function.
Change-Id: Ic40440fce04343149528fb4d33f42f73da908171
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/494
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sakthivel Samidurai [Mon, 16 Mar 2015 22:37:32 +0000 (15:37 -0700)]
Changeset for reviewing RI-CA integration changes.
--Added a single line at the end for full RI code review.
--For specific RI integration changes refer
https://gerrit.iotivity.org/gerrit/#/c/394/
Change-Id: I54e3fcf2e0c10c382d4be59d2d380eb4db5f9791
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: Sashi Penta <sashi.kumar.penta@intel.com>
Jon A. Cruz [Fri, 13 Mar 2015 01:29:37 +0000 (18:29 -0700)]
Fixed problems in URI parsing including memory corruption.
Fixed issues in CAParseURI that included
* Use of uint32_t instead of size_t.
- Passing by address resulted in corruption on 64-bit builds and all
others where the datatypes are different. This includes various
embedded devices that have a size_t smaller than uint32_t.
* Miscalculation of offset would freeze parsing once a few path components
or parameters were processed.
- While walking parsed results list the buffer-check addition would fail
and all subsequent path components or parameters (depending on each
independently) would repeat the contents of a prior item. Thus the end
of path components and/or parameter parts of the list would be filled
with repeats of a single value instead of the correct latter values.
* Replaced duplicated code blocks with a single helper function.
* Added unit tests for issue. However the test cases won't be runnable
until after the build machine issue with connectivity/test is addressed.
Change-Id: Ife3f327ae3bbda518d663bb0d6c5b4c0d8f98e9a
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/470
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 17 Mar 2015 18:14:23 +0000 (14:14 -0400)]
Removed unused macro.
Cleaned up the definition of an unused macro in occlientcb.c.
Change-Id: Id43fcb3df6140dea11fa76cd59519b007af90974
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/492
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Mon, 16 Mar 2015 22:03:29 +0000 (15:03 -0700)]
Fixed InProcClientWrapper's option parameter to OCDoResource
InProcClientWrapper was calling OCDoResource with the option
parameter set to a valid value despite the numOptions being 0.
This commit ensures that it will send a nullptr in that event,
preventing confusion during debugging in the future.
Change-Id: Ided75e1c90a971ea205e9e04bf170a5144e8206d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/485
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sakthivel Samidurai [Mon, 9 Mar 2015 23:40:49 +0000 (16:40 -0700)]
Run unit tests after building the stack
Run unit tests after building the C/C++ stacks and unit tests.
Change-Id: I11bf90f95f30815abd272a26d82c97815d4e8bc7
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/455
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Mon, 16 Mar 2015 20:14:31 +0000 (13:14 -0700)]
Fixed Free of invalid memory in remote handler
Previously review 476 (
75980f86) was submitted as a workaround
for this one, however this fixes the root cause, which is the
options pointer not being set to zero in the condition where there
is no options being set.
Change-Id: I0152dfc8c1813def7762be37fb91cc3cc3f120d3
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/482
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Fri, 13 Mar 2015 21:02:44 +0000 (14:02 -0700)]
Fix result code translations from COAP to CA.
Temp fix with macros to convert COAP codes to CA code.
Change-Id: I3bb759c63dafcfcc5a491133577c75240d63affe
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Mandeep Shetty [Sat, 14 Mar 2015 00:08:02 +0000 (17:08 -0700)]
Check validity before free-ing options pointer.
Free pointer only if pointer is valid decided on basis of
number of options preset in the header.
Change-Id: I21666e4f694652120ed164ffc763b0aeeb0ea951
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/476
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sachin Agrawal [Mon, 16 Feb 2015 06:19:03 +0000 (22:19 -0800)]
Bug Fix in earlier rehandhsake implementation
Identified a corner case in earlier rehandshake implementation where if
no data transfer takes place between client and Server before re-handshake
is issued, re-handshake process was failing. DTLS state machine does not
update it's state at Server until the first data packet was received from
client. Updated logic to detect for 're-handshake' situation when epoch
mis-match happens. Also updated dtls-client test app to conveniently test
the feature. Use 'client:rehandshake' command for testing.
Change-Id: Idfaad7d477508603c35ad7948ca7c8f05e3228d0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Mandeep Shetty [Tue, 10 Mar 2015 23:20:49 +0000 (16:20 -0700)]
Return correct stack result on malloc fail in ocstack.c
Assign OC_STACK_NO_MEMORY to result variable when memory allocation
fails before jumping to exit.
Change-Id: I99c8f4ee18d82ef1b6a70c29b4625a06f61f7e4a
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/460
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Doug Hudson [Thu, 12 Mar 2015 19:20:49 +0000 (15:20 -0400)]
Fixed bug where pointer is dereferenced before it is validated.
Change-Id: I6628c52bd3536cf57a320008e46b61968927e3f6
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/468
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Jon A. Cruz [Thu, 12 Mar 2015 17:17:32 +0000 (10:17 -0700)]
Removed incorrect static from function declaration.
Declaring the function as 'static' in a header attempts to create a private
copy of the function in each file that includes the header. Correcting this
cleared several warnings.
Change-Id: Ie1bb47e929fb0aa5530c397e4dce275ad1e0fb0e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/465
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Ossama Othman [Thu, 12 Mar 2015 21:54:43 +0000 (14:54 -0700)]
Do not bother with C++11 check on C SDK-only platforms.
Some IoTivity platforms, such as Arduino, only require the C SDK. Do
not bother running the C++11 flag check for those platforms. This
also addresses a problem where Arduino 1.0.x builds would erroneously
fail due to lack of C++11 support.
Change-Id: I1782a258837850adb65e7219254fdeee259a3cc7
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/469
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Jon A. Cruz [Fri, 6 Mar 2015 00:44:03 +0000 (16:44 -0800)]
Corrected @file tags and restored 'Files' section.
* Corrected @file tags that were inadvertently broken which left their
comments falling to the next item to be documented.
* Removed unnecessary '@brief' tags and explicit filenames. The latter are
only required when the @file is targeting a source other than the one it
is present in.
* Unified formatting of @file doc comment blocks.
* Added 'Files' section back to generated docs.
Change-Id: I7f3fbc3cecf5a922c9f8a98d673bc91a18be8847
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/461
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Caiwen Zhang [Tue, 3 Mar 2015 07:13:20 +0000 (15:13 +0800)]
Update scons build readme and howto document
Change-Id: I3a9e7dd82ad98f969449da42acadfad2e0eb4705
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/432
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
HyunJun Kim [Thu, 12 Mar 2015 02:16:03 +0000 (11:16 +0900)]
Add freature of Scheduled Group Action.
We provide function of Scheduled Group Action.
It will send some action message
when preset time is expired.
And we need some function about the time.
These function will use for checking time.
Change-Id: Ib42941db257cd481be4ed6b7f1a8c1b28ff3809e
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/436
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Joseph Morrow [Tue, 10 Mar 2015 18:53:51 +0000 (14:53 -0400)]
Added SCons support for Arduino platform.
Change-Id: I9dcf69cef00dc14e099c1355ad7f2118746fa3e1
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/431
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ashok Channa [Wed, 4 Feb 2015 09:48:20 +0000 (18:48 +0900)]
Added connectivity files for full code review
Please comment on patch set 14 if any comments are not addressed
from 1~13.
NOTE:
1)Code Comments till Patch Set 13 are updated.
2)Please put your comments on new patch sets(at least from 13) and
try to avoid on old patch sets as it difficult to review the old sets
Modified CA source files for review comments.
Updated documentation, return parameters with CAResult, optimization etc.
Global variable naming conventions ..
Change-Id: Id19ec37831ae46896b59007cdde07217b5d8696a
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Joseph Morrow [Mon, 9 Mar 2015 17:53:03 +0000 (13:53 -0400)]
Applied fixes to enable Unicast discovery in the RI Layer's sample apps.
This fixes IOT-372 "Unicast Discovery over Wifi does not work."
Change-Id: Ifbc545f8a04049518410a4d9f54f692388921288
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/452
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Minchul Lee [Tue, 24 Feb 2015 10:23:26 +0000 (19:23 +0900)]
Add tizen build option for ARM Cortex-A
Change-Id: I52b86e5353b51a3c78973b59679c2ed84a4a5e11
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/406
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval.pro@gmail.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Doug Hudson [Mon, 9 Mar 2015 20:21:23 +0000 (16:21 -0400)]
Fix error in downloading hippomocks library.
Apparently, the filename of the hippomocks library zip file that is
downloaded from the github changed from 'master.zip'
to 'hippomocks-master.zip' since the hippomocks.scons script was created.
This modification uses a SHA hash to download a specific version of
the hippomocks library.
Change-Id: Iaa3b523b11c35a918a0a3de22876f2d62f339372
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Ossama Othman [Mon, 9 Mar 2015 23:35:07 +0000 (16:35 -0700)]
Do not hardcode path separators in build paths.
It is conceivable that iotivity may be built on platforms where '/'
is not a suitable directory separator. When constructing paths use
Python's os.path.join() function instead of constructing paths by
concatenating strings with '/' in them.
Change-Id: I7c435bd454339f4df9a8e41250e705aa98a6d09f
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/456
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Jon A. Cruz [Sun, 8 Mar 2015 06:49:25 +0000 (22:49 -0800)]
Fixed DLOPEN define warning.
Unconditionally defining DLOPEN_POSIX for cpluff was causing redefinintion errors once
it started being passed in on the command-line. Added conditional guards to prevent the
warnings.
Change-Id: Ieb40909b77710fa46209465e4e924569059738c5
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/451
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Ossama Othman [Mon, 9 Mar 2015 23:50:35 +0000 (16:50 -0700)]
Updated external library paths to be ignored by git.
The downloaded cereal library is now placed in extlibs/cereal/cereal.
Updated the '.gitignore' file, accordingly. Without this change in
place, changes to extlibs/cereal/SConscript would be incorrectly
ignored.
Lastly, ignore all downloaded and unpacked expat library files and
directories.
Change-Id: Ic2a211bd421d25e92449427c64d096e785d6282e
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/457
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Mandeep Shetty [Fri, 6 Mar 2015 21:39:58 +0000 (13:39 -0800)]
Constant time insert into linked list of resources.
Do not iterate over linked list to insert at end.
We already iterate once to check if resource uri already exists.
Use a pointer to the tail of the linked list to insert resource.
Changed two extern variables to static as they're only used in one module.
Change-Id: I41f458a2384b4fa2d8a23d78e632e1614d4875c8
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/365
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Mon, 9 Mar 2015 17:54:15 +0000 (13:54 -0400)]
Fixed issues that are warnings on Linux, but errors on Arduino.
Change-Id: Ibbc1d31e64e5aad711dc576c517c7665f622f40f
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Tue, 10 Mar 2015 02:17:53 +0000 (19:17 -0700)]
Corrected OCException that had gotten out of sync with OCStackResult.
Corrected the OCException class that had gotten out of sync with
new value added to OCStackResult and was resulting in warnings and
inproper messages.
Change-Id: I2bbc3044d89aee00018593cadc7ddee56f7b8b61
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Mandeep Shetty [Fri, 27 Feb 2015 23:30:19 +0000 (15:30 -0800)]
Fixing query delimiters in uri reassembly.
The first delimiter after the uri and before the query is '?'
All eventual delimiters between query params are '&'.
This is missed out on the patch :
https://gerrit.iotivity.org/gerrit/#/c/193.
Change-Id: Iec533d10075e1692a84b36683b0b42b2b702a01e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/422
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Jon A. Cruz [Fri, 6 Mar 2015 00:44:03 +0000 (16:44 -0800)]
Corrected @file tags and restored 'Files' section.
* Corrected @file tags that were inadvertently broken which left their
comments falling to the next item to be documented.
* Removed unnecessary '@brief' tags and explicit filenames. The latter are
only required when the @file is targeting a source other than the one it
is present in.
* Unified formatting of @file doc comment blocks.
* Added 'Files' section back to generated docs.
Change-Id: I7f3fbc3cecf5a922c9f8a98d673bc91a18be8847
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/449
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Caiwen Zhang [Mon, 2 Mar 2015 09:09:04 +0000 (17:09 +0800)]
Using gnustl_shared library instead of gnustl_static
As iotiviy includes more than one library should use gnustl_shared
library instead of gnustl_static library
Change-Id: I3d35e1b482ee8c5b7cca77ac735005bd62e630d6
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/425
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Patrick C Lankswert [Tue, 17 Feb 2015 18:35:44 +0000 (13:35 -0500)]
Added Arduino Mega w/WiFi build to auto build process.
Seung-Woo Lee found a problem with the build for Arduino Mega w/WiFi.
As a result, I am adding this to the build machine list to prevent
regression in the future.
Change-Id: Icdc9fd0ffd911c1bc9c1878f17ebb86010f2c2e1
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sanjeev BA [Wed, 4 Feb 2015 03:06:10 +0000 (12:06 +0900)]
Minor typo fixes.
Change-Id: I9e36e8f6f9f88620b4d65a889f927d6c7c9c2f97
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/302
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Erich Keane [Mon, 2 Mar 2015 21:04:47 +0000 (13:04 -0800)]
Fixed Klocwork errors in InProcClientWrapper.cpp
Klocworks identified a number of issues as memory leaks, so
this fix updates the calls to use the newer version of OCDoResource
which permits passing of a NULL rather than using the out parameter.
Change-Id: I02cf1d83d4dfafca0773e6e3385881d180335de4
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/428
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Mandeep Shetty [Thu, 5 Mar 2015 22:35:29 +0000 (14:35 -0800)]
Removing unneccesary floating point conversions.
Remove casting uint types to float in presence bounds calculation
and using division with a single floating point constant instead.
Change-Id: I7b1738753ccec3109c698774204d3d92fde7de21
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Shilpa Sodani [Thu, 26 Feb 2015 23:10:38 +0000 (15:10 -0800)]
Fix Presence issue of not working on Ethernet
Change connectivityType of Presence resource to OC_ALL
Send presence notification on all the n/w interface
Fix IOT-351 & IOT-270
Fixed the if-statement for freeing header options
Change-Id: I553434b77885a466a63fba0968edf400abacb53f
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/415
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
William Dieter [Fri, 27 Feb 2015 04:58:06 +0000 (23:58 -0500)]
Removed Doxygen warnings caused by improper formatting of several headers
OCResource.h and OCPlatform.h had a number of methods where improperly
documented. They had:
* Incorrect parameter names for a several methods,
* Missing documentation for overloaded methods,
* Where only one overload was documented, often the documentation was
attached to the wrong overloaded method,
* Improper capitalization, and
* Formatting that impairs readability of Doxygen HTML documentation.
This commit addresses those issues.
Change-Id: I4536964afe91f4278810fe2d71f0cf74cf7a78b7
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
William Dieter [Fri, 27 Feb 2015 15:11:38 +0000 (15:11 +0000)]
Removed unneeded references to oic-utilities
The oic-utilities repo was used as a temporary solution for holding third
party libraries. The build system now has a better way to handle them.
This commit removes obsolete instructions to copy the oic-utilities repo
from the scons build instructions.
The resource/csdk/README.txt file still has a reference to oic-utilties,
as do some of the old release notes files. The csdk README can probably
be deleted when makefiles are eliminated.
Change-Id: Ic5824264835359a59cfd79443ce4e773205eeb07
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/420
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
(cherry picked from commit
18d902402335fb1394b2c8c57640255a5f707917)
Reviewed-on: https://gerrit.iotivity.org/gerrit/424
Jon A. Cruz [Thu, 5 Mar 2015 06:15:11 +0000 (22:15 -0800)]
Updated Doxygen config.
Removed deprecated items. Enabled Javadoc style auto-brief. Fixed tab settings.
Change-Id: Ia002ccdc9ce86de6c36c8aeb5fd3b6d7c70f5864
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/440
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sashi Penta [Fri, 20 Feb 2015 09:29:06 +0000 (01:29 -0800)]
Remove unused HandleStackResponses function
Change-Id: I31e854345ee7d25308a37bbebde3e1eb19dc8f47
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sashi Penta [Tue, 24 Feb 2015 06:09:08 +0000 (22:09 -0800)]
Fix Presence notification issues.
* Handle duplicate stop notification on the client side.
* Once StopPresence is called on the server, no more notifications are sent. Fixes IOT-66.
* Correct implementation for sending the presence notification when unbinding.
Change-Id: I112a1ef2cb5c04d847c0c83f5309d67acdc4c1fb
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/402
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Sachin Agrawal [Thu, 5 Mar 2015 16:44:30 +0000 (08:44 -0800)]
Added workaround to enable security in CA branch
Currently there is a disconnect in the data structure used between RI
layer and CA layer to convey DTLS PSK credentials. We cannot update this
data structure in CA layer until all reviews of CA layer is completed.
This inhibits security testing of CA branch. Adding this workaround until
an update happens in CA layer to use common data structure.
Change-Id: Ieb17043c6ab3a32961133c5e009f5c06d968979f
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Younghyun Joo [Mon, 2 Mar 2015 10:10:29 +0000 (19:10 +0900)]
[PPM] Modify Protocol Plugin Manager for Android platform
1. Modify FelixAdapter for android support
2. Modify PluginManagerImpl to use FelixAdapter
Change-Id: I14481ddd75913e3eeddef00febd1e8f1c2476aef
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/423
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: yunhee.hwang <yunhee.hwang@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Sakthivel Samidurai [Mon, 2 Mar 2015 23:07:44 +0000 (15:07 -0800)]
Run Unit test after building the stack
Build using scons with TEST=1 command line option to run both
iotivity core C and C++ unittests. Output the unittest
result file in ./out/linux/x86_64/debug/ for debug build.
Output the unittest result file in ./out/linux/x86_64/release
for release build.
Change-Id: I871d3c84a32263f2861fe2896bc3f34ab25b9474
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/430
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sachin Agrawal [Thu, 26 Feb 2015 17:28:56 +0000 (09:28 -0800)]
Updated tinyDTLS test apps to use identity hint
dtls-server test is updated to pass 'psk hint' to tinyDTLS library so that
it can send ServerKeyExchange packet. Similarly, dtls-client test
is updated to retrieve PSK specific for the server whose identity was
received via 'psk hint' packet.
Change-Id: Ifba720f1505ed6afbf56dfc179d98790176ce0b0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/348
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Caiwen Zhang [Tue, 10 Feb 2015 09:10:27 +0000 (17:10 +0800)]
Check if C/C++ compiler is installed
If C/C++ compiler isn't installed, notify user to install it.
Change-Id: I58ad124139a2b454dcd8100b14d5ed23a8065144
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/322
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
William Dieter [Fri, 27 Feb 2015 15:11:38 +0000 (15:11 +0000)]
Removed unneeded references to oic-utilities
The oic-utilities repo was used as a temporary solution for holding third
party libraries. The build system now has a better way to handle them.
This commit removes obsolete instructions to copy the oic-utilities repo
from the scons build instructions.
The resource/csdk/README.txt file still has a reference to oic-utilties,
as do some of the old release notes files. The csdk README can probably
be deleted when makefiles are eliminated.
Change-Id: Ic5824264835359a59cfd79443ce4e773205eeb07
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/420
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Sachin Agrawal [Fri, 27 Feb 2015 19:49:26 +0000 (11:49 -0800)]
Fixing Klocwork reported error in secure sample apps
Recently OCDoResource API was updated to take a NULL handle.
Updated sample apps to pass a NULL handle. This will stop
Klocwork on generating false positives.
Change-Id: I35f81cdde155a4118578ea86a35a981038c22f2e
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/421
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Ossama Othman [Mon, 23 Feb 2015 18:45:26 +0000 (10:45 -0800)]
Do not explicitly add "-fPIC" to the compiler command line.
There is no need to explicitly add "-fPIC" to the compiler command
line since the SCons SharedLibary builder will automatically add it.
This change also addresses a problem where position independent code
was unnecessarily and incorrectly generated for static libraries.
IoTivity resource related static libraries are now smaller and code is
more efficient as result of removing "-fPIC" from static library
generation since the indirection that accompanies position independent
code no longer exists (for those static libraries).
Change-Id: I6cf57713d97b62f873ded4f4728fbb5e77e28ca6
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/399
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Ossama Othman [Mon, 23 Feb 2015 18:34:20 +0000 (10:34 -0800)]
Reorder library link order for mqttclient to address link error.
An unresolved symbol error for pthread_create() occurred during the
Linux mqttclient sample app link phase. Move the pthread library to
end of the linker command line so that the missing symbol can be
resolved for libraries that depend on it.
Generally, libraries that depend on specific libraries should appear
earlier in the linker command line. For example, if libfoo depends on
libpthread, the library command line should look something like:
g++ bar.c -lfoo -lpthread
This doesn't matter as much for dynamically linked libraries since the
inter-library dependency is embedded into the shared library itself,
but order does matter when statically linking.
Change-Id: I6ac40dde39930501458e16624052ab934503e27f
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/398
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Shilpa Sodani [Thu, 26 Feb 2015 22:17:20 +0000 (14:17 -0800)]
Fix CA invalid free memory bug
Fixed the if-statement for freeing header options
Change-Id: I13e809b805cb94495aa7487dfb6ed1ca4bd53396
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Sakthivel Samidurai [Thu, 26 Feb 2015 19:14:32 +0000 (11:14 -0800)]
Fix scons build issue
The scons fails due to 'stacktest_env' is not defined.
Replace stacktest_env with unittests_env.
Change-Id: I9ec68a05f7c576be3686fe12f93077cd6c7ac7ca
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/412
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Minji Park [Fri, 27 Feb 2015 05:58:00 +0000 (14:58 +0900)]
[SSM] Fix IOT-332, 333, 334 issues
Modify SSM java Interface and Android sample app
1. Fix IOT 332, unregister queries continuously
2. Fix IOT 333, handling exception when registering an empty query
3. Fix IOT 334, handling exception when registering invalid queries
Change-Id: Ie4bb94c19634c18f6484313de16a49c1ac5f46d1
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/418
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jk13 [Fri, 27 Feb 2015 01:21:38 +0000 (10:21 +0900)]
[SSM] Fix IOT-322, 323 issues
1. Fix IOT 322, duplicated callback if query contains
multiple 'and' operation to one resource
2. Fix IOT 323, init-term exceptional case
Change-Id: If78af1060c905c52c36aa6cdbf01af1f8a11db73
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/416
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Younghyun Joo [Mon, 23 Feb 2015 09:38:23 +0000 (18:38 +0900)]
[PPM] Set the Iotivity Code Format
1. Excute the format script
Change-Id: I2aa09fcec6a4641dea44fbffbd6692e0deadf86a
Signed-off-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/397
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: yunhee.hwang <yunhee.hwang@samsung.com>
Erich Keane [Mon, 23 Feb 2015 22:40:13 +0000 (14:40 -0800)]
Changed OCDOResource's handle param to take NULL
Most calls to OCDoResource were ignoring the handle parameter's
out value, so this call formalizes that a NULL is an acceptable value
for this parameter. The callers that were using this (as highlighted
by Static Code Analaysis) without using the handle parameter were all
switched to use this new NULL functionality.
Change-Id: I9fc047c080499d1283ffc2cba32addd0f5689c77
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/400
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
projects / platform / upstream / iotivity.git / log