Daniel Juyung Seo [Fri, 15 Nov 2013 09:35:07 +0000 (18:35 +0900)]
test_index.c: internal refactoring of test code.
1. Set internal function as static.
2. Put prefix '_' for internal functions.
3. Moved window resize/show code.
Chris Michael [Fri, 15 Nov 2013 10:14:08 +0000 (10:14 +0000)]
Make routines to get the wayland window from an ecore_evas be more
inline with their X counterparts. Also, remove some EINA_UNUSED where
parameters were being used.
The previous code to get the Ecore_Wl_Window from an Ecore_Evas did
not check to make sure the Ecore_Evas Engine was a wayland engine, and
thus elm_tests like Window Inline would spew CRIT & ERR messages from
ecore_evas about the interface.
This fixes Phab Ticket T502
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 15 Nov 2013 08:47:54 +0000 (08:47 +0000)]
Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Thu, 14 Nov 2013 13:51:03 +0000 (22:51 +0900)]
elementary/entry - internal change of the magnifier.
use the fill_set instead of the clipper.
soon after 1.8, proxy just created the filled area buffer, then magnifier surface size will be fixed regardless of the entry source.
Chris Michael [Thu, 14 Nov 2013 09:30:14 +0000 (09:30 +0000)]
Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 14 Nov 2013 09:26:04 +0000 (09:26 +0000)]
Stop fetching the same Evas and Clip object 4 times
We can just fetch this information once as it is not going to change
during the for loop.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Sebastian Dransfeld [Thu, 14 Nov 2013 04:15:43 +0000 (05:15 +0100)]
quicklaunch: Add AC_LANG_SOURCE to source code
Fixes warning:
configure.ac:217: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
m4/elm_quicklaunch.m4:9: ELM_QUICKLAUNCH is expanded from...
configure.ac:217: the top level
Jean-Philippe Andre [Tue, 5 Nov 2013 09:17:58 +0000 (18:17 +0900)]
Quicklaunch: don't increment init count twice
Ooops, don't increment elm_init count from quicklaunch init
when running normally.
Ryuan Choi [Wed, 13 Nov 2013 18:47:31 +0000 (03:47 +0900)]
elm_web : Moved elm_widget_sub_object_parent_add() call from ewk_view's smart_add to elm_web's
Because ewk_view is smart class and it's parent is Evas, it prints below warning.
... Can't execute function Elm_Widget:ELM_WIDGET_SUB_ID_SUB_OBJECT_ADD (op 0x9f)
for class 'Evas'. Aborting.
Amitesh Singh [Wed, 13 Nov 2013 11:32:31 +0000 (20:32 +0900)]
[hoversel] - Added focus support on hoversel items.
Summary: Focus support on hoversel items.
Test Plan: elementary_test->hoversel2
Reviewers: seoz, raster, Hermet
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D316
Daniel Juyung Seo [Wed, 13 Nov 2013 08:03:49 +0000 (17:03 +0900)]
test_genlist.c: added "genlist del" example to reveal more genlist issues.
This example tests the following cases on item selection.
1. genlist item deletion
2. genlist clear and item append
3. genlist del
ChunEon Park [Wed, 13 Nov 2013 05:51:55 +0000 (14:51 +0900)]
elementary/entry - use a convenient api.
And actually magnifier needs to update fill area if it is resized.
ChunEon Park [Wed, 13 Nov 2013 05:36:22 +0000 (14:36 +0900)]
Revert "elementary/entry - clean up the magnifier code."
This reverts commit
46b007a7c9d0028aeab43587bc773724c06d0ec8.
sorry, this is wrong fix. clip should be removed explicitly.
ChunEon Park [Wed, 13 Nov 2013 05:25:21 +0000 (14:25 +0900)]
elementary/entry - clean up the magnifier code.
ChunEon Park [Wed, 13 Nov 2013 04:29:28 +0000 (13:29 +0900)]
elementary/entry - clean up the magnifier code.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:53:43 +0000 (10:53 +0900)]
test_button.c: added dynamic label change example to button.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:29:30 +0000 (10:29 +0900)]
ctxpopup, player, slideshow, spinner, toolbar, video: internal refactoring of smart event routines.
Now most of smart events codes look consistent.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:19:47 +0000 (10:19 +0900)]
test_toolbar.c: fixed wrong image name.
Give a warm spank to jeyzu :)
Daniel Juyung Seo [Wed, 13 Nov 2013 01:16:33 +0000 (10:16 +0900)]
test_toolbar.c: gave more meaningful name 'Toolbar Vartical' to toolbar test 6.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:54:37 +0000 (09:54 +0900)]
button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:34:58 +0000 (09:34 +0900)]
test_hoversel.c: print out hoversel item's text when it's selected.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:32:20 +0000 (09:32 +0900)]
test_hoversel.c: removed unnecessary weight/align set.
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:56:45 +0000 (17:56 -0200)]
remove unused var.
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:17:13 +0000 (17:17 -0200)]
delete window and children when button is gone
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:03:49 +0000 (17:03 -0200)]
fix doc typo and breakage due widget_type case changes.
elm_widget_type_get() is not lowercase anymoe, rather "Elm_Win". As
other parts of the elementary source were using evas_object_type_get()
use it, and it still returns the legacy lowercase name.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:26:48 +0000 (03:26 +0900)]
configure.ac: say 'no' not 'none' when webkit is not detected during autogen.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:59 +0000 (03:24 +0900)]
elm_dayselector.c: fixed wrong widget style name set on smart add.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:26 +0000 (03:24 +0900)]
elm_dayselector.c: fixed wrong widget name check.
This fixes T481.
https://phab.enlightenment.org/T481
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:03 +0000 (03:24 +0900)]
elm_dayselector.c: fixed formatting before working on it.
Carsten Haitzler (Rasterman) [Tue, 12 Nov 2013 14:13:41 +0000 (23:13 +0900)]
deps removal - fix pc file to match
Yakov Goldberg [Tue, 12 Nov 2013 13:54:58 +0000 (15:54 +0200)]
elm_app_client: fix eo define for not yet implemented func
Yakov Goldberg [Tue, 12 Nov 2013 13:50:17 +0000 (15:50 +0200)]
dayselector/gesture_layer/layout: typo doxygen
Carsten Haitzler (Rasterman) [Tue, 12 Nov 2013 13:56:05 +0000 (22:56 +0900)]
option build deps that efl guarantees... now just are assumed and not ifdef'd
Ryuan Choi [Mon, 11 Nov 2013 15:26:26 +0000 (00:26 +0900)]
elm_web: Fixed compilation warning
maxerba [Sun, 10 Nov 2013 16:50:43 +0000 (17:50 +0100)]
Small correction
maxerba [Sun, 10 Nov 2013 12:40:45 +0000 (13:40 +0100)]
updating portuguese and italian translations
Carsten Haitzler (Rasterman) [Sat, 9 Nov 2013 06:21:22 +0000 (15:21 +0900)]
Revert "remove ifdef from glsl in glview shader - ifdefs not universally supported"
This reverts commit
54883cb7fb0c42f37615f1485e554d947b42c369.
Daniel Juyung Seo [Fri, 8 Nov 2013 12:52:37 +0000 (21:52 +0900)]
elm_index.c: Removed unused local variables.
Daniel Juyung Seo [Fri, 8 Nov 2013 12:49:52 +0000 (21:49 +0900)]
button,inwin,radio,scroller,slider: Do not call smart_activate when the widget is disabled.
Jaehwan Kim [Fri, 8 Nov 2013 12:46:58 +0000 (21:46 +0900)]
elm_check.c: Do not execute smart_activate when the widget is disabled.
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 09:12:55 +0000 (18:12 +0900)]
fix warning
Jaeun Choi [Fri, 8 Nov 2013 09:11:06 +0000 (18:11 +0900)]
bug fix: clear index omit info for omit disabled case as well
Summary:
In the original code, omit related information was cleared and recalculated
only when omit function was enabled. So dynamic omit mode change didn't work in elementary_test.
The information should be cleared everytime the index box is filled. fixed it.
Test Plan: None
Reviewers: seoz, Hermet, raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D262
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:35:53 +0000 (17:35 +0900)]
warning--
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:34:59 +0000 (17:34 +0900)]
warning--
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:18:28 +0000 (17:18 +0900)]
fix formatting, typose and downed naming
Thiep Ha [Fri, 8 Nov 2013 08:06:08 +0000 (17:06 +0900)]
Move selection handler from edje to elm
Reviewers: cedric, raster, seoz, Hermet, tasn
CC: raster
Differential Revision: https://phab.enlightenment.org/D311
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 07:56:24 +0000 (16:56 +0900)]
fix cursor to stay shown when cursor moves due to manual placement or typing
related to https://phab.enlightenment.org/D204 which doesn't apply or
has the emit in the wrong place. this now has it done right.
Thiep Ha [Fri, 8 Nov 2013 07:08:47 +0000 (16:08 +0900)]
elm_entry: fix magnifier not showing up.
The swallow part was properly renamed and namespaced, so reflect that
in the code. Also force a edje object recalc before moving the magnifier.
Reviewers: raster, cedric, Hermet, tasn
Reviewed By: cedric
CC: seoz
Differential Revision: https://phab.enlightenment.org/D286
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 06:42:31 +0000 (15:42 +0900)]
colorsel - dont free up palette CONFIG except when clearing palette.
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 06:33:13 +0000 (15:33 +0900)]
config - standard can't use default-desktop as it doesn't exist as a theme
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 02:54:09 +0000 (11:54 +0900)]
external symbols need to be EAPI marked even in headers.
Daniel Juyung Seo [Fri, 8 Nov 2013 02:30:50 +0000 (11:30 +0900)]
elm_dbus_menu.c: Removed unused pointer value assignment.
This fixes coverity CID 1039975.
Daniel Juyung Seo [Fri, 8 Nov 2013 02:22:01 +0000 (11:22 +0900)]
elm_prefs_data.c: Check return value of eina_value_get().
This fixes coverity CID 1040042.
Daniel Juyung Seo [Fri, 8 Nov 2013 01:27:44 +0000 (10:27 +0900)]
elm_config.c: Check null for profile. I can be null.
This fixes coverity CID 1040032.
Tom Hacohen [Thu, 7 Nov 2013 14:29:38 +0000 (14:29 +0000)]
Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra
Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
Chris Michael [Thu, 7 Nov 2013 14:26:57 +0000 (14:26 +0000)]
Fix selection type when trying to get a selection. Also fix pasting
from terminology into other elm apps (selection format issue).
Wayland has no concept of primary or secondary clipboards so we need
to test for selection == those due to some X apps.
*cough*terminology*cough* using only Primary or Secondary.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 7 Nov 2013 12:01:00 +0000 (12:01 +0000)]
Fix elm_entry to work with copy/paste (mouse and keyboard) under
wayland.
This also unifies some of the code between X & wayland wrt copy/paste.
This is part of a larger copy/paste fix for efl/elm wayland.
Previously, copy/paste would not work via keyboard shortcuts. This
series of changes fixes that issue (wrt elm_entry anyway).
This also adds addtional copy/paste support (wrt efl wayland),
including support for various mime types (text/plain, elm-markup, and html).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 7 Nov 2013 11:57:14 +0000 (11:57 +0000)]
Fix elementary copy/paste for wayland. Rework copy/paste code in elm.
This is part of a larger copy/paste fix for efl/elm wayland.
Previously, copy/paste would not work via keyboard shortcuts. This
series of changes fixes that issue (wrt elm_entry anyway).
This also adds addtional copy/paste support (wrt efl wayland),
including support for various mime types (text/plain, elm-markup, and
html).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Thu, 7 Nov 2013 13:34:57 +0000 (22:34 +0900)]
elementary/scroller - don't focus region show if the scroller is disabled.
ChunEon Park [Thu, 7 Nov 2013 13:33:25 +0000 (22:33 +0900)]
elementary - fixed changelog typo
Tom Hacohen [Thu, 7 Nov 2013 11:44:22 +0000 (11:44 +0000)]
Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
Doug Newgard [Thu, 7 Nov 2013 11:05:01 +0000 (20:05 +0900)]
Minor PKGBUILD cleanup
Summary:
Add PKGBUILD to make dist so it will be in the snapshots
Change dep to current efl package since efl_x11 isn't there anymore
Check for Makefile before running make clean distclean otherwise build fails
Set correct arch on elementary_doc
Install docs to /usr/share/doc
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D282
Carsten Haitzler (Rasterman) [Thu, 7 Nov 2013 08:25:53 +0000 (17:25 +0900)]
reandme == 1.8.0
Daniel Juyung Seo [Wed, 6 Nov 2013 16:24:12 +0000 (01:24 +0900)]
test_genlist.c: Fixed wrong item class name.
This fixes coverity CID 1126089.
Daniel Juyung Seo [Wed, 6 Nov 2013 15:00:38 +0000 (00:00 +0900)]
test_progressbar.c: Fixed wrong null set of timer.
If pd is null, pd->timer will crash and cannot set it to null.
This fixes coverity CID 1126081.
Daniel Juyung Seo [Wed, 6 Nov 2013 14:59:45 +0000 (23:59 +0900)]
test_progressbar.c: Fixed formatting before working on it.
Ryuan Choi [Wed, 6 Nov 2013 10:26:57 +0000 (19:26 +0900)]
fileselector: Remove invalid or unnecessary comment
Daniel Juyung Seo [Wed, 6 Nov 2013 04:36:34 +0000 (13:36 +0900)]
elm_list.c: fixed a bug when any item is selected without control on multi select with control mode.
When any item is selected without control on multi select with control mode, already selected items should be unselected automatically.
Daniel Juyung Seo [Wed, 6 Nov 2013 04:11:41 +0000 (13:11 +0900)]
test_list.c: Fixed list multi select internal structure name.
Daniel Juyung Seo [Wed, 6 Nov 2013 04:11:23 +0000 (13:11 +0900)]
test_genlist.c: Added genlist multi select example.
Daniel Juyung Seo [Tue, 5 Nov 2013 19:38:55 +0000 (04:38 +0900)]
fileselector.edc: Fixed button part size calculationg issue.
Do not fix the height of button swallow part so that it can be expanded.
This fixes T238.
Daniel Juyung Seo [Tue, 5 Nov 2013 18:32:50 +0000 (03:32 +0900)]
test.c: Splitted elementary_test List categories into List, Genlist, and Gengrid.
This is because there are too many list examples and it was quite hard to find a proper test.
Daniel Juyung Seo [Tue, 5 Nov 2013 18:23:41 +0000 (03:23 +0900)]
test_list.c: Splitted list multi select example.
Daniel Juyung Seo [Tue, 5 Nov 2013 18:09:54 +0000 (03:09 +0900)]
test_list.c: fix list focus example to enable the focus highlight and animation for the proper window.
Daniel Zaoui [Tue, 5 Nov 2013 15:26:51 +0000 (17:26 +0200)]
DnD: Fix compilation errors by adapting the multi-callbacks to Wayland.
Chris Michael [Tue, 5 Nov 2013 09:50:17 +0000 (09:50 +0000)]
Remove whitespace
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Carsten Haitzler (Rasterman) [Tue, 5 Nov 2013 09:12:57 +0000 (18:12 +0900)]
update po's
Daniel Zaoui [Mon, 4 Nov 2013 13:08:53 +0000 (15:08 +0200)]
DnD: multi-callbacks support
This features permits execution of more than one set of functions during
DnD.
Delete function API has been modified to give the developer the
possibility to remove a specific set of functions.
Daniel Zaoui [Sun, 27 Oct 2013 09:27:17 +0000 (11:27 +0200)]
DnD: Code improvement + variables renaming
Little code improvement
Rename cbdata with dropdata
Daniel Juyung Seo [Tue, 5 Nov 2013 05:18:47 +0000 (14:18 +0900)]
test_list.c: Added elm_list_multi_select_mode_set() example.
Daniel Juyung Seo [Tue, 5 Nov 2013 05:17:15 +0000 (14:17 +0900)]
elm_list.c: Added a real support for ELM_OBJECT_MULTI_SELECT_MODE_WITH_CONTROL for list.
This was missed in
a8efd7676eb95378355f4d603ddff938279703af.
Daniel Juyung Seo [Tue, 5 Nov 2013 05:11:40 +0000 (14:11 +0900)]
elm_list.c: Split _item_unselect() into _item_unhighlight() and _item_unselect().
Daniel Juyung Seo [Tue, 5 Nov 2013 02:22:46 +0000 (11:22 +0900)]
test_list.c: Internal refactoring.
1. Use EINA_FALSE instead of 0
2. Set the parent widget correctly.
3. Remove unused multi_select_set.
4. Give a meaningful label to the first list item.
5. Call item_selected_set to the second item.
6. Remove unnecessary box.
Daniel Juyung Seo [Tue, 5 Nov 2013 00:29:44 +0000 (09:29 +0900)]
test_popup.c: Removed unused array.
Jean-Philippe Andre [Mon, 4 Nov 2013 08:54:31 +0000 (17:54 +0900)]
elementary_test: remove ELM_LIB_QUICKLAUNCH
Refer to the previous commits for the reason.
Remove all #ifndef ELM_LIB_QUICKLAUNCH from the test files.
Daniel Juyung Seo [Tue, 5 Nov 2013 00:22:25 +0000 (09:22 +0900)]
elm_list: Added missing elm_list_multi_select_mode_set/get API for list to fix the API consistency between multi selectable widgets.
This was omitted by genlist/gengrid multi select mode set/get() commit
ae03d3cef36abd27ff530e350e39ae401f4f389e.
Daniel Juyung Seo [Mon, 4 Nov 2013 15:17:23 +0000 (00:17 +0900)]
ChangeLog/NEWS: removed unnecessary entries from ChangeLog and NEWS.
Genlist/Gengrid multi select mode was changed in another way.
Refer
ae03d3cef36abd27ff530e350e39ae401f4f389e.
Daniel Juyung Seo [Mon, 4 Nov 2013 05:57:42 +0000 (14:57 +0900)]
elm_slider.c, elm_image.c: Removed executable permission from c source.
Please be more careful of file permission.
ChunEon Park [Mon, 4 Nov 2013 13:19:09 +0000 (22:19 +0900)]
elementary - removed unintended conflicted lines
that was introduced by
a61bbe7dcf0c6936e3104b35d56a7ed330da4176
ChunEon Park [Mon, 4 Nov 2013 13:17:03 +0000 (22:17 +0900)]
Revert "popup: Added support for popup move. elm_popup_move."
This reverts commit
f67ecb2028dd663aa4b0d9fe78b2a392ac169e7e.
Conflicts:
ChangeLog
NEWS
src/bin/test_popup.c
Sorry, Pend this to 1.8 after.
Let's think about adding this API more carefully.
Seunggyun Kim [Mon, 4 Nov 2013 12:18:15 +0000 (21:18 +0900)]
fix elm_config_glayer_*_set/get header comment and changelog
Summary: fix elm_config_glayer_*_set/get header comment
Reviewers: seoz, jaehwan, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D151
Conflicts:
ChangeLog
Ryuan Choi [Mon, 4 Nov 2013 12:14:45 +0000 (21:14 +0900)]
elm_widget.c: Fixed warning while scrolling elementary_test using arrow
Summary: Checked whether object which direction pointed is NULL before getting it's data
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D95
Ryuan Choi [Mon, 4 Nov 2013 12:01:06 +0000 (21:01 +0900)]
POTFILES.in : Added missing files in src/lib
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D76
Cedric Bail [Mon, 4 Nov 2013 11:14:47 +0000 (20:14 +0900)]
elementary: automatically detect if compiler can build quicklaunch binary.
Ryuan Choi [Mon, 4 Nov 2013 09:45:38 +0000 (18:45 +0900)]
gengrid: Fixed documentation typo.
Carsten Haitzler (Rasterman) [Mon, 4 Nov 2013 09:32:44 +0000 (18:32 +0900)]
alpha1 release autofoo/build tree work to pass distcheck and actually work
Jean-Philippe Andre [Mon, 4 Nov 2013 08:19:43 +0000 (17:19 +0900)]
Quicklaunch: Remove extra build code for elm_test
Now that we know we can just compile PIE programs and run them with
quicklaunch, let's simplify the build logic.
I'm pretty sure it even gives a nice boost in the build process :)
Jean-Philippe Andre [Mon, 4 Nov 2013 06:12:51 +0000 (15:12 +0900)]
elm/quicklaunch: Improve executable path search
Always search executable based on CWD if possible.
This way, elementary_run behaves more like sh where all of
sh script, sh ./script and sh `pwd`/script will work.
Also, remove quicklaunch-specific ELM_MAIN.
This needs some doc, but compiling with -fpie and -pie is much
better.
Note: There's an API/ABI break here, BUT these APIs are marked
as not to be used outside macros. And there isn't any macro
using them :)
Jean-Philippe Andre [Mon, 4 Nov 2013 03:21:49 +0000 (12:21 +0900)]
elm/quicklaunch: Increment _elm_init_count in ql_init
Apps call elm_shutdown before exiting. But when using
Quiklaunch, elm_init has never been called, so the
init count is still 0.
This will be especially useful since programs compiled
with -fPIC and linked with -pie can be loaded by
Quicklaunch.
ChunEon Park [Mon, 4 Nov 2013 05:51:06 +0000 (14:51 +0900)]
Revert "elm_conform.c: Added "virtualkeypad,size,changed" smart callback."
This reverts commit
cbd7446f0bf413ad821ac40703d2a2ca728758ef.
Conflicts:
ChangeLog
NEWS
Please be more considerable to add this feature.
The function itself is not logical and we don't think it's proper for the conformant yet.