platform/upstream/libSkiaSharp.git
8 years agoDelete 2 legacy flags
fmalita [Mon, 25 Jan 2016 14:29:44 +0000 (06:29 -0800)]
Delete 2 legacy flags

No longer used in Chrome/Android:

  SK_SUPPORT_LEGACY_ANISOTROPIC_MIPMAPS
  SK_SUPPORT_LEGACY_PRESCALE_SEMANTICS

R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1632633002

Review URL: https://codereview.chromium.org/1632633002

8 years agoSK_SUPPORT_LEGACY_DRAWFLTER typo
fmalita [Mon, 25 Jan 2016 14:23:54 +0000 (06:23 -0800)]
SK_SUPPORT_LEGACY_DRAWFLTER typo

s/FLTER/FILTER/

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1634573002

Review URL: https://codereview.chromium.org/1634573002

8 years agoAvoid updating glPathStencilFunc unless it changes
kkinnunen [Mon, 25 Jan 2016 14:07:26 +0000 (06:07 -0800)]
Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619623005

Review URL: https://codereview.chromium.org/1619623005

8 years agoRevert of Prototype of RAW decoding in Skia. (patchset #32 id:610001 of https://coder...
msarett [Mon, 25 Jan 2016 14:05:19 +0000 (06:05 -0800)]
Revert of Prototype of RAW decoding in Skia. (patchset #32 id:610001 of https://codereview.chromium.org/1520403003/ )

Reason for revert:
A few build failures on Chrome OS/Android.

Original issue's description:
> Add RAW decoding into Skia.
>
> TBR=reed@google.com
>
> BUG=skia:
>
> (Based on the work from ebrauer in https://codereview.chromium.org/1459473007)
> (Based on the work from adaubert in https://codereview.chromium.org/1494003003)
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1520403003
>
> Committed: https://skia.googlesource.com/skia/+/6bd8639f8c142eedf543f4e5f3b02d2bf11df308

TBR=scroggo@google.com,adaubert@google.com,yujieqin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1635443002

8 years agofix arcto exception handling
caryclark [Mon, 25 Jan 2016 13:39:04 +0000 (05:39 -0800)]
fix arcto exception handling

To match SVG behavior,
draw a line when either radius is zero,
or when the end point equals the start point.

Update the GM to include these tests, and
take the scale used to test it on a highres display.

R=fmalita@chromium.org
BUG=skia:4849
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1627423002

Review URL: https://codereview.chromium.org/1627423002

8 years agoAdd RAW decoding into Skia.
yujieqin [Mon, 25 Jan 2016 13:29:03 +0000 (05:29 -0800)]
Add RAW decoding into Skia.

TBR=reed@google.com

BUG=skia:

(Based on the work from ebrauer in https://codereview.chromium.org/1459473007)
(Based on the work from adaubert in https://codereview.chromium.org/1494003003)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1520403003

Review URL: https://codereview.chromium.org/1520403003

8 years agoWhitespace change to test SK_IMAGE_VERSION download
borenet [Mon, 25 Jan 2016 13:00:13 +0000 (05:00 -0800)]
Whitespace change to test SK_IMAGE_VERSION download

TBR=scroggo
BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633453003

Review URL: https://codereview.chromium.org/1633453003

8 years agoEnable GL_CHROMIUM_bind_uniform_location, command buffer is fixed
kkinnunen [Mon, 25 Jan 2016 09:44:03 +0000 (01:44 -0800)]
Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed

Enable GL_CHROMIUM_bind_uniform_location, command buffer implementation
is fixed now.

BUG=skia:4454
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613763003

Review URL: https://codereview.chromium.org/1613763003

8 years agoDo not try to get fragment input locations with CHROMIUM_path_rendering
kkinnunen [Mon, 25 Jan 2016 08:47:23 +0000 (00:47 -0800)]
Do not try to get fragment input locations with CHROMIUM_path_rendering

Do not try to get fragment input locations with CHROMIUM_path_rendering,
it uses the binding mechanism in CHROMIUM_path_rendering

BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618773002

Review URL: https://codereview.chromium.org/1618773002

8 years agoMake BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples
kkinnunen [Mon, 25 Jan 2016 08:31:49 +0000 (00:31 -0800)]
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples

Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples.

BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615833002

Review URL: https://codereview.chromium.org/1615833002

8 years agoRevert of skstd -> std for unique_ptr (patchset #24 id:460001 of https://codereview...
mtklein [Mon, 25 Jan 2016 03:49:24 +0000 (19:49 -0800)]
Revert of skstd -> std for unique_ptr (patchset #24 id:460001 of https://codereview.chromium.org/1436033003/ )

Reason for revert:
Still need an answer for SkAdvancedTypefaceMetrics (at least for Google3 iOS build).

Original issue's description:
> skstd -> std for unique_ptr
>
> TBR=reed@google.com
> No public API changes.
>
> BUG=skia:4564
>
> Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
>
> Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
>
> Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1436033003
>
> Committed: https://skia.googlesource.com/skia/+/ccf1de0d9aa75f29829f1c4c462214b991fd8c9e

TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4564

Review URL: https://codereview.chromium.org/1626873004

8 years agoskstd -> std for unique_ptr
mtklein [Mon, 25 Jan 2016 03:18:54 +0000 (19:18 -0800)]
skstd -> std for unique_ptr

TBR=reed@google.com
No public API changes.

BUG=skia:4564

Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50

CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot

Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065

Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c

Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1436033003

Review URL: https://codereview.chromium.org/1436033003

8 years agoadd 4f support to colorfiltershader
reed [Sun, 24 Jan 2016 19:15:14 +0000 (11:15 -0800)]
add 4f support to colorfiltershader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1625263002

TBR=

Review URL: https://codereview.chromium.org/1625263002

8 years agoRevert[2] of expand unitests for color4f
reed [Sun, 24 Jan 2016 03:37:56 +0000 (19:37 -0800)]
Revert[2] of expand unitests for color4f

This reverts commit 5f34e8ed82e6cbf29401bda5d423a50a2ab6db74.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622983002

TBR=

Review URL: https://codereview.chromium.org/1622983002

8 years agoRevert of expand unitests for color4f (patchset #1 id:1 of https://codereview.chromiu...
reed [Sat, 23 Jan 2016 22:19:06 +0000 (14:19 -0800)]
Revert of expand unitests for color4f (patchset #1 id:1 of https://codereview.chromium.org/1622893002/ )

Reason for revert:
leaking shadercontext in test

Original issue's description:
> expand unitests for color4f
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622893002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/fac684502b6047ffc7dc2e59bd7e5a7cbfa5bf78

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1622923002

8 years agoDon't dirty MIP chain when damage bounds is empty
bsalomon [Sat, 23 Jan 2016 18:41:40 +0000 (10:41 -0800)]
Don't dirty MIP chain when damage bounds is empty
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618383002

Review URL: https://codereview.chromium.org/1618383002

8 years agoexpand unitests for color4f
reed [Sat, 23 Jan 2016 18:15:39 +0000 (10:15 -0800)]
expand unitests for color4f

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622893002

TBR=

Review URL: https://codereview.chromium.org/1622893002

8 years agoAdd svg path arcto
caryclark [Sat, 23 Jan 2016 13:07:04 +0000 (05:07 -0800)]
Add svg path arcto

The arcto() used by SVG in Chrome and Android is ported here, using conics
instead of cubics. The logic is a direct transposition of the WebKit code.

The attached GM includes SVG that draws the same as Skia.

R=reed@google.com
BUG=skia:3959
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613303002

Review URL: https://codereview.chromium.org/1613303002

8 years agoAdd getYUV8Planes() API to SkCodec
msarett [Fri, 22 Jan 2016 22:46:42 +0000 (14:46 -0800)]
Add getYUV8Planes() API to SkCodec

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1549473003

Review URL: https://codereview.chromium.org/1549473003

8 years agoSSSE3 opts for RGB -> RGB(FF) or BGR(FF)
msarett [Fri, 22 Jan 2016 22:12:38 +0000 (14:12 -0800)]
SSSE3 opts for RGB -> RGB(FF) or BGR(FF)

Swizzle Bench Runtime
z620         0.21x
Dell Venue 8 0.26x

RGB PNGs Decode Runtime
z620         0.91x
Dell Venus 8 0.96x

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618603003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1618603003

8 years agoskip zero-length linear gradient intervals to make new code more consistent with...
lsalzman [Fri, 22 Jan 2016 22:03:02 +0000 (14:03 -0800)]
skip zero-length linear gradient intervals to make new code more consistent with older table-based implementation

BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619413002

Review URL: https://codereview.chromium.org/1619413002

8 years agoFactor out xcode c/cpp settings into variables to apply to cmake builds.
bsalomon [Fri, 22 Jan 2016 20:54:57 +0000 (12:54 -0800)]
Factor out xcode c/cpp settings into variables to apply to cmake builds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619243003

Review URL: https://codereview.chromium.org/1619243003

8 years agoChange name from ScaleToSides to SkScaleToSides.
herb [Fri, 22 Jan 2016 19:58:55 +0000 (11:58 -0800)]
Change name from ScaleToSides to SkScaleToSides.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618283004

Review URL: https://codereview.chromium.org/1618283004

8 years agoRevert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium...
mtklein [Fri, 22 Jan 2016 19:51:40 +0000 (11:51 -0800)]
Revert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium.org/1616013003/ )

Reason for revert:
This is somehow blocking the Google3 roll in ways neither Ben nor I understand.  Precautionary revert... will try again Monday.

Original issue's description:
> de-proc sk_float_rsqrt
>
> This is the first of many little baby steps to have us stop runtime-detecting NEON.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d

TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1629503002

8 years agoAnisotropic mipmap fixes
fmalita [Fri, 22 Jan 2016 19:45:39 +0000 (11:45 -0800)]
Anisotropic mipmap fixes

1) when selecting a level scale, use max(scaleX, scaleY) instead of
  current sqrt(scaleX * scaleY)

2) track and apply non-uniform fixup scales

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617183004

Review URL: https://codereview.chromium.org/1617183004

8 years agoFirst rough draft of skiaserve
joshualitt [Fri, 22 Jan 2016 19:21:43 +0000 (11:21 -0800)]
First rough draft of skiaserve

Please excuse the mess while we iterate

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1621753002

Review URL: https://codereview.chromium.org/1621753002

8 years agoUpdate deps to pull microhttpd
joshualitt [Fri, 22 Jan 2016 19:17:46 +0000 (11:17 -0800)]
Update deps to pull microhttpd

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1620813004

Review URL: https://codereview.chromium.org/1620813004

8 years agoadd GM to exercise duplicate color-stops
reed [Fri, 22 Jan 2016 18:35:26 +0000 (10:35 -0800)]
add GM to exercise duplicate color-stops

BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1620423002

TBR=

Review URL: https://codereview.chromium.org/1620423002

8 years agoUse nextafter instead of nexttoward to avoid using long double calculation.
herb [Fri, 22 Jan 2016 18:11:03 +0000 (10:11 -0800)]
Use nextafter instead of nexttoward to avoid using long double calculation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1621453004

Review URL: https://codereview.chromium.org/1621453004

8 years agoUse NEON optimizations for RGB -> RGB(FF) or BGR(FF) in SkSwizzler
msarett [Fri, 22 Jan 2016 17:54:21 +0000 (09:54 -0800)]
Use NEON optimizations for RGB -> RGB(FF) or BGR(FF) in SkSwizzler

Swizzle Bench Runtime Nexus 6P
xxx_xxxa        0.32x
xxx_swaprb_xxxa 0.31x

Swizzle Bench Runtime Nexus 9
xxx_xxxa        1.11x
xxx_swaprb_xxxa 1.14x
(This is a slow down.)

Swizzle Bench Runtime Nexus 5
xxx_xxxa        0.12x
xxx_swaprb      0.12x

RGB PNG Decode Runtime
Nexus 6P        0.94x
Nexus 9         0.98x

I don't know how to explain the fact that the Swizzle Bench was
slower on Nexus 9, but the decode times got faster.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618003002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1618003002

8 years agotry removing attribute((aligned(16))
mtklein [Fri, 22 Jan 2016 17:50:20 +0000 (09:50 -0800)]
try removing attribute((aligned(16))

CQ_EXTRA_TRYBOTS=client.skia:Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618873005

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1618873005

8 years agoRevert of added support for PLS path rendering (patchset #16 id:360001 of https:...
ethannicholas [Fri, 22 Jan 2016 17:45:47 +0000 (09:45 -0800)]
Revert of added support for PLS path rendering (patchset #16 id:360001 of https://codereview.chromium.org/1541903002/ )

Reason for revert:
ASAN failure at src/gpu/GrXferProcessor.cpp:224

Original issue's description:
> added support for PLS path rendering
>
> BUG=skia:3555
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1541903002
>
> Committed: https://skia.googlesource.com/skia/+/7df3f5e127f8016d17b637cc48a6a4718f1a6822

TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626553002

Review URL: https://codereview.chromium.org/1626553002

8 years agoAdd SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter.
benjaminwagner [Fri, 22 Jan 2016 17:45:14 +0000 (09:45 -0800)]
Add SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter.

Fixes Google3 dm build. (Can't enable SK_INTERNAL for Google3 dm without enabling it for all dependents.)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626543002

Review URL: https://codereview.chromium.org/1626543002

8 years agoRevert of whitespace change to test bugdroid (patchset #1 id:1 of https://codereview...
rmistry [Fri, 22 Jan 2016 16:57:41 +0000 (08:57 -0800)]
Revert of whitespace change to test bugdroid (patchset #1 id:1 of https://codereview.chromium.org/1625503002/ )

Reason for revert:
one more test

Original issue's description:
> whitespace change to test bugdroid
>
> NOTRY=true
> TBR=
> BUG=skia:4814
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1625503002
>
> Committed: https://skia.googlesource.com/skia/+/aed5717afddce200b3de88d8dde5252068b131c8

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4814

Review URL: https://codereview.chromium.org/1626533002

8 years agode-proc sk_float_rsqrt
mtklein [Fri, 22 Jan 2016 16:49:26 +0000 (08:49 -0800)]
de-proc sk_float_rsqrt

This is the first of many little baby steps to have us stop runtime-detecting NEON.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1616013003

8 years agowhitespace change to test bugdroid
rmistry [Fri, 22 Jan 2016 16:49:20 +0000 (08:49 -0800)]
whitespace change to test bugdroid

NOTRY=true
TBR=
BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1625503002

Review URL: https://codereview.chromium.org/1625503002

8 years agoFix bounds of checking if a radii are too long for a side.
herb [Fri, 22 Jan 2016 16:34:35 +0000 (08:34 -0800)]
Fix bounds of checking if a radii are too long for a side.

BUG=skia:4692,skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617763003

Review URL: https://codereview.chromium.org/1617763003

8 years agoDM: dump a zero-results .json file right at startup.
mtklein [Fri, 22 Jan 2016 16:18:14 +0000 (08:18 -0800)]
DM: dump a zero-results .json file right at startup.

This way, if DM runs, the file will be there, even if it crashes before the
first time we'd ordinarily write out the file (currently, any time
the number of tasks remaining to do becomes evenly divisible by 500).

BUG=skia:4839
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626493002

Review URL: https://codereview.chromium.org/1626493002

8 years agoAdd ability to query read pixels support without a render target.
bsalomon [Fri, 22 Jan 2016 16:16:09 +0000 (08:16 -0800)]
Add ability to query read pixels support without a render target.

Add more checks to onGetReadPixelsInfo.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615023003

Review URL: https://codereview.chromium.org/1615023003

8 years agoSkBSwap32
mtklein [Fri, 22 Jan 2016 15:54:08 +0000 (07:54 -0800)]
SkBSwap32

Seems handy.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619923002

Review URL: https://codereview.chromium.org/1619923002

8 years agoRefactor swizzle names and types.
mtklein [Fri, 22 Jan 2016 15:42:53 +0000 (07:42 -0800)]
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 (RGB) srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626463002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1626463002

8 years agoMake swizzling in read/write pixel copy code more generic
bsalomon [Fri, 22 Jan 2016 15:17:34 +0000 (07:17 -0800)]
Make swizzling in read/write pixel copy code more generic

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617433002

Review URL: https://codereview.chromium.org/1617433002

8 years agoUpdate libwebp to version 0.5.0
scroggo [Fri, 22 Jan 2016 14:58:27 +0000 (06:58 -0800)]
Update libwebp to version 0.5.0

This is the version used by Android.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601253003

Review URL: https://codereview.chromium.org/1601253003

8 years agoRevert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https...
robertphillips [Fri, 22 Jan 2016 14:53:57 +0000 (06:53 -0800)]
Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/1607253002/ )

Reason for revert:
Overdraw Xfer mode using new fangled glsl features

Original issue's description:
> Add gpu implementation of OverdrawXfermode
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002
>
> Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba

TBR=egdaniel@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review URL: https://codereview.chromium.org/1626443002

8 years agoRevert of Consolidate SK_CRASH and sk_throw into SK_ABORT (patchset #5 id:80001 of...
djsollen [Fri, 22 Jan 2016 14:50:25 +0000 (06:50 -0800)]
Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT (patchset #5 id:80001 of https://codereview.chromium.org/1610823002/ )

Reason for revert:
Chrome is calling SK_CRASH

Original issue's description:
> Consolidate SK_CRASH and sk_throw into SK_ABORT
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610823002
>
> Committed: https://skia.googlesource.com/skia/+/4c5cd7d527ed29aabfa72aa47b23a4496eeda357

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1620333002

8 years agoadded support for PLS path rendering
ethannicholas [Fri, 22 Jan 2016 14:48:46 +0000 (06:48 -0800)]
added support for PLS path rendering

BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1541903002

Review URL: https://codereview.chromium.org/1541903002

8 years agoFix GrAtlasTextBlob bounds management
joshualitt [Fri, 22 Jan 2016 14:08:48 +0000 (06:08 -0800)]
Fix GrAtlasTextBlob bounds management

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605013002

Committed: https://skia.googlesource.com/skia/+/ae473fdfc3db2d9dd82b05b2568767d6d4038fcd

Review URL: https://codereview.chromium.org/1605013002

8 years agoConsolidate SK_CRASH and sk_throw into SK_ABORT
djsollen [Fri, 22 Jan 2016 14:04:55 +0000 (06:04 -0800)]
Consolidate SK_CRASH and sk_throw into SK_ABORT
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610823002

Review URL: https://codereview.chromium.org/1610823002

8 years agoRevert[2] of float color components
reed [Fri, 22 Jan 2016 09:04:29 +0000 (01:04 -0800)]
Revert[2] of float color components

This reverts commit 2a2bdc698460c38ac9e24ba4abdeefec67bcba37.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622483002

TBR=
NOTRY=True
Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot  seems wicked slow

Review URL: https://codereview.chromium.org/1622483002

8 years agoRevert of experiment: float color components (patchset #6 id:100001 of https://codere...
reed [Fri, 22 Jan 2016 08:04:30 +0000 (00:04 -0800)]
Revert of experiment: float color components (patchset #6 id:100001 of https://codereview.chromium.org/1617813002/ )

Reason for revert:
broke some colormatrix tests

Original issue's description:
> experiment: float color components
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617813002
>
> Committed: https://skia.googlesource.com/skia/+/353c148d8e8c9031daca34c6f9d6bcc6f08706c7

TBR=fmalita@chromium.org,mtklein@google.com,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1623453002

8 years agoHide SkCanvas::{set,get}DrawFilter
fmalita [Fri, 22 Jan 2016 02:47:11 +0000 (18:47 -0800)]
Hide SkCanvas::{set,get}DrawFilter

Except for Android, which still makes use of it.

BUG=skia:3587
R=reed@google.com,djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1618843002

Review URL: https://codereview.chromium.org/1618843002

8 years agoexperiment: float color components
reed [Thu, 21 Jan 2016 23:29:10 +0000 (15:29 -0800)]
experiment: float color components

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617813002

Review URL: https://codereview.chromium.org/1617813002

8 years agoAdd setter for GrGLSLShaderVar layout qualifier
egdaniel [Thu, 21 Jan 2016 23:21:48 +0000 (15:21 -0800)]
Add setter for GrGLSLShaderVar layout qualifier

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611423002

Review URL: https://codereview.chromium.org/1611423002

8 years agoFix CMake build on Mac.
Ben Wagner [Thu, 21 Jan 2016 22:38:13 +0000 (17:38 -0500)]
Fix CMake build on Mac.

8 years agoStop testing builds with runtime-detected NEON
mtklein [Thu, 21 Jan 2016 22:24:10 +0000 (14:24 -0800)]
Stop testing builds with runtime-detected NEON

O frabjous day!

Chrome has switched on requiring NEON globally at head.
Android has always built with NEON as appropriate for each device.

In practice, this switches our Nexus 5 bots from runtime-detected to
building with NEON globally.  It also lines a few columns up and makes
equivalent aliases more obviously the same.

We still have Build bots to test we can build on ARMv7 with no NEON.  (We even have Build bots to test building ARMv6.)

(It looks like that buildbot_spec.json just hasn't been updated in a while.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612753002

CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot

Review URL: https://codereview.chromium.org/1612753002

8 years agoExpose API for gx font variation axes.
bungeman [Thu, 21 Jan 2016 22:17:47 +0000 (14:17 -0800)]
Expose API for gx font variation axes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1590223003

Review URL: https://codereview.chromium.org/1590223003

8 years agoSkValue: SkXfermode
halcanary [Thu, 21 Jan 2016 22:15:10 +0000 (14:15 -0800)]
SkValue: SkXfermode

Implement:
  template<> SkValue SkToValue<SkXfermode>(const SkXfermode*);

  template<> bool SkFromValue<SkXfermode*>(const SkValue&, SkXfermode**);

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1585813004

NOTRY=true

Review URL: https://codereview.chromium.org/1585813004

8 years agoAdd ability to add general layout qualifiers GrGLSLShaderVar
egdaniel [Thu, 21 Jan 2016 19:19:52 +0000 (11:19 -0800)]
Add ability to add general layout qualifiers GrGLSLShaderVar

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610853002

Review URL: https://codereview.chromium.org/1610853002

8 years agoUse fActualProc to choose fFastProc or fSlowProc in SkSwizzler
msarett [Thu, 21 Jan 2016 17:59:38 +0000 (09:59 -0800)]
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616753003

Review URL: https://codereview.chromium.org/1616753003

8 years agoFix bounds computations for SkDisplacementMapEffect with negative scale.
senorblanco [Thu, 21 Jan 2016 17:55:47 +0000 (09:55 -0800)]
Fix bounds computations for SkDisplacementMapEffect with negative scale.

BUG=skia:4835
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616663003

Review URL: https://codereview.chromium.org/1616663003

8 years agoDM: dump images for task failures too (but not skipped tasks)
mtklein [Thu, 21 Jan 2016 17:39:35 +0000 (09:39 -0800)]
DM: dump images for task failures too (but not skipped tasks)

This will get us back to uploading things like serialize-8888 mismatches.

BUG=skia:4806
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1614443002

Review URL: https://codereview.chromium.org/1614443002

8 years agoAdd version number to images tested in DM
scroggo [Thu, 21 Jan 2016 17:32:58 +0000 (09:32 -0800)]
Add version number to images tested in DM

BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619493003

Review URL: https://codereview.chromium.org/1619493003

8 years agoDemo fuzz for Herb
mtklein [Thu, 21 Jan 2016 17:25:32 +0000 (09:25 -0800)]
Demo fuzz for Herb

BUG=skia:4692
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611293002

Review URL: https://codereview.chromium.org/1611293002

8 years agoAdd Lua SkXfermode skp scraping support
robertphillips [Thu, 21 Jan 2016 17:05:32 +0000 (09:05 -0800)]
Add Lua SkXfermode skp scraping support

This is to answer the question of do any of our skps have SkLerpXfermodes. AFAICT they should not so this is just to verify.

The only controversial part of this is the addition of 'getLuaName' to SkXfermode

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1614923002

Review URL: https://codereview.chromium.org/1614923002

8 years agoRename SkCodec_libpng to SkPngCodec
msarett [Thu, 21 Jan 2016 17:05:23 +0000 (09:05 -0800)]
Rename SkCodec_libpng to SkPngCodec

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1613043003

Review URL: https://codereview.chromium.org/1613043003

8 years agoImplement onMatchFamilyStyle for Mac.
bungeman [Thu, 21 Jan 2016 16:18:42 +0000 (08:18 -0800)]
Implement onMatchFamilyStyle for Mac.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612653002

Review URL: https://codereview.chromium.org/1612653002

8 years agoresolution dependent path measure
caryclark [Thu, 21 Jan 2016 15:07:02 +0000 (07:07 -0800)]
resolution dependent path measure

When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.

Pass the resolution through to path measure.

Replicate chrome bug in skia GM.

R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1608353002

Review URL: https://codereview.chromium.org/1608353002

8 years agofix skp fuzz
caryclark [Thu, 21 Jan 2016 14:54:46 +0000 (06:54 -0800)]
fix skp fuzz

R=kjlubick@google.com
BUG=skia:4816
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617033002

Review URL: https://codereview.chromium.org/1617033002

8 years agoRemove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS (now unused).
senorblanco [Thu, 21 Jan 2016 14:49:15 +0000 (06:49 -0800)]
Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS (now unused).

BUG=skia:3194
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616503002

Review URL: https://codereview.chromium.org/1616503002

8 years agodetect bad/corrupt flattenable factory indices
reed [Thu, 21 Jan 2016 14:44:18 +0000 (06:44 -0800)]
detect bad/corrupt flattenable factory indices

BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1615883002

Review URL: https://codereview.chromium.org/1615883002

8 years agoMake colorimagefilter GM not crash when resource path not specified
bsalomon [Thu, 21 Jan 2016 14:44:08 +0000 (06:44 -0800)]
Make colorimagefilter GM not crash when resource path not specified
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619723002
BUG=skia:

Review URL: https://codereview.chromium.org/1619723002

8 years agofuzz: list API fuzzing options if -t api and -n matches nothing.
mtklein [Thu, 21 Jan 2016 14:13:52 +0000 (06:13 -0800)]
fuzz: list API fuzzing options if -t api and -n matches nothing.

Today we segfault if --name is empty.  This fixes that too.

This updates some terms: -t api lets us fuzz an API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617713003

Review URL: https://codereview.chromium.org/1617713003

8 years agoSeperating our fuzzing binary from DM produces a 50x speed increase for decoding...
kjlubick [Thu, 21 Jan 2016 13:03:28 +0000 (05:03 -0800)]
Seperating our fuzzing binary from DM produces a 50x speed increase for decoding images and a 10x speed increase in decoding/rendering Skps.

This also lets us differentiate between the decoding of Skps and the rendering of them, the latter of which may be more interesting for bugs.

BUG=skia:4800
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1591073002

Review URL: https://codereview.chromium.org/1591073002

8 years agoremove dead code around SK_SUPPORT_LEGACY_TRANSLATEROUNDHACK
reed [Thu, 21 Jan 2016 12:33:07 +0000 (04:33 -0800)]
remove dead code around SK_SUPPORT_LEGACY_TRANSLATEROUNDHACK

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611183002

TBR=

Review URL: https://codereview.chromium.org/1611183002

8 years agoRevert of Fix GrAtlasTextBlob bounds management (patchset #8 id:140001 of https:...
joshualitt [Wed, 20 Jan 2016 21:54:28 +0000 (13:54 -0800)]
Revert of Fix GrAtlasTextBlob bounds management (patchset #8 id:140001 of https://codereview.chromium.org/1605013002/ )

Reason for revert:
seems to break upright matrix

Original issue's description:
> Fix GrAtlasTextBlob bounds management
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605013002
>
> Committed: https://skia.googlesource.com/skia/+/ae473fdfc3db2d9dd82b05b2568767d6d4038fcd

TBR=bsalomon@google.com,jvanverth@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1615473002

8 years agoSkValue: improve SkFromValue<T> implementation
mtklein [Wed, 20 Jan 2016 21:35:20 +0000 (13:35 -0800)]
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605093003

Review URL: https://codereview.chromium.org/1605093003

8 years agoRevert to old behavior for swap buffers
joshualitt [Wed, 20 Jan 2016 21:09:12 +0000 (13:09 -0800)]
Revert to old behavior for swap buffers

New behavior is preserved with 'syncOrSwap' call

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606883005

Review URL: https://codereview.chromium.org/1606883005

8 years agoFix GrAtlasTextBlob bounds management
joshualitt [Wed, 20 Jan 2016 20:35:22 +0000 (12:35 -0800)]
Fix GrAtlasTextBlob bounds management

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605013002

Review URL: https://codereview.chromium.org/1605013002

8 years agoAdd gpu implementation of OverdrawXfermode
robertphillips [Wed, 20 Jan 2016 20:00:21 +0000 (12:00 -0800)]
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002

Review URL: https://codereview.chromium.org/1607253002

8 years agoSkNx miplevel building
mtklein [Wed, 20 Jan 2016 19:55:51 +0000 (11:55 -0800)]
SkNx miplevel building

All sizes approximately twice as fast.

Before:
    micros    bench
   1649.35   mipmap_build_512x512 nonrendering
   1824.42   mipmap_build_511x512 nonrendering
   2100.66 ? mipmap_build_512x511 nonrendering
   2375.94   mipmap_build_511x511 nonrendering

After:
    micros    bench
    730.32 ! mipmap_build_512x512 nonrendering
    922.12   mipmap_build_511x512 nonrendering
    999.07   mipmap_build_512x511 nonrendering
   1342.93 ! mipmap_build_511x511 nonrendering

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6

Review URL: https://codereview.chromium.org/1606013003

8 years agoreplace arcto quads with a conic
caryclark [Wed, 20 Jan 2016 19:55:11 +0000 (11:55 -0800)]
replace arcto quads with a conic

also, remove code used only for
the quad generation

R=reed@google.com
BUG=578885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612543003

Review URL: https://codereview.chromium.org/1612543003

8 years agoConvert CanvasStateTest to the new saveLayer API
fmalita [Wed, 20 Jan 2016 19:17:39 +0000 (11:17 -0800)]
Convert CanvasStateTest to the new saveLayer API

The test needs to still work when SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG is
defined but SK_SUPPORT_LEGACY_SAVEFLAGS is not.

R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610193002

Review URL: https://codereview.chromium.org/1610193002

8 years agochange kMedium_SkFilterQuality to never pop if we're scaling
reed [Wed, 20 Jan 2016 19:04:40 +0000 (11:04 -0800)]
change kMedium_SkFilterQuality to never pop if we're scaling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605193002

Review URL: https://codereview.chromium.org/1605193002

8 years agoadd wait on fence without flush
joshualitt [Wed, 20 Jan 2016 18:54:58 +0000 (10:54 -0800)]
add wait on fence without flush

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610183002

Review URL: https://codereview.chromium.org/1610183002

8 years agoSkValue: implementation, unit test
halcanary [Wed, 20 Jan 2016 18:00:26 +0000 (10:00 -0800)]
SkValue: implementation, unit test
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1604253002

Review URL: https://codereview.chromium.org/1604253002

8 years agoMake nanobench --outResultsFile only work with Release builds.
mtklein [Wed, 20 Jan 2016 17:53:59 +0000 (09:53 -0800)]
Make nanobench --outResultsFile only work with Release builds.

It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.

BUG=skia:4828
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606323002

Review URL: https://codereview.chromium.org/1606323002

8 years agoAdd SkPath::isLastContourClosed()
fs [Wed, 20 Jan 2016 17:51:07 +0000 (09:51 -0800)]
Add SkPath::isLastContourClosed()

Adds a simple method for checking if the last command/verb in the
current contour is a 'close'.

This will simplify determining "closedness" for blink::Path, and aid
in the implementation of algorithms such as:

https://drafts.fxtf.org/motion-1/#motion-processing (second item in list)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601103006

Review URL: https://codereview.chromium.org/1601103006

8 years agoteach dump_record to recurse into subpictures
mtklein [Wed, 20 Jan 2016 16:46:40 +0000 (08:46 -0800)]
teach dump_record to recurse into subpictures

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606293002

Review URL: https://codereview.chromium.org/1606293002

8 years agoRevert of SkNx miplevel building (patchset #3 id:40001 of https://codereview.chromium...
mtklein [Wed, 20 Jan 2016 16:33:59 +0000 (08:33 -0800)]
Revert of SkNx miplevel building (patchset #3 id:40001 of https://codereview.chromium.org/1606013003/ )

Reason for revert:
Paranoid revert to see if it helps skia:4823

Original issue's description:
> SkNx miplevel building
>
> All sizes approximately twice as fast.
>
> Before:
>     micros    bench
>    1649.35   mipmap_build_512x512 nonrendering
>    1824.42   mipmap_build_511x512 nonrendering
>    2100.66 ? mipmap_build_512x511 nonrendering
>    2375.94   mipmap_build_511x511 nonrendering
>
> After:
>     micros    bench
>     730.32 ! mipmap_build_512x512 nonrendering
>     922.12   mipmap_build_511x512 nonrendering
>     999.07   mipmap_build_512x511 nonrendering
>    1342.93 ! mipmap_build_511x511 nonrendering
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6

TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1607323002

8 years agoremove fragile assert
reed [Wed, 20 Jan 2016 16:12:02 +0000 (08:12 -0800)]
remove fragile assert

The assert basically wants the following to always be true (but it aint)

floor(int + 0.5 + float) == floor(0.5 + float) + int

... where int + 0.5 happens first, and then we add the float.

BUG=skia:4825
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1609873003

Review URL: https://codereview.chromium.org/1609873003

8 years agoAdd ability to wire up sharelist in glcontext creation
joshualitt [Wed, 20 Jan 2016 16:07:01 +0000 (08:07 -0800)]
Add ability to wire up sharelist in glcontext creation

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1604993005

Review URL: https://codereview.chromium.org/1604993005

8 years agoMake GrGLProgramBuilder a local stack variable in CreateProgram
egdaniel [Wed, 20 Jan 2016 15:53:51 +0000 (07:53 -0800)]
Make GrGLProgramBuilder a local stack variable in CreateProgram

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1604313002

Review URL: https://codereview.chromium.org/1604313002

8 years agoadd arc circle gap gm
caryclark [Wed, 20 Jan 2016 15:46:05 +0000 (07:46 -0800)]
add arc circle gap gm

The circle and arc don't line up because
the circle uses conics and arc uses
quadratics.

TBR=reed@google.com
BUG=578885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606263002

Review URL: https://codereview.chromium.org/1606263002

8 years agoA few more small changes to make GrAtlasTextBlob nearly self contained
joshualitt [Wed, 20 Jan 2016 14:48:47 +0000 (06:48 -0800)]
A few more small changes to make GrAtlasTextBlob nearly self contained

Note: There is still a bit of friendliness, but its going to require
some creativity to deal with.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606943002

Review URL: https://codereview.chromium.org/1606943002

8 years agoMove distance field text positioning into GrTextUtils
joshualitt [Wed, 20 Jan 2016 14:36:09 +0000 (06:36 -0800)]
Move distance field text positioning into GrTextUtils

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521633002

Review URL: https://codereview.chromium.org/1521633002

8 years agoTexturing support for RECTANGLE textures.
bsalomon [Wed, 20 Jan 2016 14:18:10 +0000 (06:18 -0800)]
Texturing support for RECTANGLE textures.

Uses textureSize() to unnormalize texture coords when reading from a RECTANGLE texture. Because of this we also require a later GLSL version to use rectangle textures (1.40).

Note that this causes a issue with the bicubic effect. The texture coords seem to have poor precision and the result is ugly. textureSize() is intended as a workaround until effects can be updated to handle unnormalized coords themselves.

Updates places where we were looking for OpenGL version 3.2 for rectangle support. It was actually added in 3.1.

BUG=skia:3868

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1594483003

Review URL: https://codereview.chromium.org/1594483003

8 years agoRevert of sdf: use linear edge distance approximation for all gradient directions...
mtklein [Wed, 20 Jan 2016 00:26:55 +0000 (16:26 -0800)]
Revert of sdf: use linear edge distance approximation for all gradient directions (patchset #1 id:1 of https://codereview.chromium.org/1545893003/ )

Reason for revert:
breaks roll?

https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/81753

Original issue's description:
> sdf: use linear edge distance approximation for all gradient directions
>
> Image diff tools tell me there are diffs, but I sure can't see them.
> This drops edge_distance() off the chart as far as CPU cost goes.
>
> BUG=skia:4729
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1545893003
>
> Committed: https://skia.googlesource.com/skia/+/8a87bb4d5c23da83ef406ef87b470afa4217d7a4

TBR=jvanverth@google.com,bsalomon@google.com,reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4729

Review URL: https://codereview.chromium.org/1603953005

8 years agoFix patch check-in instructions for non-committers
hcm [Tue, 19 Jan 2016 21:57:27 +0000 (13:57 -0800)]
Fix patch check-in instructions for non-committers

BUG=skia:4681
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606003003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1606003003

Review URL: https://codereview.chromium.org/1606003003

8 years agodon't preround in bitmap scaling setup
reed [Tue, 19 Jan 2016 21:33:32 +0000 (13:33 -0800)]
don't preround in bitmap scaling setup

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607853003

Review URL: https://codereview.chromium.org/1607853003

8 years agoAdd SSSE3 Optimizations for premul and swap
msarett [Tue, 19 Jan 2016 21:17:58 +0000 (13:17 -0800)]
Add SSSE3 Optimizations for premul and swap

Improves deocde performance for RGBA pngs.

Swizzler Time on z620 (clang):
SwapPremul 0.24x
Premul     0.24x
Swap       0.37x
Decode Time on z620 (clang):
Premul   ZeroInit Decodes 0.88x
Unpremul ZeroInit Decodes 0.94x
Premul   Regular  Decodes 0.91x
Unpremul Regular  Decodes 0.98x

Swizzler Time in Dell Venue 8 (gcc):
SwapPremul 0.14x
Premul     0.14x
Swap       0.08x
Decode Time on Dell Venus 8 (gcc):
Premul   ZeroInit Decodes 0.79x
Premul   Regular  Decodes 0.77x

Note:
ZeroInit means memory is zero initialized, and we do not write to
memory for large sections of zero pixels (memory use opt for Android).

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601883002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1601883002