Jan Kotas [Sat, 14 Feb 2015 02:18:27 +0000 (18:18 -0800)]
Fixed comments, replaced references to Evanesco with ARM
Jan Kotas [Fri, 13 Feb 2015 22:14:10 +0000 (14:14 -0800)]
Simplify platform ifdefs
Simplify platform ifdefs like #if defined(_WIN64) || defined(_TARGET_ARM_) to #if !defined(_TARGET_X86_) based on @BruceForstall suggestion
Stephen Toub [Fri, 13 Feb 2015 21:22:47 +0000 (16:22 -0500)]
Merge pull request #261 from stephentoub/fix_semaphore
Implement CreateSemaphoreExA/W via CreateSemaphoreA/W
Stephen Toub [Fri, 13 Feb 2015 20:36:51 +0000 (15:36 -0500)]
Implement CreateSemaphoreExA/W
Any managed code that touches the ThreadPool is currently crashing when the ThreadPool tries to initialize. This is due to it creating a semaphore via CreateSemaphoreExA/W in the pal, and those functions not being implemented.
This commit just implements those functions by delegating to their non-Ex counterparts. With this change, ThreadPool.QueueUserWorkItem, Task.Run, etc. are able to successfully schedule work and have it executed.
AlexGhiondea [Fri, 13 Feb 2015 19:27:20 +0000 (11:27 -0800)]
Merge pull request #262 from AlexGhiondea/produceDevPackage
Update the CoreCLR nuspec to deploy the files under the aspnetcore5 folder
Alex Ghiondea [Fri, 13 Feb 2015 18:56:56 +0000 (10:56 -0800)]
Update the CoreCLR nuspec to deploy the files under the aspnetcore5 folder.
Matt Mitchell [Fri, 13 Feb 2015 18:47:53 +0000 (10:47 -0800)]
Merge pull request #245 from poizan42/fix-rm-intermediates
Fix wrong flag to rm when deleting intermediates folder.
Matt Mitchell [Fri, 13 Feb 2015 18:46:57 +0000 (10:46 -0800)]
Merge pull request #251 from shahid-pk/issue-243
Correctly locate Clang [Fixes 250]
Matt Mitchell [Fri, 13 Feb 2015 18:46:08 +0000 (10:46 -0800)]
Merge pull request #260 from henrybw/henrybw-define-complus
Add definition of "COMPLUS" to the glossary
Henry Baba-Weiss [Fri, 13 Feb 2015 17:08:05 +0000 (09:08 -0800)]
Add definition of "COMPLUS" to the glossary
In the same vein as "COR" and "URT", the terms "COM+"/"COMPLUS" appear frequently throughout the codebase, most notably in config settings (e.g. "COMPLUS_DefaultVersion"). I couldn't find any other explanation for what this means, and since I remember learning about it myself by asking older members of the team, I thought it would be helpful to have this documented for newcomers to the codebase.
Jan Vorlicek [Fri, 13 Feb 2015 15:31:38 +0000 (16:31 +0100)]
Merge pull request #259 from janvorli/linux-issue177
Modify the windows amd64 unwinder to work as jitted code unwinder on Uni...
Jan Vorlicek [Fri, 13 Feb 2015 10:33:23 +0000 (11:33 +0100)]
Modify the windows amd64 unwinder to work as jitted code unwinder on Unix
Update the windows amd64 unwinder from its source to the latest version
and add context pointers updating that was excluded before.
Change methods of the OOPStackUnwinder and OOPStackUnwinderAMD64 to be
static, since the base class has no data members and the unwinding is
always using the processor specific subclass.
Modify the code so that it is built in two flavors. The first one
is the DAC flavor which is used by the debugger. The second one will be
used for jitted code stack frames unwinding on non-Windows systems.
Jan Vorlicek [Fri, 13 Feb 2015 09:53:38 +0000 (10:53 +0100)]
Merge pull request #258 from sergiy-k/fix-sscanf-parsing
Fix sscanf implementation in PAL
Sergiy Kuryata [Fri, 13 Feb 2015 08:29:53 +0000 (00:29 -0800)]
Fix sscanf implementation in PAL
Implementation of sscanf was incorrectly handling cases where the input format was in the form of \93%2c\94, \93%2s\94, or \93%[\93 which could result in an access violation. The problem was that sscanf was calling sscanf_s with incorrect set of arguments. Implementation of sscanf_s expects to find the size of the target buffer in the list of its parameters but that parameter was not present in some cases. This change fixes this issue and re-enables previously disabled sscanf tests.
Matt Ellis [Fri, 13 Feb 2015 05:52:13 +0000 (21:52 -0800)]
Merge pull request #254 from ellismg/remove-locale-cpp
Remove locale.cpp from the PAL on OSX
Rich Lander [Fri, 13 Feb 2015 05:33:29 +0000 (21:33 -0800)]
Merge pull request #246 from akoeplinger/fix-botr
Improvements to docs
shahid-pk [Fri, 13 Feb 2015 00:00:11 +0000 (05:00 +0500)]
Correctly locate Clang [Fixes 243]
Addressing comments
Matt Ellis [Fri, 13 Feb 2015 02:23:02 +0000 (18:23 -0800)]
Remove locale.cpp from the PAL on OSX
The globalization plans no longer require these methods to be
implemented in the PAL, since we no longer call into the VM for
globalization support except on Windows.
It's possible that more stuff can be cleaned up here, and not just for
OSX, but I need to take a careful look at the use of codepages across the
runtime to understand if it's still needed.
Matt Ellis [Fri, 13 Feb 2015 02:01:18 +0000 (18:01 -0800)]
Merge pull request #252 from dotnet-bot/from-tfs
Merge changes from TFS
Eugene Zemtsov [Fri, 13 Feb 2015 01:12:40 +0000 (17:12 -0800)]
Workaround for an ARM specific MS C++ compiler bug
Due to a bug #1123874 in arm codegen, critical code path in mscordbi.dll became unusable making any managed debugging impossible on ARM.
[tfs-changeset: 1414914]
Bengu Li [Fri, 13 Feb 2015 00:50:18 +0000 (16:50 -0800)]
Merge pull request #249 from libengu/msilchookup_1
Expand the availability of MSILC JIT to all tests
Jan Vorlicek [Fri, 13 Feb 2015 00:16:38 +0000 (01:16 +0100)]
Merge pull request #244 from benpye/file-size-ex
Add GetFileSizeEx implementation to pal
Matt Mitchell [Fri, 13 Feb 2015 00:13:58 +0000 (16:13 -0800)]
Merge pull request #248 from mmitche/xunit-xml-output
Xunit xml output
Bengu Li [Fri, 13 Feb 2015 00:03:39 +0000 (16:03 -0800)]
Expand the availability of MSILC JIT to all tests
Matt Mitchell [Thu, 12 Feb 2015 21:49:53 +0000 (13:49 -0800)]
Spit out Xunit xml result files
Spit out the xunit result files, as well as make the directory for the xunit html result files consistent with the result of the logs. We should also be passing the include and exclude attributes to the xunit task
Ben Pye [Thu, 12 Feb 2015 22:42:43 +0000 (22:42 +0000)]
Cleanup GetFileSize test to reduce duplicated code
Ben Pye [Thu, 12 Feb 2015 22:26:25 +0000 (22:26 +0000)]
Pal tests should pass on windows
Ben Pye [Thu, 12 Feb 2015 21:12:39 +0000 (21:12 +0000)]
Error if the filesize pointer is null, improve GetFileSizeEx test.
Alexander Köplinger [Thu, 12 Feb 2015 21:08:04 +0000 (22:08 +0100)]
[docs] Replace smart quotes and ellipses with their ASCII equivalent
Bengu Li [Thu, 12 Feb 2015 20:41:21 +0000 (12:41 -0800)]
Merge pull request #242 from libengu/msilchookup
Hook up initial JIT tests for MSILC JIT
Kasper F. Brandt [Thu, 12 Feb 2015 20:38:39 +0000 (21:38 +0100)]
Fix wrong flag to rm when deleting intermediates folder. Fixes #243
Pat Gavlin [Thu, 12 Feb 2015 20:29:11 +0000 (12:29 -0800)]
Merge pull request #241 from pgavlin/AltJitFixes
Small fixes to enable AltJit support on UNIX.
Ben Pye [Thu, 12 Feb 2015 20:16:31 +0000 (20:16 +0000)]
Add GetFileSizeEx implementation to pal
AlexGhiondea [Thu, 12 Feb 2015 19:35:50 +0000 (11:35 -0800)]
Merge pull request #228 from shahid-pk/issue-225
Disable the 'trim_trailing_whitespace' fixes issue 225
Stephen Toub [Thu, 12 Feb 2015 19:30:26 +0000 (14:30 -0500)]
Merge pull request #188 from stephentoub/disable_etw_unix
Update FEATURE_MANAGED_ETW and disable it on Unix
Bengu Li [Thu, 12 Feb 2015 19:26:45 +0000 (11:26 -0800)]
Hook up initial JIT tests for MSILC JIT
Pat Gavlin [Thu, 12 Feb 2015 19:03:50 +0000 (11:03 -0800)]
Small fixes to enable AltJit support on UNIX.
- Load libcoreclr.so with the RTLD_GLOBAL flag set in unixxorerun s.t.
its exports are available for subsequently loaded libraries.
- Demangle PAL_TryExcept
- Replace a non-portable path separator character with the corresponding
portable definition from the PAL.
shahid-pk [Thu, 12 Feb 2015 07:19:32 +0000 (12:19 +0500)]
Disable the 'trim_trailing_whitespace' fixes issue 225
Matt Mitchell [Thu, 12 Feb 2015 17:51:15 +0000 (17:51 +0000)]
Merge pull request #136 from poizan42/cmake-locate
Make build.cmd lookup the install directory of cmake in the registry if ...
Matt Mitchell [Thu, 12 Feb 2015 17:45:19 +0000 (17:45 +0000)]
Merge pull request #220 from mmitche/issue-208
Fix rebuild issue with development package
Matt Mitchell [Thu, 12 Feb 2015 17:33:58 +0000 (17:33 +0000)]
Merge pull request #238 from poizan42/fix-spaces-linux-build
Fix build on paths with spaces and with llvm path with spaces.
Kasper F. Brandt [Sat, 7 Feb 2015 18:26:24 +0000 (19:26 +0100)]
Make build.cmd lookup the install directory of cmake in the registry if it's not on the path.
Jan Kotas [Thu, 12 Feb 2015 17:12:03 +0000 (09:12 -0800)]
Merge pull request #239 from kangaroo/master
[issue #232] Rename dispatchexceptionwrapper on the filesystem as well
Matt Mitchell [Thu, 12 Feb 2015 16:56:00 +0000 (16:56 +0000)]
Merge pull request #183 from poizan42/build-space-fix
Correct handling of paths with spaces and ampersands when building on windows
Geoff Norton [Thu, 12 Feb 2015 16:36:09 +0000 (08:36 -0800)]
Add missing license header
Geoff Norton [Thu, 12 Feb 2015 16:14:59 +0000 (08:14 -0800)]
[issue #232] Rename dispatchexceptionwrapper on the filesystem as well
Kasper F. Brandt [Thu, 12 Feb 2015 15:59:43 +0000 (16:59 +0100)]
Fix build on paths with spaces and with llvm path with spaces. Fixes #216
Rich Lander [Thu, 12 Feb 2015 15:50:24 +0000 (07:50 -0800)]
Merge pull request #237 from richlander/master
Add Rudi's GH handle to stackwalking doc
Richard Lander [Thu, 12 Feb 2015 15:38:08 +0000 (07:38 -0800)]
Add Rudi's GH handle
Rich Lander [Thu, 12 Feb 2015 15:12:57 +0000 (07:12 -0800)]
Merge pull request #236 from richlander/master
Update document links
Richard Lander [Thu, 12 Feb 2015 15:08:49 +0000 (07:08 -0800)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Richard Lander [Thu, 12 Feb 2015 15:08:16 +0000 (07:08 -0800)]
Fix documentation links
Rich Lander [Thu, 12 Feb 2015 15:06:16 +0000 (07:06 -0800)]
Merge pull request #235 from richlander/master
Update documents
Richard Lander [Thu, 12 Feb 2015 14:59:03 +0000 (06:59 -0800)]
Make gittr link more visible
Richard Lander [Thu, 12 Feb 2015 14:56:50 +0000 (06:56 -0800)]
Update readme links to index page
Richard Lander [Thu, 12 Feb 2015 14:51:11 +0000 (06:51 -0800)]
Add documents index
Richard Lander [Thu, 12 Feb 2015 14:43:04 +0000 (06:43 -0800)]
Attribute stack walking doc to Rudi
Jan Kotas [Thu, 12 Feb 2015 14:30:55 +0000 (06:30 -0800)]
Merge pull request #223 from kangaroo/warning-clean
Clean up compiler warnings on the OSX build
Jan Kotas [Thu, 12 Feb 2015 14:24:48 +0000 (06:24 -0800)]
Merge pull request #233 from lioncash/leak
ceesectionstring: Fix a potential memory leak
Jan Kotas [Thu, 12 Feb 2015 14:23:03 +0000 (06:23 -0800)]
Merge pull request #231 from poizan42/fix-abs-64bit
Fix copy paste errors in llabs test
Rich Lander [Thu, 12 Feb 2015 14:15:48 +0000 (06:15 -0800)]
Merge pull request #234 from StephenCleary/patch-1
Replaced TODO with doc links.
Stephen Cleary [Thu, 12 Feb 2015 13:27:01 +0000 (08:27 -0500)]
Replaced TODO with doc links.
Added links to the CLR Code Guide.
Lioncash [Thu, 12 Feb 2015 13:13:54 +0000 (08:13 -0500)]
ceesectionstring: Fix a potential memory leak
Alexander Köplinger [Thu, 12 Feb 2015 10:40:04 +0000 (11:40 +0100)]
[docs] Remove trailing spaces
See markdownlint rule MD009: https://github.com/mivok/markdownlint/blob/master/docs/RULES.md#md009---trailing-spaces
Alexander Köplinger [Thu, 12 Feb 2015 10:17:25 +0000 (11:17 +0100)]
[docs] Add space after hash on atx style header
See markdownlint rule MD018: https://github.com/mivok/markdownlint/blob/master/docs/RULES.md#md018---no-space-after-hash-on-atx-style-header
Alexander Köplinger [Thu, 12 Feb 2015 10:09:45 +0000 (11:09 +0100)]
[docs] Headers should be surrounded by blank lines
See markdownlint rule MD-022: https://github.com/mivok/markdownlint/blob/master/docs/RULES.md#md022---headers-should-be-surrounded-by-blank-lines
Alexander Köplinger [Thu, 12 Feb 2015 09:58:30 +0000 (10:58 +0100)]
[docs] Get rid of multiple consecutive blank lines
See markdownlint rule MD-012: https://github.com/mivok/markdownlint/blob/master/docs/RULES.md#md012---multiple-consecutive-blank-lines
Alexander Köplinger [Thu, 12 Feb 2015 09:56:18 +0000 (10:56 +0100)]
[docs] Make formatting of code blocks/lists consistent
Code block is denoted by one tab, indentation in code blocks is four spaces.
List starts at the beginning of a line, nested list items are indented by two spaces.
Alexander Köplinger [Thu, 12 Feb 2015 09:30:38 +0000 (10:30 +0100)]
[docs] Fix typos in recently added BotR chapters
Matt Ellis [Thu, 12 Feb 2015 09:52:06 +0000 (01:52 -0800)]
Merge pull request #230 from AndreyAkinshin/master
Typo fix in objecthandle.cpp
Kasper F. Brandt [Thu, 12 Feb 2015 09:50:09 +0000 (10:50 +0100)]
fix copy paste errors in llabs test
Andrey Akinshin [Thu, 12 Feb 2015 09:16:20 +0000 (11:16 +0200)]
Typo fix in objecthandle.cpp
Rich Lander [Thu, 12 Feb 2015 07:05:14 +0000 (23:05 -0800)]
Merge pull request #226 from richlander/master
Add new BOTR docs to readme
Richard Lander [Thu, 12 Feb 2015 07:03:29 +0000 (23:03 -0800)]
Add new BOTR docs to readme
Richard Lander [Thu, 12 Feb 2015 06:59:38 +0000 (22:59 -0800)]
Respond to PR feedback on DAC filenames
dotnet-bot [Thu, 12 Feb 2015 06:49:15 +0000 (22:49 -0800)]
Add CLR coding guide
dotnet-bot [Thu, 12 Feb 2015 06:48:26 +0000 (22:48 -0800)]
Add stack walking document
Richard Lander [Thu, 12 Feb 2015 06:40:28 +0000 (22:40 -0800)]
Update glossary based on issue #209
Geoff Norton [Thu, 12 Feb 2015 04:41:29 +0000 (20:41 -0800)]
Clean up compiler warnings on the OSX build
Stephen Toub [Thu, 12 Feb 2015 03:20:12 +0000 (22:20 -0500)]
Invert ETW condition in clr.coreclr.props
Change a condition to be == Windows_NT rather than != Unix.
Jan Kotas [Thu, 12 Feb 2015 02:52:52 +0000 (18:52 -0800)]
Merge pull request #211 from kangaroo/issue-199
Implement JIT_MemSet and JIT_MemCpy for clang
Jan Kotas [Thu, 12 Feb 2015 02:46:19 +0000 (18:46 -0800)]
Merge pull request #207 from poizan42/fix-abs-64bit
Add abs(__int64) overload for 64-bit targets. Fixes #143
Matt Ellis [Thu, 12 Feb 2015 01:47:26 +0000 (17:47 -0800)]
Merge pull request #221 from ellismg/palsuite-line-endings
Force PAL test lists to have Unix line endings
Geoff Norton [Thu, 12 Feb 2015 01:26:34 +0000 (17:26 -0800)]
Ensure that we call memcpy from the PLT on linux
Jan Kotas [Thu, 12 Feb 2015 01:20:21 +0000 (17:20 -0800)]
Merge pull request #219 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Ellis [Wed, 11 Feb 2015 22:22:26 +0000 (14:22 -0800)]
Force PAL test lists to have Unix line endings
A common workflow for some folks on our team is to check out the Git
repository, then share that folder out over to Linux. In this case,
we need the pal test files to have Unix line endings, even in the case
where core.autocrlf = true, which is the case on Windows.
My hunch is that we would also need this even if we didn't do this,
since otherwise changes to this file will be mirrored back to TFS with
DOS line endings, which would break building the TFS version when
checked out, so it's likely a good idea to do this anyway, even if the
leading factor is a somewhat odd workflow.
Stephen Toub [Thu, 12 Feb 2015 01:11:56 +0000 (20:11 -0500)]
Address PR feedback on ETW disablement on Unix
Matt Mitchell [Thu, 12 Feb 2015 00:12:17 +0000 (16:12 -0800)]
Fix rebuild issue with development package
If the development package is deleted and then a rebuild is attempted we fail because mscorlib is not where we think it should be. We should be looking for mscorlib.pdb in the PDBs dir and also building the packages after the PDBs are moved.
Matt Mitchell [Thu, 12 Feb 2015 00:21:59 +0000 (00:21 +0000)]
Merge pull request #215 from mmitche/sos-in-dev-package
Add sos to the development package
John Chen [Thu, 12 Feb 2015 00:05:19 +0000 (16:05 -0800)]
Fix ARM Ready To Run: A dynamic helper generator was not allocating enough memory.
[tfs-changeset: 1414126]
Jan Vorlicek [Thu, 12 Feb 2015 00:00:34 +0000 (01:00 +0100)]
Merge pull request #217 from sergiy-k/disable-pal-sscanf-tests
Disable a few PAL sscanf test cases
Sergiy Kuryata [Wed, 11 Feb 2015 23:13:42 +0000 (15:13 -0800)]
Disable a few PAL sscanf test cases
These tests need to be temporary disabled untill the issue https://github.com/dotnet/coreclr/issues/161 is fixed. This needs to be done in order to enable running PAL tests in the lab. Currently these test cases fail on Mac and Linux release builds.
Kasper F. Brandt [Wed, 11 Feb 2015 09:02:49 +0000 (10:02 +0100)]
Add abs(__int64) overload for 64-bit targets. Fixes #143
Matt Mitchell [Wed, 11 Feb 2015 22:03:09 +0000 (14:03 -0800)]
Add sos to the development package
AlexGhiondea [Wed, 11 Feb 2015 21:01:55 +0000 (13:01 -0800)]
Merge pull request #189 from akoeplinger/fix-filename-casing
Correct casing of file paths in mscorlib
AlexGhiondea [Wed, 11 Feb 2015 19:53:04 +0000 (11:53 -0800)]
Merge pull request #212 from poizan42/fix-hardcoded-tools-resgen-path
Use $(SDK40ToolsPath) to get path to ResGen instead of hardcoding "NETFX 4.5.1 Tools".
Geoff Norton [Wed, 11 Feb 2015 19:31:28 +0000 (11:31 -0800)]
Remove the CPP stubs and ensure to mark the leaf end
Kasper F. Brandt [Wed, 11 Feb 2015 19:07:17 +0000 (20:07 +0100)]
Use $(SDK40ToolsPath) to get path to ResGen instead of hardcoding "NETFX 4.5.1 Tools".
Fixes #210
Geoff Norton [Wed, 11 Feb 2015 05:56:48 +0000 (21:56 -0800)]
Implement JIT_MemSet and JIT_MemCpy for clang
The windows build has a hand written version of these functions, but
modern systems should have an equivalent performant version of this.
We do need to wrap them to get the trap for a null reference exception,
but after that we can tail call directly.
Alexander Köplinger [Tue, 10 Feb 2015 18:54:29 +0000 (19:54 +0100)]
Correct casing of file paths in mscorlib
Some of the files had a different path/filename casing in the project reference than on disk.