Brian Sullivan [Thu, 13 Dec 2018 01:11:35 +0000 (17:11 -0800)]
Merge pull request dotnet/coreclr#21512 from briansull/fix_750014
Fix for PMI assert: 'vnWx != NoVN'
Commit migrated from https://github.com/dotnet/coreclr/commit/
36df5c596406245e9db944e2d14a1a818dfba920
Andy Ayers [Thu, 13 Dec 2018 00:56:07 +0000 (16:56 -0800)]
JIT: optimize unbox/unbox.any when type is known (dotnet/coreclr#21501)
Optimize away the unbox type test when the jit knows the type of object
being unboxed and can resolve the type comparison at jit time.
Closes dotnet/coreclr#14473.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d279e47a9bc6a9d44484c3143a5f8dd9bc57579c
Andy Ayers [Thu, 13 Dec 2018 00:54:08 +0000 (16:54 -0800)]
JIT: handle byref-typed immediates in encoding (dotnet/coreclr#21477)
We may now retype some immediates (for instance RVA statics feeding into Spans)
as byrefs. These need to be tracked as such during encoding so that the encoder
GC liveness tracking stays current.
Fixes the assert seen in dotnet/coreclr#21466.
Commit migrated from https://github.com/dotnet/coreclr/commit/
962b1737249adcbf6eea9388463a042e4dc19288
Brian Sullivan [Wed, 12 Dec 2018 23:22:49 +0000 (15:22 -0800)]
Merge branch 'master' into fix_750014
Commit migrated from https://github.com/dotnet/coreclr/commit/
62ef56ee42808e746bbac44ce7f4f65677bba55a
Brian Sullivan [Wed, 12 Dec 2018 22:42:43 +0000 (14:42 -0800)]
Fix for PMI assert: 'vnWx != NoVN'
Commit migrated from https://github.com/dotnet/coreclr/commit/
d80bbeebc88117f3c2e696a1f4fcfeb844c02557
Pent Ploompuu [Wed, 12 Dec 2018 14:47:16 +0000 (16:47 +0200)]
Optimize number parsing (dotnet/coreclr#21365)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d7f7112efaf54a9634abf2f3a8fecc254301c85
Oded Hanson [Wed, 12 Dec 2018 00:42:17 +0000 (02:42 +0200)]
Added support for debugging a sandboxed app on Mac (dotnet/coreclr#21068)
* Fixed bug in StackString where the size is not initialized correctly to STACK_COUNT
* Added CharString and WCharString template classes and a generic CharStringFromLPCWSTR method
* Added support for debugging a sandboxed app on Mac
This change fixes the usage of IPC while debugging while running in a sandbox. When running in a sandbox, the temporary folder for each process will be different. Thus the pipes being created in TwoWayPipe right now would be created in different directories in the debugger process and the process being debugged.
This change configures the folder to be used based on the application group ID that the sandboxed app belongs to.
For the same reasons, the names sempahores being used to synchronize the debugger attach need to be prefixed with the application group ID. This change was abit more involved since the name of the semaphore is limited to 31 characters, so we had to encode the semaphore names differently to make them shorter.
Last, new APIs to the debugger shim were added to support this new feature. This change only handles the runtime side and the dbgshim. An additional change to vsdbg needs to be done to use the new APIs.
fixes dotnet/coreclr#21066
* Fixed build breaks on non Mac Unix platforms
* Fixed usage of gApplicationGroupId in non apple environments
* Fixed bug in semaphore names
* Got rid of usage of StackString
* Made PAL_GetApplicationGroupId Apple specific
* Added comment about pragma pack
* Fixed comment
* Added exported symbols
* Duplicated applicationGroupId so it can be used from another thread during register complete callback
* Renamed BitNum2ByteNum to GetExtraEncodedAreaSize to make intent clearer
* Fixed nit comments
* Removed redundant changes in StackString
* Fixed windows build break
* Fixed compilation switch from __APPLE to __APPLE__
* Added missing exports
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b687cf51745790ff02c2de3f9f992ddc94bfae1
Andy Ayers [Tue, 11 Dec 2018 22:59:29 +0000 (14:59 -0800)]
JIT: capture failing inline observation in more cases (dotnet/coreclr#21471)
We were not capturing failing inline observations for failed inlines
that got reported by the runtime directly. Move the point of capture
up in the jitted code so it always happens regardless of reporting
obligations.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fc90b973bf806410b836541a3d0af2293152c787
Tanner Gooding [Tue, 11 Dec 2018 21:11:00 +0000 (13:11 -0800)]
Moving the remaining Vector128/256 helper intrinsics to be implemented using other intrinsics (dotnet/coreclr#21451)
* Updating Vector256.Create(V128, V128) to be implemented using other intrinsics
* Updating Vector128.Create(T, ...) and Vector256.Create(T, ...) to be implemented using other intrinsics
* Renaming CreateSoftware to SoftwareFallback and adding clarifying comments to the helper method code
* Fixing Vector128.Create(int, int, int, int) to properly consume the elements for the Sse2 codepath
Commit migrated from https://github.com/dotnet/coreclr/commit/
aaa00748a9029dc23a3b5455e81a3133d91afe56
dotnet-maestro-bot [Tue, 11 Dec 2018 18:21:12 +0000 (10:21 -0800)]
Update CoreClr to preview-27211-02 (dotnet/coreclr#21488)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f4060cacc908d76eb2051b86a8e84a961228f949
dotnet-maestro-bot [Tue, 11 Dec 2018 12:14:52 +0000 (04:14 -0800)]
Update CoreClr to preview-27211-01 (dotnet/coreclr#21481)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e042b90d1af94d9593ab087ed2b82b48290231f
Jan Kotas [Tue, 11 Dec 2018 12:12:12 +0000 (07:12 -0500)]
Delete unnecessary struct initialization (dotnet/coreclr#21482)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fcbe7ce1f06aa7c84dcfb954eb8be2d3deba2483
Sung Yoon Whang [Tue, 11 Dec 2018 06:49:18 +0000 (22:49 -0800)]
make GC/GCHandle tracing pay-for-play (dotnet/coreclr#21479)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b25304c757219d3103f691f615b5fa70ed22e92e
Sung Yoon Whang [Tue, 11 Dec 2018 06:49:03 +0000 (22:49 -0800)]
Fix for SetGCHandle event not getting emitted when running under Standalone GC (dotnet/coreclr#21478)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d62143d4ae97833081c5f235a91dea95da4461a0
Julius R Friedman [Tue, 11 Dec 2018 05:42:06 +0000 (00:42 -0500)]
Eliminate GenTreeRegVar and GT_REG_VAR and RegVar (dotnet/coreclr#18317)
Issue dotnet/coreclr#18201 / Hackathon
Commit migrated from https://github.com/dotnet/coreclr/commit/
e1a5d0fca2ccd95ef8c21167343f4fdd017b53a6
Tanner Gooding [Tue, 11 Dec 2018 01:41:21 +0000 (17:41 -0800)]
Adding support for the 2-byte VEX encoding to the emitter (dotnet/coreclr#21453)
* Adding support for the 2-byte VEX encoding to the emitter
* Relocating and expanding the comment which explains the two-byte VEX encoding check
Commit migrated from https://github.com/dotnet/coreclr/commit/
9fe157072d6551781200a0ce3e3321fd3dafcc0d
Brian Sullivan [Tue, 11 Dec 2018 01:24:10 +0000 (17:24 -0800)]
Merge pull request dotnet/coreclr#21386 from briansull/issue_19925
Preserve the exception sets from child nodes when we create a new unique value number
Commit migrated from https://github.com/dotnet/coreclr/commit/
335804f565c0bb18792b7097b3a1258f6cf5224a
Egor Chesakov [Tue, 11 Dec 2018 00:53:40 +0000 (16:53 -0800)]
Specify HelixTargetQueues in yaml (dotnet/coreclr#21443)
* Parametrize test-job with helixQueues(Public|Internal) in eng/test-job.yml and specify them in eng/platform-matrix.yml
* Remove HelixTargetQueues property in tests/helixpublishwitharcade.proj
* Fix the error "unknown os: linux2" with Python script
Commit migrated from https://github.com/dotnet/coreclr/commit/
86ae71ac96ed44399de26bad3542fc5ddc04bbf9
Jan Kotas [Mon, 10 Dec 2018 14:47:48 +0000 (06:47 -0800)]
Fix warnings as errors
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
9084476de3173deaf3c2c39549411fa55f500f72
Jan Kotas [Mon, 10 Dec 2018 21:34:03 +0000 (13:34 -0800)]
Refactor internal System.AppDomain out of CoreLib (dotnet/coreclr#21460)
Fixes dotnet/coreclr#21028
Commit migrated from https://github.com/dotnet/coreclr/commit/
64f76abbde7f3b7a91bbdbe66c9beebc63bb8f0c
Brian Sullivan [Mon, 10 Dec 2018 21:26:13 +0000 (13:26 -0800)]
Renamed VNCollectExc to VNUnionExcSet
Commit migrated from https://github.com/dotnet/coreclr/commit/
842f575fac8d64467bb4a15ef9fe893bedc536ad
Brian Sullivan [Mon, 10 Dec 2018 21:18:11 +0000 (13:18 -0800)]
Merge branch 'master' into issue_19925
Commit migrated from https://github.com/dotnet/coreclr/commit/
22af997e369e00e2f9ef6b8837c07f78def7d35b
Aaron Robinson [Mon, 10 Dec 2018 20:21:48 +0000 (12:21 -0800)]
Instead of using Win8+ api-sets use forwarder DLL to support downlevel versions of Windows. (dotnet/coreclr#21469)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ab1529bb9bca98d8ebfce5461626cec14426ac53
dotnet-maestro-bot [Mon, 10 Dec 2018 16:20:17 +0000 (08:20 -0800)]
Update CoreClr to preview-27210-02 (dotnet/coreclr#21467)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9dd701f69d68ebd8577adb91fd70e1ea38be7d9e
Jan Kotas [Mon, 10 Dec 2018 15:52:15 +0000 (07:52 -0800)]
Add support for RVA fields to crossgen/R2R (dotnet/coreclr#21463)
* Add support for RVA fields to crossgen/R2R
RVA fields are became more common with pre-inititialized ReadOnlySpan<byte>. Fix crossgen to deal with them for R2R.
* Fix tests, map new JIT helper for R2R
Commit migrated from https://github.com/dotnet/coreclr/commit/
32d8dfb65f2403c1cb628495ee944a9f35a0eb3a
dotnet-maestro-bot [Mon, 10 Dec 2018 11:43:04 +0000 (03:43 -0800)]
Update CoreClr, PgoData to preview-27210-01, master-
20181210-0037, respectively (dotnet/coreclr#21452)
Commit migrated from https://github.com/dotnet/coreclr/commit/
06da50019c25b1273a8df8e03fe8bc7b5d8288b9
Nick Craver [Mon, 10 Dec 2018 11:01:52 +0000 (06:01 -0500)]
Fix for dotnet/coreclr#21456 (Regressions in attribute allocations for non-generic attributes) (dotnet/coreclr#21462)
* Fix for dotnet/coreclr#21456 - restrict increased generic attribute allocations to only generic attributes
This is a trivial quick-fix for dotnet/coreclr#21456 where regressions between 2.1 and 3.0 were discovered on most attibute pathways due to the allocation overhead in the generic-supporting pathways. The workaround is to simply not take that slow/expensive path for non-generics.
While I'd like to optimize `RuntimeModule.ResolveMethod` further, there's a public surface area in play there that makes the changes non-trivial. There, we'll have to choose overhead on the public path (which may still be a net win), or duplication in code for another path.
* Update comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
130cec3b15815ae023a7aac9dc96aa97b36117a0
Jan Kotas [Mon, 10 Dec 2018 10:57:57 +0000 (02:57 -0800)]
Delete vm/context.* (dotnet/coreclr#21459)
* Delete vm/context.*
Leftover from remoting
Commit migrated from https://github.com/dotnet/coreclr/commit/
49ca3db92a48da71d25c607af9716a30bafb3ff8
Oded Hanson [Mon, 10 Dec 2018 09:51:48 +0000 (11:51 +0200)]
Added Close On Exec Attribute for Mutex files (dotnet/coreclr#21455) (dotnet/coreclr#21458)
* Added Close On Exec Attribute for mutex files (dotnet/coreclr#21455)
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc03ef9aeb467950f181a2e2d53fe4b92a98d0c9
Oded Hanson [Mon, 10 Dec 2018 09:49:39 +0000 (11:49 +0200)]
Fixed bug where "DCI_NUMA" was missing from debug channel names (dotnet/coreclr#21454) (dotnet/coreclr#21457)
In additional to adding "DCI_NUMA" to dbg_channel_names, a static assertion was added to verify that dbg_channel_names length is valid. Also added some comments to help developpers not to forget to add corresponding entries in dbg_channel_names.
FIxes dotnet/coreclr#21454
Commit migrated from https://github.com/dotnet/coreclr/commit/
9a59c40788d55aeb187df2319cd4450fdb01b6f9
dotnet-maestro-bot [Sun, 9 Dec 2018 01:02:09 +0000 (17:02 -0800)]
Update CoreClr, CoreFx, CoreSetup, PgoData to preview-27208-01, preview.18606.1, preview-27206-02, master-
20181208-0038, respectively (dotnet/coreclr#21374)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a81680cc473a6620625815eb643c2f2fea771f2e
Michal Strehovský [Sat, 8 Dec 2018 21:48:06 +0000 (22:48 +0100)]
Fix regression in fat calls (dotnet/coreclr#21446)
This seems to fix an AV in RyuJIT.
Commit migrated from https://github.com/dotnet/coreclr/commit/
759116b3db4b0f6e2b4306062f33b517d532217a
Tarek Mahmoud Sayed [Sat, 8 Dec 2018 20:40:13 +0000 (12:40 -0800)]
Leap Seconds Support (dotnet/coreclr#21420)
* Leap Seconds Support
* Address Feedback
* More feedback addressing
Commit migrated from https://github.com/dotnet/coreclr/commit/
98e49952213ff29ee78cb9c33dd33927a88905c6
Aaron Robinson [Sat, 8 Dec 2018 18:41:29 +0000 (10:41 -0800)]
Remove `TryGetGuid()` and `GetDefaultInterfaceForCoclass()` from the (dotnet/coreclr#21447)
* Remove `TryGetGuid()` and `GetDefaultInterfaceForCoclass()` from the
stdinterfaces API surface.
Commit migrated from https://github.com/dotnet/coreclr/commit/
12fafad1c95a3379a0d8bd9e584a8161cb3f9fe1
Jeremy Koritzinsky [Sat, 8 Dec 2018 05:36:01 +0000 (21:36 -0800)]
Add PNSE CustomMarshaler tests (for Tlbimp compat) (dotnet/coreclr#21438)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d26b3b538dae408635806bb86d14e6d64f6cbd80
Stephen Toub [Sat, 8 Dec 2018 04:49:29 +0000 (23:49 -0500)]
Use string.Create in ConvertFromUtf32 (dotnet/coreclr#21409)
* Use string.Create in ConvertFromUtf32
Removes the unsafe code from the method. Also happens to make it a bit faster.
* Improve Rune.ToString performance
Commit migrated from https://github.com/dotnet/coreclr/commit/
ca60cf7c507e73f3bb28de0f7781b201a66cf8d2
Stephen Toub [Sat, 8 Dec 2018 02:14:44 +0000 (21:14 -0500)]
Remove some unnecessary spinning (dotnet/coreclr#21437)
Most of the use of SpinWait in CoreLib involves waiting for some short-lived operation to complete on another thread, in which case the spinning thread should backoff as it's unable to make forward progress until the other operation completes. In a few cases, however, SpinWait is being used just around CompareExchange operations, such that at least one thread running this code path is guaranteed to make forward progress, and the backoff in the spinning doesn't actually help (in theory it could help to reduce contention if lots of threads were all trying to CompareExchange concurrently, but in such cases you'd actually want more randomized backoff, as otherwise it's likely all the threads would re-attempt at around the same time and similarly re-encounter contention).
Commit migrated from https://github.com/dotnet/coreclr/commit/
1cba6f8c32a74a7e7e20fad004be6796a7282c94
Tanner Gooding [Fri, 7 Dec 2018 23:01:23 +0000 (15:01 -0800)]
Moving various Vector128/256 helper method to be implemented using other intrinsics (dotnet/coreclr#21432)
* Updating Vector128.CreateScalar and Vector256.CreateScalar to be implemented using other intrinsics
* Updating Vector128.Equals and Vector256.Equals to be implemented using other intrinsics
* Updating Vector256.WithLower, Vector256.GetUpper, and Vector256.WithUpper to be implemented using other intrinsics
* Updating Vector128.Create(T) and Vector256.Create(T) to be implemented using other intrinsics
* Fixing the `NI_Base_Vector256_As` intrinsics to only fold the cast if AVX is supported and add a clarifying comment to the Vector128/256.Equals code
* Changing the various `*Software()` local functions in Vector128/256 to be `SoftwareFallback()`
Commit migrated from https://github.com/dotnet/coreclr/commit/
615a321f5226e0d9389741f4fcec9b6944e319cb
Aaron Robinson [Fri, 7 Dec 2018 22:31:24 +0000 (14:31 -0800)]
Add support for loading registered TLBs (dotnet/coreclr#21430)
* Add support for loading registered TLBs
Commit migrated from https://github.com/dotnet/coreclr/commit/
139bdfd2b9378a7370e8d771811c330488d29ea2
Davis Goodin [Thu, 6 Dec 2018 23:16:49 +0000 (17:16 -0600)]
Build Microsoft.NET.Sdk.IL in source-build
Commit migrated from https://github.com/dotnet/coreclr/commit/
d52df656f0a4c3dc6591698575cd598ea6d5272a
Tanner Gooding [Fri, 7 Dec 2018 21:00:35 +0000 (13:00 -0800)]
Adding a note to the genBaseIntrinsic function header about operand assumptions (dotnet/coreclr#21439)
Commit migrated from https://github.com/dotnet/coreclr/commit/
be913c781de85aa3f4e0b952262f0f081c93eacb
Jan Vorlicek [Fri, 7 Dec 2018 19:13:43 +0000 (20:13 +0100)]
Fix some SOS commands after SharedDomain removal (dotnet/coreclr#21401)
The recent removal of SharedDomain has broken some SOS commands, like
Name2EE or bpmd. There was a code that was enumerating domains and
obtaining some information on them. And the shared domain pointer from
DacpAppDomainStoreData was being included in the list of domains. As it
is NULL now, we have failed to get the information and the domain
iteration loop was exited prematurely.
I have made SOS resilient to the possibility of missing shared domain.
On older runtimes, the shared domain is still being reported.
Commit migrated from https://github.com/dotnet/coreclr/commit/
af46c514824aacd4d439eb1891d3d392c6894476
Stephen Toub [Fri, 7 Dec 2018 18:56:32 +0000 (13:56 -0500)]
Add CancellationToken parameter to GetAsyncEnumerator (dotnet/coreclr#21397)
Commit migrated from https://github.com/dotnet/coreclr/commit/
811e34bc945ca1e294d64320cd3aba7866f8aeee
Stephen Toub [Fri, 7 Dec 2018 18:55:53 +0000 (13:55 -0500)]
Factor new AsyncIteratorStateMachineAttribute into TryResolveStateMachineMethod (dotnet/coreclr#21396)
Commit migrated from https://github.com/dotnet/coreclr/commit/
372f18e8befffe3f4f1ccb3c21aeaf41af2aa763
Carol Eidt [Fri, 7 Dec 2018 18:11:30 +0000 (10:11 -0800)]
Merge pull request dotnet/coreclr#21361 from fiigii/x64tests
Improve hardware intrinsic tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
02d37e4b3f7a8d26949a827f9b0d6c0422b3670c
Jeremy Koritzinsky [Fri, 7 Dec 2018 17:55:37 +0000 (09:55 -0800)]
Add PNSE implementations of unsupported built-in custom marshalers to enable good error messages on PIAs that could possibly directly use them. (dotnet/coreclr#21429)
Commit migrated from https://github.com/dotnet/coreclr/commit/
78de81cf619c6e06a26860763dea761d928febd0
Bruce Forstall [Fri, 7 Dec 2018 16:10:00 +0000 (08:10 -0800)]
Disable ObjectStackAllocationTests for ARM32 (dotnet/coreclr#21421)
Issue dotnet/coreclr#21376
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e929c65e76778b18a888c46643a56cf6a740408
Stephen Toub [Fri, 7 Dec 2018 09:56:40 +0000 (04:56 -0500)]
Fix Microsoft.IO.Redist compilation string.Create compilation failure
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff199cc9ac6cef3679918d2e88d5c19f8090593e
Carol Eidt [Fri, 7 Dec 2018 14:20:49 +0000 (06:20 -0800)]
Merge pull request dotnet/coreclr#21431 from fiigii/fixbmi
Fix a bug that disabled Bmi1/2.X64
Commit migrated from https://github.com/dotnet/coreclr/commit/
77a5a729dd1ce008d4da2bc3f3b5775e4664dd75
Michal Strehovský [Fri, 7 Dec 2018 10:46:27 +0000 (11:46 +0100)]
Work around an MCG bug (dotnet/corertdotnet/coreclr#6658)
This is blocking TFS integrations.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
13f8624a5526d9e71c6b8383c68be0afded8d596
Jan Vorlicek [Fri, 7 Dec 2018 09:32:59 +0000 (10:32 +0100)]
Fix SOS thread statics display (dotnet/coreclr#21426)
I've noticed that when dumping an object with thread locals using SOS
dumpobj command, I never get the thread locals. I've stepped through the
code in SOS that displays thread statics and found that for some strange
reason, it dismisses threads where DomainLocalModule doesn't have
"initialized" flag set for the given class. However, when runtime
accesses thread statics, it just checks "allocated" flag set for the
given class in the ThreadLocalModule. Removing the extra check for
DomainLocalModule fixed the problem and now thread statics are displayed
properly.
Commit migrated from https://github.com/dotnet/coreclr/commit/
add9f313447c44db85944cbff0d633f8852b5b9f
Jan Vorlicek [Fri, 7 Dec 2018 09:20:48 +0000 (10:20 +0100)]
Disable obsolete collectible corefx tests (dotnet/coreclr#21428)
Now that the COM interop support for collectible classes is in, we need
to disable couple of corefx tests that were checking that it fails.
Commit migrated from https://github.com/dotnet/coreclr/commit/
35b5555b96b57e9f5a969580abb5dfdfeb735732
Andy Ayers [Fri, 7 Dec 2018 08:12:04 +0000 (00:12 -0800)]
JIT: block general cloning of candidate calls (dotnet/coreclr#21418)
Follow-up from dotnet/coreclr#21270 and dotnet/coreclr#21414.
Block general cloning from inadvertently cloning a candidate call.
Add a separate path for cloning calls that are inline and guarded
devirtualization candidates for use by guarded devirtualization.
Callers need to take extra steps after cloning one of these calls
to properly fix everything up.
Also fix up some issues in the large comment for the fat calli
transformation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
08be98cd4d13102958b21d8ad4b067f6fee1abb4
Fei Peng [Fri, 7 Dec 2018 01:42:17 +0000 (17:42 -0800)]
Fix a bug that disabled Bmi1/2.X64
Commit migrated from https://github.com/dotnet/coreclr/commit/
4c9b4f0537bfeb97c3f749bc0bd5c4560f090e9c
Tanner Gooding [Fri, 7 Dec 2018 01:15:03 +0000 (17:15 -0800)]
Moving CreateScalarUnsafe, ToScalar, Vector128.ToVector256Unsafe, and Vector256.GetLower to be intrinsics (dotnet/coreclr#21351)
* Moving CreateScalarUnsafe, ToScalar, Vector128.ToVector256Unsafe, and Vector256.GetLower to be intrinsics
* Adding containment support to the helper intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c18b3290b825e66e973e147eda8c7cca3e539c6
Carol Eidt [Thu, 6 Dec 2018 21:50:19 +0000 (13:50 -0800)]
Merge pull request dotnet/coreclr#21314 from CarolEidt/DontPromoteHwVector
Don't struct-promote opaque vectors
Commit migrated from https://github.com/dotnet/coreclr/commit/
61da68e56ab0b3dd4865d34aee0ca243cc702c09
Michelle McDaniel [Thu, 6 Dec 2018 21:18:28 +0000 (13:18 -0800)]
Revert "Move the perf jobs to Windows.10.Amd64.ClientRS4.DevEx.15.8.Open (dotnet/coreclr#21258)" (dotnet/coreclr#21412)
This reverts commit dotnet/coreclr@
5bb1b41dd19bca8f25b6d048c27d6708b86326cb.
Commit migrated from https://github.com/dotnet/coreclr/commit/
82693d8f088d2a3c0cc8e2d2f7de0a86b18b4df9
Stephen Toub [Thu, 6 Dec 2018 21:11:49 +0000 (16:11 -0500)]
Use Span instead of manual copy in MetadataImport.GetUserString (dotnet/coreclr#21405)
* Use Span instead of manual copy in MetadataImport.GetUserString
* Address PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
4ea2c295ac521272af399580006c55d295782b5a
Stephen Toub [Thu, 6 Dec 2018 21:11:33 +0000 (16:11 -0500)]
Remove char[] allocation from EventPipePayloadDecoder for strings (dotnet/coreclr#21407)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5786b4b607038417a51c2990f7c3db4990126ef7
Stephen Toub [Thu, 6 Dec 2018 21:11:09 +0000 (16:11 -0500)]
Use string.Create in Path.GetRandomFilePath (dotnet/coreclr#21410)
* Use string.Create in Path.GetRandomFilePath
Removes a good chunk of the unsafe code.
* Address PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
18ef23757624db629f3a414c29b8a795e12b05ba
Andy Ayers [Thu, 6 Dec 2018 20:58:48 +0000 (12:58 -0800)]
JIT: move indirect call transformations to a new source file (dotnet/coreclr#21414)
Follow-up from a review comment in dotnet/coreclr#21270.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e9c14ee4a3085b7b2a5e34bb2e26d71dbfc2fec
Stephen Toub [Thu, 6 Dec 2018 19:27:42 +0000 (14:27 -0500)]
Replace a few new string(char, 1) with char.ToString(char) (dotnet/coreclr#21406)
Slightly cleaner, slightly faster.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1433bca815a32a9cb77b12f6baf0a64c61b20cf
Russ Keldorph [Wed, 5 Dec 2018 23:58:32 +0000 (15:58 -0800)]
Work around apparent bug in CMD's FOR /L
Hopefully this will mean that official build failures during the actual build
phase will correctly be reported as failures. There could be other places that
need to change, but this is all we know of right now.
Fixes dotnet/coreclr#18788 (at least part of it)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c8dd79c74e8021f5e2fb9c05116e69848470c87
Stephen Toub [Thu, 6 Dec 2018 18:41:54 +0000 (13:41 -0500)]
Fix CancellationTokenRegistration.Token after CTS.Dispose (dotnet/coreclr#21394)
CTR.Token should never throw, but it's currently throwing an ObjectDisposedException if the associated CancellationTokenSource has been disposed.
Commit migrated from https://github.com/dotnet/coreclr/commit/
588faa52bd2269ca3158c2b0c9199b0b9f90ec11
Egor Chesakov [Thu, 6 Dec 2018 18:22:50 +0000 (10:22 -0800)]
Run MSBuild in parallel when submitting jobs to Helix (dotnet/coreclr#21390)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2161d9d1789d28b1e56f4edff47572b12585a680
Jeremy Koritzinsky [Thu, 6 Dec 2018 17:56:21 +0000 (09:56 -0800)]
Port CustomMarshalers.dll to C# and .NET Core (dotnet/coreclr#21343)
* Import CustomMarshalers from corefx PR.
* Add tests for marshalling IEnumerator and IEnumerable using the System.Runtime.InteropServices.CustomMarshalers.
* Verify that the marshaller is used in the managed -> native direction in the tests.
* Remove #if's
* PR Feedback.
* Move ComHelpers.h into interop common headers.
* Add some template machinery to ensure that we don't accidentally pass in an incorrect type into DoQueryInterface.
* Add VariantClear
* Make marshalers internal and root them in ILLinkTrim.xml
* Revert enable-if machinery.
* Add tests for the pass-through unwrapping done by the EnumeratorToEnumVariantMarshaler.
* Remove some of my helper code.
* Added todo about exposing EnumerableToDispatchMarshaler.
* PR Feedback.
* Removed the last placement new.
* Use the runtime hooks to enable us to not have to publically expose the custom marshalers.
* Remove out of date comments.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5955967d808d1d88ef927235276d3ca82b5d9363
Andy Ayers [Thu, 6 Dec 2018 17:03:31 +0000 (09:03 -0800)]
Guarded devirtualization foundations (dotnet/coreclr#21270)
Lay the groundwork for guarded devirtualization of virtual and interface
calls in the jit.
Introduce the notion of a guarded devirtualization candidate and identify
these if regular devirtualization fails. Use simple heuristics to produce
a class to guess for. Require that the method that would be invoked if the class
guess is correct be a plausible inline candidate.
Generalize the calli transformer to become an indirect call transformer.
This runs after importation because it needs to introduce control flow and
runs before inlining so that the new direct calls it introduces can be inlined.
Implement the transformation to duplicate the call site, devirtualize on the side
where the class is now known exactly, and turn the resulting direct call into an
inline candidate.
Add a motivation and design document.
Commit migrated from https://github.com/dotnet/coreclr/commit/
045f470f71cfcedf3eb7ff248f25bf29619d9a88
Egor Chesakov [Thu, 6 Dec 2018 03:41:47 +0000 (19:41 -0800)]
Use array syntax in eng/test-job.yml (dotnet/coreclr#21393)
Update eng/test-job.yml to use array syntax after changing from phase schema to job schema
Commit migrated from https://github.com/dotnet/coreclr/commit/
7454475cd4f5575d2a2db3879bb164609e8bd6ad
Brian Sullivan [Thu, 6 Dec 2018 01:46:49 +0000 (17:46 -0800)]
Added NullChk exceptions for GT_ARR_LENTH, GT_ARR_ELEM and GT_ARR_OFFSET
Commit migrated from https://github.com/dotnet/coreclr/commit/
425f8428461bb4770bbec56d3bbb13e0a6c0adf6
Jan Kotas [Thu, 6 Dec 2018 01:39:33 +0000 (17:39 -0800)]
Delete FEATURE_TREAT_NI_AS_MSIL_DURING_DIAGNOSTICS (dotnet/coreclr#21387)
Always defined in .NET Core
Commit migrated from https://github.com/dotnet/coreclr/commit/
2376cd18c8b9ff850092817ea31533e58a85369f
Jan Vorlicek [Thu, 6 Dec 2018 00:21:43 +0000 (01:21 +0100)]
Disable native image usage for collectible assemblies (dotnet/coreclr#21378)
* Disable native image usage for collectible assemblies
There are couple of issues with using native images as collectible
assemblies. The most important one is that statics handling is different
for collectible and non-collectible classes. Collectible classes have
statics stored in per class allocated blocks while the non-collectible ones
are all stored per module. So the code that accesses them needs to use
different offsets relative to a statics base address in each of these cases.
The crossgen generates just a single form of code that corresponds to the
non-collectible case and so such code cannot be used when a module is
loaded as collectible.
To mitigate that, we disable using the native code from crossgen-ed
assemblies and JIT all the code instead.
We may want to revisit this in the future and e.g. unify the statics
handling for collectible and non-collectible classes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f940ccc633088d657e6d34c1e56bb0f0be4a4a73
Brian Sullivan [Wed, 5 Dec 2018 23:33:52 +0000 (15:33 -0800)]
Merge branch 'master' into issue_19925
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1b63cc0709cb0ae3985149c0500d7e57322fc00
Brian Sullivan [Wed, 5 Dec 2018 23:32:22 +0000 (15:32 -0800)]
Use fgValueNumberAddExceptionSetForIndirection to calculate the base address for the VNF_NullPtrExc
Commit migrated from https://github.com/dotnet/coreclr/commit/
5bc24688a10464004540904bb040cd0e37c2601e
Egor Chesakov [Wed, 5 Dec 2018 23:29:48 +0000 (15:29 -0800)]
Refactor genAllocLclFrame into two architecture-specific functions (dotnet/coreclr#21074)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5f19dbbc2612390d145bfa7c896784fbc643436
Michelle McDaniel [Wed, 5 Dec 2018 23:02:57 +0000 (15:02 -0800)]
Move the perf jobs to Windows.10.Amd64.ClientRS4.DevEx.15.8.Open (dotnet/coreclr#21258)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5bb1b41dd19bca8f25b6d048c27d6708b86326cb
Brian Sullivan [Wed, 5 Dec 2018 22:26:55 +0000 (14:26 -0800)]
Merge pull request dotnet/coreclr#21322 from mikedn/div-small-int
Fix lclvar "cloning" in const division lowering
Commit migrated from https://github.com/dotnet/coreclr/commit/
fdf722ecdea2de7044795b51c3e0d212cc2d8f68
Jarret Shook [Wed, 5 Dec 2018 22:00:32 +0000 (14:00 -0800)]
Change from phases to jobs (dotnet/coreclr#21384)
* Initial change to use jobs/jobs.yml
* Fix If syntax
* Hopefully fix more syntax
* Change from jobs to job
* change from queue to pool
* change scope of container name
* Change build to sync and init tools inside build.sh
* Add workspace
Commit migrated from https://github.com/dotnet/coreclr/commit/
0ab2780c421f5b18549d9f215108e587e6fcbee6
Swaroop Sridhar [Wed, 5 Dec 2018 20:55:39 +0000 (12:55 -0800)]
Suppress a CMake Warning (dotnet/coreclr#21147)
* Suppress a CMake Warning
This change adds a local cmake_policy rule to suppress
warnings about libraries with unicode names.
```
CMake Warning (dev) at tests/src/Interop/PInvoke/DllImportPath/CMakeLists.txt:14 (add_library):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
The target name "DllImportPath_U�n�i�c�o�d�e" is reserved or
not valid for certain CMake features, such as generator expressions, and
may result in undefined behavior.
This warning is for project developers. Use -Wno-dev to suppress it.
```
* Update tests/src/Interop/PInvoke/DllImportPath/CMakeLists.txt
Co-Authored-By: swaroop-sridhar <Swaroop.Sridhar@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
31a132a9c58facbfde91de6119df8c4fbfa52d48
Brian Sullivan [Wed, 5 Dec 2018 20:05:40 +0000 (12:05 -0800)]
Preserve the exception sets from child nodes when we create a new unique value number
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c17b091638b7ee94a99146565d2e713e75abde8
Jeremy Koritzinsky [Wed, 5 Dec 2018 18:04:52 +0000 (10:04 -0800)]
Add tests for marshalling RuntimeHandle types. (dotnet/coreclr#21091)
* Add tests for marshalling runtime handles.
* Remove DLL signature for impossible test
Commit migrated from https://github.com/dotnet/coreclr/commit/
a3304a1fc6a442efc54f2fc765e6877ffba14a5a
Steve MacLean [Wed, 5 Dec 2018 18:03:56 +0000 (13:03 -0500)]
Remove FromGAC & OnTPAList (dotnet/coreclr#21371)
* Remove FromGAC & OnTPAList
* PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
339694220684c079698bb0e3656011b9522d26f3
Jan Kotas [Wed, 5 Dec 2018 16:01:02 +0000 (08:01 -0800)]
Revert Array enumerator behavior change (dotnet/coreclr#21368)
Fixes dotnet/coreclr#21046
Commit migrated from https://github.com/dotnet/coreclr/commit/
6496481b4eec064188a50bcf5132191273d088f6
Aaron Robinson [Wed, 5 Dec 2018 04:13:48 +0000 (20:13 -0800)]
Convert SDK projects into non-SDK projects (dotnet/coreclr#21369)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e8d67d23b2edcb2200f2601ac74c421d98b6c97f
Sergey Andreenko [Wed, 5 Dec 2018 03:58:32 +0000 (19:58 -0800)]
Add repro for `(reg2 == REG_NEXT(reg1)) || (reg2 == REG_LR)` assert in `codegenarm64`. (dotnet/coreclr#21344)
* Add a repro.
* Exclude the failing test.
* fix formatting
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e6cefa8887613fc18a8cc9be54f38c7907adca8
Steve MacLean [Wed, 5 Dec 2018 02:57:17 +0000 (21:57 -0500)]
Fix XML comments on *nux (dotnet/coreclr#21372)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f794a0c783f36fa5f1f85060fce86dbf05e09cf0
Aaron Robinson [Wed, 5 Dec 2018 01:59:28 +0000 (17:59 -0800)]
Additional tests for type equivalence (dotnet/coreclr#21340)
* Additional tests for type equivalence
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce6cdca8af8da8e1c60d955e2f168467f9809aaa
Stephen Toub [Wed, 5 Dec 2018 00:14:33 +0000 (19:14 -0500)]
Merge pull request dotnet/coreclr#21313 from stephentoub/asynciteratorattr
Add AsyncIteratorStateMachineAttribute
Commit migrated from https://github.com/dotnet/coreclr/commit/
3af62c9332b15792aaeed21f25bb69218812f962
Fei Peng [Wed, 5 Dec 2018 00:06:39 +0000 (16:06 -0800)]
Improve BMI2 MultiplyNoFlags APIs (dotnet/coreclr#21362)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2217719e39762dc4bb1bb8094b4c4ab86229b004
Mike McLaughlin [Tue, 4 Dec 2018 20:51:50 +0000 (12:51 -0800)]
Update the symbol uploader/publisher to version 1.0.0-beta-63604-05. (dotnet/coreclr#21360)
Commit migrated from https://github.com/dotnet/coreclr/commit/
71255bc05db24f078f334ead245898b817c8a06e
Fei Peng [Tue, 4 Dec 2018 20:09:53 +0000 (12:09 -0800)]
Move more SSE2 intrinsic tests to template
Commit migrated from https://github.com/dotnet/coreclr/commit/
ddd6ddb6075e74d253146a99cf84fac77e18bb7e
Fei Peng [Tue, 4 Dec 2018 19:41:02 +0000 (11:41 -0800)]
Remove redundant checks in test templates
Commit migrated from https://github.com/dotnet/coreclr/commit/
86e6443684982ffd13f6cdfb4ead82f586063934
Stephen Toub [Tue, 4 Dec 2018 18:55:52 +0000 (13:55 -0500)]
Merge pull request dotnet/coreclr#21356 from stephentoub/xmlcomments
Fix lots of malformed XML comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e7713437a42b6c9abd401368ae1004deed988be
dotnet-maestro-bot [Tue, 4 Dec 2018 17:52:55 +0000 (09:52 -0800)]
Update CoreClr, CoreFx, CoreSetup to preview-27204-02, preview.18604.2, preview-27204-02, respectively (dotnet/coreclr#21353)
Commit migrated from https://github.com/dotnet/coreclr/commit/
359d0ee4dab568d29bdc2d6b0bbae8439aa30815
Stephen Toub [Tue, 4 Dec 2018 16:30:19 +0000 (11:30 -0500)]
Delete dead code in Task<T>
Commit migrated from https://github.com/dotnet/coreclr/commit/
85f2d14b0c5c44f5669e50d3d6486fa9500aa103
Stephen Toub [Tue, 4 Dec 2018 16:28:52 +0000 (11:28 -0500)]
Enable building/validating XML comments in CoreLib
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe1806b0b650fb9ec239b347d8eda72487f11aee
Stephen Toub [Tue, 4 Dec 2018 15:47:21 +0000 (10:47 -0500)]
Fix lots of malformed XML comments
These are causing errors in the source.dot.net build. Turning on DocumentationFile and suppressing 1591, 1573, and 0419, Corelib builds clean after these changes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1b3dc3356cb6acd7025d50202b7003f0244fb7ed
dotnet-maestro-bot [Tue, 4 Dec 2018 13:52:04 +0000 (05:52 -0800)]
Update CoreClr, CoreFx, CoreSetup to preview-27204-01, preview.18604.1, preview-27203-03, respectively (dotnet/coreclr#21346)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f7c3f1a79beda467bbf956407f46a9ec9071e39a
Tanner Gooding [Tue, 4 Dec 2018 13:51:50 +0000 (05:51 -0800)]
Fixing the Vector64/128/256<T>.ToString(string) methods to pass `null` for the formatProvider (dotnet/coreclr#21350)
Commit migrated from https://github.com/dotnet/coreclr/commit/
02274cb31cca8530480e6087564abe78a72d198d
Steve MacLean [Tue, 4 Dec 2018 07:27:31 +0000 (02:27 -0500)]
Remove *LoadContextHostBinder (dotnet/coreclr#21342)
Commit migrated from https://github.com/dotnet/coreclr/commit/
248d54d6990677efcfcdeecd63539e72219c9d60
Jan Kotas [Mon, 3 Dec 2018 20:57:56 +0000 (12:57 -0800)]
Sort System.Private.CoreLib.csproj
Commit migrated from https://github.com/dotnet/coreclr/commit/
397aaccb5104844998c3bcf6e9245cc81127e1e2