platform/core/system/storaged.git
6 years agoblock: Add mmc inserted & removed popup 45/172645/1 accepted/tizen/unified/20180320.065835 submit/tizen/20180319.102056 submit/tizen/20180320.020048
pr.jung [Thu, 15 Mar 2018 04:30:16 +0000 (13:30 +0900)]
block: Add mmc inserted & removed popup

- Launch notice popup when mmc is mounted and unexpectedly removed

Change-Id: I0978c2bb8eee80129490065bac1749cf03883674
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Fix code to be more readable 82/172382/1
pr.jung [Tue, 13 Mar 2018 11:26:19 +0000 (20:26 +0900)]
block: Fix code to be more readable

Change-Id: I413ad40cb7cd633f5ad2f2af3af4343e9e497e79
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Change external storage permission to 777 58/172358/2
pr.jung [Tue, 13 Mar 2018 10:47:02 +0000 (19:47 +0900)]
block: Change external storage permission to 777

- Directory permission is 777, uid is root groupid is priv_externalstorage
- security-manager will handle access control for external storage
- When externalstorage privilege is configured as privacy,
security framework will enforce this privilege with different mechanism - per-application mount namespace.
In such case mount options must be different to allow all users and groups access to mount point.
If an application is not supposed to have access to externalstorage,
security-manager will mount a special directory over sdcard mount point.
In such case access control is no longer based on GID,
so mount options must allow application access regardless of its groups.

Change-Id: I1582d3afd70354cc81d7142fee4c9edf4c94ef30
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Remove memset 29/172229/1 accepted/tizen/unified/20180314.062124 submit/tizen/20180313.034553
pr.jung [Tue, 13 Mar 2018 02:24:28 +0000 (11:24 +0900)]
block: Remove memset

Change-Id: I758bed8d6bbd08425135ea2461ffe4717925f01b
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Create default directory for mmc 62/172162/3
pr.jung [Mon, 12 Mar 2018 08:59:35 +0000 (17:59 +0900)]
block: Create default directory for mmc

- Create default directories (Images, Videos, Sountds, Downloads) for primary sdcard

Change-Id: If3cb0d66ad41d13c05a00dfc85256f8eabafc8b3
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoMinor fixes: chmod files, rename dbus conf file, etc. 62/171862/2 accepted/tizen/unified/20180308.070156 submit/tizen/20180307.235255 submit/tizen/20180308.005943
Hyotaek Shim [Wed, 7 Mar 2018 23:50:30 +0000 (08:50 +0900)]
Minor fixes: chmod files, rename dbus conf file, etc.

Change-Id: Ia23bfea0d18dd65f9c3a7a504f0b7b4817980d89
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agodbus: modify dbus policy correctly 73/171573/8
sanghyeok.oh [Mon, 5 Mar 2018 13:23:51 +0000 (22:23 +0900)]
dbus: modify dbus policy correctly

Change-Id: I3d26b9ed55aa7462e3fa4fe3ff44a1578f595a4d
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
6 years agoblock: Add GetStatvfs dbus method 73/171273/5 accepted/tizen/unified/20180307.071336 submit/tizen/20180306.082630
pr.jung [Tue, 27 Feb 2018 09:08:34 +0000 (18:08 +0900)]
block: Add GetStatvfs dbus method

Change-Id: I2d6f6fa61a8785638624e93ee02992c880da3f70
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoAdd compile options: -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 42/171542/2
Hyotaek Shim [Mon, 5 Mar 2018 11:45:26 +0000 (20:45 +0900)]
Add compile options: -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64

Change-Id: Ieb40d80c30668673177f6ccee9e580d79b62ef6e
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoauto-test: Add auto-test for storaged 67/170667/7
pr.jung [Tue, 20 Feb 2018 05:50:02 +0000 (14:50 +0900)]
auto-test: Add auto-test for storaged

Change-Id: I272e1c869628569663da76aa377892a58a5042ba
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoChange speedcheck methods by using O_DIRECT read operations 92/171092/1
Hyotaek Shim [Mon, 26 Feb 2018 11:05:44 +0000 (20:05 +0900)]
Change speedcheck methods by using O_DIRECT read operations
to prevent corruption in existing filesystem on MicroSD card.
Further work might be required to consider optimized zero-page reads in several MicroSD cards.

Change-Id: Ic26f9c3c5396bbad7b21683d1b08a72c6a8404a3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Fix dbus method string format for GetControl 90/169790/1
pr.jung [Fri, 9 Feb 2018 06:05:28 +0000 (15:05 +0900)]
block: Fix dbus method string format for GetControl

Change-Id: Iff6538b88827af03d9622d62dcfa650d78ce2a1c
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoStraighten up the code 21/169421/1 submit/tizen/20180207.010849
pr.jung [Tue, 6 Feb 2018 11:17:26 +0000 (20:17 +0900)]
Straighten up the code

Change-Id: I8804cdf9385afcc74eda7939650bb4fff8be2973
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agodbus: change dbus library from dbus to gdbus 59/169259/6
sanghyeok.oh [Mon, 5 Feb 2018 08:17:50 +0000 (17:17 +0900)]
dbus: change dbus library from dbus to gdbus

Change-Id: I87f7fb5d88cba95f08b1927012f9b65cadc538a0
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
6 years agodbus: clean up dbus policy 19/141619/3
sanghyeok.oh [Tue, 1 Aug 2017 06:50:22 +0000 (15:50 +0900)]
dbus: clean up dbus policy

Change-Id: I2dd9e43cbfc9a5353fcf91035a684d355a50dbe2
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
6 years agoDPM: refactoring. splitting dbus response variables 05/167005/3 accepted/tizen/unified/20180115.074519 submit/tizen/20180115.052022
INSUN PYO [Mon, 15 Jan 2018 02:31:53 +0000 (11:31 +0900)]
DPM: refactoring. splitting dbus response variables

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ic4d95d570e1aed841d7c64c0f882f390283d2426

6 years agoMerge "DPM: fix bug. wrong dbus return value." into tizen submit/tizen/20180115.045329
Jung [Fri, 12 Jan 2018 04:35:06 +0000 (04:35 +0000)]
Merge "DPM: fix bug. wrong dbus return value." into tizen

6 years agoDPM: fix bug. wrong dbus return value. 14/166814/1
INSUN PYO [Fri, 12 Jan 2018 04:29:21 +0000 (13:29 +0900)]
DPM: fix bug. wrong dbus return value.

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I9e9f505976560457aeb3ee799394e51e8abde86e

6 years agoRemove tizen_build_devel_mode in the spec 55/164855/1
Hyotaek Shim [Thu, 21 Dec 2017 08:18:08 +0000 (17:18 +0900)]
Remove tizen_build_devel_mode in the spec

Change-Id: I42e6d7db925f41e9cdddc26809f6ca84fcb0c368
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Check fs_usage on retrieve_udev_device() 67/162667/3 accepted/tizen/unified/20171207.070136 submit/tizen/20171205.073503
pr.jung [Tue, 5 Dec 2017 01:35:31 +0000 (10:35 +0900)]
block: Check fs_usage on retrieve_udev_device()

- fs_usage for ext4 and vfat is filesystem and for crypto_LUKS is crypto.
- There is format requests for ext4 or vfat only. (not crypto_LUKS)

Change-Id: Ic1ceb8bc57c89f1d46a5b991a04244ddc25a727d
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Call pipe_trigger() for BLOCK_LUKS_CLOSE operation 65/162565/3 accepted/tizen/unified/20171205.060702 submit/tizen/20171204.104825
pr.jung [Mon, 4 Dec 2017 08:21:01 +0000 (17:21 +0900)]
block: Call pipe_trigger() for BLOCK_LUKS_CLOSE operation

Change-Id: I2676b017768797cc4d70bc3f20818827f4eafdfd
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: Close luks and remove block device 47/162447/1
pr.jung [Thu, 30 Nov 2017 07:23:48 +0000 (16:23 +0900)]
block: Close luks and remove block device

- Remove operation frees bdev structure

Change-Id: I138310ea793261cd0163472820eaf0abda7b1df2
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: When block is disabled, extended internal storage should not be unmounted 43/162243/3
pr.jung [Wed, 29 Nov 2017 11:03:38 +0000 (20:03 +0900)]
block: When block is disabled, extended internal storage should not be unmounted

- When block control is off,
storaged doesn't deal with mount, format, and unmount operation
storaged doesn't unmount extended internal storage
storaged only handles uevents for extended internal storage
- Mount and Foramt dbus methods for extended internal storage are blocked
- Unmount dbus method for device node is blocked
- FormatwithType dbus method for mapper node is blocked

Change-Id: I723acb5601ad6fd6f53da1dce3f408108f2e676a
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agorefactoring : remove unused parameter. 78/162278/1
INSUN PYO [Thu, 30 Nov 2017 05:58:40 +0000 (14:58 +0900)]
refactoring : remove unused parameter.

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I655750c0fde5cf606ca3195e49656891a4510980

6 years agoblock: Rearrange block_init and block_exit sequence. 46/161046/4 accepted/tizen/unified/20171123.065824 submit/tizen/20171122.101525
pr.jung [Tue, 21 Nov 2017 07:14:43 +0000 (16:14 +0900)]
block: Rearrange block_init and block_exit sequence.

- Get internal storage number on block_init().
- Call pipe_exit() after threads stop.

Change-Id: I2bbcc296448a907052d96a2486700be37a92087f
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit bb0d0846aecf8c021fd704d79f577a2d20d890b6)

6 years agoblock: Unref udev device 96/161196/1
pr.jung [Wed, 22 Nov 2017 05:46:57 +0000 (14:46 +0900)]
block: Unref udev device

Change-Id: Ibe9df053cfb7f6e0fd0bb37332057154c57ffaf4
Signed-off-by: pr.jung <pr.jung@samsung.com>
6 years agoblock: register uevent control after block_init_from_udev_enumerate() 86/160486/3
pr.jung [Thu, 16 Nov 2017 05:54:40 +0000 (14:54 +0900)]
block: register uevent control after block_init_from_udev_enumerate()

Change-Id: I1abf743b6c48c0ac706b28e1d6d53ae248340388
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
6 years agoblock: Change unmount option in remove_whole_block_device() 65/160765/1
pr.jung [Mon, 20 Nov 2017 04:46:53 +0000 (13:46 +0900)]
block: Change unmount option in remove_whole_block_device()

- UNMOUNT_NORMAL to UNMOUNT_FORCE

Change-Id: Ifa184f174d575060944e66d4dffda5cd0050b0a3
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Check booting is done when storaged handles uevent 15/160315/1
pr.jung [Wed, 15 Nov 2017 08:45:49 +0000 (17:45 +0900)]
block: Check booting is done when storaged handles uevent

- Uevent for internal storage is handled before booting is done and block_init_from_udev_enumerate() called

Change-Id: I61d48551b15707c27a41ff63cb01a8c0f47ec2c5
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoDPM support 02/159002/5 accepted/tizen/unified/20171115.061244 submit/tizen/20171115.015314
INSUN PYO [Mon, 6 Nov 2017 08:52:39 +0000 (17:52 +0900)]
DPM support

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I2cfb22bcba36f3b8b3c3a487052a228033fe5769

7 years agodbus name cleanup
INSUN PYO [Mon, 6 Nov 2017 08:39:50 +0000 (17:39 +0900)]
dbus name cleanup

7 years agoblock,app: Support extended internal storage -> portable storage setting 54/158454/5 accepted/tizen/unified/20171102.061522 submit/tizen/20171101.104249
pr.jung [Tue, 31 Oct 2017 08:13:14 +0000 (17:13 +0900)]
block,app: Support extended internal storage -> portable storage setting

- Only block type of mapper node(/dev/mapper/extendedsd) is BLOCK_EXTENDEDSD_DEV
- Not handle unformatted storage is setting on external storage using extended-sd app.
- Remove mount operation as extended internal storage when "ExtendedInternalSD" is sent as mount path (Mount dbus method)
- Support unmount operation for extended internal storage
- Add BLOCK_LUKS_CLOSE operation.
- Need to close luks when unmounting mapper node
- Register storage callback for removed signal for external storage(ex. /dev/mmcblk1p1)
- Register storage callback for mapper node
    - internal -> portable setting: Get mapper node removed signal to progress format operation for external storage.
    - portable -> internal setting: Get mapper node mounted signal to progress app ui

Change-Id: Iba8206e6e50ff2ed7df18931cd63c5c88109d049
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoRevert "Support reformatting from internal to external storage" 98/158198/5
Jung [Mon, 30 Oct 2017 09:33:29 +0000 (09:33 +0000)]
Revert "Support reformatting from internal to external storage"

This reverts commit c2ea6ef05797aaf0181c45ed5bcf03741ce76194.

Change-Id: If8fce2a3e84b393952d986b99f71ae7dc1109638

7 years agoapp: Launch setting app when "Move apps now" and "Set Default storage" button touched 07/158307/1
pr.jung [Tue, 31 Oct 2017 04:58:44 +0000 (13:58 +0900)]
app: Launch setting app when "Move apps now" and "Set Default storage" button touched

Change-Id: Id9596a1dcdeb681866bc7d5a45aa7a2884a8ec7c
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoAvoid crash on storaged UI 94/158194/1 accepted/tizen/unified/20171030.161702 submit/tizen/20171030.093838
Hyotaek Shim [Mon, 30 Oct 2017 09:07:14 +0000 (18:07 +0900)]
Avoid crash on storaged UI

Change-Id: Ib198495d8e69238fb526f772a9aea835634490c3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoCheck if ode_luke_close is done by using access(EXTENDEDSD_NODE_PATH, F_OK) 79/158179/1
Hyotaek Shim [Mon, 30 Oct 2017 08:01:49 +0000 (17:01 +0900)]
Check if ode_luke_close is done by using access(EXTENDEDSD_NODE_PATH, F_OK)

Change-Id: If135e1e74f478ea8ba2d2e154c5a823f03b5be98
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoHandle exceptional cases in request_check_speed() to avoid divide-by-zero 67/158167/2
Hyotaek Shim [Mon, 30 Oct 2017 07:32:30 +0000 (16:32 +0900)]
Handle exceptional cases in request_check_speed() to avoid divide-by-zero

Change-Id: I9ff67572cbe5b866aff2e1f49220c60271aa81b9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoSupport reformatting from internal to external storage 28/158128/6
Hyotaek Shim [Mon, 30 Oct 2017 02:50:05 +0000 (11:50 +0900)]
Support reformatting from internal to external storage

Change-Id: Idcf3befbd50de35899545cddf142865cee547cb9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoMake vcont_set_int() to be set for extendedsd 46/157646/1 accepted/tizen/unified/20171028.113737 submit/tizen/20171027.081500
Hyotaek Shim [Wed, 25 Oct 2017 11:57:45 +0000 (20:57 +0900)]
Make vcont_set_int() to be set for extendedsd

Change-Id: I97e656033855152c938d34c0aa6ec456b49335ac
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoAdd a new operation type (BLOCK_LUKS_CLOSE) 11/157611/1
Hyotaek Shim [Wed, 25 Oct 2017 09:28:53 +0000 (18:28 +0900)]
Add a new operation type (BLOCK_LUKS_CLOSE)

Change-Id: I83db5761c72df35c8b28126fff039014eacc00cf
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoUse ode_luks_close_sync() instead of ode_luks_close() 98/157598/2
Hyotaek Shim [Wed, 25 Oct 2017 08:30:17 +0000 (17:30 +0900)]
Use ode_luks_close_sync() instead of ode_luks_close()
ode_luks_close_sync() is performed at add_operation(BLOCK_DEV_REMOVE) of /dev/mmcblkX that is set up as crypto_LUKS

Change-Id: Ib4509d9b29fb2c00bed95907df92c76028fe2f63
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoRemove udev_update flag, which was used to avoid udev property update as NULL 86/157586/2
Hyotaek Shim [Wed, 25 Oct 2017 08:01:08 +0000 (17:01 +0900)]
Remove udev_update flag, which was used to avoid udev property update as NULL
(The device-mapper sync-mode patch resolved the problem(NULL update).)

Change-Id: I82381b55ab3c745d9f2a45caa6ce6d587c0c80b3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoUpdate udev properties for /dev/mapper/extendedsd by using retrieve_udev_device() 18/157318/1 submit/tizen/20171024.082141
Hyotaek Shim [Tue, 24 Oct 2017 07:26:39 +0000 (16:26 +0900)]
Update udev properties for /dev/mapper/extendedsd by using retrieve_udev_device()

Change-Id: I040d66ac070a8a62710d1113ec4e7f8a62242f38
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoUpdate bdev properties on UDEV_CHANGE 97/157297/1
Hyotaek Shim [Tue, 24 Oct 2017 06:23:52 +0000 (15:23 +0900)]
Update bdev properties on UDEV_CHANGE

Change-Id: I0e701c3aee78f372a65d1286e5a6d286dc95c66d
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock: Unmount mapper node when extended internal storage is removed 89/157089/7 accepted/tizen/unified/20171024.071451 submit/tizen/20171023.130046
pr.jung [Thu, 19 Oct 2017 05:53:49 +0000 (14:53 +0900)]
block: Unmount mapper node when extended internal storage is removed

Change-Id: I4176eaa2b5419aff67ba400734369acb3b6514d6
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoRemove MS_NOEXEC option from ext4 mount for extended internal storage 84/156684/2
Hyotaek Shim [Thu, 19 Oct 2017 11:07:14 +0000 (20:07 +0900)]
Remove MS_NOEXEC option from ext4 mount for extended internal storage

Change-Id: Ia6a0947427a68323df24e3e32cc38d2ab4f98375
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock: Launch popup when extended internal storage is inserted 53/156653/1
pr.jung [Thu, 19 Oct 2017 07:24:20 +0000 (16:24 +0900)]
block: Launch popup when extended internal storage is inserted

- Popup launchs ode ui for password

Change-Id: I872c3f52993022d23f1e35670f45c9a9946d7bdd
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit e1442c70e678b4c29cbabc04fdc9cba98a679c93)

7 years agoAdd dependency to dbus.socket in storaged.service 37/156637/1
Hyotaek Shim [Thu, 19 Oct 2017 07:47:37 +0000 (16:47 +0900)]
Add dependency to dbus.socket in storaged.service

Change-Id: I42fb8b7bdfaaf143ba9cf139df9de73f7b0c5899
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit fe9ff73d99312682c5df4b023f29d65db98ee52a)

7 years agoapp: Need to unmount sdcard before launching encryption app 48/156348/1 accepted/tizen/unified/20171019.145706 submit/tizen/20171019.034316
pr.jung [Wed, 18 Oct 2017 06:25:14 +0000 (15:25 +0900)]
app: Need to unmount sdcard before launching encryption app

Change-Id: Id01b0888d3b102e350844c2a00c7c6790b9e3a24
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 863659e8fc5e53a0edc780dc2a49f20e2fdf3470)

7 years agoFix sleep function waiting for udev properties 13/156213/1
Hyotaek Shim [Tue, 17 Oct 2017 12:06:25 +0000 (21:06 +0900)]
Fix sleep function waiting for udev properties

Change-Id: Ie893ebe310f20bcaab3630c139e1329e0167eed6
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoapp: Remove test code 06/156206/1
pr.jung [Tue, 17 Oct 2017 11:43:30 +0000 (20:43 +0900)]
app: Remove test code

- Get Primary mmc id and devpath using dbus method call

Change-Id: I0a798bad0dfb7e7ad69e986c81f37c2620c1067d
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit c670c0e89036d4f96847456b0c8f896c38503fb3)

7 years agoFix for mounting the extended internal storage (/dev/mapper/extendedsd) 92/156192/5
Hyotaek Shim [Tue, 17 Oct 2017 11:09:08 +0000 (20:09 +0900)]
Fix for mounting the extended internal storage (/dev/mapper/extendedsd)

Change-Id: Icac79f0f46d8f2baf76d0052aaac0a905e2d7985
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoapp: Launch org.tizen.ode for encryption and get signal for mapper node from storaged 42/156142/1
pr.jung [Mon, 16 Oct 2017 10:08:43 +0000 (19:08 +0900)]
app: Launch org.tizen.ode for encryption and get signal for mapper node from storaged

- Launch org.tizen.ode for extended internal storage encryption
- Wait for mapper node mounted signal (DeviceChanged)

Change-Id: I592795cd7249114c2994ab22f5ed3e259e8b1bae
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoapp: Need to launch app with launch option 41/156141/2
pr.jung [Mon, 16 Oct 2017 09:23:06 +0000 (18:23 +0900)]
app: Need to launch app with launch option

- Can skip portable / extended internal selection page

Change-Id: Ib4d1dc7e06c65ad6bccb8779c47ca271b391a352
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Mapper device should not update udev data on format operation 40/156140/1
pr.jung [Tue, 17 Oct 2017 07:41:06 +0000 (16:41 +0900)]
block: Mapper device should not update udev data on format operation

Change-Id: I2a7473272e8c6b26d66dd5de4f06879e5b0aa038
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoSupport for encrypted internal memory extension 42/129342/20
Krzysztof Jackiewicz [Fri, 22 Sep 2017 12:01:58 +0000 (14:01 +0200)]
Support for encrypted internal memory extension

- Support device mapper devices. Necessary because dmcrypt uses device mapper.
  It also requires proper udev rules for device mapper. Device mapper devices
  will be marked as BLOCK_MAPPER_DEV (previously
  BLOCK_MMC_EXTENDED_INTERNAL_DEV). Update block.conf file and related logic.

- Support different/unknown filesystems. We don't know what kind of data will
  be on sd card, but we have to be able to detect it. All sdcards are marked as
  BLOCK_MMC_DEV. Listener can distinguish cards by fs_type if needed.

- For devices with non-filesystem FS_USAGE (for example "crypto") we don't need
  2.4 backward compatibility and fixed id.

- Don't generate mount path for devices with non-filesystem FS_USAGE.

- Don't check for primary partition on device mapper devices.

- Don't check multimount for unknown filesystems.

- Trigger card setup UI for cards without LUKS or with garbage on them. Don't
  treat unformatted cards as an error.

- For internal memory extension assign the mountpoint in make_block_data() as
  in case of other types of storage.

- Don't try to mount unknown filesystems.

- In case of device mapper udev events treat "change" as "add" (perhaps this
  can be avoided by providing proper udev rules).

- Update device data when udev "change" event occurs. Formatting partition
  externally (LUKS case) requires manual udev read so that both udev and
  storaged have the actual device state. Also notify listeners about this
  change.

- Allow unmounting internal memory extension card. Not sure why it was disabled.

Change-Id: I26f98b31a24936f0b4524fc5c081163f9c9e4878
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoModify UX scenario to set up sdcard through setting apps 15/155315/3
Hyotaek Shim [Fri, 13 Oct 2017 02:09:56 +0000 (11:09 +0900)]
Modify UX scenario to set up sdcard through setting apps

Change-Id: Ib6a6bba01222b0c74ad15aff6b47e424a62b0ca9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoVFAT format with the label(emul-sdcard) in the mobile emulator 53/155253/1
Hyotaek Shim [Thu, 12 Oct 2017 12:12:06 +0000 (21:12 +0900)]
VFAT format with the label(emul-sdcard) in the mobile emulator

Change-Id: I0747f1f1540fc844c9fc90483f91cd6261f5ffb4
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock, app: Add CheckSpeed 72/154872/1
pr.jung [Wed, 11 Oct 2017 07:52:57 +0000 (16:52 +0900)]
block, app: Add CheckSpeed

- Add CheckSpeed dbus method on storaged
- App calls CheckSpeed (internal extended sdcard)

Change-Id: I90817330ce210946d9ee1a1b9fcc9895648d431c
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 645a395e3af4fa85a1f4840b76a30da154f51c93)

7 years agoRemove "Requires: %{name}-org.tizen.extended-sd" 67/154667/1 accepted/tizen/unified/20171011.150308 submit/tizen/20171011.042629 submit/tizen/20171011.074613
Hyotaek Shim [Wed, 11 Oct 2017 04:23:08 +0000 (13:23 +0900)]
Remove "Requires: %{name}-org.tizen.extended-sd"

Change-Id: Iba7f575599447169d33b3d3144ece788d55460ea
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock: Do not add INSERT operation for unformatted device (except mmc) 67/154367/2 submit/tizen/20171010.082421
pr.jung [Tue, 10 Oct 2017 06:23:49 +0000 (15:23 +0900)]
block: Do not add INSERT operation for unformatted device (except mmc)

Change-Id: I73ed8bf74b367397f25ec043d690d7caa63e7b30
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoapp: svace fix - handle NULL var 64/154264/3 accepted/tizen/unified/20171010.162512 submit/tizen/20171010.031320
sanghyeok.oh [Tue, 10 Oct 2017 02:51:11 +0000 (11:51 +0900)]
app: svace fix - handle NULL var

Change-Id: I6d2ece851362dfdbaa40e2b80d5c65d491e6956a
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoAdd "Requires: %{name}-org.tizen.extended-sd" 69/154269/1
Hyotaek Shim [Tue, 10 Oct 2017 02:22:01 +0000 (11:22 +0900)]
Add "Requires: %{name}-org.tizen.extended-sd"

Change-Id: I1efc633404818c65530f4142770466f030166fdb
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit f7aafc6095ba447bd99c621645a86609bd83199d)

7 years agoCoverity fixes. 30/153630/2
INSUN PYO [Fri, 29 Sep 2017 04:04:19 +0000 (13:04 +0900)]
Coverity fixes.

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I0e0745dbbd84ed7e76f5eb0ff4211c127dfd7687

7 years agoblock: Free th_node_list when block_exit 88/153688/2
pr.jung [Fri, 29 Sep 2017 05:32:41 +0000 (14:32 +0900)]
block: Free th_node_list when block_exit

Change-Id: Iceb902056361ee7e7d470d25cfa73706371c78e4
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Add a mutex for pipe 89/153689/1
pr.jung [Fri, 29 Sep 2017 06:24:38 +0000 (15:24 +0900)]
block: Add a mutex for pipe

- Multithread should not write pipe at the same time

Change-Id: Ic95645160e339716bdba8874d42c5aeb516aa520
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoinclude src/shared/dbus_macro.h in apps/* 46/152946/1 accepted/tizen/unified/20170929.081543 submit/tizen/20170928.010842 submit/tizen/20170928.082606
Hyotaek Shim [Wed, 27 Sep 2017 10:58:38 +0000 (19:58 +0900)]
include src/shared/dbus_macro.h in apps/*

Change-Id: I4c838338226cfada67e7913e6a8694b0e8b282d8
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoudev: Increase udev monitor buffer size 25/152725/1 accepted/tizen/unified/20170928.072235 submit/tizen/20170927.065426 submit/tizen/20170927.232123
INSUN PYO [Wed, 27 Sep 2017 02:58:06 +0000 (11:58 +0900)]
udev: Increase udev monitor buffer size

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I17054338f2b600f4a17e0b41502a565539b069a6

7 years agoudev: Increase udev monitor buffer size 34/152534/1
pr.jung [Tue, 26 Sep 2017 09:02:37 +0000 (18:02 +0900)]
udev: Increase udev monitor buffer size

Change-Id: Ieb3dffe9548530baa89c114c8ab5b9ac8c09cf52
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoudev: Do not receive G_IO_ERR flag 62/152462/1
pr.jung [Tue, 26 Sep 2017 07:41:40 +0000 (16:41 +0900)]
udev: Do not receive G_IO_ERR flag

Change-Id: I83ab9c89594c1690c54baf7bf7147add012b41e3
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 49bf0ea30237315f833274e3580797c5ddc6b97d)

7 years agoblock: Do not mount unformatted storage at booting time 52/152452/1
pr.jung [Tue, 26 Sep 2017 01:08:02 +0000 (10:08 +0900)]
block: Do not mount unformatted storage at booting time

Change-Id: I3c7608c4e76cc0fe4fcb0b21cfcc039e02aee34b
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 623c073f0783b615750a6d33f0b7ae2e4851e568)

7 years agoblock: Need to set VCONFKEY_SYSMAN_MMC_EXTENDEDINTERNAL_MOUNTED for extended internal... 50/152450/1
pr.jung [Mon, 25 Sep 2017 07:32:20 +0000 (16:32 +0900)]
block: Need to set VCONFKEY_SYSMAN_MMC_EXTENDEDINTERNAL_MOUNTED for extended internal sdcard

Change-Id: If4b596e97f0605d52113b185225ffdadda3a3ad6
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 6f9731069c7c99447548293e84fe1802a989399f)

7 years agodbus: unref reply message 20/152420/1
pr.jung [Mon, 25 Sep 2017 09:59:34 +0000 (18:59 +0900)]
dbus: unref reply message

Change-Id: Id47482a765be09f5994fd692e0366ae2c6ba4a7a
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoremove duplicated exception codes 50/151750/2 submit/tizen/20170922.080655
Hyotaek Shim [Fri, 22 Sep 2017 01:36:48 +0000 (10:36 +0900)]
remove duplicated exception codes

Change-Id: I86d3da1d03b2af52115e37e634e1be506842688f
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock: Change mount path of extended internal storage at booting time 74/150974/1
pr.jung [Tue, 19 Sep 2017 08:04:33 +0000 (17:04 +0900)]
block: Change mount path of extended internal storage at booting time

Change-Id: I862f4cc1a5d92aeb5870154e7d957fb2d9f2b74b
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoapp: Call myfiles app on Move files button callback 60/150960/1
pr.jung [Tue, 19 Sep 2017 07:35:04 +0000 (16:35 +0900)]
app: Call myfiles app on Move files button callback

Change-Id: I865ba1dc65f0801ea4747aca4375dc61aab09301
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Change /opt/extendedsd directory access permission 08/150908/1
pr.jung [Tue, 19 Sep 2017 05:28:04 +0000 (14:28 +0900)]
block: Change /opt/extendedsd directory access permission

- 770 root priv_externalstorage * -> 755 root root _

Change-Id: I2428d90e7178fd50af822aa1ff7895dc324fce0b
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit a490b2e4eb125c07771dd5084e324e73a61242a1)

7 years agoblock: Launch sdcard setting popup when sdcard is inserted after booting is done 06/150906/2
pr.jung [Tue, 19 Sep 2017 05:10:00 +0000 (14:10 +0900)]
block: Launch sdcard setting popup when sdcard is inserted after booting is done

Change-Id: Icd62e3be2d58c82d2f4afaf854590a1cf1239fed
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 7ac0b06affd5668ee06c1466d44d7a0bf10dc128)

7 years agoapp: Change async call timeout to 120sec. 05/150905/1
pr.jung [Tue, 19 Sep 2017 04:46:04 +0000 (13:46 +0900)]
app: Change async call timeout to 120sec.

Change-Id: I09f1c634cd09246fb481a7bd4d6a3d32ee629147
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 8b5a310953a56fc7281793ebb63cf79e3634d176)

7 years agoapp: Call FormatwithType asynchronously 64/150764/2
pr.jung [Mon, 18 Sep 2017 11:22:34 +0000 (20:22 +0900)]
app: Call FormatwithType asynchronously

Change-Id: I10d779bbd64d1dd6f856d650df2a42ffea9fc33e
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 0e6ed6b68508fd5fb438377cd99c443712f2b057)

7 years agoblock: Only for primary mmc, vconf key value should be valid 59/150759/2
pr.jung [Mon, 18 Sep 2017 11:19:56 +0000 (20:19 +0900)]
block: Only for primary mmc, vconf key value should be valid

Change-Id: I1b3362978d9e649cd8801d7494743bbcb8ff3350
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 4af347bc7a99dcceaa6e8953946756786e81b53b)

7 years agoblock: Add an app to setup sdcard 88/143988/19
pr.jung [Mon, 14 Aug 2017 06:24:16 +0000 (15:24 +0900)]
block: Add an app to setup sdcard

- When sdcard is inserted, extended-sd app is launched
- User can choose the usage of sdcard (portable storage or internal storage)

Change-Id: I6a6e527bff8e12d56bfe8468c72d089a81a66bda
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit 736a22188bd61ae413e548c66d5d086d573970db)

7 years agodbus: incorrect use of GetConnectionUnixProcessID method. 37/150237/1
INSUN PYO [Fri, 15 Sep 2017 01:55:08 +0000 (10:55 +0900)]
dbus: incorrect use of GetConnectionUnixProcessID method.

dbus.c: get_dbus_method_sender_pid(169) > no message : [org.freedesktop.DBus.Error.InvalidArgs:Argument 0 is specified to be of type "int32", but is actually of type "uint32"

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ia1dbe36ae55cd3b24000f406e135d318d4163362

7 years agoApply Tizen Coding Rule 39/149239/3 accepted/tizen/unified/20170913.071536 submit/tizen/20170912.090438
pr.jung [Tue, 12 Sep 2017 02:28:02 +0000 (11:28 +0900)]
Apply Tizen Coding Rule

Change-Id: I8bad9418fc390b46879403fc6bd96dafd51e0991
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Format as ext4 filesystem when request is for extended internal storage 48/131248/8
pr.jung [Wed, 10 May 2017 10:12:31 +0000 (19:12 +0900)]
block: Format as ext4 filesystem when request is for extended internal storage

Change-Id: Ia00b45e1306b6aeda266a915c21d7514263c0182
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
7 years agoblock: Checking calloc failed 32/148432/3 accepted/tizen/unified/20170908.220714 submit/tizen/20170908.052651
pr.jung [Fri, 8 Sep 2017 02:31:33 +0000 (11:31 +0900)]
block: Checking calloc failed

Change-Id: Icad2dd4c3580793d4ce6838210b62df00d7a3c08
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Only for primary mmc, vconf key value should be valid 58/146958/4
pr.jung [Thu, 31 Aug 2017 08:38:23 +0000 (17:38 +0900)]
block: Only for primary mmc, vconf key value should be valid

Change-Id: I7923441baa51517e304d78bcf07d392ff933223c
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Create file when sdcard is inserted 86/141086/2 accepted/tizen/4.0/unified/20170816.011942 accepted/tizen/4.0/unified/20170816.015025 accepted/tizen/4.0/unified/20170829.020438 accepted/tizen/unified/20170731.020634 submit/tizen/20170728.063117 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0/20170828.100004 submit/tizen_4.0_unified/20170814.115522
pr.jung [Fri, 28 Jul 2017 06:16:49 +0000 (15:16 +0900)]
block: Create file when sdcard is inserted

Change-Id: Ia430af302ac7df92aa916313c73f3bd4d7fc26a9
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Check return value of mnt_fs_get_srcpath 67/132867/1 accepted/tizen/unified/20170608.184603 submit/tizen/20170608.051314
pr.jung [Thu, 8 Jun 2017 04:58:59 +0000 (13:58 +0900)]
block: Check return value of mnt_fs_get_srcpath

Change-Id: Ib5f35b3a5a0a8eba50d4add92fed9e65c6148b74
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Prevent buffer overflow 63/132663/1
pr.jung [Wed, 7 Jun 2017 06:00:15 +0000 (15:00 +0900)]
block: Prevent buffer overflow

- Specify a limit on the input string length
when using s with '%' format specifies for scanf-like functions

Change-Id: I7406565b9d834763784ff8c18bdd9cf31119536d
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Change sizeof to strlen to get length of devnode 43/127043/1 accepted/tizen/unified/20170426.195755 submit/tizen/20170426.042525 tizen_4.0.m1_release
pr.jung [Wed, 26 Apr 2017 02:49:07 +0000 (11:49 +0900)]
block: Change sizeof to strlen to get length of devnode

Change-Id: I0af1a7e100917f873c128af63f6796aef217059f
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock, storage: Recevie StartupFinished signal instead of BootingDone signal 36/126536/1 accepted/tizen/unified/20170425.044934 submit/tizen/20170424.085953
pr.jung [Mon, 24 Apr 2017 05:50:51 +0000 (14:50 +0900)]
block, storage: Recevie StartupFinished signal instead of BootingDone signal

- Systemd sends StartupFinished signal when system session is ready.
- Receive StartupFinished(systemd) signal instaed of BootingDone(deviced) signal.

Change-Id: I4f31c437f2dbe5811a20d6ba38407b95bc78fb6f
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Add ExtendedInternalStorage configuration 36/123536/5 accepted/tizen/unified/20170413.162741 submit/tizen/20170413.022542
pr.jung [Thu, 6 Apr 2017 04:40:52 +0000 (13:40 +0900)]
block: Add ExtendedInternalStorage configuration

- When sdcard is inserted, user needs to choose which way to use.
(External storage or extended internal storage)
- BLOCK_MMC_EXTENDED_INTERNAL_DEV is added on block_device_type

Change-Id: I33e200a74ce16d7b74eb498d0e8ccad15a9a8e8b
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agomodule : change the plugin path according to the library of arch. 25/124625/1 accepted/tizen/unified/20170412.152524 submit/tizen/20170412.041900
wchang kim [Wed, 12 Apr 2017 04:05:52 +0000 (13:05 +0900)]
module : change the plugin path according to the library of arch.

Change-Id: Ib2bfd2842aab2677e39efddd6a014c757ba1e34a

7 years agocommon: Not handle missing method 89/124389/3
pr.jung [Tue, 11 Apr 2017 08:08:23 +0000 (17:08 +0900)]
common: Not handle missing method

- If there is method call with not implemented method,
it is not handled and return DBUS_HANDLER_RESULT_NOT_YET_HANDLED

Change-Id: I46e24e2a71e7b29f589705ac7a5439b8c7c6e755
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agocommon: Do not warn about uses of functions, variables, and types marked as deprecate... 91/124591/1
pr.jung [Wed, 12 Apr 2017 01:34:57 +0000 (10:34 +0900)]
common: Do not warn about uses of functions, variables, and types marked as deprecated by using the deprecated attribute.

Change-Id: Ic026783cad4b571d7bd02790a28ae93cc734c7c1
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoblock: Should not free block device when add mount operation is failed 82/124382/1
pr.jung [Tue, 11 Apr 2017 07:34:04 +0000 (16:34 +0900)]
block: Should not free block device when add mount operation is failed

- Add insert operation is succeed, so if main thread free block device,
then block thread can't use block device

Change-Id: Ia37923a433b3f62f4c584df1390bdd18241d2c3d
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agocommon: Remove readdir 84/124184/4 accepted/tizen/unified/20170411.164111 submit/tizen/20170411.050818
pr.jung [Mon, 10 Apr 2017 11:25:32 +0000 (20:25 +0900)]
common: Remove readdir

- readdir makes no guarantee of thread safety
- Use readdir_r instead

Change-Id: I0a5c3e6bcabe1ef76291a58dd756a99a5a4a95d0
Signed-off-by: pr.jung <pr.jung@samsung.com>
7 years agoMerge "common: Increase refcount for DBusMessage" into tizen accepted/tizen/unified/20170407.190717 submit/tizen/20170407.050303
pr.jung [Fri, 7 Apr 2017 05:01:17 +0000 (22:01 -0700)]
Merge "common: Increase refcount for DBusMessage" into tizen

7 years agocommon: Increase refcount for DBusMessage 93/123793/1
pr.jung [Fri, 7 Apr 2017 04:33:22 +0000 (13:33 +0900)]
common: Increase refcount for DBusMessage

- DBusMessage should not be freed when result is null
- Refcount is decreased on reply_dbus_method_result

Change-Id: I712790950f42514377e9d39deecb0388e784b0c7
Signed-off-by: pr.jung <pr.jung@samsung.com>