platform/upstream/gstreamer.git
4 years agowpe: Move webview load waiting to WPEView
Philippe Normand [Thu, 10 Sep 2020 13:39:58 +0000 (14:39 +0100)]
wpe: Move webview load waiting to WPEView

As waiting for the load to be finished is specific to the WebView, it should be
done from our WPEView, not from the WPEContextThread. This fixes issues where
multiple wpesrc elements are created in sequence. Without this patch the first
view might receive erroneous buffer notifications.

Fixes #1386

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1568>

4 years agoaudiobuffersplit: Add support for specifying output buffer size
Sanchayan Maity [Fri, 11 Sep 2020 12:47:20 +0000 (18:17 +0530)]
audiobuffersplit: Add support for specifying output buffer size

Currently for buffer splitting only output duration can be specified.
Allow specifying a buffer size in bytes for splitting.

Consider a use case of the below pipeline
appsrc ! rptL16pay ! capsfilter ! rtpbin ! udpsink

Maintaining MTU for RTP transfer is desirable but in a scenario
where the buffers being pushed to appsrc do not adhere to this,
an audiobuffersplit element placed between appsrc and rtpL16pay
with output buffer size specified considering the MTU can help
mitigate this.

While rtpL16pay already has a MTU setting, in case of where an
incoming buffer has a size close to MTU, for eg. with a MTU of
1280, a buffer of size 1276 bytes would be split into two buffers,
one of 1268 and other of 8 bytes considering RTP header size of
12 bytes. Putting audiobuffersplit between appsrc and rtpL16pay
can take care of this.

While buffer duration could still be used being able to specify
the size in bytes is helpful here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1578>

4 years agowpe: Use proper callback for TLS errors signal handling
Philippe Normand [Thu, 10 Sep 2020 12:05:23 +0000 (13:05 +0100)]
wpe: Use proper callback for TLS errors signal handling

The load-failed and load-failed-with-tls-errors signals expect distinct callback
signatures.

Fixes #1388

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1566>

4 years agova: h264dec: add documentation
Víctor Manuel Jáquez Leal [Sun, 20 Sep 2020 06:31:23 +0000 (08:31 +0200)]
va: h264dec: add documentation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1585>

4 years agomsdk: enable GPUCopy
Haihao Xiang [Tue, 10 Dec 2019 11:54:43 +0000 (19:54 +0800)]
msdk: enable GPUCopy

Note it works for system memory only

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/910>

4 years agomsdk: call MFXInitEx instead of MFXInit
Haihao Xiang [Tue, 10 Dec 2019 11:47:03 +0000 (19:47 +0800)]
msdk: call MFXInitEx instead of MFXInit

MFXInitEx has more control than MFXInit. The current setting in this
commit is identical to MFXInit

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/910>

4 years agova: decoder: render picture only if data
Víctor Manuel Jáquez Leal [Sat, 19 Sep 2020 12:08:46 +0000 (14:08 +0200)]
va: decoder: render picture only if data

Call vaRenderPicture() only if buffer or slice data is available.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1584>

4 years agova: decoder: warn if decode fails on a surface
Víctor Manuel Jáquez Leal [Thu, 17 Sep 2020 17:54:28 +0000 (19:54 +0200)]
va: decoder: warn if decode fails on a surface

Instead of logging error if a step fails, it logs a warning message
reducing the noise and obeying the rule for errors since the program
doesn't end

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1584>

4 years agova: h264dec: check is pad has fixed caps at caps query
Víctor Manuel Jáquez Leal [Thu, 17 Sep 2020 17:52:29 +0000 (19:52 +0200)]
va: h264dec: check is pad has fixed caps at caps query

Otherwise it will always reply with the possible driver caps, which
generates problems with Web MSE players.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1583>

4 years agova: h264dec: Don't need to set pts/dts/duration on outputting frame
Seungha Yang [Fri, 18 Sep 2020 20:39:32 +0000 (05:39 +0900)]
va: h264dec: Don't need to set pts/dts/duration on outputting frame

It will be handled by videodecoder baseclass

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1582>

4 years agowebrtcbin: Accept end-of-candidate pass it to libnice
Olivier Crête [Thu, 26 Mar 2020 00:50:01 +0000 (20:50 -0400)]
webrtcbin: Accept end-of-candidate pass it to libnice

libnice now supports the concept of end-of-candidate, so use the API
for it. This also means that if you don't do that, the webrtcbin will
never declared the connection as failed.

This requires bumping the dependency to libnice 0.1.16

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1139>

4 years agokmssink: Do not source using padded width/height
Nicolas Dufresne [Thu, 17 Sep 2020 21:39:25 +0000 (17:39 -0400)]
kmssink: Do not source using padded width/height

The width/height from the video meta can be padded width, height. But when
sourcing from padded buffer, we only want to use the valid pixels. This
rectangle is from the crop meta, orther it is deduces from the caps. The width
and height from the caps is save in the parent class, use these instead of the
GstVideoInfo when settting the src rectangle.

This fixes an issue with 1080p video displaying repeated or green at the
padded bottom 8 lines (seen with v4l2codecs).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1580>

4 years agod3d11: Add support for packed 8bits 4:2:2 YUV formats
Seungha Yang [Thu, 17 Sep 2020 16:41:35 +0000 (01:41 +0900)]
d3d11: Add support for packed 8bits 4:2:2 YUV formats

Note that newly added formats (YUY2, UYVY, and VYUY) are not supported
render target view formats. So such formats can be only input of d3d11convert
or d3d11videosink. Another note is that YUY2 format is a very common
format for hardware en/decoders on Windows.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1581>

4 years agowebrtcbin: Merge the RTX SSRCs from all transceivers when bundling
Olivier Crête [Wed, 26 Aug 2020 21:48:06 +0000 (17:48 -0400)]
webrtcbin: Merge the RTX SSRCs from all transceivers when bundling

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1545>

4 years agoavtp: avtpaafdepay: fix crash when building caps
Marian Cichy [Tue, 15 Sep 2020 15:09:57 +0000 (17:09 +0200)]
avtp: avtpaafdepay: fix crash when building caps

gst_caps_new_simple gets wrong types for rate and channel which
may lead to a crash.

As 64-bit values for rate, depth, format, channels does not
make much sense and since any other functionality in gstreamer
expects G_TYPE_INT for channels and rate, we should stick to that

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1576>

4 years agoh265parse: recognize more HEVC extension streams
Haihao Xiang [Tue, 9 Jun 2020 02:10:12 +0000 (10:10 +0800)]
h265parse: recognize more HEVC extension streams

There are streams which have the right general_profile_idc and
general_profile_compatibility_flag, but don't have the right extension
flags. We may try to use chroma_format_idc and bit_depth to
recognize these streams.

e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/IBF_Disabled_A_MediaTek_2.zip

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328>

4 years agoh265parser: select the right profile for high throughput SCC stream
Haihao Xiang [Fri, 5 Jun 2020 05:01:06 +0000 (13:01 +0800)]
h265parser: select the right profile for high throughput SCC stream

Currently screen-extended-high-throughput-444 is recognized as
screen-extended-main-444, screen-extended-high-throughput-444-10 is
recognized as screen-extended-main-444-10 because they have the same
extension flags, so without this patch, it is possible that a decoder
which supports SCC but doesn't support throughput SCC will try to decode
a throughput SCC stream.

e.g.
https://www.itu.int/wftp3/av-arch/jctvc-site/bitstream_exchange/draft_conformance/SCC/HT_A_SCC_Apple_2.zip

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1328>

4 years agomsdk: vpp: fixup passthrough checking for DMA
Randy Li (ayaka) [Tue, 8 Sep 2020 06:43:49 +0000 (14:43 +0800)]
msdk: vpp: fixup passthrough checking for DMA

I think it is just a typo from e1a90f1ec9
msdkvpp: Disable passthrough if memory capsfeature changes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1559>

4 years agowaylandsink: Use memfd_create() when available
Emmanuel Gil Peyrot [Tue, 15 Sep 2020 15:51:51 +0000 (17:51 +0200)]
waylandsink: Use memfd_create() when available

This (so-far) Linux- and FreeBSD-only API lets users create file
descriptors purely in memory, without any backing file on the filesystem
and the race condition which could ensue when unlink()ing it.

It also allows seals to be placed on the file, ensuring to every other
process that we won’t be allowed to shrink the contents, potentially
causing a SIGBUS when they try reading it.

This patch is best viewed with the -w option of git log -p.

It is an almost exact copy of Wayland commit
6908c8c85a2e33e5654f64a55cd4f847bf385cae, see
https://gitlab.freedesktop.org/wayland/wayland/merge_requests/4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1577>

4 years agocodecs: vp9decoder: Relying on upstream vp9parse for super frame handling
Seungha Yang [Thu, 10 Sep 2020 12:19:43 +0000 (21:19 +0900)]
codecs: vp9decoder: Relying on upstream vp9parse for super frame handling

By this way, we can simplify the decoding flow. Moreover, we don't
need to worry about the case where multiple visible-frames are
composed in one super-frame, since upstream vp9parse will split
them per frame unit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>

4 years agocodecs: vp9decoder: Remove unused pts variable
Seungha Yang [Thu, 10 Sep 2020 12:42:49 +0000 (21:42 +0900)]
codecs: vp9decoder: Remove unused pts variable

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>

4 years agod3d11vp9dec: Don't need to consider output_picture() call without GstVideoCodecFrame
Seungha Yang [Fri, 11 Sep 2020 15:12:03 +0000 (00:12 +0900)]
d3d11vp9dec: Don't need to consider output_picture() call without GstVideoCodecFrame

Baseclass will be updated in order to ensure GstVideoCodecFrame.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>

4 years agod3d11vp9dec: Specify profile and alignment on sink template
Seungha Yang [Thu, 10 Sep 2020 11:32:13 +0000 (20:32 +0900)]
d3d11vp9dec: Specify profile and alignment on sink template

Set supported profile(s) on sink template caps, so that decodebin
can filter out this element if profile of given vp9 stream is not
supported by hardware decoder.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>

4 years agod3d11decoder: Cleanup code
Seungha Yang [Thu, 10 Sep 2020 12:31:38 +0000 (21:31 +0900)]
d3d11decoder: Cleanup code

* Don't need to set pts/dts/duration on output buffer of frame.
  it's handled by baseclass
* Remove meaningless debug output

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1567>

4 years agocodecs: h264decoder: Calculate and set latency
Víctor Manuel Jáquez Leal [Sat, 22 Aug 2020 10:44:16 +0000 (12:44 +0200)]
codecs: h264decoder: Calculate and set latency

Add gst_h264_decoder_set_latency(), which calculates and sets
latency on base decoder class, after new_sequence is called.

This assumes that in new_sequence() vmethod, callee negotiates
downstream caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1531>

4 years agoRevert "va: h264dec: set latency"
Víctor Manuel Jáquez Leal [Sat, 22 Aug 2020 10:47:23 +0000 (12:47 +0200)]
Revert "va: h264dec: set latency"

This reverts commit 3aedef4c8601dcafb065d8095a927f1cd528056f.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1531>

4 years agovalidate: plug leak in gssdp
Jordan Petridis [Mon, 14 Sep 2020 11:42:36 +0000 (14:42 +0300)]
validate: plug leak in gssdp

These are triggered by the webrtcbin tests

https://gitlab.gnome.org/GNOME/gssdp/-/issues/10

4 years agotsdemux: Parse Audio Preselection Descriptor
yychao [Fri, 4 Sep 2020 15:34:16 +0000 (23:34 +0800)]
tsdemux: Parse Audio Preselection Descriptor

For Dolby AC4 audio experience, parsing PMTs/APD from transport stream layer for all available presentations.
Refer to ETSI EN 300 468 V1.16.1 (2019-05)

1. 6.4.1 Audio preselection descriptor
2. Table M.1: Mapping of codec specific values to the audio preselection descriptor

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1555>

4 years agotsdemux: Add new API for fetching extended descriptors
yychao [Fri, 4 Sep 2020 15:28:58 +0000 (23:28 +0800)]
tsdemux: Add new API for fetching extended descriptors

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1555>

4 years agowebrtc: propagate more errors through the promise
Matthew Waters [Wed, 26 Aug 2020 05:45:35 +0000 (15:45 +1000)]
webrtc: propagate more errors through the promise

Return errors on promises when things fail where available.

Things like parsing errors, invalid states, missing fields, unsupported
transitions, etc.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1565>

4 years agomeson: Do not warn when a windowing system is not found
Nirbheek Chauhan [Wed, 1 Jul 2020 02:05:08 +0000 (07:35 +0530)]
meson: Do not warn when a windowing system is not found

Error out when the vulkan option is enabled, and just print
a message() otherwise. This is more correct and also allows us to pass
--fatal-meson-warnings more reliably.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1391>

4 years agoopencv: set opencv_dep when option is disabled (#1406)
Adam Williamson [Thu, 10 Sep 2020 17:35:11 +0000 (10:35 -0700)]
opencv: set opencv_dep when option is disabled (#1406)

The examples build file checks opencv_dep, so it still needs to
be set even if the option is disabled.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1406

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1570>

4 years agoopenh264dec: port to new request_sync_point() API
Mathieu Duponchelle [Thu, 10 Sep 2020 21:12:10 +0000 (23:12 +0200)]
openh264dec: port to new request_sync_point() API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1571>

4 years agoh264decoder: Fix various typos
Nicolas Dufresne [Tue, 28 Jul 2020 22:32:03 +0000 (18:32 -0400)]
h264decoder: Fix various typos

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1563>

4 years agov4l2slh264dec: Minor cleanup
Nicolas Dufresne [Tue, 28 Jul 2020 22:39:52 +0000 (18:39 -0400)]
v4l2slh264dec: Minor cleanup

Move few variables in their respective scope.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1563>

4 years agov4l2slh264dec: Fix B-Frame weight table
Nicolas Dufresne [Wed, 22 Jul 2020 19:40:14 +0000 (15:40 -0400)]
v4l2slh264dec: Fix B-Frame weight table

We where not setting the luma l1 weight table.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1563>

4 years agovideoparsers: Add vp9parse element
Seungha Yang [Wed, 9 Sep 2020 12:38:33 +0000 (21:38 +0900)]
videoparsers: Add vp9parse element

Adding vp9parse element to parse various stream information such as
resolution, profile, and so on. If upstream does not provide resolution and/or
profile, this would be useful for decodebin pipeline for autoplugging
suitable decoder element depending on template caps of each decoder element.

In addition, vp9parse element supports unpacking superframe into
single frame for decoders. The vp9 superframe is a frame which consists
of multiple frames (or superframe with one frame is allowed) followed by superframe
index block. Then unpacked each frame will be considered as normal frame
by decoder. The decision for unpacking will be done by downstream element's
"alignment" caps field, which can be "super-frame" or "frame".
If downstream specifies the "alignment" as "frame",
then vp9parse element will split an incoming superframe into single frames
and the superframe index (located at the end of the superframe) data
will be discarded by vp9parse element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1041>

4 years agomfvideosrc: Set timestamp on buffer when it's captured
Seungha Yang [Tue, 16 Jun 2020 12:09:36 +0000 (21:09 +0900)]
mfvideosrc: Set timestamp on buffer when it's captured

Capture the timestamp immediately when new frame is arrived,
instead of doing that on ::create() method. There would be
time gap between captured time and outputting time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1351>

4 years agoline21enc: add remove-caption-meta property
Mathieu Duponchelle [Fri, 4 Sep 2020 14:53:03 +0000 (16:53 +0200)]
line21enc: add remove-caption-meta property

Similar to #GstCCExtractor:remove-caption-meta

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1554>

4 years agoline21enc: heavily constrain video height
Mathieu Duponchelle [Fri, 4 Sep 2020 00:38:58 +0000 (02:38 +0200)]
line21enc: heavily constrain video height

We can only determine a correct placement for the CC line
with:

* height == 525 (standard NTSC, line 21 / 22)
* height == 486 (NTSC usable lines + 6 lines for VBI, line 1 / 2)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1554>

4 years agoline21enc: add support for CDP closed caption meta
Mathieu Duponchelle [Fri, 4 Sep 2020 00:33:52 +0000 (02:33 +0200)]
line21enc: add support for CDP closed caption meta

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1554>

4 years agoadaptivedemux: Add another nominal bitrate fallback calculation
Edward Hervey [Thu, 27 Aug 2020 09:23:01 +0000 (11:23 +0200)]
adaptivedemux: Add another nominal bitrate fallback calculation

Some HTTP servers don't provide fragment sizes (with the Content-Length HTTP
header). In order to still figure out a nominal bitrate (for usage by queue2),
calculate on when we're done downloading a fragment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1544>

4 years agoadaptivedemux: Handle invalid HTTP duration
Edward Hervey [Thu, 27 Aug 2020 09:18:56 +0000 (11:18 +0200)]
adaptivedemux: Handle invalid HTTP duration

The default BYTE DURATION basesrc query handler will return `-1` and TRUE. In
order to properly handle cases where upstream http servers didn't return a valid
Content-Length we also need to check whether it was valid when calculating
bitrates.

Avoids returning completely bogus bitrates with gogol's video streaming services

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1544>

4 years agomfvideoenc: Add support for zero-copy encoding
Seungha Yang [Wed, 12 Aug 2020 11:31:32 +0000 (20:31 +0900)]
mfvideoenc: Add support for zero-copy encoding

Add custom IMFMediaBuffer and IMF2DBuffer implementation in order to
keep track of lifecycle of Media Foundation memory object.
By this new implementation, we can pass raw memory of upstream buffer
to Media Foundation without copy.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1518>

4 years agortmp2: Replace stats queue with stats lock
Jan Alexander Steffens (heftig) [Tue, 1 Sep 2020 11:28:44 +0000 (13:28 +0200)]
rtmp2: Replace stats queue with stats lock

Making the thread receiving the stats wait on the loop to respond was
not a good idea, as the latter can get blocked on the streaming thread.

Have get_stats read the values directly, adding a lock to ensure we
don't read garbage.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1550>

4 years agortmp2sink: add docs section with since marker on new stop-commands property
Nazar Mokrynskyi [Wed, 19 Aug 2020 11:51:17 +0000 (14:51 +0300)]
rtmp2sink: add docs section with since marker on new stop-commands property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256>

4 years agortmp2: fix code style, update documentation cache
Nazar Mokrynskyi [Tue, 18 Aug 2020 16:16:40 +0000 (19:16 +0300)]
rtmp2: fix code style, update documentation cache

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256>

4 years agortmp2: Clean up (improve) GstRtmpStopCommands type
Jan Alexander Steffens (heftig) [Tue, 18 Aug 2020 12:05:26 +0000 (14:05 +0200)]
rtmp2: Clean up (improve) GstRtmpStopCommands type

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256>

4 years agortmp2sink: handle EOS event and close stream
Nazar Mokrynskyi [Sat, 2 May 2020 01:49:42 +0000 (04:49 +0300)]
rtmp2sink: handle EOS event and close stream

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1285

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1256>

4 years agompegtsmux: Make handling of sinkpads thread-safe
Jan Alexander Steffens (heftig) [Wed, 2 Sep 2020 13:29:49 +0000 (15:29 +0200)]
mpegtsmux: Make handling of sinkpads thread-safe

Ensure we take the object lock while accessing `GstElement.sinkpads`.
Use an iterator when the code isn't simple to avoid deadlock.

When we find the best pad, take a reference so a concurrent pad
release doesn't destroy the pad before we're done with it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1553>

4 years agohlssink2: Actually release splitmuxsink's pads
Jan Alexander Steffens (heftig) [Tue, 1 Sep 2020 11:29:30 +0000 (13:29 +0200)]
hlssink2: Actually release splitmuxsink's pads

It was looking at the "outer" peer of the ghost pad, not the "inner"
peer (the target).

It provided the wrong pad to gst_element_release_request_pad.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1551>

4 years agompegtsmux: Don't create streams with reserved PID
Edward Hervey [Tue, 8 Sep 2020 08:48:56 +0000 (10:48 +0200)]
mpegtsmux: Don't create streams with reserved PID

There are quite a few reserved PID in the various MPEG-TS (and derivate)
specifications which we should definitely not use. Those PID have a certain
meaning and purpose.

Furthermore, a lot of the code in the muxer implementation also makes assumption
on the purpose of streams based on their PID.

Therefore, when requesting a pad with a specific PID, make sure it is not a
restricted PID.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1561>

4 years agoci: include template from gst-ci master branch again
Tim-Philipp Müller [Tue, 8 Sep 2020 16:30:42 +0000 (17:30 +0100)]
ci: include template from gst-ci master branch again

4 years agoBack to development
Tim-Philipp Müller [Tue, 8 Sep 2020 15:58:50 +0000 (16:58 +0100)]
Back to development

4 years agoRelease 1.18.0
Tim-Philipp Müller [Mon, 7 Sep 2020 23:07:45 +0000 (00:07 +0100)]
Release 1.18.0

4 years agomeson: dist pot file in tarball
Tim-Philipp Müller [Mon, 7 Sep 2020 21:48:27 +0000 (22:48 +0100)]
meson: dist pot file in tarball

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1558>

4 years agogst: Update for gst_video_transfer_function_*() function renaming
Sebastian Dröge [Mon, 7 Sep 2020 09:14:47 +0000 (12:14 +0300)]
gst: Update for gst_video_transfer_function_*() function renaming

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1557>

4 years agotests: mpegtsmux: Test that we can manipulate pads after stop
Jan Alexander Steffens (heftig) [Tue, 1 Sep 2020 13:05:07 +0000 (15:05 +0200)]
tests: mpegtsmux: Test that we can manipulate pads after stop

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1552>

4 years agompegtsmux: Keep mux usable after stop
Jan Alexander Steffens (heftig) [Tue, 1 Sep 2020 12:56:55 +0000 (14:56 +0200)]
mpegtsmux: Keep mux usable after stop

Otherwise you cannot request new pads until after it is started again.

gst_base_ts_mux_reset with FALSE is still called in the dispose
implementation, so the muxer still gets deallocated when we actually
clean up.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1552>

4 years agomsdkvp9dec: change the include header order
Haihao Xiang [Tue, 1 Sep 2020 05:32:44 +0000 (13:32 +0800)]
msdkvp9dec: change the include header order

This fixes the compiler error when MFX_VERSION_USE_LATEST is defined in
the SDK.

/usr/include/mfx/mfxvp9.h:48:5: error: unknown type name ‘mfxExtBuffer’
     mfxExtBuffer Header;

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1549>

4 years agortmp2: Need to unescape the userinfo before setting
Nirbheek Chauhan [Fri, 28 Aug 2020 21:12:12 +0000 (02:42 +0530)]
rtmp2: Need to unescape the userinfo before setting

This regressed in 827afa206d8c9675f2a7af402396552c2ed1df09. The same
fix was also committed to the webrtc element, but rtmp2 was missed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1547>

4 years agowebrtc: Clean up the userinfo unescaping code
Nirbheek Chauhan [Fri, 28 Aug 2020 21:10:44 +0000 (02:40 +0530)]
webrtc: Clean up the userinfo unescaping code

Continuation from 04fd705906f4bd4cf1901001484e60c21e1b3139. This is
easier to understand and also avoids two copies.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1547>

4 years agodshowsrcwrapper: Update build instructions. Add _builddir to include search path.
Jérôme Laheurte [Tue, 25 Aug 2020 08:04:53 +0000 (10:04 +0200)]
dshowsrcwrapper: Update build instructions. Add _builddir to include search path.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1537>

4 years agomodplug: avoid division by zero
Jonathan Matthew [Thu, 27 Aug 2020 21:53:26 +0000 (07:53 +1000)]
modplug: avoid division by zero

Under some conditions, GetMaxPosition() returns zero, which should cause
position queries to fail rather than crash.

4 years agowebrtc: Unescape turnserver user and password
trilene [Fri, 21 Aug 2020 22:40:59 +0000 (18:40 -0400)]
webrtc: Unescape turnserver user and password

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1530>

4 years agomeson: allow the user to disable opencv
Fabrice Fontaine [Sat, 22 Aug 2020 21:33:48 +0000 (23:33 +0200)]
meson: allow the user to disable opencv

Allow the user to really disable opencv through meson (i.e.
-Dopencv=disabled).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1533>

4 years agosctp: usrsctp: increase DIAG_MSG_LEN to accomodate longer file path
Tim-Philipp Müller [Tue, 25 Aug 2020 22:46:16 +0000 (23:46 +0100)]
sctp: usrsctp: increase DIAG_MSG_LEN to accomodate longer file path

Fixes "‘%s’ directive output truncated writing XX bytes into
a region of size NN [-Wformat-truncation=]" compiler warnings.

https://github.com/sctplab/usrsctp/pull/521

Fixes #1389

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1540>

4 years agodshowsrcwrapper: fix typo in variable name
Jérôme Laheurte [Tue, 25 Aug 2020 08:49:11 +0000 (10:49 +0200)]
dshowsrcwrapper: fix typo in variable name

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1538>

4 years agovulkan: fix the enumtypes install path
Wim Taymans [Fri, 21 Aug 2020 14:28:42 +0000 (16:28 +0200)]
vulkan: fix the enumtypes install path

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1528>

4 years agowpe: skip glbasesrc decide_allocation when non-GL caps are negotiated
Philippe Normand [Sat, 22 Aug 2020 13:38:38 +0000 (14:38 +0100)]
wpe: skip glbasesrc decide_allocation when non-GL caps are negotiated

Checking for GL caps features in gl_start() was done too late in case the parent
class fails to setup a working GL context. The element now determines if GL
support should be enabled during the decide-allocation query handling.

Additionally, when no GL context was found, we need to handle the element
cleanup because in that situation glbasesrc won't call gl_stop.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1376

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1532>

4 years agocodecs: h264decoder: Fix possible GstH264Picture leak and small cleanup
Seungha Yang [Fri, 21 Aug 2020 13:48:48 +0000 (22:48 +0900)]
codecs: h264decoder: Fix possible GstH264Picture leak and small cleanup

Don't leak pictures when dpb is full unexpectedly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1527>

4 years agod3d11videosink: Fix crash caused by missing null termination
Seungha Yang [Thu, 20 Aug 2020 17:36:13 +0000 (02:36 +0900)]
d3d11videosink: Fix crash caused by missing null termination

gst_caps_features_new() must be null terminated.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1524>

4 years agova: allocator: remove parameter from _create_buffer_surface()
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 14:50:46 +0000 (16:50 +0200)]
va: allocator: remove parameter from _create_buffer_surface()

Don't the allocator to _create_buffer_surface() since it's not used.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: utils: free allocated string
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 15:18:26 +0000 (17:18 +0200)]
va: utils: free allocated string

and fix a memleak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: utils: fix log category initialization
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 07:05:00 +0000 (09:05 +0200)]
va: utils: fix log category initialization

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: h264dec: check va allocator at decide allocation
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 09:39:46 +0000 (11:39 +0200)]
va: h264dec: check va allocator at decide allocation

And some code cleanups

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: decoder: improve locks for member variable access
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 09:38:46 +0000 (11:38 +0200)]
va: decoder: improve locks for member variable access

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agowebrtc/datachannel: clear the error after use
Matthew Waters [Mon, 24 Aug 2020 07:01:59 +0000 (17:01 +1000)]
webrtc/datachannel: clear the error after use

Fixes a memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agowebrtc/datachannel: free previous protocol/label fields
Matthew Waters [Mon, 24 Aug 2020 07:01:22 +0000 (17:01 +1000)]
webrtc/datachannel: free previous protocol/label fields

Fixes a memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agotests/webrtc: unref GBytes after use
Matthew Waters [Mon, 24 Aug 2020 07:00:30 +0000 (17:00 +1000)]
tests/webrtc: unref GBytes after use

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agosctpdec: unref after retrieving the static pad template
Matthew Waters [Mon, 24 Aug 2020 06:58:41 +0000 (16:58 +1000)]
sctpdec: unref after retrieving the static pad template

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agoRelease 1.17.90
Tim-Philipp Müller [Thu, 20 Aug 2020 15:14:23 +0000 (16:14 +0100)]
Release 1.17.90

4 years agowebrtc/ice: resolve .local candidates internally
Matthew Waters [Thu, 20 Aug 2020 02:58:30 +0000 (12:58 +1000)]
webrtc/ice: resolve .local candidates internally

Requires the system's DNS resolver to support mdns resolution.

Fixes interoperablity with recent versions of chrome/firefox that
produce .local address in for local candidates.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1139

4 years agosrtobject: set error when canceled waiting for a caller
J. Kim [Wed, 19 Aug 2020 11:46:31 +0000 (11:46 +0000)]
srtobject: set error when canceled waiting for a caller

To propagate error, this commit sets a reason. Otherwise, the function
caller should check if `error` is NULL when the return value is not normal.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1522>

4 years agosrtobject: fix typo, s/errorj/error
J. Kim [Wed, 19 Aug 2020 11:30:47 +0000 (11:30 +0000)]
srtobject: fix typo, s/errorj/error

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1522>

4 years agodocs: fix gst-docs build if opencv is not being built
Tim-Philipp Müller [Mon, 17 Aug 2020 17:51:17 +0000 (18:51 +0100)]
docs: fix gst-docs build if opencv is not being built

The disabler in opencv_dep (retrieved via libs_doc) will
cause a meson interpreter error if opencv is not being built:

ERROR: The += operator currently only works with arrays, dicts, strings or ints
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1519>

4 years agofdkaacenc: Implement flush function
Vivia Nikolaidou [Fri, 14 Aug 2020 16:57:30 +0000 (19:57 +0300)]
fdkaacenc: Implement flush function

The internal fdk encoder always produces 1024 bytes even with no input,
so special care should be taken to not drain it twice.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1515>

4 years agomediafoundation: Correct wrong raw video format mapping
Seungha Yang [Mon, 17 Aug 2020 12:39:13 +0000 (21:39 +0900)]
mediafoundation: Correct wrong raw video format mapping

Was a shameful mistake

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1517>

4 years agova: h264dec: set latency
Víctor Manuel Jáquez Leal [Sat, 8 Aug 2020 17:59:33 +0000 (19:59 +0200)]
va: h264dec: set latency

The min latency is calculated with the maximum number of frames that
precede any frame, if available, and it is lower than the maximum
number of frames in DBP.

The max latency is calculated with the maxium size of frames in DBP.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1500>

4 years agofdkaacenc: Refactor layout selection code
Jan Alexander Steffens (heftig) [Thu, 16 May 2019 18:40:14 +0000 (20:40 +0200)]
fdkaacenc: Refactor layout selection code

No functional change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1359>

4 years agofdkaacenc: Move channel layouts to gstfdkaac.c
Jan Alexander Steffens (heftig) [Thu, 18 Jun 2020 09:33:49 +0000 (11:33 +0200)]
fdkaacenc: Move channel layouts to gstfdkaac.c

In preparation of sharing them with the decoder. Iteration of the
channel layouts needs to be changed to use a sentinel element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1359>

4 years agovulkan: docs annotation updates
Matthew Waters [Wed, 12 Aug 2020 05:59:01 +0000 (15:59 +1000)]
vulkan: docs annotation updates

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1506>

4 years agobuild/vulkan: split vulkan gir
Matthew Waters [Tue, 11 Aug 2020 11:56:39 +0000 (21:56 +1000)]
build/vulkan: split vulkan gir

also add to docs

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1506>

4 years agowpe: WebView and WebContext handling fixes
Philippe Normand [Wed, 5 Aug 2020 17:41:45 +0000 (18:41 +0100)]
wpe: WebView and WebContext handling fixes

The WPEThreaded view is now split in 2 classes:
- WPEContextThread handles the persistent WebKit thread, where all WebKit API
calls should be handled.
- WPEView: is created from the WPEContextThread. It handles the WebView and
maintains the public interface on which wpesrc relies. This is the facade for
the WebView, basically. It takes care of dispatching API calls into the context
thread.

With these fixes it is now possible to create (and reuse) mutlple wpesrc
elements during the application lifetime.

Fixes #1372

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1484>

4 years agosctp: fix build with GST_DISABLE_GST_DEBUG
Sebastian Dröge [Fri, 7 Aug 2020 06:26:19 +0000 (09:26 +0300)]
sctp: fix build with GST_DISABLE_GST_DEBUG

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agosctp: hook up internal copy of libusrsctp to build
Tim-Philipp Müller [Sat, 25 Jul 2020 16:56:43 +0000 (17:56 +0100)]
sctp: hook up internal copy of libusrsctp to build

Add option 'sctp-internal-usrsctp' so people can choose
to build againts the distro version instead.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agosctp: import internal copy of usrsctp library
Tim-Philipp Müller [Fri, 24 Jul 2020 18:23:19 +0000 (19:23 +0100)]
sctp: import internal copy of usrsctp library

There are problems with global shared state and no API stability
guarantees, and we can't rely on distros shipping the fixes we
need. Both firefox and Chrome bundle their own copies too.

Imported from https://github.com/sctplab/usrsctp,
commit 547d3b46c64876c0336b9eef297fda58dbe1adaf
Date: Thu Jul 23 21:49:32 2020 +0200

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agoproxysink: event_function needs to handle the event when it is disconnecetd from...
Jose Quaresma [Wed, 12 Aug 2020 10:57:10 +0000 (11:57 +0100)]
proxysink: event_function needs to handle the event when it is disconnecetd from proxysrc

without this a disconneted proxysink fail when goes to play with error:

 Internal data stream error.
 streaming stopped, reason error (-5)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1508>

4 years agocccombiner: Correct sink_query chain up and fix caps leaks
Seungha Yang [Thu, 13 Aug 2020 11:19:21 +0000 (20:19 +0900)]
cccombiner: Correct sink_query chain up and fix caps leaks

Don't chain up to src_query() from sink_query() method, and
returned caps by gst_static_pad_template_get_caps() needs to be
cleared.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1513>

4 years agomediafoundation: Call MFShutdown when destroying plugin
Seungha Yang [Wed, 12 Aug 2020 17:24:52 +0000 (02:24 +0900)]
mediafoundation: Call MFShutdown when destroying plugin

MFStartup and MFShutdown should be paired as documented in
https://docs.microsoft.com/en-us/windows/win32/api/mfapi/nf-mfapi-mfstartup#remarks
Otherwise valgrind-like tools would report false positive memory leak.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1512>