Jesse Luehrs [Tue, 19 Jun 2012 14:49:42 +0000 (09:49 -0500)]
the known problems section is also for platform specific things
Steve Hay [Tue, 19 Jun 2012 16:59:29 +0000 (17:59 +0100)]
Use ll rather than I64 for win32/config*.gc64 format strings
The corresponding types are long long rather than __int64 so this makes
more sense and matches proposed diffs from the land of Strawberry Perl
for supporting 32-bit builds with 64-bit ints on Windows (hopefully
coming up soon...).
Steve Hay [Tue, 19 Jun 2012 16:54:18 +0000 (17:54 +0100)]
Add missing dlltool default to win32/config.gc
ExtUtils::MakeMaker and ExtUtils::CBuilder both default to this anyway,
but it's good to be explicit, and reduces diffs with the .gc64 file.
Jesse Luehrs [Tue, 19 Jun 2012 14:25:46 +0000 (09:25 -0500)]
perldelta updates
Father Chrysostomos [Tue, 19 Jun 2012 13:29:50 +0000 (06:29 -0700)]
perldelta for
186a5ba82d58
This entry is only for the user-visible changes.
Lukas Mai [Tue, 19 Jun 2012 13:03:19 +0000 (15:03 +0200)]
remove bogus $remainder variable from perlfunc/split
As reported by Anša Vernerová:
| Calling the third argument $remainer is simply wrong - the remainder is
| the fourth argument, which is not assigned to anything.
David Mitchell [Mon, 18 Jun 2012 21:40:25 +0000 (22:40 +0100)]
overloading: make qr fallback to "" better
With the re_eval jumbo fix, the behaviour of overloaded objects in
runtime patterns, such /^$overloaded/ has changed, such that the stringify
overload ("") no longer avoids the need for 'use re "eval"': for example,
use overload "" => sub { qr/(??{1})/ }
my $o = bless [];
"1" =~ /^$o/;
works in 5.16.0, but dies with "Eval-group not allowed" in blead.
Change this back to the former behaviour, such that if qr and concat
ops aren't overloaded, then use "" overloading, and if the return from
that is a qr object, extract any code blocks from it.
This is achieved by:
* moving the concat/stringify code ahead of the regex block extraction
code,
* making the overloaded stringify call be explicit (rather than
being invoked implicitly by sv_catsv()),
* looping to re-apply overloading to any object returned by "".
* applying those last two steps in the case of a single arg too
This is a partial fix for
[perl #113682] Bleadperl v5.17.0-424-gd24ca0c breaks
ABIGAIL/Regexp-Common-
2011121001.tar.gz
Nicholas Clark [Wed, 28 Mar 2012 15:15:15 +0000 (17:15 +0200)]
In cflags.SH trim the case statement of file basenames.
Add examples showing how to use cflags.SH to tweak the compiler flags used
for individual object files.
Previously cflags.SH contained a somewhat stale pre-canned list of file
basenames including removed files such as usersub (deleted before 5.000
shipped), and a partial list of 5.000 XS extensions. Whilst it's possible
to generate the correct list in cflags by parsing MANIFEST (and adding a few
fixups), it's still not actually *useful*, as cflags gets overwritten as
soon as config.sh changes. Hence the most end-user useful solution with
minimal maintenance is to eliminate the list entirely, and document how the
user should add to it as necessary.
Nicholas Clark [Mon, 16 Apr 2012 05:51:49 +0000 (07:51 +0200)]
In pp_iter, handle end of range at IV_MAX without undefined behaviour.
The previous code assumed that incrementing a signed integer value wraps.
We're lucky that it has (so far), as it's undefined behaviour in C.
So refactor to code which doesn't assume anything.
Nicholas Clark [Mon, 18 Jun 2012 19:49:39 +0000 (21:49 +0200)]
In t/op/arith.t, tryeq_sloppy() wasn't correctly handling negative values.
The code was treating any negative value as "ok", rather than only those
within 1e-9 of the expected value. This bug has been present since
tryeq_sloppy() was added by commit
800e6488b45c59f1 in Oct 2001.
Jesse Luehrs [Tue, 19 Jun 2012 07:15:38 +0000 (02:15 -0500)]
this is already mentioned at the end (and that is more correct)
Jesse Luehrs [Tue, 19 Jun 2012 07:10:34 +0000 (02:10 -0500)]
remove some boilerplate
Jesse Luehrs [Tue, 19 Jun 2012 07:05:20 +0000 (02:05 -0500)]
todo
Jesse Luehrs [Tue, 19 Jun 2012 06:27:21 +0000 (01:27 -0500)]
consistency
Jesse Luehrs [Tue, 19 Jun 2012 06:06:00 +0000 (01:06 -0500)]
combine sections
Jesse Luehrs [Tue, 19 Jun 2012 05:32:26 +0000 (00:32 -0500)]
bump Filter::Util::Call to CPAN version 1.45
Jesse Luehrs [Tue, 19 Jun 2012 05:20:28 +0000 (00:20 -0500)]
fix inadvertent removal during editing
Jesse Luehrs [Tue, 19 Jun 2012 05:07:03 +0000 (00:07 -0500)]
perldelta copyediting
Father Chrysostomos [Tue, 19 Jun 2012 03:43:03 +0000 (20:43 -0700)]
Revert perlfilter part of
318b791f053
The CPAN release has an old version.
Jesse Luehrs [Mon, 18 Jun 2012 22:44:04 +0000 (17:44 -0500)]
whoops, should be using $new_version here
Jesse Luehrs [Mon, 18 Jun 2012 22:30:07 +0000 (17:30 -0500)]
use the right default for MAP
Jesse Luehrs [Mon, 18 Jun 2012 22:25:18 +0000 (17:25 -0500)]
make sure podlators is skipped, it won't be handled correctly
Jesse Luehrs [Mon, 18 Jun 2012 22:03:26 +0000 (17:03 -0500)]
bump Filter::Util::Call to CPAN version 1.44
Jesse Luehrs [Mon, 18 Jun 2012 21:39:25 +0000 (16:39 -0500)]
teach sync-with-cpan how to update Maintainers.pl
Jesse Luehrs [Mon, 18 Jun 2012 21:20:43 +0000 (16:20 -0500)]
update sync-with-cpan to handle dists with MAPped files
Jesse Luehrs [Mon, 18 Jun 2012 21:17:33 +0000 (16:17 -0500)]
ensure 'make' updates all necessary files
moving files around doesn't change the mtime, and tarballs store the
mtime to use when untarring, so it's possible to end up with an updated
file with an mtime before the corresponding file in lib/
Jesse Luehrs [Mon, 18 Jun 2012 20:57:41 +0000 (15:57 -0500)]
get the dir name from the tarball filename
Filter::Util::Call comes from Filter-x.yz.tar.gz for instance, which
untars to Filter-x.yz, not Filter-Util-Call-x.yz as it was previously
assuming
Jesse Luehrs [Mon, 18 Jun 2012 20:57:18 +0000 (15:57 -0500)]
allow overriding version in this branch too
Jesse Luehrs [Mon, 18 Jun 2012 20:56:48 +0000 (15:56 -0500)]
not sure why this is necessary
Nicholas Clark [Mon, 18 Jun 2012 15:36:47 +0000 (17:36 +0200)]
Remove some 5.002 and 5.003 compatibility code from Class::Struct.
Nicholas Clark [Mon, 18 Jun 2012 15:13:49 +0000 (17:13 +0200)]
Add tests for all the error paths in Class::Struct.
Nicholas Clark [Mon, 18 Jun 2012 14:24:23 +0000 (16:24 +0200)]
Add tests for Class::Struct constructors called with initialiser lists.
Zefram [Mon, 18 Jun 2012 13:31:24 +0000 (14:31 +0100)]
use ppport.h for Storable on Perl 5.8.9
Storable.xs requires a definition of dVAR, which on 5.8.9 is only supplied
by ppport.h.
Nicholas Clark [Mon, 18 Jun 2012 12:30:52 +0000 (14:30 +0200)]
Merge fixes for Porting tests when building with -Dmksymlinks.
Nicholas Clark [Tue, 5 Jun 2012 14:07:40 +0000 (16:07 +0200)]
Avoid tests converting @INC to abs paths where no longer necessary.
As find_git_or_skip() no longer changes directory, no need to make paths in
@INC absolute in the various tests that use it.
Nicholas Clark [Tue, 5 Jun 2012 13:55:22 +0000 (15:55 +0200)]
Set GIT_DIR instead of changing directory in find_git_or_skip() in test.pl
Return the directory of the source tree, so that tests can change directory
to it if necessary. Modify t/porting/cmp_version.t to change directory.
This gets t/porting/utils.t passing again under -Dmksymlinks, without breaking
t/porting/cmp_version.t. The former needs to run in the build tree as it
inspects various build products. The latter needs to run in the (real)
checkout tree, else it thinks that every single file has changed (into a
symlink).
Nicholas Clark [Sun, 3 Jun 2012 14:39:58 +0000 (16:39 +0200)]
Teach Porting/cmpVERSION.pl about .pm files extracted from .pm_PL files.
Previously these were overlooked - the generated .pm file corresponding to
an .xs file would be found on disk, but as that file was not in git, the
original $VERSION could not be determined and it would be skipped. Now the
correct master file is checked, and failed if it is not updated.
Without this change, t/porting/cmp_version.t currently fails for a build
using -Dmksymlinks, due to ext/DynaLoader/dl_vms.xs having recent changes.
The test changes directory to the original git checkout, and if that
checkout is clean, there is *no* ext/DynaLoader.pm file there, which meant
that the previous version of pm_file_from_xs() would die because it could
not figure out which Perl file relates to dl_vms.xs
Nicholas Clark [Sun, 3 Jun 2012 14:34:40 +0000 (16:34 +0200)]
Update DynaLoader's VERSION after commit
7d08496d81c138d9.
Nicholas Clark [Sun, 3 Jun 2012 14:04:47 +0000 (16:04 +0200)]
In Porting/cmpVERSION.pl, treat undefined versions more rigorously.
For any changed module, if the old version is undefined or unparseable, treat
it as a SKIP, not an OK. If the old version *was* parseable, but the current
version is not, treat that as a FAIL - moving from a parseable to an
unparseable version is a regression.
Nicholas Clark [Sun, 3 Jun 2012 13:57:20 +0000 (15:57 +0200)]
In Porting/cmpVERSION.pl, increment $count in one place, unconditionally.
Previously it was only incremented if it was being used (as part of generating
TAP output). However, this was done as ++$count, necessitating using a printf
statement. By moving the increment to one place we can use print instead,
which is simpler, and avoid the risk of forgetting to increment $count if we
add a new block for different test output.
Chris 'BinGOs' Williams [Mon, 18 Jun 2012 11:44:39 +0000 (12:44 +0100)]
Sync Maintainers.pl with CPAN for Carp
Chris 'BinGOs' Williams [Thu, 7 Jun 2012 18:52:53 +0000 (19:52 +0100)]
Updated podlators to CPAN version 2.4.2
[DELTA]
2012-06-01 Russ Allbery <rra@stanford.edu>
* VERSION: podlators 2.4.2 released.
* t/text-encoding.t: Remove the test of a POD document without an
encoding. We previously tested that this interpreted the document
as ISO 8859-1, but Pod::Simple behavior has changed so that the
test started failing, plus Pod::Simple now warns about a missing
=encoding. (#77553)
2012-05-30 Russ Allbery <rra@stanford.edu>
* VERSION: podlators 2.4.1 released.
* lib/Pod/Man.pm (parse_file): Override the Pod::Simple method to
set output_fh to STDOUT if it's not already set. (#77530)
* lib/Pod/Text.pm (parse_file): Likewise.
Steve Hay [Mon, 18 Jun 2012 07:46:16 +0000 (08:46 +0100)]
Add perldelta entry for commit
4f46e52b00
Also wrap a long line.
Father Chrysostomos [Mon, 18 Jun 2012 01:21:31 +0000 (18:21 -0700)]
perldelta update
Jesse Luehrs [Mon, 18 Jun 2012 01:59:07 +0000 (20:59 -0500)]
bump version in Maintainers.pl to match what is in core
Jesse Luehrs [Mon, 18 Jun 2012 01:14:59 +0000 (20:14 -0500)]
typo fix
Jesse Luehrs [Mon, 18 Jun 2012 01:11:57 +0000 (20:11 -0500)]
update the core-cpan-diff section a bit
Jesse Luehrs [Mon, 18 Jun 2012 01:04:23 +0000 (20:04 -0500)]
use 'undef' instead of 'UNKNOWN' for -u
Jesse Luehrs [Mon, 18 Jun 2012 00:57:17 +0000 (19:57 -0500)]
check upstreams with -x too
Jesse Luehrs [Mon, 18 Jun 2012 00:36:24 +0000 (19:36 -0500)]
Revert "bump Pod::Simple to CPAN version 3.22"
This reverts commit
74216f0477933a6ab02c6e6041e0dc98eb109017.
this update breaks podlators and Pod::HTML, so reverting it until i
figure out how to get those updated
Jesse Luehrs [Mon, 18 Jun 2012 00:07:40 +0000 (19:07 -0500)]
bump Pod::Simple to CPAN version 3.22
Jesse Luehrs [Mon, 18 Jun 2012 00:01:52 +0000 (19:01 -0500)]
bump HTTP::Tiny to CPAN version 0.022
Jesse Luehrs [Sun, 17 Jun 2012 23:55:30 +0000 (18:55 -0500)]
bump Archive::Tar to CPAN version 1.88
Jesse Luehrs [Sun, 17 Jun 2012 23:53:45 +0000 (18:53 -0500)]
fix error message
Shlomi Fish [Sun, 17 Jun 2012 21:05:28 +0000 (00:05 +0300)]
add use strict to perl -d
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:42:18 +0000 (13:42 +0100)]
Updated PerlIO-via-QuotedPrint to CPAN version 0.07
[DELTA]
0.07 5 April 2012
Brought up to date with current code esthetics. Verified it runs on
5.14.2, threaded and unthreaded.
28 January 2004
Made sure the test-suite cleans up on multi-versioned systems.
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:39:20 +0000 (13:39 +0100)]
Updated Memoize to CPAN version 1.03
[DELTA]
1.03 Sun, 22 Apr 2012 17:11:16 -0400
* Clarified MERGE cache options and fixed bug
* Documentation fixes
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:35:48 +0000 (13:35 +0100)]
Updated Term-ANSIColor to CPAN version 3.02
[DELTA]
2012-03-18 Russ Allbery <rra@stanford.edu>
* ANSIColor.pm: Version 3.02 released.
* ANSIColor.pm (AUTOLOAD): Only return pass-through behavior if
the function that was called was one of our constants, rather than
turning every unknown function in the Term::ANSIColor namespace
into a passthrough join function when colors are disabled.
* t/basic.t: Test proper error reporting with colors disabled.
* ANSIColor.pm (AUTOLOAD): Preserve an existing value of $@ when
generating a constant sub and restore it afterwards. Diagnose
errors in creating the constant sub and die instead of ignoring
them.
* t/eval.t: New test for $@ preservation.
* ANSIColor.pm: Add italic and the ITALIC constant. Document that
the support for it is rare.
* t/basic.t: Test italic and ITALIC support.
* ANSIColor.pm: Add "mistyped" as a stopword, required by the
latest aspell on Debian.
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:33:46 +0000 (13:33 +0100)]
Updated Digest-MD5 to CPAN version 2.52
[DELTA]
2012-06-08 Gisle Aas <gisle@ActiveState.com>
Gisle Aas (3):
Wrong version number in the changelog
The t/threads.t was missing from the MANIFEST
Update expected digests for files
Andrew Fresh (1):
Remove double the
Lyle Hopkins (1):
Digest::Perl::MD5 OO fallback didn't work [RT#66634]
Peter J. Acklam (1):
Fix typos (spelling errors) in cpan/Digest-MD5/*
Shlomi Fish (1):
Modernize the code in the POD.
Zefram (1):
Makes Digest::MD5 work on Perl 5.6 [RT#75032]
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:30:42 +0000 (13:30 +0100)]
Updated autodie to CPAN version 2.11
[DELTA]
2.11
* DOCS: Explicitly documented that autodie is context
unaware. (Thanks to chromatic.)
* TEST: Multi-arg open tests are skipped on VMS.
(Thanks to Craig A. Berry.)
* TEST BUGFIX recv.t shouldn't assume STDIN is a file handle.
(Thanks to Todd Rinaldo)
* TEST: Fixed compatibility with Carp 1.25.
(Thanks to Olivier Mengué.)
* INTERNAL: Exception classes are loaded more safely.
(Thanks to Schwern)
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:20:11 +0000 (13:20 +0100)]
Updated Safe to CPAN release 2.33
[DELTA]
2.33 Tue Apr 3 2012
- Don't eval code under 'no strict' (Father Chrysostomos)
2.32 Sat Mar 31 2012
- Make Safe play nice with Devel::Cover
Chris 'BinGOs' Williams [Fri, 8 Jun 2012 12:16:58 +0000 (13:16 +0100)]
Updated Search-Dict to CPAN release 1.07
[DELTA]
1.07 2012-04-11
- install into sitelib for Perl 5.12+
- use Tie::Handle to get Tie::StdHandle for older Perls
- avoid using fc() in v5.15.0 - v5.15.7
- fix tests for older Perls
1.06 2012-03-31
- suppress stat() warnings on tied filehandles
1.05 2012-03-31
- no longer requires stat() on filehandle
- tests use Test::More
- case folds with fc() on Perl 5.15+
Father Chrysostomos [Sun, 17 Jun 2012 20:18:55 +0000 (13:18 -0700)]
Revert "B::Deparse: loopexes have list prec"
This reverts commit
6a31dbf44ee919c340a3372c95b28d581979d165.
It turns out to be wrong. Loopexes do have low precedence, but not
as low as I thought. Their precedence level is actually their own,
undocumented in perlop:
diff --git a/pod/perlop.pod b/pod/perlop.pod
index 3edeabd..c9a1adf 100644
--- a/pod/perlop.pod
+++ b/pod/perlop.pod
@@ -49,6 +49,7 @@ values only, not array values.
nonassoc .. ...
right ?:
right = += -= *= etc.
+ nonassoc loop exits (last, next, goto)
left , =>
nonassoc list operators (rightward)
right not
I am reverting this for now, till we decide what it is that
needs fixing.
Karl Williamson [Sun, 17 Jun 2012 19:47:20 +0000 (13:47 -0600)]
perlop: Fit some verbatim lines into 79 cols
Karl Williamson [Sun, 17 Jun 2012 19:46:17 +0000 (13:46 -0600)]
numeric.c: Fix typo, clarify comment
Hugo van der Sanden [Sun, 17 Jun 2012 08:32:49 +0000 (09:32 +0100)]
Fixup for bigint docs
Some copy/paste and insertion errors in bignum 0.19 left the docs in
a confusing state.
Jesse Luehrs [Sun, 17 Jun 2012 17:24:03 +0000 (12:24 -0500)]
ensure correctness if sv_2mortal modifies errno
Brian Fraser [Sat, 2 Jun 2012 17:15:34 +0000 (14:15 -0300)]
require should die if a file exists but can't be read.
See [perl #113422]. If a file exists but there's an error opening it,
we throw an exception and disregard the rest of @INC.
Karl Williamson [Sun, 17 Jun 2012 17:41:49 +0000 (11:41 -0600)]
perldelta: entry for qr/\87/ bug fix
Karl Williamson [Sun, 17 Jun 2012 17:23:53 +0000 (11:23 -0600)]
t/re/re_tests: Clarify comment
Karl Williamson [Sun, 17 Jun 2012 17:20:39 +0000 (11:20 -0600)]
regcomp.c: Warn and don't emit a NUL for e.g. /\87/
/\87/ when there are fewer than 87 capture groups was being read as
/\00087/, with no warning.
Karl Williamson [Sun, 17 Jun 2012 17:17:05 +0000 (11:17 -0600)]
regcomp.c: Add comments
The main part of this commit summarizes a huge switch statement, that I
never fully understood until I wrote the comment.
Karl Williamson [Sat, 5 May 2012 17:16:50 +0000 (11:16 -0600)]
toke.c: Combine macro calls
Replace a combination of macro calls with a single one that means the
same thing
Karl Williamson [Sat, 5 May 2012 14:11:21 +0000 (08:11 -0600)]
pp_hot.c: Combine macro calls
Replace a combination of macro calls with a single one that means the
same thing
Karl Williamson [Sat, 5 May 2012 14:09:41 +0000 (08:09 -0600)]
walk.c: Combine macro calls
Replace combinations of macro calls with single ones that mean the same
thing.
Karl Williamson [Sat, 5 May 2012 14:04:39 +0000 (08:04 -0600)]
a2py.c: Use isWORDCHAR() instead of individ components
isWORDCHAR() is a single macro (and array lookup) that is the equivalent
of the OR of the three macros previously used.
Karl Williamson [Sat, 5 May 2012 14:04:15 +0000 (08:04 -0600)]
handy.h: Add comment
Jesse Luehrs [Sun, 17 Jun 2012 16:44:29 +0000 (11:44 -0500)]
perlipc typo fixes, reported by Linda Walsh (RT#113556)
Jesse Luehrs [Sun, 17 Jun 2012 16:26:39 +0000 (11:26 -0500)]
typo fix, reported by Joaquin Ferrero (RT#113616)
Jesse Luehrs [Sun, 17 Jun 2012 16:22:59 +0000 (11:22 -0500)]
add note about minicpan mirrors and core-cpan-diff
Karl Williamson [Sun, 17 Jun 2012 14:28:51 +0000 (08:28 -0600)]
pp_hot.c: Add -Dr messages
This announces, when run with the appropriate debug levels, when regex
matching is skipped because we know up-front that it can't possibly
match.
Martin Hasch [Sun, 17 Jun 2012 13:42:34 +0000 (07:42 -0600)]
PATCH: [perl #113640] Typo in perlop.pod: bignum pragma
There is no 'bitfloat' pragma
David Mitchell [Sat, 16 Jun 2012 12:56:50 +0000 (13:56 +0100)]
fix paren unwinding with CURLYN, CURLYM
Historically, CURLYN and CURLYM didn't restore lastparen ($+) nor
invalidate higher numbered paren slots (reg->offs[n].end = -1)
when backtracking.
Recent commit
f6033a9d6c91e0c29d5aa5049361a529b5d7cdc4 fixed the lastparen
issue, but then exposed the offs[n].end issue, which had previously been
masked by the too-high lastparen value causing a previous state (such as a
branch) to conveniently wipe out the offending parens on further
backtracking.
Or to put it another way, each backtracker should be expected to clean up
his own mess, not hope that someone previous to him will do it for him.
Fix this by doing the .end = 1 stuff on CURLYN,M failure as well as
BRANCH/TRIE. For consistency, define a new macro to do it.
Jesse Luehrs [Fri, 15 Jun 2012 22:15:19 +0000 (17:15 -0500)]
minicpan doesn't set up the by-authors symlink
Chris 'BinGOs' Williams [Thu, 7 Jun 2012 21:26:46 +0000 (22:26 +0100)]
Updated IO-Compress to CPAN version 2.052
[DELTA]
2.052 29 April 2012
* IO::Compress::Zip
Force a ZIP64 archive when it contains >= 0xFFFF entries.
* Typos in POD
[RT# #76130: Gunzip Pod typo in OO section: $$output instead of $$input
2.049 18 February 2012
* IO::Compress::Zip
Error in t/cz-03zlib-v1.t that caused warnings with 5.15
[RT# 110736: warnings from cpan/IO-Compress/t/cz-03zlib-v1.t]
Chris 'BinGOs' Williams [Thu, 7 Jun 2012 21:23:18 +0000 (22:23 +0100)]
Updated Compress-Raw-Bzip2 to CPAN version 2.052
[DELTA]
2.052 29 April 2012
* No Changes
2.049 18 February 2012
* No Changes
Chris 'BinGOs' Williams [Thu, 7 Jun 2012 21:03:55 +0000 (22:03 +0100)]
Updated Compress-Raw-Zlib to CPAN version 2.054
[DELTA]
2.054 8 May 2012
* Build issue on Win32
[#77030]
2.053 6 May 2012
* Include zlib 1.2.7 source.
2.052 29 April 2012
* Fixed build issue when Perl is built with C++
2.051 20 February 2012
* Bug in Compress::Raw::Zlib on Windows
[#75222]
2.050 20 February 2012
* Build failure on Irix & Solaris.
[RT #69985]
2.049 18 February 2012
* Include zlib 1.2.6 source.
Jesse Luehrs [Fri, 15 Jun 2012 21:01:30 +0000 (16:01 -0500)]
add note about metacpan to the rmg
Father Chrysostomos [Fri, 15 Jun 2012 16:48:35 +0000 (09:48 -0700)]
checkAUTHORS.pl: another address for Renee Bäcker
Father Chrysostomos [Fri, 15 Jun 2012 16:44:50 +0000 (09:44 -0700)]
Increase $Class::Struct::VERSION to 0.64
Renee Bäcker [Sat, 9 Jun 2012 11:17:18 +0000 (04:17 -0700)]
add tests for overridden Class::Struct accessors
Rhesa Rozendaal [Fri, 15 Jun 2012 16:39:13 +0000 (09:39 -0700)]
[perl #29230] Class::Struct, accessor overrides not called from constructor
Class::Struct allows you to override the accessors it creates, but it
doesn't call them in its constructor.
In other words,
$struct->field('blah');
calls my override, but
$struct = structure->new('field' => 'blah');
doesn't. Class::Struct simply does
$r->{'field'} = $init{'field'}
but it would be more useful if it did
$r->field($init{'field'})
Father Chrysostomos [Fri, 15 Jun 2012 16:37:41 +0000 (09:37 -0700)]
Add Rhesa Rozendaal to AUTHORS
Father Chrysostomos [Thu, 14 Jun 2012 20:16:40 +0000 (13:16 -0700)]
op.c:utilize: don't allocate pegop if !PL_madskills
Just following what the FIXME note says. :-)
This shaves off a few CPU cycles.
Father Chrysostomos [Thu, 14 Jun 2012 15:42:11 +0000 (08:42 -0700)]
Let hints.t run at the top level
Father Chrysostomos [Thu, 14 Jun 2012 06:43:14 +0000 (23:43 -0700)]
Tests for perl #94476
Father Chrysostomos [Thu, 14 Jun 2012 06:11:26 +0000 (23:11 -0700)]
configpm: comment typo
Father Chrysostomos [Thu, 14 Jun 2012 06:10:46 +0000 (23:10 -0700)]
Don’t call mro_method_changed_in after newCONSTSUB
newCONSTSUB already does it itself (by calling newXS_len_flags,
which does it).
Father Chrysostomos [Thu, 14 Jun 2012 05:46:40 +0000 (22:46 -0700)]
Don’t create pads for sub stubs
Two code paths, sv_2cv (for \&name) and get_cvn_flags (for
&{"name"}()) were using start_subparse and newATTRSUB to create a
subroutine stub, which is what usually happens for Perl subs (with
op trees).
This resulted in subs with unused pads attached to them, because
start_subparse sets up the pad, which must be accessible dur-
ing parsing.
One code path, gv_init, which (among other things) reifies a GV after
a sub declaration (like ‘sub foo;’, which for efficiency doesn’t
create a CV), created the subroutine stub itself, without using
start_subparse/newATTRSUB.
This commit takes the code from gv_init, makes it more generic so it
can apply to the other two cases, puts it in a new function called
newSTUB, and makes all three locations call it.
Now stub creation should be faster and use less memory.
Additionally, this commit causes sv_2cv and get_cvn_flags to bypass
bug #107370 (glob stringification not round-tripping properly). They
used to stringify the GV and pass the string to newATTRSUB (wrapped in
an op, of all things) for it to look up the GV again. While bug
been fixed, as it was a side effect of sv_2cv triggering bug #107370.
Father Chrysostomos [Wed, 13 Jun 2012 20:58:13 +0000 (13:58 -0700)]
op.c:newPROG: Remove questionable comment
This thing about PL_eval_root going through an expensive function call
had already ceased to be the case before commit
5983a79d, which added
it. And I think it was only ever valid for non-core code.