G S Senthil Kumar [Wed, 6 Apr 2016 05:48:05 +0000 (11:18 +0530)]
Updated the MANIFEST content of simulator plugins.
Changed the version of plugins from 1.0.0 to 1.1.0.
Also specified the vendor as OCF.
Change-Id: Ic12f18a939530e75045c5f274b4e4d2dd1724d46
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7629
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Sunil Kumar K r [Mon, 4 Apr 2016 06:47:20 +0000 (12:17 +0530)]
IOT-1060 API should return invalid param for negative timeout value
timeout validation added. function names changed from json to cbor in provisioningclient
code reformated as per comments.
Change-Id: I20e254e7f50abde179a61b52e78c6fb92fcd3129
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7565
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Ashwini Kumar [Mon, 28 Mar 2016 09:45:23 +0000 (15:15 +0530)]
Security CBOR cleanup
- removed duplicate changes introduced for Security CBOR conversion
- Fixed pstat double free error
- Fixed crl double free
- Addressed review comments from Habib, Saurabh
- Addressed review commenst from Chul and removed compile warnings for CRL
oxm manager
- Fixed unittests, C++ examples to use .dat files for SVRs
- modified tizen .spec to install .dat files
- fixed svace static analysis issues
Change-Id: I638a247875c2b01f0207557fade3893dc363df5b
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7395
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
uzchoi [Tue, 5 Apr 2016 07:23:43 +0000 (16:23 +0900)]
DoxyGen for c and cpp API
Doxygen for c and cpp
javadoc: remove simulator package
Change-Id: I5aed13dfda52d9c2fcd7b1b4b30734d35b24d476
Signed-off-by: uzchoi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Markus Jung [Tue, 5 Apr 2016 04:38:40 +0000 (13:38 +0900)]
[IOT-1065][IOT-1069] RC - Tizen: sample application fix
- Correct sample configuration
- Deactivate notification on bundle resource initialization
- Remove BMI related UI for Tizen. Soft-sensors cannot be configered at runtime.
This will be a feature for the next release.
- Removed async bundle activation which is causing crashes in Tizen
Change-Id: Id87a36b1cb27d4267433823494415e35d2c6acee
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7593
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Sandipan Patra [Mon, 4 Apr 2016 12:19:10 +0000 (17:49 +0530)]
[Enrollee] API name modification as per IoTivity coding standard
Change-Id: I6c4f7ed6f07eb67ed989a81e5edf59ece29426b7
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7579
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Habib Virji [Sat, 26 Mar 2016 22:54:02 +0000 (22:54 +0000)]
IOT-982 Query handling for /oic/res
- By default oic.if.baseline is added for any resource created. All resource
created in OIC should have oic.if.baseline.
- In case query is empty, oic.if.ll as interface query.
- oic.if.ll handler returns all resources which are DISCOVERABLE.
- Same handler handles when query includes oic.if.ll.
- Only oic.if.ll and oic.if.baseline are supported as query param for /oic/res.
- oic.if.baseline handler only responds to query that are baseline interface.
- In case query includes rt but no if param. response is based on matching of rt value.
- It also include rt, if and uri for /oic/res response if it is oic.if.baseline..
Change-Id: Icaeab9f5407e9a02623e31b2d3be4488643c1e7a
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7365
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Tue, 5 Apr 2016 08:29:57 +0000 (17:29 +0900)]
added error handling logic about the message transmission fail in CA
If CA fail to add data to pdu, CA have to send the error message
to RI Layer using error callback.
Change-Id: I02ee617b7537c96a800b35c4319b15bcbafd44f8
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7609
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
jihwan.seo [Fri, 25 Mar 2016 07:34:37 +0000 (16:34 +0900)]
clean up getting methodID from jni
Change-Id: I09dad979e5c5e6f30fa693b97895bfe72a6e9690
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Markus Jung [Mon, 4 Apr 2016 06:05:12 +0000 (15:05 +0900)]
[IOT-1070][IOT-1071] RC-Android: check for null or empty parameters
Check for null or empty parameters. Throwing IllegalArgumentException.
Change-Id: I15822ee0ad6e572ab51b8f85efc666a8e43bc320
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
Sandeep Sharma [Thu, 31 Mar 2016 08:51:58 +0000 (14:21 +0530)]
Make SECURED flag propagate as integer to BuildConfig
in android build for conditionally loading ocprovision.
Removed propagtion as String.
Valid values on Command line for SECURED flag is '0' or '1'.
Change-Id: I45708ee54ae9bd19fa17bd49d24b49b2811e82c5
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7485
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Mon, 4 Apr 2016 03:15:13 +0000 (12:15 +0900)]
modified reasonable log message for connectionStateChanged state
Change-Id: I3bf080c1b002211b2af4f9e03225a01a7e93f248
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Dmitriy Zhuravlev [Fri, 1 Apr 2016 06:50:58 +0000 (09:50 +0300)]
File status check before fopen
Related issue: https://jira.iotivity.org/browse/IOT-1047
Change-Id: I83b82980b122e1336b18e4c864cf8bc3826abb6d
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7491
Reviewed-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Reviewed-by: Ivan Pazderskyy <i.pazderskyy@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
vimala.v [Mon, 4 Apr 2016 09:16:10 +0000 (14:46 +0530)]
[Arduino] Fix svace issues in connectivity.
Change-Id: Ibf77575c655038b8cd9dacd090e6411f461d94d3
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
vimala.v [Fri, 1 Apr 2016 11:46:35 +0000 (17:16 +0530)]
[Arduino] Changed write property to Write without response
Change-Id: I879cd15f9acb5cf71e594fbef6ff3e9989dac5fc
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jee Hyeok Kim [Mon, 4 Apr 2016 08:06:45 +0000 (17:06 +0900)]
Remove unused java packages
Change-Id: I5e290730676036edc783125194beafca781219f2
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
sahil bansal [Mon, 4 Apr 2016 04:39:47 +0000 (10:09 +0530)]
[IOT-1066]Updated OCGetDevInfoFromNetwork API description
Change-Id: Id6a5f66de22cd5927b5c7010e69d4b24b10e0856
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7559
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jung Seungho [Mon, 4 Apr 2016 05:50:29 +0000 (14:50 +0900)]
Fixed SVACE deteted Code
Change-Id: Ic324f1ab173e6101bd92c399e790fa343f15a197
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7561
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Jihun Ha [Mon, 4 Apr 2016 01:12:16 +0000 (10:12 +0900)]
Fix a wrong conditional statement in oicgroup
strlen(actionTypeStr) at line 790 was always 0, which is not what it meant
to be. After assign a proper string to actionTypeStr, then strlen() function
should be used.
Change-Id: I2ac7dd5750f54f59eb16e9469fc4dcec5259bcc9
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7553
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jee Hyeok Kim [Mon, 4 Apr 2016 01:06:42 +0000 (10:06 +0900)]
Revert resource publish workaround code
Change-Id: I3ab0dc4e969ccd0beffeaf8997fccb057b4bc0e3
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7551
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jihun Ha [Fri, 1 Apr 2016 07:38:34 +0000 (16:38 +0900)]
Remove an vulnerability for using strcat() function in oicgroup
Rather than strcat function, strncat function with a consideration of
a maximum length of string is better to be used for security reason.
Change-Id: I12b76ef4c149c66fac2b6b2963feef86d760d85f
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7515
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Habib Virji [Thu, 31 Mar 2016 23:01:29 +0000 (00:01 +0100)]
IOT-1018 RD payload handling of uint8_t and uint64_t value
- Setting the value of uint64_t to avoid casting being set wrong.
- Update to helper function to set size of the string.
- ocresource correct payload destroy.
- Removes duplicate MAX_ADDR_STR_SIZE
- Update Publish resource type from oic.wk.rdPub to oic.wk.rdpub.
Change-Id: I3bd13eb0fe52accf1d86da4d8ba0ecebdda79885
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7503
Reviewed-by: Towhidul Islam <t.islam@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Jay Sharma [Fri, 1 Apr 2016 16:00:26 +0000 (21:30 +0530)]
[Easy-Setup] Fixed JIRA issue IOT-1064
Change-Id: I1f2184ed17fb262628e52d4171d6579577158973
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7537
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Sandipan Patra [Fri, 1 Apr 2016 13:33:44 +0000 (19:03 +0530)]
[Tizen SVACE] Fixed svace issues for tizen enrollee
Change-Id: I26b5692362dea51fc4a729415066e4aaf035e728
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7533
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
G S Senthil Kumar [Fri, 1 Apr 2016 12:32:47 +0000 (18:02 +0530)]
Fix for SVACE reported issues on Simulator Java layer.
Resolved SVACE issues on java sdk and ServiceProvider and ClientController
plugins.
Change-Id: I1ba0b937deef1cf7f7a8d37de6fe0192eb07a82f
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Sandipan Patra [Fri, 1 Apr 2016 12:05:44 +0000 (17:35 +0530)]
[Arduino SVACE] Fixed svace issue for arduino
Change-Id: Iee5e7bea013be0e04c5c5898ace716e6f5a8bd80
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Fri, 1 Apr 2016 11:06:12 +0000 (16:36 +0530)]
[Easy-Setup] Fixed SVACE issues for Android [Mediator]
Change-Id: Ia0f3c0ec84e6129fafb8e4334b10b493977222b5
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jihwan.seo [Fri, 1 Apr 2016 00:34:03 +0000 (09:34 +0900)]
enabled ScanResponse for Advertising in BLE server
long device name can be used
though using ScanResonse Advertise data.
Change-Id: I474a8aafb2415b3933df92957c6db6907e8ff320
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jay Oh [Fri, 1 Apr 2016 02:36:30 +0000 (11:36 +0900)]
Bug Fix - the Object Array Value in the Palyload was not cloned properly.
- Object type (String) value was not checked
- Modification : add the case handling for OCREP_PROP_OBJECT
Change-Id: I8fe9c1fc7fec43648d2127284169af225a6a2bb0
Signed-off-by: Jay Oh <junghyun.oh@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Abhishek Sharma [Wed, 30 Mar 2016 00:15:57 +0000 (09:15 +0900)]
[IOT-1043] [RI] Canceling observation using RESET is not working
Related JIRA ticket : https://jira.iotivity.org/browse/IOT-1043
Change-Id: I7f984fe8f649af0681352fed14f8a37d73b2eba9
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7451
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sungkyu Ko <sungkyu.ko@samsung.com>
Reviewed-by: Gihong Kim <k1358.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaehong Jo [Thu, 31 Mar 2016 07:16:52 +0000 (16:16 +0900)]
Fix issue related SVACE in oickeepalive
Change-Id: I4c788411bcd8eb4251d292e0bf56ab470dfcafc1
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7481
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
jihwan.seo [Thu, 31 Mar 2016 12:02:13 +0000 (21:02 +0900)]
remove unnecessary startScan logic.
it doesn't need to scan when disconnected LE anymore.
since scenario was changed for support manual disconnect API.
Change-Id: I9fb36953d0dc209f7c7dda5c8ad2a3a05b61f0cb
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Hauke Mehrtens [Thu, 31 Mar 2016 09:47:58 +0000 (11:47 +0200)]
android: add AUTHENTICATION_FAILURE error code
This error code was added in commit
abe4ddd7e4 "Add wrong PIN defence codes in
case of PIN based OxM" to IoTivity, but it was not added to the Android error
code enum.
Change-Id: Id3a0ca22b537fba1d600eecc069fbfb88fcf470d
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7495
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Markus Jung [Thu, 31 Mar 2016 07:39:54 +0000 (16:39 +0900)]
[IOT-1052] Resource container fixes
Resource container fixes:
- Using strncat instead of strcat and including a length check for
configured paths.
- Checks for non-null references in Configuration.cpp
- Member initializiation in BundleInfoInternal.cpp
Change-Id: Ifb4c50a76b22e7c2b06465187c90a8328eda5a90
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7509
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: JungHo Kim <jhyo.kim@samsung.com>
Joonghwan Lee [Thu, 31 Mar 2016 02:57:40 +0000 (11:57 +0900)]
Add empty string check of uuid
Add empty string check code to prevent returning true when both uuid are empty string
-Patch 1: Initial
-Patch 2: Remove 'x' file permission
Change-Id: Id9c50025593ad3bd14a74b874d442e8d3da441f7
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Joonghwan Lee [Thu, 31 Mar 2016 07:10:17 +0000 (16:10 +0900)]
Resolved security issues - IOT-1058 & IOT-1059
https://jira.iotivity.org/browse/IOT-1058
[PM] [C] [Linux] [API] OCProvisionDirectPairing Fails to Provision Direct Pairing
https://jira.iotivity.org/browse/IOT-1059
[PM] [C] [Linux] [API] OCDoDirectPairing returns OC_STACK_INVALID_PARAM instead of OC_STACK_CALLBACK while resultCallback= NULL
-Patch 1: Resolved security Issues on 1.1.0-RC2
-Patch 2: Fix the expected value of OCDoDirectPairingTests.NullCallback in the stack unit test
Change-Id: I82cd3f855eeda1a65596984804fc8f1ce10cb79f
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jee Hyeok Kim [Fri, 1 Apr 2016 01:05:25 +0000 (10:05 +0900)]
Fix not to issue session if user unauthorized.
1. Check userId and return unauthorized response
if cannot find userId
2. Code cleanup
Change-Id: I2b0053512f51168e809b2b3320dd5645ff9a4632
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7511
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Philippe Coval [Thu, 3 Mar 2016 17:56:51 +0000 (18:56 +0100)]
tizen: Fixed RHSampleApp project file to use SDK path separator
This MSDOS '\' will break support on non Windows tizen-sdk
Change-Id: I83aaa2529d9d317a9f6406beba40ec6de8fddfcf
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6147
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mats Wichmann <mats@osg.samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Thu, 31 Mar 2016 14:41:37 +0000 (20:11 +0530)]
[Easy-Setup] Fixed SVACE issues.
Change-Id: Id2722e42ac6958e57a46f6cb8480395788697b10
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7501
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Hauke Mehrtens [Thu, 31 Mar 2016 09:47:21 +0000 (11:47 +0200)]
android: update versionName to 1.1 for the IoTivity 1.1 release
Change-Id: I6fa292c4cba715239e39d209e9ae4fa1a94d72b4
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7493
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Philippe Coval [Fri, 11 Mar 2016 12:15:40 +0000 (13:15 +0100)]
tizen: prevent building as seems unsuported on 32bit arch
Let's disable it for Tizen now, like for android or iOS.
Error was observed while building for Tizen:2.3.1:Wearable on i586 or armv7l :
#error "Requires IEEE 754 floating point!"
Change-Id: Ibd7ccbc0e8405aa3cbace45a2a0ae65ce35c87f3
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6139
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jung Seungho [Thu, 31 Mar 2016 09:44:16 +0000 (18:44 +0900)]
Fixed SVACE detected Code in Stack, AccountServer and CI .
CI remains 1 detect. and have to fix in RD
Change-Id: Ia23fbda13ef843181f5daaff97f2008b936510a8
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Randeep Singh [Thu, 31 Mar 2016 04:56:25 +0000 (10:26 +0530)]
[IOT-1049][Security][Resource Leak] Resolved possible resource leak
Change-Id: Id63ad08de60c9b6915415f356baa734f4c0a6395
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7477
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
js126.lee [Thu, 31 Mar 2016 02:58:30 +0000 (11:58 +0900)]
[IOT-1048][Security][Dangling Pointer] Address of local variable goes out of function scope
Related JIRA ticket : https://jira.iotivity.org/browse/IOT-1048
Patch 1: Init
Patch 2: Apply Mr. Kang's comment
Change-Id: I6f6fb829df89517fc24bed77a9f2827af10ef1de
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7471
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Yonggoo Kang [Wed, 30 Mar 2016 06:40:11 +0000 (15:40 +0900)]
Update pstat's device id in case of default
Change-Id: Ia7b7b24bbf39a42a761d9a872a62909b78064cae
Signed-off-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Philippe Coval [Tue, 8 Mar 2016 11:00:52 +0000 (12:00 +0100)]
look for project header in project path and not in system one
Use #include "..." vs #include <...>
as some compilers are making the difference
This was observed when building outside main project
This message appeared while building using tizen-sdk 2.4.0 Rev4
with imported libs (built with gbs from Tizen:2.4:Mobile repo)
Change-Id: Ic89a700bf9c2b9b10c739d5706ac9b3f742b210d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6143
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
jihwanseo [Mon, 28 Mar 2016 07:16:18 +0000 (16:16 +0900)]
removed CASample App for CA
since simpleserver and simpleclient can be covered it.
remove all sample sources.
Change-Id: Ib5960c0e9ee3ef8093718f0dd5f0e93b3db8e16f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7381
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Sandipan Patra [Tue, 29 Mar 2016 11:20:33 +0000 (16:50 +0530)]
[Tizen Enrollee] Removing GUI Enrollee Sample
Change-Id: I4c6dd1656d8ce184107e2bd5aa79a6c4b8c2475e
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7441
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hemant Mahsky <h.mahsky@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Wed, 30 Mar 2016 04:20:48 +0000 (09:50 +0530)]
[Easy-Setup] Fixed arduino issue.
Change-Id: I3b167eccaa5835288b5a560f070882df996aeb9e
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7453
Reviewed-by: Sandipan Patra <sandipan.p@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Tue, 29 Mar 2016 10:06:54 +0000 (03:06 -0700)]
Fix a bug of RCSResourceObject.
The problem was that when handler is canceled, segfault ocuured.
Change-Id: I04f4bae70db986245566f97f8388dc39254fb828
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7435
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jongmin Choi [Mon, 28 Mar 2016 06:47:45 +0000 (15:47 +0900)]
Client Initial pstat cm value changed
Patch #1: Initial Client pstat cm changed (2 -> 0)
Patch #2: Client JSON and DAT files in
resource/csdk/stack/samples/linux/secure/ changed accordingly
Patch #3: Easy-setup JSON and DAT files modified
Change-Id: Id0d1ceac5373ade28b2ee6f7a523da0fbfc1d52b
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7377
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Sandeep Sharma [Tue, 29 Mar 2016 05:27:18 +0000 (10:57 +0530)]
Fixed conditional Loading of ocprovision
Make build flag to propagate from gradle env to java runtime
Change-Id: I5e343778fe48d272cb025fddf64a7439276d75f6
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7425
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Tue, 29 Mar 2016 07:01:42 +0000 (16:01 +0900)]
Fix the bug in UUID convertor.
Previous ConvertStrToUuid() API does not guarantee correct result in case of empty UUID.
Even if input string is empty string,the input string may contain the garbage except first byte.
Here is bad case for ConvertStrToUuid() API :
Input : b'00 00 00 00 00 00 00 00 00 00 CC CC FF FF FF FF'
Since first byte is NULL character, the input string is empty string exactly.
The expected result is "
00000000-0000-0000-0000-
000000000000" in case of empty string.
But current ConvertStrToUuid() will be generated "
00000000-0000-0000-0000-
CCCCFFFFFFFF" for above input.
This patch is intended to fix it.
[Patch #1] Initial upload
[Patch #2] Update commit message
[Patch #3] Update according to comments.
[Patch #4] Update log message.
[Patch #5] Fix the typo on log message according to review comment.
Change-Id: I97c95a8fea30ffdf7e4c4ff6622e083b8357705a
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7431
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Mon, 28 Mar 2016 09:13:15 +0000 (18:13 +0900)]
Modify to ignore response if edp of pconf's response is false
Change-Id: I3511fdcb7be074f0591b3001d4c35af6462e13e7
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7391
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Tue, 29 Mar 2016 01:25:22 +0000 (10:25 +0900)]
Add extern C to prevent name mangling in C++ layer
Change-Id: I36a225ae5bb91d9bd45a1614d9acd0e9305d5fde
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7413
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Mon, 28 Mar 2016 07:16:00 +0000 (16:16 +0900)]
Update pstat init API to fill device id of pstat as doxm's uuid
in case of pstat's device id is empty.
If you want test with empty device uuid,
please use the resource/csdk/security/provisioning/sample/oic_svr_db_randompin_with_empty_deviceid.dat
Patch #1 : Intial upload
Patch #2 : Add json file according to Mr.JongSung Lee's comment.
Change-Id: I9c791074cd5abe179c2c4cccbb66e0d95d044399
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7383
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jongmin Choi [Mon, 28 Mar 2016 09:11:37 +0000 (18:11 +0900)]
README files updated for testing
Patch #1: README files updated for Ownership Transfer testing
Patch #2: LD_LIBRARY_PATH setting added
Patch #3: spaces removed
Change-Id: Ibde619776e3853ecbfed0be29388785a6e5e40e4
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7389
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Manoj Gupta [Fri, 18 Mar 2016 04:59:43 +0000 (10:29 +0530)]
Unused Variable Warning remove
Change-Id: I0b7159842cde4864c3113a0352488d4c3a65cd7d
Signed-off-by: Manoj Gupta <manoj.g2@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6055
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
hyuna0213.jo [Tue, 29 Mar 2016 02:22:03 +0000 (11:22 +0900)]
Bug fixing related to slow response server
Change-Id: Id0cc88362af1067003b76ebda8322e409063a38c
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7417
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Sandeep Sharma [Mon, 28 Mar 2016 15:03:25 +0000 (20:33 +0530)]
Modified Android to resolve
1. Build Issue with SECURED=1
2. Run time library loading Issue with SECURED=0
3. Updated DAT file for android sample provisioning client app.
PS: Currently both SECURED=0 and SECURED=1 build is successful
but run time loading is failing for SECURED=1.
Change-Id: I8b88092e682f2c3095ba0ccc4f81f4f40d205490
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
hunje.yeon [Tue, 29 Mar 2016 01:42:19 +0000 (10:42 +0900)]
[IOT-1026] Fix for Tizen RESampleClient Jira Issue
fix build issue caused by invalid variable.
Change-Id: Ibc57ab0498a066ebc03751a45dd37c6111d48a35
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7415
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
eunok.shin [Mon, 28 Mar 2016 12:26:27 +0000 (21:26 +0900)]
fix publish request parsing error
Change-Id: I814b3f1fe63f1659b3ac8d6cf6d11740fb8ea502
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7399
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Jay Sharma [Mon, 28 Mar 2016 11:27:00 +0000 (16:57 +0530)]
[Resource-Encapsulation] [IOT-1026] Fixed Jira Issue
Change-Id: I216c46097a85590ba927fe74c56b74b848a5611f
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6293
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Mon, 28 Mar 2016 15:57:39 +0000 (21:27 +0530)]
[Resource-Encapsulation] Fixed the Tizen sample app build issue.
- Updated "NestedAttributeClientApp" Tizen app.
Change-Id: I3cf63257fe3e23dde2cf1998ebccbb9d25de8388
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7409
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
wonny [Mon, 28 Mar 2016 12:53:58 +0000 (21:53 +0900)]
Modified SceneManager Unittest
- SceneTest : fix not creating scene
- RemoteSceneActionTest : fix setup() logic
Change-Id: Ie923d766e5da8ac7a3798f5a7febfb9404e7a2d5
Signed-off-by: wonny <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7401
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Mon, 28 Mar 2016 07:29:45 +0000 (16:29 +0900)]
Problem regarding NON request on Slow Response server
When a slow responding server receives a NON type request,
it is sending back an ACK message immediately, and then later,
sending NON response. According to RFC-7252, response of NON request
should only be a NON, there should not be any ACK in between.
Change-Id: I0b00c2423660d622df8490bf03011d18a1c26126
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7385
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
hyuna0213.jo [Mon, 28 Mar 2016 08:25:07 +0000 (17:25 +0900)]
fixed code to get token about the empty message
fixed code to get token about the empty message.
Change-Id: Ifbe334f42457c1b2ba801d92cdca540433689938
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
vimala.v [Mon, 28 Mar 2016 10:36:21 +0000 (16:06 +0530)]
Fix for crash in Tizen casample when message type is CA_MSG_RESET
Change-Id: I94937968bb6e63c74d0458919cdfedce1b2b60b0
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7397
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Jaehong Jo [Mon, 21 Mar 2016 00:23:00 +0000 (09:23 +0900)]
Add activity for NFC Transport.
The activity required for the NFC adapter.
Change-Id: Id735532944dfb2f496043620c0b7b3230d534957
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6111
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
leechul [Mon, 28 Mar 2016 00:46:44 +0000 (09:46 +0900)]
[IOT-1045] Remove the CborEncoder initialization in security modules to remove compile error.
Related JIRA ticket : https://jira.iotivity.org/browse/IOT-1045
I've modified on the basis of the following :
1) Does not initialize CborEncoder in all other modules except security modules.
2) Current initialization can make compile error in some other environment.
Actually, I can't reproduce this errors in my environment.
[Patch 1] : Intial upload.
[Patch 2] : Update commit message.
Change-Id: I98ff0b7db802605a54f357064fad13e7b3888a4c
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7371
Reviewed-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
leechul [Mon, 28 Mar 2016 04:58:25 +0000 (13:58 +0900)]
Changes to PolicyEngine to support rowner and isop checks.
Note that the pstat.isop must be set to "true" by the provisioning
tool after OTM is complete and provisioning is done!
patch #2 - added GetPstatIsop() function to pstatresource.h and .c.
Still needs to be properly provisioned by PT.
patch #3 - fixed unittest failure (workaround for now since proper
tests require device to be owned). Also marked GetDeviceOwnerId()
function for fixing after schema updates are done.
patch #4 - change to Chul Lee's suggested design using function
array instead of case switch. However it does not compile. See
Reply comments please.
patch #5 - fixed compile error and also logic error (changed || to
&&)
patch #6 - implemented correct GetDoxmRownerId() in doxmresource.c.
Other entity handlers should follow this simple template after
schema update is done.
patch #7 - fixed build issue on other platforms (worked on Linux)
patch #8 - rebase
patch #9 - added correct functions for all resources with
rowner/rownerID vals.
patch #10 - changed behavior on SVRs without rownerID, since
devowner is already being checked.
patch #11 - rebase again
patch #12 - now that acl, amacl and cred have rownerID property,
added correct getRownerId() for those 3 resources
patch #13 - remove the unexpected condition in policyengine.c
Please see my comments on line 465~473 in patch #12
Change-Id: If3c0a01f76260e10d3169fc0cfa79924175ca62d
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Kyungsun Cho [Sun, 27 Mar 2016 10:39:55 +0000 (19:39 +0900)]
Added default security_version definition for |oic/sec/ver| resource
- patch #1: initial commit
- patch #2: fixed multiple definition
Change-Id: I08572a6020653f99ea7f5922d82b51e4fd31bb22
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Kyungsun Cho [Sun, 27 Mar 2016 11:45:54 +0000 (20:45 +0900)]
fixed callback handling bug on |SecurityVersionDiscoveryHandler|
Change-Id: Ib07eba1221c26b7b57742d4f2c8aa2f9b9fae0dc
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
js126.lee [Mon, 28 Mar 2016 01:30:14 +0000 (10:30 +0900)]
Change name of encoding type
There is no name of encoding type as "oic.sec.encoding.bytestream" in the spec.
But we need a type to handling priv/pub data as byte array because our db is binary.
So we define new name of encoding type as "oic.sec.encoding.none" that means no need to encoding.
And we have asked to add this type into RAML spec.
-Patch 1 : Init
-Patch 2 : Modify encoding type from encodign.none to encoding.raw.
Change-Id: I7ad3d8facd302f97426cd42f139fbc11a7682638
Signed-off-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6329
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Jongmin Choi [Mon, 28 Mar 2016 02:02:22 +0000 (11:02 +0900)]
Provisioning Sample README updated
Patch #1: README file updated
Patch #3: CBOR change stated
Patch #4: File permission fixed
Change-Id: I04d7944aa720960777991277df94bdd9ac7018b1
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/7373
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
leechul [Fri, 25 Mar 2016 09:31:21 +0000 (18:31 +0900)]
Modify to update rowner as PT's UUID when ownership transfer is done.
1) Modify data structure of each security resource as single instance of rowner.
1) Add internal API to set the rowner.
2) Modify the doxmresource.c in order to update rowner when OTM is done.
3) Fix the minor bugs.
[Patch 1] : Intial upload
[Patch 2] : Revert the direct pairing related SVR DB files to prevent conflict.
[Patch 3] : Rebase
[Patch 4] : Remove the compile errors
[Patch 5-6] : Remove the compile errors for arduino
[Patch 7] : Update commit message
[Patch 8] : Rebase
Change-Id: I2f10786082265a2942dcadccb12f113658db8c34
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6325
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Kyungsun Cho [Thu, 24 Mar 2016 10:21:57 +0000 (19:21 +0900)]
[Revert] Renamed |SHA| symbol names on |tinydtls| external library
- patch #1: initial commit
- patch #2: rebased
- patch #3: fixed conflicts on |pkix/crypto_adaptoer.h|
Gerrit: https://gerrit.iotivity.org/gerrit/#/c/6245/
Jira: https://jira.iotivity.org/browse/IOT-977
Change-Id: Id111511a1eeab7cf83a319b9a3d87ed07bd71c7d
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6269
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Yonggoo Kang [Thu, 24 Mar 2016 14:29:21 +0000 (23:29 +0900)]
Update db files and Fix json2cbor tool
patch#1 : 1. Update dat/json files.
2. Fix json2cbor tool about CRED
patch#2 : Rebase to resolve conflict, minor fix
patch#3 : Resolve SVACE issue, check return value
Change-Id: Ibcaa8f2d0588924e42ab8985dac7b15a82579c8c
Signed-off-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6301
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Jongsung Lee <js126.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
js126.lee [Fri, 25 Mar 2016 04:53:32 +0000 (13:53 +0900)]
Resolved Svace defect on Security folder
-Patch 1: Resolve svase defect on security folder
-Patch 2: Apply Mr.Kang's comment
Change-Id: I4c020c4081121852de0c3623f53a177fd2b474c9
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6319
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
js126.lee [Thu, 24 Mar 2016 13:03:27 +0000 (22:03 +0900)]
Apply device provisiong state during OTM
Please just review, But don't merge this patch!!
Accoding to Device-Onborading-State, Ready for provisioning step is added during OTM.
1. Ready for OTM : The second bit of is enable, and isop is false.
2. Ready for Provisioning : The second bit of cm is disable, and isop is false.
3. Ready for Normal operation : THe second bit of cm is disable, and isop is true.
- Patch 1: Added Ready for provisioning step.
- Patch 2: Apply Chul's comment
Change-Id: I4a5aeb1b392aa35bf20a3ef960d3d30674ec40a4
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6297
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Habib Virji [Thu, 24 Mar 2016 22:26:46 +0000 (22:26 +0000)]
[IOT-995] Fix memory reallocation for security resources
When CborOutOfMemory is generated reallocation should be based on
encoder.ptr incremented value.
It also fixes allocation for security payload. It allocates value
based on the payload size.
Change-Id: I5213679d65e48bb91cd590d3cc654a6cd80b2af2
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6241
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Habib Virji [Thu, 24 Mar 2016 22:10:42 +0000 (22:10 +0000)]
[IOT-993] Remove limit of payload size handling
It cannot go beyond two level of increasing the payload size and it a[[ear it can go for handling bigger size.
Change-Id: I303f29563b32ba25d2f5e92a28f3a0ecac46ea60
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mushfiqul Islam <i.mushfiq@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
hyuna0213.jo [Thu, 24 Mar 2016 06:36:13 +0000 (15:36 +0900)]
modified target message type related blockwise transfer.
According to a spec, uses of the block options in conjunction
with multicast messages are for further study. so I modified to not
pass the blockwise transfer logic in case of the multicast message.
Change-Id: I2913dc7fc608e6da007071fd325c76931cf02325
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6253
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Minji Park [Wed, 23 Mar 2016 07:56:01 +0000 (16:56 +0900)]
fix configuration parsing problem in Resource Container
- fix configuration parsing for input information with bundle resource uri
Change-Id: I8a45b7a00179ab11a018ef1c3030df0233339090
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6217
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jihwan.seo [Fri, 25 Mar 2016 00:25:43 +0000 (09:25 +0900)]
fixed some crash for NFC.
Change-Id: I6abdd1cd99771a73876ffb5e8d2a9da40d2f19c0
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6309
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
jyong2.kim [Thu, 24 Mar 2016 23:02:57 +0000 (08:02 +0900)]
[IOT-1040] Fixed for jira issue about RH android.
prevented crash when init is called with null String at address.
Change-Id: I390fdd036e6afae44af36d935564b2fa5045d990
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hun-je Yeon [Thu, 1 Oct 2015 14:17:54 +0000 (23:17 +0900)]
[IOT-1019] Fix for jira issue
Add console out when Resource Container started.
Change-Id: If262e26fcee0e9ce52fada57fec03eccf47fc69f
Signed-off-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6289
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Thu, 24 Mar 2016 10:35:01 +0000 (19:35 +0900)]
[IOT-1039]Fixed for jira issue.
It is fix for a RH android sample application.
When the call terminate RH android sample, It expected to return success but return error.
terminate API is try to terminate a thread, but it was already terminated at other api.
Change-Id: I52b79252f1d952917729f7716d381303b57501a6
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6287
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 24 Mar 2016 08:51:22 +0000 (01:51 -0700)]
[IOT-1032][IOT-1033][IOT-1034] Fixed for an issue with android sample application.
It seems discovered resource is not what it should be in sample client.
It happens because method finding resource is changed.
Change-Id: Ib820319658038f7969fbd503b374c9d1933adb09
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6265
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jee Hyeok Kim [Wed, 23 Mar 2016 02:51:48 +0000 (11:51 +0900)]
Fix terminate sequence and observe option parser
1. Fix Observe option parser at stack
2. Fix terminate logic at stack
3. Add validation check to client
4. Remove JSONUtil class which multiply exist.
5. Rename Const file to Constants
Change-Id: Ib6419574151e787046b9a7fa89c351237304792a
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Glen Youngjin Kim <glen.kim@samsung.com>
Thiago Macieira [Thu, 24 Mar 2016 00:04:08 +0000 (17:04 -0700)]
Parse integers and single-precision floats in incoming CBOR streams
Incoming single-precision data is automatically converted to
double-precision upon parsing. Integers are kept as is, but if the user
requests the data as floating point, we convert on the fly. That is
inefficient if the call is performed more than once, but the appication
shouldn't do that anyway to avoid memory allocations.
Fixes IOT-981.
Change-Id: I11a23ec8442c40bf9f7affff143e9edd0d17eec7
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6239
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
hyuna0213.jo [Mon, 21 Mar 2016 04:55:36 +0000 (13:55 +0900)]
Changed the message transmission logic about CA_DEFAULT_ADAPTER
if transport adapter type is set as CA_DEFAULT_ADAPTER,
CA transmit a message via all transport adapter after generating a pdu.
but CoAP over UDP and CoAP over TCP can be used to generating pdu
according to transport type. so transport type should be determined
before generating a pdu.
Change-Id: I1cd6adda7dd060239eb40d74c36a1fa69da619f5
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
G S Senthil Kumar [Thu, 24 Mar 2016 10:15:11 +0000 (15:45 +0530)]
Fix for Jira IOT-1044.
Resolved UI issues which occurred when changing attribute values
from Simulator plug-ins in Eclipse Mars IDE.
Change-Id: Ibd2e0c7c5cfc314dddaba551958a86258d3188f0
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6267
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Jay Sharma [Thu, 24 Mar 2016 14:29:05 +0000 (19:59 +0530)]
[Easy-setup] Fixed Security feature
- Updated Mediator and enrollee sample applications [Android, Linux,Tizen]
- Updated iotivity.spec file
- Updated tizen-sdb README file
Change-Id: I95a8540ced6c9b5ac5036afb2763aeb02ec24a09
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6303
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Habib Virji [Wed, 23 Mar 2016 21:31:47 +0000 (21:31 +0000)]
[IOT-990] Support for URI comparisons to be case-insenstive
Support for rt or if in the query to be case-insensitive.
JIRA ISSUE: IOT-990
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Change-Id: Ieff5256e25b2232f25dec52e86b356a0682e3241
Reviewed-on: https://gerrit.iotivity.org/gerrit/6237
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Habib Virji [Thu, 24 Mar 2016 14:01:26 +0000 (14:01 +0000)]
[IOT-914] Device ID to be based on DOXM GetDeviceID
Instead of ocstack generating random device id. DOXM id is going to be used.
Change-Id: I1a780f07388ee1fe09e315c2d645f1c8ee5142de
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6299
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Dmitriy Zhuravlev [Thu, 24 Mar 2016 13:45:05 +0000 (15:45 +0200)]
Fix PKIX provision
There is an issue with payload converter
Change-Id: I6377cecd53b52986515fee7f7022680099cf05be
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: i.pazderskyy <i.pazderskyy@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6291
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
js126.lee [Thu, 24 Mar 2016 11:38:07 +0000 (20:38 +0900)]
Add security version resource
-Patch 1: To check security version, oic.sec.ver is created.
-Patch 2: Add commit description
-Patch 3.4: Apply Randeep's comment
-Patch 5: Rebase
-Patch 6-7: Fixed build error on Arduino
-Patch 8: Modify version data type of provisioningmanager
-Patch 9: Rebase
-Patch 10: Update device type
-Patch 11: 1) Modify to start version discovery in succession after secure port discovery
2) Separate each discovery(secureport, version) process as internal function.
-Patch 12: Add null check and remove unnecessary local variables.
-Patch 13: Modify the API description according to patch 11.
-Patch 14: Update according to SVACE report
-Patch 15: Rebase
It is clone https://gerrit.iotivity.org/gerrit/#/c/6059/ of
security-cbor-conv-1.1 branch after resolved conflict.
Change-Id: I0de72d8cc35acb048acfb7136769f3c84c72c152
Signed-off-by: Jongsung Lee <js126.lee@samsung.com>
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6105
Reviewed-by: Yonggoo Kang <ygace.kang@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
coderhyme [Mon, 14 Mar 2016 02:57:32 +0000 (19:57 -0700)]
Fixed a bug in the cache module of RE
If observation for a resource from a client is started, it should be canceled.
But there was a logic error that it isn't.
Change-Id: I2440c20999b7076bea5987ccbad3f0710269b3d9
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
(cherry picked from commit
607ef0e262f85d164cb3b1edbcf2e5bf926a2930)
Reviewed-on: https://gerrit.iotivity.org/gerrit/6259
Dmitriy Zhuravlev [Thu, 24 Mar 2016 11:15:53 +0000 (11:15 +0000)]
Revert "Fix PKIX provision"
This reverts commit
2e7005a00fac880b8d727cc896890f01bef26879.
Change-Id: I3e94a2c70a9c8de5e700ad9c1314b1e42ae17408
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/6285
projects / platform / upstream / iotivity.git / log