platform/upstream/libSkiaSharp.git
8 years agoRoll GN
mtklein [Fri, 5 Aug 2016 15:40:03 +0000 (08:40 -0700)]
Roll GN

No major new features... just good to keep up.

https://chromium.googlesource.com/chromium/buildtools.git/+log/60f7f9a..9c6ad6f

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2218063002

Review-Url: https://codereview.chromium.org/2218063002

8 years agoMaking a sample for shadow maps for more intensive development
vjiaoblack [Fri, 5 Aug 2016 14:55:01 +0000 (07:55 -0700)]
Making a sample for shadow maps for more intensive development

Merge branch 'shadow-gm' into shadow-sample

Added variable size shadow maps. Also fixed some bugs

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198933002

Review-Url: https://codereview.chromium.org/2198933002

8 years agoMinor clean up related to blur mask filters
robertphillips [Fri, 5 Aug 2016 14:51:29 +0000 (07:51 -0700)]
Minor clean up related to blur mask filters

This is the non-substantive portion of: https://codereview.chromium.org/2201133002/ (Implement GPU occluded blur mask filter)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214163003

Review-Url: https://codereview.chromium.org/2214163003

8 years agoMove to SkDataTable::MakeXXX and sk_sp.
bungeman [Fri, 5 Aug 2016 13:51:50 +0000 (06:51 -0700)]
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.

Review-Url: https://codereview.chromium.org/2211143002

8 years agoFix vulkan resolve
egdaniel [Fri, 5 Aug 2016 13:35:39 +0000 (06:35 -0700)]
Fix vulkan resolve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215353003

Review-Url: https://codereview.chromium.org/2215353003

8 years ago[recipes] Increase test coverage
borenet [Fri, 5 Aug 2016 13:30:10 +0000 (06:30 -0700)]
[recipes] Increase test coverage

Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003

Review-Url: https://codereview.chromium.org/2215443003

8 years ago[recipes] Separate builder_spec into compile/test/perf recipes
borenet [Fri, 5 Aug 2016 12:40:59 +0000 (05:40 -0700)]
[recipes] Separate builder_spec into compile/test/perf recipes

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002

Review-Url: https://codereview.chromium.org/2205473002

8 years ago[recipes] Remove build environment vars from default_env
borenet [Fri, 5 Aug 2016 12:18:05 +0000 (05:18 -0700)]
[recipes] Remove build environment vars from default_env

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002

Review-Url: https://codereview.chromium.org/2209423002

8 years agocheck zero-length text draws
reed [Thu, 4 Aug 2016 22:54:41 +0000 (15:54 -0700)]
check zero-length text draws

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215113002

TBR=

Review-Url: https://codereview.chromium.org/2215113002

8 years agoRemove color-dodge/burn from NVIDIA blacklist on 355.00+
csmartdalton [Thu, 4 Aug 2016 21:43:49 +0000 (14:43 -0700)]
Remove color-dodge/burn from NVIDIA blacklist on 355.00+

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212593002

Review-Url: https://codereview.chromium.org/2212593002

8 years agoImplement Vulkan Resolve.
egdaniel [Thu, 4 Aug 2016 19:50:01 +0000 (12:50 -0700)]
Implement Vulkan Resolve.

First step to getting msaa running on vulkan

BUG=skia:5127
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210383002

Review-Url: https://codereview.chromium.org/2210383002

8 years agoAdd new GM for occluded blurmask filter draws
robertphillips [Thu, 4 Aug 2016 19:35:46 +0000 (12:35 -0700)]
Add new GM for occluded blurmask filter draws

This splits out just the GM portion of https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter occluders) which included some API changes

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002

Review-Url: https://codereview.chromium.org/2214033002

8 years agoGet Mac viewer working with SDL
jvanverth [Thu, 4 Aug 2016 19:30:31 +0000 (12:30 -0700)]
Get Mac viewer working with SDL

Also fixes SkiaSDLExample.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210603003

Review-Url: https://codereview.chromium.org/2210603003

8 years agoThis CL's base is the CL that sets up the distance vector field req. exposure: https...
dvonbeck [Thu, 4 Aug 2016 19:27:26 +0000 (12:27 -0700)]
This CL's base is the CL that sets up the distance vector field req. exposure: https://codereview.chromium.org/2114993002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151653002

Review-Url: https://codereview.chromium.org/2151653002

8 years agoCreate a separate src for colorspace tests
msarett [Thu, 4 Aug 2016 19:22:06 +0000 (12:22 -0700)]
Create a separate src for colorspace tests

This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006

Review-Url: https://codereview.chromium.org/2206953006

8 years ago[recipes] Fixes for Coverage bot
borenet [Thu, 4 Aug 2016 19:16:03 +0000 (12:16 -0700)]
[recipes] Fixes for Coverage bot

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002

Review-Url: https://codereview.chromium.org/2217523002

8 years ago[recipes] Stop pretending that buildbot_spec is a step, simplify
borenet [Thu, 4 Aug 2016 18:33:01 +0000 (11:33 -0700)]
[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Review-Url: https://codereview.chromium.org/2209343002

8 years agoMove builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes
borenet [Thu, 4 Aug 2016 18:07:10 +0000 (11:07 -0700)]
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes

- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
  - no more buildbot_spec.py step
  - "real" dm and nanobench flags, instead of --dummy-flags
  - some inconsequential stuff in visualbench, which is removed anyway.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002

Review-Url: https://codereview.chromium.org/2215803002

8 years agoSkRTConf: eliminate
halcanary [Thu, 4 Aug 2016 17:47:16 +0000 (10:47 -0700)]
SkRTConf: eliminate

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Review-Url: https://codereview.chromium.org/2212473002

8 years agoUpdate skimage VERSION: attempt 3
msarett [Thu, 4 Aug 2016 17:39:22 +0000 (10:39 -0700)]
Update skimage VERSION: attempt 3

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211973002

Review-Url: https://codereview.chromium.org/2211973002

8 years agoGN: make SkPMColor BGRA on Linux. All other platforms are auto-detected.
mtklein [Thu, 4 Aug 2016 16:52:11 +0000 (09:52 -0700)]
GN: make SkPMColor BGRA on Linux.  All other platforms are auto-detected.

This technically shouldn't cause us to draw differently, but sometimes
does on buggy GMs, and also has us go down slightly different code paths.
It's good to be consistent with GYP, Chromium, Google3, etc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214023002

Review-Url: https://codereview.chromium.org/2214023002

8 years agoSlim the CQ down to the GN bots, where they exist.
mtklein [Thu, 4 Aug 2016 16:47:38 +0000 (09:47 -0700)]
Slim the CQ down to the GN bots, where they exist.

If no one objects to my "GN bot plan" email, this unblocks us from removing
a bunch of non-GN bots.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207073002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2207073002

8 years agoAdd new bench for occluded blurmaskfilter draws
robertphillips [Thu, 4 Aug 2016 16:03:19 +0000 (09:03 -0700)]
Add new bench for occluded blurmaskfilter draws

w/ occluders
  44/44  MB     6       497us   500us   500us   502us   0%      .oOOooooOO      gpu     bluroccludedrrect

w/o occluders
  41/41  MB     5       1.08ms  1.09ms  1.12ms  1.47ms  11%     .........O      gpu     bluroccludedrrect

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002

Review-Url: https://codereview.chromium.org/2203153002

8 years agoRemove SkSurface::MakeRenderTargetDirect
robertphillips [Thu, 4 Aug 2016 15:45:02 +0000 (08:45 -0700)]
Remove SkSurface::MakeRenderTargetDirect

split into:
https://codereview.chromium.org/2182543003/ (Move prepareForExternalIO from GrRenderTarget to GrDrawContext)
https://codereview.chromium.org/2187573002/ (Reduce usage of MakeRenderTargetDirect)
https://codereview.chromium.org/2186073002/ (Rename GrContext's newDrawContext & drawContext to makeDrawContext)
https://codereview.chromium.org/2178353005/ (Remove use of MakeRenderTargetDirect from view system)
https://codereview.chromium.org/2198433003/ (Remove some ancillary users of SkSurface::MakeRenderTargetDirect)
https://codereview.chromium.org/2208483004/ (Remove GrRenderTarget member variable from SkGpuDevice)
https://codereview.chromium.org/2211473002/ (Move GrContext::makeDrawContext to new GrContextPriv object)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2176333002

Review-Url: https://codereview.chromium.org/2176333002

8 years agoShow SVG file name in SampleApp title
fmalita [Thu, 4 Aug 2016 15:39:41 +0000 (08:39 -0700)]
Show SVG file name in SampleApp title

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217483002

Review-Url: https://codereview.chromium.org/2217483002

8 years agoRevert of Update skimage VERSION: attempt 2 (patchset #1 id:1 of https://codereview...
msarett [Thu, 4 Aug 2016 14:46:44 +0000 (07:46 -0700)]
Revert of Update skimage VERSION: attempt 2 (patchset #1 id:1 of https://codereview.chromium.org/2213973002/ )

Reason for revert:
Think this is going to break Windows again.

Original issue's description:
> Update skimage VERSION: attempt 2
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002
>
> Committed: https://skia.googlesource.com/skia/+/d6dec3f4a1365d34e147234acf3c4a3629146457

TBR=borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216523003

8 years agoUpdate skimage VERSION: attempt 2
msarett [Thu, 4 Aug 2016 14:29:09 +0000 (07:29 -0700)]
Update skimage VERSION: attempt 2

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2213973002

Review-Url: https://codereview.chromium.org/2213973002

8 years agoSpeculative fix for internal builds
fmalita [Thu, 4 Aug 2016 13:26:05 +0000 (06:26 -0700)]
Speculative fix for internal builds

Guard the DMSrcSink SkSVGDOM.h include.

TBR=dogben@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210583003

Review-Url: https://codereview.chromium.org/2210583003

8 years agoRemove GrRenderTarget member variable from SkGpuDevice
robertphillips [Thu, 4 Aug 2016 13:20:45 +0000 (06:20 -0700)]
Remove GrRenderTarget member variable from SkGpuDevice

Split out of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208483004

Review-Url: https://codereview.chromium.org/2208483004

8 years agospin off easy stuff from Herb's windows GN CL
mtklein [Thu, 4 Aug 2016 13:19:33 +0000 (06:19 -0700)]
spin off easy stuff from Herb's windows GN CL

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209533004

No public API changes.
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2209533004

8 years agoRevert of Update to new skimage VERSION (patchset #1 id:1 of https://codereview.chrom...
borenet [Thu, 4 Aug 2016 11:47:23 +0000 (04:47 -0700)]
Revert of Update to new skimage VERSION (patchset #1 id:1 of https://codereview.chromium.org/2211633002/ )

Reason for revert:
The CIPD package is broken

Original issue's description:
> Update to new skimage VERSION
> TBR=borenet@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002
>
> Committed: https://skia.googlesource.com/skia/+/52d1be5ca7b1ba8cc450be7dd6377ea5bb73386a

TBR=msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review-Url: https://codereview.chromium.org/2216613002

8 years agoAdd an SVG DM source
fmalita [Thu, 4 Aug 2016 02:53:36 +0000 (19:53 -0700)]
Add an SVG DM source

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004

Review-Url: https://codereview.chromium.org/2209593004

8 years agoRevert of SkRTConf: reduce functionality to what we use, increase simplicity (patchse...
mtklein [Thu, 4 Aug 2016 02:19:48 +0000 (19:19 -0700)]
Revert of SkRTConf: reduce functionality to what we use, increase simplicity (patchset #8 id:150001 of https://codereview.chromium.org/2212473002/ )

Reason for revert:
missed GrVkPipelineStateCache

Original issue's description:
> SkRTConf: reduce functionality to what we use, increase simplicity
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
> DOCS_PREVIEW= https://skia.org/?cl=2212473002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> [mtklein]
> TBR=reed@google.com
> Only removing unused public API.
>
> Committed: https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47

TBR=halcanary@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2215433003

8 years agoUpdate to new skimage VERSION
msarett [Wed, 3 Aug 2016 22:48:32 +0000 (15:48 -0700)]
Update to new skimage VERSION
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002

Review-Url: https://codereview.chromium.org/2211633002

8 years agoFix compiler complaints about uninit vars
msarett [Wed, 3 Aug 2016 22:46:33 +0000 (15:46 -0700)]
Fix compiler complaints about uninit vars

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206143003

Review-Url: https://codereview.chromium.org/2206143003

8 years agoSkRTConf: reduce functionality to what we use, increase simplicity
halcanary [Wed, 3 Aug 2016 22:30:37 +0000 (15:30 -0700)]
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Review-Url: https://codereview.chromium.org/2212473002

8 years agoGN: build sfntly, icu, harfbuzz
halcanary [Wed, 3 Aug 2016 22:08:04 +0000 (15:08 -0700)]
GN: build sfntly, icu, harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010

Review-Url: https://codereview.chromium.org/2200833010

8 years agoMove GrContext::makeDrawContext to new GrContextPriv object
robertphillips [Wed, 3 Aug 2016 21:26:53 +0000 (14:26 -0700)]
Move GrContext::makeDrawContext to new GrContextPriv object

We don't want external clients to be able to call the wrapping makeDrawContext. The "creating" makeDrawContext needs to be public for external image filters.

The 3 specialized drawContext creators on GrContextPriv (to wrap backend objects) are also to be kept from public use and will be used to remove SkSurface::MakeRenderTargetDirect.

Split out of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect)

TBR=bsalomon@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002

Review-Url: https://codereview.chromium.org/2211473002

8 years agoRequire gn format in presubmit
mtklein [Wed, 3 Aug 2016 21:18:22 +0000 (14:18 -0700)]
Require gn format in presubmit

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203283003

Review-Url: https://codereview.chromium.org/2203283003

8 years agoSkPDF: fewer GYP_DEFINES
halcanary [Wed, 3 Aug 2016 21:17:53 +0000 (14:17 -0700)]
SkPDF: fewer GYP_DEFINES

also: hack a unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003

Review-Url: https://codereview.chromium.org/2208743003

8 years agoConvert SkAutoTUnref<SkData> to sk_sp<SkData>.
bungeman [Wed, 3 Aug 2016 20:32:32 +0000 (13:32 -0700)]
Convert SkAutoTUnref<SkData> to sk_sp<SkData>.

With the move from SkData::NewXXX to SkData::MakeXXX most
SkAutoTUnref<SkData> were changed to sk_sp<SkData>. However,
there are still a few SkAutoTUnref<SkData> around, so clean
them up.

Review-Url: https://codereview.chromium.org/2212493002

8 years agoPerform color correction on png decodes
msarett [Wed, 3 Aug 2016 19:59:27 +0000 (12:59 -0700)]
Perform color correction on png decodes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184543003
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2184543003

8 years agoadded initial GLSL support to skslc
ethannicholas [Wed, 3 Aug 2016 19:43:36 +0000 (12:43 -0700)]
added initial GLSL support to skslc

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185393003

Review-Url: https://codereview.chromium.org/2185393003

8 years agoAdd new benchmark for testing special hard stop gradient cases
fmenozzi [Wed, 3 Aug 2016 19:12:19 +0000 (12:12 -0700)]
Add new benchmark for testing special hard stop gradient cases

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206713002

Review-Url: https://codereview.chromium.org/2206713002

8 years agoSkPDF: PDFShader code modernized.
halcanary [Wed, 3 Aug 2016 18:16:56 +0000 (11:16 -0700)]
SkPDF: PDFShader code modernized.

Motivation:  reduce code complexity.

SkCanon stores SkPDFShader::State next to SkDFObject, not inside.

many places use sk_sp<T> rather than T* to represent ownership.

SkPDFShader::State no longer holds bitmap.

SkPDFShader::State gets move constructor, no longer heap-allocated.

Classes removed:
  SkPDFFunctionShader
  SkPDFAlphaFunctionShader
  SkPDFImageShader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193973002

Review-Url: https://codereview.chromium.org/2193973002

8 years agoMake SK_BUILD_FOR_WIN32 auto-detection work.
mtklein [Wed, 3 Aug 2016 18:09:59 +0000 (11:09 -0700)]
Make SK_BUILD_FOR_WIN32 auto-detection work.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205173003

No public API changes
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2205173003

8 years agoFinish delete of SkNinePatch
msarett [Wed, 3 Aug 2016 18:04:01 +0000 (11:04 -0700)]
Finish delete of SkNinePatch

TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206333002

Review-Url: https://codereview.chromium.org/2206333002

8 years agoSkShaper: optionally disable harfbuzz
halcanary [Wed, 3 Aug 2016 17:43:55 +0000 (10:43 -0700)]
SkShaper: optionally disable harfbuzz

also, re-enable warnings.

motivation:  used by me for PDF testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002

Review-Url: https://codereview.chromium.org/2201153002

8 years ago[Recipes] Move test and perf steps into test and perf recipes
borenet [Wed, 3 Aug 2016 17:38:44 +0000 (10:38 -0700)]
[Recipes] Move test and perf steps into test and perf recipes

This looks like another big change, but I really just moved blocks of code around.  Again, no expectations diffs because no behavior is changed.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002

Review-Url: https://codereview.chromium.org/2198973002

8 years ago[SVGDom] Initial SVGLength support
fmalita [Wed, 3 Aug 2016 17:21:11 +0000 (10:21 -0700)]
[SVGDom] Initial SVGLength support

Mostly plumb new length types, but also introduce a stateful parser,
rect shape and named color support.

R=reed@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053002

Review-Url: https://codereview.chromium.org/2202053002

8 years agoFix fake_specs.py, update recipe expectation
borenet [Wed, 3 Aug 2016 17:10:07 +0000 (10:10 -0700)]
Fix fake_specs.py, update recipe expectation

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002

Review-Url: https://codereview.chromium.org/2200763002

8 years agoFix dtor bug in SkLights
robertphillips [Wed, 3 Aug 2016 16:40:39 +0000 (09:40 -0700)]
Fix dtor bug in SkLights

The overriding problem was that the SkTDArray wasn't calling the SkLight destructors.

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003

Review-Url: https://codereview.chromium.org/2206823003

8 years agoGN: gpu support in tools
mtklein [Wed, 3 Aug 2016 15:28:20 +0000 (08:28 -0700)]
GN: gpu support in tools

If you want to try this out, the DOCS_PREVIEW link is a quickstart.

Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library
or just used by testing tools?  I've got it written here as tool-only,
but we could easily move it to libskia if it's a thing we want to ship.

I'm honestly not sure I understand how this linked before without a definition
of GrGLCreateNativeInterface().  Or are there two, one real and one no-op
default with some sort of weak linking setup?  dlopen()?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003

Review-Url: https://codereview.chromium.org/2201233003

8 years agoSK_GAMMA_SRGB is the default.
mtklein [Wed, 3 Aug 2016 15:28:15 +0000 (08:28 -0700)]
SK_GAMMA_SRGB is the default.

Looks like that other CL stuck just fine.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207013002

Review-Url: https://codereview.chromium.org/2207013002

8 years agoRe-organize Skia recipes
borenet [Wed, 3 Aug 2016 15:23:10 +0000 (08:23 -0700)]
Re-organize Skia recipes

Break Skia recipe module into:
  - skia_vars: defines and stores variables (eg. paths)
  - skia_step: utilities for running Skia steps
  - skia_flavor: flavor-specific stuff
  - skia: top-level setup, checkout, test/perf steps, etc etc

This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.

Next steps:
  - Merge buildbot_spec into skia_vars
  - Move test_steps and perf_steps from skia recipe_module into
    swarm_test and swarm_perf recipes
  - Cleaner checkout_steps process

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002

Review-Url: https://codereview.chromium.org/2198173002

8 years agoUpdate hardstop_gradients GM to include more special cases
fmenozzi [Wed, 3 Aug 2016 14:58:06 +0000 (07:58 -0700)]
Update hardstop_gradients GM to include more special cases

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2204873005

Review-Url: https://codereview.chromium.org/2204873005

8 years agoDon't leave fResScale uninitialized when constructing an SkStroke.
deanm [Wed, 3 Aug 2016 14:21:04 +0000 (07:21 -0700)]
Don't leave fResScale uninitialized when constructing an SkStroke.

Set a default value of 1.  Users can set it with setResScale, but it's better
that the constructor doesn't just leave the field uninitialized otherwise.

R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207753003

Review-Url: https://codereview.chromium.org/2207753003

8 years agoFix copy-paste bugs in SkCanvas Nine and Lattice
msarett [Wed, 3 Aug 2016 13:53:26 +0000 (06:53 -0700)]
Fix copy-paste bugs in SkCanvas Nine and Lattice

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203983002

Review-Url: https://codereview.chromium.org/2203983002

8 years agoGN: add tests to DM
mtklein [Tue, 2 Aug 2016 23:02:05 +0000 (16:02 -0700)]
GN: add tests to DM

depends on https://codereview.chromium.org/2202203003 and https://codereview.chromium.org/2208433002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203143002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN-Trybot

Review-Url: https://codereview.chromium.org/2203143002

8 years agoFixed ambient lighting calculations on SkLightingShader
dvonbeck [Tue, 2 Aug 2016 21:46:34 +0000 (14:46 -0700)]
Fixed ambient lighting calculations on SkLightingShader

BUG=skia:5520
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003

Review-Url: https://codereview.chromium.org/2202233003

8 years agoMove off SK_SUPPORT_LEGACY_DATA_FACTORIES.
bungeman [Tue, 2 Aug 2016 21:40:46 +0000 (14:40 -0700)]
Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004

Review-Url: https://codereview.chromium.org/2206633004

8 years agoGN: get echo-headers sources via exec_script
mtklein [Tue, 2 Aug 2016 21:28:26 +0000 (14:28 -0700)]
GN: get echo-headers sources via exec_script

exec_script runs every time gn does, which is explicitly on every one of our
bot runs.  That should be enough to obviate the .git/logs/HEAD hack.

Easiest way to do this was to swap around find.py's argument order to allow
multiple search directories.  This is the root of all the .gyp changes.

This moves the blacklist into BUILD.gn, which I think is nice.
It expands it a little as we're now searching recursively, into include/gpu/vk
which we can't include safely without the Vulkan SDK.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205903004

Review-Url: https://codereview.chromium.org/2205903004

8 years agoDelete SkNinePatch
msarett [Tue, 2 Aug 2016 20:55:10 +0000 (13:55 -0700)]
Delete SkNinePatch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206663002

Review-Url: https://codereview.chromium.org/2206663002

8 years agoGN: re-run echo_headers if git state changes.
mtklein [Tue, 2 Aug 2016 20:05:54 +0000 (13:05 -0700)]
GN: re-run echo_headers if git state changes.

This should mean it re-runs if a header is added or removed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206683002

Review-Url: https://codereview.chromium.org/2206683002

8 years agoDelete SkARGBImageEncoder.
mtklein [Tue, 2 Aug 2016 19:57:32 +0000 (12:57 -0700)]
Delete SkARGBImageEncoder.

It appears to be unused now except by its unit test, also deleted.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208433002

No public API changes.
TBR=reed@google.com

Review-Url: https://codereview.chromium.org/2208433002

8 years agonot much point to SK_SUPPORT_PDF
mtklein [Tue, 2 Aug 2016 19:20:36 +0000 (12:20 -0700)]
not much point to SK_SUPPORT_PDF

It only controls a few minor things in testing tools,
which can always assume PDF support is present.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202203003

Review-Url: https://codereview.chromium.org/2202203003

8 years agoRefactor of SkColorSpaceXformOpts
msarett [Tue, 2 Aug 2016 18:30:30 +0000 (11:30 -0700)]
Refactor of SkColorSpaceXformOpts

(1) Performance is better or stays the same.

(2) Code is split into functions (RasterPipeline-ish
    design).  IMO, it's not really more or less readable.
    But I think it's now much easier add capabilities,
    apply optimizations, or do more refactors.  Or to
    actually use RasterPipeline.  I help back from trying
    any of these to try to keep this CL sane.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194303002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review-Url: https://codereview.chromium.org/2194303002

8 years agoRemove now unused source files.
bungeman [Tue, 2 Aug 2016 18:18:48 +0000 (11:18 -0700)]
Remove now unused source files.

These files have been renamed and exist only as stubs for transition
reasons. Remove these now unused stubs.

CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Review-Url: https://codereview.chromium.org/2197423003

8 years agogn: fix fiddle
mtklein [Tue, 2 Aug 2016 18:13:48 +0000 (11:13 -0700)]
gn: fix fiddle

  - __SK_FORCE_IMAGE_DECODER_LINKING makes sure the PNG encoder is linked
  - updated path to make working with sample draw.cpp easier.

No public API changes.
TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202353002

Review-Url: https://codereview.chromium.org/2202353002

8 years agoRemove 'Ulta' width.
bungeman [Tue, 2 Aug 2016 17:43:29 +0000 (10:43 -0700)]
Remove 'Ulta' width.

All users of this old name appear to be updated.

TBR=reed
Removing unused and mis-spelled API.

Review-Url: https://codereview.chromium.org/2206453003

8 years agoAdd Overstroke gm
hstern [Tue, 2 Aug 2016 17:35:57 +0000 (10:35 -0700)]
Add Overstroke gm

Already exists as a sampleapp, but sampleapps don't get tested
automatically

BUG=skia:5405,5406,chrome:589769
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161633002

Review-Url: https://codereview.chromium.org/2161633002

8 years agoAdd code to lua paths to get the fill path and get lists of verbs and
hstern [Tue, 2 Aug 2016 16:17:59 +0000 (09:17 -0700)]
Add code to lua paths to get the fill path and get lists of verbs and
points

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199823002

Review-Url: https://codereview.chromium.org/2199823002

8 years agoFix build_command_buffer for Windows
borenet [Tue, 2 Aug 2016 15:37:50 +0000 (08:37 -0700)]
Fix build_command_buffer for Windows

BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207563002

Review-Url: https://codereview.chromium.org/2207563002

8 years agoAdd drawImageLattice() and drawBitmapLattice() APIs
msarett [Tue, 2 Aug 2016 15:05:56 +0000 (08:05 -0700)]
Add drawImageLattice() and drawBitmapLattice() APIs

The specified image/bitmap is divided into rects, which
can be draw stretched, shrunk, or at a fixed size.  Will be
used by Android to draw 9patch (which are acutally N-patch)
images.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992283002

Review-Url: https://codereview.chromium.org/1992283002

8 years agoRename FontConfigInterface font manager files.
bungeman [Tue, 2 Aug 2016 14:07:33 +0000 (07:07 -0700)]
Rename FontConfigInterface font manager files.

These files are now so badly misnamed that it is causing problems.
The original files are kept as shells until Chromium and PDFium can
be updated. After Chromium and PDFium builds are updated, the old
files will be removed and the cmake and bzl builds will be updated.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199973002
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Review-Url: https://codereview.chromium.org/2199973002

8 years agoFix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN
borenet [Tue, 2 Aug 2016 14:02:52 +0000 (07:02 -0700)]
Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN

BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002

Review-Url: https://codereview.chromium.org/2199273002

8 years agoMore fixes for SwarmBucket
borenet [Tue, 2 Aug 2016 13:50:49 +0000 (06:50 -0700)]
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Review-Url: https://codereview.chromium.org/2202053005

8 years agoAlways return ImageShader, even from SkShader::MakeBitmapShader
reed [Tue, 2 Aug 2016 13:12:06 +0000 (06:12 -0700)]
Always return ImageShader, even from SkShader::MakeBitmapShader

Lessons learned

1. ImageShader (correctly) always compresses (typically via PNG) during serialization. This has the surprise results of
- if the image was marked opaque, but has some non-opaque pixels (i.e. bug in blitter or caller), then compressing may "fix" those pixels, making the deserialized version draw differently. bug filed.
- 565 compressess/decompresses to 8888 (at least on Mac), which draws differently (esp. under some filters). bug filed.

2. BitmapShader did not enforce a copy for mutable bitmaps, but ImageShader does (since it creates an Image). Thus the former would see subsequent changes to the pixels after shader creation, while the latter does not, hence the change to the BlitRow test to avoid this modify-after-create pattern. I sure hope this prev. behavior was a bug/undefined-behavior, since this CL changes that.

BUG=skia:5595
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195893002

Review-Url: https://codereview.chromium.org/2195893002

8 years agoRoll recipe DEPS
borenet [Tue, 2 Aug 2016 12:11:15 +0000 (05:11 -0700)]
Roll recipe DEPS

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002

Review-Url: https://codereview.chromium.org/2205863002

8 years agoGN: add some missing SkCodec defines
mtklein [Mon, 1 Aug 2016 22:50:27 +0000 (15:50 -0700)]
GN: add some missing SkCodec defines

    TURBO_HAS_...
    WEBP_SWAP_16BIT_CSP

BUG=skia:5591
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196413003

Review-Url: https://codereview.chromium.org/2196413003

8 years agoFix SkJpegCodec::onSkipScanlines when TURBO_HAS_SKIP is not defined
msarett [Mon, 1 Aug 2016 22:08:03 +0000 (15:08 -0700)]
Fix SkJpegCodec::onSkipScanlines when TURBO_HAS_SKIP is not defined

I think I just broke this in:
https://codereview.chromium.org/2174493002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202763002

Review-Url: https://codereview.chromium.org/2202763002

8 years agoHide (mostly) unused SkColorSpace writeToICC() function
msarett [Mon, 1 Aug 2016 21:23:32 +0000 (14:23 -0700)]
Hide (mostly) unused SkColorSpace writeToICC() function

This originally was intended to be used for serialization, but
we've chosen another approach.

Includes a revert of:
https://codereview.chromium.org/2012133003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002

Review-Url: https://codereview.chromium.org/2193223002

8 years agoSketch SkPictureRecorder::optimizeFor(GrContext*).
mtklein [Mon, 1 Aug 2016 20:17:47 +0000 (13:17 -0700)]
Sketch SkPictureRecorder::optimizeFor(GrContext*).

I'm open to API suggestions.
We can pass this in finishAs(), up front, whatever.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203453002

Review-Url: https://codereview.chromium.org/2203453002

8 years agoGN: use the correct fontconfig font mugger.
mtklein [Mon, 1 Aug 2016 20:08:46 +0000 (13:08 -0700)]
GN: use the correct fontconfig font mugger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202733002

Review-Url: https://codereview.chromium.org/2202733002

8 years agoReplace 'Ulta' with 'Ultra'.
bungeman [Mon, 1 Aug 2016 19:37:13 +0000 (12:37 -0700)]
Replace 'Ulta' with 'Ultra'.

Start fixing a typo in an enum name.

TBR=reed
This is just a typo fix.

Review-Url: https://codereview.chromium.org/2202703002

8 years agoPick the right download tool for windows.
herb [Mon, 1 Aug 2016 19:26:51 +0000 (12:26 -0700)]
Pick the right download tool for windows.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197423002

Review-Url: https://codereview.chromium.org/2197423002

8 years agoAdded distance vector support for CircleGeometryProcessor
dvonbeck [Mon, 1 Aug 2016 18:37:45 +0000 (11:37 -0700)]
Added distance vector support for CircleGeometryProcessor

This CL's base is the CL that sets up the distance vector field req. exposure: https://codereview.chromium.org/2114993002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190023002

Committed: https://skia.googlesource.com/skia/+/779e1924eaf7c5652dee93e0e8e975bbf5723b37
Review-Url: https://codereview.chromium.org/2190023002

8 years agoimplement isABitmap for imageshader, return localmatrix for bitmap's impl
reed [Mon, 1 Aug 2016 18:24:14 +0000 (11:24 -0700)]
implement isABitmap for imageshader, return localmatrix for bitmap's impl

For imageshader, I only return true if the image is explicitly raster-backed. I do not return true for texture, nor for generator (i.e. lazy/picture) backed. Is that ok?

BUG=skia:5592
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197323002

Review-Url: https://codereview.chromium.org/2197323002

8 years agoReplace old SkRecords RefBox with sk_sp.
mtklein [Mon, 1 Aug 2016 18:24:03 +0000 (11:24 -0700)]
Replace old SkRecords RefBox with sk_sp.

The main differences are that RefBox's constructor reffed and sk_sp's doesn't,
and that RefBox auto-casts to the underlying pointer while sk_sp doesn't.

I've added a bunch of sk_ref_sp() and .get() to compensate.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197243003

Review-Url: https://codereview.chromium.org/2197243003

8 years agomake an image from a mutable bitmap
reed [Mon, 1 Aug 2016 18:12:58 +0000 (11:12 -0700)]
make an image from a mutable bitmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199813002

Review-Url: https://codereview.chromium.org/2199813002

8 years agoGrFP can express distance vector field req., program builder declares variable for it
dvonbeck [Mon, 1 Aug 2016 18:01:56 +0000 (11:01 -0700)]
GrFP can express distance vector field req.,  program builder declares variable for it

This update allows fragment processors to require a field of vectors to the nearest edge. This requirement propagates:

- from child FPs to their parent
- from parent FPs to the GrPaint
- from GrPaint through the PipelineBuilder into GrPipeline
- acessed from GrPipeline by GrGLSLProgramBuilder

GrGLSL generates a variable for the distance vector and passes it down to the GeometryProcessor->emitCode() method.

This CL's base is the CL for adding the BevelNormalSource API: https://codereview.chromium.org/2080993002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002

Committed: https://skia.googlesource.com/skia/+/4ef6dfa7089c092c67b0d5ec34e89c1e319af196
Review-Url: https://codereview.chromium.org/2114993002

8 years agoGN: only include headers in echo_headers.py
mtklein [Mon, 1 Aug 2016 17:39:10 +0000 (10:39 -0700)]
GN: only include headers in echo_headers.py

This keeps things like VIM .swp files out of skia.h.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202643002

Review-Url: https://codereview.chromium.org/2202643002

8 years agoadding new GM to demostrate new shadows
vjiaoblack [Mon, 1 Aug 2016 17:02:31 +0000 (10:02 -0700)]
adding new GM to demostrate new shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118553002

Review-Url: https://codereview.chromium.org/2118553002

8 years agoAdd SkColorSpace::Equals() API
msarett [Mon, 1 Aug 2016 16:43:08 +0000 (09:43 -0700)]
Add SkColorSpace::Equals() API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196743002

Review-Url: https://codereview.chromium.org/2196743002

8 years agoDefault fake gamma to sRGB.
mtklein [Mon, 1 Aug 2016 16:22:12 +0000 (09:22 -0700)]
Default fake gamma to sRGB.

No one appears to be using the default 2.2.
This makes SK_GAMMA_SRGB the default / a no-op, which seems more realistic.

Chrome's explicitly setting SK_GAMMA_EXPONENT or SK_GAMMA_SRGB.
We set Android platform explicitly to 1.4.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198073002

Review-Url: https://codereview.chromium.org/2198073002

8 years agoGN: define fake-gamma configuration to match our bots.
mtklein [Mon, 1 Aug 2016 15:37:48 +0000 (08:37 -0700)]
GN: define fake-gamma configuration to match our bots.

This should fix many of the GN text diffs in Gold.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195393002

Review-Url: https://codereview.chromium.org/2195393002

8 years agoGN: Define SK_HAS_... in all Skia-private code, not just libskia.
mtklein [Mon, 1 Aug 2016 13:56:40 +0000 (06:56 -0700)]
GN: Define SK_HAS_... in all Skia-private code, not just libskia.

SkForceLinking wasn't force-linking the WEBP encoder, or any encoder.
(The others must be explicitly used.)

This should help the GN Debug Perf bots progress past

    Running Encode_color_wheel.jpg_WEBP nonrendering
    ../../../bench/EncoderBench.cpp:58: fatal error: "assert(data)"

On my laptop, a debug nanobench run now finishes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196243002

Review-Url: https://codereview.chromium.org/2196243002

8 years agoRemove some ancillary users of SkSurface::MakeRenderTargetDirect
robertphillips [Mon, 1 Aug 2016 12:53:23 +0000 (05:53 -0700)]
Remove some ancillary users of SkSurface::MakeRenderTargetDirect

calved off of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198433003

Review-Url: https://codereview.chromium.org/2198433003

8 years agoStop running nanobench on Test.*Debug bots
borenet [Mon, 1 Aug 2016 12:08:52 +0000 (05:08 -0700)]
Stop running nanobench on Test.*Debug bots

We'll need to add Perf.*Debug bots to achieve the same coverage.

BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2189393002

8 years agoRevert of GrFP can express distance vector field req., program builder declares...
mtklein [Sat, 30 Jul 2016 21:21:10 +0000 (14:21 -0700)]
Revert of GrFP can express distance vector field req.,  program builder declares variable for it (patchset #20 id:370001 of https://codereview.chromium.org/2114993002/ )

Reason for revert:
UBSAN says we're reading a bad bool here:
bool usesDistanceVectorField() const { return fUsesDistanceVectorField; }

../../../include/gpu/GrPaint.h:83:51: runtime error: load of value 239, which is not a valid value for type 'bool'
SUMMARY: AddressSanitizer: undefined-behavior ../../../include/gpu/GrPaint.h:83:51 in

Seems likely also the root of Valgrind failure:
https://luci-milo.appspot.com/swarming/task/30522e4f2241cb10

Original issue's description:
> GrFP can express distance vector field req.,  program builder declares variable for it
>
> This update allows fragment processors to require a field of vectors to the nearest edge. This requirement propagates:
>
> - from child FPs to their parent
> - from parent FPs to the GrPaint
> - from GrPaint through the PipelineBuilder into GrPipeline
> - acessed from GrPipeline by GrGLSLProgramBuilder
>
> GrGLSL generates a variable for the distance vector and passes it down to the GeometryProcessor->emitCode() method.
>
> This CL's base is the CL for adding the BevelNormalSource API: https://codereview.chromium.org/2080993002
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2114993002
>
> Committed: https://skia.googlesource.com/skia/+/4ef6dfa7089c092c67b0d5ec34e89c1e319af196

TBR=egdaniel@google.com,robertphillips@google.com,bsalomon@google.com,dvonbeck@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Review-Url: https://codereview.chromium.org/2201613002