Slawomir Cygan [Fri, 31 Aug 2018 14:46:45 +0000 (16:46 +0200)]
Add Flat decorations to integer fragment shader inputs
According to spec fragment shader inputs that are signed
or unsigned integers must be decorated with Flat.
Components: Vulkan
VK-GL-CTS Issue: 1335
Affects: dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_int_16_to_16x2.*
Change-Id: I5aa4f5bf9623549af4fb74647f956b9cbf4e3751
Jari Komppa [Fri, 25 May 2018 13:26:26 +0000 (16:26 +0300)]
Added test to check memory requirement invariance
Added a test that allocates random buffers and images, first in order
one by one, and then shuffled, verifying that the required memory
sizes match between these runs.
Image sizes, formats, allocation types and heap type requirements are
randomized.
The test depends on the supported image formats and available heap
types, so it is subtly different depending on the features the
driver supports. The goal for this test is to check for memory
requirement invariance, and thus it differs with the exact features
that are supported. The used features are printed in the log
for reference.
New tests:
dEQP-VK.api.invariance.random
Components: Vulkan
VK-GL-CTS issue: 1171
Change-Id: If869a72f6552174171d1f9bcce51e424ad8e8572
Slawomir Cygan [Thu, 27 Jul 2017 14:16:37 +0000 (16:16 +0200)]
Correct test group name ending in "_"
Components: Vulkan
Affects:
dEQP-VK.pipeline.multisample_interpolation.sample_interpolate_at_single_sample*
VK-GL-CTS issue: 1337
Change-Id: Id4b2bd4184c87bd35d88c2632ce31e5f7b31bfbb
Alexander Galazin [Thu, 6 Sep 2018 16:54:39 +0000 (18:54 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: Ic536adcefd24b9624863ce2894391238f4b4fb34
Alexander Galazin [Thu, 6 Sep 2018 16:35:42 +0000 (18:35 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: If13d31edfaa41aab48bbca57024722276b86a511
Alexander Galazin [Thu, 6 Sep 2018 16:18:10 +0000 (18:18 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I717b207ec5642fb2f5a7deb9a91e52da7b3c862f
Alexander Galazin [Thu, 6 Sep 2018 15:48:31 +0000 (17:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I5a095ab6fddfaa9ce687f8627b58ec12176ba660
Jeff Bolz [Fri, 31 Aug 2018 02:42:54 +0000 (21:42 -0500)]
Handle denorm flush to negative zero in unpackhalf2x16 tests.
Whether input fp16 values are flushed to zero is implementation
dependent. However, negative denorm values can be flushed to negative
zero and the logic did not handle that case.
Affects: dEQP-VK.glsl.builtin.function.pack_unpack.unpackhalf2x16*
Component: Vulkan
VK-GL-CTS issue: 1341
Change-Id: I2cd4a68cb5e498cd714a7e55b27ae4bc05ccde2d
Matthew Netsch [Fri, 13 Jul 2018 15:10:54 +0000 (11:10 -0400)]
Fixes tessellation triangle check
Tessellators may produce inner vertices positioned
on the edge of a primitive when used with fractional
odd spacing and the inner tessellation level is one.
Point mode doesn't factor into this rule
Components: Vulkan
VK-GL-CTS Issue: 1273
Affects:
dEQP-VK.tessellation.primitive_discard.*
Change-Id: Ida8c75d4275403eaae8b52fe55f3ed9e61dd2d6e
Toni Merilehti [Thu, 16 Aug 2018 11:54:02 +0000 (14:54 +0300)]
Fix result checking in multisample resolve tests
Test cases now return the correct test status based on the average
resolved values in attachments. Verifying the result also adjusts
the threshold values depending on the format component sizes and
converts the non-linear sRGB format values to linear before verifying
the result.
Affects:
dEQP-VK.renderpass.*.multisample_resolve.*
Components: Vulkan
VK-GL-CTS Issue 1306
Change-Id: I1ced03a1839221d5a76292d582155825c507923d
Matthew Netsch [Wed, 5 Sep 2018 18:36:31 +0000 (14:36 -0400)]
Reduces percentage of heap used in memory tests
Heaps can be shared and even fragmented on real systems.
The current percentage of 50% is a little high to reasonably
account for these issues.
Components: Vulkan
VK-GL-CTS issue: 1342
Affects:
dEQP-VK.memory.device_group_allocation.random*
Change-Id: I9a9c7fff05a663facd142a61a505c38925912ed8
Piotr Byszewski [Thu, 16 Aug 2018 06:43:03 +0000 (08:43 +0200)]
Simultaneous depth+stencil components blit test
Previously blit_image tests for depth and stencil components
were done separately - in one tests half of regions had depth
bit set and the other half stencil bit. This change modifies
those tests by adding additional blit regions that have both
DS bits set.
Components: Vulkan
VK-GL-CTS issue: 1303
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.depth_stencil.*
Change-Id: I38dec5c7e32678437126fb32ecf02c7329618094
Piotr Byszewski [Thu, 23 Aug 2018 13:24:13 +0000 (15:24 +0200)]
Ensure there's no KHX extensions
This change adds test that verifies if implementations don't
expose KHX extensions for neither instance nor device.
Components: Vulkan
VK-GL-CTS issue: 1258
Affects:
dEQP-VK.api.info.device.no_khx_extensions
Change-Id: Ib8020cadbe1714d9854d3a18969a6850ebd56f08
Alexander Galazin [Fri, 31 Aug 2018 09:16:21 +0000 (12:16 +0300)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I5a798ad268b27984038160cf645fc162260b069b
Alexander Galazin [Fri, 31 Aug 2018 07:52:20 +0000 (10:52 +0300)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I7e0e51ad6bbdebe2c0067cedbb8e0d3bca177fad
Petros Bantolas [Wed, 18 Jul 2018 10:19:04 +0000 (11:19 +0100)]
Fix subpixel precision for line geometry generation
Line geometry generation for rasterization tests wasn't taking the HW
subPixelPrecisionBits limit into account. Modified the triangle creation
routines to round those coordinates down to the driver provided
precision.
Affects:
dEQP-VK.rasterization.*line*
dEQP-GLES*.functional.rasterization.*line*
Components: Framework
VK-GL-CTS issue: 1274
Change-Id: I54af2f9606372bead2a8c7238588374101f80e55
Alexander Galazin [Thu, 30 Aug 2018 12:35:21 +0000 (14:35 +0200)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Change-Id: I692ba691f3fb23aa09a722d12f9cc9158d561457
Alexander Galazin [Thu, 30 Aug 2018 11:51:15 +0000 (13:51 +0200)]
Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
Change-Id: I0b5a54a89154a5877a22244870d39149bf05b28b
Alexander Galazin [Thu, 30 Aug 2018 11:51:13 +0000 (13:51 +0200)]
Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master
Change-Id: Ia9cfc9fa2550d981cfa3e3317253123ed061f47e
Jim Hauxwell [Tue, 28 Aug 2018 16:33:48 +0000 (17:33 +0100)]
Fix invalid combinations for texture/copy on ES2 driver
OES_packed_depth_stencil describes the valid combinations available.
Texturing is only valid from it when OES_depth_texture is also present.
ES3 added depth texturing, but used different tokens than the initial
extension.
Affects:
KHR-GLES2.core.internalformat.texture2d.
depth_stencil_unsigned_int_24_8_depth24_stencil8
KHR-GLES*.core.internalformat.texture2d.
depth_stencil_unsigned_int_24_8_depth_stencil
Components: OpenGL
VK-GL-CTS issue: 1261
Change-Id: I91262c2c7eb71c9d3ff1eb59931227132b1828f9
Alexander Galazin [Thu, 30 Aug 2018 07:18:37 +0000 (09:18 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I4c2cee91e239dd2b76c2e3a11148aa51d966f7ed
Alexander Galazin [Thu, 30 Aug 2018 07:18:34 +0000 (09:18 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: If4c00f790e935ce2a38709a99745acff6d1ef5f8
Krzysztof Kosiński [Fri, 22 Jun 2018 18:01:17 +0000 (11:01 -0700)]
Add wide color tests for RGB888 surfaces.
This also removes some duplication in the test creation function.
Change-Id: If0541906e510b3c2191a3e9ca8be3eb2529a0475
Components: EGL
Affects: dEQP-EGL.functional.wide_color
Yabin Zheng [Tue, 28 Aug 2018 09:09:24 +0000 (17:09 +0800)]
Modify the negative test related to glShaderBinary
Input 0 to binary parameter of glShaderBinary will lead to GL_INVALID_VALUE
accoridng to the GLES3.2 spec "An INVALID_VALUE error is generated if the
data pointed to by binary does not match the specified binaryformat."
The spec doesn't point out the order when we input more than one invalid
parameters. Add more conditions when checking the returned error messages.
Components: OpenGL
Affects: dEQP-GLES2.functional.negative_api.shader.shader_binary
VK-GL-CTS issue: 1331
Change-Id: I4c29a88175acf78f7a90262914890b9a53dbd3b5
James Helferty [Tue, 14 Aug 2018 20:56:59 +0000 (16:56 -0400)]
Free framebuffer objects after use.
Avoid leaking framebuffer objects in verifyLookupTextureData methods.
Affects:
KHR-GL4*.sparse_texture_clamp_tests.SparseTextureClampLookupColor
KHR-GL4*.sparse_texture_clamp_tests.SparseTextureClampLookupResidency
Components: OpenGL
VK-GL-CTS issue: 1312
Change-Id: I12aedd34fa80dbd9061ac174ce622a976019396d
Matthew Netsch [Tue, 28 Aug 2018 18:44:45 +0000 (14:44 -0400)]
Fixes memory allocation tests
Queries the platform specific alignment restrictions
with a temp buffer instead of estimating.
Components: Vulkan
VK-GL-CTS issue: 1259
Affects:
dEQP-VK.memory.allocation.basic.size_*
Change-Id: I272026f9e29b5606b8a4265ef0034752ac43a71a
John Anthony [Thu, 23 Aug 2018 14:11:13 +0000 (16:11 +0200)]
Incorrect enum values for VK_KHR_create_renderpass2
Some VkStructureType enum values added for VK_KHR_create_renderpass2 are
not in accordance with current Vulkan headers and the Vulkan
specification.
Components: Vulkan
VK-GL-CTS issue: 1321
Affects: dEQP-VK.*renderpass2.*
Change-Id: I51031d538bc427e56bbf56f603f200b513834d67
Ilkka Saarelainen [Fri, 10 Aug 2018 11:39:07 +0000 (14:39 +0300)]
Add float <--> int conversion tests
Added compute and graphics tests for OpConvertSToF, OpConvertFToS,
OpConvertUToF and OpConvertFToU instructions.
New tests:
dEQP-VK.spirv_assembly.instruction.compute.convert*
dEQP-VK.spirv_assembly.instruction.graphics.convert*
Components: Vulkan
VK-GL-CTS issue: 1079
Change-Id: Ia9a293a71e563a379a94f237afa8ee15bda2e01b
Jari Komppa [Fri, 20 Jul 2018 12:56:09 +0000 (15:56 +0300)]
Added test set for unnormalized coord samplers
The conformance suite did not have any dedicated tests for samplers with
unnormalized coordinates.
New tests:
dEQP-VK.texture.filtering.unnormal.*
Components: Vulkan
VK-GL-CTS issue: 1157
Google bug:
73500860
Change-Id: I290862ee2816e5fb54a1eb0987b74fd49995d39e
Jason Ekstrand [Tue, 3 Jul 2018 15:07:48 +0000 (08:07 -0700)]
Add tests for VK_EXT_vertex_attribute_divisor
New tests:
dEQP-VK.draw.instanced.*_attrib_divisor_*
Components: Vulkan
VK-GL-CTS issue: 1290
Change-Id: Idc6d247f47b18c783c24e30b91169fb9daf64bb3
Slawomir Cygan [Tue, 31 Jul 2018 13:33:43 +0000 (15:33 +0200)]
Add secondary command buffers to pipeline barrier tests
This adds secondary command buffers with transfer and
barrier operations to pipeline barriers tests.
Inside render pass command buffers are not added.
Components: Vulkan
VK-GL-CTS Issue: 1292
Affects:
dEQP-VK.memory.pipeline_barrier.*
Change-Id: I0e4b3fab2afd8d85743edf4bd6855d5ef877519a
Hernan Liatis [Fri, 6 Apr 2018 22:32:01 +0000 (15:32 -0700)]
Create Compute test for OpCompositeExtract
This test makes sure that OpCompositeExtract can be used on a struct
value inside a function.
New tests:
dEQP-VK.spirv_assembly.instruction.compute.opcompositeextract.*
Component: Vulkan
VK_GL_CTS issue: 1112
Change-Id: I6b071baaddd2b60310a23294547b7571cff960ce
Piotr Byszewski [Fri, 17 Aug 2018 14:47:47 +0000 (16:47 +0200)]
Extend deviceProperties2 test
With this change few device ID properties are also tested under
Vulkan 1.0 if the appropriate device extensions is present.
Test will also fail when the extensions are exposed but the
structs are left uninitialised.
Components: Vulkan
VK-GL-CTS issue: 1058
Affects:
dEQP-VK.api.info.get_physical_device_properties2.properties
Change-Id: I508a4025579372b394acc0da73295e3881efcc5b
Chris Forbes [Tue, 28 Aug 2018 21:59:48 +0000 (14:59 -0700)]
Set dest path for spirv binaries produced by check_build_sanity
This eliminates some contamination between the sanity script and
various Android build flavors
Change-Id: I9a97f616f8f266793d5e54dd3e2752c7f152dc71
Component: Framework
VK-GL-CTS: 1330
Chris Forbes [Tue, 28 Aug 2018 18:52:08 +0000 (11:52 -0700)]
scripts: Do code generation earlier
The actual builds are likely to fail if the framework code generation
steps were going to do anything.
Components: Framework
VK-GL-CTS Issue: 1328
Change-Id: I7ac96fb11520e028b0611e703925378a75dabd07
Aaron Bartholomew [Mon, 20 Aug 2018 19:28:42 +0000 (12:28 -0700)]
Improve wsi.incremental_present.* for low memory
This patch modifies the VK.wsi.incremental_present.* tests to alleviate
issues with memory use on memory constrained platforms
The issue is that the scale_down group in particular creates very large
swapchains & that the presentation engine may keep one or moreof the
swapchain images allocated until it is able to release them. Which means
that since this test does the following:
create swapchain, render some frames, destroy the swapchain, repeat
the high watermark for memory consumed by swapchain images will be higher
than the amount consumed by the single largest swapchain created.
This patch addresses these issues in two ways:
1) Reducing the size of the swapchain images allocated for scale down
tests to use the next power of two of the window size, instead of the
max extents reported by Vulkan
Max extents are already tested in other deqp tests & it's redundant
to do evaluate it again here; this change will make the test more
on functionality
2) Creates/Renders/Destroys a small dummy swapchain between each test
iteration in order to flush the memory held by the presentation
engine
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 1179
Change-Id: Ib7e1a5d9110e7dabc0d0ced21b643389c2bf0328
(cherry picked from commit
a3ba2368fda1ecf8cc3d5c3136b5674a3414f472)
Alexander Galazin [Tue, 28 Aug 2018 09:16:08 +0000 (11:16 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: Id5fde48915685d08e6a3201cc3d91eb87f68d208
Aaron Bartholomew [Mon, 20 Aug 2018 19:28:42 +0000 (12:28 -0700)]
Improve wsi.incremental_present.* for low memory
This patch modifies the VK.wsi.incremental_present.* tests to alleviate
issues with memory use on memory constrained platforms
The issue is that the scale_down group in particular creates very large
swapchains & that the presentation engine may keep one or moreof the
swapchain images allocated until it is able to release them. Which means
that since this test does the following:
create swapchain, render some frames, destroy the swapchain, repeat
the high watermark for memory consumed by swapchain images will be higher
than the amount consumed by the single largest swapchain created.
This patch addresses these issues in two ways:
1) Reducing the size of the swapchain images allocated for scale down
tests to use the next power of two of the window size, instead of the
max extents reported by Vulkan
Max extents are already tested in other deqp tests & it's redundant
to do evaluate it again here; this change will make the test more
on functionality
2) Creates/Renders/Destroys a small dummy swapchain between each test
iteration in order to flush the memory held by the presentation
engine
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 1179
Change-Id: Ib7e1a5d9110e7dabc0d0ced21b643389c2bf0328
(cherry picked from commit
a3ba2368fda1ecf8cc3d5c3136b5674a3414f472)
Yunchao He [Thu, 16 Aug 2018 00:17:50 +0000 (18:17 -0600)]
Fix an issue in the api feature tests for sampler_filter_minmax
extension.
Sampler flag VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_MINMAX_BIT_EXT
is supported for some particular texture formats when minmax property
filterMinmaxSingleComponentFormats is true, not when minmax property
filterMinmaxImageComponentMapping is true.
Components: Vulkan
Affects: dEQP-VK.api.info.format_properties.*
VK-GL-CTS issue: 1323
Change-Id: I6f74433dfc63ce1cd5e2b91f5f18d1d6cd433d40
Simen Kaspersen [Thu, 2 Aug 2018 13:17:00 +0000 (15:17 +0200)]
Remove unconditional depth_clamping for 1.1.2
Changed depthClampEnable from VK_TRUE to VK_FALSE where it is not needed.
Depth clamp specific tests in builtin_var.fragdepth set as not supported for incompatible systems.
Affects:
dEQP-VK.pipeline.early_destroy.*
dEQP-VK.api.object_management.*.graphics_pipeline
dEQP-VK.binding_model.shader_access.*
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.device_group.*
Components: Vulkan
VK-GL-CTS issue: 1286
Change-Id: I88271dda6001c63208b28d615ceab20bc597b743
Aaron Bartholomew [Mon, 20 Aug 2018 19:28:42 +0000 (12:28 -0700)]
Improve wsi.incremental_present.* for low memory
This patch modifies the VK.wsi.incremental_present.* tests to alleviate
issues with memory use on memory constrained platforms
The issue is that the scale_down group in particular creates very large
swapchains & that the presentation engine may keep one or moreof the
swapchain images allocated until it is able to release them. Which means
that since this test does the following:
create swapchain, render some frames, destroy the swapchain, repeat
the high watermark for memory consumed by swapchain images will be higher
than the amount consumed by the single largest swapchain created.
This patch addresses these issues in two ways:
1) Reducing the size of the swapchain images allocated for scale down
tests to use the next power of two of the window size, instead of the
max extents reported by Vulkan
Max extents are already tested in other deqp tests & it's redundant
to do evaluate it again here; this change will make the test more
on functionality
2) Creates/Renders/Destroys a small dummy swapchain between each test
iteration in order to flush the memory held by the presentation
engine
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 1179
Change-Id: Ib7e1a5d9110e7dabc0d0ced21b643389c2bf0328
Chris Forbes [Tue, 28 Aug 2018 01:07:53 +0000 (18:07 -0700)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: I17fe4454a499f701ef7660c22eab8049eb949615
Chris Forbes [Mon, 27 Aug 2018 17:31:42 +0000 (10:31 -0700)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Iaa4f4bec631129c71d93c2a3fa7fa6d5c53acbb5
Alexander Galazin [Mon, 27 Aug 2018 11:57:12 +0000 (13:57 +0200)]
Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
Change-Id: I2ed414f071867f3664529a283421f35f4bcf27b9
Alexander Galazin [Mon, 27 Aug 2018 10:45:37 +0000 (12:45 +0200)]
Update glslang
Components: Framework
Change-Id: I9f331d1e09f78d5b6dd40b6784c57349989c005d
Ilya Zaytsev [Tue, 21 Aug 2018 14:46:48 +0000 (16:46 +0200)]
Fix issues in ProtectedMemCopyBufferToImage
Fixes the following issues:
* pipeline barriers were not correct: wrong stages and wrong access masks
were used
* R32G32B32A32_UINT image view was sampled from sampler2D
Affects: dEQP-VK.protected_memory.image.copy_buffer_to_image.*
Components: Vulkan
VK-GL-CTS issue: 1326
Change-Id: I9d7eb9f8d9c2dcda1d7dd1f3b0e68e71fcd8c8f9
Yabin Zheng [Wed, 16 May 2018 08:18:35 +0000 (16:18 +0800)]
Wrong statues effects KHR-GLES32.core.internalformat.* tests
glReadPixels() will report a GL_INVALID_OPERATION because of some wrong
status before.
Some tests(KHR-GLES32.core.geometry_shader) execute the commands on the
default FBO. If the geometry_shader tests remove the texture from color
attachment0 in the deinit() function, that will lead to an incomplete
default FBO. According to the GLES spec(May 14, 2018) 3.2(P406), When we
run some tests in the KHR-GLES32.core.internalformat.* suite, the
glReadPixels() will report a GL_INVALID_OPERATION because of "An
INVALID_OPERATION error is generated if the read framebuffer is
not framebuffer complete."
Taking into account the impact of different config ID on the tests, I
think creating a new FBO is not suitable for KHR-GLES32.core.internalformat.*
Components: OpenGL
Affects:
KHR-GLES32.core.internalformat.*
KHR-GLES32.core.geometry_shader.*
VK-GL-CTS issue: 1244
Change-Id: I0158df8bdea829048b8b35f151d16b7f47f057f8
asokolow [Tue, 12 Jun 2018 08:59:10 +0000 (10:59 +0200)]
Do not expect TCS shader with XFB variables to fail linkging in GL
The test tries to link shader with XFB variables in TCS, without TES stage.
The test expects the shader to fail linking, but this behavior does not
seem to be mandated by GL spec.
According to GL 4.6 spec (
https://www.khronos.org/registry/OpenGL/specs/gl/glspec46.core.pdf - page 387)
- It is not forbidden to use TransformFeedbackVaryings with Tessellation Control
Shader and the spec does not mandate linking failure, even without NV_gpu_shader5
extension.
Test seems to derive this behavior from OGL ES spec where XFB is not allowed
within TCS shader.
Components: OpenGL
VK-GL-CTS Issue: 1221
Affects:
KHR-GL45.tessellation_shader.single.xfb_captures_data_from_correct_stage
Change-Id: Ie7c4209e0a36d48e56df04030ed095741bda155a
Kenneth Russell [Mon, 23 Jul 2018 22:26:47 +0000 (15:26 -0700)]
Add cases for structs as inout and out parameters.
Structs with lowp, mediump and highp (when supported in fragment
shaders) members are tested as inout and out parameters in both ES 2.0
and 3.0 shaders.
The highp variant of this test catches a bug which was found by the
Three.js community in https://github.com/mrdoob/three.js/issues/14137 .
Similar tests were integrated into the WebGL conformance suite in
https://github.com/KhronosGroup/WebGL/pull/2663 .
Verified on:
Qualcomm Adreno 308 (LG Aristo) - bug reproduces in both ES2 and ES3
highp fragment shaders
Qualcomm Adreno 540 (Pixel 2),
NVIDIA Tegra (SHIELD Tablet) - all tests pass
New tests:
dEQP-GLES[23].functional.shaders.struct.local.parameter_inout_*
dEQP-GLES[23].functional.shaders.struct.local.parameter_out_*
VK-GL-CTS Issue 1280
Change-Id: Ie332aede0ad52453815d9e123145ec035009430b
(cherry picked from commit
3b0365b1a090c4e15f72b2cb877ee15f65c8befe)
Chris Forbes [Sat, 25 Aug 2018 00:52:04 +0000 (17:52 -0700)]
Reinstate dot & reflect tests
There is now enough coverage of alternative evaluation orders that these
can be enabled.
Bug: b/
28767510
Change-Id: I65de890cd8106ff12f4f5bf76e3db31966681023
Chris Forbes [Fri, 24 Aug 2018 16:14:03 +0000 (09:14 -0700)]
Merge remote-tracking branch 'aosp/master' into deqp-dev
Change-Id: Ic7c969b1b52cf6b3fee8e8879508bf13de9a354e
Alexander Galazin [Fri, 24 Aug 2018 13:48:05 +0000 (15:48 +0200)]
Fix Vulkan build
Components: Vulkan
Change-Id: Id35717953f8727e1996d356f56f870c9455a9c39
Slawomir Cygan [Thu, 2 Aug 2018 16:01:57 +0000 (18:01 +0200)]
Fix asserts and check for base image format support in image.mutable tests
This adds a check if base image can be created given the format.
It is required for implementations supporting VK_KHR_maintenance2 or 1.1:
if these are supported, the exisiting VkImageView format support does not
cover base image format support.
Additionally, fix malformed asserts and missign case switches in this test.
Components: Vulkan
Affects: dEQP-VK.image.mutable
VK-GL-CTS Issue: 1295, 1294
Change-Id: I010a8823e2f7fa53a845366e489f071dbdc2f7f2
Ari Suonpaa [Tue, 5 Jun 2018 12:30:38 +0000 (15:30 +0300)]
New test for copying 16bit input to two outputs.
Added a test where 16bit input is copied into two outputs. This
verifies a 16bit intermediate value can be used twice.
New tests:
dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.input_output_*_16_to_16x2.*
Components: Vulkan
VK-GL-CTS issue: 893
Change-Id: Ifc4bd97f65d38e018b5600bd445a7cc625dd358d
Alexander Galazin [Fri, 24 Aug 2018 12:50:05 +0000 (14:50 +0200)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Change-Id: Id608fc80ae08fe2c61d72c65cca3188e37095130
Alexander Galazin [Fri, 24 Aug 2018 12:08:57 +0000 (14:08 +0200)]
Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
Change-Id: I9446aef49cc962cddbca7928fd6415ec13169295
Alexander Galazin [Fri, 24 Aug 2018 12:08:54 +0000 (14:08 +0200)]
Merge vk-gl-cts/opengl-es-cts-3.2.5 into vk-gl-cts/master
Change-Id: Ida0335ab0cd96894bdcd55837afcdac0470fb85a
Alexander Galazin [Fri, 24 Aug 2018 07:27:02 +0000 (09:27 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/master
Change-Id: I9a83f25ba7ad9bf007cd9b6778893a6f90587533
Alexander Galazin [Fri, 24 Aug 2018 07:26:58 +0000 (09:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ib1bfbe439ce0b734de4328d9d9577bc0a3793288
Alexander Galazin [Fri, 24 Aug 2018 07:26:54 +0000 (09:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ie5d1d301b96c8eff6a7d974de13c1d35195d7b26
Alexander Galazin [Fri, 24 Aug 2018 07:26:51 +0000 (09:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I5b4bdc020c0dda7ec55aafd498cd1f1193b9c77b
Chris Forbes [Thu, 23 Aug 2018 17:31:30 +0000 (10:31 -0700)]
Merge remote-tracking branch 'khronos/master' into HEAD
Change-Id: I58c439e2cf8859ca9cae5c78b8e065c5a652b1cd
Alexander Galazin [Thu, 23 Aug 2018 13:51:53 +0000 (15:51 +0200)]
Update Vulkan CTS mustpass
Components: Vulkan
Change-Id: I419768f938469473196797dc0d68f7776a9affb1
Pierre Tsai [Thu, 2 Aug 2018 15:13:14 +0000 (11:13 -0400)]
bufSize of glGetInternalformativ does not follow spec
In the specification section 22.3 Internal Format Queries
(glspec46.core.pdf page 564), it is written:
No more than bufSize integers will be written into params.
The confusion may come from the man page where in one point it is said:
"No more than bufSize basic machine units will be written to this
memory." But the above description is still a number of integers.
Affects:
KHR-GL46.sparse_texture_tests.SparseDSATextureCommitment
KHR-GL46.sparse_texture_tests.SparseTextureAllocation
KHR-GL46.sparse_texture_tests.SparseTextureCommitment
KHR-GL46.sparse_texture_tests.TextureParameterQueries
KHR-GL46.sparse_texture_tests.InternalFormatQueries
Components: OpenGL
VK-GL-CTS issue: 1296
Change-Id: I05ea0cbe54539f6f8711278cb7b08ad7e5862aa9
Yabin Zheng [Fri, 27 Jul 2018 06:29:20 +0000 (14:29 +0800)]
Throw NotSupported if MAX_FRAGMENT_IMAGE_UNIFORMS = 0
GLES 3.1 implementations may expose MAX_FRAGMENT_IMAGE_UNIFORMS = 0
which would prevent KHR-GLES31.shaders.layout_location.*image.* tests
from running.
Components: OpenGL
Affects:
KHR-GLES31.shaders.layout_location.*
VK-GL-CTS issue: 1284
Change-Id: I41299b58da0e7ec46587f2893dfb4a3859516669
Kenneth Russell [Mon, 23 Jul 2018 22:26:47 +0000 (15:26 -0700)]
Add cases for structs as inout and out parameters.
Structs with lowp, mediump and highp (when supported in fragment
shaders) members are tested as inout and out parameters in both ES 2.0
and 3.0 shaders.
The highp variant of this test catches a bug which was found by the
Three.js community in https://github.com/mrdoob/three.js/issues/14137 .
Similar tests were integrated into the WebGL conformance suite in
https://github.com/KhronosGroup/WebGL/pull/2663 .
Verified on:
Qualcomm Adreno 308 (LG Aristo) - bug reproduces in both ES2 and ES3
highp fragment shaders
Qualcomm Adreno 540 (Pixel 2),
NVIDIA Tegra (SHIELD Tablet) - all tests pass
New tests:
dEQP-GLES[23].functional.shaders.struct.local.parameter_inout_*
dEQP-GLES[23].functional.shaders.struct.local.parameter_out_*
VK-GL-CTS Issue 1280
Change-Id: Ie332aede0ad52453815d9e123145ec035009430b
James Hauxwell [Fri, 13 Jul 2018 13:52:40 +0000 (14:52 +0100)]
Fix invalid combinations for texture/copy on ES2 driver
The OES_rgb8_rgba8 extension specification only specifies
RenderbufferStorageOES for additional GL_RGB8/GL_RGBA8 tokens. ES3 spec
made these mandatory formats for texturing/copying.
Affects:
KHR-GLES2.core.internalformat.texture2d.rgb_unsigned_byte_rgb8
KHR-GLES2.core.internalformat.texture2d.rgba_unsigned_byte_rgb8
KHR-GLES2.core.internalformat.copy_tex_image.rgba8
KHR-GLES2.core.internalformat.copy_tex_image.rgb8
Components: OpenGL
VK-GL-CTS issue: 1260
Change-Id: Icbbd8882c5e623f5ac4725eebf977f535cfbfa31
Tony Zlatinski [Thu, 16 Aug 2018 13:17:28 +0000 (08:17 -0500)]
Vulkan AHB - fix incorrect structure definition
Fix a missing VkComponentMapping field of the VkAndroidHardwareBufferFormatPropertiesANDROID
structure. This is causing incorrect values to be populated to the
structure, as well as, a stack overwrite of other stack-located locals.
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r8g8b8a8_unorm
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r5g6b5_unorm_pack16
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r16g16b16a16_sfloat
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.a2b10g10r10_unorm_pack32
Components: Vulkan
VK-GL-CTS issue: 1305
VK-GL-CTS issue: 1316
Change-Id: I81eb1cc605912bf0adebe67b65d7ccdd31236ec9
Daniel Koch [Thu, 16 Aug 2018 02:55:06 +0000 (22:55 -0400)]
Fix copy/paste errors in opundef assembly tests
The tests were using %is_nan_0 repeatedly instead of %is_nan_<i>
Affects: dEQP-VK.spirv_assembly.instruction.graphics.opundef.*
(likely only the vec4float32 and matrix subsets)
Component: Vulkan
VK-GL-CTS: 1315
Change-Id: I2bed6e94f6867c424c5102ef3eeab8ac32021dcd
(cherry picked from commit
a46089154137e0939c02bdcabc74f5daa303ffb2)
Ari Suonpaa [Wed, 8 Aug 2018 10:43:45 +0000 (13:43 +0300)]
Test push descriptors
Added uniform and storage buffer push descriptor tests. Tests for other
descriptor types should be added later.
New tests:
dEQP-VK.pipeline.push_descriptor.*
Components: Vulkan
VK-GL-CTS issue: 1187
Change-Id: I6c8a2ae96f23cff3da1cdeed1659da61e3aa347c
Boris Zanin [Wed, 4 Jul 2018 09:02:23 +0000 (11:02 +0200)]
Refactor: Compatible compute and graphics VerifyIO
Refactoring:
* Compatibilize VerifyIO function declaration
* Add isCoreFeatureSupported
* Graphic shader can run over whole area
Affects tests:
* dEQP-VK.spirv_assembly.*
Components: Vulkan
VK-GL-CTS issue: 1095
Change-Id: Iba9bab9d40a06f1eba90572cc60f1c334c4b8474
Slawomir Cygan [Thu, 12 Jul 2018 17:00:15 +0000 (19:00 +0200)]
Split subgroups tests into test groups
Subgroup test hierarchy was a bit too flat, with many test variants
added by permutating test case names.
This change splits the test into compute, graphic, framebuffer..
groups.
Components: Vulkan
VK-GL-CTS Issue: 1276
Affects: dEQP-VK.subgroups.*
Change-Id: I2a3c3a4ad8c5a8116d0c58b41d030b36eccc80e5
Treehugger Robot [Tue, 21 Aug 2018 01:12:31 +0000 (01:12 +0000)]
Merge "RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count"
Ostrowski, Igor [Fri, 9 Feb 2018 10:56:15 +0000 (11:56 +0100)]
RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count
This change add new tests for VK_KHR_draw_indirect_count
extension, and adds the extension to the whitelist.
New Tests:
dEQP-VK.draw.indirect_draw.*.indirect_draw_count.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_instanced.*
Note: for Android CTS backport, adjusted excluded test list to not impact
previously-passing implementations that don't care about this extension.
Affected tests:
dEQP-VK.api.info.device.extensions
Components: Vulkan, Framework
VK-GL-CTS issue: 1004
Bug: b/
111786155
Change-Id: I7078e1104c1ebd29320fa04afa20549757e56bc5
(cherry picked from Khronos commit
7b47cd53c6656b866e7c3a3c0a590da85f3b2de1)
(cherry picked from commit
43622dc64ce9f19461828b0bd62ca5342c26eb40)
Jiayuan Ren [Mon, 20 Aug 2018 21:55:58 +0000 (14:55 -0700)]
Fix: rendering complete times not monotonic am:
59b6ba9bb2 am:
c23074d57c
am:
85d1e56494
Change-Id: I163fbb3b0d80663561f5d2fcd67c9b8fa345a358
Jiayuan Ren [Mon, 20 Aug 2018 21:52:12 +0000 (14:52 -0700)]
Fix: rendering complete times not monotonic am:
59b6ba9bb2
am:
c23074d57c
Change-Id: I68ded1c7963a388629e34ba5c3fa59755c109ac9
Jiayuan Ren [Mon, 20 Aug 2018 21:48:05 +0000 (14:48 -0700)]
Fix: rendering complete times not monotonic
am:
59b6ba9bb2
Change-Id: I3a1fc45cf76cb1ca0b5cc0e84fceb7808d68537f
Colin Cross [Mon, 20 Aug 2018 17:21:55 +0000 (17:21 +0000)]
Merge "Revert "Revert "Convert external/deqp/android/cts to Android.bp"""
Chris Forbes [Sat, 18 Aug 2018 00:27:26 +0000 (17:27 -0700)]
Merge "Merge remote-tracking branch 'khronos/vulkan-cts-1.1.0' into HEAD" into pie-cts-dev
am:
b6c2ed7121
Change-Id: I95bd47a45fcaef4d89b765e1f29fb3db5e8f210c
Jiayuan Ren [Tue, 14 Aug 2018 19:09:01 +0000 (12:09 -0700)]
Fix: rendering complete times not monotonic
We run into an intermittent issue that two neighboring
frames have the same rendering complete timestamp.
The timers will always have finite granularity.
The timestamp is in nanosecond but the timer producing
these timestamps might not actually be able to produce
timestamps at 1ns resolution. When the timer used for
these events has not enough granularity, events that
happen very quickly right after one another will appear
as if they appear at the same point in time.
Two neighboring frames have the same timestamp is allowed.
Components: AOSP
VK-GL-CTS issue: 1311
Bug: b/
112778381
Affects:
dEQP-EGL.functional.get_frame_timestamps.*
Treehugger Robot [Fri, 17 Aug 2018 23:15:48 +0000 (23:15 +0000)]
Merge "Merge remote-tracking branch 'khronos/vulkan-cts-1.1.0' into HEAD" into pie-cts-dev
Julien Desprez [Fri, 17 Aug 2018 17:34:45 +0000 (17:34 +0000)]
Merge "Update CTS runner after TF interface update"
Ostrowski, Igor [Fri, 17 Aug 2018 01:58:49 +0000 (18:58 -0700)]
[automerger skipped] Merge "RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count" into oreo-mr1-cts-dev am:
9bbaf74230 -s ours
am:
a51e7a7d9c -s ours
Change-Id: Ia2a1e26d432456e0fd173e0f9878bf254f4272c8
Ostrowski, Igor [Fri, 17 Aug 2018 00:08:52 +0000 (17:08 -0700)]
[automerger skipped] RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count
am:
43622dc64c -s ours
Change-Id: Ifad35fa0297f9099e3da124153c8200f168611f0
Tony Zlatinski [Fri, 17 Aug 2018 00:06:12 +0000 (17:06 -0700)]
Vulkan AHB - fix incorrect structure definition
am:
181b5cd80e
Change-Id: Ie3c769146a1dc5862067e5a61a194300a7825168
Ostrowski, Igor [Fri, 17 Aug 2018 00:04:06 +0000 (17:04 -0700)]
[automerger skipped] Merge "RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count" into oreo-mr1-cts-dev
am:
9bbaf74230 -s ours
Change-Id: I4de7ad984886cb4508f9e5f408e8c8e610f75434
Chris Forbes [Thu, 16 Aug 2018 23:56:16 +0000 (16:56 -0700)]
Merge remote-tracking branch 'khronos/vulkan-cts-1.1.0' into HEAD
Change-Id: I8db2d3d6347c92f0f4fdd0d9db07a812a96243d8
Bug: b/
112439889
Ostrowski, Igor [Fri, 9 Feb 2018 10:56:15 +0000 (11:56 +0100)]
RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count
This change add new tests for VK_KHR_draw_indirect_count
extension, and adds the extension to the whitelist.
New Tests:
dEQP-VK.draw.indirect_draw.*.indirect_draw_count.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_instanced.*
Note: for Android CTS backport, adjusted excluded test list to not impact
previously-passing implementations that don't care about this extension.
Affected tests:
dEQP-VK.api.info.device.extensions
Components: Vulkan, Framework
VK-GL-CTS issue: 1004
Bug: b/
111786155
Change-Id: I3d53806eb1a45293a77b940d9c2fa540a6d83d50
(cherry picked from Khronos commit
7b47cd53c6656b866e7c3a3c0a590da85f3b2de1)
Tony Zlatinski [Thu, 16 Aug 2018 13:17:28 +0000 (08:17 -0500)]
Vulkan AHB - fix incorrect structure definition
Fix a missing VkComponentMapping field of the VkAndroidHardwareBufferFormatPropertiesANDROID
structure. This is causing incorrect values to be populated to the
structure, as well as, a stack overwrite of other stack-located locals.
Affects:
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r8g8b8a8_unorm
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r5g6b5_unorm_pack16
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.r16g16b16a16_sfloat
dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.a2b10g10r10_unorm_pack32
Components: Vulkan
VK-GL-CTS issue: 1305
VK-GL-CTS issue: 1316
Bug: b/
112705952
Change-Id: I81eb1cc605912bf0adebe67b65d7ccdd31236ec9
(cherry picked from Khronos commit
0116a17ddb4eb4f25624698bc0ba1c68e51a6950)
Treehugger Robot [Thu, 16 Aug 2018 18:47:59 +0000 (18:47 +0000)]
Merge "RESTRICT AUTOMERGE: Backport tests for VK_KHR_draw_indirect_count" into oreo-mr1-cts-dev
Colin Cross [Thu, 16 Aug 2018 18:16:01 +0000 (18:16 +0000)]
Revert "Revert "Convert external/deqp/android/cts to Android.bp""
This reverts commit
10848da9348e610bd6e938836ae846abcf540a3d.
Bug:
112654980
Change-Id: I5c5d5b932eb7df0b710668dadaf788344ca5b1e2
Daniel Koch [Thu, 16 Aug 2018 02:55:06 +0000 (22:55 -0400)]
Fix copy/paste errors in opundef assembly tests
The tests were using %is_nan_0 repeatedly instead of %is_nan_<i>
Affects: dEQP-VK.spirv_assembly.instruction.graphics.opundef.*
(likely only the vec4float32 and matrix subsets)
Component: Vulkan
VK-GL-CTS: 1315
Change-Id: I2bed6e94f6867c424c5102ef3eeab8ac32021dcd
Treehugger Robot [Wed, 15 Aug 2018 23:48:33 +0000 (23:48 +0000)]
Merge "Revert "Convert external/deqp/android/cts to Android.bp""
Colin Cross [Wed, 15 Aug 2018 21:55:29 +0000 (21:55 +0000)]
Revert "Convert external/deqp/android/cts to Android.bp"
This reverts commit
e674df42dddcba06641861912154be98a7937884.
Reason for revert: broke tradefed/general_tests_zip
Bug:
112654980
Change-Id: I251b5e2372cb9c7c12e87ce94c07222a97500406
Chris Forbes [Wed, 15 Aug 2018 14:49:36 +0000 (14:49 +0000)]
Merge "Fix build for surfaceless target"
Eric Anholt [Sat, 21 Jul 2018 00:52:28 +0000 (17:52 -0700)]
Avoid spurious failures in create_context when desktop GL 3.x is unsupported.
On a driver advertising GLES 3.0 and GL 2.1, the test was failing with:
Creating OpenGL context with config ID 29
Fail, context: 0x00000000, error: EGL_BAD_MATCH
This was because
b60ae978ad04 ("Handle unsupported no_config
contexts") added a requirement for GL 3.x, even though EGL doesn't
require that.
Affects: dEQP-EGL.functional.create_context.*
Components: AOSP
VK-GL-CTS issue: 1283
Change-Id: Id99ad51c1d0dca2c68e42a7bffe282f12a101027
Colin Cross [Wed, 15 Aug 2018 01:51:16 +0000 (01:51 +0000)]
Merge "Convert external/deqp/android/cts to Android.bp"
Julien Desprez [Tue, 14 Aug 2018 23:50:12 +0000 (16:50 -0700)]
Update CTS runner after TF interface update
Test: unit tests
Bug:
112468193
Change-Id: I82a0ef4c894ad56dc426e856cfb3dfdbb70d8edd
Chris Forbes [Tue, 14 Aug 2018 23:23:12 +0000 (16:23 -0700)]
Fix build for surfaceless target
Bug: crbug/873651
Change-Id: I80b88bd6022edbe7936c17e11d1f3f79d8b9500d
Components: Framework
Chris Forbes [Mon, 13 Aug 2018 23:35:16 +0000 (16:35 -0700)]
Merge remote-tracking branch 'khronos/vulkan-cts-1.0.2' into HEAD am:
d502cf9784
am:
c4a6a1e68a
Change-Id: I2bd6a3d3adf162ae02fceea8dcde436c66cc5c0f