Tim Collier [Wed, 26 Sep 2018 22:06:18 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_cat_lnx in p80211metadef.h
Rename DIDmib_cat_lnx in p80211metadef.h to DIDMIB_CAT_LNX to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:17 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyDSSSTable_dot11CurrentChannel in p80211metadef.h
Rename DIDmib_dot11phy_dot11PhyDSSSTable_dot11CurrentChannel in
p80211metadef.h to DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines. Also shorten name by removing repeated use of
"DOT11" and "DOT11PHY" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:16 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyDSSSTable in p80211metadef.h
Rename DIDmib_dot11phy_dot11PhyDSSSTable in p80211metadef.h to
DIDMIB_DOT11PHY_DSSSTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "DOT11PHY" to ease readability and
reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:15 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel in p80211metadef.h
Rename DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel
in p80211metadef.h to DIDMIB_DOT11PHY_TXPOWERTABLE_CURRENTTXPOWERLEVEL
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines. Also shorten name by removing repeated use of
"DOT11" and "DOT11PHY" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:14 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyOperationTable in p80211metadef.h
Rename DIDmib_dot11phy_dot11PhyOperationTable in p80211metadef.h to
DIDMIB_DOT11PHY_OPERATIONTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "DOT11PHY" to ease readability and
reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:13 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_cat_dot11phy in p80211metadef.h
Rename DIDmib_cat_dot11phy in p80211metadef.h to DIDMIB_CAT_DOT11PHY
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:12 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime in p80211metadef.h
Rename
DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime in
p80211metadef.h to
DIDMIB_DOT11MAC_OPERATIONTABLE_MAXTRANSMITMSDULIFETIME to fix "Avoid
CamelCase" message from checkpatch and conform to the coding style
guidelines. Also shorten name by removing repeated use of "DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:11 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold
in p80211metadef.h to
DIDMIB_DOT11MAC_OPERATIONTABLE_FRAGMENTATIONTHRESHOLD to fix "Avoid
CamelCase" message from checkpatch and conform to the coding style
guidelines. Also shorten name by removing repeated use of "DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:10 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11LongRetryLimit in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable_dot11LongRetryLimitin
p80211metadef.h to DIDMIB_DOT11MAC_OPERATIONTABLE_LONGRETRYLIMIT to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:09 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11ShortRetryLimit in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable_dot11ShortRetryLimit in
p80211metadef.h to DIDMIB_DOT11MAC_OPERATIONTABLE_SHORTRETRYLIMIT to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:08 +0000 (23:06 +0100)]
staging: wlan-ng: DIDmib_dot11mac_dot11OperationTable_dot11RTSThreshold in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable_dot11RTSThreshold in
p80211metadef.h to DIDMIB_DOT11MAC_OPERATIONTABLE_RTSTHRESHOLD to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:07 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11MACAddress in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable_dot11MACAddress in
p80211metadef.h to DIDMIB_DOT11MAC_OPERATIONTABLE_MACADDRESS to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:06 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable in p80211metadef.h
Rename DIDmib_dot11mac_dot11OperationTable in p80211metadef.h to
DIDMIB_DOT11MAC_OPERATIONTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "DOT11" to ease readability and
reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:05 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable_dot11ExcludeUnencrypted in p80211metadef.h
Rename DIDmib_dot11smt_dot11PrivacyTable_dot11ExcludeUnencrypted in
p80211metadef.h to DIDMIB_DOT11SMT_PRIVACYTABLE_EXCLUDEUNENCRYPTED to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:04 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID in p80211metadef.h
Rename DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID in
p80211metadef.h to DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID to fix
"Avoid CamelCase" message from checkpatch and conform to the coding
style guidelines. Also shorten name by removing repeated use of
"DOT11" to ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:03 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable_dot11PrivacyInvoked in p80211metadef.h
Rename DIDmib_dot11smt_dot11PrivacyTable_dot11PrivacyInvoked to
DIDMIB_DOT11SMT_PRIVACYTABLE_PRIVACYINVOKED to fix "Avoid CamelCase"
message from checkpatch and conform to the coding style
guidelines. Also shorten name by removing repeated use of "DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:02 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable in p80211metadef.h
Rename DIDmib_dot11smt_dot11PrivacyTable to
DIDMIB_DOT11SMT_PRIVACYTABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines. Also shorten
name by removing repeated use of "DOT11" to ease readability and
reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:01 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable_key in p80211metadef.h
Rename DIDmib_dot11smt_dot11WEPDefaultKeysTable_key in p80211metadef.h
to didmib_dot11smt_wepdefaultkeystable_key to fix "Avoid CamelCase"
message from checkpatch and conform to the coding style
guidelines. Also shorten name by removing repeated use of "DOT11" to
ease readability and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:06:00 +0000 (23:06 +0100)]
staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable in p80211metadef.h
Rename DIDmib_dot11smt_dot11WEPDefaultKeysTable in p80211metadef.h to
DIDMIB_DOT11SMT_WEPDEFAULTKEYSTABLE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines. Also
shorten name by removing repeated use of "DOT11" to ease readability
and reduce long lines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:59 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmib_cat_dot11smt in p80211metadef.h
Rename DIDmib_cat_dot11smt in p80211metadef.h to DIDMIB_CAT_DOT11SMT
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:58 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_flashdl_write in p80211metadef.h
Rename DIDmsg_p2req_flashdl_write in p80211metadef.h to
DIDMSG_P2REQ_FLASHDL_WRITE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:57 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_flashdl_state in p80211metadef.h
Rename DIDmsg_p2req_flashdl_state in p80211metadef.h to
DIDMSG_P2REQ_FLASHDL_STATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:56 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_resultcode in p80211metadef.h
Rename DIDmsg_p2req_ramdl_write_resultcode in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:55 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_data in p80211metadef.h
Rename DIDmsg_p2req_ramdl_write_data in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_DATA to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:54 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_len in p80211metadef.h
Rename DIDmsg_p2req_ramdl_write_len to DIDMSG_P2REQ_RAMDL_WRITE_LEN to
fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:53 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_addr in p80211metadef.h
Rename DIDmsg_p2req_ramdl_write_addr in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE_ADDR to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:52 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_write in p80211metadef.h
Rename DIDmsg_p2req_ramdl_write in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_WRITE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:51 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_resultcode in p80211metadef.h
Rename DIDmsg_p2req_ramdl_state_resultcode in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:50 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_exeaddr in p80211metadef.h
Rename DIDmsg_p2req_ramdl_state_exeaddr in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_EXEADDR to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:49 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_enable in p80211metadef.h
Rename DIDmsg_p2req_ramdl_state_enable in p80211metadef.h to
DIDMSG_P2REQ_RAMDL_STATE_ENABLE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:48 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_ramdl_state in p80211metadef.h
Rename DIDmsg_p2req_ramdl_state to DIDMSG_P2REQ_RAMDL_STATE in
p80211metadef.h to fix "Avoid CamelCase" message from checkpatch and
conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:47 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_readpda_resultcode in p80211metadef.h
Rename DIDmsg_p2req_readpda_resultcode in p80211metadef.h to
DIDMSG_P2REQ_READPDA_RESULTCODE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:46 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11ind_associate in p80211metadef.h
Rename DIDmsg_dot11ind_associate in p80211metadef.h to
DIDMSG_DOT11IND_ASSOCIATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:45 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_readpda_pda in p80211metadef.h
Rename DIDmsg_p2req_readpda_pda in p80211metadef.h to
DIDMSG_P2REQ_READPDA_PDA to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:44 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_p2req_readpda in p80211metadef.h
Rename DIDmsg_p2req_readpda in p80211metadef.h to DIDMSG_P2REQ_READPDA
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:43 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_lnxreq_autojoin in p80211metadef.h
Rename DIDmsg_lnxreq_autojoin in p80211metadef.h to
DIDMSG_LNXREQ_AUTOJOIN to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:42 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_lnxreq_commsquality in p80211metadef.h
Rename DIDmsg_lnxreq_commsquality in p80211metadef.h to
DIDMSG_LNXREQ_COMMSQUALITY to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:41 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_lnxreq_hostwep in p80211metadef.h
Rename DIDmsg_lnxreq_hostwep in p80211metadef.h to
DIDMSG_LNXREQ_HOSTWEP to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:40 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_lnxreq_wlansniff in p80211metadef.h
Rename DIDmsg_lnxreq_wlansniff in p80211metadef.h to
DIDMSG_LNXREQ_WLANSNIFF to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:39 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_lnxreq_ifstate in p80211metadef.h
Rename DIDmsg_lnxreq_ifstate in p80211metadef.h to
DIDMSG_LNXREQ_IFSTATE to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:38 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11ind_authenticate in p80211metadef.h
Rename DIDmsg_dot11ind_authenticate in p80211metadef.h to
DIDMSG_DOT11IND_AUTHENTICATE to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:37 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_start in p80211metadef.h
Rename DIDmsg_dot11req_start in p80211metadef.h to
DIDMSG_DOT11REQ_START to fix "Avoid CamelCase" message from checkpatch
and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:36 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_scan_results in p80211metadef.h
Rename DIDmsg_dot11req_scan_results in p80211metadef.h to
DIDMSG_DOT11REQ_SCAN_RESULTS to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:35 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_scan in p80211metadef.h
Rename DIDmsg_dot11req_scan in p80211metadef.h to DIDMSG_DOT11REQ_SCAN
to fix "Avoid CamelCase" message from checkpatch and conform to the
coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:34 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibset_resultcode in p80211metadef.h
Rename DIDmsg_dot11req_mibset_resultcode in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:33 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibset_mibattribute in p80211metadef.h
Rename DIDmsg_dot11req_mibset_mibattribute in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET_MIBATTRIBUTE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:32 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibset in p80211metadef.h
Rename DIDmsg_dot11req_mibset in p80211metadef.h to
DIDMSG_DOT11REQ_MIBSET to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:31 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibget_resultcode in p80211metadef.h
Rename DIDmsg_dot11req_mibget_resultcode in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET_RESULTCODE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:30 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibget_mibattribute in p80211metadef.h
Rename DIDmsg_dot11req_mibget_mibattribute in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET_MIBATTRIBUTE to fix "Avoid CamelCase" message
from checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Collier [Wed, 26 Sep 2018 22:05:29 +0000 (23:05 +0100)]
staging: wlan-ng: rename DIDmsg_dot11req_mibget in p80211metadef.h
Rename DIDmsg_dot11req_mibget in p80211metadef.h to
DIDMSG_DOT11REQ_MIBGET to fix "Avoid CamelCase" message from
checkpatch and conform to the coding style guidelines.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
YueHaibing [Fri, 28 Sep 2018 02:21:53 +0000 (02:21 +0000)]
staging: rtlwifi: Remove set but not used variable 'ppsc'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c: In function 'halbtc_leave_lps':
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:284:21: warning:
variable 'ppsc' set but not used [-Wunused-but-set-variable]
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c: In function 'halbtc_enter_lps':
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:307:21: warning:
variable 'ppsc' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nathan Chancellor [Fri, 28 Sep 2018 00:50:39 +0000 (17:50 -0700)]
staging: bcm2835-camera: Avoid unneeded internal declaration warning
Clang warns:
drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning:
variable 'mains_freq_qmenu' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static const s64 mains_freq_qmenu[] = {
^
1 warning generated.
This is because mains_freq_qmenu is currently only used in an ARRAY_SIZE
macro, which is a compile time evaluation in this case. Avoid this by
adding mains_freq_qmenu as the imenu member of this structure, which
matches all other controls that uses the ARRAY_SIZE macro in v4l2_ctrls.
This turns out to be a no-op because V4L2_CID_MPEG_VIDEO_BITRATE_MODE is
defined as a MMAL_CONTROL_TYPE_STD_MENU, which does not pass the imenu
definition along to v4l2_ctrl_new in bm2835_mmal_init_controls.
Link: https://github.com/ClangBuiltLinux/linux/issues/122
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Thu, 27 Sep 2018 22:28:14 +0000 (23:28 +0100)]
staging: rtl8723bs: Skip unnecessary field checks
Skip unnecessary request field checks when the information element
pointer is null.
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Whitmore [Wed, 26 Sep 2018 19:17:04 +0000 (20:17 +0100)]
staging:rtl8192u: Remove potential memory leak
Add call to ieee80211_networks_free() to avoid potential memory
leak if allocation of pHTInfo fails.
If the third allocation fails only the first successful allocation
is freed, not the second.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Whitmore [Wed, 26 Sep 2018 19:16:55 +0000 (20:16 +0100)]
staging:rtl8192u: Move HTSetConnectBwModeCallback() - Style
The function HTSetConnectBwModeCallback() is only used in the file
in which it is defined, so has been changed to being of type 'static'.
Additionally the function is defined after it is used so a prototype
was included in the file. This prototype, in the middle of the file
has been removed and the function implementation moved so that it is
defined before it is used in the file.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Whitmore [Wed, 26 Sep 2018 19:16:54 +0000 (20:16 +0100)]
staging:rtl8192u: Remove definition of HTSetConnectBwMode - Style
Remove the redundant declaration of the function HTSetConnectBwMode()
as it is not needed in the code. The function is already declared
in header file, multiple declarations add nothing.
This is a style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Whitmore [Wed, 26 Sep 2018 19:16:53 +0000 (20:16 +0100)]
staging:rtl8192u: Make HTMcsToDataRate static - Style
The function HTMcsToDataRate() is not used outside the file in which
it is defined, so has been declared as 'static' and the prototype
removed from the header file.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Whitmore [Wed, 26 Sep 2018 19:16:52 +0000 (20:16 +0100)]
staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style
The function HTHalfMcsToDataRate() is unused in code so has simply
been removed from the code.
As a result two static functions, (IsHTHalfNmode40Bandwidth and
IsHTHalfNmodeSGI), are not longer called, so they have been removed
as well.
These are coding style changes which should have no impact on
runtime code execution.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Thu, 27 Sep 2018 12:17:49 +0000 (13:17 +0100)]
staging: wilc1000: fix incorrect allocation size for structure
Currently the allocation for str_vals is for the sizeof the pointer
rather than the size of the structure. Fix this.
Detected by smatch
"wilc_wlan_cfg_init() error: not allocating enough data 392 vs 8"
Fixes:
acceb12a9f8b ("staging: wilc1000: refactor code to avoid static variables for config parameters")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Thu, 27 Sep 2018 21:19:11 +0000 (22:19 +0100)]
staging: rtl8188eu: Skip unnecessary field checks
Skip unnecessary request field checks when the information element
pointer is null.
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Thu, 27 Sep 2018 12:16:40 +0000 (14:16 +0200)]
staging: rtl8188eu: remove get_right_chnl_for_iqk()
The function get_right_chnl_for_iqk() only returns non zero values for
channels > 14. According to the TODO, code valid only for 5 GHz should
be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Remove get_right_chnl_for_iqk() and the variable chn_index that is
used to save the return value. Replace the uses of chn_index with zero.
Remove the now unused define ODM_TARGET_CHNL_NUM_2G_5G.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nathan Chancellor [Thu, 27 Sep 2018 00:32:01 +0000 (17:32 -0700)]
staging: rtl8188eu: Use proper enum in rtl8188eu_config_rf_reg
Clang warns when an enumerated type is implicitly converted to another.
drivers/staging/rtl8188eu/hal/rf_cfg.c:180:25: warning: implicit
conversion from enumeration type 'enum rf90_radio_path' to different
enumeration type 'enum rf_radio_path' [-Wenum-conversion]
rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
~~~~~~~~~~~~~~~ ^~~~~~~~~~~
1 warning generated.
Avoid this by using the equivalent value from the expected type,
rf_radio_path:
RF90_PATH_A = RF_PATH_A = 0
Link: https://github.com/ClangBuiltLinux/linux/issues/164
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 26 Sep 2018 20:04:08 +0000 (22:04 +0200)]
staging: rtl8188eu: use break to exit while loop
The variable bContinual is only used to break out of the while loop.
Remove the variable and use break instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 26 Sep 2018 20:04:07 +0000 (22:04 +0200)]
staging: rtl8188eu: rename variable - style
Rename the return value variable in some functions in rtw_efuse.c
to avoid CamelCase. bRet -> ret
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 26 Sep 2018 20:04:06 +0000 (22:04 +0200)]
staging: rtl8188eu: do not line break function definition - style
Do not line break function definition. Clears a checkpatch issue.
CHECK: Lines should not end with a '('
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 26 Sep 2018 20:04:05 +0000 (22:04 +0200)]
staging: rtl8188eu: simplify function comments - style
Simplify function comments. Clears a 'line over 80 characters'
checkpatch warning.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Wed, 26 Sep 2018 13:34:05 +0000 (14:34 +0100)]
staging: rtl8188eu: fix spelling mistake "transfoer_len" -> "transfer_len"
Trivial fix to spelling mistake in DBG_88E debug message text.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nathan Chancellor [Tue, 25 Sep 2018 19:13:26 +0000 (12:13 -0700)]
staging: rtl8188eu: Simplify memcmp logical checks
Clang generates a warning when it sees a logical not followed by a
conditional operator like ==, >, or < because it thinks that the logical
not should be applied to the whole statement:
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:293:8: warning: logical
not is only applied to the left hand side of this comparison
[-Wlogical-not-parentheses]
It assumes the author might have made a mistake in their logic:
if (!a == b) -> if (!(a == b))
Sometimes that is the case; other times, it's just a super convoluted
way of saying 'if (a)' when b = 0:
if (!1 == 0) -> if (0 == 0) -> if (true)
Alternatively:
if (!1 == 0) -> if (!!1) -> if (1)
Simplify these comparisons so that Clang doesn't complain.
Link: https://github.com/ClangBuiltLinux/linux/issues/161
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Thu, 20 Sep 2018 13:22:25 +0000 (14:22 +0100)]
staging: rts5208: Remove unnecessary braces {}
This patch fixes the checkpatch.pl warning "braces {} are not necessary"
in the rts5208 driver. Mostly applies to single-line return/goto if
blocks.
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 21 Sep 2018 09:28:51 +0000 (11:28 +0200)]
staging: most: fix label names
This patch makes use of label names that say what the goto
actually does, as recommended in the kernel documentation.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 25 Sep 2018 11:25:21 +0000 (13:25 +0200)]
staging: rtl8188eu: remove rtw_qos.h
There is only one struct in rtw_qos.h and it is only included from
drv_types.h. Move the struct into drv_types.h to reduce the number
of header files.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Tue, 25 Sep 2018 11:25:20 +0000 (13:25 +0200)]
staging: rtl8188eu: remove unused rtw_scan_abort()
The function rtw_scan_abort() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nathan Chancellor [Fri, 21 Sep 2018 17:37:23 +0000 (10:37 -0700)]
staging: rtl8188eu: Remove unnecessary parentheses
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:295:21: warning: equality
comparison with extraneous parentheses [-Wparentheses-equality]
if ((pwrpriv->rpwm == pslv)) {
~~~~~~~~~~~~~~^~~~~~~
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:295:21: note: remove
extraneous parentheses around the comparison to silence this warning
if ((pwrpriv->rpwm == pslv)) {
~ ^ ~
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c:295:21: note: use '=' to
turn this equality comparison into an assignment
if ((pwrpriv->rpwm == pslv)) {
^~
=
drivers/staging/rtl8188eu/hal/odm.c:1062:27: warning: equality
comparison with extraneous parentheses [-Wparentheses-equality]
if ((pregpriv->wifi_spec == 1))/* (pmlmeinfo->HT_enable == 0))
*/
~~~~~~~~~~~~~~~~~~~~^~~~
drivers/staging/rtl8188eu/hal/odm.c:1062:27: note: remove extraneous
parentheses around the comparison to silence this warning
if ((pregpriv->wifi_spec == 1))/* (pmlmeinfo->HT_enable == 0))
*/
~ ^ ~
drivers/staging/rtl8188eu/hal/odm.c:1062:27: note: use '=' to turn this
equality comparison into an assignment
if ((pregpriv->wifi_spec == 1))/* (pmlmeinfo->HT_enable == 0))
*/
^~
=
Link: https://github.com/ClangBuiltLinux/linux/issues/163
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arkadiusz Lis [Mon, 24 Sep 2018 17:34:22 +0000 (19:34 +0200)]
staging: emxx_udc: remove unnecessary nullpointer checks
This patch removes nullpointer checks which are redundant. container_of
returns structure containing entity which we know for sure is not null,
so the whole structure can not be null.
Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Tue, 25 Sep 2018 08:34:00 +0000 (09:34 +0100)]
staging: bcm2835-camera: Remove unused header
Remove the asm/cacheflush.h header include from mmal-vchiq.c. This
dependency was removed in:
commit
7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Tue, 25 Sep 2018 08:33:59 +0000 (09:33 +0100)]
staging: bcm2835-camera: Update TODO
Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:
commit
7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Mon, 24 Sep 2018 16:25:25 +0000 (17:25 +0100)]
staging: rtl8723bs: fix spelling mistake "toogle" -> "toggle"
Trivial fix to spelling mistake in struct field name
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Mon, 24 Sep 2018 17:30:31 +0000 (18:30 +0100)]
staging: rtl8723bs: fix spelling mistake "unvalid" -> "invalid"
Trivial fix to spelling mistake in DBG_871X debug messages.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Sun, 23 Sep 2018 09:25:55 +0000 (11:25 +0200)]
staging: rtl8188eu, rtl8723bs: fix spelling mistake "evet" -> "event"
Trivial fix to spelling mistake in RT_TRACE message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aymen Qader [Thu, 20 Sep 2018 22:53:21 +0000 (23:53 +0100)]
staging: sm750fb: Fix typo frambuffer->framebuffer
This patch corrects a typo (frambuffer->framebuffer) in the
sm750fb_fram(e)buffer_release and sm750fb_fram(e)buffer_alloc function
names.
Signed-off-by: Aymen Qader <qader.aymen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:44 +0000 (11:53 +0530)]
staging: wilc1000: return exact error of register_netdev() from wilc_netdev_init()
Refactor wilc_netdev_init() to return the error code received from
register_netdev() during the failure condition.
Earlier discussion link
[1]. https://www.spinics.net/lists/linux-wireless/msg177304.html
Suggested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:43 +0000 (11:53 +0530)]
staging: wilc1000: refactor wilc_set_multicast_list() function
Refactor wilc_set_multicast_list() by making below changes:
o use kmalloc_array
o remove unnecessary res
o add u8 *cur_mc
o use i as index
o use '%pM' extension in netdev_dbg()
The below checkpatch issue is also resolved after code refactor.
'spaces preferred around that '/' (ctx:VxV)'
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:42 +0000 (11:53 +0530)]
staging: wilc1000: use usleep_range() in place of udelay()
Changes to avoid the below checkpatch warning:
'usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt;'
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:41 +0000 (11:53 +0530)]
staging: wilc1000: remove unnecessary option used with ccflags-y in Makefile
Cleanup patch to remove -I(src) and -DWILC_ASIC_A0 option used in
ccflag-y in Makefile.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:40 +0000 (11:53 +0530)]
staging: wilc1000: remove wilc_debugfs.c file as its not used
Deleted wilc_debugfs.c file as it's not used.
Earlier discussion link:
[1]. https://www.spinics.net/lists/linux-wireless/msg176076.html
Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:39 +0000 (11:53 +0530)]
staging: wilc1000: remove p2p related static variables to wilc_vif struct
Avoid use of static variable and move them as part of private
data(wilc_priv) struct.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:38 +0000 (11:53 +0530)]
staging: wilc1000: remove unnecessary memset in sdio_init() & wilc_spi_init()
Cleanup changes to avoid unnecessary setting 'wilc->bus_data' value to
zero as the buffer was allocated using kzalloc().
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:37 +0000 (11:53 +0530)]
staging: wilc1000: avoid use of 'g_spi' static variable
Instead of using static variable 'g_spi' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and
free is taken care in wilc_netdev_cleanup().
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:36 +0000 (11:53 +0530)]
staging: wilc1000: avoid use of 'g_sdio' static variable
Instead of using static variable 'g_sdio' move it as part of 'wilc'
struct. Also allocating the memory in the probe function and free during
deinitialization.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:35 +0000 (11:53 +0530)]
staging: wilc1000: remove use of unnecessary 'wilc_connected_ssid' variable
'wilc_connected_ssid' actually used to store the BSSID information for
connected BSSID. 'wilc_vif' already has 'bssid' variable to store the
same information. So refactor code to remove 'wilc_connected_ssid' and
instead used 'wilc_vif' struct 'bssid' element.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:34 +0000 (11:53 +0530)]
staging: wilc1000: avoid the use of 'hif_driver_comp' completion variable
Instead of using extra completion variable to handle the sync call now
using msg->is_sync flag to handle the sync call.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:33 +0000 (11:53 +0530)]
staging: wilc1000: rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals'
Rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' as its more
appropriate for structure to store the values of string configuration.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:32 +0000 (11:53 +0530)]
staging: wilc1000: refactor code to avoid static variables for config parameters
Refactor the code in wilc_wlan_cfg.c file to avoid the use of static
variables. Move the static variables as part of wilc struct and also
dynamically allocating memory for keeping those variables.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:31 +0000 (11:53 +0530)]
staging: wilc1000: refactor code to remove 'mac_status' from 'wilc_mac_cfg' struct
Refactor the code by removing use of 'mac_status' from 'wilc_mac_cfg'
and only have the string type configuration values in 'wilc_mac_cfg'
struct. Now fetch the value 'WID_STATUS' configuration from 'g_cfg_byte'
array.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:30 +0000 (11:53 +0530)]
staging: wilc1000: remove unused wid from cfg struct
Cleanup patch to remove the unused element stored in cfg struct.
Removed those wid from the cfg variables whose value is not
fetched(GET_CFG) from the code. In case the wid is only set to the
firmware then there is need to store them as part of cfg variables, so
removed the unused code.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:29 +0000 (11:53 +0530)]
staging: wilc1000: remove unused wid type values
Cleanup patch to remove the wid type not used in the code.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:28 +0000 (11:53 +0530)]
staging: wilc1000: changes 'val' type to u8 in wilc_cfg_byte struct
Use the correct datatype for storing the byte value in 'wilc_cfg_byte'
struct.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:27 +0000 (11:53 +0530)]
staging: wilc1000: set default value of cfg response type in wilc_wlan_cfg_indicate_rx()
Handle the setting of default value for 'wilc_cfg_rsp' type for all
cases in wilc_wlan_cfg_indicate_rx() as the caller make use of this
value to know the type of the received message.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:26 +0000 (11:53 +0530)]
staging: wilc1000: refactor wilc_wlan_parse_info_frame() function
Return 'void' from wilc_wlan_parse_info_frame() as same constant value
is returned always. Also removed the 'size' from input parameter as its
not used in the function.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ajay Singh [Tue, 25 Sep 2018 06:23:25 +0000 (11:53 +0530)]
staging: wilc1000: change return type to 'void' for wilc_wlan_cfg_indicate_rx()
Cleanup patch to use 'void' return type for wilc_wlan_cfg_indicate_rx(),
as its return value is not used in caller. The value set in
'rsp' argument is used to get the success status.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log