platform/upstream/dotnet/runtime.git
5 years agoUpdate packageIndex.json with packages from release branches (dotnet/corefx#37600)
Jose Perez Rodriguez [Tue, 21 May 2019 23:58:45 +0000 (16:58 -0700)]
Update packageIndex.json with packages from release branches (dotnet/corefx#37600)

* Update packageIndex.json with packages from release branches

* Fixing last packaging validation errors

Commit migrated from https://github.com/dotnet/corefx/commit/8d0428194d69a8d7fb249a9f4ef780cb4cd54de4

5 years agoAdd Utc test to ensure creating only one instance (dotnet/corefx#37721)
Tarek Mahmoud Sayed [Tue, 21 May 2019 21:39:09 +0000 (14:39 -0700)]
Add Utc test to ensure creating only one instance (dotnet/corefx#37721)

* Add Utc test to ensure creating only one instance

* Address the feedback

Commit migrated from https://github.com/dotnet/corefx/commit/39c7df85afee9ddc8bc1a1726a92526d43b1959f

5 years agoExclude non netcoreapp packages from OOB package (dotnet/corefx#37845)
Viktor Hofer [Tue, 21 May 2019 19:16:50 +0000 (12:16 -0700)]
Exclude non netcoreapp packages from OOB package (dotnet/corefx#37845)

Commit migrated from https://github.com/dotnet/corefx/commit/008d21c47c22b5757e09f6c3d346998004a0f985

5 years agoAvoid StackOverflowException when cyclic enumerable Type (dotnet/corefx#37818)
Steve Harter [Tue, 21 May 2019 18:50:53 +0000 (11:50 -0700)]
Avoid StackOverflowException when cyclic enumerable Type (dotnet/corefx#37818)

Commit migrated from https://github.com/dotnet/corefx/commit/857d1d1a9e1cd3597e3b1488f119d3a52e8b921a

5 years agoUpdate ProjectNTfs to beta-27721-00 (dotnet/corefx#37832)
dotnet-maestro-bot [Tue, 21 May 2019 17:32:31 +0000 (10:32 -0700)]
Update ProjectNTfs to beta-27721-00 (dotnet/corefx#37832)

Commit migrated from https://github.com/dotnet/corefx/commit/a70f241c0096ed2695333faaa08811e09e947a80

5 years agoAdding some additional tests to validating formatting is correct with regards to...
Tanner Gooding [Tue, 21 May 2019 11:09:12 +0000 (04:09 -0700)]
Adding some additional tests to validating formatting is correct with regards to rounding. (dotnet/corefx#37820)

Commit migrated from https://github.com/dotnet/corefx/commit/b3ac650a36e2fa04988fb37c4a0a3195a9e2dc36

5 years agoAs Span and As Memory apis added for immutable arrays (dotnet/corefx#37757)
Anirudh Agnihotry [Tue, 21 May 2019 06:42:55 +0000 (23:42 -0700)]
As Span and As Memory apis added for immutable arrays (dotnet/corefx#37757)

* As Span and As memory added for immutable arrays

* Fixing netstandard build

* using a more generic compile constant

* fixing build for netcoreapp

* building fix for netfx and netstandard

* fixing netstandard1.0, using generateRefereceASource to get ref file, tests for string and default immutable arrays

Commit migrated from https://github.com/dotnet/corefx/commit/51a1f16ee2aaded4ce1fca6847471b58f7ffa160

5 years agoReenable ModifyStore tests (dotnet/corefx#37827)
Viktor Hofer [Tue, 21 May 2019 05:40:49 +0000 (07:40 +0200)]
Reenable ModifyStore tests (dotnet/corefx#37827)

Commit migrated from https://github.com/dotnet/corefx/commit/11eba7947e9736109c588a1cfcb77987cb80f570

5 years agoImplement GetComment API (dotnet/corefx#35705)
Mandar Sahasrabuddhe [Tue, 21 May 2019 02:25:22 +0000 (07:55 +0530)]
Implement GetComment API (dotnet/corefx#35705)

* CoreFx dotnet/corefx#33347: Implement GetComment API

* Generate References as per correct steps

* Exclude delims & line separators, new unescape test

* Revert consume comment changes, test case fixes

* Partial revert of previous incorrect online merge

* fixed another online merge conflict resolution slippage

* Intermediate rebase from master

* Reworked files

* Reworked files 2

* Fix coding sytle as per review comments

Commit migrated from https://github.com/dotnet/corefx/commit/53aaaf3c848e4e737420de2b46f7cace397d730a

5 years agoAdd Microsoft.Private.CoreFx.OOB package (dotnet/corefx#37784)
Viktor Hofer [Tue, 21 May 2019 00:18:36 +0000 (02:18 +0200)]
Add Microsoft.Private.CoreFx.OOB package (dotnet/corefx#37784)

* Add Microsoft.Private.CoreFx.OOB package

Commit migrated from https://github.com/dotnet/corefx/commit/ef1a5aa730098b6c3350977a991232c1ff11cfe3

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37746)
dotnet-maestro[bot] [Tue, 21 May 2019 00:15:57 +0000 (17:15 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37746)

* Update dependencies from https://github.com/dotnet/coreclr build 20190516.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27716-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27716-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27716-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190517.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27717-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27717-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27717-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190518.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27718-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27718-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27718-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190519.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27719-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27719-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27719-72

* Fix ref assemblies due to change in coreclr

* Fix serialization tests after TimeZone change

Commit migrated from https://github.com/dotnet/corefx/commit/c85411a30c2c3a1d6ad3beea7be92b19b1e24df9

5 years agoConverting SystemColors into InstanceDescriptors using Color Convertor (dotnet/corefx...
Anirudh Agnihotry [Mon, 20 May 2019 23:40:01 +0000 (16:40 -0700)]
Converting SystemColors into InstanceDescriptors using Color Convertor (dotnet/corefx#37810)

* fixed converting systemcolors into instance Descriptor using colorConvertor

* doing a color check first

* checking if right property is returned

Commit migrated from https://github.com/dotnet/corefx/commit/f403c576995dd5860af48226d3ffaec873094ca9

5 years agoUpdate supported architectures on Windows in docs
Viktor Hofer [Mon, 20 May 2019 23:05:32 +0000 (01:05 +0200)]
Update supported architectures on Windows in docs

Commit migrated from https://github.com/dotnet/corefx/commit/e94ff8a041014decb591ecff475792d68603ca70

5 years agoUpdate docs with Outerloop changes
Viktor Hofer [Mon, 20 May 2019 23:04:24 +0000 (01:04 +0200)]
Update docs with Outerloop changes

Commit migrated from https://github.com/dotnet/corefx/commit/5f61457d4f8ab9daff042c168c34fced70f2fda2

5 years agoGenerate System.Runtime.Extensions reference assembly against implementation (dotnet...
Santiago Fernandez Madero [Mon, 20 May 2019 22:39:16 +0000 (15:39 -0700)]
Generate System.Runtime.Extensions reference assembly against implementation (dotnet/corefx#37811)

Commit migrated from https://github.com/dotnet/corefx/commit/2e1d93ea69e703345d4f8396aba5a9e47c965dea

5 years agoEnsure JsonException is thrown parsing invalid DateTime, DateTimeOffset, and Guid...
Christopher Watford [Mon, 20 May 2019 19:11:17 +0000 (15:11 -0400)]
Ensure JsonException is thrown parsing invalid DateTime, DateTimeOffset, and Guid dotnet/corefx#37807 (dotnet/corefx#37809)

* Add tests to cover dotnet/corefx#36901 and dotnet/corefx#37807

* Ensure DateTime(Offset) and Guid throw JsonException dotnet/corefx#37807

- The original JsonValueConverterXXX code for these allowed an InvalidOperationException
to be raised from Utf8JsonReader.TryGetXXX, instead of returning false so a JsonException
could be thrown.

Commit migrated from https://github.com/dotnet/corefx/commit/3ff5c4a6eb6315c61cfb0078245c31b59f798290

5 years agoUpdate ProjectNTfs to beta-27720-00 (dotnet/corefx#37792)
dotnet-maestro-bot [Mon, 20 May 2019 16:41:15 +0000 (09:41 -0700)]
Update ProjectNTfs to beta-27720-00 (dotnet/corefx#37792)

Commit migrated from https://github.com/dotnet/corefx/commit/7373fd9794c4b52c2a4d253cc2bc4b47c2054241

5 years agoFix testscope usage in yml and sh script (dotnet/corefx#37805)
Viktor Hofer [Mon, 20 May 2019 16:25:58 +0000 (18:25 +0200)]
Fix testscope usage in yml and sh script (dotnet/corefx#37805)

Commit migrated from https://github.com/dotnet/corefx/commit/889491763322134a1a184f3d54eb1f3605949d33

5 years agoAdd string-based WriteAsProperty overload to JsonElement. (dotnet/corefx#37789)
Ahson Khan [Mon, 20 May 2019 09:57:17 +0000 (02:57 -0700)]
Add string-based WriteAsProperty overload to JsonElement. (dotnet/corefx#37789)

* Add string-based WriteAsProperty overload to JsonElement.

* Address PR feedback - remove UTF-16 from the comments.

Commit migrated from https://github.com/dotnet/corefx/commit/189766719a059512a515d488efc5c65c7abf0650

5 years agoSkipValidation when using the writer internally within the serializer. (dotnet/corefx...
Ahson Khan [Mon, 20 May 2019 07:21:36 +0000 (00:21 -0700)]
SkipValidation when using the writer internally within the serializer. (dotnet/corefx#37791)

Commit migrated from https://github.com/dotnet/corefx/commit/e58b35cd0f8fe6caa194ca7e48388d8d59854fe0

5 years ago[System.Drawing] Fix cut & paste error (dotnet/corefx#37788)
Filip Navara [Mon, 20 May 2019 05:59:05 +0000 (07:59 +0200)]
[System.Drawing] Fix cut & paste error (dotnet/corefx#37788)

Commit migrated from https://github.com/dotnet/corefx/commit/8261325d82e18ce559dd19cde7e40c2ab140ed8b

5 years agoThrow ArgumentException in JsonSerializer if ReadCommentHandling is Allow dotnet...
Christopher Watford [Mon, 20 May 2019 01:30:08 +0000 (21:30 -0400)]
Throw ArgumentException in JsonSerializer if ReadCommentHandling is Allow dotnet/corefx#37634 (dotnet/corefx#37713)

* Add tests for Allow failing in JsonSerializer Parse/Read dotnet/corefx#37634

* Add check to throw on ReadComentHandling == Allow dotnet/corefx#37634

* Remove unused parameter from CheckSupportedOptions

* Move Allow check into JsonSerializerOptions

Commit migrated from https://github.com/dotnet/corefx/commit/27dae83598c87e3cf4b139c8c981c13fe8e9a81e

5 years agoAdded value type serialization support (dotnet/corefx#36506)
Yoh Deadfall [Mon, 20 May 2019 01:29:05 +0000 (04:29 +0300)]
Added value type serialization support (dotnet/corefx#36506)

* Added value type serialization support

* Fixed coding style issue

Commit migrated from https://github.com/dotnet/corefx/commit/d70ba24c8ca8d8a4384ebe732b3cd748a22e9551

5 years agoAllow run Outerloop tests only (dotnet/corefx#37766)
Viktor Hofer [Sat, 18 May 2019 15:15:04 +0000 (17:15 +0200)]
Allow run Outerloop tests only (dotnet/corefx#37766)

* Allow run Outerloop tests only

* Rename to testScope

* Manual darc update from build '20190517.7'

Commit migrated from https://github.com/dotnet/corefx/commit/963480a7a8f8cf59e3be8f9bfe6ba87623d04088

5 years agoRemove aliases (dotnet/corefx#37759)
Anirudh Agnihotry [Sat, 18 May 2019 02:28:42 +0000 (19:28 -0700)]
Remove aliases (dotnet/corefx#37759)

Commit migrated from https://github.com/dotnet/corefx/commit/c671ce2be16ae3c6086a061d9d94b81005217735

5 years agoConsume comments changes (dotnet/corefx#35934)
Mandar Sahasrabuddhe [Fri, 17 May 2019 22:36:49 +0000 (04:06 +0530)]
Consume comments changes (dotnet/corefx#35934)

* Consume comments changes

* Fixed issues in branch splitting

* Use sequence positions. Elaborate comments.

* Reworked algos, review comment fixes

* Fixed review comments

* minor comment fix

* Standardize exception messages

* Clean up exception messages

Commit migrated from https://github.com/dotnet/corefx/commit/d72d7203a89d3207985c9aca6f02fb8576cbe47b

5 years agoGenerate System.Runtime ref assembly against implementation (dotnet/corefx#37737)
Santiago Fernandez Madero [Fri, 17 May 2019 21:20:13 +0000 (14:20 -0700)]
Generate System.Runtime ref assembly against implementation (dotnet/corefx#37737)

* Generate System.Runtime ref assembly against implementation

* PR Feedback and baseline uapaot errors

Commit migrated from https://github.com/dotnet/corefx/commit/959168e7ff3f9f1957e9e45206ed42d4231d1312

5 years agoAdd resource containers missing in Outerloop.yml (dotnet/corefx#37761)
Viktor Hofer [Fri, 17 May 2019 20:15:33 +0000 (22:15 +0200)]
Add resource containers missing in Outerloop.yml (dotnet/corefx#37761)

Commit migrated from https://github.com/dotnet/corefx/commit/b578d19c256d9a95111e2fd81e72f06c077b766c

5 years agoUnit tests for Path.Join overloads (dotnet/corefx#37285)
Blake Hensley [Fri, 17 May 2019 19:29:18 +0000 (12:29 -0700)]
Unit tests for Path.Join overloads (dotnet/corefx#37285)

* Unit tests for Path.Join overloads

* Add more unit tests

* Minor mod to JoinStringArray_8 test

* Add unit test for zero-length array

* Use proper const for zero-len string

* Added unit test for array of one element

* Format fix: missing/extra space

Commit migrated from https://github.com/dotnet/corefx/commit/a4da51f02f194bdedc9320a50aa63b72411488b6

5 years agoMove runtests to eng and fix invocation (dotnet/corefx#37754)
Viktor Hofer [Fri, 17 May 2019 19:18:29 +0000 (21:18 +0200)]
Move runtests to eng and fix invocation (dotnet/corefx#37754)

Commit migrated from https://github.com/dotnet/corefx/commit/26195605c37bbb2d269e64b0ee3bbfb8c47ddde5

5 years agoEnable rolling builds and add arm64 in outerloop (dotnet/corefx#37728)
Viktor Hofer [Fri, 17 May 2019 17:32:20 +0000 (19:32 +0200)]
Enable rolling builds and add arm64 in outerloop (dotnet/corefx#37728)

* Enable rolling builds and add arm64 in outerloop

* Disable tests on official builds

* Allow Outerloop to run aggregated

* Disable failing RH6 test

Commit migrated from https://github.com/dotnet/corefx/commit/9643d42eb34e9eadfcfea51379812d185dc4fc7c

5 years agoAdd extension data support to Json serializer (dotnet/corefx#37690)
Steve Harter [Fri, 17 May 2019 14:56:47 +0000 (07:56 -0700)]
Add extension data support to Json serializer (dotnet/corefx#37690)

Commit migrated from https://github.com/dotnet/corefx/commit/71487a4a5bf7c0043cca4672ff3352c098dabd8c

5 years agoClean up usage of ArrayPool in the Cryptography assemblies
Jeremy Barton [Fri, 17 May 2019 13:28:17 +0000 (06:28 -0700)]
Clean up usage of ArrayPool in the Cryptography assemblies

The primary motivator of this change is to prepare for moving cryptography from
the public, shared ArrayPool instance to a private pool (or pools), just as a defense
in depth strategy.  Since only the shared ArrayPool instance has GC cooperation
the change to a private pool is not happening at this time.

What this change does provide:
* Every ArrayPool.Rent was identified as being private to the assembly or shared
  out.  If the array gets shared out, it is not appropriate to use a private pool.
* CryptoPool clears returned arrays by default. Instead of an optional bool for
  clearing it has an optional length to clear (from index 0).
* Some rents were removed altogether, via a couple strategies:
  * Opportunistic stackalloc
  * Add a SpanAction-based AsnWriter.WriteBitString overload to avoid the
    pattern of rent-write-call-copy (instead do request-write-done).
  * Add AsnWriter.ValueEquals to prevent rent-encode-compare.
* At least one Rent with no Return was found and fixed.
* Fixed several Rent-growth strategies that could double-Return on exceptions.
* Changed Rfc2898DeriveBytes to just use the one field array instead of a
   lot of rent-write-copy-to-the-field.
* Moves some Return calls out of finally blocks in Async methods to avoid a
  Return-while-in-use path with Task composition when one Task gets aborted
  and another is still running.

Commit migrated from https://github.com/dotnet/corefx/commit/64609475281f2be05a0b9ca5b7bbdaf43b12dc55

5 years agoFix missing casts in Enumerable.Select assert (dotnet/corefx#37410) (dotnet/corefx...
Tim [Fri, 17 May 2019 06:08:25 +0000 (14:08 +0800)]
Fix missing casts in Enumerable.Select assert (dotnet/corefx#37410) (dotnet/corefx#37699)

Commit migrated from https://github.com/dotnet/corefx/commit/6f9570e012054bf407778c0b07632e7733ecbb13

5 years agoAdd interleaved comments to JSON tests (dotnet/corefx#37712)
Christopher Watford [Fri, 17 May 2019 01:51:54 +0000 (21:51 -0400)]
Add interleaved comments to JSON tests (dotnet/corefx#37712)

Commit migrated from https://github.com/dotnet/corefx/commit/18ddda0989624b742c5d6913eebb1851e443432f

5 years agoUse Arcade DotNetTool and NuGetPackageRoot (dotnet/corefx#37647)
Viktor Hofer [Fri, 17 May 2019 01:39:21 +0000 (03:39 +0200)]
Use Arcade DotNetTool and NuGetPackageRoot (dotnet/corefx#37647)

* Use Arcade props

* Use global dotnet if applicable

Commit migrated from https://github.com/dotnet/corefx/commit/f42e04b8d4be76b1818cf263ff06234d0e25ada0

5 years agoFix minor typo NanoSeconds -> nanoseconds (dotnet/corefx#37732)
Gergely Kalapos [Fri, 17 May 2019 00:32:40 +0000 (20:32 -0400)]
Fix minor typo NanoSeconds -> nanoseconds (dotnet/corefx#37732)

Commit migrated from https://github.com/dotnet/corefx/commit/ef25246c7ea01a96cda8a464b4b717213e8d9685

5 years agoFix ListenerWithFilter test (dotnet/corefx#37731)
Stephen Toub [Fri, 17 May 2019 00:31:47 +0000 (17:31 -0700)]
Fix ListenerWithFilter test (dotnet/corefx#37731)

It's searching the output to ensure the id doesn't get written out, so it can't match other IDs that are written out.

Commit migrated from https://github.com/dotnet/corefx/commit/05233fd0c0200f1fda258bab148bbae28592892d

5 years agoFix a bug in xsd validation during deserialization (dotnet/corefx#37596)
Jiayi [Fri, 17 May 2019 00:20:22 +0000 (17:20 -0700)]
Fix a bug in xsd validation during deserialization (dotnet/corefx#37596)

* Fix a bug in xsd validation during deserialization
* Add a test

Commit migrated from https://github.com/dotnet/corefx/commit/4435d785565f192392b29890401748a6cdea4109

5 years agoImprove performance of Linux X509Chain building via caching
Jeremy Barton [Thu, 16 May 2019 23:56:35 +0000 (16:56 -0700)]
Improve performance of Linux X509Chain building via caching

X509Chain will use cached versions of CU\My, CU\CA, and CU\Root, in addition to the already cached LM\CA and LM\Root stores.

By avoiding the dips down to the filesystem it knocks a significant amount of I/O and computation off of the store reloads (~45% of one of my perf tests was spent doing SHA-1... for verifying the HMAC on opening the CU\My files).

The new heuristics are:

* CU\My, CU\CA, CU\Root
  * After one second elapses check to see if the LastWriteTimeUtc on the directory has changed, if so, invalidate the cache.
  * After 30 seconds invalidate the cache no matter what.
  * Cache invalidation is per store
* LM\CA, LM\Root
  * After 5 seconds elapses check to see if the LastWriteTimeUtc on either (or both) of the SSL_CERT_FILE file or SSL_CERT_DIR directory has changed (and if so, invalidate the cache)
  * After 5 minutes invalidate the cache no matter what.
  * System stores are rebuilt together.

All X509Store objects for LM\CA and LM\Root will get the same Pal instance (which just no-ops the Dispose) which is a projection over the cache.

All X509Store objects for CU\ stores will still use the existing "raw read" model, because otherwise the cache led to observable differences between Windows and Linux. Only X509Chain gets the cached stores.

In running a chain-build-only 1000 times in a loop test, before this change my machine reported ~13.6ms per chain build, and after was 0.822ms.

In running a particular SslStream-to-SslStream handshake test, 10000 iterations before the change was 7 minutes 51 seconds. After was 3 minutes 40 seconds.

This change also fixes a bug introduced in the previous perf enhancement where ERR_get_error was used instead of ERR_peek_last_error (wrong end of the queue, and destructive vs passive)... and that the managed code wasn't checking for the error anyways.

Commit migrated from https://github.com/dotnet/corefx/commit/d8797a0f1616c1db1e5294964f2826e051f2615e

5 years agoFixed deserialization of null arrays for issue dotnet/corefx#37606 (dotnet/corefx...
gnovack [Thu, 16 May 2019 23:35:08 +0000 (19:35 -0400)]
Fixed deserialization of null arrays for issue dotnet/corefx#37606 (dotnet/corefx#37616)

* Fixed deserialization of null root arrays.

* Used reader.CurrentDepth to catch root level nulls.

Commit migrated from https://github.com/dotnet/corefx/commit/026fa6a6889ab1c9c8f14f55d414d2940fc59805

5 years agoAdd [EnumeratorCancellation] to Microsoft.Bcl.AsyncInterfaces (dotnet/corefx#37719)
Stephen Toub [Thu, 16 May 2019 22:53:45 +0000 (15:53 -0700)]
Add [EnumeratorCancellation] to Microsoft.Bcl.AsyncInterfaces (dotnet/corefx#37719)

Commit migrated from https://github.com/dotnet/corefx/commit/52c6527b80062c2a3a906fd3d01881ff2f36f405

5 years agoDetermine the anyAttribute Namespace based on the NamespaceList (dotnet/corefx#37409)
JosVerburg [Thu, 16 May 2019 22:20:20 +0000 (00:20 +0200)]
Determine the anyAttribute Namespace based on the NamespaceList (dotnet/corefx#37409)

* Determine the anyAttribute Namespace based on the NamespaceList

* Do not test the namespace attribute for full framework for intersection and union cases

* Compare namespaces using string comparison in unit tests

Commit migrated from https://github.com/dotnet/corefx/commit/2c22af8903522e54f71225c40ddd383b15632ae0

5 years agoUpdate issue-guide.md
Karel Zikmund [Thu, 16 May 2019 20:59:33 +0000 (13:59 -0700)]
Update issue-guide.md

Update owners

Commit migrated from https://github.com/dotnet/corefx/commit/75a6020a76e85fb65b6bdae9f8497f6d5596e4c2

5 years agoExecuting tests in a serial order (dotnet/corefx#37715)
Anirudh Agnihotry [Thu, 16 May 2019 20:27:56 +0000 (13:27 -0700)]
Executing tests in a serial order (dotnet/corefx#37715)

Commit migrated from https://github.com/dotnet/corefx/commit/81291b0793b90c535546d3d95c69085020891d28

5 years agoAdded failing test case for unexpected StackOverflowException
Oskar Dudycz [Thu, 16 May 2019 18:23:09 +0000 (20:23 +0200)]
Added failing test case for unexpected StackOverflowException

[System.Text.Json] Serializing class that has array of children of the same class throws StackOverflowException (dotnet/corefx#37611)

Commit migrated from https://github.com/dotnet/corefx/commit/374833115e24d6384da62fa631acde2e65101eb8

5 years agoUse CancellationToken.UnsafeRegister in a few more places (dotnet/corefx#37551)
Stephen Toub [Thu, 16 May 2019 18:08:10 +0000 (11:08 -0700)]
Use CancellationToken.UnsafeRegister in a few more places (dotnet/corefx#37551)

CancellationToken.Register captures the current ExecutionContext and uses it to invoke the callback if/when it's invoked.  That's generally desirable and is the right default, but in cases where we know for certain the callback doesn't care about EC (e.g. we're not invoking any 3rd-party code), we can use UnsafeRegister instead (newly added in 3.0), which skips capturing the ExecutionContext, as if Capture returned null.  This helps few a couple of small costs:
- Avoids thread local lookups to capture the current EC.
- Avoids additional delegate invocations and thread local gets/sets to invoke the callback with the captured EC.
- Avoids holding on to the EC in case it's needed, which can potentially keep alive an unbounded amount of state due to AsyncLocals.

Commit migrated from https://github.com/dotnet/corefx/commit/b1a1bfa0997ce35e8540fbbe74276858e315807e

5 years agoUpdate issue-guide.md
Karel Zikmund [Thu, 16 May 2019 17:37:28 +0000 (10:37 -0700)]
Update issue-guide.md

Update area ownerships

Commit migrated from https://github.com/dotnet/corefx/commit/ca9bf96e1cdce0c421c4f040fd10ec555dacd077

5 years agoLinux: ProcessName: return script name instead of interpreter program (dotnet/corefx...
Tom Deseyn [Thu, 16 May 2019 17:30:06 +0000 (10:30 -0700)]
Linux: ProcessName: return script name instead of interpreter program (dotnet/corefx#37294)

* Linux: ProcessName: return script name instead of interpreter program

Fixes https://github.com/dotnet/corefx/issues/37198
Regression by https://github.com/dotnet/corefx/pull/37144

* Add ProcessNameMatchesScriptName test

* ProcessNameMatchesScriptName: don't run on OSX

* LongProcessNamesAreSupported: don't run on Alpine

* Remove ActiveIssue attributes

Commit migrated from https://github.com/dotnet/corefx/commit/1b6f45ca261467baea62ef577f8b8a7c6cf3b96c

5 years agoMark System.Reflection.Emit* as inbox on netstandard2.1 (dotnet/corefx#37532)
William Godbe [Thu, 16 May 2019 16:53:04 +0000 (09:53 -0700)]
Mark System.Reflection.Emit* as inbox on netstandard2.1 (dotnet/corefx#37532)

Commit migrated from https://github.com/dotnet/corefx/commit/b885c2296e531be15151a4857c73b4cf1c1b08c6

5 years agoUpdate ProjectNTfs to beta-27716-00 (dotnet/corefx#37698)
dotnet-maestro-bot [Thu, 16 May 2019 15:42:41 +0000 (08:42 -0700)]
Update ProjectNTfs to beta-27716-00 (dotnet/corefx#37698)

Commit migrated from https://github.com/dotnet/corefx/commit/7e44240e1644e80a856d81cb989f26751fa52579

5 years agoFix serialization of Dictionary<string, object> (dotnet/corefx#37686)
Jeremy Kuhne [Thu, 16 May 2019 04:45:57 +0000 (21:45 -0700)]
Fix serialization of Dictionary<string, object> (dotnet/corefx#37686)

We didn't drill into the value type (of the key/value pair, i.e. "object") properly when serializing.

Commit migrated from https://github.com/dotnet/corefx/commit/cf80956620388850469b516cc895e30a299928e2

5 years agoAdded System.GC.GetTotalAllocatedBytes to the ref assembly (dotnet/corefx#37635)
Vladimir Sadov [Thu, 16 May 2019 00:13:00 +0000 (17:13 -0700)]
Added System.GC.GetTotalAllocatedBytes to the ref assembly (dotnet/corefx#37635)

* Update dependencies from https://github.com/dotnet/coreclr build 20190514.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27714-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27714-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27714-72

* Added GetTotalAllocatedBytes to ref

* Added a test for GC.GetTotalAllocatedBytes

* SImplified the test.

Commit migrated from https://github.com/dotnet/corefx/commit/d0d6a734fc877b76f766548d5e79a63aba5160cf

5 years agoRemove ILC testing (dotnet/corefx#37681)
Viktor Hofer [Wed, 15 May 2019 20:52:49 +0000 (22:52 +0200)]
Remove ILC testing (dotnet/corefx#37681)

* Remove ILC testing

Commit migrated from https://github.com/dotnet/corefx/commit/16725f91a2ccc41a3ef7981b828914d018f9f2fb

5 years agoAdd Guid serialization support. (dotnet/corefx#37529)
Jeremy Kuhne [Wed, 15 May 2019 19:23:23 +0000 (12:23 -0700)]
Add Guid serialization support. (dotnet/corefx#37529)

* Add Guid serialization support.

Add non IConvertable converters to dictionary for easier extensibility.

* Fix project ordering.

* Remove explicit static constructor

Commit migrated from https://github.com/dotnet/corefx/commit/797142155af425a7dd0581900ad4c9884c62e53b

5 years agoImprove test coverage for SequenceReader. (dotnet/corefx#37416)
Jeremy Kuhne [Wed, 15 May 2019 19:08:19 +0000 (12:08 -0700)]
Improve test coverage for SequenceReader. (dotnet/corefx#37416)

One of the tests was inadvertently private. Added additional coverage and clarification text to TryCopyTo.

Commit migrated from https://github.com/dotnet/corefx/commit/203f61e27e93b098dcc0736fbfe2b38528dcf9aa

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27715-00, beta-27715-00, respectively...
dotnet-maestro-bot [Wed, 15 May 2019 18:27:23 +0000 (11:27 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27715-00, beta-27715-00, respectively (dotnet/corefx#37663)

Commit migrated from https://github.com/dotnet/corefx/commit/cdaaeb18c974eeb1d75bfb5b4286b8caa90255e5

5 years agoAdded optional/default parameters for StreamWriter/StreamReader (dotnet/corefx#36959)
Jim Demis [Wed, 15 May 2019 17:39:46 +0000 (20:39 +0300)]
Added optional/default parameters for StreamWriter/StreamReader (dotnet/corefx#36959)

* Added optional/default parameters for StreamWriter/StreamReader

Fix dotnet/corefx#8173

* removed tests

* Added tests for constructors with optional arguments

* Added tests and reverted null encoding throws

Commit migrated from https://github.com/dotnet/corefx/commit/d1912344d9f09d6d294aa555c6322ed35ec1cb28

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#37512)
dotnet-maestro[bot] [Wed, 15 May 2019 16:22:16 +0000 (09:22 -0700)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#37512)

* Update dependencies from https://github.com/dotnet/arcade build 20190507.7

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19257.7
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19257.7
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19257.7
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19257.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19257.7
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19257.7
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19257.7
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19257.7
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19257.7
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19257.7
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19257.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19257.7
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19257.7

* Update dependencies from https://github.com/dotnet/arcade build 20190508.5

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19258.5
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19258.5
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19258.5
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19258.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19258.5
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19258.5
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19258.5
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19258.5
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19258.5
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19258.5
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19258.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19258.5
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19258.5

* Update dependencies from https://github.com/dotnet/arcade build 20190509.9

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19259.9
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19259.9
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19259.9
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19259.9
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19259.9
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19259.9
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19259.9
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19259.9
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19259.9
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19259.9
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19259.9
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19259.9
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19259.9

* Update dependencies from https://github.com/dotnet/arcade build 20190510.2

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19260.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19260.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19260.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19260.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19260.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19260.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19260.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19260.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19260.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19260.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19260.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19260.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19260.2

* Update dependencies from https://github.com/dotnet/arcade build 20190511.1

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19261.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19261.1
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19261.1
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19261.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19261.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19261.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19261.1
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19261.1
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19261.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19261.1
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19261.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19261.1
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19261.1

* Use RemoteExecutor NS version

* Update dependencies from https://github.com/dotnet/arcade build 20190512.1

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19262.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19262.1
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19262.1
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19262.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19262.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19262.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19262.1
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19262.1
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19262.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19262.1
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19262.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19262.1
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19262.1

* Update dependencies from https://github.com/dotnet/arcade build 20190513.3

- Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.19263.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19263.3
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19263.3
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19263.3
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19263.3
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19263.3
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19263.3
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19263.3
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19263.3
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19263.3
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19263.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19263.3
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19263.3

* Exclude compile assets for RemoteExecutor

* Manual darc update from build '20190514.12'

* Fix Unix restore of RemoteExecutor

* Exclude assets for RemoteExecutor correctly

* Downgrade compiler version

* Fix remoteexecutor lib binplacing for uap/uapaot

* Add RemoteExecutorHost tfms in test

* Fix process name check test on netfx

Commit migrated from https://github.com/dotnet/corefx/commit/5a91f2a23f463900457e496c4e7d59494b3a3740

5 years agoUnix: make Backspace work when Console.ReadLine has wrapped lines (dotnet/corefx...
Tom Deseyn [Wed, 15 May 2019 16:13:27 +0000 (09:13 -0700)]
Unix: make Backspace work when Console.ReadLine has wrapped lines (dotnet/corefx#37182)

* Unix: make Backspace work when Console.ReadLine has wrapped lines

* Get ClrEof string from TermInfo database

* PR feedback

* ManualTests: replace Fact by ConditionalFact(ManualTestsEnabled)

Commit migrated from https://github.com/dotnet/corefx/commit/9b8b9c6cf6f9cce3ce9f36b2131fcadd33b755e0

5 years agoAdd ToXmlString and FromXmlString implementations to RSA and DSA.
Jeremy Barton [Wed, 15 May 2019 05:54:46 +0000 (22:54 -0700)]
Add ToXmlString and FromXmlString implementations to RSA and DSA.

The ToXmlString implementations produce output identical to .NET Framework.

The FromXmlString implementations are based on XDocument in Core, vs a
custom parser in Framework.  Additionally, the FromXmlString in Core can
read values which (per the xmldsig spec) removed any leading zero-value
bytes, whereas the Framework version can't.

No ToXmlString or FromXmlString is being added for ECDsa or
ECDiffieHellman, because these types have always thrown in .NET Framework.
The equivalent functionality was provided by an overload on ECDsaCng (and
ECDiffieHellmanCng) that took a format-type enum (with only one member
defined in it). Since that's not portable, and telemetry has never
seen a caller of that method, they are being left as PNSE.

Commit migrated from https://github.com/dotnet/corefx/commit/271138bc0625ff82b1d1b5cb115a309130d8202e

5 years agoFix System.Diagnostics.Process.[x]ProcessorTime on macOS (dotnet/corefx#37637)
Gergely Kalapos [Wed, 15 May 2019 03:08:15 +0000 (23:08 -0400)]
Fix System.Diagnostics.Process.[x]ProcessorTime on macOS (dotnet/corefx#37637)

* Fix System.Diagnostics.Process xProcessorTime props and add test

The ri_user_time unit is nanoseconds, but the TimeSpan .ctor expects values with a 100-nanosecond unit.

* Update src/System.Diagnostics.Process/tests/ProcessTests.cs

* Update src/System.Diagnostics.Process/tests/ProcessTests.cs

* Update src/System.Diagnostics.Process/tests/ProcessTests.cs

* Update src/System.Diagnostics.Process/tests/ProcessTests.cs

* Add ActiveIssue to TotalProcessorTime_PerformLoop_TotalProcessorTimeValid

* Address PR feedback

* Fix typo - NanoSeconds -> Nanoseconds

Commit migrated from https://github.com/dotnet/corefx/commit/a28176b5ec68b6da1472934fe9493790d1665cae

5 years agoMove colon debug assert to where it is needed (dotnet/corefx#37654)
Layomi Akinrinade [Wed, 15 May 2019 01:29:56 +0000 (18:29 -0700)]
Move colon debug assert to where it is needed (dotnet/corefx#37654)

This addresses https://github.com/dotnet/corefx/pull/37159#discussion_r279108249.

Commit migrated from https://github.com/dotnet/corefx/commit/11b548176e6889866dee553ea84b92da3916e73b

5 years agoHarden PerfCounter tests (dotnet/corefx#37658)
Viktor Hofer [Wed, 15 May 2019 01:28:16 +0000 (03:28 +0200)]
Harden PerfCounter tests (dotnet/corefx#37658)

Commit migrated from https://github.com/dotnet/corefx/commit/4361e909ff46231bd49b0736f8c4588f5e87e192

5 years agoDon't reference netstandard.dll by wildcard (dotnet/corefx#37660)
Eric StJohn [Tue, 14 May 2019 23:13:50 +0000 (16:13 -0700)]
Don't reference netstandard.dll by wildcard (dotnet/corefx#37660)

NetStandard.dll is built during the same phase as the other generated shims.
We use a ProjectReference to correctly sequence it before other generated
shims.  Make sure that building a generated shim after building
netstandard.csproj doesn't result in 2 netstandard.dll's being passed to
the compiler.

Commit migrated from https://github.com/dotnet/corefx/commit/30f4fbcb5bc16bdb3953d9186f20606a0f134f2d

5 years agoFix bug in ZipArchiveEntry data descriptor (dotnet/corefx#37601)
Carlos Sanchez Lopez [Tue, 14 May 2019 21:26:12 +0000 (14:26 -0700)]
Fix bug in ZipArchiveEntry data descriptor (dotnet/corefx#37601)

* Prevent data corruption (can't drag drop files using external zip tools) when data descriptor bit is turned on in a seekable file that is being updated.

* Add unit test to verify data descriptor is off after updating a zip file that was created with an unseekable stream.

Commit migrated from https://github.com/dotnet/corefx/commit/05ada9bc9674ef874666260c14a01187deee8040

5 years agodisable UDS tests on Nano (dotnet/corefx#37652)
Tomas Weinfurt [Tue, 14 May 2019 17:41:01 +0000 (10:41 -0700)]
disable UDS tests on Nano (dotnet/corefx#37652)

Commit migrated from https://github.com/dotnet/corefx/commit/47be0d100765c165c085fd492786783b1833ff95

5 years agoMerge pull request dotnet/corefx#37632 from dotnet/MattGal-patch-1
Matt Galbraith [Tue, 14 May 2019 17:30:53 +0000 (10:30 -0700)]
Merge pull request dotnet/corefx#37632 from dotnet/MattGal-patch-1

Use Docker feature for nano runs

Commit migrated from https://github.com/dotnet/corefx/commit/a8e545f503fa1c9db783efa730afa1e2d231871c

5 years agoReplace the esoteric '<<' in calls to Buffer.BlockCopy() in URI.cs (dotnet/corefx...
William Godbe [Tue, 14 May 2019 17:24:18 +0000 (10:24 -0700)]
Replace the esoteric '<<' in calls to Buffer.BlockCopy() in URI.cs (dotnet/corefx#37310)

* Document the esoteric use of '<<' in URI.cs

* Fix comment style

* Make calls to Buffer.BlockCopy() clearer

* Add EOL

Commit migrated from https://github.com/dotnet/corefx/commit/c746f95107a615f17a7fa5344b4c207291536ac3

5 years agoupdate HTTP2 responce header processing (dotnet/corefx#37572)
Tomas Weinfurt [Tue, 14 May 2019 16:52:45 +0000 (09:52 -0700)]
update HTTP2 responce header processing (dotnet/corefx#37572)

* update HTTP2 responce header processing

* fix also trailinbg headers

Commit migrated from https://github.com/dotnet/corefx/commit/269a37755c788252385ceec472c619e68d676032

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27714-00, beta-27714-00, respectively...
dotnet-maestro-bot [Tue, 14 May 2019 16:30:01 +0000 (09:30 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27714-00, beta-27714-00, respectively (dotnet/corefx#37638)

Commit migrated from https://github.com/dotnet/corefx/commit/8ba8d866746e0bfa12a7fbb74e878ff361a5eb00

5 years agoReplace rewriting GenFacades shims with source projects (dotnet/corefx#37550)
Eric StJohn [Tue, 14 May 2019 16:23:42 +0000 (09:23 -0700)]
Replace rewriting GenFacades shims with source projects (dotnet/corefx#37550)

* Replace rewriting GenFacades shims with source projects

This uses the new facade generation process that generates source files
instead of relying on assembly rewriting for the production of desktop
and netstandard facades.

* Don't double import the SDK

I reuse the properties in the generated projects (treating them as props
files) but the SDK attribute on the Project element was causing the SDK
to be imported twice.  Avoid this by conditioning the imports.

* Workaround APICompat misidentifying the core assembly

* Fix shim binplacing

* Clarify comment.

Commit migrated from https://github.com/dotnet/corefx/commit/cb650e1b95f290c1a64dff26ccd5d21b8116ade7

5 years agoUpdate windows.yml
Matt Galbraith [Tue, 14 May 2019 15:49:50 +0000 (08:49 -0700)]
Update windows.yml

Put quotes back (tried without them for @safern )

Commit migrated from https://github.com/dotnet/corefx/commit/eacccb411346c86b10c74ffd728540b12963a274

5 years agoUpdate windows.yml
Matt Galbraith [Tue, 14 May 2019 15:37:39 +0000 (08:37 -0700)]
Update windows.yml

Remove " chars

Commit migrated from https://github.com/dotnet/corefx/commit/41ab963854979114eeb43a63e0d7d2ec910e682f

5 years agoremoving partial facades from netcoreapp\uap reference assembly build (dotnet/corefx...
Anirudh Agnihotry [Tue, 14 May 2019 04:58:20 +0000 (21:58 -0700)]
removing partial facades from netcoreapp\uap reference assembly build (dotnet/corefx#37591)

Commit migrated from https://github.com/dotnet/corefx/commit/f5be0283c5e00dd823a41f671f9c9a41170f0a85

5 years agoAllow trailing trivia in JsonSerializer.Parse and Read dotnet/corefx#37500 (dotnet...
Christopher Watford [Tue, 14 May 2019 03:58:42 +0000 (23:58 -0400)]
Allow trailing trivia in JsonSerializer.Parse and Read dotnet/corefx#37500 (dotnet/corefx#37549)

* Add tests for trailing trivia to JsonSerializer

Contributes to dotnet/corefx#37500

* Consume trailing trivia in JsonSerializer.ReadCore

Fixes dotnet/corefx#37500

* Add tests for leading trivia too

- Consolidates leading and trailing trivia tests into one

* Simplify ReadCore loop per @ahsonkhan review

NOTE: throws NPE in state.PropertyPath if invalid JSON is in the trailer.

* Do not compute PropertyPath if outside document

* Add additional test cases for primitives

* Clean up tests and add negative test for leading/trailing comments

Commit migrated from https://github.com/dotnet/corefx/commit/2b8126ea3a4ab951386052313e2b71c42cd71480

5 years agoUpdate windows.yml
Matt Galbraith [Mon, 13 May 2019 23:23:27 +0000 (16:23 -0700)]
Update windows.yml

Still fighting the yaml

Commit migrated from https://github.com/dotnet/corefx/commit/ad60d144b36a72c04b30acf1e84e7bf840e591c5

5 years agoUpdate windows.yml
Matt Galbraith [Mon, 13 May 2019 23:21:10 +0000 (16:21 -0700)]
Update windows.yml

fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/9ff9769dc10af0d941ebb27c4f01e73c27c1f759

5 years agoUpdate windows.yml
Matt Galbraith [Mon, 13 May 2019 23:18:26 +0000 (16:18 -0700)]
Update windows.yml

Ah ha, it's a backtick to get powershell to work with ( )

Commit migrated from https://github.com/dotnet/corefx/commit/fc59ec7a4206ef7173b9777404ff7dafaad6cc3a

5 years agoUpdate windows.yml
Matt Galbraith [Mon, 13 May 2019 22:49:50 +0000 (15:49 -0700)]
Update windows.yml

change to double quotes

Commit migrated from https://github.com/dotnet/corefx/commit/9b58db24948c2917cdc01a5805c6a1c52cab9838

5 years agoFix ODBC issues with UTF-16 (dotnet/corefx#36710)
Calvin Buckley [Mon, 13 May 2019 22:46:02 +0000 (19:46 -0300)]
Fix ODBC issues with UTF-16 (dotnet/corefx#36710)

* Fixup UTF-16 string marshalling rules in ODBC

Based on a patch by Filip Navara (@filipnavara) - this clears up
some ambigious situations after the change to UTF-8 by default.

* Fix endianness issue marshalling UTF-16 strings manually in ODBC

Encoding.Unicode is used for UTF-16LE, and is no good on big
endian systems. Detect at runtime what Encoding object to use.

This fixes ODBC on Mono for IBM i.

* Restore in attributes from botched patch application

* and this line too

* remove unneeded MarshalAs on SQLGetDiagFieldW

* compile error typo fix

* Remove in attributes on strings

Commit migrated from https://github.com/dotnet/corefx/commit/18b98c9aa2d92b60da217b1912e368a6c48b4f2f

5 years agoUpdate windows.yml
Matt Galbraith [Mon, 13 May 2019 22:31:18 +0000 (15:31 -0700)]
Update windows.yml

Try escaping the ()

Commit migrated from https://github.com/dotnet/corefx/commit/5b9efef3d1dc97934c702c3602dd89e22d92dc8c

5 years agoAdd support for more collections (dotnet/corefx#37308)
Layomi Akinrinade [Mon, 13 May 2019 21:19:31 +0000 (14:19 -0700)]
Add support for more collections (dotnet/corefx#37308)

* Add support for additional collections

* Add more tests

* Some changes

* Address review feedback

* Some nits

* Remove immutable dependency

* Use Invoke, not DyanmicInvoke

* Address review comments

* Utilize JsonPropertyInfoCommon generic TElement parameter

Commit migrated from https://github.com/dotnet/corefx/commit/cc00646d20b70827aa52ecd67ae6748d03eb3233

5 years agoMerge pull request dotnet/corefx#37574 from dotnet/darc-master-ed378f9a-8baa-48bb...
William Godbe [Mon, 13 May 2019 19:31:42 +0000 (12:31 -0700)]
Merge pull request dotnet/corefx#37574 from dotnet/darc-master-ed378f9a-8baa-48bb-8487-e5938c044604

[master] Update dependencies from dotnet/standard

Commit migrated from https://github.com/dotnet/corefx/commit/57df9bfeebca618949906ce875e249ce903ae51a

5 years agoMerge pull request dotnet/corefx#37619 from dotnet-maestro-bot/master-UpdateDependencies
William Godbe [Mon, 13 May 2019 19:24:46 +0000 (12:24 -0700)]
Merge pull request dotnet/corefx#37619 from dotnet-maestro-bot/master-UpdateDependencies

Update ProjectNTfs, ProjectNTfsTestILC to beta-27713-00, beta-27713-00, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/42570b927296153bceaf313caccb246eb95357b8

5 years agoUse Docker feature for nano runs
Matt Galbraith [Mon, 13 May 2019 18:45:32 +0000 (11:45 -0700)]
Use Docker feature for nano runs

@wfurt FYI

Commit migrated from https://github.com/dotnet/corefx/commit/4c8af9a27784df92bb567d920f84799b90990717

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27713-00, beta-27713-00, respectively
dotnet-maestro-bot [Mon, 13 May 2019 18:08:35 +0000 (11:08 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27713-00, beta-27713-00, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/2b741e27494b710029b581d90394e377906fc0e6

5 years agoMerge branch 'master' into darc-master-ed378f9a-8baa-48bb-8487-e5938c044604
William Godbe [Mon, 13 May 2019 17:57:02 +0000 (10:57 -0700)]
Merge branch 'master' into darc-master-ed378f9a-8baa-48bb-8487-e5938c044604

Commit migrated from https://github.com/dotnet/corefx/commit/e9b2ef72ff6a746a1d7a2928e2e8cc41dade3dcf

5 years agoAdd Idn.GetAscii Test (dotnet/corefx#37498)
Tarek Mahmoud Sayed [Mon, 13 May 2019 16:18:11 +0000 (09:18 -0700)]
Add Idn.GetAscii Test (dotnet/corefx#37498)

This test to enusre we are not throwing when having a string with hyphens in the 3rd and 4th places.

Commit migrated from https://github.com/dotnet/corefx/commit/33013441dcde783c38c063e39d52da8bfbb32ad6

5 years agoAdd AssemblyResolve_FirstChanceException test (dotnet/corefx#37570)
Steve MacLean [Sat, 11 May 2019 00:21:38 +0000 (20:21 -0400)]
Add AssemblyResolve_FirstChanceException test (dotnet/corefx#37570)

PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/0d3caeba10c3c4a83f16a11c4298e39528d923b5

5 years agoUpdate System.Text.Encodings.Web Unicode data to 12.1
Levi Broderick [Thu, 9 May 2019 23:27:15 +0000 (16:27 -0700)]
Update System.Text.Encodings.Web Unicode data to 12.1

Commit migrated from https://github.com/dotnet/corefx/commit/ea5a6589ca24c3d38e3ff0f995a4df6c79b889c6

5 years agoRefactoring and code cleanup for System.Text.Encodings.Web
Levi Broderick [Sun, 5 May 2019 03:56:47 +0000 (20:56 -0700)]
Refactoring and code cleanup for System.Text.Encodings.Web
- Don't use embedded resources for the mapping of defined characters
- Rename source files to better reflect actual namespace layouts
- Add tools for generating the list of defined characters and Unicode ranges
- Add instructions on how to update the underlying Unicode data

Commit migrated from https://github.com/dotnet/corefx/commit/185e0302830ed4e304c197e5e31270a9abccb3e2

5 years agoRe-enables OLEDB tests and Fixes SEHException (dotnet/corefx#37540)
Maryam Ariyan [Fri, 10 May 2019 21:06:16 +0000 (14:06 -0700)]
Re-enables OLEDB tests and Fixes SEHException (dotnet/corefx#37540)

Fixes: dotnet/corefx#37538

Commit migrated from https://github.com/dotnet/corefx/commit/2c64705c1aa8ecd9278ac8b8f692bf980d3b3fd3

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27710-00, beta-27710-00, respectively...
dotnet-maestro-bot [Fri, 10 May 2019 16:08:19 +0000 (09:08 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27710-00, beta-27710-00, respectively (dotnet/corefx#37581)

Commit migrated from https://github.com/dotnet/corefx/commit/87b2e237fafbdfb01f03f16558f3fa17f8288f91

5 years agoFixing the ApCompatBaselines for System.Runtime.Intrinsics and System.Numerics.Vector...
Tanner Gooding [Fri, 10 May 2019 15:01:26 +0000 (08:01 -0700)]
Fixing the ApCompatBaselines for System.Runtime.Intrinsics and System.Numerics.Vectors (dotnet/corefx#37568)

* Ensure that the System.Numerics.Vectors implementation and ref match.

* Ensure that the System.Runtime.Intrinsics implementation and ref match.

* Ensure that the System.Runtime.Intrinsics.Experimental implementation and ref match.

Commit migrated from https://github.com/dotnet/corefx/commit/9d02eb96686c32ae131ab14c9d08a12bacb89979

5 years agoAdding typeforward to AsyncInterfaces now that the type has been added to netstandard...
Jose Perez Rodriguez [Fri, 10 May 2019 03:01:57 +0000 (20:01 -0700)]
Adding typeforward to AsyncInterfaces now that the type has been added to netstandard (dotnet/corefx#37575)

* Adding typeforward to AsyncInterfaces now that the type has been added to netstandard

* Remove baseline entry for missing type

Commit migrated from https://github.com/dotnet/corefx/commit/441238d5a50ee3cb19179e93c2b94ec7b09ca214

5 years agoAdd ServiceContainer tests and fix bugs (dotnet/corefx#37519)
Hugh Bellamy [Fri, 10 May 2019 00:15:11 +0000 (17:15 -0700)]
Add ServiceContainer tests and fix bugs (dotnet/corefx#37519)

* Add ServiceContainer tests and fix bugs

* Fix .NET Framework tests

* Dummy change for CI

Commit migrated from https://github.com/dotnet/corefx/commit/6803f28cae60b0f7f92ac70e4e57c1f0583adffd

5 years agoFix netfx build with nullable annotations
Stephen Toub [Thu, 9 May 2019 19:25:49 +0000 (15:25 -0400)]
Fix netfx build with nullable annotations

Commit migrated from https://github.com/dotnet/corefx/commit/068bb40c724e92ee289e6c2eb44b9ac5432b643a

5 years agoUse RetryHelper to harden flaky tests (dotnet/corefx#37560)
Viktor Hofer [Thu, 9 May 2019 21:25:24 +0000 (23:25 +0200)]
Use RetryHelper to harden flaky tests (dotnet/corefx#37560)

Commit migrated from https://github.com/dotnet/corefx/commit/7076e2b603c3ba8f22fdb802aa4b078296ecd6b3

5 years agoMove UseDefaultCredentials_SetToFalseAndServerNeedsAuth_StatusCodeUnauthorized test...
Stephen Toub [Thu, 9 May 2019 21:24:57 +0000 (17:24 -0400)]
Move UseDefaultCredentials_SetToFalseAndServerNeedsAuth_StatusCodeUnauthorized test to OuterLoop (dotnet/corefx#37556)

Commit migrated from https://github.com/dotnet/corefx/commit/ae3262aa29e860eaee9fc5d96eba539a3b4fe084