Stefan Kost [Wed, 28 Sep 2005 18:14:13 +0000 (18:14 +0000)]
fixed umlauts in ChangeLog again
Original commit message from CVS:
fixed umlauts in ChangeLog again
Stefan Kost [Wed, 28 Sep 2005 17:30:13 +0000 (17:30 +0000)]
gst/gstinfo.c: don't do dummy g_strdup()s
Original commit message from CVS:
* gst/gstinfo.c: (gst_debug_log_default):
don't do dummy g_strdup()s
* libs/gst/controller/gstcontroller.c:
(on_object_controlled_property_changed),
(gst_controlled_property_new), (gst_controller_new_valist),
(gst_controller_new_list),
(gst_controller_remove_properties_valist), (gst_controller_set),
(gst_controller_get), (gst_controller_sync_values),
(gst_controller_get_value_array), (_gst_controller_class_init),
(gst_controller_get_type):
* libs/gst/controller/gstcontroller.h:
* libs/gst/controller/gstinterpolation.c:
(gst_controlled_property_find_timed_value_node):
convert // to /**/ comments
Wim Taymans [Wed, 28 Sep 2005 16:43:20 +0000 (16:43 +0000)]
gst/gstbus.*: Added async-message and sync-message signals to the bus.
Original commit message from CVS:
* gst/gstbus.c: (marshal_VOID__MINIOBJECT), (gst_bus_class_init),
(gst_bus_post), (poll_func), (gst_bus_async_signal_func),
(gst_bus_sync_signal_handler):
* gst/gstbus.h:
Added async-message and sync-message signals to the bus.
Added helper BusFunc to emit signals for all posted messages.
* gst/gstmessage.c: (gst_message_type_get_name),
(gst_message_type_to_quark), (gst_message_get_type):
* gst/gstmessage.h:
Register quarks for message names.
Stefan Kost [Wed, 28 Sep 2005 16:39:29 +0000 (16:39 +0000)]
added another constructor for language bindings
Original commit message from CVS:
* docs/libs/gstreamer-libs-sections.txt:
* libs/gst/controller/gstcontroller.c: (gst_controller_new_valist),
(gst_controller_new_list):
* libs/gst/controller/gstcontroller.h:
added another constructor for language bindings
Thomas Vander Stichele [Wed, 28 Sep 2005 15:45:21 +0000 (15:45 +0000)]
check/gst/gstpipeline.c: add another check
Original commit message from CVS:
* check/gst/gstpipeline.c: (GST_START_TEST), (gst_pipeline_suite):
add another check
* gst/gstbus.c:
add some doc
* gst/gstinfo.c: (_gst_debug_init):
slightly more readable color for refcount debugging
Wim Taymans [Wed, 28 Sep 2005 13:41:27 +0000 (13:41 +0000)]
gst/gstbin.c: Small doc fixes. get_clock -> provide_clock.
Original commit message from CVS:
* gst/gstbin.c: (gst_bin_class_init), (gst_bin_provide_clock_func),
(add_to_queue), (clear_queue), (reset_degree), (update_degree),
(find_element), (gst_bin_sort_iterator_next),
(gst_bin_sort_iterator_resync), (gst_bin_sort_iterator_free),
(gst_bin_iterate_sorted), (gst_bin_element_set_state),
(gst_bin_change_state), (gst_bin_dispose):
Small doc fixes. get_clock -> provide_clock.
* gst/gstelement.c: (gst_element_class_init),
(gst_element_provides_clock), (gst_element_provide_clock),
(gst_element_get_clock), (gst_element_commit_state),
(gst_element_lost_state):
* gst/gstelement.h:
Make get/set_clock() symetric. Add provide_clock vmethod since
that is actually what this function does.
* gst/gstpipeline.c: (gst_pipeline_class_init),
(gst_pipeline_change_state), (gst_pipeline_provide_clock_func),
(gst_pipeline_get_clock):
get_clock -> provide_clock.
Andy Wingo [Wed, 28 Sep 2005 13:05:12 +0000 (13:05 +0000)]
gst/base/gstbasesrc.c (gst_base_src_unlock): Comment a bit in lieu of real docs...
Original commit message from CVS:
2005-09-28 Andy Wingo <wingo@pobox.com>
* gst/base/gstbasesrc.c (gst_base_src_unlock): Comment a bit in
lieu of real docs...
* gst/elements/gstfdsrc.c: Cleaned up a bit.
Tim-Philipp Müller [Wed, 28 Sep 2005 12:52:51 +0000 (12:52 +0000)]
gst/elements/: Make element details static.
Original commit message from CVS:
* gst/elements/gstcapsfilter.c:
* gst/elements/gstfakesink.c:
* gst/elements/gstfakesrc.c:
* gst/elements/gstfdsink.c:
* gst/elements/gstfdsrc.c:
* gst/elements/gstfilesink.c:
* gst/elements/gstfilesrc.c:
* gst/elements/gstidentity.c:
* gst/elements/gsttee.c:
* gst/elements/gsttypefindelement.c:
Make element details static.
Wim Taymans [Wed, 28 Sep 2005 11:03:58 +0000 (11:03 +0000)]
gst/gstbin.c: Some documentation updates.
Original commit message from CVS:
* gst/gstbin.c: (add_to_queue), (clear_queue), (reset_outdegree),
(update_outdegree), (find_element), (gst_bin_sort_iterator_next),
(gst_bin_sort_iterator_resync), (gst_bin_sort_iterator_free),
(gst_bin_iterate_sorted), (gst_bin_element_set_state),
(gst_bin_change_state), (gst_bin_dispose):
Some documentation updates.
Clean up dispose handlers.
* gst/gstobject.c: (gst_object_ref), (gst_object_unref):
* gst/gstpad.c: (gst_pad_dispose):
Clean up dispose handler.
* gst/gstpipeline.c: (gst_pipeline_change_state):
Removed spurious UNLOCK.
Stefan Kost [Tue, 27 Sep 2005 20:40:35 +0000 (20:40 +0000)]
added two new functions to the docs documents all undocumented GstXXXFlags completed some incomplete docs
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* gst/base/gstbasesrc.h:
* gst/gstelement.h:
* gst/gstevent.h:
* gst/gstobject.h:
* gst/gstpad.h:
* gst/gstpipeline.c:
* gst/gstpipeline.h:
* gst/gstutils.h:
* gst/gstxml.h:
added two new functions to the docs
documents all undocumented GstXXXFlags
completed some incomplete docs
Thomas Vander Stichele [Tue, 27 Sep 2005 18:33:48 +0000 (18:33 +0000)]
gst/: remove now useless and leaky resurrection code in dispose
Original commit message from CVS:
* gst/gstbin.c: (gst_bin_dispose):
* gst/gstelement.c: (gst_element_dispose):
remove now useless and leaky resurrection code in dispose
* gst/base/gstbasesrc.c: (gst_base_src_init):
* gst/gstelementfactory.c: (gst_element_factory_create):
* gst/gstobject.c: (gst_object_set_parent):
add some debugging
Wim Taymans [Tue, 27 Sep 2005 17:00:13 +0000 (17:00 +0000)]
docs/design/part-TODO.txt: Update TODO.
Original commit message from CVS:
* docs/design/part-TODO.txt:
Update TODO.
* gst/gstbin.c: (add_to_queue), (clear_queue), (reset_outdegree),
(update_outdegree), (find_element), (gst_bin_sort_iterator_next),
(gst_bin_sort_iterator_resync), (gst_bin_sort_iterator_free),
(gst_bin_iterate_sorted), (gst_bin_element_set_state),
(gst_bin_change_state):
* gst/gstelement.h:
Remove element variable, we keep element info in the iterator now.
Andy Wingo [Tue, 27 Sep 2005 16:30:26 +0000 (16:30 +0000)]
libs/gst/dataprotocol/dataprotocol.c: Fix error-checking return values.
Original commit message from CVS:
2005-09-27 Andy Wingo <wingo@pobox.com>
* libs/gst/dataprotocol/dataprotocol.c: Fix error-checking return
values.
Wim Taymans [Tue, 27 Sep 2005 16:16:39 +0000 (16:16 +0000)]
check/gst/gstbin.c: Enable check that works now.
Original commit message from CVS:
* check/gst/gstbin.c: (GST_START_TEST):
Enable check that works now.
* gst/gstbin.c: (add_to_queue), (clear_queue), (reset_outdegree),
(update_outdegree), (find_element), (gst_bin_sort_iterator_next),
(gst_bin_sort_iterator_resync), (gst_bin_sort_iterator_free),
(gst_bin_iterate_sorted), (gst_bin_element_set_state),
(gst_bin_change_state):
* gst/gstbin.h:
Redid the state change algorithm using a topological sort algo.
Handles all cases correctly.
Exposed iterator for state change order.
* gst/gstelement.h:
Temp storage for state changes. Need to get rid of this soon.
Wim Taymans [Tue, 27 Sep 2005 15:37:40 +0000 (15:37 +0000)]
gst/: Leak fixes, the fold functions need to unref the passed object and _get_parent_*() returns ref to parent.
Original commit message from CVS:
* gst/elements/gsttee.c: (gst_tee_init), (gst_tee_do_push):
* gst/gstutils.c: (intersect_caps_func), (gst_pad_proxy_getcaps),
(link_fold_func), (gst_pad_proxy_setcaps):
Leak fixes, the fold functions need to unref the passed object and
_get_parent_*() returns ref to parent.
Tim-Philipp Müller [Tue, 27 Sep 2005 13:25:18 +0000 (13:25 +0000)]
check/gst/gstbuffer.c: Plug leak in test case and fix 'make check-valgrind'
Original commit message from CVS:
* check/gst/gstbuffer.c: (test_make_writable):
Plug leak in test case and fix 'make check-valgrind'
Tim-Philipp Müller [Tue, 27 Sep 2005 13:07:14 +0000 (13:07 +0000)]
gst/gstbuffer.c: Set READONLY flag on subbuffers, so that gst_buffer_make_writable() works correctly in all circumsta...
Original commit message from CVS:
* gst/gstbuffer.c: (gst_subbuffer_init):
Set READONLY flag on subbuffers, so that gst_buffer_make_writable()
works correctly in all circumstances (we could have just copied
the parent buffer's readonly flag, but conceptually it seems
cleaner to mark all subbuffers as read-only). (based on patch
by Alessandro Decina, #314710).
* check/gst/gstbuffer.c: (create_read_only_buffer),
(test_make_writable), (test_subbuffer_make_writable),
(gst_test_suite):
Add some tests for gst_buffer_make_writable().
Wim Taymans [Tue, 27 Sep 2005 09:57:20 +0000 (09:57 +0000)]
gst/gstbin.c: use gst_object_has_ancestor().
Original commit message from CVS:
* gst/gstbin.c: (bin_element_is_semi_sink), (gst_bin_change_state):
use gst_object_has_ancestor().
* gst/gstobject.c: (gst_object_has_ancestor):
* gst/gstobject.h:
gst_object_has_ancestor() copied from gstbin.c as it is a
usefull function.
* tests/instantiate/create.c: (create_all_elements):
* tests/lat.c: (handoff_src), (handoff_sink):
* tests/sched/runxml.c: (main):
* tests/seeking/seeking1.c: (main):
* tests/threadstate/threadstate2.c: (bus_handler), (timeout_func),
(main):
Fix compilation of some tests.
Tim-Philipp Müller [Tue, 27 Sep 2005 09:29:04 +0000 (09:29 +0000)]
gst/gsterror.h: Remove comment. GST_TYPE_G_ERROR is here to stay,
Original commit message from CVS:
* gst/gsterror.h:
Remove comment. GST_TYPE_G_ERROR is here to stay,
G_TYPE_ERROR has been WONTFIX'ed by the GLib folks
(#316961, #300610).
Wim Taymans [Mon, 26 Sep 2005 18:22:07 +0000 (18:22 +0000)]
check/gst/gstbin.c: Added check that shows error in state change order.
Original commit message from CVS:
* check/gst/gstbin.c: (GST_START_TEST), (gst_bin_suite):
Added check that shows error in state change order.
Wim Taymans [Mon, 26 Sep 2005 17:46:27 +0000 (17:46 +0000)]
gst/gstbin.c: Make state change function use 3 queues again, we were adding elements in the wrong order.
Original commit message from CVS:
* gst/gstbin.c: (gst_bin_change_state):
Make state change function use 3 queues again, we were
adding elements in the wrong order.
* gst/gstghostpad.c: (gst_ghost_pad_do_unlink):
Some debug info,
* gst/gstpad.c: (gst_pad_dispose):
Added some debug info first.
Tim-Philipp Müller [Mon, 26 Sep 2005 17:40:39 +0000 (17:40 +0000)]
docs/design/: Replace all _pull_region() with _pull_range()
Original commit message from CVS:
* docs/design/draft-push-pull.txt:
* docs/design/part-events.txt:
* docs/design/part-overview.txt:
* docs/design/part-scheduling.txt:
Replace all _pull_region() with _pull_range()
Andy Wingo [Mon, 26 Sep 2005 16:19:27 +0000 (16:19 +0000)]
try the fourth
Original commit message from CVS:
try the fourth
Andy Wingo [Mon, 26 Sep 2005 16:12:07 +0000 (16:12 +0000)]
foo
Original commit message from CVS:
foo
Andy Wingo [Mon, 26 Sep 2005 16:07:54 +0000 (16:07 +0000)]
gst/gstvalue.c (_gst_value_initialize): Better fakeout.
Original commit message from CVS:
2005-09-26 Andy Wingo <wingo@pobox.com>
* gst/gstvalue.c (_gst_value_initialize): Better fakeout.
Andy Wingo [Mon, 26 Sep 2005 15:49:23 +0000 (15:49 +0000)]
check/gst-libs/controller.c: Update for controller api change.
Original commit message from CVS:
2005-09-26 Andy Wingo <wingo@pobox.com>
* check/gst-libs/controller.c: Update for controller api change.
Andy Wingo [Mon, 26 Sep 2005 15:43:30 +0000 (15:43 +0000)]
Remove memchunk benchmark stuff, this is taken over by GLib bug 118439.
Original commit message from CVS:
2005-09-26 Andy Wingo <wingo@pobox.com>
* configure.ac:
* tests/Makefile.am:
* tests/memchunk: Remove memchunk benchmark stuff, this is taken
over by GLib bug 118439.
* gst/base/gstbasesink.c (gst_base_sink_wait): Factor out the wait
routines to a function.
* docs/libs/gstreamer-libs-sections.txt: I am a good person today.
* libs/gst/controller/gsthelper.c:
* libs/gst/controller/gstcontroller.h (gst_controller_sync_values)
(gst_object_sync_values): Renamed from sink_values. Ugh.
* libs/gst/controller/gsthelper.c: Update for __gst_controller_key.
* libs/gst/controller/gstcontroller.c (__gst_controller_key):
Renamed from controller_key, as it is exported.
* gst/gstvalue.c (_gst_value_initialize): Fake out the compiler.
Thomas Vander Stichele [Mon, 26 Sep 2005 15:03:43 +0000 (15:03 +0000)]
remove queryutils headers after moving the two used functions to gstquery. also fixes build problem for gstsiddec
Original commit message from CVS:
remove queryutils headers after moving the two used functions
to gstquery. also fixes build problem for gstsiddec
Michael Smith [Mon, 26 Sep 2005 13:40:21 +0000 (13:40 +0000)]
Correct syntax for debug option in gst-launch manpage
Original commit message from CVS:
Correct syntax for debug option in gst-launch manpage
Wim Taymans [Mon, 26 Sep 2005 11:21:42 +0000 (11:21 +0000)]
gst/base/gstbasesrc.c: Some more debugging info.
Original commit message from CVS:
* gst/base/gstbasesrc.c: (gst_base_src_get_range),
(gst_base_src_is_seekable), (gst_base_src_change_state):
Some more debugging info.
Stefan Kost [Sun, 25 Sep 2005 18:34:49 +0000 (18:34 +0000)]
added more docs
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* gst/base/gstbasetransform.h:
* gst/gstindex.h:
added more docs
Stefan Kost [Sun, 25 Sep 2005 12:11:39 +0000 (12:11 +0000)]
inlined the last two docs files removed the tmpl directory from cvs (no more conflicts here!)
Original commit message from CVS:
* docs/gst/.cvsignore:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstpipeline.sgml:
* docs/gst/tmpl/gstplugin.sgml:
* gst/gstpipeline.c:
* gst/gstplugin.c:
* gst/gstplugin.h:
inlined the last two docs files
removed the tmpl directory from cvs (no more conflicts here!)
Stefan Kost [Sun, 25 Sep 2005 11:19:22 +0000 (11:19 +0000)]
inlined two more docs factored gstpadtemplate out of gstpad
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstpad.sgml:
* docs/gst/tmpl/gstpadtemplate.sgml:
* gst/Makefile.am:
* gst/gstpad.c: (gst_pad_class_init), (gst_pad_dispose),
(gst_pad_finalize), (gst_pad_set_pad_template):
* gst/gstpad.h:
* gst/gstpadtemplate.c: (gst_pad_template_get_type),
(gst_pad_template_class_init), (gst_pad_template_init),
(gst_pad_template_dispose), (name_is_valid),
(gst_static_pad_template_get), (gst_pad_template_new),
(gst_static_pad_template_get_caps), (gst_pad_template_get_caps),
(gst_pad_template_pad_created):
* gst/gstpadtemplate.h:
inlined two more docs
factored gstpadtemplate out of gstpad
Tim-Philipp Müller [Sat, 24 Sep 2005 14:35:07 +0000 (14:35 +0000)]
check/gst/gstbin.c: Fix test case: we can't rely on a fixed state change order when going from READY => PAUSED becaus...
Original commit message from CVS:
* check/gst/gstbin.c: (test_children_state_change_order_flagged_sink),
(test_children_state_change_order_semi_sink):
Fix test case: we can't rely on a fixed state change order when
going from READY => PAUSED because the sink might commit its
new state first when the first buffer created by the source
reaches the sink before the source has finished its change state.
(Test case still fails at times, see #316856, comment 5 onwards)
Wim Taymans [Sat, 24 Sep 2005 14:14:03 +0000 (14:14 +0000)]
Various documentation updates.
Original commit message from CVS:
* docs/design/part-events.txt:
* docs/design/part-gstbus.txt:
* docs/design/part-gstpipeline.txt:
* docs/design/part-messages.txt:
* docs/design/part-overview.txt:
* docs/design/part-segments.txt:
* gst/gstbin.c:
* gst/gstbuffer.c:
* gst/gstclock.c:
* gst/gstelement.c:
* gst/gstevent.c:
* gst/gstfilter.c:
* gst/gstiterator.c:
Various documentation updates.
Thomas Vander Stichele [Sat, 24 Sep 2005 11:41:01 +0000 (11:41 +0000)]
gst/gstclock.h: Well, that's embarassing. Luckily we weren't using
Original commit message from CVS:
* gst/gstclock.h:
Well, that's embarassing. Luckily we weren't using
GST_CLOCK_DIFF anywhere.
Thomas Vander Stichele [Fri, 23 Sep 2005 18:08:59 +0000 (18:08 +0000)]
common/gtk-doc.mak: don't fail on building XML, FC4 slave shows a bunch of doc missing bits that I don't get
Original commit message from CVS:
* common/gtk-doc.mak:
don't fail on building XML, FC4 slave shows a bunch of doc
missing bits that I don't get
* gst/gstpad.c:
* gst/gstpipeline.c:
* gst/gststructure.c:
some doc updates
Tim-Philipp Müller [Fri, 23 Sep 2005 18:02:18 +0000 (18:02 +0000)]
Add blurb about how the bus goes into flushing mode and drops all messages when its bin goes from READY into NULL state.
Original commit message from CVS:
* docs/design/part-gstbin.txt:
* docs/design/part-gstbus.txt:
* gst/gstbus.c:
Add blurb about how the bus goes into flushing mode and
drops all messages when its bin goes from READY into NULL
state.
Thomas Vander Stichele [Fri, 23 Sep 2005 17:46:06 +0000 (17:46 +0000)]
add a method to get a GstClockTime out of a structure
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* gst/gststructure.c: (gst_structure_get_clock_time):
* gst/gststructure.h:
add a method to get a GstClockTime out of a structure
Tim-Philipp Müller [Fri, 23 Sep 2005 17:17:42 +0000 (17:17 +0000)]
check/gst/gstbin.c: Added test to check state change order in bins (can still be made to fail here under heavy disk l...
Original commit message from CVS:
* check/gst/gstbin.c: (test_children_state_change_order_flagged_sink),
(test_children_state_change_order_semi_sink), (gst_bin_suite):
Added test to check state change order in bins (can still be made
to fail here under heavy disk load; bails out with 'Push on pad
fakesink:sink0, but it was not activated in push mode').
* gst/gstbin.c: (gst_bin_class_init), (gst_bin_change_state):
Fix state change order when there is only a semi sink (#316856)
* gst/gstbus.c: (gst_bus_class_init):
Use _class_peek_parent(), not _class_ref(); fix docs to say
'default main context' instead of 'mainloop' where that is
what's meant.
* gst/gstelement.c: (gst_element_commit_state),
(gst_element_set_state):
Fix typos in debug messages
Thomas Vander Stichele [Fri, 23 Sep 2005 16:35:43 +0000 (16:35 +0000)]
fix docs
Original commit message from CVS:
fix docs
Thomas Vander Stichele [Fri, 23 Sep 2005 15:48:14 +0000 (15:48 +0000)]
don't break docs build
Original commit message from CVS:
don't break docs build
Thomas Vander Stichele [Fri, 23 Sep 2005 15:36:28 +0000 (15:36 +0000)]
various doc updates
Original commit message from CVS:
* docs/README:
* gst/gstpad.c: (gst_pad_class_init), (gst_pad_chain):
* gst/gstpluginfeature.c:
* gst/gstutils.c:
various doc updates
* gst/base/gstbasesink.c: (gst_base_sink_handle_object):
change an assert into an error until it gets fixed properly
Stefan Kost [Fri, 23 Sep 2005 14:31:21 +0000 (14:31 +0000)]
inlined 3 more biiiig doc files and added some missing docs on the fly
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstelement.sgml:
* docs/gst/tmpl/gstinfo.sgml:
* docs/gst/tmpl/gstobject.sgml:
* gst/gstelement.c:
* gst/gstelement.h:
* gst/gstinfo.c:
* gst/gstinfo.h:
* gst/gstobject.c: (gst_object_class_init):
* gst/gstobject.h:
inlined 3 more biiiig doc files and added some missing docs on the fly
Thomas Vander Stichele [Fri, 23 Sep 2005 11:41:30 +0000 (11:41 +0000)]
put back source in registry. add checks for find_plugin.
Original commit message from CVS:
* check/gst/.cvsignore:
* check/gst/gstplugin.c: (GST_START_TEST), (gst_plugin_suite):
* gst/gstregistryxml.c: (load_plugin),
(gst_registry_xml_save_plugin):
put back source in registry. add checks for find_plugin.
* testsuite/states/bin.c: (assert_state), (empty_bin),
(test_adding_one_element), (main):
* testsuite/states/locked.c: (main):
some compile/run fixes
Thomas Vander Stichele [Thu, 22 Sep 2005 20:02:11 +0000 (20:02 +0000)]
fix leak in the test itself
Original commit message from CVS:
fix leak in the test itself
Wim Taymans [Thu, 22 Sep 2005 18:07:22 +0000 (18:07 +0000)]
gst/base/gstbasesink.c: Prepare for more accurate position reporting and query handling.
Original commit message from CVS:
* gst/base/gstbasesink.c: (gst_base_sink_class_init),
(gst_base_sink_send_event), (gst_base_sink_peer_query),
(gst_base_sink_query):
Prepare for more accurate position reporting and query
handling.
* gst/gstelement.c: (gst_element_send_event),
(gst_element_set_state):
Add some comment.
Wim Taymans [Thu, 22 Sep 2005 17:40:42 +0000 (17:40 +0000)]
gst/gstquery.*: More documentation.
Original commit message from CVS:
* gst/gstquery.c: (gst_query_new_segment), (gst_query_set_segment),
(gst_query_parse_segment):
* gst/gstquery.h:
More documentation.
Add segment query for future use.
Wim Taymans [Thu, 22 Sep 2005 16:51:27 +0000 (16:51 +0000)]
gst/gstbin.c: Some more debug info.
Original commit message from CVS:
* gst/gstbin.c: (gst_bin_add_func):
Some more debug info.
* gst/gstelement.c: (gst_element_send_event):
Simplify send_event
* gst/gstelement.h:
Don't know how flags got broken.
* gst/gstquery.h:
Added new query.
Tim-Philipp Müller [Thu, 22 Sep 2005 15:38:12 +0000 (15:38 +0000)]
check/gst/gstvalue.c: Add simplistic test suite for GST_TYPE_DATE serialisation and deserialisation.
Original commit message from CVS:
* check/gst/gstvalue.c: (test_date), (gst_value_suite):
Add simplistic test suite for GST_TYPE_DATE serialisation and
deserialisation.
Tim-Philipp Müller [Thu, 22 Sep 2005 15:08:02 +0000 (15:08 +0000)]
Add GST_TYPE_DATE, a boxed type that wraps GDate, and the usual bunch of utility functions along with a hack that che...
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* gst/gststructure.c: (gst_structure_set_valist),
(gst_structure_get_date):
* gst/gststructure.h:
* gst/gstvalue.c: (gst_value_set_date), (gst_value_get_date),
(gst_date_copy), (gst_value_compare_date),
(gst_value_serialize_date), (gst_value_deserialize_date),
(gst_value_transform_date_string),
(gst_value_transform_string_date), (_gst_value_initialize):
* gst/gstvalue.h:
Add GST_TYPE_DATE, a boxed type that wraps GDate, and the usual
bunch of utility functions along with a hack that checks that
developers don't accidentally use G_TYPE_DATE where GST_TYPE_DATE
is required. Part of the grand scheme in #170777.
Andy Wingo [Thu, 22 Sep 2005 12:05:05 +0000 (12:05 +0000)]
gst/gstconfig.h.in: Psych out gtk-doc.
Original commit message from CVS:
2005-09-22 Andy Wingo <wingo@pobox.com>
* gst/gstconfig.h.in: Psych out gtk-doc.
* docs/gst/gstreamer-sections.txt: Add GST_HAVE_GLIB_2_8.
* check/Makefile.am (check_PROGRAMS): Add gstplugin to the tests.
* tools/gst-inspect.c (print_element_list): Plug some
inconsequential leaks.
* gst/gstregistry.c (gst_registry_get_default): Doc.
* gst/gsttypefindfactory.c (gst_type_find_factory_call_function):
* gst/gstelementfactory.c (gst_element_factory_create):
* gst/gstindexfactory.c (gst_index_factory_create): Update for
refcount changes.
* gst/gstpluginfeature.c (gst_plugin_feature_list_free): Doc.
(gst_plugin_feature_load): Doc, don't eat refs.
* gst/gstplugin.c (gst_plugin_load): Doc, don't eat refs.
(gst_plugin_list_free): Doc.
(gst_plugin_load_file): Doc updates.
Andy Wingo [Thu, 22 Sep 2005 09:30:41 +0000 (09:30 +0000)]
gst/gstbuffer.c (gst_buffer_get_caps): Like all our _get accessors returning refcounted objects, return a ref.
Original commit message from CVS:
2005-09-22 Andy Wingo <wingo@pobox.com>
* gst/gstbuffer.c (gst_buffer_get_caps): Like all our _get
accessors returning refcounted objects, return a ref.
* check/gst/gstbuffer.c (GST_START_TEST): Use refcount-idempotent
accessor for caps. IDEMPOTENCE. Oh yes.
Tim-Philipp Müller [Wed, 21 Sep 2005 21:39:06 +0000 (21:39 +0000)]
gst/gstinfo.c: Add mutex to serialise access to the hash table with the function pointer => function name string mapp...
Original commit message from CVS:
Reviewed by: Tim-Philipp Müller <tim at centricular dot net>
* gst/gstinfo.c: (_gst_debug_nameof_funcptr),
(_gst_debug_register_funcptr):
Add mutex to serialise access to the hash table with
the function pointer => function name string mapping;
make that hash table static scope (#316809).
* gst/registries/.cvsignore:
Remove left-over file.
Tim-Philipp Müller [Wed, 21 Sep 2005 15:55:12 +0000 (15:55 +0000)]
docs/pwg/appendix-porting.xml: And something about newsegment events and caps-on-buffers to the porting guide (feel f...
Original commit message from CVS:
* docs/pwg/appendix-porting.xml:
And something about newsegment events and caps-on-buffers to
the porting guide (feel free to improve).
Andy Wingo [Wed, 21 Sep 2005 13:24:33 +0000 (13:24 +0000)]
Test that removing probes from within the probe functions works.
Original commit message from CVS:
(test_buffer_probe_once): Test that removing probes from within
the probe functions works.
Andy Wingo [Wed, 21 Sep 2005 13:11:22 +0000 (13:11 +0000)]
check/gst/gstutils.c (test_buffer_probe_n_times): Add tests for data and event probes on the same pad.
Original commit message from CVS:
2005-09-21 Andy Wingo <wingo@pobox.com>
* check/gst/gstutils.c (test_buffer_probe_n_times): Add tests for
data and event probes on the same pad.
Andy Wingo [Wed, 21 Sep 2005 12:21:10 +0000 (12:21 +0000)]
check/gst/gstutils.c: New file.
Original commit message from CVS:
2005-09-21 Andy Wingo <wingo@pobox.com>
* check/gst/gstutils.c: New file.
(test_buffer_probe_n_times): A simple buffer probe test. More to
come, foolios.
* gst/gstutils.c (gst_pad_add_buffer_probe): Connect to
have-data::buffer, not have-data.
(gst_pad_add_event_probe): Likewise for have-data::event.
(gst_pad_add_data_probe): More docs. The part about 'resolving the
peer' isn't quite right yet though.
(gst_pad_remove_buffer_probe, gst_pad_remove_event_probe)
(gst_pad_remove_data_probe): Change to take the guint handler_id
as their arg, not the function+data, which is more glib-like.
* gst/gstpad.c (gst_pad_emit_have_data_signal): Add a detail to
the signal emission to indicate if the data is a buffer or an
event.
(gst_pad_get_type): Initialize buffer and event quarks.
(gst_pad_class_init): have-data is now a detailed signal, yes it
is.
Tim-Philipp Müller [Wed, 21 Sep 2005 11:52:04 +0000 (11:52 +0000)]
gst/: Don't put functional code in g_return_if_fail() or g_return_val_if_fail() statements, otherwise things will bre...
Original commit message from CVS:
* gst/base/gstbasetransform.c: (gst_base_transform_transform_size):
* gst/gstutils.c: (gst_util_set_value_from_string),
(gst_util_set_object_arg):
Don't put functional code in g_return_if_fail() or
g_return_val_if_fail() statements, otherwise things will
break when G_DISABLE_CHECKS is defined during compilation.
Stefan Kost [Wed, 21 Sep 2005 09:48:40 +0000 (09:48 +0000)]
inlied another one and added some obvious docs
Original commit message from CVS:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstvalue.sgml:
* gst/gstvalue.c:
* gst/gstvalue.h:
inlied another one and added some obvious docs
Wim Taymans [Wed, 21 Sep 2005 09:13:32 +0000 (09:13 +0000)]
gst/elements/gstfdsrc.*: Properly implement fdsrc. Removed signal and timeout, better implemented somewhere else.
Original commit message from CVS:
* gst/elements/gstfdsrc.c: (gst_fdsrc_class_init),
(gst_fdsrc_init), (gst_fdsrc_start), (gst_fdsrc_stop),
(gst_fdsrc_unlock), (gst_fdsrc_set_property),
(gst_fdsrc_get_property), (gst_fdsrc_create):
* gst/elements/gstfdsrc.h:
Properly implement fdsrc. Removed signal and timeout,
better implemented somewhere else.
Stefan Kost [Wed, 21 Sep 2005 08:58:48 +0000 (08:58 +0000)]
inlined more docs
Original commit message from CVS:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstimplementsinterface.sgml:
* gst/gstinterface.c:
inlined more docs
Stefan Kost [Wed, 21 Sep 2005 08:40:55 +0000 (08:40 +0000)]
docs/gst/: remove obsolete doc file
Original commit message from CVS:
* docs/gst/gstreamer-sections.txt:
* docs/gst/tmpl/.cvsignore:
* docs/gst/tmpl/gstenumtypes.sgml:
remove obsolete doc file
David Schleef [Wed, 21 Sep 2005 07:37:02 +0000 (07:37 +0000)]
gst/gstelementfactory.c: Drink a little beer, fix a little leak.
Original commit message from CVS:
* gst/gstelementfactory.c: (gst_element_factory_make): Drink a
little beer, fix a little leak.
Stefan Kost [Tue, 20 Sep 2005 20:54:37 +0000 (20:54 +0000)]
remove files
Original commit message from CVS:
remove files
Stefan Kost [Tue, 20 Sep 2005 20:40:00 +0000 (20:40 +0000)]
more docs inlined, splitted gstindex.{c,h}
Original commit message from CVS:
* docs/gst/gstreamer-docs.sgml:
* docs/gst/gstreamer-sections.txt:
* docs/gst/tmpl/.cvsignore:
* gst/Makefile.am:
* gst/gst.h:
* gst/gstbin.c:
* gst/gstelement.h:
* gst/gstindex.c: (gst_index_class_init):
* gst/gstindex.h:
* gst/gstindexfactory.c: (gst_index_factory_get_type),
(gst_index_factory_class_init), (gst_index_factory_init),
(gst_index_factory_finalize), (gst_index_factory_new),
(gst_index_factory_destroy), (gst_index_factory_find),
(gst_index_factory_create), (gst_index_factory_make):
* gst/gstindexfactory.h:
* gst/gstpluginfeature.c:
* gst/gstpluginfeature.h:
* libs/gst/controller/gstcontroller.c: (gst_controller_new_valist):
more docs inlined, splitted gstindex.{c,h}
Thomas Vander Stichele [Tue, 20 Sep 2005 20:19:52 +0000 (20:19 +0000)]
fix a leak in controller
Original commit message from CVS:
fix a leak in controller
Tim-Philipp Müller [Tue, 20 Sep 2005 19:16:43 +0000 (19:16 +0000)]
gst/elements/gstfilesink.c: Set sync to FALSE by default.
Original commit message from CVS:
* gst/elements/gstfilesink.c: (gst_file_sink_init):
Set sync to FALSE by default.
Wim Taymans [Tue, 20 Sep 2005 17:38:51 +0000 (17:38 +0000)]
gst/base/gstbasesink.c: Make sync property settable from subclass.
Original commit message from CVS:
* gst/base/gstbasesink.c: (gst_base_sink_class_init),
(gst_base_sink_init):
Make sync property settable from subclass.
* gst/elements/gstfakesink.c: (gst_fake_sink_init),
(gst_fake_sink_change_state):
Set sync to FALSE by default.
Wim Taymans [Tue, 20 Sep 2005 17:30:35 +0000 (17:30 +0000)]
The timeout handler should have lower priority than the source so we don't timeout before popping a message with 0 ti...
Original commit message from CVS:
* gst/gstbus.c: (poll_func), (poll_timeout), (gst_bus_poll):
* tools/gst-launch.c: (main):
The timeout handler should have lower priority than the source
so we don't timeout before popping a message with 0 timeout.
Dump error messages after failed state change.
Tim-Philipp Müller [Tue, 20 Sep 2005 17:21:13 +0000 (17:21 +0000)]
tools/gst-inspect.c: Fix two typos.
Original commit message from CVS:
* tools/gst-inspect.c: (print_element_properties_info):
Fix two typos.
Thomas Vander Stichele [Tue, 20 Sep 2005 15:45:42 +0000 (15:45 +0000)]
remove the sync property from fakesink.
Original commit message from CVS:
* check/gst/gstevent.c:
* gst/elements/gstfakesink.c:
* gst/elements/gstfakesink.h:
remove the sync property from fakesink.
has the side effect of setting sync TRUE
for fakesink, which is a change. Anyone who knows how
to fix this nicely in a GObject-y way, feel free.
Stefan Kost [Tue, 20 Sep 2005 15:19:08 +0000 (15:19 +0000)]
docs/gst/gstreamer-docs.sgml: remove probe refsection
Original commit message from CVS:
* docs/gst/gstreamer-docs.sgml:
remove probe refsection
Stefan Kost [Tue, 20 Sep 2005 12:50:23 +0000 (12:50 +0000)]
check/Makefile.am: disable valgrinding the controller test again
Original commit message from CVS:
* check/Makefile.am:
disable valgrinding the controller test again
* docs/gst/gstreamer-sections.txt:
update for api-changes
Wim Taymans [Tue, 20 Sep 2005 12:05:47 +0000 (12:05 +0000)]
gst/base/gstbasesink.*: Added sync property to basesink to disable clock sync.
Original commit message from CVS:
* gst/base/gstbasesink.c: (gst_base_sink_class_init),
(gst_base_sink_set_property), (gst_base_sink_get_property),
(gst_base_sink_do_sync):
* gst/base/gstbasesink.h:
Added sync property to basesink to disable clock sync.
Andy Wingo [Tue, 20 Sep 2005 11:09:50 +0000 (11:09 +0000)]
gst/gstelementfactory.c (gst_element_factory_create): Avoid eating the caller's refcount.
Original commit message from CVS:
2005-09-20 Andy Wingo <wingo@pobox.com>
* gst/gstelementfactory.c (gst_element_factory_create): Avoid
eating the caller's refcount.
* gst/gstobject.h (GST_OBJECT_REFCOUNT)
(GST_OBJECT_REFCOUNT_VALUE): Conditionally fondle the right
refcount.
* gst/gstconfig.h.in (GST_HAVE_GLIB_2_8):
* configure.ac (GST_HAVE_GLIB_2_8_DEFINE): Make the availability
of GLib 2.8 public, so we can know which refcount to check in
tests.
* gst/gstobject.c: Use the GST_HAVE_GLIB_2_8 define.
(gst_object_init): Only set the gst refcount if we're going ahead
with the refcount hack.
Stefan Kost [Tue, 20 Sep 2005 10:41:03 +0000 (10:41 +0000)]
more leaks plumbed, added more debug-logging
Original commit message from CVS:
* check/gst-libs/controller.c: (plugin_init), (GST_START_TEST):
* libs/gst/controller/gstcontroller.c: (gst_controller_new_valist):
more leaks plumbed, added more debug-logging
* gst/gstmacros.h:
whitespace fix
Thomas Vander Stichele [Tue, 20 Sep 2005 09:47:13 +0000 (09:47 +0000)]
remove include of removed header
Original commit message from CVS:
remove include of removed header
Thomas Vander Stichele [Tue, 20 Sep 2005 09:28:56 +0000 (09:28 +0000)]
gst/gstclock.c: Commit from the Political Party For More Atomic CVS Commits, so that people don't waste too much of t...
Original commit message from CVS:
* gst/gstclock.c: (_gst_clock_id_free):
Commit from the Political Party For More Atomic CVS Commits,
so that people don't waste too much of their day fishing
out obvious leaks out of massive commits.
Oh, and fix a pretty damn obvious leak in the memchunk
removal code.
Stefan Kost [Tue, 20 Sep 2005 09:23:39 +0000 (09:23 +0000)]
check/: plug mem-leak, re-add to valgrindable tests
Original commit message from CVS:
* check/Makefile.am:
* check/gst-libs/controller.c: (plugin_init), (GST_START_TEST):
plug mem-leak, re-add to valgrindable tests
Thomas Vander Stichele [Tue, 20 Sep 2005 09:08:25 +0000 (09:08 +0000)]
unbreak the build for those who have chronic arthritis and typing "make check" is just too taxing on the hands
Original commit message from CVS:
unbreak the build for those who have chronic arthritis
and typing "make check" is just too taxing on the hands
Andy Wingo [Tue, 20 Sep 2005 08:25:32 +0000 (08:25 +0000)]
gst/gst.h: Re-add marshal to gst.h's include list -- if we really want it out, you should fix plugins at the same time.
Original commit message from CVS:
2005-09-20 Andy Wingo <wingo@pobox.com>
* gst/gst.h: Re-add marshal to gst.h's include list -- if we
really want it out, you should fix plugins at the same time.
Stefan Kost [Tue, 20 Sep 2005 07:32:48 +0000 (07:32 +0000)]
added missing symbols to api docs disable ref-count hack if we have glib >= 2.8
Original commit message from CVS:
* configure.ac:
* docs/gst/gstreamer-sections.txt:
* gst/gstobject.c:
added missing symbols to api docs
disable ref-count hack if we have glib >= 2.8
David Schleef [Tue, 20 Sep 2005 06:28:33 +0000 (06:28 +0000)]
docs/gst/Makefile.am: Ignore a few more internal headers
Original commit message from CVS:
* docs/gst/Makefile.am: Ignore a few more internal headers
* docs/gst/gstreamer-docs.sgml: Remove old sections
* docs/gst/gstreamer-sections.txt: Remove old sections
* docs/gst/tmpl/gstobject.sgml: update
* docs/gst/tmpl/gstplugin.sgml: update
* docs/gst/tmpl/gstpluginfeature.sgml: update
* docs/random/ds/0.9-suggested-changes: update.
* gst/Makefile.am: remove memchunk and trashstack, since they're
not used.
* gst/gst.c: (gst_deinit): rename gst_registry_deinit to _cleanup
* gst/gst.h: don't include some headers
* gst/gstchildproxy.c: add gstmarshal.h
* gst/gstclock.c: Don't use memchunks
* gst/gstminiobject.c: Add some docs
* gst/gstobject.c: remove DESTROYED flag, since it's redundant
* gst/gstobject.h: same
* gst/gstplugin.c: include gstmacros.h
* gst/gstplugin.h: don't include gstmacros.h, since it's private
* gst/gstquery.c: don't use memchunks
* gst/gstregistry.c: rename gst_registry_deinit()
* gst/gstregistry.h: same
David Schleef [Tue, 20 Sep 2005 05:13:30 +0000 (05:13 +0000)]
docs/libs/gstreamer-libs-docs.sgml: Remove docs for getbits
Original commit message from CVS:
* docs/libs/gstreamer-libs-docs.sgml: Remove docs for getbits
* docs/libs/gstreamer-libs-sections.txt:
* docs/libs/tmpl/gstgetbits.sgml:
* docs/libs/tmpl/gstputbits.sgml:
Jan Schmidt [Tue, 20 Sep 2005 00:27:37 +0000 (00:27 +0000)]
check/generic/states.c: Add a sleep to ensure elements have a chance to start their pad tasks before shutdown. Reduce...
Original commit message from CVS:
* check/generic/states.c: (GST_START_TEST), (states_suite):
Add a sleep to ensure elements have a chance to start their
pad tasks before shutdown. Reduces racy test results.
* gst/elements/gstfdsrc.c: (gst_fdsrc_init), (gst_fdsrc_create):
Time out the select every now and then to check for shutdown.
Tim-Philipp Müller [Mon, 19 Sep 2005 20:01:45 +0000 (20:01 +0000)]
win32/gstenumtypes.*: Update.
Original commit message from CVS:
* win32/gstenumtypes.c:
* win32/gstenumtypes.h:
Update.
Wim Taymans [Mon, 19 Sep 2005 16:32:44 +0000 (16:32 +0000)]
gst/gstpipeline.c: Automatically PAUSE and RESUME a pipeline when a flushing seek is performed.
Original commit message from CVS:
* gst/gstpipeline.c: (do_pipeline_seek), (gst_pipeline_send_event):
Automatically PAUSE and RESUME a pipeline when a flushing seek
is performed.
Removed old files.
Thomas Vander Stichele [Mon, 19 Sep 2005 16:28:58 +0000 (16:28 +0000)]
whitespace fix
Original commit message from CVS:
whitespace fix
Andy Wingo [Mon, 19 Sep 2005 15:12:25 +0000 (15:12 +0000)]
gst/gstregistry.h: Spacing fixen.
Original commit message from CVS:
2005-09-19 Andy Wingo <wingo@pobox.com>
* gst/gstregistry.h: Spacing fixen.
Wim Taymans [Mon, 19 Sep 2005 14:55:26 +0000 (14:55 +0000)]
gst/base/gstbasesrc.c: Handle state change failure more correctly.
Original commit message from CVS:
* gst/base/gstbasesrc.c: (gst_base_src_change_state):
Handle state change failure more correctly.
Thomas Vander Stichele [Mon, 19 Sep 2005 14:41:57 +0000 (14:41 +0000)]
check/: enable cleanup again after fixing the leak
Original commit message from CVS:
* check/Makefile.am:
* check/pipelines/cleanup.c: (run_pipeline):
* check/pipelines/simple_launch_lines.c: (run_pipeline),
(GST_START_TEST):
enable cleanup again after fixing the leak
* docs/README:
some more info on docs
Thomas Vander Stichele [Mon, 19 Sep 2005 14:20:37 +0000 (14:20 +0000)]
don't complain about my ARM .so files. Another reason why it does make sense to have plugins follow a standard file ...
Original commit message from CVS:
don't complain about my ARM .so files. Another reason why it does make sense
to have plugins follow a standard file name pattern like libgst(whatever).so
Thomas Vander Stichele [Mon, 19 Sep 2005 14:09:54 +0000 (14:09 +0000)]
check/Makefile.am: re-enable tests now that leaks are plugged
Original commit message from CVS:
* check/Makefile.am:
re-enable tests now that leaks are plugged
* check/gst/gst.c:
* check/gst/gstbin.c:
* check/gst/gstpipeline.c:
add some more tests while fixing leaks
* common/check.mak:
make sure binaries are uptodate when valgrinding/gdbing
* gst/gst.c:
* gst/gstelementfactory.c:
remove a ref too many, and add a FIXME for when we get
round to disposing of classes
* gst/gstplugin.c:
fix the refcounting when loading a plugin from a file and
the code pretends that the pointer is the same even though
of course it can change
* gst/gstpluginfeature.c:
unref plugins marked cached (a bit confusing as a name)
as the docs state should be done
various doc additions to explain refcounting
* gst/gstregistry.c:
* gst/gstregistryxml.c:
debugging
Christian Schaller [Mon, 19 Sep 2005 14:09:37 +0000 (14:09 +0000)]
update spec file
Original commit message from CVS:
update spec file
Wim Taymans [Mon, 19 Sep 2005 11:18:03 +0000 (11:18 +0000)]
GstBusHandler -> GstBusFunc, return value has the same meaning as any other GSource (FALSE == remove source).
Original commit message from CVS:
* check/gst/gstbin.c: (pop_messages), (GST_START_TEST):
* check/gst/gstbus.c: (message_func_eos), (message_func_app),
(send_messages), (GST_START_TEST), (gstbus_suite):
* check/gst/gstpipeline.c: (GST_START_TEST):
* check/pipelines/cleanup.c: (run_pipeline):
* check/pipelines/simple_launch_lines.c: (run_pipeline),
(GST_START_TEST):
* gst/gstbus.c: (gst_bus_have_pending), (gst_bus_source_prepare),
(gst_bus_source_check), (gst_bus_source_dispatch),
(gst_bus_create_watch), (gst_bus_add_watch_full),
(gst_bus_add_watch), (poll_func), (poll_timeout), (gst_bus_poll):
* gst/gstbus.h:
* tools/gst-launch.c: (event_loop):
* tools/gst-md5sum.c: (event_loop):
GstBusHandler -> GstBusFunc, return value has the same meaning as
any other GSource (FALSE == remove source).
_add_watch() and _add_watch_full() now take a MessageType mask to
only handle specific types of messages.
_poll() returns the GstMessage instead of the message type to avoid
race conditions.
_have_pending() takes a MessageType mask now too.
Added testsuite for multiple bus watches.
Fix testsuites and applications for new bus API.
Thomas Vander Stichele [Sun, 18 Sep 2005 22:15:23 +0000 (22:15 +0000)]
mark a bunch of the tests as to fix until we fix them
Original commit message from CVS:
mark a bunch of the tests as to fix until we fix them
Thomas Vander Stichele [Sun, 18 Sep 2005 21:40:58 +0000 (21:40 +0000)]
common/check.mak: use GST_PLUGIN settings for valgrind tests as well, so we're valgrinding the correct thing
Original commit message from CVS:
* common/check.mak:
use GST_PLUGIN settings for valgrind tests as well, so we're
valgrinding the correct thing
* gst/gst.c: (init_post):
plug another leak
Thomas Vander Stichele [Sun, 18 Sep 2005 21:24:55 +0000 (21:24 +0000)]
various cleanups and memleak plugging. make valgrind is happy now.
Original commit message from CVS:
various cleanups and memleak plugging. make valgrind is happy now.
Thomas Vander Stichele [Sun, 18 Sep 2005 21:23:13 +0000 (21:23 +0000)]
add check-valgrind target
Original commit message from CVS:
add check-valgrind target