Lasse Collin [Wed, 23 Jan 2008 11:42:35 +0000 (13:42 +0200)]
Fixed a typo.
Lasse Collin [Wed, 23 Jan 2008 11:40:45 +0000 (13:40 +0200)]
Fix a memory leak in the Subblock encoder.
Lasse Collin [Wed, 23 Jan 2008 11:36:07 +0000 (13:36 +0200)]
Fix Size of Header Metadata Block handling. Now
lzma_metadata.header_metadata_size == LZMA_VLI_VALUE_UNKNOWN
is not allowed at all. To indicate missing Header Metadata
Block, header_metadata_size must be set to zero. This is
what Metadata decoder does after this patch too.
Note that other missing fields in lzma_metadata are still
indicated with LZMA_VLI_VALUE_UNKNOWN. This isn't as
illogical as it sounds at first, because missing Size of
Header Metadata Block means that Header Metadata Block is
not present in the Stream. With other Metadata fields,
a missing field means only that the value is unknown.
Lasse Collin [Wed, 23 Jan 2008 11:15:55 +0000 (13:15 +0200)]
Fix a memory leak in metadata_decoder.c.
Lasse Collin [Wed, 23 Jan 2008 11:13:58 +0000 (13:13 +0200)]
Fix the fix
863028cb7ad6d8d0455fa69348f56b376d7b908f which
just moved to problem. Now it's really fixed.
Lasse Collin [Tue, 22 Jan 2008 22:21:04 +0000 (00:21 +0200)]
Take advantage of return_if_error() macro in
lzma_info_metadata_set() in info.c.
Lasse Collin [Tue, 22 Jan 2008 22:18:32 +0000 (00:18 +0200)]
Fixed a dangling pointer that caused invalid free().
Lasse Collin [Tue, 22 Jan 2008 20:49:24 +0000 (22:49 +0200)]
Added lzma_easy_* functions. These should make using
liblzma as easy as using zlib, because the easy API
don't require developers to know any fancy LZMA options.
Note that Multi-Block Stream encoding is currently broken.
The easy API should be OK, the bug(s) are elsewhere.
Lasse Collin [Tue, 22 Jan 2008 19:16:22 +0000 (21:16 +0200)]
Fix Multi-Block Stream encoder's EOPM usage.
Lasse Collin [Mon, 21 Jan 2008 22:15:11 +0000 (00:15 +0200)]
Made lzma_extra pointers const in lzma_options_stream.
Lasse Collin [Sun, 20 Jan 2008 18:15:21 +0000 (20:15 +0200)]
Updated debug/sync_flush.c.
Lasse Collin [Sun, 20 Jan 2008 18:14:26 +0000 (20:14 +0200)]
Added debug/repeat.c.
Lasse Collin [Sun, 20 Jan 2008 18:12:58 +0000 (20:12 +0200)]
Fix alignment handling bugs in Subblock encoder.
This leaves one known alignment bug unfixed: If repeat count
doesn't fit into 28-bit integer, the encoder has to split
this to multiple Subblocks with Subblock Type `Repeating Data'.
The extra Subblocks may have wrong alignment. Correct alignment
is restored after the split Repeating Data has been completely
written out.
Since the encoder doesn't even try to fix the alignment unless
the size of Data is at least 4 bytes, to trigger this bug you
need at least 4 GiB of repeating data with sequence length of
4 or more bytes. Since the worst thing done by this bug is
misaligned data (no data corruption), this bug simply isn't
worth fixing, because a proper fix isn't simple.
Lasse Collin [Sat, 19 Jan 2008 19:16:33 +0000 (21:16 +0200)]
Implemented LZMA_SYNC_FLUSH support to the Subblock encoder.
The API for handing Subfilters was changed to make it
consistent with LZMA_SYNC_FLUSH.
A few sanity checks were added for Subfilter handling. Some
small bugs were fixed. More comments were added.
Lasse Collin [Sat, 19 Jan 2008 13:19:21 +0000 (15:19 +0200)]
Revised the Delta filter implementation. The initialization
function is still shared between encoder and decoder, but the
actual coding is in separate files for encoder and decoder.
There are now separate functions for the actual delta
calculation depending on if Delta is the last filter in the
chain or not. If it is the last, the new code copies the
data from input to output buffer and does the delta
calculation at the same time. The old code first copied the
data, then did the delta in the target buffer, which required
reading through the data twice.
Support for LZMA_SYNC_FLUSH was added to the Delta encoder.
This doesn't change anything in the file format.
Lasse Collin [Fri, 18 Jan 2008 18:18:08 +0000 (20:18 +0200)]
Added the debug directory and the first debug tool
(sync_flush). These tools are not built unless the
user runs "make" in the debug directory.
Lasse Collin [Fri, 18 Jan 2008 18:13:00 +0000 (20:13 +0200)]
Added test files to test usage of flush marker in LZMA.
Lasse Collin [Fri, 18 Jan 2008 18:02:52 +0000 (20:02 +0200)]
Fix LZMA_SYNC_FLUSH handling in LZ and LZMA encoders.
That code is now almost completely in LZ coder, where
it can be shared with other LZ77-based algorithms in
future.
Lasse Collin [Fri, 18 Jan 2008 15:21:24 +0000 (17:21 +0200)]
Don't add -g to CFLAGS when --enable-debug is specified.
It's the job of the user to put that in CFLAGS.
Lasse Collin [Fri, 18 Jan 2008 12:17:37 +0000 (14:17 +0200)]
Set stdin and stdout to binary mode on Windows. This patch is
a forward port of
b7b22fcb979a16d3a47c8001f058c9f7d4416068
from lzma-utils-legacy.git. I don't know if the new code base
builds on Windows, but this is a start.
Lasse Collin [Thu, 17 Jan 2008 22:50:29 +0000 (00:50 +0200)]
Added test_compress.sh and bunch of files needed by it.
This new set of tests compress and decompress several
test files with many different compression options.
This set of tests will be extended later.
Lasse Collin [Thu, 17 Jan 2008 16:56:53 +0000 (18:56 +0200)]
Subblock decoder: Don't exit the main loop in decode_buffer()
too early if we hit End of Input while decoding a Subblock of
type Repeating Data. To keep the loop termination condition
elegant, the order of enumerations in coder->sequence were
changed.
To keep the case-labels in roughly the same order as the
enumerations in coder->sequence, large chunks of code was
moved around. This made the diff big and ugly compared to
the amount of the actual changes made.
Lasse Collin [Thu, 17 Jan 2008 15:39:42 +0000 (17:39 +0200)]
Fix wrong too small size of argument unfiltered_max
in ia64_coder_init(). It triggered assert() in
simple_coder.c, and could have caused a buffer overflow.
This error was probably a copypaste mistake, since most
of the simple filters use unfiltered_max = 4.
Lasse Collin [Thu, 17 Jan 2008 15:27:45 +0000 (17:27 +0200)]
Added --delta to the output of "lzma --help".
Lasse Collin [Thu, 17 Jan 2008 11:14:20 +0000 (13:14 +0200)]
Fix Subblock docoder: If Subblock filter was used with known
Uncompressed Size, and the last output byte was from RLE,
the code didn't stop decoding as it should have done.
Lasse Collin [Wed, 16 Jan 2008 14:33:37 +0000 (16:33 +0200)]
Tiny non-technical edits to file-format.txt.
Lasse Collin [Wed, 16 Jan 2008 12:48:04 +0000 (14:48 +0200)]
Plugged a memory leak in stream_decoder.c.
Lasse Collin [Wed, 16 Jan 2008 12:47:27 +0000 (14:47 +0200)]
Added memory leak detection to lzmadec.c.
Lasse Collin [Wed, 16 Jan 2008 12:46:50 +0000 (14:46 +0200)]
Added lzma_memlimit_count().
Lasse Collin [Wed, 16 Jan 2008 12:31:44 +0000 (14:31 +0200)]
Added ARRAY_SIZE(array) macro.
Lasse Collin [Wed, 16 Jan 2008 11:27:03 +0000 (13:27 +0200)]
Make Uncompresed Size validation more strict
in alone_decoder.c.
Lasse Collin [Tue, 15 Jan 2008 15:46:59 +0000 (17:46 +0200)]
Free the allocated memory in lzmadec if debugging is
enabled. This should make it possible to detect possible
memory leaks with Valgrind.
Lasse Collin [Tue, 15 Jan 2008 14:25:38 +0000 (16:25 +0200)]
Fix memory leaks from test_block_header.c.
Lasse Collin [Tue, 15 Jan 2008 12:23:35 +0000 (14:23 +0200)]
Use fastpos.h when encoding LZMA dictionary size in
Filter Flags encoder.
Lasse Collin [Tue, 15 Jan 2008 12:02:22 +0000 (14:02 +0200)]
Revised the fastpos code. It now uses the slightly faster
table-based version from LZMA SDK 4.57. This should be
fast on most systems.
A simpler and smaller alternative version is also provided.
On some CPUs this can be even a little faster than the
default table-based version (see comments in fastpos.h),
but on most systems the table-based code is faster.
Lasse Collin [Tue, 15 Jan 2008 11:32:13 +0000 (13:32 +0200)]
Added bsr.h.
Lasse Collin [Tue, 15 Jan 2008 11:29:14 +0000 (13:29 +0200)]
Fixed assembler detection in configure.ac, and added
detection for x86_64.
Lasse Collin [Tue, 15 Jan 2008 10:20:41 +0000 (12:20 +0200)]
Omit invalid space from printf() format string
in price_table_gen.c.
Lasse Collin [Tue, 15 Jan 2008 07:54:34 +0000 (09:54 +0200)]
Removed a few unused macros from lzma_common.h.
Lasse Collin [Tue, 15 Jan 2008 06:37:42 +0000 (08:37 +0200)]
Fix a typo in lzma_encoder.c.
Lasse Collin [Tue, 15 Jan 2008 06:36:25 +0000 (08:36 +0200)]
Convert bittree_get_price() and bittree_reverse_get_price()
from macros to inline functions.
Lasse Collin [Tue, 15 Jan 2008 05:44:59 +0000 (07:44 +0200)]
Fix CRC code in case --enable-small is used.
Lasse Collin [Tue, 15 Jan 2008 05:41:39 +0000 (07:41 +0200)]
Fix typo in test_index.c.
Lasse Collin [Tue, 15 Jan 2008 05:40:21 +0000 (07:40 +0200)]
Added precomputed range coder probability price table.
Lasse Collin [Mon, 14 Jan 2008 11:42:43 +0000 (13:42 +0200)]
Remove RC_BUFFER_SIZE from lzma_encoder_private.h
and replace it with a sanity check.
Lasse Collin [Mon, 14 Jan 2008 11:39:54 +0000 (13:39 +0200)]
Major changes to LZ encoder, LZMA encoder, and range encoder.
These changes implement support for LZMA_SYNC_FLUSH in LZMA
encoder, and move the temporary buffer needed by range encoder
from lzma_range_encoder structure to lzma_lz_encoder.
Lasse Collin [Mon, 14 Jan 2008 11:34:29 +0000 (13:34 +0200)]
Added one assert() to process.c of the command line tool.
Lasse Collin [Mon, 14 Jan 2008 10:09:52 +0000 (12:09 +0200)]
Don't use coder->lz.stream_end_was_reached in assertions
in match_c.h.
Lasse Collin [Mon, 14 Jan 2008 10:08:02 +0000 (12:08 +0200)]
In lzma_read_match_distances(), don't use
coder->lz.stream_end_was_reached. That variable
will be removed, and the check isn't required anyway.
Rearrange the check so that it doesn't make one to
think that there could be an integer overflow.
Lasse Collin [Mon, 14 Jan 2008 09:56:41 +0000 (11:56 +0200)]
Small LZMA_SYNC_FLUSH fixes to Block and Single-Stream encoders.
Lasse Collin [Mon, 14 Jan 2008 09:54:56 +0000 (11:54 +0200)]
More fixes to LZMA decoder's flush marker handling.
Lasse Collin [Thu, 10 Jan 2008 15:13:42 +0000 (17:13 +0200)]
Eliminate lzma_lz_encoder.must_move_pos. It's needed
only in one place which isn't performance criticial.
Lasse Collin [Wed, 9 Jan 2008 18:05:57 +0000 (20:05 +0200)]
Define HAVE_ASM_X86 when x86 assembler optimizations are
used. This #define will be useful for inline assembly.
Lasse Collin [Wed, 9 Jan 2008 10:06:46 +0000 (12:06 +0200)]
Added good-single-none-empty_3.lzma and
bad-single-none-empty.lzma.
Lasse Collin [Tue, 8 Jan 2008 21:11:59 +0000 (23:11 +0200)]
Take advantage of return_if_error() in block_decoder.c.
Lasse Collin [Tue, 8 Jan 2008 21:10:57 +0000 (23:10 +0200)]
Updated tests/files/README.
Lasse Collin [Tue, 8 Jan 2008 21:05:40 +0000 (23:05 +0200)]
Added test files with empty Compressed Data.
Lasse Collin [Tue, 8 Jan 2008 20:58:42 +0000 (22:58 +0200)]
Fix decoding of Blocks that have only Block Header.
Lasse Collin [Tue, 8 Jan 2008 20:27:46 +0000 (22:27 +0200)]
Added good-single-subblock_implicit.lzma.
Lasse Collin [Tue, 8 Jan 2008 16:50:30 +0000 (18:50 +0200)]
Disable CRC32 from Block Headers when --check=none
has been specified.
Lasse Collin [Tue, 8 Jan 2008 11:36:29 +0000 (13:36 +0200)]
Fixed encoding of empty files. Arguments to is_size_valid()
were in wrong order in block_encoder.c.
Lasse Collin [Tue, 8 Jan 2008 11:35:36 +0000 (13:35 +0200)]
Added a few test files.
Lasse Collin [Tue, 8 Jan 2008 10:29:58 +0000 (12:29 +0200)]
Avoid using ! in test_files.sh, because that doesn't work
with some ancient /bin/sh versions.
Lasse Collin [Mon, 7 Jan 2008 22:48:30 +0000 (00:48 +0200)]
More pre-C99 inttypes.h compatibility fixes. Now the code
should work even if the system has no inttypes.h.
Lasse Collin [Mon, 7 Jan 2008 21:25:32 +0000 (23:25 +0200)]
Updated fi.po although it's currently pretty much crap.
Lasse Collin [Mon, 7 Jan 2008 21:14:25 +0000 (23:14 +0200)]
Test for $GCC = yes instead of if it is non-empty. This
way it is possible to use ac_cv_c_compiler_gnu=no to
force configure to think it is using non-GNU C compiler.
Lasse Collin [Mon, 7 Jan 2008 19:49:41 +0000 (21:49 +0200)]
Added test_files.sh to tests/Makefile.am so it gets
included in the tarball with "make dist".
Lasse Collin [Mon, 7 Jan 2008 16:22:24 +0000 (18:22 +0200)]
Cosmetic edit to test_files.sh.
Lasse Collin [Mon, 7 Jan 2008 16:09:44 +0000 (18:09 +0200)]
Added tests/files/README.
Lasse Collin [Mon, 7 Jan 2008 12:20:57 +0000 (14:20 +0200)]
Tell in COPYING that everything in tests/files is
public domain.
Lasse Collin [Mon, 7 Jan 2008 12:19:05 +0000 (14:19 +0200)]
Cleaned up the tests/files directory.
Lasse Collin [Mon, 7 Jan 2008 11:49:19 +0000 (13:49 +0200)]
Added test_files.sh to test decoding of the files in
the tests/files directory. It doesn't test the malicious
files yet.
Lasse Collin [Mon, 7 Jan 2008 09:23:13 +0000 (11:23 +0200)]
Updated README regarding the assembler optimizations.
Lasse Collin [Mon, 7 Jan 2008 08:58:00 +0000 (10:58 +0200)]
Updated THANKS.
Lasse Collin [Sun, 6 Jan 2008 19:47:17 +0000 (21:47 +0200)]
Cosmetic changes to configure.ac.
Lasse Collin [Sun, 6 Jan 2008 17:46:38 +0000 (19:46 +0200)]
Automatically disable assembler code on Darwin x86.
Darwin has different ABI than GNU+Linux and Solaris,
thus the assembler code doesn't assemble on Darwin.
Lasse Collin [Sun, 6 Jan 2008 17:45:27 +0000 (19:45 +0200)]
With printf(), use PRIu64 with a cast to uint64_t instead
of %zu, because some pre-C99 libc versions don't support %zu.
Lasse Collin [Sun, 6 Jan 2008 14:27:41 +0000 (16:27 +0200)]
Introduced compatibility with systems that have pre-C99
or no inttypes.h. This is useful when the compiler has
good enough support for C99, but libc headers don't.
Changed liblzma API so that sys/types.h and inttypes.h
have to be #included before #including lzma.h. On systems
that don't have C99 inttypes.h, it's the problem of the
applications to provide the required types and macros
before #including lzma.h.
If lzma.h defined the missing types and macros, it could
conflict with third-party applications whose configure
has detected that the types are missing and defined them
in config.h already. An alternative would have been
introducing lzma_uint32 and similar types, but that would
just be an extra pain on modern systems.
Lasse Collin [Sat, 5 Jan 2008 17:57:00 +0000 (19:57 +0200)]
Fix typo in comment (INT64_MAX -> UINT64_MAX).
Lasse Collin [Sat, 5 Jan 2008 17:42:04 +0000 (19:42 +0200)]
Rearranged testing of GCC-specific flags.
Lasse Collin [Fri, 4 Jan 2008 23:20:24 +0000 (01:20 +0200)]
Another bug fix for flush marker detection.
Lasse Collin [Fri, 4 Jan 2008 19:37:01 +0000 (21:37 +0200)]
Fix stupid bugs in flush marker detection.
Lasse Collin [Fri, 4 Jan 2008 19:30:33 +0000 (21:30 +0200)]
Added support for flush marker, which will be in files
that use LZMA_SYNC_FLUSH with encoder (not implemented
yet). This is a new feature in the raw LZMA format,
which isn't supported by old decoders. This shouldn't
be a problem in practice, since lzma_alone_encoder()
will not allow LZMA_SYNC_FLUSH, and thus not allow
creating files on decodable with old decoders.
Made lzma_decoder.c to require tab width of 4 characters
if one wants to fit the code in 80 columns. This makes
the code easier to read.
Lasse Collin [Fri, 4 Jan 2008 18:45:05 +0000 (20:45 +0200)]
Moved range decoder initialization (reading the first
five input bytes) from LZMA decoder to range decoder
header. Did the same for decoding of direct bits.
Lasse Collin [Fri, 14 Dec 2007 09:15:21 +0000 (11:15 +0200)]
Added a note to README that --disable-assembler
must be used on Darwin.
Lasse Collin [Fri, 14 Dec 2007 08:07:10 +0000 (10:07 +0200)]
Use the filename suffix .S instead of .s for assembler files
so that the preprocessor removes the /* */ style comments,
which are not supported by some non-GNU assemblers (Solaris)
that otherwise work with this code.
Lasse Collin [Fri, 14 Dec 2007 07:59:05 +0000 (09:59 +0200)]
Fixed wrong symbol name in crc64_x86.s.
Lasse Collin [Fri, 14 Dec 2007 07:53:24 +0000 (09:53 +0200)]
Use .globl instead of .global in x86 assembler code for
better portability. Still needs fixing the commenting.
Lasse Collin [Thu, 13 Dec 2007 18:14:37 +0000 (20:14 +0200)]
Fixed a few short options that take an argument.
short_opts[] was missing colons to indicate
required argument. Thanks to Fabio Pedretti for
the bug report.
Lasse Collin [Tue, 11 Dec 2007 15:08:04 +0000 (17:08 +0200)]
Removed uncompressed size tracking from Delta encoder too.
Lasse Collin [Tue, 11 Dec 2007 14:49:19 +0000 (16:49 +0200)]
Remove uncompressed size tracking from the filter encoders.
It's not strictly needed there, and just complicates the
code. LZ encoder never even had this feature.
The primary reason to have uncompressed size tracking in
filter encoders was validating that the application
doesn't give different amount of input that it had
promised. A side effect was to validate internal workings
of liblzma.
Uncompressed size tracking is still present in the Block
encoder. Maybe it should be added to LZMA_Alone and raw
encoders too. It's simpler to have one coder just to
validate the uncompressed size instead of having it
in every filter.
Lasse Collin [Tue, 11 Dec 2007 12:10:53 +0000 (14:10 +0200)]
Get rid of no-NLS gnulib. I don't know how to get it
working with Automake. People who want smaller lzmadec
should use --disable-nls on non-GNU systems.
Lasse Collin [Tue, 11 Dec 2007 12:09:35 +0000 (14:09 +0200)]
Fixed a typo in tests/Makefile.am which prevented
building the tests if gnulib was needed.
Lasse Collin [Tue, 11 Dec 2007 09:18:58 +0000 (11:18 +0200)]
Fixed wrong type of flags_size in Subblock encoder.
Lasse Collin [Mon, 10 Dec 2007 18:44:16 +0000 (20:44 +0200)]
Bumped version number to 4.42.3alpha.
Lasse Collin [Mon, 10 Dec 2007 13:02:50 +0000 (15:02 +0200)]
Disabled some unneeded warnings and made "make dist" work.
Lasse Collin [Sun, 9 Dec 2007 19:43:15 +0000 (21:43 +0200)]
Added LZMA_SYNC_FLUSH support to the Copy filter.
Lasse Collin [Sun, 9 Dec 2007 15:14:07 +0000 (17:14 +0200)]
Added missing LZMA_API to the C versions of the CRC functions.
The x86 assembler versions were already OK.
Jim Meyering [Sun, 9 Dec 2007 14:34:25 +0000 (15:34 +0100)]
* tests/test_block_header.c (test3): Remove duplicate initializer.
Lasse Collin [Sun, 9 Dec 2007 15:06:45 +0000 (17:06 +0200)]
Take advantage of return_if_error() macro in more places.
Cleaned Subblock filter's initialization code too.