Glib patch for Gnome-glib android build

Added boost dependency in the scons script.
The scons build script downloads the appropriate boost version for
android, unpacks and builds it.

This also builds C++ liboc library but not the examples.

Change-Id: I54d1a938e249a3e251d8508180c8cd103420d70f
Signed-off-by: jnashok <jn.ashok@samsung.com>
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update the use of clock_gettime(2)

clock_gettime(2) is a POSIX feature, but CLOCK_REALTIME_COARSE is a
Linux extension. So instead of using clock_gettime only on Linux, try to
use the POSIX macros instead. This way, we'll use clock_gettime on
systems that support it, falling back to gettimeofday if they don't.

POSIX.1-2008 requires clock_gettime(2) functionality, so up the
_POSIX_C_SOURCE macro requirement to the 2008 version. This will request
the 2008 API if it's available on some systems (QNX is known to not
enable all the API it has available). Older versions of POSIX don't
require the timer support.

Change-Id: I27eaacb532114dd188c4ffff13d3229d285d21cb
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/677
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Cleaning previous debug build before running Unit Tests to rebuild debug.

By doing this, it will cause a trigger to rebuild the appropriate modules
of the stack's logging. This will make it so that when the Unit
Tests are ran, that all logging will actually be off. Until now, the Unit
Tests were re-using the binaries from the last debug build without re-
triggering a rebuild to remove the logging symbols from the CA and RI
Layers. We need the Unit Tests to run with debug symbols to fully enable
the Valgrind pluging on the Jenkins CI System.

Change-Id: I117f583a18be0f8dd9c9f2c52b30b61ceb34ed70
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/687
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added token length to direct stack responses.

Token length is required because the stack at the client side looks at
the token field only if token length is non zero. Without the token,
client application will not receive responses.

Change-Id: If1f9e85473bd964651669640d2fe48c1821600d5
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/682
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Bug Fixed CA InterfaceController for TC-33

fixed some problem in TC-33 by transport option
when OIC base code is built with 'TARGET_TRANSPORT=WIFI'
now CA can return a suitable reason for the status
that Network has disabled

Change-Id: Iaf0142cad5db4b0ee287cbeec75add1431d2a754
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/685
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Merge Things Manager codes CA and Master branch.

It was modified base on CA for preparing for official merge.

Change-Id: If3cb90d9a1a03a8d79d95952f5dfabb07c526634
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/632
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Resolve potential buffer overflow warning

Compiler warning generated because the value of the size argument in
'strncat' is too large.

Also, IF check was not accounting for DELIMTER size, which
could cause overflow.

Change-Id: Iee3724bb08d8254f7a99f84ec1571eeeb5974d22
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/678
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Remove unnecessary, generated files that were committed

Those files should never have been in the repository in the first place. The
commit that introduced them (3e4087ca6843ea40863488458eed22b31df08983) should
not have been approved.

Change-Id: I27eaacb532114dd188c4ffff13d3233af112d867
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/679
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Enable compilation and functionality on darwin(osx)

Currently, the iotivity project does not support compiling/
running on Apple Darwin platforms.  This patch enables
compilation and minimal sample functionality for darwin.

It accomplishes this by adding 'darwin' as a valid
target_os in all build-scripts.  glib2 compiling/linking
is also added for the darwin build, which was previously
missing and blocking building connectivity-abstraction.

Many positions in the code had #ifdef __linux__, which has
been switched to also recognize __APPLE__.

Finally, the logger time-functionality used linux-specific
clock_gettime, so this functionality has been broken up
into an osalGetTime function, with an implementation for
__APPLE__ included in this patch.

Change-Id: Iddc2462db44198be90a975536e0273f63c521ab6
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/668
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update CA layer code for tinyDTLS location

Update CA layer code to pick tinyDTLS from iotivity/extlibs
location when compiling CA shared module.

Change-Id: I2e142453a43752073938cd56878597212ff606ae
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/671
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

fix problem by transport option when code is build and clean up.
Now, when code is build to 'transport type = WIFI'. some TC have error.
So, I changed TC 26, 28, 33.

Change-Id: I6ef9e9ea4d8718d3005585f162eeb3652af04f17
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/675
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Bug fixed for logging flag to scons build parameters.

Change-Id: Iae7d52afe44d915edcf887e6c1625b95e308512e
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/670
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Jira-IOT398] Fix for linux Scons build to not support BT/BLE build
Signed-off-by: jnashok <jn.ashok@samsung.com>
Change-Id: I754bce8832fd360983a0f732cde41240ea6ab4ad
Reviewed-on: https://gerrit.iotivity.org/gerrit/656
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated Doxyfile to match master so that all code comments added
on the CA branch will not have to be redone.

Getting the Doxygen config file to match that in master will
prevent extra work of fixing doc comments once CA is merged back.
Instead all comments added and/or edited in the CA branch will
start correct and not require fixes post-merge.

Change-Id: I5a66c37c1b88582b309f841c58a0acb33f52cec6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/647
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modified unittests readme to be upto date

Change-Id: I6982ec502ae391b5664e66d62e7fca1eed192f5f
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/588
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed [IOT-442] "CA unit test 17,20,23 are expecting to fail"

Currently CA unit test 17,20,23 are expecting to fail but are actually
invalid parameter error.

Change-Id: Iaa4447425eab245c02168bb4984f3d4186631377
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/674
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed linker order for Arduino libraries for Due and WiFi combination

Incorrect order of WiFi and SPI libraries was causing linker
to generate output binary which Arduino Due MCU was unable to load.

Change-Id: I3e5aa19d531ed8d754dad7d4fd53848a6a4d1f68
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/673
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sanjay Sharma <sanjay1.sharma@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed bug to send discovery request as Non-Confirmable request

Discovery requests needs to be send as Non-Con requests. Recent change
was failing some of the test cases supported by sample apps.

Change-Id: Ic6a701eaabdcf51cc388618c1afc07baefc3362f
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/651
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated DTLS usage as per discussion

As per discussion between Sachin and Ashok, following are updated:
1) CA API modified such that memory holding credentials is not
   shared between RI and CA i.e. For GetCredential() call, RI will
   allocate memory and CA will free it.
2) Since there was no consensus on "creds" member of
   "OCDtlsPskCredsBlob", as per discussion, CA has forked a separate
   structure i.e. CADtlsPskCredsBlob and samples modified to use it.
3) Duplicate ocsecurityconfig.h is updated as per the original version.
   This will be removed in a separate commit with other forked files.
4) RI layer is updated to remove SEC_CA_MERGE_WORKAROUND.

Change-Id: I174d82616985e0064e9a2fdccf08cbf8a43dfb7d
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/605
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix incorrect usages of OIC_LOG_V macro.

The OIC_LOG_V macro is intended to be used for variadic log messages.
This macro was used in many cases for non-variadic messages.  In these
cases, OIC_LOG_V was replaced with OIC_LOG.

Change-Id: I8a2c9319da495fc89d73146c3b57e67f64a60340
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Support HighQoS and Cancel Observe in CA and RI

Modified the timeout callback in CA to add tokens in responses.
Modified CA codes to used pdu codes that are according to stranded.
RI now send ACK and RESET pdus to support High QOS when
receiving requests, responses and to cancel observations. Added
support for slow resources.

Change-Id: If8cd175690fb51e0f4c125eda6d67f95a21dc3e3
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>
Signed-off-by: Vijay <vijay.s.kesavan@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/610
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

RESET/ACK code review update.

updating review comment changes Re factored PDU creation API
for better usage Changed debug to error logs
during critical conditions.

https://gerrit.iotivity.org/gerrit/#/c/303/
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Change-Id: I5d5b82ab7368fb7c30bf1055dda6331613240051
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/589
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Move unittest file to test folder to sync with existing folder structure

Change-Id: Id42c8139e86a1236b3524b6d07cb26392609a2cc
Signed-off-by: eunok.shin <eunok.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add stack logging flag to scons build parameters.

This will allow people to build debug versions of the stack without
actually enabling all the stack debug logs. This is useful (for instance)
when you may want to run unit tests in debug mode (ie. with no optimizat-
ion and full debug symbols), run without stack logging noise, and run
valgrind as the CI (ie. build) system does. The default values of when
logging will be enabled remain the same as before, except the default for
stack logging when building/running the unit tests is disabled. You may
change this by simply adding "LOGGING=1" or "LOGGING=true" to the list
of scons options, however.

Change-Id: I70cedc9143c6015fd75bf4725cf72b6a64b8529e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/657
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Linux sample application changes to test CA full function

Change-Id: I54d8410893d01dbb486422f1ffd4f68c7a24df46
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix outdated SCons build scripts that were broken for WiFi.

Corrected outdated SCons build script that was still referencing the
'NET' environment variable instead of the TARGET_TRANSPORT one that
the CA branch was switched to using.

Removed setup/documentation of the outdated 'NET' option.

Change-Id: I2f22921b290da65d77fccb237b09dd0b6302996d
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Mods per RI code review.

- Add doxygen comments
- Return OC_STACK_ERROR if observer notification fails
- Declared function that was only used in module as static

Change-Id: I129b88a21b228a1aceaa0ebd898cc25472bc46bb
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/627
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Addressing RI and CA integration code review.

Addressed the issues assigned to me in changeset 401 patch 2
Signed-off-by: Vijay Kesavan <vijay.s.kesavan@intel.com>
Change-Id: I4d7014d97e51bd85d61d25ac7693a917caede242
Signed-off-by: sanjaysh <sanjay1.sharma@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Adding autoconf generated files in tinydtls repo

tinydtls build system uses autotools while Iotivity uses
scons build system. Since tinydtls contains few source files
and header files, it seems  convenient for Iotivity to use
scons to build tinydtls library.
This patch is to add autoconf generated files so that tinydtls
can be build using scons script.

Note: Since this change is a custom change and specifically
for Iotivity, I do not intend to submit this patch for
upstreaming.

Change-Id: I4da593a8abccd731466a88d365dca536f608c94a
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/638
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Soft Sensor Manager - Apply changed C.A. API

Modify ResourceFinder to find resources and check presence status with connectivity type options

Change-Id: Ieeab82369f40c05ec0cae68f6395cd9a8e415cf7
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/633
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Remove unused header and CPP files

Remove unused OCSecurityModel.h and OCSecurityModel.cpp files

Change-Id: Ic1308e4edaedce609edecae7950d44136e78c17e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/646
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removed old_tests folder

The old_tests folder is not used.

Change-Id: I194ba0d7a11b38b682d62f3a95cd86406955f1fb
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/645
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add VERBOSE flag to scons

cleans up build noise so warnings errors can stand out more

Change-Id: Iad90dbfc8e92c02a9f65274bcba67e7bf01d7451
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/644
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed [IOT-396] "Sconscript not available in Iotivity repo"

Currently Sconscript alone has been added for tinydtls compilation.
Before compiling the code, Please add tinydtls source code in this folder.

Change-Id: Idd5f19f54dba5cc5cfb855658b08498ff5fda0d7
Signed-off-by: k.karthick <k.karthick@samsung.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/595
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix C client to receive presence notifications.

This fixes IOT-432.
Make occlient.cpp subscribe to the same resource ocserver.cpp is sending
out presence notifications on. Server sends out notifications for
core.led while client was subscribed to core.light.

Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Change-Id: I8aeb96b981f1bb71ce0661f1fa54d58ba1a19b8c
Reviewed-on: https://gerrit.iotivity.org/gerrit/626
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Jira] IOT 409 Fix for CAInitializeWiFi naming to be in consistent with other APIs

Change-Id: Ib2fac3df7084cffff8f7a31cc63c972aad0bb327
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/624
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modifications based on RI comments.

- Add doxygen function comments
- Declared functions that were only used in module as static

Change-Id: Ib183811a163b084a303793479f66465f9ca3f1f5
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/636
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix for Arduino WiFi shield fragmentation issue.

Added fix for Arduino WiFi shield fragmentation issue.
It was dropping outgoing packets that are more than 90 bytes.

Change-Id: I8d9f4a02268346b145ff8599232132414bc86123
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/594
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Unify caprotocolmessage to fix bugs in different versions.

Unified the caprotocolmessage sources to a single version that
brings together bug fixes that had gone individually into either
one copy or the other, but not both.

Will also allow testing of the arduino-centric code under Linux
builds.

Follow-up to https://gerrit.iotivity.org/gerrit/#/c/470/

Fixes IoT-400

Change-Id: I47b726c940ef1dd45a26cf160b92e1cbbd7f5f2e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Enabled the build script to build for Arduino Due as well.

This enables the build server and endusers/developers to verify builds
for the Arduino Due as well.

Change-Id: I08ca0893b16d8cfcf133e8554379eeb69e489515
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/614
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Allow upload to an Arduino Due device from root of repo scons build.

Support to upload to an Arduino Due device was only added to the internal
CA Layer scons build. This commit mitigates this issue.

Change-Id: I7ffe3d38976b9de12fa987235d0ed1fe5305b6aa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/615
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changed flag from "-std=c99" to "-std=gnu99" to enable arduino due builds.

This will allow the stack to use asm.

Change-Id: I7565381ea7cc7abf5b71539eb57c0570ae7fced7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/616
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Support for Arduino Due in CA Layer

1) Sconscript is modifed for Due support.
2) A separate patch(arduino_due_ble.patch) is provided for BLE support.

Change-Id: Ide9894f64a307f1b6c17c19f1009150803458e16
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/590
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Wrapping auto-ran unit tests with valgrind.

Along with Jenkins' valgrind publisher plugin, the build server will now
be keeping track of memory leaks that are/can be tracked by the unit
tests.

Change-Id: Ic5f20ef07faa57e4689fa334b628fcd3e44b0f1e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/621
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removed Token ASCII-char limit and length limit

Currently, the stack has a fixed-size for Tokens (CAToken_t)
which is null terminated and limited to the ASCII character
set.  The OIC specification requires that tokens be variable
length up to 8 bytes, not be null terminated, and be the
full binary set.

This change removes the null termination behavior (bad,
since it is binary data, where the NUL is a valid value),
provides for a variable length token, and removes the previous
limit that held us to the printable ASCII character set.

This issue was captured in IOT-380 in JIRA.

Change-Id: I2159dd3202edeff4025c7e1d0de50360b6521e53
Signed-off-by: jnashok <jn.ashok@samsung.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/598
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Added interruption of select() to linux IP reading to allow for proper
stopping.

Added standard mechanism to cleanly interrupt select() calls in linux
network code so that stack shutdown is now immediate.

Among other things this allows for a longer timeout to be used in
select() calls which reduces log spam and increases performance.

Another effect is to clean up unit test performance with a main dev box
gaining more than two orders of magnitude in performance. Stack unit
tests were taking 39 seconds to complete whereas with this change they
complete in less than 1/3rd of a second (1/10th for release builds).

Change-Id: I330b1d7507ab81c5b54677d1ef21434862f63508
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/635
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Adding base timestamps to linux log output.

This updates logging output on linux to have basic timestamps prepended.

It includes additions of link flag adjustments needed for gcc 4.6.

This currently uses coarse timers to allow for faster response. The
timer type could be switched to normal if testing something more
precise. On some systems tested the resolution was 4ms.

Change-Id: Ief75680bfd17178e4c035ef6a69db00b8c7de73e
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/622
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added function pointer validation to InProcClientWrapper

InProcClientWrapper permitted calls with an invalid function
object being sent. This ensures that the parameter is correctly
validated.

Change-Id: If38af50fd6fb3ab2006c0c5cb53dd9af0c42a57b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/620
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Modifications per RI code review.

- Add function missing headers
- Changed return type to bool where appropriate
- Declared functions that were only used in module as static

Change-Id: I6c4eb32714a5582b6237aa6ab624652c64929fb5
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/617
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Adding simple internal developer documentation with examples of
integration of graphviz diagrams in doxygen for automatic cross-linking.

Change-Id: Ifcd1869f06c1025cd9192b74f02365280bc929bc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/602
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix unobservable resource being observed.

Fix of IOT-343.
Add test to check if resource is observable.
Added comments to make code in ocserverrequest.c

Change-Id: Ie5bb98e7f8bece3f7b8ab9e50998156f7328892c
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/441
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Check valid function pointer before calling.

This  fixes IOT - 431.
Check if function pointer to context deleter is valid before calling function.

Change-Id: Ie66a79b14153b3cd09b6fb478307bc5f3d17afcd
Signed-off-by: Mandeep Shetty: <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/609
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed few klockwork issues.

Pointers not being checked before being dereferenced.
Return values of functions being ignored leading to possible dereference
of NULL pointers.

Change-Id: Iaa5507ff6c6e1b310fdba83d0c4e21a884794653
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/518
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Clean up extra characters in logs, validate params.

Validate function parameters. Fixed some style.
Added bounded string function in ocserverrequest::HandleSingleResponse

Change-Id: I7cbda0c88d2a16265e35e8b4ba24f874bc0285c1
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix unit test lockup on the build server

Add timeout for a unit test if it takes forever to complete it.

Change-Id: If562cf69db0cc81f20932a99110c28704cbd7129
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/536
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added comments for a macro.

- This changeset addresses one of the comment from full RI-CA review.

Change-Id: I62b1ffb53104dcc57e8a04e067cafcc34e6bc655
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/550
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Klockwork fixes on C samples

Send MAX_HEADER_OPTION_DATA_LENGTH as buffer size to avoid array bounds
violation by potentially sending a larger size contained in the
optionLength field in received headers.

Change-Id: If9f6ea0688298a2ba7723db67f5082509fad1d5f
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/493
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added OCHeaderOption unit tests

Adding a bunch of unit tests to completely validate the functionality
of OCHeaderOption

Change-Id: I53efd7e92b03a371f4a302e743128572195f1c29
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/586
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Adding OCException unit tests

Adding a bunch of unit tests to validate the functionality of
OCException.

Also removed the unused 'reason' function that didn't use 'this'

Change-Id: I34bac1c06b2bc755a0af19e3ddcc1ac9ae3611fc
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/584
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed Presence Resource Filter crash

The AddClientCB method would delete the resourceTypeName
before it got a chance to insert it due to the logic designed
to make the free'ing consistent.  This fix moves the free until
afterwards.  Note that the insert method does NOT makes a copy,
so it is the responsibility of this method to free in the event
that the pointer is not captured.

Change-Id: I9c0c66cfbfb9e8d1ace5df9de372476fbf262659
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/582
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Updated tinyDTLS test apps to use identity hint

dtls-server test is updated to pass 'psk hint' to tinyDTLS library so that
it can send ServerKeyExchange packet. Similarly, dtls-client test
is updated to retrieve PSK specific for the server whose identity was
received via 'psk hint' packet.

Change-Id: Ifba720f1505ed6afbf56dfc179d98790176ce0b0
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/348
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Seung-Woo Lee <sw0524.lee@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit f5fb7aae180aa04babd2fc1364365b8ae1452efd)
Reviewed-on: https://gerrit.iotivity.org/gerrit/433
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit a8c761f0b18ecdfe1b4d4fa5d15ccdc2700d8bcc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/597

Update C++ Unit test for OCResource

Add unit test for missing OCResource API.

Change-Id: I8434a5410a774a9b95863ab3f6a19844a4a4007b
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix return type to enable callback.

UpdateResponseAddr() did not set success as result which caused the
stack to return quietly.
Set response type to OC_STACK_OK so stack can do the callback.

Change-Id: I3958c51f08735d2e7bf30bcefdfbb99255ea69bf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/587
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update C++ OCPlatform Unit test

Add unit test for external OCPlatform APIs

Change-Id: I0c17134429f99b9a6d28a79b248c92b2ad84b989
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix possible buffer overflows & array out of bound

Init char buffer to null so we don't have to keep adding null
characters.
Fixed potential array out of bounds issue in
occollection::HandleBatchInterface()

Change-Id: Ief43e5196fe360e0035f8aff49b15d969fb92b5e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/568
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Explicitly specify OCResourceIdentifier assignments/ctors

The OCResourceIdentifier proxy class depends on compiler rules
to determine validity of constructors and assignments.  This patch
correctly explicitly specifies these values.

Note: This patch does NOT change any behavior or functionality, it
solely specifies behavior explicitly rather than implicitly.

Change-Id: I5110cb10e07112e7786c56fedee43f76cfdab3bd
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/572
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added check to not add duplicate resourcetype.

Do not add already existing resourcetype and or resource interface to linked list.
Also fixed incorrect logic in insertResourceType().

Change-Id: I43195e8f9d0d6c71274fd7321baf3a02268e2cf2
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/574
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed memory handling of HandleSingleResponse

As identified in the RI code review, the options and token
were leaked and had some interesting behavior if the options count
was zero.  This patch corrects those, and repairs some return
values that were inconsistent and detected while chaising the
memory around.

Change-Id: Ica590fefc8702faa7108cc00642cbc2424f402ac
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/564
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>

Code portability cleanup.

Added required #includes and #defines to allow the code to be compiled without
errors in more situations.

Fixed platform and compiler assumptions that would prevent the code from
compiling successfully under different compilers and platforms. This helps
with building with different compilers or even later versions of current ones.

Added comments documenting resons for the #defines and portability info.

Change-Id: Ia4a943af1d2d06509e46669f952b5e7ca80efaf4
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/532
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed a number of KW Memory leaks in ocstack.c

Klocwork discovered a number of memory leaks.  This fix repairs most
of them.  A few are left behind due to Mandeep's commit in 518,
and Sachin's intent to look into the tok issues.

Change-Id: I92f5902e22dfbaa59e6b7d24985cfa489c93348b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/520
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Adding unit test for connectivity-abstraction work.

Simple addition of unit test for adding cases related to the
connectivity-abstraction work. Utilized in subsequent commits.

Change-Id: Iee4d688ff78bcb358a4d403e32b81f5fdc3bd060
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/474
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Fixed Arduino config setup when 'ALL' is selected as a transport.

Arduino scons config was only structured to handle one transport as a time,
and would fail to configure needed lib imports when 'ALL' was the selected
transport.

This change removes the choice of 'ALL' when Arduino is the selected OS. It
also will log an error and stop the build when more than a single transport
is selected for Arduino builds. This is mainly until resources permit
testing of the code on hardware configurations with multiple transport
shields attached.

Change-Id: I9da97df1db696904581eaccbbbc519b291b0b3ed
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Addressed magic strings, incorrect logging

- This changeset is put up to address comments from  the full
code review of RI-CA integration

Change-Id: If89b482b3d13584529a399b761ef8d8d0a36caa7
Signed-Off-By: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/551
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed memory leak from Observer

The observer delete mechanism was not properly deleting the token
that was created for it in the AddObserver method and was identified
in the RI code review in ocstack.c line 2109.

Change-Id: I56ba9c89a1890e28c79efb2d76b0783c037cd6e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/567
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Defined OC_MULTICAST_PORT instead of using const 5683

Change-Id: I6b73a795f02d244d9e0b417a2b7b2f3aa7fc91a3
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/553
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removed a single instance of the usage of a "magic number" in the stack.

After walking through the logic in ValidateQuery() its clear that there
was an intention add a second #define, but this must have been over-
looked at that time. There a single #define to avoid usage of a
"magic number" (or a raw value, ie. "2") but it was actually being used
in the wrong spot in the code.

Change-Id: I2ff045005ccacc9822280d93e6b20bfac8df1cbd
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/539
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Cleaned up some static initialization and casting errors in one function.

Cleaned up function to ensure that different scopes within the stack don't
act negatively on eachother by malloc'ing space for each caller to
obtain their own copy of the address.

Change-Id: I7ebdfde0fb6edbbe57f0d52b541fc252e7509b17
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/541
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Implemented OCRepresentation::setChildren

As reported in IOT 410, setChildren had a header entry, and
no implementation. This patch implements setChildren

Change-Id: I0f881dab27c09d72fd068c0b2d446bbfcc77a42b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/561
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Clean up OCStop in C stack

Cleanup OCStop method in the C stack. Remove unnecessary
error check.

Change-Id: I4a1618c684c685a32f70b3087f08fca0961d3461
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/545
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Address RI Code review comments

Remove duplicate code to convert qualityOfService to
CAMessageType.

Change-Id: Icfc7365587cd4306d619544acfa9e6e70bea5d8e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/537
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed KW Warnings based on using uninitialized values

The values adjusted here were improperly initialized, so these
fixes ensure that they are only used when properly initialized.

Note that in the second case, we were checking for NULL, but
dereferencing anyway.  This adds an else case to avoid that.

Change-Id: I34cb292267f6ba21d3849fa5ad06b89eca02b557
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed memory issues related to AddClientCB

AddClientCB had a weak memory-guarantee that caused 3 values to be
leaked in certain conditions.  This will prevent those from happening.

The result-setting is done in order to ensure that the values are always
properly free'd.

Change-Id: I027fab84ddf62526d51a6e7e35dd54a96acbb48d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/502
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed build warnings in stack

OCException's string handling was missing a few items.

ocstack used some creative casting to get a 16 bit value out
of an 8 bit array that could likely result in bad-optimizations
or undefined behavior.

Removed an unused variable.

Change-Id: I9af5d22f450f72d15b793cec57630e8c81f7b5de
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/496
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

isListOfObservers replaced with ObserveType in simpleserverHQ.cp

Signed-off-by: Sanjay Sharma<sanjay1.sharma@intel.com>
Change-Id: I733fd8e7e051ebf747dac58259df31c45546889e
Reviewed-on: https://gerrit.iotivity.org/gerrit/547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Cleaned up some misdirection when copying a string's value.

A weird case occurred where a char* string was referencing array location
'0', then was being pass-by reference to appear as a "char*" which simply
returned the origin char* string.

Change-Id: I014207a4050d69cf5b8e2360f6c8d9d82a6c628e
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/542
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added const keyword to several function parameters.

This file was considered in need of re-examination with regards to making
parameters const "where necessary" during the RI Code Review process (be-
fore merging the connectivity-abstraction and master branch).

Change-Id: I12db60e5404a0a5ce7811d53efc637815160a012
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/540
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed presence payload parsing logic (IOT-406)

Updated method parsePresencePayload to handle scenarios
when payload is not in the expected presence format.
Also added unit test to verify parsing functionality.

Change-Id: I47d995b8f49cc96805bf837ac2c2f77c1859da82
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/538
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Update scons build readme and howto document

Change-Id: I3a9e7dd82ad98f969449da42acadfad2e0eb4705
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/432
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit f7c465f6d306179b4244591cfe0be73a14feb047)
Reviewed-on: https://gerrit.iotivity.org/gerrit/472
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add missing c flag.

Adding missing c99 flag to arduino scons files to match other builds.

Change-Id: I118374979c448981ae2a7ca59648a1d30ca33f5b
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Enable build process for Arduino Mega on CA Branch for the CI System.

I believe this was previously mistakenly disabled. By re-enabling this,
we can ensure that all new commits to the CA Branch are validated
correctly.

Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Change-Id: Icc882206bc3e2b8dc8dd5955bfa518e361f95b2b
Reviewed-on: https://gerrit.iotivity.org/gerrit/527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Enable ability to build for Arduino with debug enabled.

The changes in this commit were required because for some reason the
function to log out a buffer's value was fully commented out for
the Arduino platform, while calls for it still existed for the Arduino
platform when running in debug mode.

Change-Id: Ia84761503627b05856819cca672f72ff7f897582
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Disable default to auto install to Arduino device after build.

By defaulting auto-upload to false, this will allow developers to build
for the Arduino platform and remove any need to actually have an Arduino
device plugged in to their machine to see a successful build output from
Scons.

Change-Id: I804bb8cc03f38bf4d79206905bcf4bdf23ee7bb9
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/530
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed RI-CA review integration changes

Updated files for some issues identified in Gerrit Patch 401.

Change-Id: I5b6bfb60e10d9ae4af358e03aaf8c5a4d8854911
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/486
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update C++ unit test

Integrate OCRepresentation tests to C++ unit test.

Change-Id: I65a3bd0066d084fb51a062005e8da39a6e9e5bdc
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/503
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fix potential memcpy buffer overruns.

Change-Id: Ia43054f29a3f3b3ac8118848847a06046822615e
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/516
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed CA logging issues.

- Fixed incorrect use of DEBUG label for logging error conditions.
Mod done as part of fixing unresolved CA issues.

- Fixed incorrect use of OIC_LOG_V in connectivity/src and
for single thread files that might affect Arduino stack size.
This issue was not listed in CA review.

Change-Id: I38cc2310bf3a7c91d0dd8b457a237c7f930e6646
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fix OCInit review comments identified in CA-RI Integration Review

Updated OCInit to correctly handle all error situations and also
improved logging in case of failures.

Change-Id: I946255883a26b4afe96ee9d2b00ba775f7250fb1
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Do not try to build OICMiddle examples on arduino.

When the target OS is arduino, avoid attempting to build the OICMiddle
example since it is C++ and not supported for that platform.

Change-Id: I054ab220214c707954f4bf3cf17b6667ee9a82a6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Made changes required to get the RI layer to build properly for Arduino.

Changes made in the RI Code Review(49ead758a03c532e7c95f5b6eb88c1d979cd36a0)
introduced build warnings on Linux. Due to the use of an older and more
verbose compiler when building for Arduino, these warnings are errors in the
build process for Arduino. This commit enables Arduino compilation by fixing
those errors.

Change-Id: I36643b4769a65badad5fc69b6fc18dbce18e22fa
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removed potential buffer overflow.

Malloc based on strlen() did not acount for the null character.

Change-Id: Iff9fed3e684e26576d24d9607ebd5afefec32ef0
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/504
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>