Mathieu Duponchelle [Fri, 24 Oct 2014 12:23:52 +0000 (14:23 +0200)]
validate-launcher: pep8ify sources.
https://bugzilla.gnome.org/show_bug.cgi?id=739208
Mathieu Duponchelle [Thu, 23 Oct 2014 19:43:45 +0000 (21:43 +0200)]
validate-utils: downgrade ERROR to DEBUG.
This function is called in places where it is legit for it
to return NULL.
Mathieu Duponchelle [Thu, 23 Oct 2014 19:36:03 +0000 (21:36 +0200)]
launcher: add a way to specify an application directory.
https://bugzilla.gnome.org/show_bug.cgi?id=739091
Mathieu Duponchelle [Thu, 23 Oct 2014 19:34:27 +0000 (21:34 +0200)]
launcher: Don't implement product-specific TestManagers.
This manager will be moved in GES.
https://bugzilla.gnome.org/show_bug.cgi?id=739091
Mathieu Duponchelle [Thu, 23 Oct 2014 13:21:14 +0000 (15:21 +0200)]
validate-launcher: restructure filesystem
https://bugzilla.gnome.org/show_bug.cgi?id=739091
Ramprakash Jelari [Fri, 24 Oct 2014 13:11:30 +0000 (18:41 +0530)]
validate: Fix compiler warning about implicit enum type conversion
gst-validate-reporter.c:119:39: error: implicit conversion from enumeration type
'GstValidateReportingDetails' to different enumeration type
'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
GstValidateInterceptionReturn ret = GST_VALIDATE_SHOW_UNKNOWN;
~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:124:11: error: implicit conversion from enumeration type
'GstValidateReportingDetails' to different enumeration type
'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
ret = iface->get_reporting_level (reporter);
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:127:10: error: implicit conversion from enumeration type
'GstValidateInterceptionReturn' to different enumeration type
'GstValidateReportingDetails' [-Werror,-Wenum-conversion]
return ret;
~~~~~~ ^~~
Mathieu Duponchelle [Wed, 22 Oct 2014 12:16:45 +0000 (14:16 +0200)]
build: We install all headers system wide for now.
Will be fixed when the API is deemed stable enough
Mathieu Duponchelle [Tue, 21 Oct 2014 21:31:37 +0000 (23:31 +0200)]
validate: rename GstValidateReportingLevel.
Removes the confusion with GstValidateReportLevel.
Modeled on GstDebugGraphDetails.
Thibault Saunier [Sat, 18 Oct 2014 16:55:59 +0000 (18:55 +0200)]
validate: Verify that elements always send a segment before pushing EOS
EOS is some kind of data flow and thus a segment event should always be
pushed before the EOS is sent
Thibault Saunier [Sat, 18 Oct 2014 16:53:03 +0000 (18:53 +0200)]
validate: Properly check that the seqnum of the EOS is always properly set
In the pipeline, an EOS should always have the same seqnum of the
previous SEGMENT event that was received. If the segment is the result
of a seek, it should always be the same as the seek seqnum too.
+ (Mathieu Duponchelle): fix reporting and concatenation tests.
Thibault Saunier [Fri, 3 Oct 2014 16:51:17 +0000 (18:51 +0200)]
validate: Add support for text based override files
Allowing user to easily determine the severity of issue
types in a config file
https://bugzilla.gnome.org/show_bug.cgi?id=737852
Thibault Saunier [Fri, 3 Oct 2014 16:53:42 +0000 (18:53 +0200)]
validate: Remove unused method
gst_media_descriptor_add_frame is not used anywhere
https://bugzilla.gnome.org/show_bug.cgi?id=737852
Thibault Saunier [Fri, 3 Oct 2014 16:42:04 +0000 (18:42 +0200)]
validate: Move GstStructure file parsing into utils
So it can be reused, at least in GstValidate.
Thibault Saunier [Thu, 2 Oct 2014 13:34:28 +0000 (15:34 +0200)]
validate: report: Simplify the issue ID registering using GQuarks
+ Remove unused issue types
https://bugzilla.gnome.org/show_bug.cgi?id=737790
Thibault Saunier [Mon, 15 Sep 2014 15:27:54 +0000 (17:27 +0200)]
validate: Check all buffers when we have the info from MediaDescriptor
We now check that each buffer is the expected one for each buffer that
come into the decoder.
+ Fix some minor leaks in test-utils
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Thu, 2 Oct 2014 09:27:30 +0000 (11:27 +0200)]
validate:media-descriptor-parser: Add a way to create from a string
So it is simple to make use of it from the testsuite
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Wed, 1 Oct 2014 14:24:58 +0000 (16:24 +0200)]
report: g_critical are CRITICAL issues!
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Wed, 17 Sep 2014 15:32:52 +0000 (17:32 +0200)]
validate: launcher: Fix printing of errors in final report
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Mon, 15 Sep 2014 17:14:27 +0000 (19:14 +0200)]
validate: Add the possibility to generate media infos with frame descs
+ Fix a little issue when the generation fails.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Mon, 15 Sep 2014 15:26:23 +0000 (17:26 +0200)]
validate: MediaDescriptors: Add md5sum to buffer informations
In the media descriptor files, we now have the md5sum of the actual
content of encoded buffers so that we can check that the buffer content is
perfectly what is was supposed to be.
+ Fix the check of whether a frame is a keyframe in the string
comparison (g_ascii_strcasecmp return 0 if string matches)
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Mon, 15 Sep 2014 15:25:14 +0000 (17:25 +0200)]
validate: Move some method between GstMediaDescriptorParser and GstMediaDescriptor
So that method land where they actually belong.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Mon, 15 Sep 2014 15:22:52 +0000 (17:22 +0200)]
validate: Add a way to pass a MediaDescriptor around monitors
And add an option in gst-validate so that the user can define what
media descriptor file to use.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
Thibault Saunier [Fri, 12 Sep 2014 10:12:14 +0000 (12:12 +0200)]
validate:media-descriptor: Handle stream with no tags
It was segfaulting before.
Thibault Saunier [Wed, 17 Sep 2014 14:51:20 +0000 (16:51 +0200)]
validate: Add more files to gitignore
Thibault Saunier [Mon, 15 Sep 2014 15:25:14 +0000 (17:25 +0200)]
validate: Move some method between GstMediaDescriptorParser and GstMediaDescriptor
So that method land where they actually belong.
Mathieu Duponchelle [Sun, 12 Oct 2014 14:25:25 +0000 (16:25 +0200)]
validate-report / reporter: rework the way we repeat issues.
+ runner: update reports count algorithm.
Mathieu Duponchelle [Sun, 12 Oct 2014 14:13:51 +0000 (16:13 +0200)]
pad-monitor: mark the peer pad as EOS too.
When a sink pad gets EOS, its src pad monitor should also
be marked as EOS (helpful with issue concatenation).
Mathieu Duponchelle [Fri, 10 Oct 2014 08:22:31 +0000 (10:22 +0200)]
validate-pad-monitor / runner: Check per-object reporting levels.
Mathieu Duponchelle [Sun, 12 Oct 2014 12:36:13 +0000 (14:36 +0200)]
validate-report: Set conditions in which a report can't be
Mathieu Duponchelle [Sun, 12 Oct 2014 12:34:34 +0000 (14:34 +0200)]
validate-report: Add a reporting level field and setter.
Mathieu Duponchelle [Tue, 21 Oct 2014 17:43:45 +0000 (19:43 +0200)]
validate-runner: implement synthetic report.
+ Fix criticals logic in validate_runner_printf
+ Update padmonitor tests
+ Split validate_report_printf function.
Mathieu Duponchelle [Fri, 10 Oct 2014 04:01:03 +0000 (06:01 +0200)]
validate-runner: Implement REPORT_NONE for global reporting.
Yeah that was tough. Helpful already though, for example:
GST_VALIDATE_REPORT_LEVEL=none,x:all gst-validate src name=x ! sink
will only report issues reported by the source.
+ Add test.
Mathieu Duponchelle [Fri, 10 Oct 2014 03:08:28 +0000 (05:08 +0200)]
tests: Check monitors correctly determine their reporting level.
+ [API] gst_validate_reporter_get_reporting_level
Mathieu Duponchelle [Fri, 10 Oct 2014 01:55:37 +0000 (03:55 +0200)]
validate-runner / monitor: Let the user single out pads.
That's some pretty specific code but it should be helpful.
The following syntax can be used : element-name::pad-name.
+ Free return of gst_object_get_name.
Mathieu Duponchelle [Fri, 10 Oct 2014 00:52:26 +0000 (02:52 +0200)]
validate-runner / reporter: Sanitize reports refcounting.
The previous code worked but was confusing, the runner didn't actually
take the ref it was releasing later.
+ Fix indentation.
Mathieu Duponchelle [Fri, 10 Oct 2014 00:49:54 +0000 (02:49 +0200)]
tests: Test reports refcounts.
+ Set the element monitor on the element as qdata.
Mathieu Duponchelle [Thu, 9 Oct 2014 23:17:43 +0000 (01:17 +0200)]
validate-monitor: Determine the reporting level at setup.
Mathieu Duponchelle [Thu, 9 Oct 2014 17:41:48 +0000 (19:41 +0200)]
validate-runner: Add code to parse GST_VALIDATE_REPORT_LEVEL.
+ Extend the tests.
+ [API] gst_validate_runner_get_default_reporting_level
+ [API] gst_validate_runner_get_reporting_level_for_name
Mathieu Duponchelle [Wed, 8 Oct 2014 03:08:21 +0000 (05:08 +0200)]
validate-runner: report-level initial work.
+ Defines reporting levels and document them.
+ Add API to get the default level.
+ fix indentation.
+ fix some typos.
+ Add the beginning of a reporting test.
Mathieu Duponchelle [Thu, 2 Oct 2014 00:50:29 +0000 (02:50 +0200)]
validate-pad-monitor: concatenate issues.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=735665
The process is to check for a similar report in intercept_report on
the pads of the upstream element, set that report as the master report
of the intercepted report, and return REPORTER_KEEP instead
of REPORTER_REPORT.
Mathieu Duponchelle [Thu, 2 Oct 2014 00:34:26 +0000 (02:34 +0200)]
test-utils: add a create_and_monitor element function.
Mathieu Duponchelle [Wed, 1 Oct 2014 16:28:33 +0000 (18:28 +0200)]
validate-reporter: Add some methods
+ gst_validate_reporter_get_reports
+ gst_validate_reporter_get_reports_count
Mathieu Duponchelle [Wed, 1 Oct 2014 13:53:24 +0000 (15:53 +0200)]
validate-report: Add the notion of master / shadow reports.
A master report is a report that has been detected by a monitor
to stem from the same issue. It thus contains a list of
"shadow reports" which it will browse when printing itself.
Mathieu Duponchelle [Wed, 1 Oct 2014 13:50:11 +0000 (15:50 +0200)]
validate-report: Make the ref / unref functions safer.
Mathieu Duponchelle [Tue, 21 Oct 2014 11:07:02 +0000 (13:07 +0200)]
tests/padmonitor: Correcly strdup the result of get_metadata.
The const pointer was becoming invalid after the first call to add_metadata,
and we ended up setting corrupted data on the second call.
Mathieu Duponchelle [Wed, 1 Oct 2014 13:11:21 +0000 (15:11 +0200)]
validate-reporter: Add return value to intercept_report.
It will allow to drop, keep or report reports.
Mathieu Duponchelle [Tue, 30 Sep 2014 14:08:46 +0000 (16:08 +0200)]
validate-pad-monitor: Reimplement reporter interface.
+ Do nothing there for now, except chain up.
Mathieu Duponchelle [Tue, 30 Sep 2014 12:52:35 +0000 (14:52 +0200)]
validate-reporter: add gst_validate_reporter_get_report.
+ Add locking.
Thibault Saunier [Mon, 20 Oct 2014 11:38:20 +0000 (13:38 +0200)]
Back to development
Thibault Saunier [Mon, 20 Oct 2014 10:04:25 +0000 (12:04 +0200)]
Release 1.4.0
Thibault Saunier [Mon, 13 Oct 2014 14:28:54 +0000 (16:28 +0200)]
validate: Print position if it could properly be queried
Otherwize we will print meaningless garbage.
Thibault Saunier [Mon, 13 Oct 2014 08:32:07 +0000 (10:32 +0200)]
validate:launcher: Minor enhancement in the documentation
Thibault Saunier [Sun, 12 Oct 2014 18:19:42 +0000 (20:19 +0200)]
validate: Rename action type playback_time to playback-time
Keeping backward compatiblity with the old naming
Thibault Saunier [Sun, 12 Oct 2014 18:07:58 +0000 (20:07 +0200)]
validate: Rename gst_validate_add_action_type to gst_validate_register_action_type
The _register naming corresponds much better to what the method does
and makes it more similar to how we refer to this kind of action in
GStreamer.
It is a last minute API change, but that API should not change anymore
after 1.4 is released.
Thibault Saunier [Sun, 12 Oct 2014 18:00:03 +0000 (20:00 +0200)]
validate: Fix the addition of playback_time in the parameter types
Thibault Saunier [Sun, 12 Oct 2014 17:46:39 +0000 (19:46 +0200)]
validate: Rename --list-action-types to --inspect-action-type
Making clearer the meaning of the parameter and closer to the
usual naming in the GStreamer land.
Thibault Saunier [Sun, 12 Oct 2014 17:16:08 +0000 (19:16 +0200)]
validate: Add the 'flags' for the seek action type
This was always a mandatory field but was not documented
Anuj Jaiswal [Mon, 29 Sep 2014 04:52:55 +0000 (10:22 +0530)]
validate: mishandled pointer criticals
Free glist of criticals
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736313
Thibault Saunier [Wed, 1 Oct 2014 08:54:47 +0000 (10:54 +0200)]
validate:docs: Add documentation about the default testsuite
Mathieu Duponchelle [Tue, 30 Sep 2014 08:30:24 +0000 (10:30 +0200)]
validate-runner: switch to using a GList for the reports.
+ Return a copy of that list in get_reports.
+ update tests.
Mathieu Duponchelle [Tue, 30 Sep 2014 07:24:48 +0000 (09:24 +0200)]
validate-runner: Hide implementation.
Mathieu Duponchelle [Tue, 30 Sep 2014 07:11:58 +0000 (09:11 +0200)]
gst-validate-runner: Add locking for the reports list.
Thibault Saunier [Mon, 29 Sep 2014 13:37:40 +0000 (15:37 +0200)]
Release 1.3.90
Thibault Saunier [Fri, 12 Sep 2014 08:47:18 +0000 (10:47 +0200)]
validate:launcher: Factorize code to get a MediaDescriptor name for classname
Instead of copy/pasting that code badly
Edward Hervey [Fri, 12 Sep 2014 08:22:15 +0000 (10:22 +0200)]
validate/docs: Add location of Scenario/Action defines
Anuj Jaiswal [Wed, 10 Sep 2014 11:15:41 +0000 (16:45 +0530)]
validate: (performance issue)refactor to remove duplicate assignment
Signed-off-by: Anuj Jaiswal <anuj.jaiswal@samsung.com>
https://bugzilla.gnome.org/show_bug.cgi?id=736412
Thibault Saunier [Thu, 11 Sep 2014 08:54:43 +0000 (10:54 +0200)]
validate: docs: Always dist the launcher directoty
Fixing make distcheck
Thibault Saunier [Thu, 11 Sep 2014 07:42:02 +0000 (09:42 +0200)]
validate: Get the Runner reports in order of arrival
Making sure they are printed in the right order
Thibault Saunier [Wed, 10 Sep 2014 07:47:22 +0000 (09:47 +0200)]
validate: Start a testsuite
Currently implemented tests are:
* Settup and cleanup on monitor is done properly
* Some tests in the PadMonitor are done properly, namely:
- Buffer before segment
- Buffer outside segment
- First buffer running time is always 0
- The Demuxer flow aggregation is properly checked
https://bugzilla.gnome.org/show_bug.cgi?id=736379
Edward Hervey [Fri, 12 Sep 2014 07:49:35 +0000 (09:49 +0200)]
validate/private: Avoid double typdef
Instead just include required (public and local) header
gst-validate-scenario.h:43:44: error: redefinition of typedef 'GstValidateActionParameter' is a C11 feature [-Werror,-Wtypedef-redefinition]
René Stadler [Wed, 26 Sep 2012 00:28:00 +0000 (02:28 +0200)]
timeline: disable tooltip while scrolling
René Stadler [Wed, 26 Sep 2012 00:00:10 +0000 (02:00 +0200)]
Hide some columns by default
René Stadler [Tue, 25 Sep 2012 23:56:05 +0000 (01:56 +0200)]
columns: optimize cell data functions a little
René Stadler [Tue, 25 Sep 2012 23:41:22 +0000 (01:41 +0200)]
Fix crash when copying row to clipboard
René Stadler [Mon, 24 Sep 2012 20:58:58 +0000 (22:58 +0200)]
timeline: fix incorrect position after scrolling using the timeline
Apparently events are dropped internally, so the last position after you stop
dragging can be off.
René Stadler [Sun, 23 Sep 2012 14:43:25 +0000 (16:43 +0200)]
models: store line offsets in arrays
René Stadler [Sun, 23 Sep 2012 15:22:53 +0000 (17:22 +0200)]
Use pango markup instead of attributes
Attributes don't work from introspection, so this blocks porting to gtk3.
In MessageColumn, admit that multiple highlighters don't actually work.
René Stadler [Sun, 23 Sep 2012 15:22:12 +0000 (17:22 +0200)]
findbar: highlight multiple matches in a message
René Stadler [Mon, 24 Sep 2012 00:15:09 +0000 (02:15 +0200)]
timeline: only redraw updated parts of the graph
Improves rendering performance a lot.
René Stadler [Mon, 24 Sep 2012 00:23:22 +0000 (02:23 +0200)]
timeline: fix position rectangle missing on first click
Regression caused by previous commit.
René Stadler [Fri, 21 Sep 2012 23:27:37 +0000 (01:27 +0200)]
timeline: only redraw required areas when updating position rectangle
René Stadler [Fri, 21 Sep 2012 23:25:22 +0000 (01:25 +0200)]
Fix crash when range filtering
Regression from 25cfe9 (timeline: make log level calculation a lot faster).
René Stadler [Fri, 21 Sep 2012 22:33:41 +0000 (00:33 +0200)]
timeline: clean up widget drawing
René Stadler [Fri, 21 Sep 2012 20:52:25 +0000 (22:52 +0200)]
timeline: make log level calculation a lot faster
This is the step where the timeline graph gets colored with the individual log
level colors. It's roughly 4.5 times faster now. Probably can be made even
better, the code also needs a cleanup.
René Stadler [Fri, 21 Sep 2012 20:15:07 +0000 (22:15 +0200)]
Data: improve stripped log file loading performance
A ~9% improvement for files without colors. This now slightly outperforms the
code before color support was added.
René Stadler [Fri, 21 Sep 2012 19:38:58 +0000 (21:38 +0200)]
Data: also yield while loading unparseable files
Otherwise, the UI would be blocked while loading something big that is not a
log file at all.
René Stadler [Fri, 21 Sep 2012 17:13:07 +0000 (19:13 +0200)]
Remove color stripping script
René Stadler [Fri, 21 Sep 2012 17:11:40 +0000 (19:11 +0200)]
Data: add support for colored log files
Adds a ~5% penalty for loading stripped files.
René Stadler [Thu, 20 Sep 2012 22:40:07 +0000 (00:40 +0200)]
timeline: remove broken actions from context menu
Hide lines before/after doesn't work as expected in this case.
René Stadler [Thu, 20 Sep 2012 21:51:05 +0000 (23:51 +0200)]
Data: fix parsing of lines missing filename or function name
E.g. ffmpeg.
René Stadler [Thu, 20 Sep 2012 18:20:58 +0000 (20:20 +0200)]
timeline: grab when scrolling in TimelineWidget
Also use gdk_event_request_motions.
René Stadler [Thu, 20 Sep 2012 18:11:48 +0000 (20:11 +0200)]
timeline: move mouse handling into TimelineWidget
René Stadler [Thu, 20 Sep 2012 17:58:06 +0000 (19:58 +0200)]
timeline: replace self.connect calls with vmethod overrides
Andrzej Bieniek [Mon, 17 Sep 2012 16:39:53 +0000 (18:39 +0200)]
setup: fix build
René Stadler [Mon, 27 Aug 2012 20:52:56 +0000 (13:52 -0700)]
timeline: don't select row when changing position in the timeline
Behaves just like the scrollbar now.
René Stadler [Mon, 27 Aug 2012 20:46:14 +0000 (13:46 -0700)]
timeline: stop scanning the file while filtering
René Stadler [Mon, 27 Aug 2012 20:45:57 +0000 (13:45 -0700)]
timeline: small cleanup
René Stadler [Fri, 24 Aug 2012 00:09:04 +0000 (02:09 +0200)]
Modernize menus a little
A bit in preparation to gtk3 app menus.
René Stadler [Thu, 23 Aug 2012 23:50:44 +0000 (01:50 +0200)]
Simplify and optimize filtered model implementation
RangeFilteredLogModel is gone. The functionality is trivially implemented in
FilteredLogModel now. Changing the range is now O(log n) at worst (was O(n) at
best, for rewriting the arrays). Stacking filtered models is not supported
anymore, which simplifies the code.
René Stadler [Thu, 23 Aug 2012 23:42:00 +0000 (01:42 +0200)]
Make RangeFilteredLogModel internal to GUI.models