Alex Langford [Wed, 29 Jan 2020 19:59:28 +0000 (11:59 -0800)]
[lldb] Move clang-based files out of Symbol
Summary:
This change represents the move of ClangASTImporter, ClangASTMetadata,
ClangExternalASTSourceCallbacks, ClangUtil, CxxModuleHandler, and
TypeSystemClang from lldbSource to lldbPluginExpressionParserClang.h
This explicitly removes knowledge of clang internals from lldbSymbol,
moving towards a more generic core implementation of lldb.
Reviewers: JDevlieghere, davide, aprantl, teemperor, clayborg, labath, jingham, shafik
Subscribers: emaste, mgorny, arphaman, jfb, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73661
Jonas Devlieghere [Fri, 31 Jan 2020 20:19:03 +0000 (12:19 -0800)]
[lldb/Test] Fix substrs order in self.expect for more tests (NFC)
Currently the substrs parameter takes a list of strings that need to be
found but the ordering isn't checked. D73766 might change that so this
changes a several tests so that the order of the strings in the substrs
list is in the order in which they appear in the output.
River Riddle [Fri, 31 Jan 2020 19:46:53 +0000 (11:46 -0800)]
[mlir][NFC] Refactor DialectConversion debug logging
Summary:
This revision beefs up the debug logging within dialect conversion. Given the nature of multi-level legalization, and legalization in general, it is one of the harder pieces of infrastructure to debug. This revision adds nice formatting to make the output log easier to parse:
```
Legalizing operation : 'std.constant'(0x608000002420) {
* Fold {
} -> FAILURE : unable to fold
* Pattern : 'std.constant -> ()' {
} -> FAILURE : pattern failed to match
* Pattern : 'std.constant -> ()' {
} -> FAILURE : pattern failed to match
* Pattern : 'std.constant -> (spv.constant)' {
** Insert : 'spv.constant'(0x608000002c20)
** Replace : 'std.constant'(0x608000002420)
//===-------------------------------------------===//
Legalizing operation : 'spv.constant'(0x608000002c20) {
} -> SUCCESS : operation marked legal by the target
//===-------------------------------------------===//
} -> SUCCESS : pattern applied successfully
} -> SUCCESS
```
Differential Revision: https://reviews.llvm.org/D73747
Nikita Popov [Fri, 24 Jan 2020 21:11:41 +0000 (22:11 +0100)]
[InstCombine] Push negation through multiply (PR44234)
Fixes https://bugs.llvm.org/show_bug.cgi?id=44234 by adding
multiply support to freelyNegateValue(). Only one of the operands
needs to be negatible, so this still fits within the framework.
Differential Revision: https://reviews.llvm.org/D73410
Siva Chandra Reddy [Fri, 31 Jan 2020 19:39:06 +0000 (11:39 -0800)]
[libc] Use cpp::Array instead of cpp::ArrayRef in memory/utils_test.
Building with address-sanitizer shows that using ArrayRef ends up
accessing a temporary outside its scope.
Dominic Chen [Fri, 31 Jan 2020 19:34:49 +0000 (14:34 -0500)]
[Typo fix] RNG: Take pass name as argument instead of pass pointer.
Summary: With the new pass manager, it is not possible to obtain a pointer to the pass.
Reviewers: jfb, rinon, yln
Subscribers: hiraditya, dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73390
aartbik [Fri, 31 Jan 2020 18:56:22 +0000 (10:56 -0800)]
[mlir] [VectorOps] fixed bug in vector.insert_strided_slice lowering
Summary:
Rationale:
When lowering to LLVM for different rank insert (n vs k), the offset
arrays needs to drop one dimension (becomes n-1), but the strides
array needs to be preserved (remains k). With regression test.
Note that this example was actually in the documentation, so
extra important to do it right :-)
Reviewers: nicolasvasilache, andydavis1, ftynse
Reviewed By: nicolasvasilache, ftynse
Subscribers: Joonsoo, merge_guards_bot, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, liufengdb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73733
Dominic Chen [Fri, 24 Jan 2020 22:21:14 +0000 (17:21 -0500)]
RNG: Take pass name as argument instead of pass pointer.
Summary: With the new pass manager, it is not possible to obtain a pointer to the pass.
Reviewers: jfb, rinon, yln
Subscribers: hiraditya, dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73390
Jay Foad [Thu, 16 Jan 2020 14:46:36 +0000 (14:46 +0000)]
[GlobalISel] Tweak lowering of G_SMULO/G_UMULO
Summary:
Applying this cleanup:
- MIRBuilder.buildInstr(TargetOpcode::G_ASHR)
- .addDef(Shifted)
- .addUse(Res)
- .addUse(ShiftAmt);
+ MIRBuilder.buildAShr(Shifted, Res, ShiftAmt);
caused an assertion failure here:
llc: /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/MachineRegisterInfo.cpp:404: llvm::MachineInstr *llvm::MachineRegisterInfo::getVRegDef(unsigned int) const: Assertion `(I.atEnd() || std::next(I) == def_instr_end()) && "getVRegDef assumes a single definition or no definition"' failed.
#4 0x00000000050a6d96 in llvm::MachineRegisterInfo::getVRegDef (this=0x74606a0, Reg=
2147483650) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/MachineRegisterInfo.cpp:403
#5 0x00000000066148f6 in llvm::getConstantVRegValWithLookThrough (VReg=
2147483650, MRI=..., LookThroughInstrs=false, HandleFConstant=true) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/GlobalISel/Utils.cpp:244
#6 0x00000000066147da in llvm::getConstantVRegVal (VReg=
2147483650, MRI=...) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/GlobalISel/Utils.cpp:210
#7 0x0000000006615367 in llvm::ConstantFoldBinOp (Opcode=101, Op1=
2147483650, Op2=
2147483656, MRI=...) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/GlobalISel/Utils.cpp:341
#8 0x000000000657eee0 in llvm::CSEMIRBuilder::buildInstr (this=0x7465010, Opc=101, DstOps=..., SrcOps=..., Flag=...) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/GlobalISel/CSEMIRBuilder.cpp:160
#9 0x0000000003645958 in llvm::MachineIRBuilder::buildAShr (this=0x7465010, Dst=..., Src0=..., Src1=..., Flags=...) at /home/jayfoad2/git/llvm-project/llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:1298
#10 0x00000000065c35b1 in llvm::LegalizerHelper::lower (this=0x7fffffffb5f8, MI=..., TypeIdx=0, Ty=...) at /home/jayfoad2/git/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2020
because at this point there are two instructions defining Res: the
original G_SMULO/G_UMULO and the new G_MUL that we built. The fix is
to modify the original mul in place, so that there is only ever one
definition of Res.
Reviewers: arsenm, aditya_nandakumar
Subscribers: wdng, rovka, hiraditya, volkan, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72842
Jessica Paquette [Thu, 30 Jan 2020 22:53:37 +0000 (14:53 -0800)]
[AArch64][GlobalISel] Walk through G_TRUNC in getTestBitReg
When you encounter a G_TRUNC, you are moving from a larger type to a smaller
type.
Asking for the i-th bit on a larger value is the same as asking for the i-th
bit on a smaller value.
So, we should always be able to walk through G_TRUNC when computing the bit
for a TB(N)Z.
Differential Revision: https://reviews.llvm.org/D73748
Jonas Devlieghere [Fri, 31 Jan 2020 18:54:41 +0000 (10:54 -0800)]
[lldb/Symbol] Use StringRef ctor to prevent incorrect overload
Use the StringRef constructor instead of toStringRef so we don't end up
with the wrong overload (llvm::toStringRef(bool)).
Fixes PR44736
Simon Pilgrim [Fri, 31 Jan 2020 18:57:10 +0000 (18:57 +0000)]
[DAG] SimplifyMultipleUseDemandedBits - peek through unused ISD::INSERT_SUBVECTOR subvectors
If we don't demand any elements of the inserted subvector then just skip it.
Alex Zinenko [Fri, 31 Jan 2020 18:46:57 +0000 (19:46 +0100)]
[mlir] Remove the dependency of StdToLLVM on LoopToStd
This is a leftover of a temporary state where loop operations were in Standard
dialect.
Alex Zinenko [Wed, 29 Jan 2020 10:33:57 +0000 (11:33 +0100)]
[mlir] Linalg tiling: generate code avoding out-of-bounds accesses
Summary:
After the `subview` operation was migrated from Linalg to Standard, it changed
semantics and does not guarantee the absence of out-of-bounds accesses through
the created view anymore. Compute the size of the subview to make sure it
always fits within the view (subviews in last iterations of the loops may be
smaller than those in other iterations).
Differential Revision: https://reviews.llvm.org/D73614
David Blaikie [Fri, 31 Jan 2020 18:14:18 +0000 (10:14 -0800)]
Orc: Remove an unnecessary explicit scope
(was useful at some point in the past for scoping some error handling
that's since been tidied up a bit)
Jonas Devlieghere [Fri, 31 Jan 2020 18:28:15 +0000 (10:28 -0800)]
[lldb/Test] Fix substrs order in self.expect for more tests (NFC)
Currently the substrs parameter takes a list of strings that need to be
found but the ordering isn't checked. D73766 might change that so this
changes a several tests so that the order of the strings in the substrs
list is in the order in which they appear in the output.
Fangrui Song [Fri, 31 Jan 2020 18:08:42 +0000 (10:08 -0800)]
[yaml2obj] Internlize DocNum. NFC
David Blaikie [Fri, 31 Jan 2020 18:09:41 +0000 (10:09 -0800)]
Orc: Remove redundant std::move
Saar Raz [Fri, 31 Jan 2020 18:05:09 +0000 (20:05 +0200)]
[Concepts] Fix isDeclarationSpecifier to detect type-constraints correctly
isDeclarationSpecifiers did not handle some cases of placeholder-type-specifiers with
type-constraints, causing parsing bugs in abbreviated constructor templates.
Add comprehensive handling of type-constraints to isDeclarationSpecifier.
Simon Pilgrim [Fri, 31 Jan 2020 18:02:21 +0000 (18:02 +0000)]
[DAG] Enable ISD::INSERT_SUBVECTOR SimplifyMultipleUseDemandedBits handling
This allows SimplifyDemandedBits to call SimplifyMultipleUseDemandedBits to create a simpler ISD::INSERT_SUBVECTOR, which is particularly useful for cases where we're splitting into subvectors anyhow.
alex-t [Fri, 31 Jan 2020 17:49:00 +0000 (20:49 +0300)]
[AMDGPU] fixed divergence driven shift operations selection
Differential Revision: https://reviews.llvm.org/D73483
Reviewers: rampitec
Hiroshi Yamauchi [Wed, 29 Jan 2020 17:36:31 +0000 (09:36 -0800)]
[PGO][PGSO] Handle MBFIWrapper
Some code gen passes use MBFIWrapper to keep track of the frequency of new
blocks. This was not taken into account and could lead to incorrect frequencies
as MBFI silently returns zero frequency for unknown/new blocks.
Add a variant for MBFIWrapper in the PGSO query interface.
Depends on D73494.
Jay Foad [Fri, 31 Jan 2020 12:40:31 +0000 (12:40 +0000)]
[GlobalISel] Tidy up unnecessary calls to createGenericVirtualRegister
Summary:
As a side effect some redundant copies of constant values are removed by
CSEMIRBuilder.
Reviewers: aemerson, arsenm, dsanders, aditya_nandakumar
Subscribers: sdardis, jvesely, wdng, nhaehnle, rovka, hiraditya, jrtc27, atanasyan, volkan, Petar.Avramovic, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73789
Raphael Isemann [Fri, 31 Jan 2020 08:02:32 +0000 (09:02 +0100)]
[lldb][NFC] Fix expect calls with wrong order of 'substrs' items for D73766
Currently the substrs parameter takes a list of strings
that need to be found but the ordering isn't checked. D73766
might change that so this changes a several tests so that
the order of the strings in the substrs list is in the order
in which they appear in the output.
Nathan James [Fri, 31 Jan 2020 16:49:13 +0000 (16:49 +0000)]
- Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory
Summary: Every call to a main like function in llvm and clang lib violates the naming convention for parameters. This prevents clang-tidy warning on such breaches.
Reviewers: alexfh, hokein
Reviewed By: hokein
Subscribers: merge_guards_bot, aheejin, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73715
Danilo Carvalho Grael [Thu, 30 Jan 2020 22:21:39 +0000 (17:21 -0500)]
[AArch64][SVE] Add SVE2 mla unpredicated intrinsics.
Summary:
Add intrinsics for the MLA unpredicated sve2 instructions:
- smlalb, smlalt, umlalb, umlalt, smlslb, smlslt, umlslb, umlslt
- sqdmlalb, sqdmlalt, sqdmlslb, sqdmlslt
- sqdmlalbt, sqdmlslbt
Reviewers: efriedma, sdesmalen, cameron.mcinally, c-rhodes, rengolin, kmclaughlin
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits, amehsan
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73746
Guillaume Chatelet [Fri, 31 Jan 2020 14:40:31 +0000 (15:40 +0100)]
[NFC] Introduce a type to model memory operation
Summary: This is a first step before changing the types to llvm::Align and introduce functions to ease client code.
Reviewers: courbet
Subscribers: arsenm, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73785
Jan Kratochvil [Fri, 31 Jan 2020 15:49:31 +0000 (16:49 +0100)]
[NFC] [lldb] Unindent DWARFDebugInfoEntry::GetDWARFDeclContext
Reduce code indentation level.
Matt Arsenault [Fri, 31 Jan 2020 15:38:36 +0000 (10:38 -0500)]
AMDGPU: Fix potential use of undefined value
Jan Kratochvil [Fri, 31 Jan 2020 15:04:40 +0000 (16:04 +0100)]
[lldb] Revert refactorization from: Move non-DWARF code: DWARFUnit -> SymbolFileDWARF
Reverting part of commit
789beeeca3cdeecc00cd731c940e52effdd7c7df.
Its DWARFDebugInfoEntry::GetDWARFDeclContext() refactorization for
return value is now adding it in opposite order.
Matt Arsenault [Thu, 23 Jan 2020 03:31:24 +0000 (22:31 -0500)]
AMDGPU/GlobalISel: Combine FMIN_LEGACY/FMAX_LEGACY
Try out using combine definition rules.
This really should be a post-legalizer combine, but the combiner pass
is currently pre-legalize. Most of the target combines are really
post-legalize, so we should probably move the pass.
Sanjay Patel [Fri, 31 Jan 2020 14:37:47 +0000 (09:37 -0500)]
[PATCH] D73727: [SLP] drop poison-generating flags for shuffle reduction ops (PR44536)
We may calculate reassociable math ops in arbitrary order when creating a shuffle reduction,
so there's no guarantee that things like 'nsw' hold on those intermediate values. Drop all
poison-generating flags for safety.
This change is limited to shuffle reductions because I don't think we have a problem in the
general case (where we intersect flags of each scalar op that goes into a vector op), but if
there's evidence of other cases being wrong, we can extend this fix to cover those cases.
https://bugs.llvm.org/show_bug.cgi?id=44536
Differential Revision: https://reviews.llvm.org/D73727
Pavel Labath [Fri, 31 Jan 2020 14:45:58 +0000 (15:45 +0100)]
[lldb] Add a basic unit test for the SharedCluster class
Pavel Labath [Fri, 31 Jan 2020 14:45:16 +0000 (15:45 +0100)]
[lldb] Remove some dead code from SharingPtr.h
These classes are not used.
Lei Zhang [Sun, 26 Jan 2020 16:10:29 +0000 (11:10 -0500)]
[mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops
This commit adds a pattern to lower linalg.generic for reduction
to spv.GroupNonUniform* ops. Right now this only supports integer
reduction on 1-D input memref. Shader entry point ABI is queried
to make sure that the input memref's shape matches the local
workgroup's invocation configuration. This makes sure that the
workload fits in one local workgroup so that we can leverage
SPIR-V group non-uniform operations.
linglg.generic is a structured op that preserves the right level
of information. It is easier to recognize reduction at this level
than performing analysis on loops.
This commit also exposes `getElementPtr` in SPIRVLowering.h given
that it's a generally useful utility function.
Differential Revision: https://reviews.llvm.org/D73437
Jonathan Coe [Fri, 31 Jan 2020 14:08:46 +0000 (14:08 +0000)]
[clang-format] Fixes for spaces around C# object initializers
Summary: Fix spaces around typename and [] in C# object initializers.
Reviewers: MyDeveloperDay, klimek, krasimir
Reviewed By: MyDeveloperDay, krasimir
Subscribers: cfe-commits
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D72401
Jan Kratochvil [Fri, 31 Jan 2020 14:16:31 +0000 (15:16 +0100)]
[lldb] Move non-DWARF code: DWARFUnit -> SymbolFileDWARF
This patchset is removing non-DWARF code from DWARFUnit for better
future merge with LLVM DWARF as discussed with @labath.
Differential revision: https://reviews.llvm.org/D70646
Matt Arsenault [Fri, 24 Jan 2020 16:55:46 +0000 (11:55 -0500)]
AMDGPU/GlobalISel: Select global MUBUF atomicrmw
Kadir Cetinkaya [Thu, 30 Jan 2020 17:42:01 +0000 (18:42 +0100)]
[clangd][Hover] Handle uninstantiated default args
Summary:
Default args might exist but be unparsed or uninstantiated.
getDefaultArg asserts on those. This patch makes sure we don't crash in such
scenarios.
Reviewers: sammccall, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73723
Matt Arsenault [Thu, 30 Jan 2020 23:41:10 +0000 (18:41 -0500)]
Reapply "AMDGPU: Cleanup and fix SMRD offset handling"
This reverts commit
6a4acb9d809aaadb9304a7a2f3382d958a6c2adf.
Saar Raz [Fri, 31 Jan 2020 13:55:06 +0000 (15:55 +0200)]
[Concepts] Correctly form initial parameter mapping for parameter packs, support substitution into SubstNonTypeTemplateParmExpr
We previously would not correctly for the initial parameter mapping for variadic template parameters in Concepts.
Testing this lead to the discovery that with the normalization process we would need to substitute into already-substituted-into
template arguments, which means we need to add NonTypeTemplateParmExpr support to TemplateInstantiator.
We do that by substituting into the replacement and the type separately, and then re-checking the expression against the NTTP
with the new type, in order to form any new required implicit casts (for cases where the type of the NTTP was dependent).
Kamil Rytarowski [Fri, 31 Jan 2020 13:54:30 +0000 (14:54 +0100)]
[compiler-rt] Fix build on NetBSD 9.99.44
Fix build on >= 9.99.44 after the removal of urio(4).
Add compat code for the device as NetBSD-9.0 is supported.
Jay Foad [Fri, 31 Jan 2020 13:52:33 +0000 (13:52 +0000)]
AMDGPU/GlobalISel: Make use of MachineIRBuilder helper functions. NFC.
Pavel Labath [Fri, 31 Jan 2020 13:45:35 +0000 (14:45 +0100)]
[lldb/DWARF] Delete some dead code in SymbolFileDWARF
- m_debug_loc(lists) are unused since the relevant logic was moved to
DWARFContext.
- const versions of DebugInfo(), DebugAbbrev() are not used, and they
are dangerous to use as they do not initialize the relevant objects.
serge-sans-paille [Thu, 16 Jan 2020 10:56:41 +0000 (11:56 +0100)]
Implement -fsemantic-interposition
First attempt at implementing -fsemantic-interposition.
Rely on GlobalValue::isInterposable that already captures most of the expected
behavior.
Rely on a ModuleFlag to state whether we should respect SemanticInterposition or
not. The default remains no.
So this should be a no-op if -fsemantic-interposition isn't used, and if it is,
isInterposable being already used in most optimisation, they should honor it
properly.
Note that it only impacts architecture compiled with -fPIC and no pie.
Differential Revision: https://reviews.llvm.org/D72829
Sjoerd Meijer [Fri, 31 Jan 2020 11:49:20 +0000 (11:49 +0000)]
[llvm-objdump] avoid crash disassembling unknown instruction
Disassembly of instructions can fail when llvm-objdump is not given the right set of
architecture features, for example when the source is compiled with:
clang -march=..+ext1+ext2
and disassembly is attempted with:
llvm-objdump -mattr=+ext1
This patch avoids further analysing unknown instructions (as was happening
before) when disassembly has failed.
Differential Revision: https://reviews.llvm.org/D73531
Raphael Isemann [Fri, 31 Jan 2020 09:46:08 +0000 (10:46 +0100)]
[lldb][NFC] Add a CompilerDecl->clang::Decl conversion function to ClangUtil
This automatically does the type checking for the cast.
Raphael Isemann [Fri, 31 Jan 2020 12:00:32 +0000 (13:00 +0100)]
[lldb][NFC] Remove unnecessary ClangASTImporter checks in ClangASTSource
A ClangASTSource always has a ClangASTImporter. Let's remove these sporadic
checks with a single assert during construction. They were added originally
for the modern-type-lookup mode that didn't use a ClangASTImporter in there.
Raphael Isemann [Fri, 31 Jan 2020 11:17:19 +0000 (12:17 +0100)]
[lldb][NFC] Remove ParserVars::m_parser_type member that was never read
We only assign values to this member but never read it. Also the
type in there has no side effects so let's just remove it.
Kerry McLaughlin [Fri, 31 Jan 2020 10:35:26 +0000 (10:35 +0000)]
[AArch64][SVE] Add remaining SVE2 intrinsics for uniform DSP operations
Summary:
Implements the following intrinsics:
- @llvm.aarch64.sve.[s|u]qadd
- @llvm.aarch64.sve.[s|u]qsub
- @llvm.aarch64.sve.suqadd
- @llvm.aarch64.sve.usqadd
- @llvm.aarch64.sve.[s|u]qsubr
- @llvm.aarch64.sve.[s|u]rshl
- @llvm.aarch64.sve.[s|u]qshl
- @llvm.aarch64.sve.[s|u]qrshl
- @llvm.aarch64.sve.[s|u]rshr
- @llvm.aarch64.sve.sqshlu
- @llvm.aarch64.sve.sri
- @llvm.aarch64.sve.sli
- @llvm.aarch64.sve.[s|u]sra
- @llvm.aarch64.sve.[s|u]rsra
- @llvm.aarch64.sve.[s|u]aba
Reviewers: efriedma, sdesmalen, dancgr, cameron.mcinally, c-rhodes, rengolin
Reviewed By: sdesmalen
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73551
Marek Kurdej [Thu, 30 Jan 2020 12:27:35 +0000 (13:27 +0100)]
Reland [libc++] [P0325] Implement to_array from LFTS with updates.
Fixed expected errors and notes.
Summary:
This patch implements https://wg21.link/P0325.
Reviewers: EricWF, mclow.lists, ldionne, lichray
Reviewed By: ldionne, lichray
Subscribers: lichray, dexonsmith, zoecarver, christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D69882
Sam Parker [Fri, 31 Jan 2020 10:31:57 +0000 (10:31 +0000)]
[NFC][ARM] Add test
Georgii Rymar [Tue, 28 Jan 2020 15:29:55 +0000 (18:29 +0300)]
[llvm-readobj] - Don't crash when dumping invalid dynamic relocation.
Currently when we dump dynamic relocation with use of
DT_RELA/DT_RELASZ/DT_RELAENT tags, we crash when a symbol index
is larger than the number of dynamic symbols or
when there is no dynamic symbol table.
This patch adds test cases and fixes the issues.
Differential revision: https://reviews.llvm.org/D73560
Stephan Herhut [Thu, 30 Jan 2020 10:27:17 +0000 (11:27 +0100)]
Fix conversion of loops to GPU with no block/thread dimensions.
Summary:
The current code assumes that one always maps at least one loop to block
dimensions and at least one loop to thread dimensions. If either is not
the case, a loop would get mapped twice.
Differential Revision: https://reviews.llvm.org/D73685
Georgii Rymar [Wed, 29 Jan 2020 14:10:07 +0000 (17:10 +0300)]
[llvm-readobj][test] - Cleanup testing of the --sections command line option.
We have the `ELF\sections.test` to test --sections.
`ELF\sections.test` uses precompiled objects, it has a bug (does not test -s alias properly).
Also, we test machine specific section types in `ELF\machine-specific-section-types.test`,
so we probably do not need to test `--sections` for a MIPS object in `ELF\sections.test`.
I think it is enough to test ELF32 and ELF64 (we do not test ELF64 in this test).
`Object/readobj-shared-object.test` also tests how llvm-readobj handles
`--sections`. It is location is wrong, it is not complete, it uses precompiled binaries
and it duplicates the `ELF\sections.test` partially (it tests both ELF32 and ELF64).
We have `ELF\readelf-s-alias.test` that tests the `-s` alias for `--sections` in llvm-readobj
and `-s` as an alias for `--symbols` in llvm-readelf.
There is no need to have a separate test for such things.
The test for the `-s` alias for `--sections` can be included into the `ELF\sections.test`.
And the test for `-s` for llvm-readelf is already included into `ELF\symbols.test`.
So, this patch:
1) Removes `Object/readobj-shared-object.test`.
2) Removes `ELF\readelf-s-alias.test`
3) Rewrites the `ELF\sections.test`.
4) Removes ELF/Inputs/trivial.obj.elf-mipsel.
Differential revision: https://reviews.llvm.org/D73686
Markus Böck [Fri, 31 Jan 2020 09:27:21 +0000 (11:27 +0200)]
[Support] Wrap extern TLS variable in getter function
This patch wraps an external thread local storage variable inside of a
getter function and makes it have internal linkage. This allows LLVM to
be built with BUILD_SHARED_LIBS on windows with MinGW. Additionally it
allows Clang versions prior to 10 to compile current trunk for MinGW.
Differential Revision: https://reviews.llvm.org/D73639
LLVM GN Syncbot [Fri, 31 Jan 2020 09:18:27 +0000 (09:18 +0000)]
[gn build] Port
16a0313ee32
Raphael Isemann [Fri, 31 Jan 2020 09:12:06 +0000 (10:12 +0100)]
[lldb] Print the command output when 'expect' fails even if a custom msg is passed
Currently if 'expect' fails and a custom msg is supplied, then lldbtest
will not print the actual command output. This makes it impossible to know
why the test actually failed. This just prints the command output even
if the msg parameter was supplied.
Guillaume Chatelet [Mon, 27 Jan 2020 14:42:20 +0000 (15:42 +0100)]
[libc] Add utils for memory functions
Summary: This patch adds a few low level functions needed to build libc memory functions.
Reviewers: sivachandra, jfb
Subscribers: mgorny, MaskRay, tschuett, libc-commits, ckennelly
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D73472
Igor Kudrin [Wed, 15 Jan 2020 03:20:58 +0000 (10:20 +0700)]
[DWARF] Add support for 64-bit DWARF in .debug_names.
Differential Revision: https://reviews.llvm.org/D72900
Marek Kurdej [Fri, 31 Jan 2020 08:43:48 +0000 (09:43 +0100)]
Revert "[libc++] [P0325] Implement to_array from LFTS with updates."
This reverts commit
86aae78268f31e58b619c9ae69e8b661dfacb9f4.
A test is failing on "Release" build without assertions enabled (Fedora 31 on x86_64).
Raphael Isemann [Fri, 31 Jan 2020 08:22:25 +0000 (09:22 +0100)]
[lldb][NFC] Add safe Decl->CompilerDecl conversion function TypeSystemClang
This adds a conversion function from clang::Decl to CompilerDecl. It checks
that the TypeSystemClang in the CompilerDecl actually fits to the clang::Decl
AST during creation, thus preventing the creation of CompilerDecl instances with
inconsistent state.
Raphael Isemann [Fri, 31 Jan 2020 08:05:20 +0000 (09:05 +0100)]
[lldb][NFC] Cleanup ClangASTImporter::LayoutInfo
Sebastian Neubauer [Thu, 23 Jan 2020 13:53:53 +0000 (14:53 +0100)]
Fix typo
Summary: Fix typo
Subscribers: jvesely, nhaehnle, kerbowa, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73458
Tim Shen [Wed, 22 Jan 2020 21:46:11 +0000 (13:46 -0800)]
[mlir] Add MemRefTypeBuilder and refactor some MemRefType::get().
The refactored MemRefType::get() calls all intend to clone from another
memref type, with some modifications. In fact, some calls dropped memory space
during the cloning. Migrate them to the cloning API so that nothing gets
dropped if they are not explicitly listed.
It's close to NFC but not quite, as it helps with propagating memory spaces in
some places.
Differential Revision: https://reviews.llvm.org/D73296
Alex Langford [Fri, 31 Jan 2020 07:16:12 +0000 (23:16 -0800)]
[lldb][NFCI] Remove UserExpression::GetJITModule
UserExpression::GetJITModule was used to support an option in
UserExpression::Evaluate that let you hold onto the JIT Module used during
the expression evaluation. This was only actually used in one spot --
REPL::IOHandlerInputComplete. That method didn't actually take use the
JIT module it got back, so this feature was not used in practice.
This means that we can delete the support in UserExpression::Evaluate
and delete the UserExpression::GetJITModule method entirely.
Alex Langford [Fri, 31 Jan 2020 05:55:18 +0000 (21:55 -0800)]
[lldb][NFCI] Remove unused LanguageType parameters
These parameters are unused in these methods, and some of them only had a
LanguageType parameter to pipe to other methods that don't use it
either.
Jonas Devlieghere [Fri, 31 Jan 2020 05:23:58 +0000 (21:23 -0800)]
[lldb/Lit] Fix UnboundLocalError when reaching a timeout.
Fixes the UnboundLocalError for the local variables out, err and
exitCode when a timeout is hit.
Jonas Devlieghere [Fri, 31 Jan 2020 04:15:35 +0000 (20:15 -0800)]
[SmallString] Use data() instead of begin() (NFC)
Both begin() and data() do the same thing for the SmallString case, but
the std::string and llvm::StringRef constructors that are being called
are defined as taking a pointer and size.
Addresses Craig Topper's feedback in https://reviews.llvm.org/D73640
Quentin Colombet [Fri, 31 Jan 2020 03:30:39 +0000 (19:30 -0800)]
[GISel][KnownBits] Fix a bug where we could run out of stack space
One of the exit criteria of computeKnownBits is whether we reach the max
recursive call depth. Before this patch we would check that the
depth is exactly equal to max depth to exit.
Depth may get bigger than max depth if it gets passed to a different
GISelKnownBits object.
This may happen when say a generic part uses a GISelKnownBits object
with some max depth, but then we hit TL.computeKnownBitsForTargetInstr
which creates a new GISelKnownBits object with a different and smaller
depth. In that situation, when we hit the max depth check for the first
time in the target specific GISelKnownBits object, depth may already
be bigger than the current max depth. Hence we would continue to compute
the known bits, until we ran through the full depth of the chain of
computation or ran out of stack space.
For instance, let say we have
GISelKnownBits Info(/*MaxDepth*/ = 10);
Info.getKnownBits(Foo)
// 9 recursive calls to computeKnownBitsImpl.
// Then we hit a target specific instruction.
// The target specific GISelKnownBits does this:
GISelKnownBits TargetSpecificInfo(/*MaxDepth*/ = 6)
TargetSpecificInfo.computeKnownBitsImpl() // <-- next max depth checks would
// always return false.
This commit does not have any test case, none of the in-tree targets
use computeKnownBitsForTargetInstr.
Richard Smith [Fri, 31 Jan 2020 02:40:53 +0000 (18:40 -0800)]
PR44627: Consider reversing == and <=> candidates found by ADL.
Pierre Habouzit [Fri, 31 Jan 2020 02:21:25 +0000 (18:21 -0800)]
Revert "[objc_direct] Small updates to help with adoption."
This reverts commit
bebb8e2596af8fe97f9b6356ff06e4e80580cf32.
Pushed by accident, not yet reviewed
Pierre Habouzit [Fri, 31 Jan 2020 00:48:11 +0000 (16:48 -0800)]
[objc_direct] Small updates to help with adoption.
Add fixits for messaging self in MRR or using super, as the intent is
clear, and it turns out people do that a lot more than expected.
Allow for objc_direct_members on main interfaces, it's extremely useful
for internal only classes, and proves to be quite annoying for adoption.
Add some better warnings around properties direct/non-direct clashes (it
was done for methods but properties were a miss).
Radar-Id: rdar://problem/
58355212
Signed-off-by: Pierre Habouzit <phabouzit@apple.com>
Pierre Habouzit [Wed, 22 Jan 2020 16:46:54 +0000 (08:46 -0800)]
[objc_direct] fix codegen for mismatched Decl/Impl return types
For non direct methods, the codegen uses the type of the Implementation.
Because Objective-C rules allow some differences between the Declaration
and Implementation return types, when the Implementation is in this
translation unit, the type of the Implementation should be preferred to
emit the Function over the Declaration.
Radar-Id: rdar://problem/
58797748
Signed-off-by: Pierre Habouzit <phabouzit@apple.com>
Differential Revision: https://reviews.llvm.org/D73208
Alex Langford [Fri, 31 Jan 2020 02:02:36 +0000 (18:02 -0800)]
[lldb][NFCI] Delete commented out code
Fangrui Song [Tue, 7 Jan 2020 20:24:59 +0000 (12:24 -0800)]
[llvm-objcopy][test] Fix tests when path contains "bar"
Differential Revision: https://reviews.llvm.org/D72358
Fangrui Song [Wed, 22 Jan 2020 20:27:17 +0000 (12:27 -0800)]
[X86][ELF] Prefer to lower MC_GlobalAddress operands to .Lfoo$local
For a MC_GlobalAddress reference to a dso_local external GlobalValue with a definition, emit .Lfoo$local to avoid a relocation.
-fno-pic and -fpie can infer dso_local but -fpic cannot. In the future,
we can explore the possibility of inferring dso_local with -fpic. As the
description of D73228 says, LLVM's existing IPO optimization behaviors
(like -fno-semantic-interposition) and a previous assembly behavior give
us enough license to be aggressive here.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D73230
Saar Raz [Fri, 31 Jan 2020 01:37:46 +0000 (03:37 +0200)]
[Concepts] Check function constraints before deducing auto return type
A constrained function with an auto return type would have it's definition
instantiated in order to deduce the auto return type before the constraints
are checked.
Move the constraints check after the return type deduction.
Richard Smith [Fri, 31 Jan 2020 01:42:17 +0000 (17:42 -0800)]
PR41991: Accept attributes on defaulted and deleted friends.
Attributes are permitted on friend definitions, but we only checked for
a proper function body, not for the =default / =delete cases.
Richard Smith [Fri, 31 Jan 2020 01:11:47 +0000 (17:11 -0800)]
PR44721: Don't consider overloaded operators for built-in comparisons
when building a defaulted comparison.
As a convenient way of asking whether `x @ y` is valid and building it,
we previouly always performed overload resolution and built an
overloaded expression, which would both end up picking a builtin
operator candidate when given a non-overloadable type. But that's not
quite right, because it can result in our finding a user-declared
operator overload, which we should never do when applying operators
non-overloadable types.
Handle this more correctly: skip overload resolution when building
`x @ y` if the operands are not overloadable. But still perform overload
resolution (considering only builtin candidates) when checking validity,
as we don't have any other good way to ask whether a binary operator
expression would be valid.
Richard Smith [Wed, 29 Jan 2020 20:07:14 +0000 (12:07 -0800)]
Replace 'AllowExplicit' bool with an enum. No functionality change.
In passing, split it up into three values (no explicit functions /
explicit conversion functions only / any explicit functions) in
preparation for using that in a future change.
Leonard Chan [Fri, 31 Jan 2020 01:09:42 +0000 (17:09 -0800)]
[SafeStack][DebugInfo] Insert DW_OP_deref in correct location
This patch addresses the issue found in https://bugs.llvm.org/show_bug.cgi?id=44585
where a DW_OP_deref was placed at the end of a dwarf expression, resulting in corrupt
symbols when debugging.
This is an attempt to reland with a few fixes for buildbot since I
haven't merged from master in a bit.
Differential Revision: https://reviews.llvm.org/D73526
Martijn Vels [Tue, 28 Jan 2020 18:43:19 +0000 (13:43 -0500)]
White space only change: reflow a comment in basic_string
Summary: This change reflows a comment line. This change serves as a no-op test commit
Reviewers: mclow.lists, ldionne, EricWF
Subscribers: dexonsmith, christof, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D73552
Alex Langford [Fri, 31 Jan 2020 00:52:57 +0000 (16:52 -0800)]
[lldb][NFCI] Rename variable in ValueObject
Amara Emerson [Fri, 31 Jan 2020 00:25:20 +0000 (16:25 -0800)]
[GlobalISel][IRTranslator] When translating vector geps, splat the base pointer if required.
We can have geps that have a scalar base pointer, and a vector index value, which
means that the base pointer must be splatted into a vector of pointers.
This fixes crashes on arm64 GlobalISel with optimizations enabled.
Leonard Chan [Fri, 31 Jan 2020 00:18:41 +0000 (16:18 -0800)]
Revert "[SafeStack][DebugInfo] Insert DW_OP_deref in correct location"
This reverts commit
fff6a1b0f1fe57b46379001db75952d2a06eab1f.
This was breaking a bunch of buildbots.
Mehdi Amini [Thu, 30 Jan 2020 01:44:35 +0000 (01:44 +0000)]
MSVC Buggy version detection: turn pre-processor error into CMake configuration time check
This allows consumer to override in a cleaner way while still prevent
them from hitting bug without knowing they run an unsupported
configuration.
Recommit after fix by Christopher Tetreault to add parens and ${} to
cmake check to work around CMake configure time "unknown arguments
specified" issue
Differential Revision: https://reviews.llvm.org/D73677
Differential Revision: https://reviews.llvm.org/D73751
Hector Diaz [Thu, 30 Jan 2020 23:07:49 +0000 (15:07 -0800)]
Auto-completion bug fix for dot operator
Summary:
There was a bug on LLDB VSCode where there was the following behavior:
//Code
```
struct foo {
int bar:
};
...
foo my_foo = {10};
```
Trying to auto-complete my_foo.b with my_foo.bar resulted instead with my_foo.my_foo.bar
This diff fixes this bug and adds some tests to check correct behavior.
It also fixes the same bug using the arrow operator (->) when user manually requests completions.
TODO: Fix bug where no recommended completions are automatically shown with arrow operator
{
F11249959}
{
F11249958}
Reviewers: wallace
Reviewed By: wallace
Subscribers: teemperor, labath, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73506
Leonard Chan [Tue, 28 Jan 2020 20:30:33 +0000 (12:30 -0800)]
[SafeStack][DebugInfo] Insert DW_OP_deref in correct location
This patch addresses the issue found in https://bugs.llvm.org/show_bug.cgi?id=44585
where a DW_OP_deref was placed at the end of a dwarf expression, resulting in
corrupt symbols when debugging.
Differential Revision: https://reviews.llvm.org/D73526
Jonas Devlieghere [Thu, 30 Jan 2020 23:51:29 +0000 (15:51 -0800)]
[lldb/Reproducers] Fix typo in CMake so we actually replay.
The CMakeLists.txt had a typo which meant that check-lldb-repro was
capturing twice instead of capturing and then replaying. This also
uncovered a missing import in lldb-repro.py. This patch fixes both
issues.
Jonas Devlieghere [Thu, 30 Jan 2020 23:35:09 +0000 (15:35 -0800)]
[lldb/Reproducers] Use LLDB_RECORD_DUMMY for GetStopDescription
GetStopDescription writes to a const char* with a given length. However,
the reproducer instrumentation serialized the char pointer and length
separately.
To serialize the string, we naively look for the first null byte to
determine its length. This can lead to the method overwriting the input
buffer when the assumed string length is smaller than the actual number
of bytes written by GetStopDescription.
The real solution is to have a custom serializer that takes both
arguments into account. However, given that these are output parameters,
they don't affect replay. If the string is passed as input later, it's
is recorded as such. Therefore I've replaced the instrumentation macro
with LLDB_RECORD_DUMMY which skips the serialization.
Matt Arsenault [Thu, 30 Jan 2020 23:39:51 +0000 (15:39 -0800)]
Revert "AMDGPU: Cleanup and fix SMRD offset handling"
This reverts commit
17dbc6611df9044d779d85b3d545bd37e5dd5200.
A test is failing on some bots
Mehdi Amini [Thu, 30 Jan 2020 23:38:36 +0000 (23:38 +0000)]
Revert "MSVC Buggy version detection: turn pre-processor error into CMake configuration time check"
This reverts commit
b4fac782462c26baa94798e5fdb58e6810bd336b.
It broke the MSVC bot
Matt Arsenault [Thu, 30 Jan 2020 16:42:58 +0000 (11:42 -0500)]
AMDGPU: Cleanup and fix SMRD offset handling
I believe this also fixes bugs with CI 32-bit handling, which was
incorrectly skipping offsets that look like signed 32-bit values. Also
validate the offsets are dword aligned before folding.
Matt Arsenault [Thu, 30 Jan 2020 21:05:34 +0000 (16:05 -0500)]
CodeGen: Use Register
Jessica Paquette [Wed, 29 Jan 2020 21:28:30 +0000 (13:28 -0800)]
[AArch64][GlobalISel] Fold in G_ANYEXT/G_ZEXT into TB(N)Z
This is similar to the code in getTestBitOperand in AArch64ISelLowering. Instead
of implementing all of the TB(N)Z optimizations at once, this patch implements
the simplest case first. The way that this is set up should make it fairly easy
to add the rest as we go along.
The idea here is that after determining that we can use a TB(N)Z, we can
continue looking through instructions and perform further folding.
In this case, when we have a G_ZEXT or G_ANYEXT where the extended bits are not
used, we can fold it into the TB(N)Z.
Differential Revision: https://reviews.llvm.org/D73673
Amara Emerson [Thu, 30 Jan 2020 22:48:40 +0000 (14:48 -0800)]
[AArch64][GlobalISel] Disallow vectors in convertPtrAddToAdd.
Found by inspection, but there's no test for this yet because G_PTR_ADD is
currently illegal for vectors. I'll add the test at a later time when the
legalizer support has landed.
Nikita Popov [Thu, 30 Jan 2020 22:24:27 +0000 (23:24 +0100)]
[InstCombine] Remove unnecessary worklist add; NFCI
Again, this will already be added by IRBuilder.
Roland McGrath [Thu, 30 Jan 2020 22:20:02 +0000 (14:20 -0800)]
[Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes
This is never appropriate on Fuchsia and any future needs for
system library dependencies of compiler-supplied runtimes will
be addressed via .deplibs instead of driver hacks.
Patch By: mcgrathr
Differential Revision: https://reviews.llvm.org/D73734
David Tenty [Thu, 30 Jan 2020 17:33:00 +0000 (12:33 -0500)]
[NFC] Fix check prefix add in fcanonicalize-elimination.ll
The test fix added by "D39306: Fix
CodeGen/AMDGPU/fcanonicalize-elimination.ll on FreeBSD 11.0" uses a test
prefix which is not actually used in the FileCheck stanza. Thus the
problem originally encountered still exists and the tests fails for host
triples that contain "1.0", including AIX 7.1.0.