Daniel Stone [Sat, 25 Apr 2009 04:55:59 +0000 (14:55 +1000)]
Keysym: Add apallingly bad API documentation for keysym <-> string
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:52:51 +0000 (14:52 +1000)]
Make keysym <-> string conversion public API
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:51:46 +0000 (14:51 +1000)]
XKB: Text: Use keysym <-> string conversion from keysym.c
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:51:16 +0000 (14:51 +1000)]
Test: Keysym: Add tests for new keysym <-> string conversions
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:42:42 +0000 (14:42 +1000)]
Keysym: Fix conversion for Unicode and bare numbers
Ensure that Unicode string representations are accepted and turned into
numbers, as well as hexadecimal numbers in 0xabcd1234 form; unknown
keysyms are output as 0xabcd1234 in string form.
This also ensures that strings are never returned malloc()ed.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:32:04 +0000 (14:32 +1000)]
KeySym: Actually handle NoSymbol
Add NoSymbol into the keysym table, so keysym <-> string conversion works for
that, too; also eliminate special-casing of VoidSymbol.
This will require special-casing in libX11 to preserve its API.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Sat, 25 Apr 2009 04:29:23 +0000 (14:29 +1000)]
test: Fix srcdir != objdir build and test failures
filecomp would fail because it couldn't find the input files, after
compilation failed due to missing includes.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Dan Nicholson [Wed, 22 Apr 2009 06:22:25 +0000 (23:22 -0700)]
listing: Drop unused deviceSpec argument
The server might care about this, but ListComponents is just reading xkb
files.
Dan Nicholson [Mon, 20 Apr 2009 13:40:34 +0000 (06:40 -0700)]
xkbcomp: Another fairly major rewrite of the listing mode
The listing code in xkbcomp had been setup to allocate a set of buffers
with file paths and then later parse through them to find which maps were
needed.
All the allocation (with the additional allocation for the components
list) was making it really slow, so this patch makes everything simpler
by just generating the components list as we walk the directory tree.
Dan Nicholson [Sun, 19 Apr 2009 23:30:36 +0000 (16:30 -0700)]
Rewrite listing code to generate XkbComponentListPtr
In xkbcomp, the listing code printed out the xkb files to stdout and the
caller would parse the output. Here, we can just generate a
XkbComponentListPtr and pass it back.
This should be a series of smaller commits, but there was no clean way to
do it since it's basically a complete rewrite except for the core map
matching logic.
A lot of code used for special printing modes in xkbcomp has been
shedded. Callers can massage the output as they please.
Dan Nicholson [Fri, 17 Apr 2009 04:47:28 +0000 (21:47 -0700)]
xkbcomp: Kill unused listing code and make functions static
Much of this was only called from xkbcomp and not used to generate
listings for the server.
Dan Nicholson [Fri, 17 Apr 2009 03:01:13 +0000 (20:01 -0700)]
Scale back global variables
Some of the global variables were either not used anymore or only used
in the listing code.
Dan Nicholson [Sun, 12 Apr 2009 19:30:12 +0000 (12:30 -0700)]
Add XkbNameMatchesPattern implementation from xkbfile
The xkbcomp listing code matches a glob type pattern against installed
xkb files. This adds a Xkbc implementation of the pattern matching code.
Dan Nicholson [Sun, 12 Apr 2009 19:15:05 +0000 (12:15 -0700)]
xkbcomp: Fix use of removed macros
Dan Nicholson [Sun, 12 Apr 2009 18:13:52 +0000 (11:13 -0700)]
Revert "xkbcomp: Remove listing sources"
This reverts commit
c4c9e36fbf4019d802323d9053f54cbfa6d3d5e5. It turns
out that the listing code is used to support the X_kbListComponents
request (via XkbListComponents).
This will have to be refactored into some reasonable interface instead
of the current usage where the server reads xkbcomp stdout. Gross.
Dan Nicholson [Sun, 12 Apr 2009 19:14:36 +0000 (12:14 -0700)]
misc: Coding-style cleanup
Dan Nicholson [Sat, 11 Apr 2009 17:35:44 +0000 (10:35 -0700)]
Use xkbpath API for locating rules
Instead of hardcoding the XKB base directory when searching for rules in
the xkbcomp code, we can extend the xkbpath API to cover rules and reuse
it. That will make it more convenient if it's ever exposed so people can
set their XKB search paths in a reasonable way.
Dan Nicholson [Fri, 10 Apr 2009 19:33:31 +0000 (12:33 -0700)]
Program and files for testing CompileKeymapFromFile
A few simple test cases for verifying the operation of parsing a keymap
file and compiling a keyboard description from it.
Dan Nicholson [Fri, 10 Apr 2009 19:25:51 +0000 (12:25 -0700)]
Add interface to compile keyboard description from keymap files
We need to support generating a keyboard description from a keymap file
because there are just some cases where RMLVO or ktcsg is not enough.
The map choosing logic has been refactored into its own function and now
supports choosing a named or default keymap.
Dan Nicholson [Fri, 10 Apr 2009 03:52:26 +0000 (20:52 -0700)]
test: Remove extraneous includes
These programs don't actually use the internal API.
Dan Nicholson [Thu, 9 Apr 2009 21:29:32 +0000 (14:29 -0700)]
Make XkbcInitAtoms externally accessible
Applications (like the server) need to initialize the atoms system
before using the rest of the library. Maybe it should just init itself
implicitly.
Dan Nicholson [Thu, 9 Apr 2009 00:59:15 +0000 (17:59 -0700)]
Constify public API
There's no reason the arguments can't be const.
Dan Nicholson [Thu, 9 Apr 2009 00:54:55 +0000 (17:54 -0700)]
Change CompileKeymapFromRules to take XkbRMLVOSet
Let's use a nice interface now that it's available from XKBrulescommon.h.
Dan Nicholson [Wed, 8 Apr 2009 14:46:25 +0000 (07:46 -0700)]
Remove all non-public API from XKBcommon.h header
The noble intention was to expose all the new API and new generic types
in the split out kbproto headers through XKBcommon.h. It turns out that
would be a massive amount of work in the server. Someday, but first just
wedging in XkbCompileKeymap* would be good.
Most of the API is in new internal xkb*.h headers. In order to allow the
XKBcommon.h header to be used from the server, we can't pull in other
headers from kbproto since the server has its own copies. However, types
that are different (XkbDescRec, XkbAction) still have Xkbc equivalents
here, and I think they should be used in the server.
Dan Nicholson [Wed, 8 Apr 2009 02:56:41 +0000 (19:56 -0700)]
Remove KS macros available in XKBfilecommon.h now
A couple of the XkbcKS* macros become redundant with XKBfilecommon.h
split out in kbproto.
Dan Nicholson [Mon, 6 Apr 2009 03:27:35 +0000 (20:27 -0700)]
Require strdup and remove utils wrapper
This kills a couple warnings from using the uStringDup wrapper. If you
don't have strdup on your platform, you have bigger issues.
Dan Nicholson [Sun, 5 Apr 2009 22:15:20 +0000 (15:15 -0700)]
Add action datatypes as defined in the server
Some of the XkbAction types are defined differently in the server, so we
add those to XKBcommon.h and use them here like XkbcDescPtr. We'll have
to deal with the impedance mismatch on the client side later.
Dan Nicholson [Sun, 5 Apr 2009 16:30:15 +0000 (09:30 -0700)]
Coding style cleanup on key allocation functions
Dan Nicholson [Sat, 4 Apr 2009 19:54:44 +0000 (12:54 -0700)]
test: Exercise compiling from components
This could probably use a lot more real world test cases, but it does
the job for now.
Dan Nicholson [Sat, 4 Apr 2009 19:50:27 +0000 (12:50 -0700)]
xkbcomp: Don't say we're exiting when we're not
Dan Nicholson [Sat, 4 Apr 2009 19:31:55 +0000 (12:31 -0700)]
xkbcomp: Give keymap file empty name if none supplied
Ensure that the keymap file topName is not NULL since it gets blindly
dereferenced later.
Dan Nicholson [Sat, 4 Apr 2009 19:21:05 +0000 (12:21 -0700)]
xkbcomp: Ensure at least keycodes supplied in components
It seems that at least a non-empty keycodes component is required to
compile a XkbcDescPtr.
Dan Nicholson [Sat, 4 Apr 2009 19:17:50 +0000 (12:17 -0700)]
xkbcomp: Don't dereference NULL VarDefsPtr
Dan Nicholson [Sat, 4 Apr 2009 19:16:04 +0000 (12:16 -0700)]
xkbcomp: Refactor keymap file generator
Dan Nicholson [Sat, 4 Apr 2009 18:04:35 +0000 (11:04 -0700)]
test: Minor refactor to allow $EXEEXT in program names
Dan Nicholson [Sat, 4 Apr 2009 17:52:23 +0000 (10:52 -0700)]
test: Add logging and some intentionally failing cases
We want to log the output of the tests rather than letting them go to
stderr. This allows tests we expect to fail to be run.
Dan Nicholson [Sat, 4 Apr 2009 17:02:39 +0000 (10:02 -0700)]
xkbcomp: Generating components requires rules _and_ layout
This came from trial and error, but it seems that you can generate a
valid keymap with only rules and layout.
Dan Nicholson [Sat, 4 Apr 2009 16:51:33 +0000 (09:51 -0700)]
xkbcomp: Fail when converting rules to components returns an error
XkbcRF_GetComponents was returning an error but leaving the generated
components alone. This ensures that the broken XkbComponentNamesPtr is
freed and the error is passed up to the caller.
Dan Nicholson [Sat, 4 Apr 2009 16:48:59 +0000 (09:48 -0700)]
xkbcomp: Cleanup error messages
Dan Nicholson [Sat, 4 Apr 2009 16:46:20 +0000 (09:46 -0700)]
xkbcomp: Ensure user has supplied a rules name
Dan Nicholson [Sat, 4 Apr 2009 16:37:53 +0000 (09:37 -0700)]
rulescomp: Remove unneeded API
Dan Nicholson [Sat, 4 Apr 2009 16:29:43 +0000 (09:29 -0700)]
Refactor xkbpath so that it implicitly initializes
Instead of requiring the user to call XkbInitIncludePath() and
XkbAddDefaultDirectoriesToPath(), all the path entry points now implicitly
initialize the path. When initializing, the default directories are added
so it's useful.
This provides normal operation without exposing the xkbpath API. That
might happen later to allow apps to edit the XKB search path.
Dan Nicholson [Sat, 4 Apr 2009 16:19:51 +0000 (09:19 -0700)]
Remove trailing spaces in source files
Dan Nicholson [Sat, 4 Apr 2009 16:14:20 +0000 (09:14 -0700)]
Test compiler to simulate xkbcomp usage
Added a test program, rulescomp, which takes a RMLVO set and generates a
XkbcDescPtr. This is essentially what the xserver will do, except that we
still need to access some xkbcomp internal API to make it work.
Dan Nicholson [Sat, 4 Apr 2009 15:52:17 +0000 (08:52 -0700)]
Fix cleanup error in names allocation
A conditional got reversed during the coding style cleanup.
Dan Nicholson [Sat, 4 Apr 2009 04:18:58 +0000 (21:18 -0700)]
xkbcomp: Ignore generated parser
Dan Nicholson [Sat, 4 Apr 2009 04:16:56 +0000 (21:16 -0700)]
xkbcomp: Don't segfault if the debug files aren't set
Another interface that needs to be cleaned up.
Dan Nicholson [Sat, 4 Apr 2009 03:34:41 +0000 (20:34 -0700)]
xkbcomp: Declare global debugging vars
These will need to be sanitized at some point, but for now let's just get
the code running.
Dan Nicholson [Sat, 4 Apr 2009 03:33:01 +0000 (20:33 -0700)]
xkbcomp: Back out strdup warning cleanup
There are some spots in the code that use strdup without checking the
argument, so we need this to not segfault. Cleanup later...
Dan Nicholson [Sat, 4 Apr 2009 02:35:01 +0000 (19:35 -0700)]
Fix install path for XKBcommon.h
Dan Nicholson [Thu, 2 Apr 2009 13:37:16 +0000 (06:37 -0700)]
Drop keysym.h pollution from XKBcommon.h
There's really no need to pull this into a public header.
Dan Nicholson [Wed, 1 Apr 2009 13:22:06 +0000 (06:22 -0700)]
Add xkbcommon pkg-config file
Dan Nicholson [Wed, 1 Apr 2009 02:30:44 +0000 (19:30 -0700)]
xkbcomp: Clean up utils prototypes
Includes using a macro for the gcc format attributes instead of repeated
ifdef's.
Dan Nicholson [Tue, 31 Mar 2009 14:21:20 +0000 (07:21 -0700)]
xkbcomp: Remove duplicated macros
Dan Nicholson [Tue, 31 Mar 2009 14:09:47 +0000 (07:09 -0700)]
xkbcomp: Kill warnings about address always evaluating as true
Dan Nicholson [Tue, 31 Mar 2009 13:57:06 +0000 (06:57 -0700)]
Merge commit 'tilt/master'
Dan Nicholson [Tue, 31 Mar 2009 12:36:52 +0000 (05:36 -0700)]
Compile keyboard description from XKB rules, too
XkbcCompileKeymapFromRules can be used to generate a XkbDescPtr from XKB
rules instead of using components. The previous XkbcCompileKeymap has
been renamed to XkbcCompileKeymapFromComponents.
Dan Nicholson [Sun, 29 Mar 2009 18:25:44 +0000 (11:25 -0700)]
Add rules file parsing from xkbfile
Copy over the Xkb_RF* rules parsing functions from xkbfile's maprules.c.
Eventually, this will be tied into xkbcomp's path searching utilities so
you don't need to supply a full path to the rules file. Also, it this
should eventually incorporate the server's RMLVOSet.
Dan Nicholson [Sun, 29 Mar 2009 18:25:44 +0000 (11:25 -0700)]
Add rules rules file parsing from xkbfile
Copy over the Xkb_RF* rules parsing functions from xkbfile's maprules.c.
Eventually, this will be tied into xkbcomp's path searching utilities so
you don't need to supply a full path to the rules file. Also, it this
should eventually incorporate the server's RMLVOSet.
Dan Nicholson [Sun, 29 Mar 2009 15:55:18 +0000 (08:55 -0700)]
Generate keyboard description from components
Finally, we can generate a XkbcDescPtr from a XkbComponentNamesPtr. This
involves turning the components into a parsed XKB file and then passing
it into the compiler. This first conversion needs more error handling.
Dan Nicholson [Sun, 29 Mar 2009 15:17:13 +0000 (08:17 -0700)]
xkbcomp: Include Xdefs.h for Atom in tokens.h
Dan Nicholson [Sun, 29 Mar 2009 15:15:27 +0000 (08:15 -0700)]
xkbcomp: Add missing includes for Bool in xkbpath
Dan Nicholson [Sun, 29 Mar 2009 15:11:25 +0000 (08:11 -0700)]
Add XKBlib resizing functions
These were originally in XKBMalloc.c.
Dan Nicholson [Sun, 29 Mar 2009 02:21:18 +0000 (19:21 -0700)]
Copy xkbfile IsUpper/IsLower macros
xkbcomp was using Xlib's XConvertCase to check upper/lowercase. That's a
lot of code, so hopefully the xkbfile macros using _XkbKSCheckCase are
good enough. This also required that <X11/keysym.h> is included to get
all the XK_* definitions.
Dan Nicholson [Sun, 29 Mar 2009 02:00:13 +0000 (19:00 -0700)]
Copy XkbEnsureSafeMapName from xkbfile
Dan Nicholson [Sun, 29 Mar 2009 01:50:29 +0000 (18:50 -0700)]
xkbcomp: Remove listing sources
The xkbcomp listing APIs were only needed for the "xkblist" mode, which
won't be supported here.
Dan Nicholson [Sun, 29 Mar 2009 01:17:34 +0000 (18:17 -0700)]
malloc/misc/xkb: Coding style cleanup
Dan Nicholson [Sun, 29 Mar 2009 00:55:46 +0000 (17:55 -0700)]
Add XKBlib API to support keytypes
Added common variants of XkbComputeEffectiveMap, XkbInitCanonicalKeyTypes
and all their needed functions. A couple functions that were in alloc.c
moved to malloc.c to mirror the libX11 sources better.
Original code in
libX11/src/xkb/XKBMalloc.c
libX11/src/xkb/XKBMisc.c
libX11/src/xkb/XKB.c
Dan Nicholson [Sat, 28 Mar 2009 23:21:25 +0000 (16:21 -0700)]
geom: Coding-style cleanup
Dan Nicholson [Sat, 28 Mar 2009 23:08:46 +0000 (16:08 -0700)]
Add geometry Compute API from XKBlib
A small needed subset from libX11/src/xkb/XKBGeom.c.
Dan Nicholson [Sat, 28 Mar 2009 22:51:06 +0000 (15:51 -0700)]
Add xkbcommon macro for XkbKSIsKeypad and XkbKSIsDeadKey(k)
IsKeypad is used in symbols, but we'll just grab them both. It might be
better to split parts of XKBfile.h out eventually.
Dan Nicholson [Sat, 28 Mar 2009 22:32:51 +0000 (15:32 -0700)]
Add XkbModIndexText replacement
Now, I think we should have all the *Text functions we need.
Dan Nicholson [Sat, 28 Mar 2009 22:24:06 +0000 (15:24 -0700)]
Drop another unneeded format argument
Almost cleared of XkbMessage...
Dan Nicholson [Sat, 28 Mar 2009 22:12:30 +0000 (15:12 -0700)]
Add VMod Text functions from xkbfile
Dan Nicholson [Sat, 28 Mar 2009 19:39:21 +0000 (12:39 -0700)]
Copy XkbAddGeom* functions from XKBlib
These are needed by the geometry compiler in xkbcomp.
Dan Nicholson [Sat, 28 Mar 2009 19:03:35 +0000 (12:03 -0700)]
xkbcomp: s/XStringToKeysym/XkbcStringToKeysym/
Dan Nicholson [Sat, 28 Mar 2009 18:56:35 +0000 (11:56 -0700)]
Expose all the geometry allocation subroutines
We need a couple in xkbcomp, but they might also be needed externally,
too.
Dan Nicholson [Sat, 28 Mar 2009 18:45:05 +0000 (11:45 -0700)]
xkbcomp: Use xkbcommon allocation functions
s/XkbAlloc/XkbcAlloc/ so we don't know XKBlib.
Dan Nicholson [Sat, 28 Mar 2009 21:09:36 +0000 (14:09 -0700)]
Kill off usage of Display
The use of Display in xkbcomp always boiled down to passing it to
XkbInternAtom and XkbAtomGetString. This shouldn't be a problem here.
Dan Nicholson [Sat, 28 Mar 2009 21:06:26 +0000 (14:06 -0700)]
Add more *Text functions from xkbfile
This should cover all the usage in xkbcomp. The format arguments were
dropped except for the special case of XkbModMaskText, which needs to
write in XkbCFile format in HandleVModDef. This was just changed to a
Bool to avoid the need for the macros in XKBfile.h.
The function prefixes have been renamed to be unique from xkbfile.
Dan Nicholson [Sat, 28 Mar 2009 13:56:26 +0000 (06:56 -0700)]
xkbcomp: Drop unused Display argument in Atom functions
The xkbcommon Atom implementation doesn't take Display into account.
Dan Nicholson [Sat, 28 Mar 2009 13:32:08 +0000 (06:32 -0700)]
Move *Text APIs into libxkbcommon
These seem like they might be generally useful, and more will be needed
from xkbfile.
Dan Nicholson [Sat, 28 Mar 2009 03:58:27 +0000 (20:58 -0700)]
libxkbcomp: Use the internal Atom implementation
s/XkbInternAtom/XkbcInternAtom/ and s/XkbAtomGetString/XkbcAtomGetString/
Dan Nicholson [Sat, 28 Mar 2009 03:53:26 +0000 (20:53 -0700)]
libxkbcomp: s/Status/int/ since we don't have Xlib.h
Dan Nicholson [Sat, 28 Mar 2009 03:32:33 +0000 (20:32 -0700)]
libxkbcomp: Drop unused format field for *Text functions
Dan Nicholson [Sat, 28 Mar 2009 03:20:01 +0000 (20:20 -0700)]
libxkbcomp: Add non-xkbfile XkbActionTypeText
Dan Nicholson [Sat, 28 Mar 2009 03:13:22 +0000 (20:13 -0700)]
libxkbcomp: s/XPointer/char */
Replace XPointer with its definition since we don't have the privilege
of using Xlib.h. Why this is char * and not void *, I'll never know.
Dan Nicholson [Sat, 28 Mar 2009 03:01:32 +0000 (20:01 -0700)]
libxkbcomp: s/XkbDescPtr/XkbcDescPtr/
We need to use the keyboard description structure from XKBcommon.h since
it doesn't have the Display field.
Dan Nicholson [Sat, 28 Mar 2009 02:54:50 +0000 (19:54 -0700)]
libxkbcomp: Eradicate XkbFileInfo usage
The only real usage was in the frontend to generate a .xkm file. The
rest of the code just operated on the attached XkbDescPtr. Note that
here we've replaced the usage of the defined field in CompileKeymap with
the equivalent field in a XkbcDescPtr.
Dan Nicholson [Sat, 28 Mar 2009 02:30:11 +0000 (19:30 -0700)]
libxkbcomp: Include X.h and Xdefs.h for Atom and Bool
Dan Nicholson [Sat, 28 Mar 2009 02:25:14 +0000 (19:25 -0700)]
libxkbcomp: Remove usage of client-side headers
This will surely break things. Let's see just what we need to replace.
Dan Nicholson [Sat, 28 Mar 2009 01:55:13 +0000 (18:55 -0700)]
xkbcomp: Add non-xkbfile XkbConfigText
Dan Nicholson [Sat, 28 Mar 2009 01:43:29 +0000 (18:43 -0700)]
Ignore files for xkbcomp
Dan Nicholson [Sat, 28 Mar 2009 01:43:12 +0000 (18:43 -0700)]
Ignore ks_tables.h in makekeys directory now
Dan Nicholson [Fri, 27 Mar 2009 13:55:32 +0000 (06:55 -0700)]
Import xkbcomp sources for CompileKeymap
A copy of the xkbcomp sources (except the frontend) have been copied in
to provide a means to compile a XkbDescPtr. This definitely doesn't
build or do the right thing yet.
Dan Nicholson [Thu, 26 Mar 2009 13:50:33 +0000 (06:50 -0700)]
Move ks_tables.h build into makekeys subdirectory
This avoids the BUILT_SOURCES weirdness and forcing the build into the
makekeys subdirectory. Added a new make variable KS_HEADERS that lists
all the keysym headers we're going to parse.
Dan Nicholson [Tue, 17 Mar 2009 13:19:56 +0000 (06:19 -0700)]
Use X extern "C" guards around function declarations for public header
Dan Nicholson [Thu, 26 Mar 2009 02:17:33 +0000 (19:17 -0700)]
atom: Coding-style cleanup and refactor
Some coding style nits were cleaned up. Additionally, most of the
functions have been collapsed from the libxkbfile version where there's
distinction with the Xlib atom functions when Display was set. Finally,
the InitAtoms function tests whether the table has already been created
by testing the pointer rather than using a static int.
Dan Nicholson [Thu, 26 Mar 2009 02:00:49 +0000 (19:00 -0700)]
Borrow atom implementation from libxkbfile
We need an atom implementation not relying on XInternAtom and friends.
The original code is in
libxkbfile/src/xkbatom.c
Dan Nicholson [Wed, 25 Mar 2009 22:41:21 +0000 (15:41 -0700)]
alloc/galloc: Coding style cleanup
Mostly tab-to-space conversion plus a few style nits. Dropped the
register keywords as I'm pretty sure modern compilers can be trusted to
do the right thing.