Ivan Furs [Mon, 6 Mar 2017 10:18:46 +0000 (19:18 +0900)]
eina_file: delete handle->fm(handel of function CreateFileMapping)
Summary: CreateFileMapping return handle. The handle before use is always closed. This handle can be immediately closed after use.
Reviewers: cedric, raster, vtorri, rimmed, an.kroitor, FurryMyad, NikaWhite
Reviewed By: raster
Subscribers: artem.popov, cedric, jpeg
Tags: #windows
Differential Revision: https://phab.enlightenment.org/D4699
Ivan Furs [Mon, 6 Mar 2017 08:38:13 +0000 (17:38 +0900)]
eet_lib: changed unlink to eina_file_unlink
Summary: changed unlink to eina_file_unlink
Reviewers: cedric, raster, an.kroitor, rimmed, FurryMyad, NikaWhite, vtorri
Subscribers: artem.popov, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4698
Jean-Philippe Andre [Mon, 6 Mar 2017 07:45:24 +0000 (16:45 +0900)]
evas: Fix non-disappearance of text entry cursor
The mouse cursor in a text entry tends to not disappear even when
the mouse moves out of the entry. This seems to happen more when
the cursor was visible for a single frame only (although I'm not
100% sure about this condition).
One important difference with previous versions of EFL is that
the cursor is now part of the theme, so it is an image object
and not set by the compositor (it looks vastly different).
Anyway, when processing the list of pending_objects, we look at
the flags render_pre and rect_del which were (re)set during the
previous frame. Those flags are then (re)set during phase 1 which
happens after processing the pending objects list... only if
needed. So, phase 1 sets the condition to invalidate the current
lists of objects but that condition is checked for before phase 1.
This patch adds a check on delete_me which should hopefully make
it a rare enough case, for performance, but still force correct
rendering.
This is all spaghetti code, sorry if this explanation also reads
like pasta.
Note that exactness tests may still be broken because earlier
versions of EFL simply did not have the cursor inside the canvas
itself.
Fixes T5231
Jean-Philippe Andre [Thu, 2 Mar 2017 11:37:32 +0000 (20:37 +0900)]
tests: Remove CPU affinity from all threads
I believe that all the threads created in our test suite should
be spawned without any special CPU affinity. The default parameter
is not 0 (corresponds to the first CPU, known as CPU 0) but -1.
Similarily the default priority is NORMAL (1), not 0 (URGENT).
This also affects two unused code paths: evas render2 and gl preload.
@fix
Jiyoun Park [Mon, 6 Mar 2017 03:39:53 +0000 (12:39 +0900)]
ecore_evas_extn: add shared lock mode to the ecore_extn.
Currently, ecore_evas_extn only use exclusive lock.
so if there are many ecore_extn_plugs , there is competition among the ecore_extn_plugs.
since the ecore_extn_plugs dont need to use exclusive lock, add the shred lock mode.
Andy Williams [Sat, 4 Mar 2017 15:39:24 +0000 (15:39 +0000)]
elm_code: Fix missing syntax for .eo files
This was accidentally removed in the transition from edi.
using text/x-eolian which is not well reported by the FS yet.
@fix
Derek Foreman [Thu, 2 Mar 2017 21:50:24 +0000 (15:50 -0600)]
ecore_evas_wayland: fix session recovery crash with async render
We need a display unset path for software render to prevent an async
render completing after a disconnect from posting a frame and crashing
us.
As of this commit both software and gl session recovery work for me.
fix T5005
#SessionRecoveryWorksHere
Derek Foreman [Fri, 3 Mar 2017 19:13:14 +0000 (13:13 -0600)]
ecore_evas_wayland: Use surface from engine info
Calling ecore_wl2_window_surface_get() has the side effect of creating
a new wayland surface if we don't already have one. If we do that
during a session recovery, we can try to create a new surface while
we have no connection to a compositor - that's Bad.
So we just use the one we already have stored - which we NULL out on
disconnect.
Derek Foreman [Fri, 3 Mar 2017 19:04:06 +0000 (13:04 -0600)]
wayland_egl: recreate outbuf on session restore
If we get an eng_update with no outbuf, try to create one.
Derek Foreman [Fri, 3 Mar 2017 19:03:24 +0000 (13:03 -0600)]
wayland_egl: Destroy the outbuf when we lose our surface
This way we properly shut down when we get disconnected from the
compositor, and can reconnect later.
Derek Foreman [Fri, 3 Mar 2017 19:01:23 +0000 (13:01 -0600)]
wayland_egl: Don't crash when asked to dump with no outbuf
Another session recovery corner case.
Derek Foreman [Fri, 3 Mar 2017 18:58:30 +0000 (12:58 -0600)]
wayland_egl: Don't crash if gl context queried when no outbuf
We can get here on session restore when we haven't had a chance
to recreate the outbuf yet.
Derek Foreman [Fri, 3 Mar 2017 18:45:58 +0000 (12:45 -0600)]
gl_generic: Add null checks in some cache functions
When wayland session recovery happens, we can end up down this path
with no gl context when elm reprocesses its config file.
That callback fires long before we've re-set up our wayland connection
so we can't possibly have a valid gl context yet.
Prevent that from crashing.
Mike Blumenkrantz [Fri, 3 Mar 2017 16:55:44 +0000 (11:55 -0500)]
Revert "ecore: forcefully flush pending event when ecore_shutdown is called."
This reverts commit
2c6808e4eed28d5b93d2f10b558b168aa365364e.
this breaks a number of expectations and guarantees in efl:
* causes unexpected event iteration during app startup before main loop begins
- leads to event loss
* causes unexpected event iteration during app shutdown after main loop quits
- leads to invalid memory access
* causes recursive event iteration during event handler callbacks
- leads to ?????????????????????????????????????????????????????????????????
all of these can be easily seen by running enlightenment, and all of these cause
unexpected behaviors in enlightenment including, but not limited to, a lot of crashes
fix T5232
Daniel Kolesa [Fri, 3 Mar 2017 16:51:50 +0000 (17:51 +0100)]
docgen: run types/vars together with classes in parallel script
Daniel Kolesa [Fri, 3 Mar 2017 16:43:19 +0000 (17:43 +0100)]
docgen: add a simple script that does doc generation in parallel
Daniel Kolesa [Fri, 3 Mar 2017 16:34:30 +0000 (17:34 +0100)]
docgen: only parse the necessary class when generating only one
Daniel Kolesa [Fri, 3 Mar 2017 15:36:47 +0000 (16:36 +0100)]
docgen: do not generate foreign classes' functions and events
Only generate the classes' own funcs/events (and overridden). Let other
classes generate their own stuff. This prevents some files from being
generated multiple times, which more than halves generation time.
Daniel Kolesa [Fri, 3 Mar 2017 15:26:04 +0000 (16:26 +0100)]
docgen: add a pass to generate individual classes
Daniel Kolesa [Fri, 3 Mar 2017 15:18:21 +0000 (16:18 +0100)]
docgen: add clist pass to list all classes
Daniel Kolesa [Fri, 3 Mar 2017 15:16:05 +0000 (16:16 +0100)]
docgen: initial support for multipass gen
Daniel Kolesa [Fri, 3 Mar 2017 14:53:31 +0000 (15:53 +0100)]
docgen: move stats and keyref build into later stage
That way we can multipass the doc build without worrying about stats.
Jiyoun Park [Fri, 3 Mar 2017 03:44:35 +0000 (12:44 +0900)]
ecore_evas_wayland: remove useless code
Jiyoun Park [Fri, 3 Mar 2017 02:28:52 +0000 (11:28 +0900)]
ecore_evas_wayland: remove useless code
Jiyoun Park [Fri, 3 Mar 2017 01:27:00 +0000 (10:27 +0900)]
ecore_evas_wayland: fix bug ee's width and height were updated wrong place.
ecore evas manages the width and height using the ee->w/h and ee->req.w/h.
but sometimes only ee->req value can be updated.
Jihoon Kim [Fri, 3 Mar 2017 01:12:28 +0000 (10:12 +0900)]
ecore_imf/xim: Fix memory leak
64 bytes in 1 blocks are definitely lost in loss record 152 of 258
at 0x4C2AB80: malloc (vg_replace_malloc.c:296)
by 0xC786A77: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
by 0xC78747B: _XimDecodeIMATTRIBUTE (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
by 0xC77A7EF: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
by 0xC767771: XGetIMValues (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
by 0x113CFE09: ???
by 0x113D08F7: ???
by 0x83DD329: ecore_imf_context_client_window_set (ecore_imf_context.c:240)
by 0x530779D: _edje_entry_real_part_init (edje_entry.c:2937)
by 0x5311C20: _edje_object_file_set_internal (edje_load.c:1079)
by 0x5328665: _edje_object_efl_file_mmap_set (edje_smart.c:438)
by 0x775BD3A: efl_file_mmap_set (in /usr/local/lib/libefl.so.1.18.4)
Marcel Hollerbach [Thu, 2 Mar 2017 17:32:40 +0000 (18:32 +0100)]
ecore_thread: do not override the data field of a thread
otherwise a currently executed ecore_thread is going to pass a complete
wrong data to its callbacks.
fix T5175
fix T5173
Guilherme Iscaro [Thu, 2 Mar 2017 19:06:15 +0000 (11:06 -0800)]
Efl.Canvas.Object: Multi-seat API should not be exposed to legacy.
Summary: This new kind of APIs should be EO only.
Reviewers: jpeg, cedric, barbieri, bdilly, stefan_schmidt
Reviewed By: cedric, barbieri
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4696
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Kolesa [Thu, 2 Mar 2017 15:34:22 +0000 (16:34 +0100)]
docgen: add info about protected/private methods/properties in listing
jiin.moon [Thu, 2 Mar 2017 06:53:03 +0000 (15:53 +0900)]
evas: Fix double clipping issue with map
If object's parent has map and object also has map, the evas
clip would be applied twice.
The context already applied clip area when drawing on map_surface.
So don't need more clipping when drawing map_image.
Also, make sure to apply the framespace clip when drawing the map
surface onto the final canvas. Thanks @jiin.moon for the initial
patch (see D4694).
@fix
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Jiwon Kim [Thu, 2 Mar 2017 06:36:00 +0000 (15:36 +0900)]
genlist: Remove weird behavior about item_show, bring_in
Summary:
When if item_show / bring_in is proceeded as 'deferred_show'
sequence, Scrollto_Type does not be checked perfectly.
As a result,
ELM_GENLIST_ITEM_SCROLLTO_NONE and any other integer values
are worked such as ELM_GENLIST_ITEM_SCROLLTO_BRING_IN.
As doxygen of Elm_Genlist_Item_Scrollto_Type,
ELM_GENLIST_ITEM_SCROLLTO_NONE and other incorrect number
should not work.
Fixes T4854
@fix
Reviewers: SanghyeonLee, woohyun, jpeg
Reviewed By: jpeg
Subscribers: id213sin, conr2d, cedric
Maniphest Tasks: T4854
Differential Revision: https://phab.enlightenment.org/D4684
Carsten Haitzler (Rasterman) [Thu, 2 Mar 2017 06:29:54 +0000 (15:29 +0900)]
emotion - fix empty video data frame update when using vdpau accel
fixes a segfault when using vdpau+gst and where the first frame seems to
be empty/zero.
@fix
Jeeyong Um [Thu, 2 Mar 2017 05:59:34 +0000 (14:59 +0900)]
doc: Fix invalid group classification for Edje_Audio
Summary: Edje_Audio group should belong to Edje group.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D4693
Bryce Harrington [Thu, 2 Mar 2017 02:52:22 +0000 (11:52 +0900)]
ecore: Fix typo in error message
Reviewers: cedric, jpeg
Reviewed By: jpeg
Subscribers: jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D4689
Jihoon Kim [Thu, 2 Mar 2017 01:19:53 +0000 (10:19 +0900)]
ecore_imf/ibus: Fix memory leak allocated by ibus_bus_new
Derek Foreman [Wed, 1 Mar 2017 20:39:32 +0000 (14:39 -0600)]
ecore-evas-wayland: Fix yet another wayland session recovery break
commit
81783ec75caf4e4314abd8baf362718379b86570 combined two "identical"
pieces of code that weren't identical. The removed code never checked
if the evas was visible before performing operations to make it so,
the code left behind would bail if the evas was visible.
Reset the visible status during disconnect to make sure we properly show
windows after a session recovery.
ref https://phab.enlightenment.org/T5005
@fix
Session works on the software engines at this point. Use this as a bisect
point next time someone fubars it.
GL still broken. Window geometry seems like it doesn't get updated right
either, but at least clients reconnect again.
#SessionRecoveryWorksHere
Derek Foreman [Wed, 1 Mar 2017 19:49:02 +0000 (13:49 -0600)]
ecore_wl2: Fix a wayland session recovery breaker... again
We need to bind a shell on reconnect, but
dfb2af697 made sure
we only bind a single shell per wayland display for the life of
the display object - which lives longer than the connection.
That means when session recovery tries to reconnect it never bothers
to bind a shell, so the client can never post buffers.
ref https://phab.enlightenment.org/T5226
ref https://phab.enlightenment.org/T5005
@fix
Chris Michael [Wed, 1 Mar 2017 18:14:50 +0000 (13:14 -0500)]
Revert "ecore-wl2: Send surface_commit after ack_configure"
Reverting this as apparently one source says to send a commit after
ack_configure, and another source says its wrong...
This reverts commit
1187035fe669d2bfc77f600d2e5a8700eb1ff194.
Chris Michael [Wed, 1 Mar 2017 18:13:46 +0000 (13:13 -0500)]
Revert "ecore-evas-wayland: Don't register animators until window gets shown"
Reverting this as apparently it broke session recovery for some odd
ass reason...
This reverts commit
38f3854f45bcfca566feee882919d7a66f92ce13.
Chris Michael [Wed, 1 Mar 2017 17:08:09 +0000 (12:08 -0500)]
ecore-wl2: Fix efl apps crashing on close in wayland
Commit
c6b59be1da ensured display cleanup after roundtrips, however we
cannot call the display_cleanup function After the display has been
disconnected ... oopsie. Essentially the call to the cleanup function
was in the wrong place here so fix.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 1 Mar 2017 16:43:11 +0000 (11:43 -0500)]
ecore-evas-wayland: Remove duplicated code
As we already call the same functions inside
_ecore_evas_wl_common_show, there is no need to duplicate the same
code when we have defer_show set...just call the show function.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 1 Mar 2017 16:30:15 +0000 (11:30 -0500)]
ecore-evas-wayland: Fix issue of apps not starting up in fullscreen mode
Calls to make a window fullscreen do require the window to already
have a shell surface with which to fullscreen. If an app sets the
window fullscreen property when the window is not shown yet, then the
app would never startup fullscreen. This patch fixes that issue by
adding a 'defer_fullscreen' flag to Ecore_Evas (wayland) so that when
the window does finally get shown, we can show it in fullscreen.
Addresses part of the T5044 ticket...
ref T5044
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 1 Mar 2017 15:50:52 +0000 (10:50 -0500)]
ecore: Don't use logging domains with spaces
Small patch to change the name of the ecore_animator logging domain.
Names with spaces in them make it impossible to export
EINA_LOG_LEVELS_GLOB inside a bashrc
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 1 Mar 2017 15:25:35 +0000 (10:25 -0500)]
ecore-wl2: Send surface_commit after ack_configure
Small patch to ensure we send a surface commit after sending the
ack_configure. This fixes an issue where E-WL internal windows would
not maximize.
Fixes T5192
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 1 Mar 2017 13:32:18 +0000 (08:32 -0500)]
ecore-wl2: Ensure display cleanup after roundtrips
Commit
ee52a28d041dfb02da0f2deca0714beb5eaa51fd added a roundtrip to
ensure and pending wl events were handled before we disconnected the
display. While this ensures some things like session recovery destroy
work again, it lead to an issue where the _ecore_wl2_display_cleanup
function was called BEFORE we processed pending events. This (in turn)
causes crashes due to processing of pending events that relied on
things like Ecore_Wl2_Input existing. As the display cleanup function
clears inputs & outputs, we need to defer calling that until the
display_roundtrip has dispatched and handled pending events.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Derek Foreman [Tue, 28 Feb 2017 23:23:03 +0000 (17:23 -0600)]
elm_cnp: allocate space for null terminator in _wl_targets_converter
strcat needs room for a string terminator.
Cedric BAIL [Tue, 28 Feb 2017 19:01:09 +0000 (11:01 -0800)]
ecore: improve debugging of animator.
Cedric BAIL [Tue, 28 Feb 2017 00:56:45 +0000 (16:56 -0800)]
ecore_evas: rely as much as possible on display source for animator to reduce spurious tick.
Chris Michael [Tue, 28 Feb 2017 17:36:05 +0000 (12:36 -0500)]
ecore-wl2: Cleanup function for finding global
As per Mike, the iterator macro already does the casting for us, so we
can cleanup the code here and not do casting, plus we can remove an
extra variable...bonus ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 17:28:02 +0000 (12:28 -0500)]
ecore-wl2: Use EINA_ITERATOR_FOREACH macro
Small patch to change from while (iterator) to using the
EINA_ITERATOR_FOREACH macro...that I had forgotten about...thanks Mike
;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 17:17:02 +0000 (12:17 -0500)]
ecore-wl2: Ensure we only bind one wayland shell
This patch adds prioritizing to our wayland shell binding code so that
we only bind One shell that the compositor advertises. During the
global_add callback, the shells get added to the 'globals' hash, and
when sync is done, we will search for shells to bind based on priority
so that we can ensure we always bind to the latest supported shell.
ref T5226
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 16:37:15 +0000 (11:37 -0500)]
Revert "ecore-wl2: Only bind one shell"
Reverting this in favor of a better approach (using a priority list)
as discussed on IRC.
This reverts commit
0e93f03636ec10710547513fb865ef2703e937a4.
Chris Michael [Tue, 28 Feb 2017 16:29:24 +0000 (11:29 -0500)]
elementary: Don't update opaque/input regions if not visible
Small patch to reduce calls to setting opaque/input regions in
wayland. Basically, if the window is not shown then there is no point
in updating these regions until such time that the window is actually
visible and the regions will get committed.
ref T5226
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 15:22:58 +0000 (10:22 -0500)]
ecore-imf-wayland: Reduce calls to set_cursor_rectangle
Avoid calls to zwp_text_input_v1_set_cursor_rectangle if we do not
need to. Previous code here would always call this function even if
the cursor rectangle was in the same position. Now we set a flag on
the cursor_location field to let us know that it needs updating.
ref T5226
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 15:12:31 +0000 (10:12 -0500)]
ecore-wl2: Actually update input/opaque regions
Previous commit
f8f71d05cdc7a8578329f75b0101662220390f20 to avoid resetting
opaque & input regions was not totally complete as it did not update
the actual values...small patch to fix that.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 14:28:24 +0000 (09:28 -0500)]
ecore-imf-wayland: Remove duplicate header include
wayland_imcontext.h already includes this header, so no need to
re-include. Also add missing (void) to function declaration
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 14:16:22 +0000 (09:16 -0500)]
ecore-imf-wayland: Formatting fixes
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 13:51:21 +0000 (08:51 -0500)]
ecore-wl2: Avoid resetting opaque & input regions if they match
Small patch to avoid setting the same opaque/input regions if they
already match what is being requested.
ref T5226
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 28 Feb 2017 13:40:26 +0000 (08:40 -0500)]
ecore-wl2: Only bind one shell
Since we only ever use One shell at a time, let's not bind all of them
as that is useless.
ref T5226
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Marcel Hollerbach [Tue, 28 Feb 2017 10:46:56 +0000 (11:46 +0100)]
eina: move the _eina_main_loop set before we init anything
otherwise we could get into problems.
fix T4891
@fix
Jean-Philippe Andre [Tue, 28 Feb 2017 07:24:05 +0000 (16:24 +0900)]
eina_value: Fix min/max values of long for Windows
long is 32 bit on Windows (both 32, 64 bit).
I wonder why eina_value doesn't simply use LONG_MIN/MAX O_o
Fixes T5204
Flavio Ceolin [Tue, 28 Feb 2017 07:00:45 +0000 (16:00 +0900)]
eina:list: Fix resource leak
Summary:
The usage of the macro EINA_MAGIC_CHECK_LIST can
lead (in some cases) to leaks.
Signed-off-by: Flavio Ceolin <flavio.ceolin@gmail.com>
Reviewers: jpeg
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4679
Jean-Philippe Andre [Tue, 28 Feb 2017 04:04:31 +0000 (13:04 +0900)]
evas: Reset state to GL_TEXTURE_2D
This should fix an ERR message under gl_drm and probably an
actual bug.
This reverts
8f2cfdf4900e8e8b13f48c213512041e5f.
I don't think the texture target should be part of the context
information. It should instead be a property of the texture.
Fixes T5171
Bryce Harrington [Tue, 28 Feb 2017 02:41:12 +0000 (11:41 +0900)]
evas: Drop duplicate macro definitions SETUP_LINE_*
Summary:
SETUP_LINE_SHALLOW and SETUP_LINE_STEEP are each identically defined
(except whitespace) in evas_line_main.c
Reviewers: cedric, jpeg
Subscribers: jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D4681
Jihoon Kim [Tue, 28 Feb 2017 02:24:39 +0000 (11:24 +0900)]
ecore_imf/ibus: fix memory leak
Cedric BAIL [Mon, 27 Feb 2017 23:12:11 +0000 (15:12 -0800)]
ecore_evas: animator eo event are not a legacy event.
Cedric BAIL [Mon, 27 Feb 2017 23:03:49 +0000 (15:03 -0800)]
edje: reorder shutdown to match internal event emit use.
We do have event emited that rely on evas still being initialized.
If we shutdown evas and then process ecore event, we would be in trouble.
Cedric BAIL [Mon, 27 Feb 2017 23:01:34 +0000 (15:01 -0800)]
ecore: forcefully flush pending event when ecore_shutdown is called.
If a component emit Ecore_Event and they aren't processed before the
call it call ecore_shutdown, there is no way to prevent this event
from being triggered after the component at shutdown itself. Which
may well lead to a use after free case. As we don't know which event
are pending and we also are not shuting down ecore completely as they
are still other component using it, we can only flush all pending event
right away.
Cedric BAIL [Mon, 27 Feb 2017 23:00:55 +0000 (15:00 -0800)]
evas: properly disable Evas_Object event catching once we can't access Evas anymore.
Cedric BAIL [Mon, 27 Feb 2017 18:13:30 +0000 (10:13 -0800)]
emile: rename emile_image_register to emile_image_callback_set.
This fix ABI report according to discussion on the mailing list.
Andy Williams [Mon, 27 Feb 2017 20:51:40 +0000 (20:51 +0000)]
elm_code: Hide the cursor when it is off screen
This resolves cursor artifacts that could be seen @fix
Chris Michael [Mon, 27 Feb 2017 18:26:11 +0000 (13:26 -0500)]
Revert "Revert "ecore-imf: Don't always load all modules""
Reverting the revert here...this Does actually work in a wayland
environment, however you may need to export ELM_DISPLAY=wl in order to
get the desired result...
NB: If you desire a specific ecore_imf module then you may want to
export ECORE_IMF_MODULE=xyz, else this patch will try to load them in
the order specified in the code (xim, ibus, scim, wayland).
This reverts commit
5c858b86e5c84d4ced77d47bb61cc6817f0e3645.
Chris Michael [Mon, 27 Feb 2017 18:12:24 +0000 (13:12 -0500)]
Revert "ecore-imf: Don't always load all modules"
Reverting this as it broke autoloading of the ecore_imf WL module.
This commit basically only loaded an X11 Ecore_Imf module even under a
wayland environment.
This reverts commit
75b4bde8d226ffb59dfad5bcdcd76ce5dde5e1ac.
Chris Michael [Mon, 27 Feb 2017 17:54:38 +0000 (12:54 -0500)]
ecore-imf: Don't always load all modules
If there is no ecore_imf_module specified in the environment, then
previous code here would load ALL the modules when we really only need
one. This patch fixes that issue...if a module is specified in the env
(export ECORE_IMF_MODULE=xyz) than that module will be loaded. If NO
module is specified in the env, then we will loop the list of built
modules and load only one.
This patch fixes an issue where running 'WAYLAND_DEBUG=1
WAYLAND_DISPLAY=wayland-0 terminology' inside an X11 environment would
cause ecore_imf to load the wayland module (as reported by Derek).
NB: If this patch breaks automatic IMF (it should not) then please feel
free to revert.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 27 Feb 2017 17:35:58 +0000 (12:35 -0500)]
elementary: Fix issue of trying to init ecore_wl2 if DISPLAY is set
Small patch to fix an issue that Derek brought up ... that is
basically, if you try:
WAYLAND_DEBUG=1 WAYLAND_DISPLAY=wayland-0 terminology while inside an
X11 environment, then elm_config would try to initialize ecore_wl2
even when running under X11.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 27 Feb 2017 16:08:43 +0000 (11:08 -0500)]
ecore-evas-wayland: Don't register animators until window gets shown
Small patch to not call _ecore_evas_register unless we are showing the
window. This stops creation of rogue animators on cursors until the
window is actually going to be shown.
Fixes T5209
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 27 Feb 2017 15:44:36 +0000 (10:44 -0500)]
elementary: Minor formatting fix
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 27 Feb 2017 15:09:34 +0000 (10:09 -0500)]
elementary: Don't set pointer object theme on start
As we are already resetting the pointer object theme when we make a
call to set the cursor, don't set it on window creation. This should
address the issue of animators getting created on window creation.
ref T5209
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Jihoon Kim [Mon, 27 Feb 2017 12:32:07 +0000 (21:32 +0900)]
ecore_imf/ibus: Fix memory leak
Jihoon Kim [Mon, 27 Feb 2017 11:28:37 +0000 (20:28 +0900)]
ecore_imf/wayland: Fix memory leak in immodule
==1321== 156 bytes in 1 blocks are definitely lost in loss record 7,687 of 9,703
==1321== at 0x4847E64: calloc (vg_replace_malloc.c:623)
==1321== by 0x92EA7E9: wayland_im_context_new (wayland_imcontext.c:1094)
==1321== by 0x92E66DD: im_module_create (wayland_module.c:132)
==1321== by 0x4D521E7: ecore_imf_module_context_create (ecore_imf_module.c:152)
==1321== by 0x4D51EF7: ecore_imf_context_add (ecore_imf_context.c:141)
Minkyu Kang [Mon, 27 Feb 2017 11:13:06 +0000 (20:13 +0900)]
elementary tooltip: adjust arrow if tooltip was moved
Summary:
If orientation is TOP, BOTTOM, LEFT and RIGHT and
tooltip was moved due to located out of screen,
adjust location of arrow so that can indicate right position.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Test Plan: elementary_test -to tooltip4
Reviewers: cedric, Hermet, jpeg
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4554
Myoungwoon Roy, Kim [Mon, 27 Feb 2017 10:48:38 +0000 (19:48 +0900)]
docs: Fix typos and some wrong expressions in Ecore and Edje API reference doxygen.
Summary: I had fixed some typos and wrong expressions, euch as capital letters, singular Etc. in Ecore and Edje API reference doxygen.
Test Plan: Doxygen Revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho, jpeg
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4677
Myoungwoon Roy, Kim [Mon, 27 Feb 2017 10:35:52 +0000 (19:35 +0900)]
docs: Fix typos and some wrong expressions
Covers: Ecore_Drm, Ecore_Evas, Ecore_File, Ecore_IMF, and
Ecore_IMF_Evas API reference doxygen.
Summary: I had fixed some typos and wrong expressions, such
as capital letters, singular Etc. in Ecore_Drm, Ecore_Evas,
Ecore_File, Ecore_IMF, and Ecore_IMF_Evas API reference doxygen.
Test Plan: Doxygen Revision
Reviewers: stefan, cedric, raster, jpeg, Jaehyun_Cho
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4680
Jean-Philippe Andre [Mon, 27 Feb 2017 05:27:24 +0000 (14:27 +0900)]
genlist: Final fix for odd/even styles issue
The key was to emit & process the signal to the edje objects
(item views) at the same time as we move them, ie. from the
loop in _item_block_position().
Also the proper counting must be used at all times. Hidden
items should not be counted.
Tree effect may still have issues but otherwise there is no
more blinking, double odd or even rows, etc... It all looks
good (as long as there is no tree effect!).
Fixes T3086
@fix
Jean-Philippe Andre [Fri, 24 Feb 2017 06:34:42 +0000 (15:34 +0900)]
genlist: Fix fileselector crazy behaviour
When using the fileselector in tree view mode (ie. expandable),
expanding any folder with a lot of files in it would cause the
genlist view to jump somewhere to the bottom. This is because
the mechanism preventing the view from moving was assuming that
all "prepend" operations meant prepending before the selected
item. This is not the case in case of expansion like in the
fileselector.
@fix
Jean-Philippe Andre [Fri, 24 Feb 2017 06:16:45 +0000 (15:16 +0900)]
genlist: Fix rare jump in prepend insert
If an item is selected, and another item is insert before
the selected item, then we try to lock the genlist view (pan)
around the selected item (if it's visible). Unfortunately,
every 16 inserts cause a jump by one line in the scroller.
That's because the scroll math assumes the block position is
known, but since it's a new block it wasn't known.
This patch fixes this issue by precalculating the block position.
Test scenario:
elementary_test -to "Genlist Tree, Insert Relative"
Select an item, clikck 50 times on "+ before".
The view should not jump.
This does not fix fileselector's craziness.
@fix
Jean-Philippe Andre [Thu, 23 Feb 2017 08:10:16 +0000 (17:10 +0900)]
genlist: (Mostly) fix item index odd/even styles
This fixes the internal item order index.
Note that groups don't reset the odd/even styles. The
original code wasn't very clear on the intent (setting
to 0 in one case, not increasing the counter in another,
but that was not consistent all over the place). I believe
resetting the odd/even styles at a group boundary would
look great, but this might be for another patch :)
This amends part of another commit, but keeps its feature:
b40a6eb85bf44a genlist: implement list position signals.
See T3086
PS: I've discovered more odd/even issues with the
fileselector in particular. Still working on it...
@fix
Jean-Philippe Andre [Thu, 23 Feb 2017 07:45:29 +0000 (16:45 +0900)]
Revert "elm_genlist: when appending items to the parent, prepend to the parent"
This reverts commit
43d82e567a2d655a089b6ca3f2d913e6ec52f1dc.
I don't understand this commit. It broke the logical order of
items, as the internal list wouldn't match the order on screen.
Other places in the code didn't seem to make this assumption
that parents come after their children. And for sure my recent
fixes require the parent to come before.
This commit was one of the many reasons why odd/even styles
look often wrong.
See T3086
Jean-Philippe Andre [Thu, 23 Feb 2017 06:52:31 +0000 (15:52 +0900)]
genlist: Remove macro GL_IT()
It was used to hide "it->item"... but was used less than it->item
itself. Explicit code here is not longer, and just as readable.
This macro I think was harmful to readability.
Simple sed, no real change at all.
Carsten Haitzler (Rasterman) [Sun, 26 Feb 2017 02:43:21 +0000 (11:43 +0900)]
evas gl common - fix nv12 text upload with upack row length
we segv'd because our testure width was wrong... i was row span
length in bytes and we use luminance+alpha texture... this fixes it.
@fix
Mike Blumenkrantz [Fri, 24 Feb 2017 19:13:13 +0000 (14:13 -0500)]
ecore: do not access 'timer_thread' global from animator thread
@fix
Mike Blumenkrantz [Fri, 24 Feb 2017 19:13:13 +0000 (14:13 -0500)]
ecore-evas: use ee->prop.window in ecore_evas_input_event_register()
this allows window events to match correctly
@fix
Mike Blumenkrantz [Fri, 24 Feb 2017 19:13:13 +0000 (14:13 -0500)]
ecore-evas: handle pointer_warp() for buffer canvas
this was missing and would do nothing when called
Mike Blumenkrantz [Fri, 24 Feb 2017 19:13:13 +0000 (14:13 -0500)]
ecore-evas: handle pointer_xy_get() for buffer canvas
this was missing and would do nothing when called
Mike Blumenkrantz [Fri, 24 Feb 2017 19:13:13 +0000 (14:13 -0500)]
ecore-evas: handle screen_geom_get() for buffer canvas
this was missing and would do nothing when called
Daniel Kolesa [Fri, 24 Feb 2017 16:17:52 +0000 (17:17 +0100)]
docgen: fix broken inheritance graphs
Daniel Kolesa [Fri, 24 Feb 2017 16:12:28 +0000 (17:12 +0100)]
docgen: more useful event listing
Daniel Kolesa [Fri, 24 Feb 2017 15:24:36 +0000 (16:24 +0100)]
docgen: disregard override info for displaying property get/set
Daniel Kolesa [Fri, 24 Feb 2017 15:10:00 +0000 (16:10 +0100)]
docgen: minor speed optimizations and cleanups
Daniel Kolesa [Fri, 24 Feb 2017 14:47:25 +0000 (15:47 +0100)]
docgen: merge overridden and other categories for methods/properties