bsalomon@google.com [Wed, 27 Feb 2013 18:43:47 +0000 (18:43 +0000)]
Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads.
We were assigning color to oldColor but it in turn would never be read because the valid flags
would be cleared.
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
12313150
git-svn-id: http://skia.googlecode.com/svn/trunk@7886
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 27 Feb 2013 18:35:16 +0000 (18:35 +0000)]
Change SkTileGride geometry calculations to match the Chromium compositor.
This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.
Companion Chromium CL required for roll: https://codereview.chromium.org/
12221077/
TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/
7350050
git-svn-id: http://skia.googlecode.com/svn/trunk@7885
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 17:46:09 +0000 (17:46 +0000)]
Revert r7883
git-svn-id: http://skia.googlecode.com/svn/trunk@7884
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 27 Feb 2013 16:54:44 +0000 (16:54 +0000)]
Use SkSet to fix issue when pdf generates an exp number of resources.
The problem fixed - http://code.google.com/p/skia/issues/detail?id=940 - is that getResources will recursively obtain all child resource recursively without checking for duplicates.
If we have lots of duplicates, then we try to build a very large vector (exponential with the number of nodes usually) and sooner or later we end up using too much memory and crash.
A possible solution could have been to make sure resources do not have duplicates, but that requirement is impractical, and it this leaves the solution fragile, if there is any issue in the tree, we crash.
When we emit the pdf, the large number of duplicates is not an issue, because SkPDFCatalog::addObject will deal with duplicates.
I have run the gm with --config pdf, and the images are 100% same bits, while the pdfs have the same size but some very small changes, the order of some objects.
Review URL: https://codereview.appspot.com/
6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7883
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 27 Feb 2013 16:43:49 +0000 (16:43 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported
https://codereview.appspot.com/
7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7882
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 27 Feb 2013 15:41:12 +0000 (15:41 +0000)]
GM : Unused parameters cleanup
I removed unused parameters in the gms wherever it was trivial to do so. I'm
trying to get the easy ones out of the way before we get into more involved
discussions around this.
Review URL: https://codereview.appspot.com/
7398056
git-svn-id: http://skia.googlecode.com/svn/trunk@7881
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 27 Feb 2013 14:12:55 +0000 (14:12 +0000)]
Build freetype as a standalone_static_library
Needed by external applications which don't use our libraries in-place.
Review URL: https://codereview.chromium.org/
12328138
git-svn-id: http://skia.googlecode.com/svn/trunk@7879
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:35 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7878
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:22 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7877
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 27 Feb 2013 13:24:12 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@7876
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 27 Feb 2013 07:10:10 +0000 (07:10 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7875
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 22:58:09 +0000 (22:58 +0000)]
fix getFamilyName by calling FcFreeTypeQuery
git-svn-id: http://skia.googlecode.com/svn/trunk@7874
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 26 Feb 2013 21:56:19 +0000 (21:56 +0000)]
Fixed sk_getMetrics_utf32_xy function
The unused parameters x and y here seems to be a mistake.
Review URL: https://codereview.appspot.com/
7386055
git-svn-id: http://skia.googlecode.com/svn/trunk@7873
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Use glGetStringi to get extensions when available.
Review URL: https://codereview.chromium.org/
12328111
git-svn-id: http://skia.googlecode.com/svn/trunk@7872
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:11:07 +0000 (17:11 +0000)]
implement CreateTypefaceFromFile
git-svn-id: http://skia.googlecode.com/svn/trunk@7869
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 17:01:26 +0000 (17:01 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7868
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 16:57:16 +0000 (16:57 +0000)]
move SampleTypeface into gm/typefacestyles
git-svn-id: http://skia.googlecode.com/svn/trunk@7867
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 26 Feb 2013 16:25:04 +0000 (16:25 +0000)]
Whitespace change to test commit-queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12328109
git-svn-id: http://skia.googlecode.com/svn/trunk@7866
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 26 Feb 2013 16:01:21 +0000 (16:01 +0000)]
Removing blank lines from codereview.settings.
depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/
7388061
git-svn-id: http://skia.googlecode.com/svn/trunk@7865
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 26 Feb 2013 15:56:05 +0000 (15:56 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7864
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 26 Feb 2013 15:50:51 +0000 (15:50 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7863
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 15:40:01 +0000 (15:40 +0000)]
Rename template param to SkSTArray to be consistent with its base class, SkTArray.
R=jvanverth@google.com
Review URL: https://codereview.appspot.com/
7372050
git-svn-id: http://skia.googlecode.com/svn/trunk@7862
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 14:45:41 +0000 (14:45 +0000)]
Add files omitted from gcl change in r7860.
git-svn-id: http://skia.googlecode.com/svn/trunk@7861
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 26 Feb 2013 14:34:43 +0000 (14:34 +0000)]
Consolidate functions common the the null and debug GL interfaces.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
7400053
git-svn-id: http://skia.googlecode.com/svn/trunk@7860
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 26 Feb 2013 13:13:44 +0000 (13:13 +0000)]
Whitespace change to test commit queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12326121
git-svn-id: http://skia.googlecode.com/svn/trunk@7859
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 26 Feb 2013 12:01:28 +0000 (12:01 +0000)]
Pointing CODE_REVIEW_SERVER to Chromium Rietveld.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/
7382058
git-svn-id: http://skia.googlecode.com/svn/trunk@7858
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 26 Feb 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7857
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 22:19:20 +0000 (22:19 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7856
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 21:47:41 +0000 (21:47 +0000)]
Fix a bunch of warnings, mainly around rowBytes.
My recent change changed the way SkBitmap::fRowBytes is stored,
and parameter/return values referring to rowBytes were changed
to type size_t. Change the storage back, and eliminate warnings
resulting from returning a size_t.
Review URL: https://codereview.appspot.com/
7396059
git-svn-id: http://skia.googlecode.com/svn/trunk@7855
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 21:02:21 +0000 (21:02 +0000)]
remove duplicate impl for getFileName() on SkFDStream
git-svn-id: http://skia.googlecode.com/svn/trunk@7854
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Mon, 25 Feb 2013 20:42:44 +0000 (20:42 +0000)]
Fixed the hash key comparison function.
Review URL: https://codereview.appspot.com/
7378065
git-svn-id: http://skia.googlecode.com/svn/trunk@7853
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 20:38:07 +0000 (20:38 +0000)]
check-point: skiafy SkFontHost_fontconfig from chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@7852
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 20:24:24 +0000 (20:24 +0000)]
add --tmpDir foo option to tests, to allow unittests that want to write/read files
use tmpDir in SkStream tests
git-svn-id: http://skia.googlecode.com/svn/trunk@7851
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 25 Feb 2013 20:12:45 +0000 (20:12 +0000)]
Give GrDrawTarget a back ptr to its owning GrContext.
Review URL: https://codereview.appspot.com/
7395055
git-svn-id: http://skia.googlecode.com/svn/trunk@7850
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 25 Feb 2013 20:07:24 +0000 (20:07 +0000)]
Add an SkSet class to be used by Pdf only, for now - reverted because of triggering heap corruption on Win7, original coe review: https://codereview.appspot.com/
6749054
git-svn-id: http://skia.googlecode.com/svn/trunk@7849
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:46:11 +0000 (18:46 +0000)]
don't #include <unistd.h> if we're windows
git-svn-id: http://skia.googlecode.com/svn/trunk@7848
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:41:26 +0000 (18:41 +0000)]
don't try to access filedescriptors on windows
git-svn-id: http://skia.googlecode.com/svn/trunk@7847
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Feb 2013 18:17:12 +0000 (18:17 +0000)]
move SkFDStream out of images into core
git-svn-id: http://skia.googlecode.com/svn/trunk@7846
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 16:05:00 +0000 (16:05 +0000)]
Remove bogus ability for creating an SkPicturePlayback to fail.
Change SkPicturePlayback::parseBufferTag to return void, since
it can never return false.
Change SkPicturePlayback::parseStreamTag to return void, since
the only way it can return false is if parseBufferTag returns
false, or if creating a sub picture failed, both of which are
nonsensical.
Due to the above, there is no reason for creating an
SkPicturePlayback to fail, so remove the isValid parameter.
Update subclasses in SkDebuggerGUI.
Review URL: https://codereview.appspot.com/
7388050
git-svn-id: http://skia.googlecode.com/svn/trunk@7844
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 25 Feb 2013 16:02:36 +0000 (16:02 +0000)]
Use size_t for rowBytes.
Previously, we were using uint32_t sometimes, int sometimes, and
size_t sometimes. Switch to using size_t, since we are actually
talking about a number of bytes.
In copyPixelsTo, use 0 as a flag to use the internal rowBytes,
which is more consistent with setConfig.
Review URL: https://codereview.appspot.com/
7370047
git-svn-id: http://skia.googlecode.com/svn/trunk@7843
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 25 Feb 2013 15:55:13 +0000 (15:55 +0000)]
Always round text position correctly.
https://codereview.appspot.com/
7383049/
Will require rebaseline of fontscaler GM.
Must add SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX to Chromium
until ~150 layout tests can be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@7842
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Feb 2013 13:32:31 +0000 (13:32 +0000)]
Whitespace change to test commit queue
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/
12340051
git-svn-id: http://skia.googlecode.com/svn/trunk@7841
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 25 Feb 2013 01:38:01 +0000 (01:38 +0000)]
Fixed '#if with no expression' warning/error
git-svn-id: http://skia.googlecode.com/svn/trunk@7840
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 23 Feb 2013 07:02:45 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7839
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 22:37:31 +0000 (22:37 +0000)]
Fix debugger build.
Review URL: https://codereview.appspot.com/
7375050
git-svn-id: http://skia.googlecode.com/svn/trunk@7838
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 22:04:19 +0000 (22:04 +0000)]
Remove SkSerializationHelpers.
Move the function definition for EncodeBitmap to SkPicture,
where InstallPixelRefProc has already moved (and where it is
relevant).
Review URL: https://codereview.appspot.com/
7386053
git-svn-id: http://skia.googlecode.com/svn/trunk@7837
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 22 Feb 2013 21:50:07 +0000 (21:50 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7836
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 21:38:35 +0000 (21:38 +0000)]
Create SkLazyPixelRef which performs lazy decoding.
The new pixel ref behaves similarly to SkImageRef, with some key differences:
It does not depend on the images project.
It requires an SkImageCache, which handles allocation and caching of the pixel
memory.
It takes a function signature for decoding which decodes into already allocated
pixel memory rather than into an SkBitmap.
Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache.
Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc,
and update sites that referenced it.
SkBitmapFactory now sets the pixel ref to a new object of the new
class SkLazyPixelRef, provided it has an SkImageCache for caching.
Provide an option to do lazy decodes in render_pictures and bench_pictures.
SkPicture:
Eliminate the default parameters in the constructor.
If a proc for decoding bitmaps is installed, use it to decode any encoded
data in subpictures.
When parsing deserializing subpictures, check for success.
When serializing subpictures, pass the picture's bitmap encoder to the
subpicture's call to serialize.
Update BitmapFactoryTest to test its new behavior.
BUG=https://code.google.com/p/skia/issues/detail?id=1008
BUG=https://code.google.com/p/skia/issues/detail?id=1009
Review URL: https://codereview.appspot.com/
7060052
git-svn-id: http://skia.googlecode.com/svn/trunk@7835
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 19:17:13 +0000 (19:17 +0000)]
Fix signed/unsigned comparison warnings in benchmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@7833
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 17:28:16 +0000 (17:28 +0000)]
use DEF_GM
git-svn-id: http://skia.googlecode.com/svn/trunk@7832
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:44:04 +0000 (16:44 +0000)]
Enable cpu-array dynamic vertex data on SGX.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
7388045
git-svn-id: http://skia.googlecode.com/svn/trunk@7830
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 16:36:57 +0000 (16:36 +0000)]
remove obsolete build flags:
SK_IGNORE_TRANS_CLAMP_FIX
SK_IGNORE_1XN_BITMAP_OPT
SK_IGNORE_CLIP_BUG_FIX
SK_IGNORE_FAST_SCALEMATRIX_INVERT
SK_IGNORE_QUAD_STROKE_FIX
SK_IGNORE_MULTIPLY_XFERMODE_OPT
SK_IGNORE_LARGE_DASH_OPT
Review URL: https://codereview.appspot.com/
7381050
git-svn-id: http://skia.googlecode.com/svn/trunk@7829
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:25:28 +0000 (16:25 +0000)]
Fix GPU-less build of bench.
git-svn-id: http://skia.googlecode.com/svn/trunk@7828
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:13:16 +0000 (16:13 +0000)]
Make GPU versions of benchs use the same canvas size as raster.
Review URL: https://codereview.appspot.com/
7400049
git-svn-id: http://skia.googlecode.com/svn/trunk@7827
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 16:07:59 +0000 (16:07 +0000)]
Fix ChartBench crash.
git-svn-id: http://skia.googlecode.com/svn/trunk@7826
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 15:50:37 +0000 (15:50 +0000)]
Avoid an unitialized warning on linux.
Review URL: https://codereview.appspot.com/
7378050
git-svn-id: http://skia.googlecode.com/svn/trunk@7825
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 15:46:44 +0000 (15:46 +0000)]
Fix a warning on Android.
Only define/use haveBuffer in debug mode, since it's only used for
assertions.
Review URL: https://codereview.appspot.com/
7384051
git-svn-id: http://skia.googlecode.com/svn/trunk@7824
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 22 Feb 2013 15:46:00 +0000 (15:46 +0000)]
Fix a warning on linux.
Review URL: https://codereview.appspot.com/
7392045
git-svn-id: http://skia.googlecode.com/svn/trunk@7823
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 22 Feb 2013 15:10:36 +0000 (15:10 +0000)]
Add chart bench.
Review URL: https://codereview.appspot.com/
7368051
git-svn-id: http://skia.googlecode.com/svn/trunk@7821
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 14:19:58 +0000 (14:19 +0000)]
remove obsolete build flag SK_IGNORE_CONVEX_QUAD_OPT
Review URL: https://codereview.appspot.com/
7363046
git-svn-id: http://skia.googlecode.com/svn/trunk@7820
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 14:02:58 +0000 (14:02 +0000)]
remove obsolete build flag SK_IGNORE_SETLINE_FIX
git-svn-id: http://skia.googlecode.com/svn/trunk@7819
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 22 Feb 2013 13:03:29 +0000 (13:03 +0000)]
remove obsolete build flag SK_IGNORE_GRADIENT_DITHER_FIX
git-svn-id: http://skia.googlecode.com/svn/trunk@7818
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 22 Feb 2013 07:16:18 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7817
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 21 Feb 2013 20:26:50 +0000 (20:26 +0000)]
Small adjustments to SkRectShaderImageFilter to follow up on original cl.
Review URL: https://codereview.appspot.com/
7377049
git-svn-id: http://skia.googlecode.com/svn/trunk@7816
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 21 Feb 2013 19:48:02 +0000 (19:48 +0000)]
Fix GM self-test expectations, mkII
Review URL: https://codereview.appspot.com/
7393046
git-svn-id: http://skia.googlecode.com/svn/trunk@7815
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 21 Feb 2013 19:20:11 +0000 (19:20 +0000)]
Fix GM self-test expectations
Review URL: https://codereview.appspot.com/
7386048
git-svn-id: http://skia.googlecode.com/svn/trunk@7814
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 21 Feb 2013 18:34:14 +0000 (18:34 +0000)]
Fix ignored errors in GM when no reference images are provided
Review URL: https://codereview.appspot.com/
7400044
git-svn-id: http://skia.googlecode.com/svn/trunk@7813
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 21 Feb 2013 17:10:44 +0000 (17:10 +0000)]
Fix warnings-as-errors on Mac10.6 and Win. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@7811
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 21 Feb 2013 16:34:21 +0000 (16:34 +0000)]
Use CPU arrays for dynamic indices/vertices on ARM GPUs.
Review URL: https://codereview.appspot.com/
7365047
git-svn-id: http://skia.googlecode.com/svn/trunk@7810
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 21 Feb 2013 15:02:28 +0000 (15:02 +0000)]
New SkRectShaderImageFilter image filter
This new changelist also introduces a new image filter called SkRectShaderImageFilter which is make to simply apply a shader on a region without using any inputs.
TEST=Added ShaderImageFilter test
Review URL: https://codereview.appspot.com/
7300046
git-svn-id: http://skia.googlecode.com/svn/trunk@7808
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 21 Feb 2013 14:33:46 +0000 (14:33 +0000)]
Add support for vertex data rendered from CPU arrays.
Review URL: https://codereview.appspot.com/
7380044
git-svn-id: http://skia.googlecode.com/svn/trunk@7807
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 21 Feb 2013 07:15:03 +0000 (07:15 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7803
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 20 Feb 2013 20:01:23 +0000 (20:01 +0000)]
Make ANGLE bot run only ANGLE configs in bench_pictures
Review URL: https://codereview.appspot.com/
7397043
git-svn-id: http://skia.googlecode.com/svn/trunk@7799
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 20 Feb 2013 19:33:20 +0000 (19:33 +0000)]
Add GrGLBufferImpl to unify implementation of GrGLVertexBuffer and GrGLIndexBuffer.
Review URL: https://codereview.appspot.com/
7346055
git-svn-id: http://skia.googlecode.com/svn/trunk@7798
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 20 Feb 2013 19:02:34 +0000 (19:02 +0000)]
Fix compile errors in blur code on Windows.
Various typecasts to remove warnings and get this code building on Windows.
git-svn-id: http://skia.googlecode.com/svn/trunk@7797
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Wed, 20 Feb 2013 18:35:40 +0000 (18:35 +0000)]
remove blur radius reinterpretation for now to make rebaselining simpler and avoid significant changes to webkit and JNI -- those come later
BUG=
Review URL: https://codereview.appspot.com/
7391043
git-svn-id: http://skia.googlecode.com/svn/trunk@7795
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Wed, 20 Feb 2013 16:42:06 +0000 (16:42 +0000)]
Complete the implementation of the faster blur; now supports all blur styles and matches the boxfilter approximation visually. Also change the interpretation of the blur radius to be sigma/2; need to add SK_IGNORE_BLUR_RADIUS_CORRECTNESS to chromium GYP to avoid immediate layout test failures over there.
Review URL: https://codereview.appspot.com/
7307076
git-svn-id: http://skia.googlecode.com/svn/trunk@7793
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 20 Feb 2013 14:55:20 +0000 (14:55 +0000)]
Fix compare of scalar against (int) kMaxTValue.
Also fix order of related compares, placing literal first.
http://code.google.com/p/skia/issues/detail?id=1127
Review URL: https://codereview.appspot.com/
7385043
git-svn-id: http://skia.googlecode.com/svn/trunk@7791
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 20 Feb 2013 12:51:37 +0000 (12:51 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7788
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 20 Feb 2013 07:02:30 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7787
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 20 Feb 2013 02:49:16 +0000 (02:49 +0000)]
add as experiment to factor out low-level enums and types
git-svn-id: http://skia.googlecode.com/svn/trunk@7786
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 19 Feb 2013 21:00:26 +0000 (21:00 +0000)]
Fix handling of setMatrix in debugger
https://codereview.appspot.com/
7349047/
git-svn-id: http://skia.googlecode.com/svn/trunk@7785
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Feb 2013 20:27:02 +0000 (20:27 +0000)]
Fix unused var warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@7781
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Feb 2013 20:17:28 +0000 (20:17 +0000)]
Refactor tracking of bound vbufs and ibufs and vertex attrib arrays.
Review URL: https://codereview.appspot.com/
7359045
git-svn-id: http://skia.googlecode.com/svn/trunk@7779
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 19 Feb 2013 17:09:14 +0000 (17:09 +0000)]
Enable blur rounding (unreviewed).
At a minimum, the following tests will need a rebaseline: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect, blurs, drawbitmapmatrix.
git-svn-id: http://skia.googlecode.com/svn/trunk@7769
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 19 Feb 2013 16:09:10 +0000 (16:09 +0000)]
Add rounding to the separable blurs. This should ensure that the box blurs are energy-preserving (ie., blurring solid 255 alpha stays 255 alpha).
Disabled by default; will enable & rebaseline.
Review URL: https://codereview.appspot.com/
7350043
git-svn-id: http://skia.googlecode.com/svn/trunk@7768
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 19 Feb 2013 15:26:19 +0000 (15:26 +0000)]
remove experimental code that accidentally got delivered
https://codereview.appspot.com/
7340044/
git-svn-id: http://skia.googlecode.com/svn/trunk@7767
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 19 Feb 2013 12:49:33 +0000 (12:49 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7766
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 19 Feb 2013 00:24:10 +0000 (00:24 +0000)]
Rebaselined webpage image GMs for ['base-macmini', 'base-macmini-lion-float', 'base-macmini-10_8'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7765
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 18 Feb 2013 21:52:43 +0000 (21:52 +0000)]
fix signature for onFindClickHandler
git-svn-id: http://skia.googlecode.com/svn/trunk@7764
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 18 Feb 2013 06:57:26 +0000 (06:57 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7763
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sun, 17 Feb 2013 08:59:56 +0000 (08:59 +0000)]
bench_graph_svg: HUGE speedup for parsing tiled bench data
Review URL: https://codereview.appspot.com/
7322085
git-svn-id: http://skia.googlecode.com/svn/trunk@7762
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sun, 17 Feb 2013 08:55:37 +0000 (08:55 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7761
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sun, 17 Feb 2013 08:33:27 +0000 (08:33 +0000)]
bench_graph_svg: add r7618 results (NOT per-tile) to self-test source data
Review URL: https://codereview.appspot.com/
7305098
git-svn-id: http://skia.googlecode.com/svn/trunk@7760
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 17 Feb 2013 07:02:20 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7759
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Sun, 17 Feb 2013 01:41:25 +0000 (01:41 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@7758
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sat, 16 Feb 2013 23:44:00 +0000 (23:44 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
git-svn-id: http://skia.googlecode.com/svn/trunk@7757
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sat, 16 Feb 2013 19:38:44 +0000 (19:38 +0000)]
Whitespace change to test (RunBuilders:Skia_Shuttle_Ubuntu12_ATI5770_Float_Debug_32)
git-svn-id: http://skia.googlecode.com/svn/trunk@7756
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 16 Feb 2013 07:01:31 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@7755
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 15 Feb 2013 17:39:54 +0000 (17:39 +0000)]
non-SK_DEVELOPER-mode patch for r7752
unreviewed
git-svn-id: http://skia.googlecode.com/svn/trunk@7753
2bbb7eff-a529-9590-31e7-
b0007b416f81