김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 08:37:04 +0000 (17:37 +0900)]
[neurun] Merge Equal and NotEqual to Comparison op (#4797)
In https://github.sec.samsung.net/STAR/nnfw/pull/4738#discussion_r156180, we've discussed to group all operations in `::arm_compute::ComparisonOperation`.
This commit introduces `ComparisonNode` that includes operations in `::::arm_compute::ComparisonOperation` and intergrate `Equal` and `NotEqual` to `ComparisonNode`
`ComparisonNode` can be support below.
```
enum class ComparisonType
{
Equal,
NotEqual,
Greater,
GreaterEqual,
Less,
LessEqual
};
```
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 20 Mar 2019 07:36:22 +0000 (16:36 +0900)]
Fix cmake regular expression bug (#4790)
Use variable setting instead of regular expression
because option setting by cmake configure is not working
It is temporary solution until changing option setting for each architecture
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 04:32:40 +0000 (13:32 +0900)]
[neurun] Enable Equal, SquaredDifference, TopKV2 ops (#4738)
* [neurun] Enable Equal, SquaredDifference, TopKV2 ops
This commit enables `Equal`, `SquaredDifference`, `TopKV2` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Fix build break
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 02:11:50 +0000 (11:11 +0900)]
[neurun] Remove unnecessary target include dirs (#4787)
Remove `target_include_directories` for NEURUN_INCLUDE_DIR.
However variable NEURUN_INCLUDE_DIR cannot be removed for now since
cpu/acl_cl kernel module improperly depend on this dir.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
Vladimir Plazun/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 20 Mar 2019 01:12:22 +0000 (04:12 +0300)]
Fix missing symbol in logging backend (#4793)
* Fix missing symbol in logging backend
Add missing ANeuralNetworksCompilation_free in logging backend
Signed-off-by: Vladimir Plazun <v.plazun@samsung.com>
* Format fix
Signed-off-by: Vladimir Plazun <v.plazun@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 08:09:46 +0000 (17:09 +0900)]
[neurun] Extract core module CMakeLists.txt (#4789)
Extract CMakeLists.txt file for neurun/core.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 08:07:32 +0000 (17:07 +0900)]
Save backend dlopen handle (#4784)
Save backend dlopen handle in map member variable
It uses to avoid warning by handle lost without dlclose(), but it will be used to other purpose later
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 08:06:49 +0000 (17:06 +0900)]
[neurun] Enable LogicalOr, LogicalNot ops (#4734)
* [neurun] Enable LogicalOr, LogicalNot ops
Related : #3708
This commit enables `LogicalOr`, `LogicalNot` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Change LogicalOr kernel to CLBitwiseOr
* Fix build break
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 06:45:52 +0000 (15:45 +0900)]
Introduce TensorInfo for interpreter (#4780)
Introduce TensorInfo for interpreter
Current implementation is copy of compiler::TensorInfo
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 06:45:18 +0000 (15:45 +0900)]
Interpreter unittest (#4783)
* Interpreter unittest
Introduce interpreter unittest: unittest for ExecManager
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Add comment and namespace
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 03:58:45 +0000 (12:58 +0900)]
[neurun] Re-organize neurun core directories (#4781)
Introduce core directory and separate headers into two types - private
and public. Public header may be used by frontend and backend
implemenatations.
New directory structure is as follows:
```
- neurun
- frontend (as-is)
- backend (as-is)
- core
- include
- src
```
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 00:35:20 +0000 (09:35 +0900)]
Remove "externals/CMakeLists.txt" (#4777)
This commit moves all the scripts related android support into contrib/
directory, and removes "externals/CMakeLists.txt" from the repo.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 12:30:54 +0000 (21:30 +0900)]
Use pre-built TensorFlow Lite (#4779)
This commit updates TensorFlow Lite CMake package to lookup pre-built
binaries from the system if BUILD_TENSORFLOW_LITE is set as OFF.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 09:34:07 +0000 (18:34 +0900)]
Check format all files as default (#4775)
Check format all c and c++ files as default
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 09:33:52 +0000 (18:33 +0900)]
Require TensorFlow Lite when building nnfw_lib_tflite (#4774)
nnfw_lib_tflite depends on TensorFlow Lite, but there is no explicit
find_package statement.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 08:24:31 +0000 (17:24 +0900)]
[neurun] Organize directories of backend impls (#4773)
Extract backend implementations outside of `src` directory.
Now the directory structure is:
```
- neurun
- frontend
- nnapi
- backend
- acl_cl
- cpu
- src (will be `core`)
```
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 08:24:03 +0000 (17:24 +0900)]
Introduce interpreter ExecManager (#4747)
To introduce interpreter ExecManager, rename Interpereter class
ExecManager will handle execution environment and invoke intepreter
Execution environment and interpreter will be introduced as separated module later
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 08:14:40 +0000 (17:14 +0900)]
Move scripts related with tflite_benchmark_model (#4770)
This commit extracts scripts related with tflite_benchmark_model
from "externals/CMakeLists.txt", and move these scripts into
tflite_benchmark_model project.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 07:25:44 +0000 (16:25 +0900)]
Allow multiple TensorFlowLite package request (#4771)
The current implementation does not work in the presence of multiple
nnfw_find_package(TensorFlowLite ...) invocations.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 06:42:37 +0000 (15:42 +0900)]
[neurun] Enable PReLU, TransposeConv, SQRT ops (#4733)
This commit enables `PReLU`, `TransposeConv`, `SQRT` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 05:08:11 +0000 (14:08 +0900)]
Fix format in contrib (#4762)
Fix format in contrib except benchmark_acl
(bencmark_acl is ported codes from arm compute)
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 04:59:50 +0000 (13:59 +0900)]
[neurun] Fix NNAPI frontend directory structure (#4769)
Reduce redundant frontend directory.
From `neurun/frontend/nnapi/frontend` to `neurun/frontend/nnapi`.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:55:22 +0000 (13:55 +0900)]
Introduce TensorFlow Lite package (#4766)
This commit extracts TensorFlow Lite build script from
"external/CMakeLists.txt", and makes is as a separate TensorFlow
Lite package.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:46:46 +0000 (13:46 +0900)]
Use regular expression to check arm architecture (#4765)
Use regular arm* and aarch* to check arm architecture
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 04:37:31 +0000 (13:37 +0900)]
[neurun] Enable EmbeddingLookup, L2Normalization, HashtableLookup ops (#4707)
* [neurun] Enable EmbeddingLookup, L2Normalization, HashtableLookup ops
This commit enables `EmbeddingLookup`, `L2Normalization`, `HashtableLookup` ops for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Add comment
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:36:58 +0000 (13:36 +0900)]
Set initialize member in PermuteLayer (#4764)
Set initialize member _type in PermuteLayer
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 03:46:44 +0000 (12:46 +0900)]
Fix logging runtime format (#4767)
Fix logging runtime format and check all runtimes
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 01:29:09 +0000 (10:29 +0900)]
Do NOT use CMAKE_CURRENT_SOURCE_DIR for tflite build (#4761)
The current tflite build script uses the hardcoded location of TensorFlow
source code.
This commit removes such hardcoded location and uses TensorFlowSource_DIR
variable instead.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 01:06:00 +0000 (10:06 +0900)]
[neurun] Separate CMakeLists for frontend/nnapi (#4760)
Separate CMakeLists for frontend/nnapi. And corresponding inclusion path
fixes.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Sun, 17 Mar 2019 23:51:34 +0000 (08:51 +0900)]
Cache generated tests (#4755)
Do not generate generated tests unless related files are changed.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 15 Mar 2019 09:53:11 +0000 (18:53 +0900)]
Introduce boolean types into internal operand (#4759)
This commit introduces boolean types into internal operand.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 15 Mar 2019 04:25:35 +0000 (13:25 +0900)]
Off downloading ACL Source on gbs build (#4741)
- Off downloading ACL Source on gbs build
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 15 Mar 2019 04:21:54 +0000 (13:21 +0900)]
Use nnfw command in Makefile (#4746)
This commit updates Makefile to access nnfw internal through top-level
nnfw command (instead of using cmake directly).
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 23:41:28 +0000 (08:41 +0900)]
Remove SetIO test's dependency with frontend (#4742)
Remove SetIO test's dependency by using neurun core
Prepare divide frontend-unittest, core-unittest and backend-unittest,
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 23:41:16 +0000 (08:41 +0900)]
Fix OperationCodeEx of nnapi (#4749)
This commit fixes OperationCodeEx number.
- ANEURALNETWORKS_REDUCE_MIN_EX : 500021 -> 50021
- ANEURALNETWORKS_PRELU_EX : 500022 -> 50022
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 11:43:53 +0000 (20:43 +0900)]
[neurun] Remove the things related to "NN API name". (#4748)
This commit Removes the things related to "NN API name".
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 11:21:31 +0000 (20:21 +0900)]
Remove runtime in Makefile (#4744)
Remove deprecated build option runtime
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 10:28:49 +0000 (19:28 +0900)]
[acl] Use lws_hint() instead of default parameter (#4745)
This commit applies `lws_hint()` in the case of below operators.
TensorFlowMax, TensorFlowSum, EXP, GATHER, CAST, PAD
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 07:48:05 +0000 (16:48 +0900)]
Introduce ONE_HOT, GREATER_EQUAL and LESS operation into NeuralNetworsEx.h (#4736)
* Introduce ONE_HOT_EX operation in NeuralNetworksEx.h
This commit introduces ONE_HOT_EX operation in NeuralNetworsEx.h.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* Introduce GREATER_EQUAL_EX and LESS_EX operations in NeuralNetworksEx.h
This commit introduces GREATER_EQUAL_EX and LESS_EX operations in NeuralNetworksEx.h
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:27:52 +0000 (16:27 +0900)]
Check aarch for arm-related build option (#4735)
Check aarch32 and aarch64 for BUILD_ARMCOMPUTE and BUILD_PURE_ARM_COMPUTE default
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:15:22 +0000 (16:15 +0900)]
Add mobiilenet to model benchmark list (#4732)
Add mobiilenet to model benchmark list
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:01:20 +0000 (16:01 +0900)]
Fix gbs build script (#4731)
Use nnfw command instead of run (removed)
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 05:56:45 +0000 (14:56 +0900)]
[neurun] Remove unused header inclusions (#4730)
Remove unused header inclusions which causes unnecessary coupling.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 04:30:06 +0000 (13:30 +0900)]
Remove CMake branch for Android build (#4729)
Let's use fine-control over each component later.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 03:50:25 +0000 (12:50 +0900)]
Revert same padding calculation (#4727)
Revert same padding calculation because current padding calculation is incorrect
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 01:42:08 +0000 (10:42 +0900)]
[neurun] Add missing generated tests (#4725)
In #4667, I've missed generated tests related that ops because of rebasing.
This commit adds missing generated tests.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 01:31:00 +0000 (10:31 +0900)]
[neurun] Update same_padding helper (#4723)
In #3629, `same_padding` helper is updated to correct.
This commit updates to the same as `same_padding` of `PACL`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 00:29:09 +0000 (09:29 +0900)]
[neurun] Enable L2Pool2D op (#4688)
This commit enables `L2Pool2D` op for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 00:28:10 +0000 (09:28 +0900)]
[neurun] Prepend license to wrapper/execution.cc (#4718)
License block for this file was missing.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 10:52:11 +0000 (19:52 +0900)]
Remove testbuild in Makefile (#4693)
Remove deprecated build option testbuild
Now svace and coverity use make all
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 13 Mar 2019 10:44:09 +0000 (19:44 +0900)]
Remove `run` script that is not used any more (#4717)
`run` is replaced with `nnfw` script.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 10:42:40 +0000 (19:42 +0900)]
Do NOT update global link directory setting (#4716)
This commit removes global link_directories in the top-level
CMakeLists.txt.
This command was introduced as a workaround for CI build failure, but is
no longer required.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:40:53 +0000 (18:40 +0900)]
Coverage report for neurun (#4706)
Change coverage report target to neurun, not pure runtime
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:16:34 +0000 (18:16 +0900)]
Fix SetIO test (#4715)
- Remove dynamic casting
- Remove unused header
- Remove unused alias
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:14:57 +0000 (18:14 +0900)]
Make clean and distclean for external handling (#4649)
* Make clean and clean_all for external handling
make clean: clean only workdir
make clean_all: clean workdir and external stamp file
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* change command clean_all to distclean
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 13 Mar 2019 07:24:30 +0000 (16:24 +0900)]
[neurun] Enable Floor, SpaceToDepth ops (#4686)
This commit enables `Floor`, `SpaceToDepth` for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 07:19:44 +0000 (16:19 +0900)]
Set the default value of BUILD_PURE_ARM_COMPUTE (#4710)
Now, the default value of BUILD_PURE_ARM_COMPUTE is decided according to
the target architecture.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 07:18:47 +0000 (16:18 +0900)]
Use add_subdirectories for contrib and tools (#4708)
This commit simplifies "contrib/CMakeLists.txt" and
"tools/CMakeLists.txt" using "add_subdirectories" function.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 06:19:57 +0000 (15:19 +0900)]
Allow explicit control over CMake with configure command (#4702)
This commit updates "nnfw configure" to pass all of its command-line arguments
to CMake, which allows users to control all the CMake options explicitly.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 06:16:31 +0000 (15:16 +0900)]
[neurun] Extract NNAPI frontend from src (#4705)
This commit extracts NNAPI implementations (e.g. ANeuralNetworksModel_create)
from "src" and moves it to newly introduced frontend/nnapi directory.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 05:51:28 +0000 (14:51 +0900)]
Remove duplicated '-Wno-ignore-attributes' FLAG (#4704)
- Remove duplicated '-Wno-ignore-attributes' FLAG from option files
- Add the FLAG into option_linux.cmake
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 05:37:21 +0000 (14:37 +0900)]
Remove unnecessary if for BUILD_ARMCOMPUTE (#4703)
Now, the default value of BUILD_ARMCOMPUTE for x86_64 is OFF.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 05:22:15 +0000 (14:22 +0900)]
Disable warning ignore-atrribute for aarch64 (#4701)
- To fix tizen gbs build error on aarch64 ( aarch64 cross build,too)
- related issue : https://github.com/ARM-software/ComputeLibrary/issues/330
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
박세희/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 13 Mar 2019 05:13:04 +0000 (14:13 +0900)]
Add comments for nnfw_find_package (#4700)
* Add comments for nnfw_find_package
This will add some example comments for nnfw_find_package in CMakeLists.txt file
Signed-off-by: SaeHie Park <saehie.park@samsung.com>
* apply comments
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 13 Mar 2019 05:08:45 +0000 (14:08 +0900)]
[neurun] Enable ResizeBilinear, ReLU1, ReLU6 ops (#4667)
Related : #4259
This commit enables `ResizeBilinear`, `ReLU1`, `ReLU6` for `acl_cl`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 04:12:59 +0000 (13:12 +0900)]
Fix coverage report bug (#4666)
Fix coverage report bug setting SRC_PREFIX: use default value
gen-coverage-report command use default variable for command
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 23:18:31 +0000 (08:18 +0900)]
Pass GENERATE_NNAPI_TESTS to docker container (#4695)
Pass host's GENERATE_NNAPI_TESTS setting to docker container
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 23:18:17 +0000 (08:18 +0900)]
Remove default constructors (#4694)
Remove default consturctor for TypeInfo and TensorInfo
Block implicit using of default constructor
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 09:37:39 +0000 (18:37 +0900)]
Do NOT use quote in CMAKE_DEPENDENT_OPTIONS (#4692)
This does not work as expected.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 07:59:33 +0000 (16:59 +0900)]
Set BUILD_ARMCOMPUTE according to TARGET_ARCH (#4684)
Now, the default vaule of BUILD_ARMCOMPUTE option will be
set according to TARGET_ARCH.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 12 Mar 2019 07:42:11 +0000 (16:42 +0900)]
[neurun] Enable ReLU, RSQRT ops (#4642)
This commit enables `ReLU`, `RSQRT` for `acl_ac`.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Tue, 12 Mar 2019 07:17:42 +0000 (16:17 +0900)]
[neurun] Add Squeeze Operation (#4678)
Add squeeze operation.
The implementation comes from pure arm compute runtime.
Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 06:46:10 +0000 (15:46 +0900)]
Update build toolchain in dockerfile (#4669)
- Remove deprecated build tool: gcc-5 softfp
- Install gcc-6 for x64 build
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 12 Mar 2019 06:45:07 +0000 (15:45 +0900)]
[neurun] Simplify ARM Compute function includes (#4682)
In #4636, `PACL` uses a set of meta headers that includes all the functions.
This commit applies this to neurun.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 05:32:44 +0000 (14:32 +0900)]
Introduce BUILD_LOGGING option (#4679)
This commit introduces BUILD_LOGGING option which allows users to
enable/disable logging runtime build, and updates CMakeLists.txt to
use it instead of OBS_BUILD.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 04:53:37 +0000 (13:53 +0900)]
Remove OBS_BUILD from GTest package (#4663)
This commit removes OBS_BUILD occurences from GTest package, and uses
BUILD_GTEST instead.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 03:16:48 +0000 (12:16 +0900)]
Update document to use docker image (#4677)
Update command usage and standalone scripts using docker image
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 12 Mar 2019 03:16:15 +0000 (12:16 +0900)]
Build independent with download option (#4648)
* Build independent with download option
If download option is off and there is correct external directory & stamp, try to build.
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* ExternalSource_Get use ExternalSource_Download
* Remove variables not used
* Fix typo
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 11:15:32 +0000 (20:15 +0900)]
Simplify tests/tools/CMakeLists.txt (#4670)
This commit introduces BUILD_TFLITE_RUN option in order to simplify
"tests/tools/CMakeLists.txt".
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 11 Mar 2019 10:49:27 +0000 (19:49 +0900)]
[nuerun] Introduce checking padding of the tensor. (#4647)
This commit introduce checking padding of the tensor.
Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 10:29:52 +0000 (19:29 +0900)]
Enable debug build in acl (#4671)
This patch enables acl debug build.
The `asserts` and `logging` are forced to 1 for debug build.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 09:54:05 +0000 (18:54 +0900)]
Always build generated NNAPI tests (#4664)
With this commit, generated NNAPI tests are always built when NNAPI test
build is enabled.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 11 Mar 2019 07:15:22 +0000 (16:15 +0900)]
[neurun] Rename operand::Context as OperandContext (#4629)
Rename to reduce namespace level. This class was the only class in this
namespace.
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 07:00:57 +0000 (16:00 +0900)]
Enable logistic_qaunt nnapi tests in neurun and pureacl (#4660)
This commit enables logistic quantize nnapi tests.
It is fixed in acl v19.02.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 05:58:21 +0000 (14:58 +0900)]
Introduce BUILD_TENSORFLOW_LITE option (#4658)
This commit introduces BUILD_TENSORFLOW_LITE option and removes one
occurences of OBS_BUILD in CMakeLists.txt via using this flag instead.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 04:51:00 +0000 (13:51 +0900)]
Introduce BUILD_TOOLS options (#4654)
This commit introduces BUILD_TOOLS option and partially removes the
the occurence of OBS_BUILD in CMakeLists.txt by using this BUILD_TOOLS
option.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 03:48:41 +0000 (12:48 +0900)]
[PACL] Use meta headers to simplify include(s) (#4656)
This commit simplifies includes(s) in compilation.cc via using meta
headers that ARM Compute and ARM Compute Ex libraries provide.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 02:11:27 +0000 (11:11 +0900)]
Fix build error : remove logging runtime dep to boost library (#4650)
- remove logging runtime dep to boost library(not required)
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 02:07:05 +0000 (11:07 +0900)]
Introduce ARMComputeEx meta header (#4653)
This commit introduces a meta header for each domain (CL/NEON) that
includes all the functions that each domain provides similarly as
ARMCompute does.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 11 Mar 2019 02:04:41 +0000 (11:04 +0900)]
Always enable test (#4634)
This commit moves enable_testing() call from GTestConfig to top-level
CMakeLists.txt.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 09:21:30 +0000 (18:21 +0900)]
Remove CLNormalizationLayerEx.h (#4646)
"CLNormalizationLayerExKernel.h" is already removed from the repo, and
thus it is possible to compile this header.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 8 Mar 2019 08:45:54 +0000 (17:45 +0900)]
[neurun] Enable NotEqual,ReduceMax,LogicalAnd ops (#4633)
To avoid frequent conflicts among op PRs(migration is too slow..), This commit enables three ops for `acl_cl` at the same time.
Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 08:42:21 +0000 (17:42 +0900)]
Remove unused CMake global variabes (#4644)
This commit removes the following (unused) CMake global variables:
- NNFW_INCLUDE_DIR
- NNFW_EXTERNALS_DIR
- TFLITE_DEPEND_DIR
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
대인기/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 07:49:39 +0000 (16:49 +0900)]
Add cmake build support for Boost library (#4572)
* Add cmake build support for Boost library
This patch downloads Boost source code(v1.65.1) from upstream
if DOWNLOAD_BOOST is true, and build and install the boost library
if BUILD_BOOST is true.
For the various compilers support, BoostConfing.cmake file
creates project-config.jam file to setup a proper toolchain
according to toolchain setting, and target libraries to build.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Remove CROSS_BUILD flag
We have already another flag - BUILD_IS_NATIVE
so remove CROSS_BUILD flag and use BUILD_IS_NATIVE instead.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Find boost package at each sub module
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Check if b2 binary exists and clean up
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Add some TODO descriptions
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Add /externals/boost to .gitignore
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Pass arguments to b2 script
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Clean up user jam file support
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Disable Boost build by default
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Remove unnecessary debug messages
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Remove _Boost_Import function
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Remove BOOST_BASE flag
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Clean up BoostConfig.cmake
- Remove _Boost_Check function.
- Add system and filesystem module build to boost build options.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Fix typo
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Use QUIET instead of REQUIRED
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Fix invalid argument error
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Update Boost variables at boost build
Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Fix build error
Signed-off-by: Inki Dae <inki.dae@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 07:38:02 +0000 (16:38 +0900)]
Remove workaround for pre-built acl (#4639)
Use pre-built acl v19.02 again
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 07:20:27 +0000 (16:20 +0900)]
Remove deprecated scripts in scripts/command (#4640)
Remove deprecated scripts in scripts/command
Build scripts are in scripts/standalone
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 8 Mar 2019 07:09:59 +0000 (16:09 +0900)]
[neurun] Correct header inclusions in Executor (#4618)
- `BackendResolver` is not needed
- Plan is required for `Executor`, not `IExecutor`
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 07:01:58 +0000 (16:01 +0900)]
Introduce nnapi-header CMake target (#4631)
This commit introduces nnapi-header target in CMake, and removes all
the occurences of NNFW_INCLUDE_DIR via linking this target instead.
Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 02:27:18 +0000 (11:27 +0900)]
acl version up to 19.02 (#4549)
* build ACL unconditionally
- This patch should be reverted after CI infra(e.g .pre-built ACL binary) is updated.
* Compute Library update to v19.02
- Update ACL to v19.02
- Remove unness. files from ARMComputeEx
Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 00:50:55 +0000 (09:50 +0900)]
Fix split implementation and test (#4622)
* Fix split implementation and test
Fix plit implementation based on NeuralNetworksEx.h spec
- Fix split in nnapi_delegate.cpp
- Fix pacl implementation
- Fix spli test
Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix comment