Nito Martinez [Wed, 25 Nov 2015 07:36:49 +0000 (08:36 +0100)]
Disable setting socket options for preexisting socket like: keepalive and tcp_nodelay, these should be set extenally if needed. Do not close the socket if the clientaddress could not be set
Nito Martinez [Fri, 20 Nov 2015 01:44:35 +0000 (02:44 +0100)]
Fixes #2982. The idea is to be able to create the socket externally and pass that socket FD to FreeRDP so that it can be used there.
The idea suggested is to use the following interface:
settings->ServerHostname = "|"
settings->ServerPort = SocketFD
Hardening [Wed, 11 Nov 2015 11:54:34 +0000 (12:54 +0100)]
Merge pull request #2970 from bmiklautz/prep_2.0
2.0 preparations
Bernhard Miklautz [Wed, 11 Nov 2015 02:20:37 +0000 (03:20 +0100)]
Merge pull request #2971 from woutershep/cmake-manual-path
cmake: tweak manpage install location
Bernhard Miklautz [Tue, 10 Nov 2015 15:29:09 +0000 (16:29 +0100)]
wlog: cleanup API includes
Only include necessary header files.
Bernhard Miklautz [Tue, 10 Nov 2015 12:40:52 +0000 (13:40 +0100)]
wlog/journald: don't set a default identifier
Don't set the identifier to "winpr" as default value because journald
will use the programs name as default if no identifier is set.
This way a program using WLog doesn't need to set an identifier (except
it want something different then it's name).
Bernhard Miklautz [Tue, 10 Nov 2015 11:05:23 +0000 (12:05 +0100)]
wlog: change variable naming and fix documentation
* change State to active and make it BOOL since it's only got two
used values
* fix some typos in the documentation
Hardening [Tue, 10 Nov 2015 09:13:47 +0000 (10:13 +0100)]
Merge pull request #2917 from binglinoioij/master
add values-zh/string.xml,that was profiles for chinese
Hardening [Tue, 10 Nov 2015 09:12:21 +0000 (10:12 +0100)]
Merge pull request #2930 from dbungert/glyph
Clamp ultra-wide glyph opRight vals to desktop width
Hardening [Tue, 10 Nov 2015 08:59:45 +0000 (09:59 +0100)]
Merge pull request #2962 from akallabeth/client_build_fixes
Allow client build to be disabled
Wouter van Kesteren [Mon, 9 Nov 2015 20:57:41 +0000 (21:57 +0100)]
cmake: tweak manpage install location
This patch is needed when wanting to install binaries/libraries to other
locations than data. The linux distro Exherbo installs binaries and
libraries to /usr/<chost>/bin, /usr/<chost>/lib respectively but
manpages should still go in /usr/share/man/ because they are
architecture independent, without this patch they go in
/usr/<chost>/share/man unconditionally.
cmake documentation states:
DATAROOTDIR - read-only architecture-independent data root (share)
So this patch makes it use that so that its configurable.
Bernhard Miklautz [Mon, 9 Nov 2015 19:30:23 +0000 (20:30 +0100)]
wlog: add some rudimentary documentation
Bernhard Miklautz [Mon, 9 Nov 2015 18:47:51 +0000 (19:47 +0100)]
wlog: fix build on windows
Bernhard Miklautz [Mon, 9 Nov 2015 18:37:02 +0000 (19:37 +0100)]
wlog: fix android build
Bernhard Miklautz [Mon, 9 Nov 2015 18:26:34 +0000 (19:26 +0100)]
Fix compiler warnings
gcc (Debian 4.9.2-10) 4.9.2
winpr/libwinpr/thread/argv.c: In function ‘CommandLineToArgvA’:
winpr/libwinpr/thread/argv.c:94:6: warning: unused variable ‘index’ [-Wunused-variable]
int index;
winpr/libwinpr/file/test/TestFileGetStdHandle.c: In function ‘TestFileGetStdHandle’:
winpr/libwinpr/file/test/TestFileGetStdHandle.c:44:2: warning: implicit
declaration of function ‘CloseHandle’ [-Wimplicit-function-declaration]
CloseHandle(stdout);
^
libfreerdp/codec/test/TestFreeRDPRegion.c: In function ‘test_norbert2_case’:
libfreerdp/codec/test/TestFreeRDPRegion.c:697:6: warning: unused variable ‘i’ [-Wunused-variable]
int i;
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_receive_format_list’:
channels/cliprdr/server/cliprdr_main.c:636:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
^
channels/cliprdr/server/cliprdr_main.c: In function ‘cliprdr_server_init’:
channels/cliprdr/server/cliprdr_main.c:1097:24: warning: unused variable ‘cliprdr’ [-Wunused-variable]
CliprdrServerPrivate* cliprdr = (CliprdrServerPrivate*) context->handle;
Bernhard Miklautz [Mon, 9 Nov 2015 17:27:38 +0000 (18:27 +0100)]
Adapt error level for debug messages
When using xfreerdp a regular invocation should really only report grave
problems as error. "Regular" messages should be either info or even
debug.
Bernhard Miklautz [Mon, 9 Nov 2015 16:56:44 +0000 (17:56 +0100)]
wlog: rework, cleanup and stabilize API
* only expose necessary functions and types in header
* don't expose appender internals
* add generic function WLog_ConfigureAppender to have the possibility
to configure appender specific settings
* detect appender availability if WLog_SetLogAppenderType or
WLog_Appender_New return FALSE or NULL respectively the appender isn't
available or the initialization failed. This is very useful for the
use with optional appenders.
* add Free to the appender interface. At the time of the Free the
appender is known and available so it can be called directly (instead
of calling the right function according to the type)
* make all appender internal function static
* all appenders return the generic wLogAppender type now. Typecasts
are internally done where necessary this abstracts the appenders more
cleanly
Bernhard Miklautz [Thu, 5 Nov 2015 13:02:07 +0000 (14:02 +0100)]
Add build-config.h
build-config.h should contain configure/compile time settings that are
relevant for projects that use FreeRDP.
For example the compiled in plugin search paths.
Bernhard Miklautz [Thu, 5 Nov 2015 11:29:41 +0000 (12:29 +0100)]
Pump version to 2.0.0
Norbert Federa [Mon, 9 Nov 2015 12:42:02 +0000 (13:42 +0100)]
Merge pull request #2964 from hardening/udp_appender
Add an UDP appender to wLog
David FORT [Fri, 6 Nov 2015 22:17:11 +0000 (23:17 +0100)]
Take in account @nfedera's remarks
Norbert Federa [Fri, 6 Nov 2015 12:43:44 +0000 (13:43 +0100)]
Merge pull request #2954 from mfleisz/cliprdr_fix
cliprdr/server: Server-side file content receiving used wrong callback
Norbert Federa [Fri, 6 Nov 2015 12:34:42 +0000 (13:34 +0100)]
Merge pull request #2926 from bjcollins/rail_fixes
Rail fixes
Hardening [Fri, 6 Nov 2015 09:21:47 +0000 (10:21 +0100)]
Merge pull request #2963 from nfedera/fix-fullscreen-multimon
client/X11: multimon/fullscreen fixes
Hardening [Fri, 6 Nov 2015 09:19:40 +0000 (10:19 +0100)]
Merge pull request #2968 from nfedera/fix-commandlinetoargv
winpr/argv: fix CommandLineToArgvA memory access
Norbert Federa [Thu, 5 Nov 2015 17:10:05 +0000 (18:10 +0100)]
winpr/argv: fix CommandLineToArgvA memory access
- fixed access of unitialized memory beyond terminating null
- minor simplifications
David FORT [Wed, 4 Nov 2015 17:11:19 +0000 (18:11 +0100)]
Add an UDP appender to wLog
This appender allows to receive the logs over a network connection using UDP packets.
You can see the logs using a listening netcat, for example: nc -ul 127.0.0.1 20000.
Norbert Federa [Wed, 4 Nov 2015 16:58:21 +0000 (17:58 +0100)]
client/X11: fix post fullscreen repositioning
Norbert Federa [Wed, 4 Nov 2015 14:01:31 +0000 (15:01 +0100)]
client/X11: multimon/fullscreen fixes
- fixed wrong calculation of xfc->fullscreenMonitors.[right|bottom]
- only use _NET_WM_FULLSCREEN_MONITORS if at least 2 monitors are involved
- call XMoveWindow before setting the _NET_WM_STATE_FULLSCREEN property
Armin Novak [Wed, 4 Nov 2015 12:15:37 +0000 (13:15 +0100)]
Fixed WITH_CLIENT_CHANNELS dependencies.
Armin Novak [Wed, 4 Nov 2015 08:53:13 +0000 (09:53 +0100)]
Added WITH_CLIENT_COMMON option.
Armin Novak [Tue, 3 Nov 2015 15:16:49 +0000 (16:16 +0100)]
Disabled client builds if WITH_CLIENT is not set.
Armin Novak [Tue, 3 Nov 2015 15:18:09 +0000 (16:18 +0100)]
Fixed return values.
Bernhard Miklautz [Tue, 3 Nov 2015 11:22:22 +0000 (12:22 +0100)]
Merge pull request #2961 from nfedera/nf-fix-image-copy-segfault
codec/color: fix segfault in freerdp_image32_copy
Norbert Federa [Tue, 3 Nov 2015 11:05:47 +0000 (12:05 +0100)]
codec/color: fix segfault in freerdp_image32_copy
Code path for dstBytesPerPixel == 3 moved src and dst pointers
beyond their respective buffers.
Hardening [Mon, 2 Nov 2015 09:50:16 +0000 (10:50 +0100)]
Merge pull request #2951 from bmiklautz/friday
Misc fixes
Bernhard Miklautz [Mon, 2 Nov 2015 09:45:35 +0000 (10:45 +0100)]
Merge pull request #2957 from hardening/journald
Adds a systemd journal appender
David FORT [Sun, 1 Nov 2015 20:34:03 +0000 (21:34 +0100)]
Take in account @bmiklautz remarks
* I have added a function to set the journal identifier
* the appender name has been changed from SYSTEMD to JOURNALD
David FORT [Fri, 30 Oct 2015 19:22:25 +0000 (20:22 +0100)]
Fix the env var leak
David FORT [Fri, 30 Oct 2015 19:20:42 +0000 (20:20 +0100)]
Use unbuffered output
David FORT [Fri, 30 Oct 2015 13:50:14 +0000 (14:50 +0100)]
Adds a systemd journal appender
Bernhard Miklautz [Thu, 29 Oct 2015 17:44:14 +0000 (18:44 +0100)]
Merge pull request #2940 from hardening/syslog_appender
Add a wLog syslog appender
David FORT [Thu, 29 Oct 2015 17:33:42 +0000 (18:33 +0100)]
Fixed a warning
David FORT [Thu, 29 Oct 2015 17:31:22 +0000 (18:31 +0100)]
Support syslog type for the WLOG_APPENDER env var
Martin Fleisz [Thu, 29 Oct 2015 11:45:12 +0000 (12:45 +0100)]
cliprdr/server: Server-side file content receiving used wrong callback
David FORT [Thu, 29 Oct 2015 09:32:58 +0000 (10:32 +0100)]
Don't include config.h in public headers
In fact we don't need the ifdefery in public headers, so don't include unneeded
config.h file.
Bernhard Miklautz [Wed, 28 Oct 2015 14:55:17 +0000 (15:55 +0100)]
Merge pull request #2952 from mfleisz/server_cliprdr_config
cliprdr/server: Provide the server with a possibility to configure capabilities
Martin Fleisz [Wed, 28 Oct 2015 11:28:14 +0000 (12:28 +0100)]
cliprdr/server: Add comment
David FORT [Tue, 27 Oct 2015 20:45:26 +0000 (21:45 +0100)]
Include config.h file when needed
Martin Fleisz [Tue, 27 Oct 2015 16:12:33 +0000 (17:12 +0100)]
cliprdr/server: Provide the server with a possibility to configure capabilities
Bernhard Miklautz [Fri, 23 Oct 2015 16:17:14 +0000 (18:17 +0200)]
winpr API: add EnvironmentBlockToEnvpA
* expose EnvironmentBlockToEnvpA
* cleanup includes in process.c
* removed unused "flag" variable in _CreateProcessExA
* make ProcessHandleCloseHandle static
Bernhard Miklautz [Fri, 23 Oct 2015 16:06:17 +0000 (18:06 +0200)]
winpr/stream: don't allow 0-size streams
Bernhard Miklautz [Fri, 23 Oct 2015 15:18:53 +0000 (17:18 +0200)]
winpr: fix compiler warning
winpr/libwinpr/utils/wlog/wlog.c: In function ‘WLog_PrintMessageVA’:
winpr/libwinpr/utils/wlog/wlog.c:234:7: warning: ‘status’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
BOOL status;
^
gcc 4.9.2
Bernhard Miklautz [Fri, 23 Oct 2015 10:38:13 +0000 (12:38 +0200)]
Merge pull request #2945 from mfleisz/wlog_compile_fix
wlog: Fix variable definitions
Martin Fleisz [Fri, 23 Oct 2015 10:08:20 +0000 (12:08 +0200)]
wlog: Fix variable definitions
Vic Lee [Fri, 23 Oct 2015 07:59:07 +0000 (15:59 +0800)]
Merge pull request #2929 from mfleisz/cliprdr_fix
cliprdr/server: Don't call CloseHandle on ChannelEvent
Martin Fleisz [Fri, 23 Oct 2015 06:49:24 +0000 (08:49 +0200)]
cliprdr/server: Fix memory leak
David FORT [Thu, 22 Oct 2015 08:54:21 +0000 (10:54 +0200)]
Adapt to last wLog changes
David FORT [Wed, 21 Oct 2015 14:13:15 +0000 (16:13 +0200)]
Add a wLog syslog appender
Hardening [Thu, 22 Oct 2015 08:35:43 +0000 (10:35 +0200)]
Merge pull request #2927 from MartinHaimberger/mh-log-returnvalues
wlog: fixed return values
MartinHaimberger [Wed, 21 Oct 2015 10:57:12 +0000 (12:57 +0200)]
Merge pull request #2939 from nfedera/fix-x11-clip-id
xfreerdp/clipr: fix self owned test and hardening
Martin Haimberger [Wed, 21 Oct 2015 08:11:06 +0000 (01:11 -0700)]
wlog: fixed return values
wlog used to return an int but the only meaning
of the return value was:
* negative ... error
* 0 or positive ... success
but the positve returned value was 1 or some id of some
subsystem, nothing meaningful for the caller.
For a more meaningful returnvalue we now use BOOL.
If something goes wrong FALSE is returned.
Martin Fleisz [Wed, 21 Oct 2015 07:53:42 +0000 (09:53 +0200)]
Merge pull request #2938 from LookBehind/master
Fix rdp_recv_logon_error_info
Norbert Federa [Tue, 20 Oct 2015 19:28:29 +0000 (21:28 +0200)]
xfreerdp/clipr: fix self owned test and hardening
- xf_cliprdr_is_self_owned() lied if multiple xfreerdp instances were
running.
- fixed a few unchecked callocs
- added/modified and handled some return values in compliance with
the new hardened channel api
LookBehind [Tue, 20 Oct 2015 14:05:09 +0000 (18:05 +0400)]
Fix rdp_recv_logon_error_info
As https://msdn.microsoft.com/en-us/library/
cc240641.aspx says - first is going errorNotificationType then errorNotificationData.
Martin Fleisz [Tue, 20 Oct 2015 06:44:52 +0000 (08:44 +0200)]
Merge pull request #2933 from realjiangms/fix_gdi_bitmap_update
GDI: Fix gdi_bitmap_update to check dest buffer size.
zihao.jiang [Sun, 18 Oct 2015 09:53:22 +0000 (17:53 +0800)]
GDI: Fix gdi_bitmap_update to check dest buffer size.
Martin Fleisz [Fri, 16 Oct 2015 09:40:25 +0000 (11:40 +0200)]
cliprdr/server: Don't call CloseHandle on EventHandle
Bernhard Miklautz [Fri, 16 Oct 2015 08:38:11 +0000 (10:38 +0200)]
Merge pull request #2910 from dupondje/master
FindGStreamer_1_0: fix build failure for new gstreamer versions
root [Fri, 16 Oct 2015 07:54:26 +0000 (15:54 +0800)]
update values-zh/strings.xml
bjcollins [Fri, 16 Oct 2015 00:10:04 +0000 (19:10 -0500)]
Cleanup unnecessary/unintended changes from last commit
bjcollins [Thu, 15 Oct 2015 23:41:55 +0000 (18:41 -0500)]
RemoteApp Support
1. Remove all uses of "localWindowOffsetCorr" variables, they added an extra layer of complexity and they are not actually needed to handle coordination of window position/size between
the local coordinate system and the remote one. This logic was causing issues in the case where the window was moved off the left side of the screen.
2. Update the xf_setWindowVisibilityRects function to offset the visibility rects as necessary when the window is hanging off the left side of the screen.
3. Stop sending mouse events when doing keyboard moves/sizes(as desired), and stop sending two mouse events for non-keyboard moves/sizes
4. Move location of new UTF8_STRING variable from previous commit
5. Refresh window and window shape for any window position/size updates, this helps keep the local and server windows in sync and works around some race conditions
bjcollins [Thu, 15 Oct 2015 23:18:21 +0000 (18:18 -0500)]
Remote app support
All window state order offsets are signed according to the RDP spec, lets treat them as such.
bjcollins [Thu, 15 Oct 2015 19:59:53 +0000 (14:59 -0500)]
Store Miscellaneous X11 Atoms into variables to match how we handle other X11 Atoms.
bjcollins [Thu, 15 Oct 2015 19:47:10 +0000 (14:47 -0500)]
RemoteApp support
Remove use of WindowRects to affect window shape, the VisibilityRects are used for this purpose.
bjcollins [Thu, 15 Oct 2015 19:39:59 +0000 (14:39 -0500)]
Ensure that app windows always get a window type assigned to them.
bjcollins [Thu, 15 Oct 2015 19:35:07 +0000 (14:35 -0500)]
Continue processing all other window orders for new remote app windows instead
of existing after only looking at part of the information. For instance, window visibility
rects are part of the message with the new order and were being ignored.
bjcollins [Thu, 15 Oct 2015 19:31:15 +0000 (14:31 -0500)]
Do not support fullscreen toggle keyboard sequence in remote_app mode. There is no support in interface for this
and the fullscreen code is not designed to handle remote app windows.
bjcollins [Thu, 15 Oct 2015 19:29:48 +0000 (14:29 -0500)]
Fix xf_rail_paint fencepost error
The regions used to store and calculate the invalidRegion are exclusive
of the bottom and right edges, not inclusive.
Fixes "mouse droppings" in mspaint.exe when moving the mouse leftwards
across the canvas.
Daniel Bungert [Wed, 14 Oct 2015 20:16:19 +0000 (14:16 -0600)]
Clamp ultra-wide glyph opRight vals to desktop width
Marc-André Moreau [Wed, 14 Oct 2015 14:50:26 +0000 (10:50 -0400)]
Merge pull request #2924 from awakecoding/master
egfx multimon fixes
Marc-André Moreau [Tue, 13 Oct 2015 19:50:39 +0000 (15:50 -0400)]
libfreerdp-gdi: fix egfx multimon support
Marc-André Moreau [Tue, 13 Oct 2015 18:49:30 +0000 (14:49 -0400)]
xfreerdp: fix multiple egfx context support in X11 GFX
Marc-André Moreau [Tue, 13 Oct 2015 15:09:43 +0000 (11:09 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 13 Oct 2015 14:40:28 +0000 (10:40 -0400)]
Merge pull request #2919 from realjiangms/fix_allow_empty_password
Sec/NLA: Support passwordless (blank password) login with NLA.
Marc-André Moreau [Tue, 13 Oct 2015 14:23:58 +0000 (10:23 -0400)]
Merge pull request #2920 from awakecoding/mbedtls
WinPR mbed TLS support
Marc-André Moreau [Tue, 13 Oct 2015 13:54:59 +0000 (09:54 -0400)]
libwinpr-crypto: fix OpenSSL 1.0 HMAC API change
Marc-André Moreau [Tue, 13 Oct 2015 13:43:26 +0000 (09:43 -0400)]
libwinpr-crypto: fix error checking
Marc-André Moreau [Tue, 13 Oct 2015 13:13:52 +0000 (09:13 -0400)]
libwinpr-crypto: avoid linking to less common digests and ciphers
Hardening [Tue, 13 Oct 2015 06:53:45 +0000 (08:53 +0200)]
Merge pull request #2912 from realjiangms/shadow_fix_auth_nopasswd
Server/Shadow: Minor fix on authentication in shadow_client.c.
Marc-André Moreau [Fri, 9 Oct 2015 19:58:50 +0000 (15:58 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into mbedtls
Marc-André Moreau [Fri, 9 Oct 2015 19:57:41 +0000 (15:57 -0400)]
winpr: make clean non-OpenSSL build possible (without schannel, makecert)
Marc-André Moreau [Fri, 9 Oct 2015 19:23:15 +0000 (15:23 -0400)]
libwinpr-crypto: add generic digest API and OpenSSL compatible key derivation
zihao.jiang [Fri, 9 Oct 2015 17:48:41 +0000 (01:48 +0800)]
Sec/NLA: Support passwordless (blank password) login with NLA.
It was supported in freerdp 1.0.2 but not supported in lastest master.
We should take empty password if it is explicitly specified with /v option.
If a password is not specified, we could first try SAM file. If the user entry does not exist, prompt for password.
Marc-André Moreau [Fri, 9 Oct 2015 16:15:31 +0000 (12:15 -0400)]
libwinpr-crypto: add generic cipher API with OpenSSL/mbedtls support
Marc-André Moreau [Thu, 8 Oct 2015 20:48:58 +0000 (16:48 -0400)]
libwinpr-sspi: remove OpenSSL dependency in NTLM SSPI module
Marc-André Moreau [Thu, 8 Oct 2015 20:26:37 +0000 (16:26 -0400)]
libwinpr-crypto: add rand and RC4 functions with OpenSSL/mbedtls
Marc-André Moreau [Thu, 8 Oct 2015 17:58:55 +0000 (13:58 -0400)]
libwinpr-crypto: add basic hashing and HMAC support with OpenSSL/mbedTLS
clouder [Thu, 8 Oct 2015 09:20:44 +0000 (17:20 +0800)]
add values-zh/string.xml
Marc-André Moreau [Tue, 6 Oct 2015 14:56:24 +0000 (10:56 -0400)]
winpr: isolate OpenSSL