Armin Novak [Tue, 1 Sep 2015 07:25:41 +0000 (09:25 +0200)]
Ignore AND mask for 32 bit pointer.
Armin Novak [Thu, 6 Aug 2015 12:43:39 +0000 (14:43 +0200)]
Fixed duplicate int.
Armin Novak [Thu, 6 Aug 2015 12:11:36 +0000 (14:11 +0200)]
Fixed mac API.
Armin Novak [Thu, 6 Aug 2015 09:24:42 +0000 (11:24 +0200)]
Added length arguments and checks.
Armin Novak [Wed, 5 Aug 2015 15:32:46 +0000 (17:32 +0200)]
Fixed return and argument checks.
Armin Novak [Wed, 5 Aug 2015 15:32:38 +0000 (17:32 +0200)]
Fixed argument checks.
Armin Novak [Wed, 5 Aug 2015 15:19:46 +0000 (17:19 +0200)]
Fixed pointer update decoding with NULL mask.
Marc-André Moreau [Tue, 4 Aug 2015 16:33:37 +0000 (12:33 -0400)]
Merge pull request #2823 from awakecoding/master
egfx channel open/close fix, H.264 Media Foundation decoder support
Marc-André Moreau [Tue, 4 Aug 2015 15:55:38 +0000 (11:55 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 4 Aug 2015 15:55:03 +0000 (11:55 -0400)]
libfreerdp-codec: fix Windows XP build for H.264 decoder
Marc-André Moreau [Tue, 4 Aug 2015 14:26:13 +0000 (10:26 -0400)]
libfreerdp-codec: fix leaks in H.264 Media Foundation decoder
Marc-André Moreau [Mon, 3 Aug 2015 20:21:48 +0000 (16:21 -0400)]
libfreerdp-codec: initial Media Foundation H.264 decoder support
Bernhard Miklautz [Mon, 3 Aug 2015 07:23:54 +0000 (09:23 +0200)]
Merge pull request #2811 from clivest/client_channel_interface_leak_fix
Fix race condition in freerdp_channels_client_load that could cause memory leak
Martin Fleisz [Fri, 31 Jul 2015 06:19:03 +0000 (08:19 +0200)]
Merge pull request #2817 from FreeRDP/mh-fix-collection-free
fixed misc *_free functions to accept NULL
Marc-André Moreau [Thu, 30 Jul 2015 18:07:35 +0000 (14:07 -0400)]
libfreerdp-codec: add more Media Foundation H.264 code
Martin Haimberger [Thu, 30 Jul 2015 14:02:36 +0000 (07:02 -0700)]
fixed misc *_free functions to accept NULL
Following types of collections support now
NULL in the free call:
* ArrayList
* BitStream
* ContdownEvent
* Dictionary
* KeyValuePair
* MessageQueue
Hardening [Thu, 30 Jul 2015 12:09:13 +0000 (14:09 +0200)]
Merge pull request #2815 from FreeRDP/mh-wait-SetLastError
winpr: WaitFor*Ojbect/s set lastError now
Martin Haimberger [Thu, 30 Jul 2015 09:52:11 +0000 (02:52 -0700)]
winpr: WaitFor*Ojbect/s set lastError now
Marc-André Moreau [Wed, 29 Jul 2015 20:33:04 +0000 (16:33 -0400)]
libfreerdp-codec: start H.264 MediaFoundation support
Clive Stevens [Wed, 29 Jul 2015 13:08:31 +0000 (14:08 +0100)]
Fix race condition in freerdp_channels_client_load
If g_pInterface is set to NULL outside the critical section in one thread
while another thread is in the critical section, the channel client context
allocated in the VirtualChannelEntry won't end up getting freed.
The channel client context is normally loaded from g_pInterface in
FreeRDP_VirtualChannelInit and stored in the pChannelInitData, then copied
from there onto the pChannelOpenData structure in FreeRDP_VirtualChannelOpen
and finally freed in freerdp_channels_free.
Marc-André Moreau [Tue, 28 Jul 2015 20:01:34 +0000 (16:01 -0400)]
libfreerdp-codec: add x264 stubs
Marc-André Moreau [Tue, 28 Jul 2015 13:21:33 +0000 (09:21 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 28 Jul 2015 12:51:03 +0000 (08:51 -0400)]
Merge pull request #2799 from kaliway/scardlistreaders-fix
Smartcard Reader Connection Handling
Marc-André Moreau [Tue, 28 Jul 2015 12:47:06 +0000 (08:47 -0400)]
Merge pull request #2801 from bmiklautz/fix/thread
winpr/thread: small cleanups
Marc-André Moreau [Tue, 28 Jul 2015 12:46:27 +0000 (08:46 -0400)]
Merge pull request #2804 from bmiklautz/fix/misc
Misc fixes
Marc-André Moreau [Tue, 28 Jul 2015 12:44:58 +0000 (08:44 -0400)]
Merge pull request #2793 from rkondratenko/pcsclite-transactions
Fix for transactions support for Smart Cards
Bernhard Miklautz [Mon, 27 Jul 2015 09:24:21 +0000 (11:24 +0200)]
core/listner: fix possible problem in _free
Bernhard Miklautz [Fri, 24 Jul 2015 12:57:47 +0000 (14:57 +0200)]
winpr/thread: don't close invalid file descriptors
In case the file descriptor is -1 don't call close.
Bernhard Miklautz [Fri, 24 Jul 2015 12:52:31 +0000 (14:52 +0200)]
winrp/thread: don't call pthread_exit on return
As the pthread_exit man page states pthread_exit is called implicitly
when the start function returns.
Bernhard Miklautz [Fri, 24 Jul 2015 11:29:48 +0000 (13:29 +0200)]
winpr/event: remove critical section
The critical section isn't required and not used anymore since
commit
8a2220a3d9c5ad70b425a33772f14f3dbe956841.
Bernhard Miklautz [Thu, 23 Jul 2015 09:52:24 +0000 (11:52 +0200)]
winpr/thread: small cleanups
Also adds error checking of winpr_StartThread in winpr_StartThread.
Bernhard Miklautz [Thu, 23 Jul 2015 09:14:39 +0000 (11:14 +0200)]
Merge pull request #2789 from akallabeth/start_thread_fix
[Thread] Fixed mutex unlocking and return checks.
Kirill Kotyagin [Wed, 22 Jul 2015 14:25:17 +0000 (17:25 +0300)]
channels/smartcard: fix possible mszReaders leak in smartcard_ListReaders(A/W)_Call
Kirill Kotyagin [Wed, 22 Jul 2015 13:56:24 +0000 (16:56 +0300)]
channels/smartcard: make smartcard_ListReaders(A/W)_Call return PCSC error statuses to the server
Bernhard Miklautz [Mon, 20 Jul 2015 15:23:23 +0000 (17:23 +0200)]
Merge pull request #2751 from realjiangms/shadow_fix_compile_error_win
server/shadow: Fix compile error on win32.
Rostislav Kondratenko [Fri, 17 Jul 2015 15:13:41 +0000 (18:13 +0300)]
Removing private context on hCard so that transaction will properly unlock when context is released.
Rostislav Kondratenko [Fri, 17 Jul 2015 15:13:02 +0000 (18:13 +0300)]
Fixing condition on SCardIsValidContext to be true when context is valid
Rostislav Kondratenko [Fri, 17 Jul 2015 13:37:44 +0000 (16:37 +0300)]
Re-enabled PCSC-Lite transactions and fixed smartcard deinitialization so it will release all contexts to unblock calls waiting for transactions
MartinHaimberger [Fri, 17 Jul 2015 10:30:20 +0000 (12:30 +0200)]
Merge pull request #2791 from bmiklautz/100percent
transport: fix regression introduced with PR #2770
Bernhard Miklautz [Fri, 17 Jul 2015 10:06:41 +0000 (12:06 +0200)]
transport: fix regression introduced with PR #2770
When the event is reset in transport_check_fds xfreerdp doesn't work and
consumes 100% CPU (see #2790). On windows this is require otherwise the
CPU consumption is 100% there.
This quick fix only resets the event on windows. It's a working approach
but definitely not the final solution.
Armin Novak [Thu, 16 Jul 2015 11:48:14 +0000 (13:48 +0200)]
Fixed mutex unlocking and return checks.
Vic Lee [Thu, 16 Jul 2015 13:57:46 +0000 (06:57 -0700)]
Merge pull request #2770 from akallabeth/bio_event_reset
Resetting frontBio after read now.
MartinHaimberger [Wed, 15 Jul 2015 12:12:13 +0000 (14:12 +0200)]
Merge pull request #2723 from akallabeth/pwd_from_stdin
New /from-stdin
MartinHaimberger [Wed, 15 Jul 2015 12:10:44 +0000 (14:10 +0200)]
Merge pull request #2786 from mfleisz/fix_makecert
winpr/tools: Fixed x509_get_default_name failing with long computer names
Martin Fleisz [Wed, 15 Jul 2015 09:47:01 +0000 (11:47 +0200)]
winpr/tools: Fixed x509_get_default_name failing with long computer names
MartinHaimberger [Wed, 15 Jul 2015 07:47:43 +0000 (09:47 +0200)]
Merge pull request #2766 from akallabeth/snprintf_to_sprintf_s
Replaced snprintf with sprintf_s
Bernhard Miklautz [Tue, 14 Jul 2015 13:50:32 +0000 (15:50 +0200)]
Merge pull request #2782 from bmiklautz/order_does_matter
x11: reorder xf_post_disconnect
Bernhard Miklautz [Tue, 14 Jul 2015 13:28:55 +0000 (15:28 +0200)]
x11: reorder xf_post_disconnect
Channels like EGFX need resources like the main window in order to
work correctly. Before the window, GDI,.. is freed it needs to be
ensured that all channels are stopped properly to prevent them to access
already freed resources. Disconnecting the channels first fixed a
possible race condition/SEGFAULT that could occur with remote initiated
disconnects.
MartinHaimberger [Tue, 14 Jul 2015 11:02:41 +0000 (13:02 +0200)]
Merge pull request #2781 from bmiklautz/fdread
winpr/synch: remove the dependency on winsock.h
Bernhard Miklautz [Tue, 14 Jul 2015 10:21:24 +0000 (12:21 +0200)]
winpr/handle: define WINPR_FD_ on all platforms
Bernhard Miklautz [Tue, 14 Jul 2015 09:39:41 +0000 (11:39 +0200)]
winpr/synch: remove the dependency on winsock.h
winsock.h pulls in a lot of defines and dependencies that are not
required and partially unwanted in winpr's core (for parts that are not
related to network). In order to get rid of this dependency and have an
independent defines for extended winpr functions the WINPR_FD_* defines
are used internally (and for exposed functions). Where required, like in
WSAEventSelect, the FD_* is mapped to WINPR_FD_*.
Bernhard Miklautz [Mon, 13 Jul 2015 15:52:18 +0000 (17:52 +0200)]
Merge pull request #2778 from akallabeth/cert_store_compare_fix
Fixed comparison bug, cleanup and error handling.
Armin Novak [Mon, 13 Jul 2015 13:52:06 +0000 (15:52 +0200)]
Using lowercase hostname for comparison now.
fixed argument mixup.
Armin Novak [Mon, 13 Jul 2015 12:16:04 +0000 (14:16 +0200)]
Fixed comparison bug, cleanup and error handling.
Armin Novak [Thu, 9 Jul 2015 10:20:22 +0000 (12:20 +0200)]
Error checks for BIO_get_event
ResetEvent before reading data from transport BIO.
Marc-André Moreau [Wed, 8 Jul 2015 18:16:29 +0000 (14:16 -0400)]
channels/rdpgfx: fix TotalDecodedFrames counter
Marc-André Moreau [Wed, 8 Jul 2015 15:17:56 +0000 (11:17 -0400)]
channels/rdpgfx: reset state on channel close
Marc-André Moreau [Tue, 7 Jul 2015 17:36:36 +0000 (13:36 -0400)]
channels/drdynvc: use same status code as mstsc for DVC opening failure
Armin Novak [Tue, 7 Jul 2015 12:48:27 +0000 (14:48 +0200)]
Resetting frontBio after read now.
Marc-André Moreau [Mon, 6 Jul 2015 20:28:52 +0000 (16:28 -0400)]
channels/rdpgfx: improve frame ack handling
Armin Novak [Fri, 3 Jul 2015 11:26:15 +0000 (13:26 +0200)]
Replaced snprintf with sprintf_s
MartinHaimberger [Fri, 3 Jul 2015 11:04:37 +0000 (13:04 +0200)]
Merge pull request #2764 from akallabeth/pull_fixes
Pull fixes
Armin Novak [Fri, 3 Jul 2015 10:38:19 +0000 (12:38 +0200)]
Added missing include breaking windows build.
Armin Novak [Fri, 3 Jul 2015 10:31:29 +0000 (12:31 +0200)]
Fixed inverted bAttached setting.
If bAttached is TRUE, the resources of the event are not
cleaned up on CloseHandle.
MartinHaimberger [Fri, 3 Jul 2015 09:36:00 +0000 (11:36 +0200)]
Merge pull request #2762 from akallabeth/handle_write_event
Add write event support to HANDLE
Armin Novak [Fri, 3 Jul 2015 09:26:22 +0000 (11:26 +0200)]
Added error checks and resource cleanup.
Armin Novak [Fri, 3 Jul 2015 09:13:48 +0000 (11:13 +0200)]
Fixed pr comments.
MartinHaimberger [Fri, 3 Jul 2015 08:44:35 +0000 (10:44 +0200)]
Merge pull request #2761 from akallabeth/sample_server_port_arg
Updated sample server.
Armin Novak [Fri, 3 Jul 2015 07:56:43 +0000 (09:56 +0200)]
Updated sample server.
* Added new command line argument --port to allow starting the
sample server on a port different than default 3389.
* Using GetKnownSubPath now to determine location of temporary
directory for server socket.
* Using distinct server socket files for each port.
Armin Novak [Fri, 3 Jul 2015 07:36:58 +0000 (09:36 +0200)]
Handle API updated.
Armin Novak [Fri, 3 Jul 2015 07:29:36 +0000 (09:29 +0200)]
WSAEventSelect: Handle lNetworkEvents == 0
WSAEventSelect did ignore the lNetworkEvents argument.
In case this argument is 0, the non blocking socket must
be set to blocking again to mimic windows behavior.
Armin Novak [Fri, 3 Jul 2015 07:25:41 +0000 (09:25 +0200)]
Added write event support to handle functions.
Allows the WinPR HANDLE functions WaitForSingleObject and
WaitForMultipleObjects to signal in case of write events.
This is used by CreateFileDescriptor and SetEventFileDescriptor,
which got an API change accomodating for this new feature.
Armin Novak [Fri, 3 Jul 2015 07:22:02 +0000 (09:22 +0200)]
Added convenience function winpr_log_backtrace.
Bernhard Miklautz [Thu, 2 Jul 2015 14:28:55 +0000 (16:28 +0200)]
Merge pull request #2759 from bmiklautz/fix/cliprdp
x11/cliprdr: handle empty format names
Bernhard Miklautz [Thu, 2 Jul 2015 13:39:35 +0000 (15:39 +0200)]
x11/cliprdr: handle empty format names
The recently added strdup checks ignored the fact that format names
can be NULL.
Hardening [Thu, 2 Jul 2015 13:08:31 +0000 (15:08 +0200)]
Merge pull request #2747 from ilammy/egfx-missing-events
Do not discard events when updating EGFX surface mapping
Hardening [Thu, 2 Jul 2015 11:11:06 +0000 (13:11 +0200)]
Merge pull request #2758 from bmiklautz/fix/CreateProcess
CreateProcess misc fixes
Bernhard Miklautz [Thu, 2 Jul 2015 10:25:48 +0000 (12:25 +0200)]
CreateProcess: fix setting of default handler
If SA_SIGINFO isn't set in the flags sa_handler is used
instead of sa_sigaction.
This fixes also the compiler warning:
FreeRDP/winpr/libwinpr/thread/process.c: In function ‘_CreateProcessExA’:
FreeRDP/winpr/libwinpr/thread/process.c:282:20: warning: assignment from
incompatible pointer type [enabled by default]
Bernhard Miklautz [Thu, 2 Jul 2015 10:05:46 +0000 (12:05 +0200)]
CreateProcess: two fixes
* change to lpCurrentDirectory if set even if no token was supplied
* fix wrong check - add missing !
This was part of akallabeth's PR #2714.
Bernhard Miklautz [Thu, 2 Jul 2015 10:02:51 +0000 (12:02 +0200)]
Merge pull request #2757 from nfedera/nf-fix-createprocess-signals
winpr: fix CreateProcess signal handler issues
Norbert Federa [Thu, 2 Jul 2015 09:21:09 +0000 (11:21 +0200)]
winpr: fix CreateProcess signal handler issues
The calling thread of CreateProcess can be in any library and
can have arbitrary signal masks and handlers.
We now save the caller's mask and block all signals before forking.
After fork:
- child resets the handlers and unblocks all signals.
- parent restores the caller's original signal mask.
Hardening [Thu, 2 Jul 2015 07:27:27 +0000 (09:27 +0200)]
Merge pull request #2754 from akallabeth/mixed_code
Fixed mixed declarations and code.
Hardening [Thu, 2 Jul 2015 07:26:13 +0000 (09:26 +0200)]
Merge pull request #2750 from realjiangms/fix_win32_wsaevent
Fix event created for WSAEventSelect
zihao.jiang [Wed, 1 Jul 2015 14:28:51 +0000 (22:28 +0800)]
server/shadow: Remove comments in define.
Bernhard Miklautz [Wed, 1 Jul 2015 14:23:00 +0000 (16:23 +0200)]
Merge pull request #2753 from akallabeth/nla_null_auth_fix
nla: Fixed handling of optional TSPasswordCreds field.
Armin Novak [Wed, 1 Jul 2015 14:20:56 +0000 (16:20 +0200)]
Fixed mixed declarations and code.
Armin Novak [Wed, 1 Jul 2015 14:05:11 +0000 (16:05 +0200)]
NLA: Fixed length check.
Armin Novak [Wed, 1 Jul 2015 13:28:35 +0000 (15:28 +0200)]
Fixed handling of optional TSPasswordCreds field.
Martin Fleisz [Wed, 1 Jul 2015 12:49:00 +0000 (14:49 +0200)]
Merge pull request #2752 from akallabeth/nla_user_length_fix
NLA decrypt credentials fixed.
Armin Novak [Wed, 1 Jul 2015 12:31:55 +0000 (14:31 +0200)]
NLA decrypt credentials fixed.
Norbert Federa [Wed, 1 Jul 2015 11:02:32 +0000 (13:02 +0200)]
Merge pull request #2738 from bmiklautz/ffuncs
hardening: check fread and fwrite return values
Bernhard Miklautz [Wed, 1 Jul 2015 10:22:32 +0000 (12:22 +0200)]
Integrate pull request feedback
* unify fwrite usage - set nmemb to 1 and the size to the size to write.
zihao.jiang [Tue, 30 Jun 2015 17:13:28 +0000 (01:13 +0800)]
Fix event created for WSAEventSelect: The event we pass to WSAEventSelect should be WSAEVENT instead of normal event.
From MSDN, it looks same as CreateEvent(NULL, FALSE, FALSE, NULL):
The WSACreateEvent function creates a manual-reset event object with an initial state of nonsignaled. The event object is unnamed.
However they are not really equivalent. When we use normal event, the WSAEventSelect still works but the event appears to be 'auto-reset'.
zihao.jiang [Tue, 30 Jun 2015 17:29:43 +0000 (01:29 +0800)]
server/shadow: Fix compile error on win32.
ilammy [Tue, 30 Jun 2015 09:41:23 +0000 (12:41 +0300)]
client/x11: do not discard events when updating EGFX surface mapping
Passing True to XSync() discards any pending X11 events. Occasionally
this caused ButtonRelease or KeyRelease to be lost and not forwarded
to the remote computed, leading to stuck keys and buttons.
This should resolve issue #2391
Bernhard Miklautz [Tue, 30 Jun 2015 08:46:38 +0000 (10:46 +0200)]
Merge pull request #2745 from mfleisz/fix_makecert
makecert: Fix double free crashes
Martin Fleisz [Tue, 30 Jun 2015 06:14:28 +0000 (08:14 +0200)]
makecert: Fix incorrect return value check
Marc-André Moreau [Mon, 29 Jun 2015 18:47:46 +0000 (14:47 -0400)]
channels/drdynvc: silence harmless warnings with Windows 8 / Windows 2012 channel close
Marc-André Moreau [Mon, 29 Jun 2015 16:43:18 +0000 (12:43 -0400)]
libfreerdp-core: fix receiving of logon error info during capability exchange
Martin Fleisz [Mon, 29 Jun 2015 16:10:59 +0000 (18:10 +0200)]
makecert: Formatting