platform/upstream/gstreamer.git
4 years agoBack to development
Tim-Philipp Müller [Fri, 3 Jul 2020 01:03:56 +0000 (02:03 +0100)]
Back to development

4 years agoRelease 1.17.2
Tim-Philipp Müller [Thu, 2 Jul 2020 23:31:17 +0000 (00:31 +0100)]
Release 1.17.2

4 years agowpe: Update plugin's doc cache
Philippe Normand [Thu, 2 Jul 2020 11:37:47 +0000 (12:37 +0100)]
wpe: Update plugin's doc cache

This was forgotten in !1392.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1402>

4 years agov4l2decoder: Track pending request
Nicolas Dufresne [Wed, 1 Jul 2020 16:28:05 +0000 (12:28 -0400)]
v4l2decoder: Track pending request

With the asynchronous slice decoding, we only queue up to 2 slices
per frames. That side effect is that now we are dequeuing bitstream
buffers in both decoding and presentation order. This would lead to
a bitstream buffer from a previous frame being dequeued instead of
the expected last slice buffer and lead to us trying to queue an
already queued bitstream buffer.

We now fix this by tracking pending requests. As request are executed
in decoding order, we marking a request done, we can effectively
dequeue bitstream buffer from all previous request, as they have been
executed already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2decoder: Improve debug tracing
Nicolas Dufresne [Wed, 1 Jul 2020 16:26:36 +0000 (12:26 -0400)]
v4l2decoder: Improve debug tracing

Add some missing traces and move per-slice operation to TRACE level to
reduce the noise level.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2decoder: Convert request pool to GstQueueArray
Nicolas Dufresne [Wed, 1 Jul 2020 16:23:49 +0000 (12:23 -0400)]
v4l2decoder: Convert request pool to GstQueueArray

The decoder is not being access from multiple threads, instead it is
always protected by the streaming lock. For this reason, a
GstAtomicQueue for the request pool is overkill and may even introduce
unneeded overhead. Use a GstQueueArray in replacement, the
GstQueueArray is a good fit since the number of item is predictable and
unlikely to vary at run-time.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Wait on previous pending request in slice mode
Nicolas Dufresne [Mon, 29 Jun 2020 17:27:32 +0000 (13:27 -0400)]
v4l2slh264dec: Wait on previous pending request in slice mode

In slice mode, we'll do one request per slice. In order to recycle
bitstream buffer, and not run-out, wait for the last pending
request to complete and mark it done.

We only wait after having queued the current slice in order to reduce
that potential driver starvation and maintain performance (using dual
buffering).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Renew bitstream buffer after submitting slice
Nicolas Dufresne [Mon, 29 Jun 2020 17:25:39 +0000 (13:25 -0400)]
v4l2slh264dec: Renew bitstream buffer after submitting slice

Submitting a slice actually clears the bitstream buffer. Ensure we
have a newly allocated bitstream buffer for the next slice.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Factor out bitstream allocation
Nicolas Dufresne [Mon, 29 Jun 2020 17:23:12 +0000 (13:23 -0400)]
v4l2slh264dec: Factor out bitstream allocation

No functional changes.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Add a helper to ensure output buffer
Nicolas Dufresne [Mon, 29 Jun 2020 17:04:56 +0000 (13:04 -0400)]
v4l2slh264dec: Add a helper to ensure output buffer

In preparation of multi-slice decoding, we will decode multiple
slices into the same buffer. This will ensure we have a buffer to
decode to, queued into the driver.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Factor out request wait
Nicolas Dufresne [Mon, 29 Jun 2020 16:39:08 +0000 (12:39 -0400)]
v4l2slh264dec: Factor out request wait

This will be reused to wait for previous slices to be complete
when dealing with following slices (in slice decoding mode).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Remove double return in submit_bitstream()
Nicolas Dufresne [Mon, 29 Jun 2020 16:14:36 +0000 (12:14 -0400)]
v4l2slh264dec: Remove double return in submit_bitstream()

This is code cleanup, no functional changes.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agov4l2slh264dec: Fix typo in debug trace
Nicolas Dufresne [Mon, 29 Jun 2020 16:06:34 +0000 (12:06 -0400)]
v4l2slh264dec: Fix typo in debug trace

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1395>

4 years agodocs: remove gst prefix from plugin titles
Mathieu Duponchelle [Thu, 2 Jul 2020 16:10:21 +0000 (18:10 +0200)]
docs: remove gst prefix from plugin titles

4 years agodocs: Update plugin cache for Windows plugins
Seungha Yang [Sun, 28 Jun 2020 15:54:50 +0000 (00:54 +0900)]
docs: Update plugin cache for Windows plugins

4 years agoplugins: Update for documentation of Windows plugins
Seungha Yang [Mon, 8 Jun 2020 15:20:08 +0000 (00:20 +0900)]
plugins: Update for documentation of Windows plugins

* Add Since marks
* Make use of GST_PARAM_CONDITIONALLY_AVAILABLE flag

4 years agonvcodec: Update for documentation
Seungha Yang [Mon, 8 Jun 2020 16:30:39 +0000 (01:30 +0900)]
nvcodec: Update for documentation

* Add Since marks
* Make use of GST_PARAM_CONDITIONALLY_AVAILABLE flag
* Add documentation template caps

4 years agowpe: Set documentation caps
Philippe Normand [Wed, 1 Jul 2020 08:00:41 +0000 (09:00 +0100)]
wpe: Set documentation caps

As the caps template can vary depending on the WPEBackend-FDO version
found at build time, set a fixed template for the generate documentation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1392>

4 years agovideoparsers: Fix parsing ATSC bar data
Jan Alexander Steffens (heftig) [Wed, 1 Jul 2020 15:54:01 +0000 (17:54 +0200)]
videoparsers: Fix parsing ATSC bar data

It rejected the case of all bars being disabled.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394>

4 years agovideoparsers: Fix parsing of ATSC AFD data
Jan Alexander Steffens (heftig) [Wed, 1 Jul 2020 15:52:39 +0000 (17:52 +0200)]
videoparsers: Fix parsing of ATSC AFD data

The test for 0x40 being set is repeated by
gst_video_parse_utils_parse_afd, which also extracts the low nibble
again, so we must not clear it here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394>

4 years agovideoparsers: Give gstvideoparseutils.c a debug category
Jan Alexander Steffens (heftig) [Wed, 1 Jul 2020 15:51:36 +0000 (17:51 +0200)]
videoparsers: Give gstvideoparseutils.c a debug category

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1394>

4 years agoccconverter: fail negotiation when framerate conversion is not possible
Matthew Waters [Wed, 1 Jul 2020 10:28:01 +0000 (20:28 +1000)]
ccconverter: fail negotiation when framerate conversion is not possible

Converting between anything but cdp will fail at converting
framerates and negotiation should reflect that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1393>

4 years agoccconverter: fix missing output framerate on the caps
Matthew Waters [Wed, 1 Jul 2020 09:41:33 +0000 (19:41 +1000)]
ccconverter: fix missing output framerate on the caps

A pipeline like this:

closedcaption/x-cea-708,format=cdp,framerate=30000/1001 ! ccconverter ! closedcaption/x-cea-708,format=cc_data

would produce a critical/assert:

GStreamer-CRITICAL **: 14:21:11.509: gst_util_fraction_multiply: assertion 'a_d != 0' failed

because there would be no framerate field on ccconverter's output.

Fixed by always fixating a framerate if the input has a framerate.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1393>

4 years agortmp2: Set connect args like libavformat does
Jan Alexander Steffens (heftig) [Mon, 29 Jun 2020 18:25:27 +0000 (20:25 +0200)]
rtmp2: Set connect args like libavformat does

To improve our compatibility. Critically, a server might elide data for
codecs we don't advertise.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384>

4 years agortmp2: Add support for AGGREGATE messages
Jan Alexander Steffens (heftig) [Mon, 29 Jun 2020 17:47:16 +0000 (19:47 +0200)]
rtmp2: Add support for AGGREGATE messages

They're multiple frames (tags) of FLV data wrapped into a message.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384>

4 years agortmp2: Move FLV tag header parsing into rtmputils.c
Jan Alexander Steffens (heftig) [Mon, 29 Jun 2020 17:46:53 +0000 (19:46 +0200)]
rtmp2: Move FLV tag header parsing into rtmputils.c

To be shared with the AGGREGATE handling.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384>

4 years agortmp2: Mark our memory singleton as leakable
Jan Alexander Steffens (heftig) [Mon, 29 Jun 2020 18:57:06 +0000 (20:57 +0200)]
rtmp2: Mark our memory singleton as leakable

So it doesn't appear in the leaks tracer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384>

4 years agortmp2: Remove GST_ERROR from rtmputils.c
Jan Alexander Steffens (heftig) [Mon, 29 Jun 2020 17:46:06 +0000 (19:46 +0200)]
rtmp2: Remove GST_ERROR from rtmputils.c

This file does not have debug logging set up.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1384>

4 years agoavtp: documentation fixes
Tim-Philipp Müller [Wed, 1 Jul 2020 11:35:32 +0000 (12:35 +0100)]
avtp: documentation fixes

Unclear why hotdoc wants 'gstavtp' as the plugin name here,
that's just wrong.

Add since marker and mark private subclasses as plugin API
so hotdoc knows they belong to the plugin and aren't external.

Fix GstAvtpAafTstampMode get_type() function.

4 years agodocs: update plugin cache with avtp plugin
Tim-Philipp Müller [Wed, 1 Jul 2020 10:17:08 +0000 (11:17 +0100)]
docs: update plugin cache with avtp plugin

CI picks this up now because the wrap was re-added in gst-build.

4 years agocodecs: h264decoder: Fix for DPB size calculation
Seungha Yang [Mon, 29 Jun 2020 21:23:07 +0000 (06:23 +0900)]
codecs: h264decoder: Fix for DPB size calculation

Some bitstreams might require more DPB size than that of what we've
calculated.

This change should've been part of initial commit of h264 stateless
codec implementation but it was missed.

See also https://chromium-review.googlesource.com/c/chromium/src/+/760276/

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1385>

4 years agompegtsmux: Correctly set ISO-639 language descriptor
Andreas Frisch [Thu, 25 Jun 2020 14:38:30 +0000 (16:38 +0200)]
mpegtsmux: Correctly set ISO-639 language descriptor

fixes #1340
Only 2 of the necessary 3 letters were copied because the teminating '\0'
needs to be counted, too - cf.
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strlcat

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1375>

4 years agowebrtcbin: Expose "latency" property
Olivier Crête [Tue, 23 Jun 2020 19:35:06 +0000 (15:35 -0400)]
webrtcbin: Expose "latency" property

This property sets the latency both on the rtpbin/rtpjittbuffer, but
also on the RTPStorage elements currently used by the FEC decoder.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1367>

4 years agodxgiscreencapsrc: Add missing debug category init
Seungha Yang [Mon, 29 Jun 2020 17:48:50 +0000 (02:48 +0900)]
dxgiscreencapsrc: Add missing debug category init

This should've been addressed in the commit 90420620722d4490ecfb4ade046b95d214f993d9
but I was missed it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1383>

4 years agocodecs: h264picture: use g_array_remove_index_fast()
Víctor Manuel Jáquez Leal [Sun, 14 Jun 2020 18:47:46 +0000 (20:47 +0200)]
codecs: h264picture: use g_array_remove_index_fast()

This algorithm is faster than the normal one. The problem is it
disorders the elements in the dpb, but it does not seem to mess
decoders.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1378>

4 years agowlvideoformat: fix typo in the format list
Michael Olbrich [Sun, 28 Jun 2020 16:54:54 +0000 (18:54 +0200)]
wlvideoformat: fix typo in the format list

DRM_FORMAT_ARGB8888 was actually used twice in the list for different SHM /
Gstreamer formats. In this case DRM_FORMAT_ABGR8888 is the correct format.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1382>

4 years agova: VA-API H.264 decoder and infrastructure
Víctor Manuel Jáquez Leal [Sun, 22 Mar 2020 18:00:50 +0000 (19:00 +0100)]
va: VA-API H.264 decoder and infrastructure

New plugin with an element for H.264 decoding with VA-API. This novel
approach, different from gstreamer-vaapi, uses gstcodecs library for
state handling.

The code is expected to looks cleaner because it uses VA-API without
further layers or wrappers.

* It uses the first supported DRM device as default VA display (other
  displays will be supported through user's GstContext)
* Requires libva >= 1.6
* No multiview/stereo profiles neither interlaced streams because
  gstcodecs doesn't handle them yet
* It is incompatible with gstreamer-vaapi
* Even if memory:VAMemory is exposed, it is not handled yet by any
  other element
* Caps templates are generated dynamically querying VAAPI, but YV12
  and I420 are added for system memory caps because they seem to be
  supported for all the drivers when downloading frames onto main
  memory, as they are used by xvimagesink and others, avoiding color
  conversion.
* Surfaces aren't bounded to context, so they can grow beyond the DBP
  size, allowing smooth reverse playback.
* There isn't yet error handling and recovery.
* 10-bit H.264 streams aren't supported by libva.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1379>

4 years agocodecs: h264decoder: update max_dpb_frames only if VUI is present
Víctor Manuel Jáquez Leal [Sat, 27 Jun 2020 11:18:34 +0000 (13:18 +0200)]
codecs: h264decoder: update max_dpb_frames only if VUI is present

There are some streams, with HRD, where the the calculated
max_dpb_frames is zero (max_dpb_mbs is less than size mb). In order to
get the dbp size it is required to rely on the VUI parameters if they
are present.

According to the spec Annex E.2.1

**max_dec_frame_buffering** specifies the required size of the HRD
decoded picture buffer (DPB) in units of frame buffers.  It is a
requirement of bitstream conformance that the coded video sequence
shall not require a decoded picture buffer with size of more than
Max(1, max_dec_frame_buffering) frame buffers to enable the output of
decoded pictures at the output times specified by dpb_output_delay of
the picture timing SEI messages. The value of max_dec_frame_buffering
shall be greater than or equal to max_num_ref_frames. An upper bound
for the value of max_dec_frame_buffering is specified by the level
limits in clauses A.3.1, A.3.2, G.10.2.1, and H.10.2.

When the max_dec_frame_buffering syntax element is not present, the
value of max_dec_frame_buffering shall be inferred as follows:

– If profile_idc is equal to 44, 86, 100, 110, 122, or 244 and
constraint_set3_flag is equal to 1, the value of
max_dec_frame_buffering shall be inferred to be equal to 0.

– Otherwise (profile_idc is not equal to 44, 86, 100, 110, 122, or 244
or constraint_set3_flag is equal to 0), the value of
max_dec_frame_buffering shall be inferred to be equal to MaxDpbFrames.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1381>

4 years agogstdtlsconnection: Propagate errors from key export to the caller
Sebastian Dröge [Fri, 26 Jun 2020 07:20:04 +0000 (10:20 +0300)]
gstdtlsconnection: Propagate errors from key export to the caller

Otherwise the DTLS connection silently does nothing instead of reporting
an error via the elements.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1156>

4 years agodtlsconnection: do not set keys_exported flag if actually not exported
Miguel Paris [Wed, 1 Apr 2020 16:08:45 +0000 (18:08 +0200)]
dtlsconnection: do not set keys_exported flag if actually not exported

keys_exported flag should be set only if keys are actually exported.
For that the next conditions are needed:
  1 - SSL_export_keying_material on success
  2 - SSL_get_selected_srtp_profile returns a valid profile
  3 - The profile ID is SRTP_AES128_CM_SHA1_80 or SRTP_AES128_CM_SHA1_32

Also don't crash if NULL is returned as profile.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1156>

4 years agod3d11h265dec: Fix possible invalid memory access
Seungha Yang [Thu, 25 Jun 2020 10:41:52 +0000 (19:41 +0900)]
d3d11h265dec: Fix possible invalid memory access

The number of element to copy should be num_tile_columns_minus1
and num_tile_rows_minus1.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1374>

4 years agonvh265sldec: Fix possible invalid memory access
Seungha Yang [Thu, 25 Jun 2020 10:26:45 +0000 (19:26 +0900)]
nvh265sldec: Fix possible invalid memory access

Fix Coverity issues.

CID 1464959, 1464960, 1464961, 1464962

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1374>

4 years agointerlace: Make caps writable before modifying them
Vivia Nikolaidou [Thu, 25 Jun 2020 13:05:39 +0000 (16:05 +0300)]
interlace: Make caps writable before modifying them

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1373>

4 years agoccextractor: Push a GAP event if we have a caption pad but a video buffer did not...
Sebastian Dröge [Wed, 24 Jun 2020 13:34:20 +0000 (16:34 +0300)]
ccextractor: Push a GAP event if we have a caption pad but a video buffer did not contain any captions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1371>

4 years agoccextractor: Add property to remove caption meta from the outgoing video buffers
Sebastian Dröge [Wed, 24 Jun 2020 10:33:39 +0000 (13:33 +0300)]
ccextractor: Add property to remove caption meta from the outgoing video buffers

This is disabled by default to keep backwards compatibility.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1371>

4 years agod3d11videosink: Disable d3d11videosink depending on supported feature level
Seungha Yang [Mon, 15 Jun 2020 19:41:14 +0000 (04:41 +0900)]
d3d11videosink: Disable d3d11videosink depending on supported feature level

Current shader code is not compatible with HLSL profile "ps_4_0_level_9_3"
or lower. So d3dcompiler cannot compile our shader code in that case.
Note that VirtualBox is one known driver which doesn't support currently
implemented shader code.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1343>

4 years agomxfvanc: document new sink pad template
Mathieu Duponchelle [Wed, 24 Jun 2020 19:18:15 +0000 (19:18 +0000)]
mxfvanc: document new sink pad template

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1368>

4 years agomxfdemux/mux: Add support for CEA-708 CDP from S436 essence tracks
Sebastian Dröge [Tue, 23 Jun 2020 20:40:38 +0000 (23:40 +0300)]
mxfdemux/mux: Add support for CEA-708 CDP from S436 essence tracks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1368>

4 years agoavfvideosrc: wait for permissions request dialog callback
Kevin King [Tue, 23 Jun 2020 22:31:51 +0000 (15:31 -0700)]
avfvideosrc: wait for permissions request dialog callback

otherwise gstreamer gives up on transitioning the pipeline before the
user has accepted

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1370>

4 years agointerlace: Switch field-pattern on the fly
Vivia Nikolaidou [Fri, 19 Jun 2020 11:30:04 +0000 (14:30 +0300)]
interlace: Switch field-pattern on the fly

The frame rate interlace uses changes when we change field-pattern, so
we need to issue a reconfigure event.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1364>

4 years agonvh264sldec: Remove useless double space
Seungha Yang [Mon, 22 Jun 2020 11:15:13 +0000 (20:15 +0900)]
nvh264sldec: Remove useless double space

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1357>

4 years agonvcodec: Add H265 stateless codec implementation
Seungha Yang [Fri, 19 Jun 2020 20:57:59 +0000 (05:57 +0900)]
nvcodec: Add H265 stateless codec implementation

Add a new GstCodecs based H265 decoder element

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1357>

4 years agonvcodec: Move common methods to nvdecoder
Seungha Yang [Thu, 18 Jun 2020 19:50:26 +0000 (04:50 +0900)]
nvcodec: Move common methods to nvdecoder

... and remove all #ifdef from nvh264sldec implementation.
New helper methods will take care of OpenGL specific ones.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1357>

4 years agonvh264sldec: Declare OpenGL related objects unconditionally
Seungha Yang [Thu, 18 Jun 2020 19:36:15 +0000 (04:36 +0900)]
nvh264sldec: Declare OpenGL related objects unconditionally

GstGLDisplay and GstGLContext are subclass of GstObject so we can
remove #ifdef for such object. This is prework for nvh265sldec.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1357>

4 years agonvh264sldec: Fix for possible wrong device selction
Seungha Yang [Thu, 18 Jun 2020 19:10:48 +0000 (04:10 +0900)]
nvh264sldec: Fix for possible wrong device selction

decoder should select assigned CUDA device id

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1357>

4 years agomeson: Add missing pc file for gstphotography
Nirbheek Chauhan [Tue, 23 Jun 2020 14:01:42 +0000 (19:31 +0530)]
meson: Add missing pc file for gstphotography

This is supposed to be used by apps like Cheese, and is a public
library.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1365>

4 years agomeson: Add missing pkgconfig files for gsttranscoder
Nirbheek Chauhan [Tue, 23 Jun 2020 13:33:12 +0000 (19:03 +0530)]
meson: Add missing pkgconfig files for gsttranscoder

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1365>

4 years agointerlace: Re-indentation
Vivia Nikolaidou [Fri, 19 Jun 2020 07:50:12 +0000 (10:50 +0300)]
interlace: Re-indentation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Don't change field-pattern on PAUSED or PLAYING state
Vivia Nikolaidou [Thu, 18 Jun 2020 20:52:01 +0000 (23:52 +0300)]
interlace: Don't change field-pattern on PAUSED or PLAYING state

It would otherwise change the caps the element produces and cause the
element to misbehave

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Don't fail negotiation if capsfilters decide framerate
Vivia Nikolaidou [Thu, 18 Jun 2020 19:56:57 +0000 (22:56 +0300)]
interlace: Don't fail negotiation if capsfilters decide framerate

Try to negotiate if the framerates on either sides of the interlace are
decided using capsfilters and the framerates are correct. Otherwise the
following pipelines would fail to negotiate:

gst-launch-1.0 videotestsrc !
video/x-raw,framerate=24/1,interlace-mode=progressive ! interlace
field-pattern=2 ! video/x-raw,framerate =30/1 ! fakesink

gst-launch-1.0 videotestsrc !
video/x-raw,framerate=60/1,interlace-mode=progressive ! interlace
field-pattern=0 ! video/x-raw,framerate=30/1 ! fakesink

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Restrict passthrough conditions
Vivia Nikolaidou [Thu, 18 Jun 2020 19:15:08 +0000 (22:15 +0300)]
interlace: Restrict passthrough conditions

Don't do passthrough if interleave-mode=mixed or if we have one of the
telecine modes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Add field switching mode for 2:2 field pattern
Vivia Nikolaidou [Thu, 18 Jun 2020 18:10:56 +0000 (21:10 +0300)]
interlace: Add field switching mode for 2:2 field pattern

In the 2:2 field pattern, interlace can switch from bottom-field-first
to top-field-first.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Only half the framerate for 1:1 field pattern
Vivia Nikolaidou [Thu, 18 Jun 2020 18:11:17 +0000 (21:11 +0300)]
interlace: Only half the framerate for 1:1 field pattern

Keep the framerate for 2:2 field pattern, and completely remove it from
the caps for all others. Otherwise, negotiation will fail if caps on
both sides of the element specify a framerate.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agointerlace: Add FIXME comment about false passthrough bug
Vivia Nikolaidou [Thu, 18 Jun 2020 17:41:35 +0000 (20:41 +0300)]
interlace: Add FIXME comment about false passthrough bug

If interlace-mode is missing from upstream caps, we can falsely do
passthrough when in fact we'd have to switch fields.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1349>

4 years agodocs: Update plugins cache
Thibault Saunier [Tue, 23 Jun 2020 16:30:51 +0000 (12:30 -0400)]
docs: Update plugins cache

4 years agoopenmpt: Namespace enum GType names
Thibault Saunier [Tue, 23 Jun 2020 15:36:15 +0000 (11:36 -0400)]
openmpt: Namespace enum GType names

4 years agodocs: Unmark wrongly marked plugin API types
Thibault Saunier [Tue, 23 Jun 2020 15:33:45 +0000 (11:33 -0400)]
docs: Unmark wrongly marked plugin API types

4 years agodocs: Document basecamerabinsrc
Thibault Saunier [Tue, 23 Jun 2020 14:03:04 +0000 (10:03 -0400)]
docs: Document basecamerabinsrc

4 years agodocs: mark more types as plugin API
Mathieu Duponchelle [Tue, 23 Jun 2020 00:51:48 +0000 (02:51 +0200)]
docs: mark more types as plugin API

4 years agoplugins_cache: add base classes
Mathieu Duponchelle [Mon, 22 Jun 2020 22:12:59 +0000 (00:12 +0200)]
plugins_cache: add base classes

4 years agomeson: mark plugins cache target as always stale
Mathieu Duponchelle [Mon, 22 Jun 2020 22:05:36 +0000 (00:05 +0200)]
meson: mark plugins cache target as always stale

4 years agodocs: mark more types as plugin API
Mathieu Duponchelle [Sat, 20 Jun 2020 23:32:50 +0000 (01:32 +0200)]
docs: mark more types as plugin API

4 years agodocs: generate documentation for libgstopencv
Mathieu Duponchelle [Sat, 20 Jun 2020 23:32:29 +0000 (01:32 +0200)]
docs: generate documentation for libgstopencv

4 years agodoc: Stop documenting properties from parents
Thibault Saunier [Fri, 19 Jun 2020 23:40:52 +0000 (19:40 -0400)]
doc: Stop documenting properties from parents

4 years agoaudiobuffersplit: Specify in the template caps that only interleaved audio is supported
Sebastian Dröge [Tue, 23 Jun 2020 06:50:46 +0000 (09:50 +0300)]
audiobuffersplit: Specify in the template caps that only interleaved audio is supported

Needs special support for non-interleaved audio and e.g. use the
GstPlanarAudioAdapter.

See https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/779

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1363>

4 years agowebrtcbin: Don't call gst_ghost_pad_construct() anymore
Sebastian Dröge [Mon, 22 Jun 2020 09:32:50 +0000 (12:32 +0300)]
webrtcbin: Don't call gst_ghost_pad_construct() anymore

It's deprecated, unneeded and doesn't do anything anymore.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1360>

4 years agoRevert "h264parse: Include `interlace-mode` in caps"
Vivia Nikolaidou [Thu, 18 Jun 2020 18:21:26 +0000 (21:21 +0300)]
Revert "h264parse: Include `interlace-mode` in caps"

This reverts commit b75a61342f4ea039d922a966f36b02cd9d9c3ad8.

The parser would only set the mode to progressive or mixed, missing the
cases where it should have been interleaved. Interleaved is more
difficult to detect because in h264 it happens per frame. On the other
hand, h264 decoders detect the interlacing information per-frame and set
the caps correctly. By giving potentially incorrect interlacing
information in the parser already, it's being enforced downstream even
after decoding, breaking some use cases (e.g. an encoder can't properly
mark the stream as TFF or BFF). On the other hand, there's no valid use
case for having interlacing information on the caps at the parsing
stage, so after a lot of discussion, it was decided to revert this.

Initial commit message:
=========================
Those are the rules:

In the SPS:
  * if frame_mbs_only_flag=1 => all frame progressive
  * if frame_mbs_only_flag=0 => field_pic_flag defines if each frame is
    progressive or interlaced, thus the mode is 'mixed' in GStreamer
    terms.

https://bugzilla.gnome.org/show_bug.cgi?id=779309
=========================

Fixes #1313

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1335>

4 years agod3d11window_win32: Chain up mouse event to parent window
Seungha Yang [Mon, 22 Jun 2020 09:42:45 +0000 (18:42 +0900)]
d3d11window_win32: Chain up mouse event to parent window

Unlike key event, mouse event will not be chained up to parent window
by DefWindowProc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1361>

4 years agodxgiscreencapsrc: Load HLSL compiler library using g_module_open
Seungha Yang [Fri, 19 Jun 2020 13:14:29 +0000 (22:14 +0900)]
dxgiscreencapsrc: Load HLSL compiler library using g_module_open

Depending on OS version, available d3dcompiler library name is different.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agodxgiscreencapsrc: Reorganize debug category usage
Seungha Yang [Fri, 19 Jun 2020 14:02:45 +0000 (23:02 +0900)]
dxgiscreencapsrc: Reorganize debug category usage

Use the same debug category in all dxgiscreencap related source code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agowinscreencap: Remove trailing whitespaces
Seungha Yang [Fri, 19 Jun 2020 12:43:15 +0000 (21:43 +0900)]
winscreencap: Remove trailing whitespaces

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agod3d11device: Print supported DXGI format for debugging
Seungha Yang [Fri, 19 Jun 2020 12:34:32 +0000 (21:34 +0900)]
d3d11device: Print supported DXGI format for debugging

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agod3d11: Load HLSL compiler library using g_module_open
Seungha Yang [Fri, 19 Jun 2020 12:24:59 +0000 (21:24 +0900)]
d3d11: Load HLSL compiler library using g_module_open

Depending on OS version, available d3dcompiler library name is different.
But for UWP, we can still use the current way

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agod3d11shader: Add missing config.h include
Seungha Yang [Fri, 19 Jun 2020 11:40:24 +0000 (20:40 +0900)]
d3d11shader: Add missing config.h include

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1355>

4 years agowebrtc: fix ice control mode when we offer initially
Matthew Waters [Sun, 21 Jun 2020 06:02:43 +0000 (16:02 +1000)]
webrtc: fix ice control mode when we offer initially

An initial offer means we have a local description not a remote
description.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1332

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1358>

4 years agomediafoundation: Add VP9 encoder element
Seungha Yang [Sun, 24 May 2020 15:15:14 +0000 (00:15 +0900)]
mediafoundation: Add VP9 encoder element

Some Intel GPUs support hardware accelerated VP9 encoding and
Microsoft provides software VP9 encoding implementation as well.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1295>

4 years agofdkaacenc: Add missing SURROUND mappings
Vivia Nikolaidou [Thu, 18 Jun 2020 09:15:09 +0000 (12:15 +0300)]
fdkaacenc: Add missing SURROUND mappings

SURROUND is more to spec according to the FIXME comments, so add this.

Also add SIDE for 5 and 5.1 because of ffmpeg compatibility, because the
following pipeline downmixes to mono otherwise:

gst-launch-1.0 audiotestsrc num-buffers=1 ! audio/x-raw, channels=6 !
avenc_ac3 ! avdec_ac3 ! audioconvert ! fdkaacenc ! fakesink -v

Fixes #1327

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1352>

4 years agovulkan: log extension/layers available/enabled on instance/device creation
Matthew Waters [Sun, 14 Jun 2020 15:38:03 +0000 (01:38 +1000)]
vulkan: log extension/layers available/enabled on instance/device creation

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/device: expose extension/layer choices
Matthew Waters [Sun, 14 Jun 2020 15:26:08 +0000 (01:26 +1000)]
vulkan/device: expose extension/layer choices

Extensions and layers can be enabled before calling
gst_vulkan_device_open().  The available extensions are stored in
GstVulkanPhysicalDevice.

Defaults are still the same.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/instance: privatise defult debug callback
Matthew Waters [Sun, 14 Jun 2020 11:04:37 +0000 (21:04 +1000)]
vulkan/instance: privatise defult debug callback

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/instance: expose extension/layer choices
Matthew Waters [Sun, 14 Jun 2020 11:00:06 +0000 (21:00 +1000)]
vulkan/instance: expose extension/layer choices

Extensions and layers can be enabled before calling
gst_vulkan_instance_open() but after calling
gst_vulkan_instance_fill_info().

Use the list of available extensions to better choose a default display
implementation to use based on the available Vulkan extensions for surface
output.

Defaults are still the same.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/physical-device: dump some more information to logs
Matthew Waters [Sat, 13 Jun 2020 07:40:02 +0000 (17:40 +1000)]
vulkan/physical-device: dump some more information to logs

Also dump the Vulkan 1.1 and Vulkan 1.2 device properties/features
where supported.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/instance: add vulkan API version selection and checking
Matthew Waters [Sat, 13 Jun 2020 07:31:07 +0000 (17:31 +1000)]
vulkan/instance: add vulkan API version selection and checking

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agovulkan/wayland: initialise debug category before debug logging
Matthew Waters [Sat, 13 Jun 2020 07:29:57 +0000 (17:29 +1000)]
vulkan/wayland: initialise debug category before debug logging

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1341>

4 years agonalutils: Improve slightly the error trace
Nicolas Dufresne [Fri, 19 Jun 2020 16:15:53 +0000 (12:15 -0400)]
nalutils: Improve slightly the error trace

Until now, bound check would simply trace the values and the range. This
enhances the trace by also tracing the name of the variable that was to be set
or read. This is not magically perfect in all cases, but greatly speed the
debugging work. Here's an example before and after this change:

Before: gst_h264_parser_parse_slice_hdr: value not in allowed range. value: 819183, range -87-77
After:  gst_h264_parser_parse_slice_hdr: value for 'slice->slice_qp_delta' not in allowed range. value: 819183, range -87-77
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1356>

4 years agoRevert "errorignore: Added convert-error signal"
Jan Alexander Steffens (heftig) [Thu, 12 Dec 2019 11:58:24 +0000 (12:58 +0100)]
Revert "errorignore: Added convert-error signal"

The introduced API has [some problems][1] and [a better solution][2] was
found that made the feature obsolete.

This reverts commit f7626c1f2ac14a34991723df6c28f54af38fcbc4.

[1]: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/736#note_357702
[2]: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/736#note_238830

https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/916

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/916>

4 years agoBack to development
Tim-Philipp Müller [Fri, 19 Jun 2020 23:28:22 +0000 (00:28 +0100)]
Back to development

4 years agoRelease 1.17.1
Tim-Philipp Müller [Fri, 19 Jun 2020 18:22:18 +0000 (19:22 +0100)]
Release 1.17.1

4 years agosrt: add "empty" subclasses for deprecated srt{client,server}{src,sink}
Tim-Philipp Müller [Fri, 19 Jun 2020 16:20:02 +0000 (17:20 +0100)]
srt: add "empty" subclasses for deprecated srt{client,server}{src,sink}

The doc system gets confused when we register the exact same
class as multiple elements, so make a subclass for each.

Also wrap registration of deprecated elements with #ifndef GST_REMOVE_DEPRECATED.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1354>

4 years agox265: ignore tune property when diffing generated docs
Tim-Philipp Müller [Fri, 19 Jun 2020 14:31:04 +0000 (15:31 +0100)]
x265: ignore tune property when diffing generated docs

Unfortunately it means those tune enums don't show up in
the docs then, but if that's how it's gotta be..

(Problem at hand is that on Tim's machine x265enc gets an
tune=animation and on the CI machine this doesn't show up.)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1354>