gen.kim [Mon, 11 May 2015 01:33:29 +0000 (18:33 -0700)]
SkPictureShader: floor scaledSize not to exceed maxTextureSize
scaledSize becomes larger than maxTextureSize by zoom level
because it is rounded.
BUG=chromium:485916
Review URL: https://codereview.chromium.org/
1129413002
egdaniel [Sun, 10 May 2015 15:45:18 +0000 (08:45 -0700)]
Only discard for XP dstCopies if we have a coverage value.
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1125283005
skia.buildbots [Sun, 10 May 2015 08:14:35 +0000 (01:14 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
1123233004
egdaniel [Fri, 8 May 2015 21:42:43 +0000 (14:42 -0700)]
Disable advance blend equations.
This is a temporary disabling of advanced blend equations till we can fix
the various bugs associated with it.
BUG=skia:3822
Review URL: https://codereview.chromium.org/
1130003003
egdaniel [Fri, 8 May 2015 19:48:35 +0000 (12:48 -0700)]
Remove coverage multiplies when it is known to be fully opaque.
BUG=skia:
Review URL: https://codereview.chromium.org/
1132883002
fmalita [Fri, 8 May 2015 18:40:41 +0000 (11:40 -0700)]
Remove unused SK_SUPPORT_LEGACY_ROUND_MIPMAP_LEVEL_CHOICE guard
R=reed@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/
1135823003
halcanary [Fri, 8 May 2015 18:39:26 +0000 (11:39 -0700)]
whitespace change (testing flaky bots)
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/
1132043004
halcanary [Fri, 8 May 2015 17:53:29 +0000 (10:53 -0700)]
whitespace change
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/
1131053004
bungeman [Fri, 8 May 2015 15:31:54 +0000 (08:31 -0700)]
Trim whitespace from parsed filename in Android v21.
The entire text content of the 'font' element is currently used as the
file name. This wasn't an issue in earlier versions, as the 'file'
element was dedicated to only containing the file name. The new 'font'
element also contains a number of attributes and potentially other tags.
This means that a 'font' element can become quite long, making it
desireable to be able to split it across multiple lines.
However, splitting the 'font' element across multiple lines is currently
difficult and awkward as any whitespace outside of tags will be
considered part of the file name. This change means that any leading or
trailing whitespace will not be considered part of the file name.
This only applies to v21 and later files, so while this restricts font
file names from beginning and ending with whitespace, it is unlikely to
break any users in practice. It is probably also undesireable to have
font files with names that begin or end with whitespace in any event.
Review URL: https://codereview.chromium.org/
1125413003
bsalomon [Fri, 8 May 2015 14:17:05 +0000 (07:17 -0700)]
remove legacy Gr things
Review URL: https://codereview.chromium.org/
1132813002
robertphillips [Fri, 8 May 2015 14:08:13 +0000 (07:08 -0700)]
Fix convex-lineonly-paths GM so it plays nice with SampleApp
Review URL: https://codereview.chromium.org/
1131273002
robertphillips [Fri, 8 May 2015 11:46:51 +0000 (04:46 -0700)]
Enable GrAAConvexTessellator in GrAAConvexPathRenderer
This CL plumbs the GrAAConvexTessellator into the GrAAConvexPathRenderer but disables in Chrome & Android.
Review URL: https://codereview.chromium.org/
1130883003
reed [Fri, 8 May 2015 00:30:13 +0000 (17:30 -0700)]
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/
1112523006/)
Reason for revert:
speculative revert to fix failures in DEPS roll
Original issue's description:
> Sketch splitting SkPicture into an interface and SkBigPicture.
>
> Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
> These cover about 89% of draw calls from Blink SKPs,
> and about 25% of draw calls from our GMs.
>
> SkPicture handles:
> - serialization and deserialization
> - unique IDs
>
> Everything else is left to the subclasses:
> - playback(), cullRect()
> - hasBitmap(), hasText(), suitableForGPU(), etc.
> - LayerInfo / AccelData if applicable.
>
> The time to record a 1-op picture improves a good chunk
> (2 mallocs to 1), and the time to record a 0-op picture
> greatly improves (2 mallocs to none):
>
> picture_overhead_draw: 450ns -> 350ns
> picture_overhead_nodraw: 300ns -> 90ns
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
c92c129ff85b05a714bd1bf921c02d5e14651f8b
TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1130333002
reed [Thu, 7 May 2015 22:36:17 +0000 (15:36 -0700)]
new image from backend desc
BUG=485243
Review URL: https://codereview.chromium.org/
1121813002
joshualitt [Thu, 7 May 2015 21:21:00 +0000 (14:21 -0700)]
adding rect batch unit test
BUG=skia:
Review URL: https://codereview.chromium.org/
1135513002
mtklein [Thu, 7 May 2015 20:41:07 +0000 (13:41 -0700)]
Sketch splitting SkPicture into an interface and SkBigPicture.
Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
These cover about 89% of draw calls from Blink SKPs,
and about 25% of draw calls from our GMs.
SkPicture handles:
- serialization and deserialization
- unique IDs
Everything else is left to the subclasses:
- playback(), cullRect()
- hasBitmap(), hasText(), suitableForGPU(), etc.
- LayerInfo / AccelData if applicable.
The time to record a 1-op picture improves a good chunk
(2 mallocs to 1), and the time to record a 0-op picture
greatly improves (2 mallocs to none):
picture_overhead_draw: 450ns -> 350ns
picture_overhead_nodraw: 300ns -> 90ns
BUG=skia:
Review URL: https://codereview.chromium.org/
1112523006
joshualitt [Thu, 7 May 2015 20:06:41 +0000 (13:06 -0700)]
tesselating path renderer unit tests
BUG=skia:
Review URL: https://codereview.chromium.org/
1127183006
halcanary [Thu, 7 May 2015 18:46:59 +0000 (11:46 -0700)]
SkPDF: detect YUV-JPEG without relying on ImageGenerator
JPEG/JFIF References:
* http://www.w3.org/Graphics/JPEG/itu-t81.pdf
* http://www.w3.org/Graphics/JPEG/jfif3.pdf
BUG=476721
BUG=446940
Review URL: https://codereview.chromium.org/
1133443003
bsalomon [Thu, 7 May 2015 18:35:55 +0000 (11:35 -0700)]
Iterate over instanced draws in GrGpu rather than above GrBatchTarget
Review URL: https://codereview.chromium.org/
1127273007
joshualitt [Thu, 7 May 2015 18:14:30 +0000 (11:14 -0700)]
Initial CL to create Reorder command builder behind a flag
BUG=skia:
Review URL: https://codereview.chromium.org/
1129943004
mtklein [Thu, 7 May 2015 17:58:44 +0000 (10:58 -0700)]
SK_ARRAY_COUNT shouldn't work on pointers.
Simpler version of https://codereview.chromium.org/
1123923002/
BUG=skia:3593
R=brucedawson@chromium.org,reed@google.com,tfarina@chromium.org
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1114283003
bungeman [Thu, 7 May 2015 17:57:02 +0000 (10:57 -0700)]
Add default resourcePath to SampleApp on Android.
Currently SampleApp on Android cannot find resources. This sets the
resourcePath to /data/local/tmp/skia/resources/ which is the path
used in documentationo. A future change will allow this default to be
overridden.
BUG=skia:3815
Review URL: https://codereview.chromium.org/
1125363004
mtklein [Thu, 7 May 2015 17:53:34 +0000 (10:53 -0700)]
DM: use SkFunction to make required argument type clearer.
Previously it was hard to tell that DrawFn took an SkCanvas* and returned an Error. Now it's clear from the type.
BUG=skia:
Review URL: https://codereview.chromium.org/
1125233002
mtklein [Thu, 7 May 2015 17:51:55 +0000 (10:51 -0700)]
We don't use boxBlurY.
Also noticed nobody sets SK_DISABLE_BLUR_DIVISION_OPTIMIZATION.
BUG=skia:
Review URL: https://codereview.chromium.org/
1134513003
mtklein [Thu, 7 May 2015 17:26:44 +0000 (10:26 -0700)]
Test sp-8888 mode on a few fast bots.
(It's not particularly slow, but this mode doesn't really need global coverage.)
BUG=skia:
Review URL: https://codereview.chromium.org/
1129903003
robertphillips [Thu, 7 May 2015 16:51:43 +0000 (09:51 -0700)]
Isolate GrBufferAllocPools inside GrBatchTarget
This CL refactors the location of the GrBufferAllocPools so they reside entirely inside the GrBatchTarget. This is in preparation for making them use scratch resources.
Review URL: https://codereview.chromium.org/
1131553002
joshualitt [Thu, 7 May 2015 15:23:19 +0000 (08:23 -0700)]
adding uniqueID to GrContext
BUG=skia:
Review URL: https://codereview.chromium.org/
1128873009
joshualitt [Thu, 7 May 2015 15:13:11 +0000 (08:13 -0700)]
Adding unit tests for limited subset of DefaultPathRenderer
BUG=skia:
Review URL: https://codereview.chromium.org/
1129203002
cdalton [Wed, 6 May 2015 20:53:12 +0000 (13:53 -0700)]
Re-enable validation for glBlendBarrierKHR and glBlendEquation
BUG=skia:
Review URL: https://codereview.chromium.org/
1103673002
cdalton [Wed, 6 May 2015 20:40:21 +0000 (13:40 -0700)]
Implement support for KHR_blend_equation_advanced
Uses KHR(or NV)_blend_equation_advanced to implement custom Xfer modes
in hardware.
BUG=skia:
Review URL: https://codereview.chromium.org/
1037123003
mtklein [Wed, 6 May 2015 20:22:02 +0000 (13:22 -0700)]
Really use SSE4 (and SSSE3) in SkBlurImage_SSE4
We don't seem to be making good use of the available instruction set.
SSE4.1 gives us an easy way to unpack a pixel into an __m128i, and
SSSE3 gave us an easy way to do the reverse.
This should be bit-perfect and about a 10% speedup.
BUG=skia:
Review URL: https://codereview.chromium.org/
1123263003
cdalton [Wed, 6 May 2015 20:16:43 +0000 (13:16 -0700)]
Place nvpr above tesselating path renderer in the chain
BUG=skia:
Review URL: https://codereview.chromium.org/
1123343003
reed [Wed, 6 May 2015 20:02:37 +0000 (13:02 -0700)]
use floor for mip-level choice
this chrome change must land first: https://codereview.chromium.org/
1131663002/
BUG=skia:
Review URL: https://codereview.chromium.org/
1131613002
reed [Wed, 6 May 2015 19:56:48 +0000 (12:56 -0700)]
Make drawImage a virtual on SkDevice
This reverts commit
06dad4b92f1fcb593bc686f9537d3e0d866b2241.
BUG=485243
Review URL: https://codereview.chromium.org/
1129843003
mtklein [Wed, 6 May 2015 19:42:04 +0000 (12:42 -0700)]
Add a control benchmark.
I'm thinking of using this in perf with something like:
ratio(fill(filter("test=foo")), fill(filter("test=control")))
Does that make sense to you?
Not sure that this is really a good control bench on all bots,
but I propose we just run it a bit and find out if it needs work.
BUG=skia:
Review URL: https://codereview.chromium.org/
1129823003
cdalton [Wed, 6 May 2015 18:48:56 +0000 (11:48 -0700)]
Add layout qualifiers to GrGLShaderBuilder
BUG=skia:
Review URL: https://codereview.chromium.org/
1114813002
mtklein [Wed, 6 May 2015 18:35:40 +0000 (11:35 -0700)]
Do we still need this DOUBLE_LOOP feature?
If so, let's do it this way so it works for all source types and doesn't need
to be chosen at compile time.
BUG=skia:
Review URL: https://codereview.chromium.org/
1129693003
halcanary [Wed, 6 May 2015 17:56:04 +0000 (10:56 -0700)]
SkPDF: Move utility fns to SkPDFUtils
BUG=skia:3585
Review URL: https://codereview.chromium.org/
1124193003
reed [Wed, 6 May 2015 17:16:02 +0000 (10:16 -0700)]
Revert of Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/
1126273002/)
Reason for revert:
still breaking webglconformance
Original issue's description:
> Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/
1124003002/)
>
> Reason for revert:
> retry now that some fixes (onDrawImage overrides) have landed in chrome/blink
>
> Original issue's description:
> > Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/
1122643005/)
> >
> > Reason for revert:
> > speculative to see if it unblocks DEPS roll
> >
> > Original issue's description:
> > > Make drawImage a virtual on SkDevice
> > >
> > > Now with patch for SkDeferredCanvas
> > >
> > > This reverts commit
119468b71f8f4f45657ab30ead331be665de5a57.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/
14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
> >
> > TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
>
> TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
620ba3afe09d4173c87537040fe50c1c1895fb1a
TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1127993004
borenet [Wed, 6 May 2015 15:33:51 +0000 (08:33 -0700)]
Remove upright-matrix- configs from Android bots
The Android bots are flaking like crazy. I'm not sure if these configs
are hurting the situation, but let's see if this helps.
TBR=mtklein,halcanary
BUG=skia:
Review URL: https://codereview.chromium.org/
1131603002
reed [Wed, 6 May 2015 14:54:38 +0000 (07:54 -0700)]
Revert of Revert of Make drawImage a virtual on SkDevice (patchset #1 id:1 of https://codereview.chromium.org/
1124003002/)
Reason for revert:
retry now that some fixes (onDrawImage overrides) have landed in chrome/blink
Original issue's description:
> Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/
1122643005/)
>
> Reason for revert:
> speculative to see if it unblocks DEPS roll
>
> Original issue's description:
> > Make drawImage a virtual on SkDevice
> >
> > Now with patch for SkDeferredCanvas
> >
> > This reverts commit
119468b71f8f4f45657ab30ead331be665de5a57.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
>
> TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
TBR=robertphillips@google.com,mtklein@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1126273002
mtklein [Wed, 6 May 2015 14:54:07 +0000 (07:54 -0700)]
DM: add Via abstract class
BUG=skia:
Review URL: https://codereview.chromium.org/
1117183007
mtklein [Wed, 6 May 2015 14:40:25 +0000 (07:40 -0700)]
Make SkFunction copyable so it can go in containers.
This totally overhauls the implementation to use ordinary inheritance-based type erasure. I give up for now getting my manual vtable shenanigans to work with MSVC. Still those same "expected ; before ), also expected ) before ;" errors.
I added support for uninitialized SkFunctions and operator=(), because it was fairly straightforward with this implementation.
The main downside here is that I've removed the inline implementation. All SkFunctions involve a heap allocation, even when just wrapping function pointers.
BUG=skia:
Review URL: https://codereview.chromium.org/
1056673002
joshualitt [Wed, 6 May 2015 13:46:01 +0000 (06:46 -0700)]
small fix to correct bounds on distance field text
BUG=skia:
Review URL: https://codereview.chromium.org/
1122253003
robertphillips [Wed, 6 May 2015 12:15:57 +0000 (05:15 -0700)]
Add GrAAConvexTessellator class
This CL adds a GrAAConvexTessellator class. It does not connect it to the GrAAConvexPathRenderer.
Review URL: https://codereview.chromium.org/
1084943003
robertphillips [Wed, 6 May 2015 11:38:36 +0000 (04:38 -0700)]
Reduce the API surface of GrBufferAllocPool and its derivatives
This utility class is going to be revamped and moved. This CL shrinks it a bit so there will be less to shuffle around.
Review URL: https://codereview.chromium.org/
1126753003
reed [Wed, 6 May 2015 00:30:45 +0000 (17:30 -0700)]
Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/
1122643005/)
Reason for revert:
speculative to see if it unblocks DEPS roll
Original issue's description:
> Make drawImage a virtual on SkDevice
>
> Now with patch for SkDeferredCanvas
>
> This reverts commit
119468b71f8f4f45657ab30ead331be665de5a57.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
14fe8fd3e53b5e988aac189a8bc3ed28904d85c8
TBR=robertphillips@google.com,mtklein@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1124003002
joshualitt [Tue, 5 May 2015 21:09:05 +0000 (14:09 -0700)]
small cleanup in GrOvalRenderer
BUG=skia:
Review URL: https://codereview.chromium.org/
1126723004
joshualitt [Tue, 5 May 2015 20:58:20 +0000 (13:58 -0700)]
trivial fix for drawvertices bounds
BUG=skia:
Review URL: https://codereview.chromium.org/
1127633003
bsalomon [Tue, 5 May 2015 20:20:09 +0000 (13:20 -0700)]
Fix vertex/index buffer leaks
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
1123823004
borenet [Tue, 5 May 2015 20:11:27 +0000 (13:11 -0700)]
Add matrix configs to DM
BUG=skia:832
Review URL: https://codereview.chromium.org/
1125793002
mtklein [Tue, 5 May 2015 19:59:56 +0000 (12:59 -0700)]
DM: add a Via to simulate SP pictures.
Will use this to test the other CL that adds small SkPicture implementations.
Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now.
BUG=skia:
Review URL: https://codereview.chromium.org/
1126613005
reed [Tue, 5 May 2015 19:54:33 +0000 (12:54 -0700)]
Make drawImage a virtual on SkDevice
Now with patch for SkDeferredCanvas
This reverts commit
119468b71f8f4f45657ab30ead331be665de5a57.
BUG=skia:
Review URL: https://codereview.chromium.org/
1122643005
reed [Tue, 5 May 2015 19:14:45 +0000 (12:14 -0700)]
add DeferredCanvas mode to SampleApp
BUG=skia:
Review URL: https://codereview.chromium.org/
1129603002
joshualitt [Tue, 5 May 2015 18:55:39 +0000 (11:55 -0700)]
create GrInOrderCommandBuilder
BUG=skia:
Review URL: https://codereview.chromium.org/
1118403003
mtklein [Tue, 5 May 2015 18:38:45 +0000 (11:38 -0700)]
DM: add draw_to_canvas() to trim some boilerplate for Vias.
BUG=skia:
Review URL: https://codereview.chromium.org/
1123743007
reed [Tue, 5 May 2015 18:36:02 +0000 (11:36 -0700)]
remove dead code behind BOOL_ONGETINFO
need this to land in chrome first https://codereview.chromium.org/
1125573002
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1123473004
halcanary [Tue, 5 May 2015 18:28:55 +0000 (11:28 -0700)]
SkPDF: Remove unused deprecated functions in SkPDFTypes
depends on:
http://crrev.com/
1107923002
http://crrev.com/
1103163002
http://crrev.com/
1110533002
http://crrev.com/
1107913002
http://crrev.com/
1106163002
BUG=skia:3585
Review URL: https://codereview.chromium.org/
1113583002
joshualitt [Tue, 5 May 2015 17:45:57 +0000 (10:45 -0700)]
Move RectBatch to GrRect
BUG=skia:
Review URL: https://codereview.chromium.org/
1127713002
mtklein [Tue, 5 May 2015 17:28:44 +0000 (10:28 -0700)]
Add presubmit to run `{dm,nanobench}_flags.py test` when changed.
BUG=skia:
Review URL: https://codereview.chromium.org/
1129443005
halcanary [Tue, 5 May 2015 17:24:09 +0000 (10:24 -0700)]
SkPDF: clean up uses of deprecated calls in SkPDFFont
BUG=skia:3585
Review URL: https://codereview.chromium.org/
1110533002
bsalomon [Tue, 5 May 2015 16:51:38 +0000 (09:51 -0700)]
Move DrawInfo out from GrDrawTarget and rename to GrVertices.
Review URL: https://codereview.chromium.org/
1124733004
joshualitt [Tue, 5 May 2015 15:41:50 +0000 (08:41 -0700)]
Create GrCommandBuilder
BUG=skia:
Review URL: https://codereview.chromium.org/
1113313003
borenet [Tue, 5 May 2015 15:28:23 +0000 (08:28 -0700)]
Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4
BUG=skia:3802
Review URL: https://codereview.chromium.org/
1115303004
reed [Tue, 5 May 2015 15:11:33 +0000 (08:11 -0700)]
add deferred config to DM
BUG=skia:
Review URL: https://codereview.chromium.org/
1113273006
jvanverth [Tue, 5 May 2015 15:01:51 +0000 (08:01 -0700)]
Adjust tolerance to fix GPU hairline curve issues
BUG=chromium:472847
Review URL: https://codereview.chromium.org/
1126793003
halcanary [Tue, 5 May 2015 15:00:24 +0000 (08:00 -0700)]
SkPDF: clean up uses of deprecated calls in SkDocument_PDF
BUG=skia:3585
Review URL: https://codereview.chromium.org/
1107913002
kkinnunen [Tue, 5 May 2015 15:00:10 +0000 (08:00 -0700)]
Avoid using SkPathEffect::DashInfo in GrStrokeInfo
Avoid using SkPathEffect::DashInfo for storing the phase
in GrStrokeInfo. Instead, just use normal instance variables.
Fixes the copy constructor pointing the DashInfo interval pointer
to the wrong interval data.
Also fixes GrStrokeInfo::setDashInfo(const SkPathEffect::DashInfo&)
by updating the fDashType correctly.
Makes it simpler to write code such as the operator== in the future.
Review URL: https://codereview.chromium.org/
1110093002
reed [Tue, 5 May 2015 14:55:19 +0000 (07:55 -0700)]
remove dead code for SK_SUPPORT_LEGACY_RADIAL_GRADIENT_SQRT
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1122933002
stephana [Tue, 5 May 2015 14:55:06 +0000 (07:55 -0700)]
cleanup
BUG=skia:
Review URL: https://codereview.chromium.org/
1085583006
reed [Tue, 5 May 2015 14:49:56 +0000 (07:49 -0700)]
remove dead SK_SUPPORT_LEGACY_CUBIC_CHOPPER code
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1116263005
bsalomon [Tue, 5 May 2015 14:49:49 +0000 (07:49 -0700)]
Start on simplifying generateGeometry() overrides
Committed: https://skia.googlesource.com/skia/+/
f28381c6866cad92af8ebe5b9d2db074613b1963
Review URL: https://codereview.chromium.org/
1122673002
reed [Tue, 5 May 2015 12:42:02 +0000 (05:42 -0700)]
Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188… (patchset #2 id:20001 of https://codereview.chromium.org/
1122813002/)
Reason for revert:
did not update DeferredCanvas
Original issue's description:
> Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/
1118823004/)"
>
> Fixed serialization from prev CL
>
> This reverts commit
973d1f1f60f2710a268a3165aa4f3460502d4be5.
>
> BUG=skia:3803
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
5392785080001fe737fac9e5801fc2127a78d4fb
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803
Review URL: https://codereview.chromium.org/
1123743006
egdaniel [Mon, 4 May 2015 19:58:16 +0000 (12:58 -0700)]
Remove canTweakAlphaForCoverage from XP's since batch reads flag.
BUG=skia:
Review URL: https://codereview.chromium.org/
1127693002
bungeman [Mon, 4 May 2015 19:03:50 +0000 (12:03 -0700)]
Fix typeface ids on Mac.
The current typeface ids with CoreText rely on ATS (which causes
memory use issues) or font data (which is unreliable, and will not
work with axes and synthetics). This changes the code so that stream
fonts never end up in the cache and always get a unique id, and
system fonts will be given an id as they are used.
Review URL: https://codereview.chromium.org/
1125763002
bsalomon [Mon, 4 May 2015 18:41:57 +0000 (11:41 -0700)]
Don't attempt to draw path if dashing or stroking fails
TBR=egdaniel@google.com
Committed: https://skia.googlesource.com/skia/+/
39202f12d37b6ef69ffaddcaa8cc92c621fcda41
Review URL: https://codereview.chromium.org/
1119393002
bsalomon [Mon, 4 May 2015 18:41:41 +0000 (11:41 -0700)]
Revert of Start on simplifying generateGeometry() overrides (patchset #10 id:160001 of https://codereview.chromium.org/
1122673002/)
Reason for revert:
Breaking bots
Original issue's description:
> Start on simplifying generateGeometry() overrides
>
> Committed: https://skia.googlesource.com/skia/+/
f28381c6866cad92af8ebe5b9d2db074613b1963
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1124633003
bsalomon [Mon, 4 May 2015 18:27:45 +0000 (11:27 -0700)]
Start on simplifying generateGeometry() overrides
Review URL: https://codereview.chromium.org/
1122673002
bsalomon [Mon, 4 May 2015 18:21:34 +0000 (11:21 -0700)]
Revert of Don't attempt to draw path if dashing or stroking fails (patchset #1 id:1 of https://codereview.chromium.org/
1119393002/)
Reason for revert:
Doesn't draw
Original issue's description:
> Don't attempt to draw path if dashing or stroking fails
>
>
> TBR=egdaniel@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
39202f12d37b6ef69ffaddcaa8cc92c621fcda41
TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1119423002
mtklein [Mon, 4 May 2015 17:54:48 +0000 (10:54 -0700)]
ignore_result()
BUG=skia:3801
Review URL: https://codereview.chromium.org/
1127603003
reed [Mon, 4 May 2015 17:49:41 +0000 (10:49 -0700)]
Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/
1118823004/)"
Fixed serialization from prev CL
This reverts commit
973d1f1f60f2710a268a3165aa4f3460502d4be5.
BUG=skia:3803
TBR=
Review URL: https://codereview.chromium.org/
1122813002
robertphillips [Mon, 4 May 2015 17:42:05 +0000 (10:42 -0700)]
Get debugger compiling again
Review URL: https://codereview.chromium.org/
1125543003
joshualitt [Mon, 4 May 2015 17:41:57 +0000 (10:41 -0700)]
Move state management to GrInOrderDrawBuffer
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
5d6bb6f795143ca360b868560b52165de51fa269
Review URL: https://codereview.chromium.org/
1120143002
bsalomon [Mon, 4 May 2015 17:36:53 +0000 (10:36 -0700)]
Don't attempt to draw path if dashing or stroking fails
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/
1119393002
bsalomon [Mon, 4 May 2015 17:36:42 +0000 (10:36 -0700)]
Move instanced index buffer creation to flush time
Committed: https://skia.googlesource.com/skia/+/
ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26
Review URL: https://codereview.chromium.org/
1116943004
bsalomon [Mon, 4 May 2015 17:09:23 +0000 (10:09 -0700)]
Revert of Move instanced index buffer creation to flush time (patchset #6 id:100001 of https://codereview.chromium.org/
1116943004/)
Reason for revert:
messed up caching, recreating index buffers all the time.
Original issue's description:
> Move instanced index buffer creation to flush time
>
> Committed: https://skia.googlesource.com/skia/+/
ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26
TBR=joshualitt@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1126613003
reed [Mon, 4 May 2015 16:00:45 +0000 (09:00 -0700)]
Revert of make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/
1118823004/)
Reason for revert:
need to make serialization work for pictures, now that images are "real"
Original issue's description:
> make drawImage a virtual on SkDevice
>
> default impl will turn the Image into a (raster) bitmap and call drawBitmap.
>
> BUG=skia:3803
>
> Committed: https://skia.googlesource.com/skia/+/
f603fb3d0e5fa57c3f228d66945bef198b001135
TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803
Review URL: https://codereview.chromium.org/
1122803002
reed [Mon, 4 May 2015 15:32:51 +0000 (08:32 -0700)]
remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical
This CL derived from https://codereview.chromium.org/
1114243005/
BUG=skia:
Review URL: https://codereview.chromium.org/
1117423003
reed [Mon, 4 May 2015 15:32:02 +0000 (08:32 -0700)]
make drawImage a virtual on SkDevice
default impl will turn the Image into a (raster) bitmap and call drawBitmap.
BUG=skia:3803
Review URL: https://codereview.chromium.org/
1118823004
bsalomon [Mon, 4 May 2015 15:09:30 +0000 (08:09 -0700)]
Move instanced index buffer creation to flush time
Review URL: https://codereview.chromium.org/
1116943004
borenet [Mon, 4 May 2015 15:04:28 +0000 (08:04 -0700)]
Support SKIA_OUT on Mac and ChromeOS
BUG=skia:3774
Review URL: https://codereview.chromium.org/
1122593003
joshualitt [Mon, 4 May 2015 14:51:09 +0000 (07:51 -0700)]
Revert of Move state management to GrInOrderDrawBuffer (patchset #4 id:60001 of https://codereview.chromium.org/
1120143002/)
Reason for revert:
Breaks windows
Original issue's description:
> Move state management to GrInOrderDrawBuffer
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
5d6bb6f795143ca360b868560b52165de51fa269
TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1119353002
joshualitt [Mon, 4 May 2015 14:41:40 +0000 (07:41 -0700)]
Move state management to GrInOrderDrawBuffer
BUG=skia:
Review URL: https://codereview.chromium.org/
1120143002
tfarina [Mon, 4 May 2015 13:40:31 +0000 (06:40 -0700)]
Update src/svg to follow C++11 style rule for {virtual,override}.
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual
and final implies both virtual and override.
The entries were found using the following command line:
$ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M
"[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]"
The regex was a courtesy of nick@chromium.org
BUG=None
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
1123573004
gen.kim [Mon, 4 May 2015 05:36:30 +0000 (22:36 -0700)]
SkPictureShader: scale down if width or height is larger than maxTextureSize
Grdient renders black because of failure onCreateTexture
if one of width or height is larger than maxTextureSize
with --force-gpu-rasterization.
BUG=chromium:473166
Review URL: https://codereview.chromium.org/
1101513004
skia.buildbots [Sun, 3 May 2015 08:03:55 +0000 (01:03 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
1124513002
reed [Sat, 2 May 2015 15:00:03 +0000 (08:00 -0700)]
remove unneeded SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER flag
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1120033003
joshualitt [Sat, 2 May 2015 14:07:17 +0000 (07:07 -0700)]
Add hairlines batch unit test
BUG=skia:
Review URL: https://codereview.chromium.org/
1119563002
joshualitt [Sat, 2 May 2015 13:58:10 +0000 (06:58 -0700)]
Fix for valgrind
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1127453002
joshualitt [Fri, 1 May 2015 20:43:30 +0000 (13:43 -0700)]
Move bounds to GrBatch
BUG=skia:
Review URL: https://codereview.chromium.org/
1121463002