Amitesh Singh [Fri, 28 Aug 2015 05:04:52 +0000 (10:34 +0530)]
gengrid: fix item looping in case of horizontal mode
This mistake is done in
a8afaebf3109f1cb8e397e29
Carsten Haitzler (Rasterman) [Fri, 28 Aug 2015 03:20:36 +0000 (12:20 +0900)]
elm win - fix to ensure smart calc is done before show
@fix
Carsten Haitzler (Rasterman) [Thu, 27 Aug 2015 00:47:53 +0000 (09:47 +0900)]
elm test EXPLODE! feature! explore widgets and their content!
hit ctrl+middle mouse on something...
Dave Andreoli [Thu, 27 Aug 2015 19:37:50 +0000 (21:37 +0200)]
Genlist: reset item tree expanded state when putting item in cache
Item expandend state need to be resetted (contracted) when the
item goes in the items cache, otherwise when the item will be reused
it will have unwanted state (expanded).
Quite visible in the "Genlist Tree and Decorate All Mode" test
@fix
Amitesh Singh [Thu, 27 Aug 2015 04:30:39 +0000 (10:00 +0530)]
config: revert first_item_focus_on_first_focus_in to 0
This fixes a behavioural change introduced in D1135.
Steps to reproduce:
1. elementary_test -> genlist/list/gengrid
2. scroll dragging the scroll-bar
3. an item nearest to viewport gets selected when you release the mouse button
Most of the time, we don't want item to be selected or focused on dragging
scroll-bar via mouse. Revert config flag to 0 to have old behaviour before D1135.
fixes: T2662
@fix
Amitesh Singh [Wed, 26 Aug 2015 17:00:02 +0000 (22:30 +0530)]
toolbar: fix issue of focus not coming to item on mouse click
resize object was not getting focused in case of mouse click.
Steps to reproduce:
1. elementary_test -to "toolbar focus".
2. set focus to toolbar item via mouse.
3. focus does not come to toolbar.
fixes T2697
@fix
Amitesh Singh [Wed, 26 Aug 2015 15:13:39 +0000 (20:43 +0530)]
gengrid: no need to loop in case of reorder mode is enabled
There is no need to loop when reorder mode is enabled. This looks
ugly and nobody wants it. This fault was introduced in
7aaa5c8d0a4a5714b4f1bf79e
This patch also fixes following crash
1. elementary_test -to "Gengrid 2".
2. Enable all the options available.
3. Do reorder of item via keys.
4. Observe segv on reordering edge items.
@fix
Vincent Torri [Wed, 26 Aug 2015 14:19:46 +0000 (16:19 +0200)]
Add missing documentation of DirectDraw rendering
Amitesh Singh [Wed, 26 Aug 2015 10:05:47 +0000 (15:35 +0530)]
gengrid: fix item focus movement in case of horizontal mode
Steps to reproduce:
1. elementary -> gengrid focus
2. change mode to horizontal
3. set focus to one of item in 2nd column.
4. Press Left direction key
issue: focus moves out of gengrid.
@fix
Tom Hacohen [Wed, 26 Aug 2015 09:48:16 +0000 (10:48 +0100)]
Elm win: Fix according to the new behaviour of parent_set.
This new behaviour was introduced in
9c78ee0bf4125c095e85f7fcf9921586cda64a52.
Amitesh Singh [Wed, 26 Aug 2015 09:04:58 +0000 (14:34 +0530)]
gengrid: add curly braces to avoid ambiguous 'if'
Seunghun Lee [Tue, 25 Aug 2015 11:41:18 +0000 (20:41 +0900)]
elm_win: Initilize the variable 'preferred_rot' as a -1 before invoking _elm_win_xwin_update() in _elm_win_finalize_internal().
Summary:
since the variable 'preferred_rot' is checked its validation in _elm_win_xwin_update(),
so, should be initialize it before invoking.
@fix
Reviewers: jypark, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2987
Hosang Kim [Tue, 25 Aug 2015 11:05:57 +0000 (20:05 +0900)]
progressbar: fix memory leak
Summary: when elm_progressbar_value_set is called, progress_status is always created.
Test Plan: elementary_test -> progressbar
Reviewers: woohyun, Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D2986
Luciana Magno de Almeida [Tue, 16 Dec 2014 21:04:43 +0000 (19:04 -0200)]
cxx: Added examples and tutorial for C++ binding
Summary:
Added the following examples:
* bg_cxx_example_01
* bg_cxx_example_02
* bubble_cxx_example_01
* button_cxx_example_00
* button_cxx_example_01
* calendar_cxx_example_01
* calendar_cxx_example_02
* calendar_cxx_example_03
* calendar_cxx_example_04
* calendar_cxx_example_05
* clock_cxx_example
* datetime_cxx_example
* glview_cxx_example_01
* hoversel_cxx_example_01
* icon_cxx_example_01
* location_cxx_example_01
* menu_cxx_example_01
* popup_cxx_example_01
* radio_cxx_example_01
* separator_cxx_example_01
* slider_cxx_example
* spinner_cxx_example
* table_cxx_example_01
* table_cxx_example_02
* thumb_cxx_example_01
Added documentation for the above examples, as well as how using lambdas
with C++ elm binding. How to use autohide feature and how to use the C++
wrappers to create windows, widgets and call Eo functions from them with
automatic C++ type conversion and how to use signals from C++.
Felipe Magno de Almeida [Tue, 25 Aug 2015 05:37:42 +0000 (02:37 -0300)]
Added elm_general.eot file to EXTRA_DIST
Fixes distcheck
ChunEon Park [Tue, 25 Aug 2015 05:07:30 +0000 (14:07 +0900)]
ChunEon Park [Tue, 25 Aug 2015 04:10:33 +0000 (13:10 +0900)]
theme: fix theme file path parsing issue on windows.
':' is usually regarded as the delimetr for new theme path
but it uses to look up the drive, ie, c: on windows, on the other hand.
this patch fixes to determine wheter ':' is used for drive name or delimeter.
@fix
Amitesh Singh [Tue, 25 Aug 2015 04:05:05 +0000 (09:35 +0530)]
scroller: fix memory leak on keys traversal
@fix
Jaehwan Kim [Mon, 24 Aug 2015 04:38:08 +0000 (13:38 +0900)]
scroller: fix the misstake. change && -> ||
@fix
Amitesh Singh [Fri, 21 Aug 2015 04:02:45 +0000 (09:32 +0530)]
test_genlist: fix a typo
Seunghun Lee [Thu, 20 Aug 2015 05:11:55 +0000 (14:11 +0900)]
elm_win: set wm rotation hints _elm_win_xwin_update().
Summary:
if app sets available rotations before invoking elm_win_alpha_set(),
wm rotation doesn't work.
this patch fixes it.
Test Plan: N/A
Reviewers: jypark
Reviewed By: jypark
Differential Revision: https://phab.enlightenment.org/D2946
Vaibhav Gupta [Wed, 19 Aug 2015 06:35:49 +0000 (12:05 +0530)]
test_scroller: Fix item count variable
Summary:
Since the _count variable is static, the buttons which are added
to scroller, get text value ahead of previously added count, instead
of starting from 1 every time a new window is opened for the example.
Signed-off-by: Vaibhav Gupta <g.vaibhav1@samsung.com>
Test Plan:
Following is the test:
1. Open Scroller 3 sample
2. Add some items and note the "Item count value of added buttons
3. Close the sample
4. Re-open Scroller 3 sample, and again add some items
5. Observe the "Item count" text of added buttons.
Reviewers: raster, Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2959
Amitesh Singh [Wed, 19 Aug 2015 04:41:53 +0000 (10:11 +0530)]
genlist: remove unnecessary bracket
Carsten Haitzler (Rasterman) [Tue, 18 Aug 2015 05:34:30 +0000 (14:34 +0900)]
elm popup - simplify if logic to be more compact and readable
Daniel Juyung Seo [Mon, 17 Aug 2015 16:22:14 +0000 (01:22 +0900)]
popup: Exceptionally set since as 1.15.1
This is exceptionall case.
This was not pushed to 1.15 but has to be pushed to 1.15.1 due to a
significant popup bug.
Daniel Juyung Seo [Mon, 17 Aug 2015 16:21:36 +0000 (01:21 +0900)]
test_table: Add variable padding config in the padding test.
Daniel Juyung Seo [Mon, 17 Aug 2015 15:32:09 +0000 (00:32 +0900)]
popup: Fix wrong since version in the doc.
Daniel Juyung Seo [Mon, 17 Aug 2015 15:20:02 +0000 (00:20 +0900)]
spinner: Remove unnecessary temporary variable.
Follow elm_layout_theme_set usage convention.
Stefan Schmidt [Mon, 17 Aug 2015 11:32:14 +0000 (13:32 +0200)]
multibuttonentry: check return value from elm_layout_theme_set
CID: 1294253
Daniel Hirt [Mon, 17 Aug 2015 05:34:21 +0000 (08:34 +0300)]
Entry: fix cursor repositioning on theme_apply
Summary:
The original code did not consider the case where the text will be
reapplied by chunks. The repositioning of the cursor should be postponed
to when the idler work is done, or not required at all.
Fixes T2646.
@fix
Reviewers: NikaWhite
Reviewed By: NikaWhite
Maniphest Tasks: T2646
Differential Revision: https://phab.enlightenment.org/D2952
Carsten Haitzler (Rasterman) [Mon, 17 Aug 2015 01:48:47 +0000 (10:48 +0900)]
elm theme - add a blank focus style if you want invisible focus
in some cases you may want a widget to focus but not to get a blue
hilightaround it - thus provide a blank focus style just for this.
@feature
Amitesh Singh [Sat, 15 Aug 2015 18:53:44 +0000 (00:23 +0530)]
popup: fix content_area resize in case of custom theme
Send elm,scroll,enable/disable signals in theme_apply.
It is a fix of
0891ac5cfc2710d0c89034
Thanks to Dave for reporting this issue.
Amitesh Singh [Sat, 15 Aug 2015 17:16:51 +0000 (22:46 +0530)]
list: fix crash while setting nearest item in viewport
This is an example of classic code copy and paste mistake.
Probably inspired from similar code in genlist/gengrid.
We were actually deleting the other items (except selected one) in
viewport in _elm_list_nearest_visible_item_get() which results into crash
while deleting the list object.
@fix
Resolves: T2662
Amitesh Singh [Sat, 15 Aug 2015 15:32:33 +0000 (21:02 +0530)]
popup: make scroller optional in popup
Summary:
@feature
Resolves: T2651
Test Plan:
1. elementary_test -to "popup"
2. Enable/disable checkbox named "Enable popup scoller"
Reviewers: raster, herb, herdsman, SanghyeonLee, tasn, simotek, cedric, jeffhoogland
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2945
Cedric BAIL [Sat, 15 Aug 2015 10:43:05 +0000 (12:43 +0200)]
view_list: small optimization reducing memory consumption using Eo_Event array of callbacks.
Now that smart callback have been converted to Eo_Event to, there is a lot of place in
our code base where we can do this easy memory optimization.
Jaehwan Kim [Fri, 14 Aug 2015 14:59:06 +0000 (23:59 +0900)]
focus: add the comment about focus origin property.
Anand [Fri, 14 Aug 2015 06:21:02 +0000 (09:21 +0300)]
elm_gengrid:Added Eolian changes in gengrid reorder Api
Summary:
Modified gengrid reorder Api's(elm_gengrid_reorder_mode_start, elm_gengrid_reorder_mode_stop,
elm_gengrid_reorder_type_set) in Eolian format.
Test Plan: elementry_test->gengrid->gengrid_focus
Reviewers: seoz, raster, Hermet, JackDanielZ
Subscribers: cedric, JackDanielZ, mvsovani, singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2510
Yeshwanth Reddivari [Fri, 14 Aug 2015 05:50:30 +0000 (11:20 +0530)]
Gengrid: Set focus after item looping
Summary:
After item looping, Gengrid item was getting selected.
So, checked for item_select_on_focus_disable flag and
accordingly set focus state or selected state of Gengrid item.
@fix
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
Reviewers: raster, Hermet, singh.amitesh, SanghyeonLee
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D2937
Mike Blumenkrantz [Thu, 13 Aug 2015 19:45:19 +0000 (15:45 -0400)]
cnp: redo wayland drop to nul terminate for text_uri drops and free on every drop
@fix
Jérémy Zurcher [Thu, 13 Aug 2015 19:41:27 +0000 (21:41 +0200)]
win: declare elm_win_wm_rotation_available_rotations_set
this should not have been removed in a0fdbad
Mike Blumenkrantz [Thu, 13 Aug 2015 19:27:14 +0000 (15:27 -0400)]
cnp: only nul terminate wayland drops for text type drops
also move data allocation into block where dropping is guaranteed
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 19:18:55 +0000 (15:18 -0400)]
cnp: end wayland drag on allocation failure
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 19:10:52 +0000 (15:10 -0400)]
cnp: pass wayland drop event size to handler, do not nul terminate drop data
performing strlen() on potential non-string data is not recommended and can
even lead to crashes. nul terminating non-string data is pointless and enables
bad application behavior such as calling strlen() on potentially non-string data
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:51:17 +0000 (14:51 -0400)]
cnp: fix wayland drop format selection
previously the drop format was chosen in a manner unrelated to what
the offered format was, leading to applications receiving either the correct
data with the wrong format, the wrong data with the wrong format, or
the wrong data with the correct format. by comparing the drop handler
types with the offered type and ensuring that there is a match, the
correctness of the format that the application receives is more reliable
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:49:28 +0000 (14:49 -0400)]
cnp: initialize Elm_Selection_Data.action for wayland drops
wayland drops are probably always copy, though there's no real functional
equivalent for the x11 meaning of this
@fix
Mike Blumenkrantz [Thu, 13 Aug 2015 18:48:35 +0000 (14:48 -0400)]
cnp: init wayland dnd handlers upon creating the first drop target
previously this would only init when the app was initiating the drag,
which would result in an app being unable to receive drags
@fix
Daniel Kolesa [Thu, 13 Aug 2015 15:46:57 +0000 (16:46 +0100)]
win: convert docs
With this, documentation conversion in elm is complete.
Daniel Kolesa [Thu, 13 Aug 2015 15:05:38 +0000 (16:05 +0100)]
gengrid: convert docs
Daniel Kolesa [Thu, 13 Aug 2015 13:21:49 +0000 (14:21 +0100)]
layout: convert docs
Carsten Haitzler (Rasterman) [Thu, 13 Aug 2015 10:26:52 +0000 (19:26 +0900)]
elm theme - conformant - fix to have proper min size of conformant
conformant would ignore min size of content (and propagate min size
to paent widget - eg window). this was just wrong. remove fixed here
(also align is useless as that is a default).
@fix
Jaehwan Kim [Thu, 13 Aug 2015 04:45:21 +0000 (13:45 +0900)]
focus: item focus moves by geometry.
In the widget code, focus origin is added. It can know
the focus movement is originated by which action.
The widgets can choose the item focus moves to last focused item
or geometrically nearby item by focus origin.
In gengrid, focus moves to last focused item if focus origin is
ELM_FOCUS_REVERT. It moves to nearby item if focus origin is from
ELM_FOCUS_UP to ELM_FOCUS_LEFT.
TODO: widgets have items should add the direction feature if it
want the focus to move to nearby item.
@feature
Jaehwan Kim [Thu, 13 Aug 2015 04:32:43 +0000 (13:32 +0900)]
test_gengrid: change the min size of gengrid
Amitesh Singh [Wed, 12 Aug 2015 18:13:29 +0000 (23:43 +0530)]
entry: fix since tag for entry_input_panel_show_on_demand_set()
Daniel Kolesa [Wed, 12 Aug 2015 16:12:16 +0000 (17:12 +0100)]
map: convert docs
Chris Michael [Wed, 12 Aug 2015 14:18:41 +0000 (10:18 -0400)]
elementary: Fix Copy and Paste test to actually paste clipboard text
Summary: The Elm Copy and Paste test was not actually pasting the
copied text into the entry when the Paste button was clicked. This
patch fixes that issue.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Wed, 12 Aug 2015 12:45:30 +0000 (13:45 +0100)]
datetime: convert docs
Daniel Kolesa [Wed, 12 Aug 2015 11:45:31 +0000 (12:45 +0100)]
web: convert docs
Daniel Kolesa [Wed, 12 Aug 2015 11:22:14 +0000 (12:22 +0100)]
genlist_item: convert docs
Jaehwan Kim [Wed, 12 Aug 2015 08:25:15 +0000 (17:25 +0900)]
focus: add the focus region show mode
When the focus is move to the object in scroller, it is scrolled
to show the focus region as a widget.
If the focus region want to be shown as an item,
set the mode ELM_FOCUS_REGION_SHOW_ITEM.
If then, it will be scrolled as an item.
TODO: Widgets have items are added on_focus_region function.
@feature
Dave Andreoli [Wed, 12 Aug 2015 07:15:09 +0000 (09:15 +0200)]
Fix docs for elm_object_tooltip_orient_set
The function is not visible in docs,
this should make it visible
Jaehwan Kim [Wed, 12 Aug 2015 02:09:14 +0000 (11:09 +0900)]
gengird: change focus move mechanism in gengrid.
This commit is related to
4d553d2bcf2157053433994ca3facb56bd670da9.
It doesn't work if item_select_on_focus_disable is 1.
So _item_focus_down is changed like _item_single_select_down.
@fix
Daniel Kolesa [Tue, 11 Aug 2015 15:57:08 +0000 (16:57 +0100)]
slider: convert docs
Daniel Kolesa [Tue, 11 Aug 2015 14:27:06 +0000 (15:27 +0100)]
toolbar_item: convert docs
Tom Hacohen [Tue, 11 Aug 2015 13:46:41 +0000 (14:46 +0100)]
Toolbar: migrate docs.
Jyotiprakash Sahoo [Tue, 11 Aug 2015 13:08:21 +0000 (22:08 +0900)]
gengrid: extends D2418 to horizontal mode.
Summary:
do not return yet in case of edge items if looping
is disabled. try to select/focus last item.
Signed-off-by: Jyotiprakash Sahoo <jp.sahoo@samsung.com>
@fix
Test Plan: elementary_test -> Gengrid 2
Reviewers: raster, singh.amitesh, cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2865
Jaehwan Kim [Tue, 11 Aug 2015 09:56:52 +0000 (18:56 +0900)]
scroller: fix the focus move bug in scroller.
When the focused object is out of the viewport and the key direction
is only the direction focus is out, it should find the next focus.
@fix
Tom Hacohen [Tue, 11 Aug 2015 11:48:37 +0000 (12:48 +0100)]
Interface scrollable: migrate docs.
Tom Hacohen [Tue, 11 Aug 2015 08:02:09 +0000 (09:02 +0100)]
List: migrate docs.
Tom Hacohen [Tue, 11 Aug 2015 07:35:32 +0000 (08:35 +0100)]
Multibutton entry: migrate docs.
Mike Blumenkrantz [Mon, 10 Aug 2015 20:19:56 +0000 (16:19 -0400)]
cnp test: add callback to print info when paste button is clicked
Mike Blumenkrantz [Mon, 10 Aug 2015 20:07:41 +0000 (16:07 -0400)]
cnp: add docs for Elm_Selection_Data members
Tom Hacohen [Mon, 10 Aug 2015 17:37:13 +0000 (18:37 +0100)]
Image: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 14:00:27 +0000 (15:00 +0100)]
Prefs: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 13:17:49 +0000 (14:17 +0100)]
Spinner: migrate docs.
Tom Hacohen [Mon, 10 Aug 2015 11:51:51 +0000 (12:51 +0100)]
Genlist: migrate one missing doc string.
Tom Hacohen [Mon, 10 Aug 2015 11:51:00 +0000 (12:51 +0100)]
Gengrid item: migrate docs.
Stefan Schmidt [Mon, 10 Aug 2015 10:55:09 +0000 (12:55 +0200)]
build: Exclude some more files from coverage as they are not in the correct path
These files come from some modules in src/modules while we set out base dir to
src/lib. In result these files are search for in src/lib and not found. In the
long term we want to find out how to collect them as well but for now a working
coverage is already good.
Overall coverage rate:
lines......: 18.1% (12596 of 69412 lines)
functions..: 18.6% (1766 of 9500 functions)
Will work on getting these run by jenkins once it is back.
Dave Andreoli [Sun, 9 Aug 2015 16:59:14 +0000 (18:59 +0200)]
Add a new (failing) test for table padding
This test expose a bug in table as explained in T2655
Dave Andreoli [Sat, 8 Aug 2015 15:08:45 +0000 (17:08 +0200)]
Add a no-wrap mode to the "Entry Style Default" test
I'm trying to reproduce an issue, not spotted by this,
but can still be usefull.
Daniel Kolesa [Fri, 7 Aug 2015 14:54:50 +0000 (15:54 +0100)]
glview: convert docs
Tom Hacohen [Fri, 7 Aug 2015 14:48:51 +0000 (15:48 +0100)]
Progressbar: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 14:47:32 +0000 (15:47 +0100)]
genlist: convert docs
Tom Hacohen [Fri, 7 Aug 2015 14:36:47 +0000 (15:36 +0100)]
Segment control: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 14:19:21 +0000 (15:19 +0100)]
Index: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 14:04:10 +0000 (15:04 +0100)]
Widget item: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:37:49 +0000 (14:37 +0100)]
Inwin: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:44:49 +0000 (14:44 +0100)]
gesture_layer: convert and fix docs
Tom Hacohen [Fri, 7 Aug 2015 13:30:44 +0000 (14:30 +0100)]
Interface atspi image: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:29:11 +0000 (14:29 +0100)]
Interface atspi value: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:28:40 +0000 (14:28 +0100)]
Interface atspi selection: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:28:13 +0000 (14:28 +0100)]
Interface atspi component: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:26:50 +0000 (14:26 +0100)]
Interface atspi action: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:25:45 +0000 (14:25 +0100)]
Interface atspi text: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:24:37 +0000 (14:24 +0100)]
popup: convert docs
Tom Hacohen [Fri, 7 Aug 2015 13:16:55 +0000 (14:16 +0100)]
Widget: migrate docs.
Tom Hacohen [Fri, 7 Aug 2015 13:10:49 +0000 (14:10 +0100)]
Label: migrate docs.
Daniel Kolesa [Fri, 7 Aug 2015 13:08:01 +0000 (14:08 +0100)]
table: convert docs
Daniel Kolesa [Fri, 7 Aug 2015 12:50:21 +0000 (13:50 +0100)]
slideshow: convert docs
Daniel Kolesa [Fri, 7 Aug 2015 12:30:06 +0000 (13:30 +0100)]
flip: convert docs
Tom Hacohen [Fri, 7 Aug 2015 12:30:05 +0000 (13:30 +0100)]
Naviframe: migrate docs.