msarett [Mon, 23 May 2016 17:21:17 +0000 (10:21 -0700)]
Test color correction in DM
This will allow me to test and visualize some assumptions
on parsing and applying color profiles. Also, it should
help me find and fix bugs.
This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance. We'll probably want to do both of these
once we know where it fits in the pipeline.
Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps. I'll continue to add more
"interesting" images and probably tweak the code as
necessary.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1995233003
Review-Url: https://codereview.chromium.org/
1995233003
msarett [Mon, 23 May 2016 17:19:26 +0000 (10:19 -0700)]
Update image testing to version 6
This replaces the old HTC.dng test image (~40 MB) with a much smaller
HTC.dng (~125 kb).
This should limit OOM errors on our bots and improve the speed of the
tests suite.
BUG=skia:5283
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2004113002
Review-Url: https://codereview.chromium.org/
2004113002
brianosman [Mon, 23 May 2016 17:15:27 +0000 (10:15 -0700)]
Enable tri-linear and NPOT-tiling support in Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2004123002
Review-Url: https://codereview.chromium.org/
2004123002
brianosman [Mon, 23 May 2016 17:11:07 +0000 (10:11 -0700)]
Add vksrgb config to dm (Vulkan sRGB). Fix help formatting of vk.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2005863002
Review-Url: https://codereview.chromium.org/
2005863002
msarett [Mon, 23 May 2016 16:29:29 +0000 (09:29 -0700)]
Make SkColorSpace a public API
I've trimmed uniqueID for now, and added some comments.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1996973002
Review-Url: https://codereview.chromium.org/
1996973002
halcanary [Mon, 23 May 2016 16:11:58 +0000 (09:11 -0700)]
SkTypes: use constexpr when appropriate
motivation: https://codereview.chromium.org/
2000853003
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2004073002
Review-Url: https://codereview.chromium.org/
2004073002
halcanary [Mon, 23 May 2016 16:02:38 +0000 (09:02 -0700)]
fiddle: srand(0) before draw(canvas)
TBR=
Review-Url: https://codereview.chromium.org/
2003043002
brianosman [Mon, 23 May 2016 13:23:27 +0000 (06:23 -0700)]
Pretend that Adreno4xx doesn't have sRGB write control.
BUG=skia:5329
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1998953003
Review-Url: https://codereview.chromium.org/
1998953003
update-skps [Sun, 22 May 2016 07:35:10 +0000 (00:35 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2004773002
Review-Url: https://codereview.chromium.org/
2004773002
scroggo [Fri, 20 May 2016 21:27:16 +0000 (14:27 -0700)]
Remove unnecessary check
Follow-on from crrev.com/
1996993003
No need to check the alpha type. If the color type is gray, the
source alpha type will be opaque.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2002723002
Review-Url: https://codereview.chromium.org/
2002723002
scroggo [Fri, 20 May 2016 20:56:13 +0000 (13:56 -0700)]
Finish supporting decoding opaque to non-opaque
When decoding to 565 or Gray, allow the client to incorrectly ask for premul.
When checking whether it's possible to decode to 565, return whether the
source is opaque.
In DM, allow decoding to 565 or Gray, even if the client also asked for premul.
This fixes a bug introduced in crrev.com/
1999593003 when we stopped ever
requesting Opaque, resulting in us not testing 565 or Gray.
BUG=skia:4616
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
1996993003
Review-Url: https://codereview.chromium.org/
1996993003
liyuqian [Fri, 20 May 2016 19:41:49 +0000 (12:41 -0700)]
Save comparisons for release.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
1997003003
Review-Url: https://codereview.chromium.org/
1997003003
liyuqian [Fri, 20 May 2016 18:41:01 +0000 (11:41 -0700)]
Use SkASSERTResult to avoid unused local variables
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2003653002
Review-Url: https://codereview.chromium.org/
2003653002
stephana [Fri, 20 May 2016 18:20:38 +0000 (11:20 -0700)]
Remove custom bundle ID for iOS
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
1998273002
Review-Url: https://codereview.chromium.org/
1998273002
robertphillips [Fri, 20 May 2016 18:14:33 +0000 (11:14 -0700)]
Retract GrRenderTarget from GrTestTarget
Split out of: https://codereview.chromium.org/
1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
2004433002
Review-Url: https://codereview.chromium.org/
2004433002
scroggo [Fri, 20 May 2016 18:08:27 +0000 (11:08 -0700)]
Only decode opaque to premul in DM image
Previously, we would test decoding an opaque SkCodec to all three:
kUnpremul,
kPremul,
kOpaque
The image should look the same in all three cases. We already test for
that in CodecTest [1], where we require that the result matches exactly.
CodecTest runs on a smaller set of images, but it covers a variety of
opaque images. No need to test on all opaque images.
Running locally on my Mac laptop, the following command:
dm --src image --images resources/
dropped from:
5932 srcs
11.2s
to:
3544 srcs
6.69s
for a 40% speedup.
BUG=skia:5307
[1] https://skia.googlesource.com/skia/+/master/tests/CodecTest.cpp#119
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1999593003
Review-Url: https://codereview.chromium.org/
1999593003
halcanary [Fri, 20 May 2016 17:36:50 +0000 (10:36 -0700)]
gyp (third_party) warning changes for ccache
Also fix a broken unit test in MatrixTest.cpp.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2002663002
Review-Url: https://codereview.chromium.org/
2002663002
bsalomon [Fri, 20 May 2016 16:11:17 +0000 (09:11 -0700)]
When building circle blur profile evaluate kernel vertically once per column
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1991413002
Review-Url: https://codereview.chromium.org/
1991413002
bsalomon [Fri, 20 May 2016 15:54:23 +0000 (08:54 -0700)]
Make LinearSrcOverBench not crash in constructor when resource path is missing
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
1998113003
Review-Url: https://codereview.chromium.org/
1998113003
scroggo [Fri, 20 May 2016 15:38:54 +0000 (08:38 -0700)]
Stop creating CodecSrcs with unused scale
Only JPEG and WEBP support native scaling, so only create a CodecSrc
with a scale for those types.
If I run
dm --src image --images resources
this cuts down the number of Srcs from 11063 to 8032. All of these
trimmed Srcs would have failed quickly for each Sink (3 Sinks with the
above flags), but this will avoid creating them.
It drops the runtime on my mac from 13.2s to 11.4s, for about a 14%
speedup.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1999103002
Review-Url: https://codereview.chromium.org/
1999103002
senorblanco [Fri, 20 May 2016 14:59:09 +0000 (07:59 -0700)]
Adjust size of imagemakewithfilter GM.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
2003453003
Review-Url: https://codereview.chromium.org/
2003453003
liyuqian [Fri, 20 May 2016 14:32:19 +0000 (07:32 -0700)]
Correct gesture scale and translation
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1996613002
Review-Url: https://codereview.chromium.org/
1996613002
senorblanco [Fri, 20 May 2016 14:27:38 +0000 (07:27 -0700)]
Fix leak in SkImage_Gpu::onMakeSubset().
BUG=skia:5327
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2003573002
Review-Url: https://codereview.chromium.org/
2003573002
djsollen [Fri, 20 May 2016 14:03:17 +0000 (07:03 -0700)]
Fix android scripts now that the $HOST is always lowercase.
BUG=skia:5309
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1992873003
Review-Url: https://codereview.chromium.org/
1992873003
robertphillips [Fri, 20 May 2016 13:38:43 +0000 (06:38 -0700)]
GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not GrContext)
This is split out of: https://codereview.chromium.org/
1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder)
BUG=skia:
Review-Url: https://codereview.chromium.org/
1993403002
scroggo [Fri, 20 May 2016 13:02:42 +0000 (06:02 -0700)]
Reduce the number of BRDSrcs run in DM
Testing to e.g. Index8 is useful, but not usefully different across
all sampleSizes and Modes. (Same for Gray.) Drop several Srcs.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990173003
Review-Url: https://codereview.chromium.org/
1990173003
jvanverth [Fri, 20 May 2016 13:01:06 +0000 (06:01 -0700)]
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978573003
Committed: https://skia.googlesource.com/skia/+/
56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
Review-Url: https://codereview.chromium.org/
1978573003
rmistry [Fri, 20 May 2016 10:50:01 +0000 (03:50 -0700)]
Fix Gold trybot results URL
BUG=skia:5324
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
1996103002
Review-Url: https://codereview.chromium.org/
1996103002
bsalomon [Thu, 19 May 2016 23:23:47 +0000 (16:23 -0700)]
Make GrAtlasTextBlob::run own effects it points to.
BUG=chromium:608566
Currently the run has bare pointers and the effects can be destroyed while a run is pointing at them.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993213003
Review-Url: https://codereview.chromium.org/
1993213003
bsalomon [Thu, 19 May 2016 22:52:34 +0000 (15:52 -0700)]
Make circle blur profile computation separable
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1996653002
Review-Url: https://codereview.chromium.org/
1996653002
senorblanco [Thu, 19 May 2016 21:50:29 +0000 (14:50 -0700)]
Image filters: implement SkImage::makeWithFilter().
This API provides a way to directly filter a subregion of an SkImage
(usually texture-backed), and returns an SkImage which may include
extra padding, along with a size to indicate the active region.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1964043002
Review-Url: https://codereview.chromium.org/
1964043002
herb [Thu, 19 May 2016 21:19:23 +0000 (14:19 -0700)]
Make an embeddable container to hold linear pipelines.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1998793002
Review-Url: https://codereview.chromium.org/
1998793002
robertphillips [Thu, 19 May 2016 21:01:05 +0000 (14:01 -0700)]
Retract GrRenderTarget from GLProgramsTest
Split out of https://codereview.chromium.org/
1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1997773002
Review-Url: https://codereview.chromium.org/
1997773002
bsalomon [Thu, 19 May 2016 19:51:46 +0000 (12:51 -0700)]
Attempt to improve lifetime management of SkGlyphCache in Ganesh atlas text code.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1983353003
Review-Url: https://codereview.chromium.org/
1983353003
robertphillips [Thu, 19 May 2016 18:36:25 +0000 (11:36 -0700)]
Make GrAppliedClip friendless
GrAppliedClip is a pretty amiable class but not so good about setting boundaries. It is probably for the best that it breaks things off with GrClipMaskManager before the drama of https://codereview.chromium.org/
1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) begins.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993263002
Review-Url: https://codereview.chromium.org/
1993263002
bungeman [Thu, 19 May 2016 18:23:55 +0000 (11:23 -0700)]
Remove mutex for retrieving default typeface.
This mutex was added due to FontConfigTypeface::LegacyCreateTypeface
being non-thread safe. This method no longer exists and the logic was
moved to SkFontMgr_FCI::onLegacyCreateTypeface which has access to an
appropriate mutex ("Clean up SkFontConfigInterface implementation.",
0265707c191a31dfde08dd1cd7011c1fe5b8e643).
Review-Url: https://codereview.chromium.org/
1994703003
brianosman [Thu, 19 May 2016 15:43:55 +0000 (08:43 -0700)]
Propagate filter mode when rendering Alpha8 bitmaps
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1988023009
Review-Url: https://codereview.chromium.org/
1988023009
msarett [Thu, 19 May 2016 14:50:24 +0000 (07:50 -0700)]
Delete workaround for matching bitmap and pixel ref rowbytes
We now handle this in:
https://googleplex-android-review.git.corp.google.com/#/c/1051261/
BUG=skia:4538
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1992143003
Review-Url: https://codereview.chromium.org/
1992143003
bungeman [Thu, 19 May 2016 14:43:52 +0000 (07:43 -0700)]
Assert complex precondition in SkGlyphCache::Visit.
SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but this is a subtle
requirement which if violated could lead to subtle bugs.
Review-Url: https://codereview.chromium.org/
1992053002
hcm [Thu, 19 May 2016 12:26:57 +0000 (05:26 -0700)]
Update Skia milestone to 53 after 52 branch
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993203002
Review-Url: https://codereview.chromium.org/
1993203002
bsalomon [Wed, 18 May 2016 20:52:05 +0000 (13:52 -0700)]
Revert of Don't allow uncacheable paths in tessellated path renderer (patchset #2 id:20001 of https://codereview.chromium.org/
1990793003/ )
Reason for revert:
Caused innershapes test to be rendered incorrectly on the N10. This might be a driver bug.
Original issue's description:
> Don't allow uncacheable paths in tessellated path renderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990793003
>
> Committed: https://skia.googlesource.com/skia/+/
aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d
TBR=senorblanco@google.com,senorblanco@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1993923002
benjaminwagner [Wed, 18 May 2016 20:28:56 +0000 (13:28 -0700)]
Fix example code in skpaint.md.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1993903002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1993903002
Review-Url: https://codereview.chromium.org/
1993903002
borenet [Wed, 18 May 2016 19:23:58 +0000 (12:23 -0700)]
Blacklist HTC.dng on 32-bit Win CPU bots
BUG=skia:5318
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1995703002
Review-Url: https://codereview.chromium.org/
1995703002
borenet [Wed, 18 May 2016 15:12:51 +0000 (08:12 -0700)]
Skip composeshader_bitmap GM on 64-bit Win CPU Test bots
Temporary measure to get the bots green while the real issue is sorted out.
BUG=skia:5315
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1989323002
Review-Url: https://codereview.chromium.org/
1989323002
bsalomon [Wed, 18 May 2016 14:30:00 +0000 (07:30 -0700)]
Don't allow uncacheable paths in tessellated path renderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990793003
Review-Url: https://codereview.chromium.org/
1990793003
tomhudson [Wed, 18 May 2016 14:24:16 +0000 (07:24 -0700)]
SkCanvas::adjustToTopLayer()
Given a matrix and a clip bounds, offsets them to reflect the difference
between device coordinates and global coordinates. Useful when a client
wants an OS-specific backing for a canvas.
R=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986383002
Review-Url: https://codereview.chromium.org/
1986383002
bsalomon [Wed, 18 May 2016 14:15:46 +0000 (07:15 -0700)]
Reformat circle blur profile computation and add comments.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1981923002
BUG=skia:5224
Review-Url: https://codereview.chromium.org/
1981923002
jvanverth [Wed, 18 May 2016 14:01:16 +0000 (07:01 -0700)]
Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of https://codereview.chromium.org/
1978573003/ )
Reason for revert:
sk_app/WindowContext.cpp is missing. Need to add file and resubmit.
Original issue's description:
> Add OpenGL context to Viewer.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978573003
>
> Committed: https://skia.googlesource.com/skia/+/
56a11e4d6f3d436a3c2497c9c9e71a117d78a93f
TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1990893002
senorblanco [Wed, 18 May 2016 14:00:08 +0000 (07:00 -0700)]
Image filters: fix filtering of transparent black in CFIF.
SkColorFilterImageFilter has a codepath to filter transparent black
regions outside of the input image. However, it was treating the
exterior as opaque black, rather than trasparent black.
Note: the results of imagefiltercropexpand GM will change, as it
was tweaked a bit to show this bug.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978363002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
1978363002
reed [Wed, 18 May 2016 13:55:17 +0000 (06:55 -0700)]
remove animator from SampleApp
There is no xml parser hooked up, so the animator test file (already behind #if 0) is not testable. Removing the files to speedup building SampleApp.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1987963002
Review-Url: https://codereview.chromium.org/
1987963002
msarett [Wed, 18 May 2016 13:28:43 +0000 (06:28 -0700)]
Parse parametric gamma curves
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1972403002
Review-Url: https://codereview.chromium.org/
1972403002
msarett [Wed, 18 May 2016 13:23:57 +0000 (06:23 -0700)]
Delete SkBitmapRegionCanvas
This was an approach we considered for implementing Android's
BitmapRegionDecoder.
It was useful for testing and comparison, but now is no longer worth
maintaining and testing.
The approach to subset/scaled decodes (clipped decode, then scale)
may be worth reconsidering at some point.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990543002
Review-Url: https://codereview.chromium.org/
1990543002
kkinnunen [Wed, 18 May 2016 05:15:39 +0000 (22:15 -0700)]
Remove NVPR related env var from command buffer GL context creation
NVPR is now enabled by default for Chromium command buffer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1975753005
Review-Url: https://codereview.chromium.org/
1975753005
bsalomon [Wed, 18 May 2016 01:36:23 +0000 (18:36 -0700)]
Make SkBlend_optsTests fail rather than crash when resources are missing
BUG=skia:5314
TBR=herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1987143002
Review-Url: https://codereview.chromium.org/
1987143002
msarett [Tue, 17 May 2016 20:57:15 +0000 (13:57 -0700)]
SkColorSpace follow-ups
Based on comments from:
https://codereview.chromium.org/
1985903002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986833002
Review-Url: https://codereview.chromium.org/
1986833002
bsalomon [Tue, 17 May 2016 20:18:03 +0000 (13:18 -0700)]
Remove GrFontScaler class.
This class is now effectively a set of helpers for interacting with a SkGlyphCache by GrBatchTextStrike. The class is deleted and the code is made into static functions in GrBatchFontCache.cpp
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985163002
Review-Url: https://codereview.chromium.org/
1985163002
liyuqian [Tue, 17 May 2016 19:44:20 +0000 (12:44 -0700)]
Implement touch control
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982643004
Review-Url: https://codereview.chromium.org/
1982643004
msarett [Tue, 17 May 2016 19:37:39 +0000 (12:37 -0700)]
Fix leak of SkGammas
TBR=borenet@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1990533002
Review-Url: https://codereview.chromium.org/
1990533002
bungeman [Tue, 17 May 2016 19:24:24 +0000 (12:24 -0700)]
Fix code guarded by SK_FONT_HOST_USE_SYSTEM_SETTINGS.
BUG=skia:5313
Review-Url: https://codereview.chromium.org/
1988913003
jvanverth [Tue, 17 May 2016 19:15:48 +0000 (12:15 -0700)]
Add OpenGL context to Viewer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978573003
Review-Url: https://codereview.chromium.org/
1978573003
bsalomon [Tue, 17 May 2016 18:58:24 +0000 (11:58 -0700)]
Remove GrFontDescKey.
This was a reference counted wrapper of SkDescriptor. It doesn't seem like the copies are performance critical. This gets us closer to removing GrFontScaler.
Also removes some unused member functions on GrBatchTextStrike and GrFontScaler.
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1988833003
Review-Url: https://codereview.chromium.org/
1988833003
brianosman [Tue, 17 May 2016 18:47:32 +0000 (11:47 -0700)]
Set the "mutable format" bit on sRGB images at creation time.
This allows us to later create an image view with a linear format, for
legacy-mode non-sRGB access.
No actual API change (just a comment change in public header).
TBR=bsalomon@google.com
BUG=skia:5308
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1981333004
Review-Url: https://codereview.chromium.org/
1981333004
borenet [Tue, 17 May 2016 17:26:15 +0000 (10:26 -0700)]
Make VisualBench bot build the visualbench target
Plus drive-by fixes for expectations/coverage.
BUG=skia:5185
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986273002
Review-Url: https://codereview.chromium.org/
1986273002
bsalomon [Tue, 17 May 2016 17:17:45 +0000 (10:17 -0700)]
Rename SkDescriptor::equals to SkDescriptor::operator==
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986253002
Review-Url: https://codereview.chromium.org/
1986253002
robertphillips [Tue, 17 May 2016 16:57:46 +0000 (09:57 -0700)]
(Mostly) Retract GrRenderTarget from SkGpuDevice
This gets us most of the way to having SkGpuDevice exclusively use a GrDrawContext instead of a GrRenderTarget. There are a few other refactorings (e.g., rm need for fLegacyBitmap and accessRenderTarget) before the GrRenderTarget can be completely removed.
Has calved off:
https://codereview.chromium.org/
1925313002/ (Tighten up SkSpecialSurface factory functions)
https://codereview.chromium.org/
1925803004/ (Add sk_sp to SkSurface_Gpu and SkGpuDevice)
https://codereview.chromium.org/
1956473002/ (Retract GrRenderTarget a bit within SkGpuDevice)
https://codereview.chromium.org/
1979913002/ (Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext)
https://codereview.chromium.org/
1982583002/ (Add isUnifiedMultisampled entry point to GrDrawContext)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1930013002
Review-Url: https://codereview.chromium.org/
1930013002
herb [Tue, 17 May 2016 16:57:34 +0000 (09:57 -0700)]
Add tests and benches to support the sRGB blitter for SkOpts
1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
209.14 LinearSrcOverplane.pngVSkOptsSSE41
562.24 LinearSrcOverplane.pngVSkOptsDefault
272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
436.46 LinearSrcOverplane.pngVSkOptsTrivial
1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
Committed: https://skia.googlesource.com/skia/+/
bc927548db17accec2195af6e15053f7918bb3f5
Review-Url: https://codereview.chromium.org/
1939513002
msarett [Tue, 17 May 2016 16:31:20 +0000 (09:31 -0700)]
Prepare SkColorSpace to be a public API
Moves implementation details into SkColorSpacePriv.h
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985903002
Review-Url: https://codereview.chromium.org/
1985903002
msarett [Tue, 17 May 2016 16:31:04 +0000 (09:31 -0700)]
Update libpng to 1.6.22rc01
If there are no issues, this version will be released May 26.
Let's start testing with it, so we are ready to update Chrome when
it is available.
BUG=skia:4710
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1983853002
Review-Url: https://codereview.chromium.org/
1983853002
msarett [Tue, 17 May 2016 15:52:11 +0000 (08:52 -0700)]
Ensure that SkColorTable->fCount is set properly after decodes
We now have some blits that will process the color table.
If we erroneously report that the size of the color table is 256,
we will do extra work and annoy MSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982753002
Review-Url: https://codereview.chromium.org/
1982753002
bsalomon [Tue, 17 May 2016 15:36:41 +0000 (08:36 -0700)]
Make GrFontScaler not be ref-counted
This object is made invalid when the SkGlyphCache that it points to is destroyed.
BUG=chromium:608566
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982303002
Review-Url: https://codereview.chromium.org/
1982303002
herb [Tue, 17 May 2016 13:50:15 +0000 (06:50 -0700)]
Revert of Change to sRGB default for codec generated images. (patchset #2 id:20001 of https://codereview.chromium.org/
1955063002/ )
Reason for revert:
TBR=brianosman@google.com
Original issue's description:
> Change to sRGB default for codec generated images.
>
> Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1955063002
>
> Committed: https://skia.googlesource.com/skia/+/
7acc00853174361cf921ecac8fbeaf6812f53eed
TBR=brianosman@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1982323002
kkinnunen [Tue, 17 May 2016 13:01:40 +0000 (06:01 -0700)]
Remove workarounds initializing command buffer EGL
The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.
The EGL implementation is fixed as part of bug 581634.
Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API. Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/
1733323002.
BUG=581634, 603223
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978733003
Review-Url: https://codereview.chromium.org/
1978733003
reed [Tue, 17 May 2016 10:07:01 +0000 (03:07 -0700)]
Revert of Add specialized sRGB blitter for SkOpts (patchset #21 id:400001 of https://codereview.chromium.org/
1939513002/ )
Reason for revert:
broke some debug bots:
Running LinearSrcOvericonstrip.pngVSkOptsSSE41 nonrendering
../../../bench/SkBlend_optsBench.cpp:118: fatal error: ""fPixmap.colorType() == kRGBA_8888_SkColorType""
Original issue's description:
> Add tests and benches to support the sRGB blitter for SkOpts
>
> 1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
> 2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
> 1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
> 3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
> 9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
>
> 633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
> 684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
> 1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
> 2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
> 10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
>
> 209.14 LinearSrcOverplane.pngVSkOptsSSE41
> 562.24 LinearSrcOverplane.pngVSkOptsDefault
> 272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
> 436.46 LinearSrcOverplane.pngVSkOptsTrivial
> 1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
>
> 318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
> 529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
> 441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
> 720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
> 2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
>
> 479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
> 1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
> 668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
> 1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
> 4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
>
>
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
>
> Committed: https://skia.googlesource.com/skia/+/
bc927548db17accec2195af6e15053f7918bb3f5
TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
1986763002
herb [Mon, 16 May 2016 21:27:51 +0000 (14:27 -0700)]
Add tests and benches to support the sRGB blitter for SkOpts
1,370.85 LinearSrcOvericonstrip.pngVSkOptsSSE41
2,359.69 LinearSrcOvericonstrip.pngVSkOptsDefault
1,828.72 LinearSrcOvericonstrip.pngVSkOptsNonSimdCore
3,277.40 LinearSrcOvericonstrip.pngVSkOptsTrivial
9,862.34 LinearSrcOvericonstrip.pngVSkOptsBruteForce
633.55 LinearSrcOvermandrill_512.pngVSkOptsSSE41
684.29 LinearSrcOvermandrill_512.pngVSkOptsDefault
1,201.88 LinearSrcOvermandrill_512.pngVSkOptsNonSimdCore
2,382.63 LinearSrcOvermandrill_512.pngVSkOptsTrivial
10,888.74 LinearSrcOvermandrill_512.pngVSkOptsBruteForce
209.14 LinearSrcOverplane.pngVSkOptsSSE41
562.24 LinearSrcOverplane.pngVSkOptsDefault
272.64 LinearSrcOverplane.pngVSkOptsNonSimdCore
436.46 LinearSrcOverplane.pngVSkOptsTrivial
1,327.23 LinearSrcOverplane.pngVSkOptsBruteForce
318.01 LinearSrcOverbaby_tux.pngVSkOptsSSE41
529.05 LinearSrcOverbaby_tux.pngVSkOptsDefault
441.33 LinearSrcOverbaby_tux.pngVSkOptsNonSimdCore
720.50 LinearSrcOverbaby_tux.pngVSkOptsTrivial
2,191.10 LinearSrcOverbaby_tux.pngVSkOptsBruteForce
479.68 LinearSrcOveryellow_rose.pngVSkOptsSSE41
1,095.03 LinearSrcOveryellow_rose.pngVSkOptsDefault
668.60 LinearSrcOveryellow_rose.pngVSkOptsNonSimdCore
1,257.19 LinearSrcOveryellow_rose.pngVSkOptsTrivial
4,970.25 LinearSrcOveryellow_rose.pngVSkOptsBruteForce
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1939513002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
554784cd85029c05d9ed04b1aeb71520d196153a
Review-Url: https://codereview.chromium.org/
1939513002
bsalomon [Mon, 16 May 2016 21:09:56 +0000 (14:09 -0700)]
Implement vulkan fence syncs for nanobench
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974913003
Review-Url: https://codereview.chromium.org/
1974913003
bungeman [Mon, 16 May 2016 19:39:23 +0000 (12:39 -0700)]
Remove unneeded reference count churn.
An object was ref'ed only to be automatically unref'ed.
Review-Url: https://codereview.chromium.org/
1979193009
borenet [Mon, 16 May 2016 17:38:51 +0000 (10:38 -0700)]
Move VisualBench_APK and SampleApp_APK to "everything" target
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1986433002
Review-Url: https://codereview.chromium.org/
1986433002
robertphillips [Mon, 16 May 2016 16:50:03 +0000 (09:50 -0700)]
Add isUnifiedMultisampled entry point to GrDrawContext
GrRenderTargetProxy supports the isUnifiedMultisampled call so GrDrawContext will be able to support it even when GrRenderTargetProxy-backed.
This is split out of: https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1982583002
Review-Url: https://codereview.chromium.org/
1982583002
herb [Mon, 16 May 2016 16:43:54 +0000 (09:43 -0700)]
Change to sRGB default for codec generated images.
Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1955063002
Review-Url: https://codereview.chromium.org/
1955063002
bsalomon [Mon, 16 May 2016 16:36:44 +0000 (09:36 -0700)]
Make blurcircles2 run as a benchmark.
In bench mode it does not draw the comparison paths (or line separators). It also randomly perturbs the blur and circle radii to avoid trivially hitting the same cache entries and each repetition.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1985713002
Review-Url: https://codereview.chromium.org/
1985713002
msarett [Mon, 16 May 2016 16:23:42 +0000 (09:23 -0700)]
Recognize Adobe RGB profiles
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971203002
Review-Url: https://codereview.chromium.org/
1971203002
robertphillips [Mon, 16 May 2016 16:14:53 +0000 (09:14 -0700)]
Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext
Since GrDrawingContext is generally replacing GrRenderTarget, this is to provide functionality similar to GrRenderTarget::wasDestroyed.
This is split out of https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1979913002
Review-Url: https://codereview.chromium.org/
1979913002
bsalomon [Mon, 16 May 2016 16:09:18 +0000 (09:09 -0700)]
Run GM benchs in bench mode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978253002
Review-Url: https://codereview.chromium.org/
1978253002
scroggo [Mon, 16 May 2016 16:04:18 +0000 (09:04 -0700)]
Only run kStripe_Mode on JPEGs
It was designed to test code in libjpeg-turbo. Skipping scanlines is
tested more generally in other tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978013002
Review-Url: https://codereview.chromium.org/
1978013002
scroggo [Mon, 16 May 2016 16:04:13 +0000 (09:04 -0700)]
Drop AndroidCodecSrc::kDivisor_Mode
This is redundant with BRD tests.
BUG=skia:5307
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1976303002
Review-Url: https://codereview.chromium.org/
1976303002
robertphillips [Sun, 15 May 2016 14:53:35 +0000 (07:53 -0700)]
Retract GrRenderTarget from AlphaClipMask code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
Committed: https://skia.googlesource.com/skia/+/
93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
Review-Url: https://codereview.chromium.org/
1977793004
update-skps [Sun, 15 May 2016 07:41:23 +0000 (00:41 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1979893002
Review-Url: https://codereview.chromium.org/
1979893002
bsalomon [Sun, 15 May 2016 00:55:32 +0000 (17:55 -0700)]
Fix return from nullptr to false in GrVkTexture.cpp
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978113002
Review-Url: https://codereview.chromium.org/
1978113002
bsalomon [Fri, 13 May 2016 20:48:48 +0000 (13:48 -0700)]
Add blurcircles2 GM
In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison.
In Sample mode this draws a single circle and almost-circle with animating radius and blur radius.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974353003
Review-Url: https://codereview.chromium.org/
1974353003
bsalomon [Fri, 13 May 2016 20:47:04 +0000 (13:47 -0700)]
Revert of Retract GrRenderTarget from AlphaClipMask code (patchset #3 id:40001 of https://codereview.chromium.org/
1977793004/ )
Reason for revert:
Possible cause of leak in ASAN bot:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3351
Original issue's description:
> Retract GrRenderTarget from AlphaClipMask code
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
>
> Committed: https://skia.googlesource.com/skia/+/
93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d
TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
1975353002
egdaniel [Fri, 13 May 2016 20:43:44 +0000 (13:43 -0700)]
Fix msaa on GrVkRenderTarget
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977113002
Review-Url: https://codereview.chromium.org/
1977113002
robertphillips [Fri, 13 May 2016 18:51:23 +0000 (11:51 -0700)]
Retract GrRenderTarget from AlphaClipMask code
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1977793004
Review-Url: https://codereview.chromium.org/
1977793004
fmalita [Fri, 13 May 2016 18:40:07 +0000 (11:40 -0700)]
SkPictureGpuAnalyzer
Stateful helper for gathering multi-picture GPU stats.
Exposes the existing SkPicture GPU veto semantics, while preserving
the SKP impl (which has some nice properties: lazy, hierarchical,
cached per pic).
R=reed@google.com,bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974833003
Review-Url: https://codereview.chromium.org/
1974833003
egdaniel [Fri, 13 May 2016 18:30:37 +0000 (11:30 -0700)]
Refactor Vulkan image, texture, RTs so that create and getter handles match.
This allows allows us to track and notify clients when either side changes
and image layout.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1974983002
Review-Url: https://codereview.chromium.org/
1974983002
cdalton [Fri, 13 May 2016 18:27:15 +0000 (11:27 -0700)]
Abort stencil draws when the attachment fails
BUG=skia:611514
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971353003
Review-Url: https://codereview.chromium.org/
1971353003
robertphillips [Fri, 13 May 2016 18:20:46 +0000 (11:20 -0700)]
Retract GrRenderTarget a bit within SkGpuDevice
Split off of: https://codereview.chromium.org/
1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1956473002
Committed: https://skia.googlesource.com/skia/+/
d215a95882485026d176a81bf58871276b21c89c
Review-Url: https://codereview.chromium.org/
1956473002
cdalton [Fri, 13 May 2016 17:25:00 +0000 (10:25 -0700)]
Convert GrClip to an abstract base class
Converts GrClip to an abstract base class and adds a "GrFixedClip"
implementation. GrFixedClip denotes a clip implemented with fixed-
function hardware. GrFixedClip allows us to remove the stateful
"fClipMode" member from GrClipMaskManager, and in the future will
be able to nicely encapsulate window rectangles.
After this change GrClipMaskManager is just a wrapper around
GrDrawTarget. We may want to consider removing it altogether.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1971343002
Review-Url: https://codereview.chromium.org/
1971343002
herb [Fri, 13 May 2016 17:04:46 +0000 (10:04 -0700)]
This has all the different source types in and working. There are many SkDiffs, but they seem to be due to better resolution.
This seems to fix all the bugs involved with make all the images produced by the codec to default to sRGB.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1967283002
Review-Url: https://codereview.chromium.org/
1967283002
liyuqian [Fri, 13 May 2016 16:57:44 +0000 (09:57 -0700)]
Change Android activity title from JNI call
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1978843002
Review-Url: https://codereview.chromium.org/
1978843002
bsalomon [Fri, 13 May 2016 16:23:38 +0000 (09:23 -0700)]
Add bounds to GrShape
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1970003003
Review-Url: https://codereview.chromium.org/
1970003003