platform/upstream/libSkiaSharp.git
11 years agoensure that negative zeros are still ignored when computing isIdentity()
reed@google.com [Fri, 19 Apr 2013 12:25:00 +0000 (12:25 +0000)]
ensure that negative zeros are still ignored when computing isIdentity()

crbug.com/162747

git-svn-id: http://skia.googlecode.com/svn/trunk@8761 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoenable path ops in unit tests
caryclark@google.com [Fri, 19 Apr 2013 11:45:56 +0000 (11:45 +0000)]
enable path ops in unit tests

git-svn-id: http://skia.googlecode.com/svn/trunk@8760 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 19 Apr 2013 07:01:00 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8759 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test the commit queue. (SkipBuildbotRuns)
commit-bot@chromium.org [Fri, 19 Apr 2013 02:37:53 +0000 (02:37 +0000)]
Whitespace change to test the commit queue. (SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/14079004

git-svn-id: http://skia.googlecode.com/svn/trunk@8758 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
commit-bot@chromium.org [Fri, 19 Apr 2013 02:36:29 +0000 (02:36 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@8757 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops : remove countdown overkill
caryclark@google.com [Thu, 18 Apr 2013 19:50:01 +0000 (19:50 +0000)]
path ops : remove countdown overkill
Review URL: https://codereview.chromium.org/13958005

git-svn-id: http://skia.googlecode.com/svn/trunk@8756 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpand modulate, add, subtract, extract component glsl helpers.
bsalomon@google.com [Thu, 18 Apr 2013 19:36:09 +0000 (19:36 +0000)]
Expand modulate, add, subtract, extract component glsl helpers.
Review URL: https://codereview.chromium.org/13895006

git-svn-id: http://skia.googlecode.com/svn/trunk@8755 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisabling path ops
caryclark@google.com [Thu, 18 Apr 2013 19:21:06 +0000 (19:21 +0000)]
disabling path ops

Default single-threaded variant may wait forever.
Review URL: https://codereview.chromium.org/13874014

git-svn-id: http://skia.googlecode.com/svn/trunk@8754 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove exclude of file which no longer exists.
bungeman@google.com [Thu, 18 Apr 2013 19:18:19 +0000 (19:18 +0000)]
Remove exclude of file which no longer exists.

git-svn-id: http://skia.googlecode.com/svn/trunk@8753 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable path ops
caryclark@google.com [Thu, 18 Apr 2013 19:02:56 +0000 (19:02 +0000)]
Enable path ops

Path ops work (to my knowledge) on all platforms.
Turning it on will use the bots to expose failing
combinations I don't know about.
Review URL: https://codereview.chromium.org/14057014

git-svn-id: http://skia.googlecode.com/svn/trunk@8751 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow tests to optionally use multiple threads
caryclark@google.com [Thu, 18 Apr 2013 18:47:37 +0000 (18:47 +0000)]
allow tests to optionally use multiple threads

modify threaded path ops tests to check

Background: this CL came out of a conversation with Eric where I learned that 10s of machines host 100s of bots. Since the bot hosting tests may be shared with many other tasks, it seems unwise for path ops to launch multiple test threads.

The change here is to make launching multiple threads "opt-in" and by default, bots can run path ops in a single thread.
Review URL: https://codereview.chromium.org/14002007

git-svn-id: http://skia.googlecode.com/svn/trunk@8750 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkAutoTDelete instead of SkTScopedPtr
reed@google.com [Thu, 18 Apr 2013 18:43:26 +0000 (18:43 +0000)]
use SkAutoTDelete instead of SkTScopedPtr
Review URL: https://codereview.chromium.org/13831011

git-svn-id: http://skia.googlecode.com/svn/trunk@8749 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compile warning
caryclark@google.com [Thu, 18 Apr 2013 17:44:57 +0000 (17:44 +0000)]
Fix compile warning
Review URL: https://codereview.chromium.org/14227005

git-svn-id: http://skia.googlecode.com/svn/trunk@8748 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops work in progress
caryclark@google.com [Thu, 18 Apr 2013 15:58:21 +0000 (15:58 +0000)]
path ops work in progress

fix bugs in tests on 32 bit release

Most changes revolve around pinning computed t values
very close to zero and one.

git-svn-id: http://skia.googlecode.com/svn/trunk@8745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoaugmenting fix in 8700 and 8701, be careful NOT to "sort" the result of mapRect
reed@google.com [Thu, 18 Apr 2013 15:37:14 +0000 (15:37 +0000)]
augmenting fix in 8700 and 8701, be careful NOT to "sort" the result of mapRect
when we only want to proceed if the matrix is nearly identity. Hence we manually
apply the matrix to the two "points" of the rect.

git-svn-id: http://skia.googlecode.com/svn/trunk@8743 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 8731, restoring 8700 and 8701... further investigation concluded that the
reed@google.com [Thu, 18 Apr 2013 15:33:27 +0000 (15:33 +0000)]
revert 8731, restoring 8700 and 8701... further investigation concluded that the
original changes were correct. The failures in DRT will be rebaselined.

git-svn-id: http://skia.googlecode.com/svn/trunk@8742 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReset shader in ovals GM
jvanverth@google.com [Thu, 18 Apr 2013 14:48:35 +0000 (14:48 +0000)]
Reset shader in ovals GM

Not resetting the shader for the paints produces interesting
results on the following configs...

Review URL: https://codereview.chromium.org/13947042/

git-svn-id: http://skia.googlecode.com/svn/trunk@8740 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding a bit of rebustness to SkRectShaderImageFilter
sugoi@google.com [Thu, 18 Apr 2013 14:13:10 +0000 (14:13 +0000)]
Adding a bit of rebustness to SkRectShaderImageFilter

Since SkRectShaderImageFilter is an image filter, I added logic so that it can actually use the size of an input image as the rect if an empty rect is provided as an argument. I also added logic to prevent creating an empty device.

Review URL: https://codereview.chromium.org/14093008

git-svn-id: http://skia.googlecode.com/svn/trunk@8739 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisabling GPU noise on Windows since Angle can't do a proper translation of this...
sugoi@google.com [Thu, 18 Apr 2013 14:04:57 +0000 (14:04 +0000)]
Disabling GPU noise on Windows since Angle can't do a proper translation of this shader to HLSL.

git-svn-id: http://skia.googlecode.com/svn/trunk@8738 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a GM to test ovals with a variety of paint settings, matrices and sizes.
jvanverth@google.com [Thu, 18 Apr 2013 13:59:04 +0000 (13:59 +0000)]
Add a GM to test ovals with a variety of paint settings, matrices and sizes.

Review URL: https://codereview.chromium.org/14329008/

git-svn-id: http://skia.googlecode.com/svn/trunk@8737 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding SK_API to export SkImage and SkSurface API classes
junov@chromium.org [Thu, 18 Apr 2013 13:28:19 +0000 (13:28 +0000)]
Adding SK_API to export SkImage and SkSurface API classes
Review URL: https://codereview.chromium.org/14328002

git-svn-id: http://skia.googlecode.com/svn/trunk@8736 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus7 cuteoverload performance trigger
robertphillips@google.com [Thu, 18 Apr 2013 12:32:28 +0000 (12:32 +0000)]
Rebaseline Nexus7 cuteoverload performance trigger

git-svn-id: http://skia.googlecode.com/svn/trunk@8735 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 18 Apr 2013 07:01:48 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8732 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r8701 and r8700 due to layout test discrepancies
robertphillips@google.com [Wed, 17 Apr 2013 21:32:03 +0000 (21:32 +0000)]
Revert r8701 and r8700 due to layout test discrepancies

git-svn-id: http://skia.googlecode.com/svn/trunk@8731 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdates to images project.
scroggo@google.com [Wed, 17 Apr 2013 21:07:55 +0000 (21:07 +0000)]
Updates to images project.

Use the SkImageEncoder_Factory on all platforms. On Windows and Mac,
register the platform's image encoder as an option for
SkImageEncoder::Create. Also add more types that can be decoded.

Update comments for SkImageDecoder to be more accurate.

Add more types to SkImageEncoder::Type, and return the correct type of
encoder, if it exists.

Use a custom version of SkImageDecoder::Factory on Windows and Mac to
check the stream for registered decoders before defaulting to the platform's
version. Share code with the existing SkImageDecoder::Factory method.

Preparation for testing decoders and encoders:
BUG=https://code.google.com/p/skia/issues/detail?id=1241

Review URL: https://codereview.chromium.org/14298010

git-svn-id: http://skia.googlecode.com/svn/trunk@8730 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly use JDCT_IFAST if it's supported.
scroggo@google.com [Wed, 17 Apr 2013 17:37:56 +0000 (17:37 +0000)]
Only use JDCT_IFAST if it's supported.

When encoding to JPEG, do not switch to JDCT_IFAST unless
DCT_IFAST_SUPPORTED is defined.

Review URL: https://codereview.chromium.org/14031013

git-svn-id: http://skia.googlecode.com/svn/trunk@8728 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops in progress
caryclark@google.com [Wed, 17 Apr 2013 16:19:02 +0000 (16:19 +0000)]
path ops in progress

fix numeric check for cubic-to-quad conversion
to be 80-bit safe

git-svn-id: http://skia.googlecode.com/svn/trunk@8727 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Wed, 17 Apr 2013 15:49:16 +0000 (15:49 +0000)]
shape ops work in progress

Try to fix the 32 bit build by making some math
decisions more robust.

Rewrite the cubic intersection special case that
detects if only end points are shared.

Rewrite the angle sort setup that computes whether
a cubic bends to the left or right.

git-svn-id: http://skia.googlecode.com/svn/trunk@8726 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReducing the complexity of the noise test for Angle
sugoi@google.com [Wed, 17 Apr 2013 15:34:09 +0000 (15:34 +0000)]
Reducing the complexity of the noise test for Angle

git-svn-id: http://skia.googlecode.com/svn/trunk@8725 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing debug bench assert on Android
sugoi@google.com [Wed, 17 Apr 2013 14:50:38 +0000 (14:50 +0000)]
Fixing debug bench assert on Android

git-svn-id: http://skia.googlecode.com/svn/trunk@8724 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkip copytexsubimage2D code path when src is multisampled.
bsalomon@google.com [Wed, 17 Apr 2013 14:25:27 +0000 (14:25 +0000)]
Skip copytexsubimage2D code path when src is multisampled.
Review URL: https://codereview.chromium.org/14048015

git-svn-id: http://skia.googlecode.com/svn/trunk@8722 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd xfermodes2 GM. Tests all xfer modes with two gradient bitmaps
bsalomon@google.com [Wed, 17 Apr 2013 14:19:44 +0000 (14:19 +0000)]
Add xfermodes2 GM. Tests all xfer modes with two gradient bitmaps
Review URL: https://codereview.chromium.org/13912017

git-svn-id: http://skia.googlecode.com/svn/trunk@8721 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix
junov@chromium.org [Wed, 17 Apr 2013 13:55:45 +0000 (13:55 +0000)]
Build fix

TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@8720 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerlin noise adjustments
sugoi@google.com [Wed, 17 Apr 2013 13:46:56 +0000 (13:46 +0000)]
Perlin noise adjustments

1 ) Added GPU simplex noise as a comparison to GPU Perlin noise. It can be enabled simply by using a #define (SK_USE_SIMPLEX_NOISE)
2 ) Enabled GPU Perlin noise tests
3 ) Added a small benchmark for noise
4 ) Disabled GPU Perlin noise on Android based on benchmarks

Review URL: https://codereview.chromium.org/14087002

git-svn-id: http://skia.googlecode.com/svn/trunk@8719 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBenchmark to measure SkSurface copy on write performance
junov@chromium.org [Wed, 17 Apr 2013 13:43:04 +0000 (13:43 +0000)]
Benchmark to measure SkSurface copy on write performance
Review URL: https://codereview.chromium.org/14297008

git-svn-id: http://skia.googlecode.com/svn/trunk@8718 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove deprecated/obsolete Makefiles.
tfarina@chromium.org [Wed, 17 Apr 2013 13:36:15 +0000 (13:36 +0000)]
Remove deprecated/obsolete Makefiles.

$ git ls-files | grep .mk

or

$ find . -name *.mk

R=epoger@google.com,reed@google.com

Review URL: https://codereview.chromium.org/14216002

git-svn-id: http://skia.googlecode.com/svn/trunk@8717 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 17 Apr 2013 07:00:56 +0000 (07:00 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8714 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd compute-bounds for conics
mike@reedtribe.org [Wed, 17 Apr 2013 02:25:33 +0000 (02:25 +0000)]
add compute-bounds for conics

git-svn-id: http://skia.googlecode.com/svn/trunk@8713 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd extrema for conics
mike@reedtribe.org [Wed, 17 Apr 2013 01:21:01 +0000 (01:21 +0000)]
add extrema for conics

git-svn-id: http://skia.googlecode.com/svn/trunk@8712 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd comments for computing derivatives
reed@google.com [Tue, 16 Apr 2013 21:07:27 +0000 (21:07 +0000)]
add comments for computing derivatives

git-svn-id: http://skia.googlecode.com/svn/trunk@8711 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix: moving more inline functions into header
junov@chromium.org [Tue, 16 Apr 2013 19:56:45 +0000 (19:56 +0000)]
Build fix: moving more inline functions into header

TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@8710 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix: moving some inline function definitions into header.
junov@chromium.org [Tue, 16 Apr 2013 19:50:30 +0000 (19:50 +0000)]
Build fix: moving some inline function definitions into header.

TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@8709 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup: Removing unnecessary args/complexity in SkSurface_Base and friends
junov@chromium.org [Tue, 16 Apr 2013 19:41:09 +0000 (19:41 +0000)]
Cleanup: Removing unnecessary args/complexity in SkSurface_Base and friends
Review URL: https://codereview.chromium.org/14263017

git-svn-id: http://skia.googlecode.com/svn/trunk@8708 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete gm after use.
scroggo@google.com [Tue, 16 Apr 2013 19:11:14 +0000 (19:11 +0000)]
Delete gm after use.

Fixes a memory leak when using the --modulo flag. Instead of deleting
manually in each case we are done with it (which led to missing one
case), use an SkAutoTDelete.

Review URL: https://codereview.chromium.org/13929019

git-svn-id: http://skia.googlecode.com/svn/trunk@8707 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange shortName to match filename
reed@google.com [Tue, 16 Apr 2013 17:58:38 +0000 (17:58 +0000)]
change shortName to match filename

git-svn-id: http://skia.googlecode.com/svn/trunk@8705 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd () around | cluster, to avoid warning.
reed@google.com [Tue, 16 Apr 2013 17:18:57 +0000 (17:18 +0000)]
add () around | cluster, to avoid warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@8701 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse forward matrix to determine if we can ignore scale part of a matrix
reed@google.com [Tue, 16 Apr 2013 17:14:45 +0000 (17:14 +0000)]
use forward matrix to determine if we can ignore scale part of a matrix
Review URL: https://codereview.chromium.org/14018020

git-svn-id: http://skia.googlecode.com/svn/trunk@8700 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix new gm to actually trigger the bug
reed@google.com [Tue, 16 Apr 2013 17:04:43 +0000 (17:04 +0000)]
fix new gm to actually trigger the bug

git-svn-id: http://skia.googlecode.com/svn/trunk@8699 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd gm to test edge case in drawBitmapRectToRect
reed@google.com [Tue, 16 Apr 2013 16:55:38 +0000 (16:55 +0000)]
add gm to test edge case in drawBitmapRectToRect

git-svn-id: http://skia.googlecode.com/svn/trunk@8698 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove 'friend SkRefCnt' from SkData.
bungeman@google.com [Tue, 16 Apr 2013 15:24:31 +0000 (15:24 +0000)]
Remove 'friend SkRefCnt' from SkData.
https://codereview.chromium.org/13925021/

If a non-POD class does not provide a default destructor, one is
provided by teh compiler. GCC will do so, but only at the point where the
vtable is output; since BlockRef has no implementation its destructor is
never output, so there is no complaint. VC++, however, provides the
destructor implementation as soon as it sees the type. If the destructor
of BlockRef is ever defined an error will be reported (since the
destructor of SkData is private).

Declaring (but does not defining) a destructor for BlockRef fixes two
issues. First, it prevents a default destructor from being provided,
removing the VC++ error. Second, BlockRef now blocks access to the
destructor through '->'.

git-svn-id: http://skia.googlecode.com/svn/trunk@8697 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable GPU acceleration for narrow ovals.
jvanverth@google.com [Tue, 16 Apr 2013 12:30:35 +0000 (12:30 +0000)]
Disable GPU acceleration for narrow ovals.

GPU anti-aliasing is currently not correct for ellipses where the ratio of long
axis length to short axis length is greater than 2 (see
https://code.google.com/p/skia/issues/detail?id=1249). This disables the GPU
path for those cases.

Review URL: https://codereview.chromium.org/13925015/

git-svn-id: http://skia.googlecode.com/svn/trunk@8694 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 16 Apr 2013 07:01:17 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8693 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse ILLEGAL_MODE macro to silence clang error.
tfarina@chromium.org [Mon, 15 Apr 2013 22:12:43 +0000 (22:12 +0000)]
Use ILLEGAL_MODE macro to silence clang error.

This fixes the following clang error:

../../tests/XfermodeTest.cpp:43:44: error: comparison of constant -1 with expression of type 'SkXfermode::Mode' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
    REPORTER_ASSERT(reporter, reportedMode == -1);
                                  ~~~~~~~~~~~~ ^  ~~

R=vandebo@chromium.org,reed@google.com

Review URL: https://codereview.chromium.org/14180004

git-svn-id: http://skia.googlecode.com/svn/trunk@8692 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLink webp in skimage and debugger.
scroggo@google.com [Mon, 15 Apr 2013 22:05:03 +0000 (22:05 +0000)]
Link webp in skimage and debugger.

Review URL: https://codereview.chromium.org/14103020

git-svn-id: http://skia.googlecode.com/svn/trunk@8691 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable caching of texture domain extents
robertphillips@google.com [Mon, 15 Apr 2013 21:51:52 +0000 (21:51 +0000)]
Enable caching of texture domain extents

https://codereview.chromium.org/14261009/

git-svn-id: http://skia.googlecode.com/svn/trunk@8690 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopath ops work in progress
caryclark@google.com [Mon, 15 Apr 2013 19:13:59 +0000 (19:13 +0000)]
path ops work in progress

standardize tests
use SK_ARRAY_COUNT everywhere
debug why x87 differs from SIMD 64
various platform specific fixes

git-svn-id: http://skia.googlecode.com/svn/trunk@8689 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer.
junov@chromium.org [Mon, 15 Apr 2013 18:15:23 +0000 (18:15 +0000)]
Fix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer.

The fImmediateDevice member of DeferredDevice (SkDeferredCanvas.cpp) was becoming invalid after a fork of the backingstore in SkSurface_Gpu cause the device to be substituted.

New unit test code was to exercise SkSurface copy on write with draws that are deferred in GrInOrderDrawBuffer.  The bad pointer was causing the test to crash.

TEST=skia unit test DeferredCanvas, subtest TestDeferredCanvasSurface
Review URL: https://codereview.chromium.org/14263015

git-svn-id: http://skia.googlecode.com/svn/trunk@8686 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove resource dir from gm to trunk
borenet@google.com [Mon, 15 Apr 2013 17:36:08 +0000 (17:36 +0000)]
Move resource dir from gm to trunk

git-svn-id: http://skia.googlecode.com/svn/trunk@8684 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix release warning (unused debug variable)
reed@google.com [Mon, 15 Apr 2013 15:23:38 +0000 (15:23 +0000)]
fix release warning (unused debug variable)

git-svn-id: http://skia.googlecode.com/svn/trunk@8682 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd experimental chop-into-quads for conics
mike@reedtribe.org [Mon, 15 Apr 2013 15:20:52 +0000 (15:20 +0000)]
add experimental chop-into-quads for conics

git-svn-id: http://skia.googlecode.com/svn/trunk@8681 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd coeffecients for kScreen xfermode.
bsalomon@google.com [Mon, 15 Apr 2013 15:16:47 +0000 (15:16 +0000)]
Add coeffecients for kScreen xfermode.
Review URL: https://codereview.chromium.org/14046021

git-svn-id: http://skia.googlecode.com/svn/trunk@8680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove freetype dependency from core.gyp
djsollen@google.com [Mon, 15 Apr 2013 14:37:28 +0000 (14:37 +0000)]
Remove freetype dependency from core.gyp

Committed: https://code.google.com/p/skia/source/detail?r=8677

Review URL: https://codereview.chromium.org/13975014

git-svn-id: http://skia.googlecode.com/svn/trunk@8678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove freetype dependency from core.gyp
djsollen@google.com [Mon, 15 Apr 2013 14:02:32 +0000 (14:02 +0000)]
Remove freetype dependency from core.gyp

Review URL: https://codereview.chromium.org/13975014

git-svn-id: http://skia.googlecode.com/svn/trunk@8677 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoComment only change. (forgot to save comment edit before landing r8675).
bsalomon@google.com [Mon, 15 Apr 2013 13:55:02 +0000 (13:55 +0000)]
Comment only change. (forgot to save comment edit before landing r8675).

git-svn-id: http://skia.googlecode.com/svn/trunk@8676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for using glCopyTexSubImage2D when possible to copy surfaces.
bsalomon@google.com [Mon, 15 Apr 2013 13:51:00 +0000 (13:51 +0000)]
Add support for using glCopyTexSubImage2D when possible to copy surfaces.
Review URL: https://codereview.chromium.org/13915011

git-svn-id: http://skia.googlecode.com/svn/trunk@8675 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sun, 14 Apr 2013 07:01:08 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd special-case for chopping at exactly half for rational-quads (2-3x faster)
mike@reedtribe.org [Sun, 14 Apr 2013 02:40:50 +0000 (02:40 +0000)]
add special-case for chopping at exactly half for rational-quads (2-3x faster)

git-svn-id: http://skia.googlecode.com/svn/trunk@8672 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocompute new weight in standard-form
mike@reedtribe.org [Sat, 13 Apr 2013 10:51:51 +0000 (10:51 +0000)]
compute new weight in standard-form

git-svn-id: http://skia.googlecode.com/svn/trunk@8671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 13 Apr 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM::height() now returns the height, not the width.
scroggo@google.com [Fri, 12 Apr 2013 22:14:03 +0000 (22:14 +0000)]
GM::height() now returns the height, not the width.

Fortunately, the only current caller has a width and height that
match, so this should not change any existing GMs.

Review URL: https://codereview.chromium.org/14234022

git-svn-id: http://skia.googlecode.com/svn/trunk@8669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoincomplete impl for chopping rational quads (need to "normalize" so I can get
reed@google.com [Fri, 12 Apr 2013 21:55:26 +0000 (21:55 +0000)]
incomplete impl for chopping rational quads (need to "normalize" so I can get
the new middle weight).

git-svn-id: http://skia.googlecode.com/svn/trunk@8668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing viral copy/paste typo Shapshot -> Snapshot
junov@chromium.org [Fri, 12 Apr 2013 20:20:50 +0000 (20:20 +0000)]
Fixing viral copy/paste typo Shapshot -> Snapshot

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@8667 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf the tree is closed then print information about contacting the sheriff.
rmistry@google.com [Fri, 12 Apr 2013 19:45:46 +0000 (19:45 +0000)]
If the tree is closed then print information about contacting the sheriff.

The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexperimental start to arcs
reed@google.com [Fri, 12 Apr 2013 19:11:10 +0000 (19:11 +0000)]
experimental start to arcs

git-svn-id: http://skia.googlecode.com/svn/trunk@8665 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: add self-test that sets --readPath to a nonexistent directory path
epoger@google.com [Fri, 12 Apr 2013 19:05:57 +0000 (19:05 +0000)]
GM: add self-test that sets --readPath to a nonexistent directory path
Review URL: https://codereview.chromium.org/13844011

git-svn-id: http://skia.googlecode.com/svn/trunk@8664 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly use JDCT_FAST if it is supported in jpeg.
scroggo@google.com [Fri, 12 Apr 2013 16:28:21 +0000 (16:28 +0000)]
Only use JDCT_FAST if it is supported in jpeg.

Fixes a bug where jpeg decoder did not work on linux.

Review URL: https://codereview.chromium.org/14188002

git-svn-id: http://skia.googlecode.com/svn/trunk@8661 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexplicitly initialize all entries in array of SkBaseMatrix, since we can't say
reed@google.com [Fri, 12 Apr 2013 15:34:53 +0000 (15:34 +0000)]
explicitly initialize all entries in array of SkBaseMatrix, since we can't say
that implicitly in C (given that our initializer value may not be all zeros).

crbug.com/174644
Review URL: https://codereview.chromium.org/13990003

git-svn-id: http://skia.googlecode.com/svn/trunk@8660 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCompiler warning/error patch for r8658
robertphillips@google.com [Fri, 12 Apr 2013 15:24:29 +0000 (15:24 +0000)]
Compiler warning/error patch for r8658

git-svn-id: http://skia.googlecode.com/svn/trunk@8659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd testing of optimizations to GM
robertphillips@google.com [Fri, 12 Apr 2013 15:13:35 +0000 (15:13 +0000)]
Add testing of optimizations to GM

https://codereview.chromium.org/12843028/

git-svn-id: http://skia.googlecode.com/svn/trunk@8658 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix NaCl build.
scroggo@google.com [Fri, 12 Apr 2013 15:04:33 +0000 (15:04 +0000)]
Fix NaCl build.

In SkDebugger.cpp::forceLinking(), call CreateGIFDecoder on linux
but not on NaCl.

Review URL: https://codereview.chromium.org/13975008

git-svn-id: http://skia.googlecode.com/svn/trunk@8656 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r8654
robertphillips@google.com [Fri, 12 Apr 2013 14:59:02 +0000 (14:59 +0000)]
Reverting r8654

git-svn-id: http://skia.googlecode.com/svn/trunk@8655 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd testing of optimizations to GM
robertphillips@google.com [Fri, 12 Apr 2013 14:53:29 +0000 (14:53 +0000)]
Add testing of optimizations to GM

https://codereview.chromium.org/12843028/

git-svn-id: http://skia.googlecode.com/svn/trunk@8654 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoForce the debugger to link decoders.
scroggo@google.com [Fri, 12 Apr 2013 14:50:10 +0000 (14:50 +0000)]
Force the debugger to link decoders.

This is required to play back SKPs with encoded data in them.

Review URL: https://codereview.chromium.org/14135004

git-svn-id: http://skia.googlecode.com/svn/trunk@8653 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: allow caller to specify which result types trigger an error
epoger@google.com [Fri, 12 Apr 2013 14:11:21 +0000 (14:11 +0000)]
GM: allow caller to specify which result types trigger an error
Review URL: https://codereview.chromium.org/14187007

git-svn-id: http://skia.googlecode.com/svn/trunk@8652 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding 'static' to eleminate compile warning on mac
junov@chromium.org [Fri, 12 Apr 2013 13:34:47 +0000 (13:34 +0000)]
Adding 'static' to eleminate compile warning on mac

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@8649 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding SkSurface support to SkDeferredCanvas
junov@chromium.org [Fri, 12 Apr 2013 13:33:01 +0000 (13:33 +0000)]
Adding SkSurface support to SkDeferredCanvas
Review URL: https://codereview.chromium.org/14178002

git-svn-id: http://skia.googlecode.com/svn/trunk@8648 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert path ops unit test until errors are fixed
caryclark@google.com [Fri, 12 Apr 2013 12:12:09 +0000 (12:12 +0000)]
revert path ops unit test until errors are fixed

git-svn-id: http://skia.googlecode.com/svn/trunk@8645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoturn on pathops unit test
caryclark@google.com [Fri, 12 Apr 2013 11:59:41 +0000 (11:59 +0000)]
turn on pathops unit test

This temporarily disables SK_ENABLE_INST_COUNT
( skbug.com/1219 )

This fixes a linktime error on VS2012 in
PathTest.cpp; -SK_ScalarInfinity should be
SK_ScalarNegativeInfinity instead.

This adds pathops and pathops unit tests to the
main unit tests.

Should this change destabilize anything, it should
be sufficient to comment out the pathops gypi
includes. at test.gyp:18,21.
Review URL: https://codereview.chromium.org/14137010

git-svn-id: http://skia.googlecode.com/svn/trunk@8644 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 12 Apr 2013 07:01:51 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agowhitespace commit to trigger buildbots after resetting skia-autogen
epoger@google.com [Fri, 12 Apr 2013 03:32:46 +0000 (03:32 +0000)]
whitespace commit to trigger buildbots after resetting skia-autogen

git-svn-id: http://skia.googlecode.com/svn/trunk@8640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorename SkBitmapChecksummer as SkBitmapHasher, and prepare for it to possibly use
epoger@google.com [Fri, 12 Apr 2013 02:23:55 +0000 (02:23 +0000)]
rename SkBitmapChecksummer as SkBitmapHasher, and prepare for it to possibly use
some algorithm other than CityHash
Review URL: https://codereview.chromium.org/14170010

git-svn-id: http://skia.googlecode.com/svn/trunk@8639 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: print list of GMs run, even in non-verbose mode (rolls back part of r8600)
epoger@google.com [Fri, 12 Apr 2013 02:11:54 +0000 (02:11 +0000)]
GM: print list of GMs run, even in non-verbose mode (rolls back part of r8600)
Review URL: https://codereview.chromium.org/14052003

git-svn-id: http://skia.googlecode.com/svn/trunk@8638 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate debug GL backend to match r8633
robertphillips@google.com [Thu, 11 Apr 2013 23:25:36 +0000 (23:25 +0000)]
Update debug GL backend to match r8633

git-svn-id: http://skia.googlecode.com/svn/trunk@8637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix the NaCl build.
scroggo@google.com [Thu, 11 Apr 2013 22:24:35 +0000 (22:24 +0000)]
Fix the NaCl build.

Do not attempt to build our gif files or link gif in Nacl.

Review URL: https://codereview.chromium.org/14201002

git-svn-id: http://skia.googlecode.com/svn/trunk@8635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd glCopyTexSubImage2D to GrGLInterface
commit-bot@chromium.org [Thu, 11 Apr 2013 22:00:34 +0000 (22:00 +0000)]
Add glCopyTexSubImage2D to GrGLInterface

Author: bsalomon@google.com

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13941006

git-svn-id: http://skia.googlecode.com/svn/trunk@8634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse blitframebuffer to implement copySurface.
commit-bot@chromium.org [Thu, 11 Apr 2013 22:00:22 +0000 (22:00 +0000)]
Use blitframebuffer to implement copySurface.

Author: bsalomon@google.com

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13910009

git-svn-id: http://skia.googlecode.com/svn/trunk@8633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBetter fix for the patched build.
scroggo@google.com [Thu, 11 Apr 2013 20:11:40 +0000 (20:11 +0000)]
Better fix for the patched build.

skia_test is also built on Android in pathops_unittest, which needed
to also depend on the flags project.

Remove the hack in skia_test of providing the full path.

Review URL: https://codereview.chromium.org/14177002

git-svn-id: http://skia.googlecode.com/svn/trunk@8632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshort names should be ... short, in commandlineflags
reed@google.com [Thu, 11 Apr 2013 19:04:34 +0000 (19:04 +0000)]
short names should be ... short, in commandlineflags

git-svn-id: http://skia.googlecode.com/svn/trunk@8629 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger a rebuild.
scroggo@google.com [Thu, 11 Apr 2013 18:56:08 +0000 (18:56 +0000)]
Whitespace change to trigger a rebuild.

Review URL: https://codereview.chromium.org/13941005

git-svn-id: http://skia.googlecode.com/svn/trunk@8628 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoInclude gif image decoding in images/ on linux.
scroggo@google.com [Thu, 11 Apr 2013 18:32:01 +0000 (18:32 +0000)]
Include gif image decoding in images/ on linux.

Build SkImageDecoder_libgif in images project and link against
libgif on linux.

Ensure that the GIF decoder is used in skimage.

Requires a new dependency on libgif-dev when building on linux.

Review URL: https://codereview.chromium.org/14029011

git-svn-id: http://skia.googlecode.com/svn/trunk@8627 2bbb7eff-a529-9590-31e7-b0007b416f81