platform/upstream/freerdp.git
3 years agoUse settings string setter to overwrite computername
akallabeth [Tue, 1 Sep 2020 09:15:44 +0000 (11:15 +0200)]
Use settings string setter to overwrite computername

(cherry picked from commit 4d7cddd7c64c75d824d8a1eb0babcfc71f0df8d4)

3 years agoIgnore NULL streams in StreamPool_Return
Armin Novak [Wed, 2 Sep 2020 08:09:48 +0000 (10:09 +0200)]
Ignore NULL streams in StreamPool_Return

(cherry picked from commit 6351885488c38327b4f59f3686d68ddd8dc0f745)

3 years agoFixed #6442: Use cmake to provide source directory for test pem
akallabeth [Mon, 24 Aug 2020 07:44:41 +0000 (09:44 +0200)]
Fixed #6442: Use cmake to provide source directory for test pem

(cherry picked from commit 70881d39578177d3229f01011f62021b1b069cb5)

3 years agoFixed short length for usb io control return.
akallabeth [Thu, 13 Aug 2020 11:51:38 +0000 (13:51 +0200)]
Fixed short length for usb io control return.

(cherry picked from commit 6f00308db78f27d6daee9a85ff3baec7cd8e8443)

3 years agoManually free up libusb transfer data to avoid double free
Armin Novak [Wed, 12 Aug 2020 08:28:21 +0000 (10:28 +0200)]
Manually free up libusb transfer data to avoid double free

(cherry picked from commit 6ce051759306219c49d4fb39a2bd9cc94c2c5afc)

3 years agoFixed double free on channel close in channel write.
Armin Novak [Wed, 12 Aug 2020 08:10:18 +0000 (10:10 +0200)]
Fixed double free on channel close in channel write.

(cherry picked from commit 81d59b2d47f1a68f4db97e2e4636d93be69892cc)

3 years agoFixed missing async user data extraction from libusb transfer
akallabeth [Tue, 11 Aug 2020 12:12:36 +0000 (14:12 +0200)]
Fixed missing async user data extraction from libusb transfer

(cherry picked from commit 786f6bbfe8ac63eb2e069a7b83b0a49b2a9a664b)

3 years agoFixed urbdrc server notification of channel close
Armin Novak [Mon, 10 Aug 2020 11:30:41 +0000 (13:30 +0200)]
Fixed urbdrc server notification of channel close

There was a recursion issue with usb device channel closing and
local redirected device removal.
If the local redirected device is removed due to hotplug events,
the device channel needs to be closed, which in turn checks if
the local device list contains the device. Ensure that the
channel close code is only executed when not called from the
channel side.

(cherry picked from commit 93ee13245ce7fe78ffbc9694bfac3da30844296a)

3 years agoRemoved channel close in USB channel done after channel is freed
akallabeth [Fri, 10 Jul 2020 08:49:25 +0000 (10:49 +0200)]
Removed channel close in USB channel done after channel is freed

(cherry picked from commit dbeaa614d6e369d3809e04be24f1d6b98e3d9e50)

3 years agoFixed access to user_data after free
akallabeth [Thu, 9 Jul 2020 10:27:17 +0000 (12:27 +0200)]
Fixed access to user_data after free

(cherry picked from commit 8c859575cfb0fc9e35d7b211993174af444ff780)

3 years agoFixed invalid buffer length and duplicated write function.
akallabeth [Thu, 9 Jul 2020 10:20:48 +0000 (12:20 +0200)]
Fixed invalid buffer length and duplicated write function.

(cherry picked from commit 54c92e78e6031d1e075625699e2d677af583716a)

3 years agoFixed urbdrc arraylist locking
akallabeth [Thu, 9 Jul 2020 09:47:06 +0000 (11:47 +0200)]
Fixed urbdrc arraylist locking

(cherry picked from commit e7533130a6bf08959670264e797487b00305e9f7)

3 years agoUnified streamID read/write
Armin Novak [Wed, 8 Jul 2020 16:18:51 +0000 (18:18 +0200)]
Unified streamID read/write

(cherry picked from commit 28bc636d5377b01936e161af9e94438a7e592f1d)

3 years agoReplace wHashTable with wArrayList in USB channel
Armin Novak [Wed, 8 Jul 2020 16:11:05 +0000 (18:11 +0200)]
Replace wHashTable with wArrayList in USB channel

The streamID is not guaranteed to be uniqe, so add all transfers
to a list and remove by checking pointers instead of the streamID

(cherry picked from commit 3ebc71abf3709871ca1609b9c99b7d234000da4a)

3 years agoAdded return checks for HashTable_Add
Armin Novak [Wed, 8 Jul 2020 08:26:34 +0000 (10:26 +0200)]
Added return checks for HashTable_Add

(cherry picked from commit ea8f93441d523e103746dfeceab98420c05e0bac)

3 years agoAdded duplicate initialization check for plugins.
Armin Novak [Mon, 10 Aug 2020 13:36:31 +0000 (15:36 +0200)]
Added duplicate initialization check for plugins.

(cherry picked from commit 75aab487e242f347868bd6c2ad5872d25a7c2c9a)

3 years agoRefactored rdg_read_http_unicode_string warning fixes
Armin Novak [Mon, 10 Aug 2020 14:39:49 +0000 (16:39 +0200)]
Refactored rdg_read_http_unicode_string warning fixes

(cherry picked from commit bfa07e701d25fc936c84ad36d58c6ab1a9a33ec9)

3 years agoRefactored socket warning fixes to be more readable.
Armin Novak [Mon, 10 Aug 2020 14:39:19 +0000 (16:39 +0200)]
Refactored socket warning fixes to be more readable.

(cherry picked from commit 57de0aebb5ee1d3458f74f9a98b99245719aa2f4)

3 years agoFixed warnings.
Armin Novak [Mon, 10 Aug 2020 10:26:46 +0000 (12:26 +0200)]
Fixed warnings.

(cherry picked from commit e50a8e09ee3feba4975c488618f5af350d851ad9)

3 years agoFixed missing input length check for color pointer.
Armin Novak [Mon, 10 Aug 2020 10:26:33 +0000 (12:26 +0200)]
Fixed missing input length check for color pointer.

(cherry picked from commit 47d02a76ce07cbfc655754a1ccfe79a9b6bc9357)

3 years agoFixed compilation warnings.
Armin Novak [Mon, 10 Aug 2020 10:04:02 +0000 (12:04 +0200)]
Fixed compilation warnings.

(cherry picked from commit 57b405ca265966fd3790cb3f30d0b0c073268e7c)

3 years agoFixed #6418: Warning due to invalid const qualifier
Armin Novak [Mon, 10 Aug 2020 09:47:52 +0000 (11:47 +0200)]
Fixed #6418: Warning due to invalid const qualifier

(cherry picked from commit 226b072af82ab7000d26a2bf76ee585098b27875)

3 years agoImprove NLA auth token debugging
Armin Novak [Mon, 10 Aug 2020 14:56:27 +0000 (16:56 +0200)]
Improve NLA auth token debugging

(cherry picked from commit 10ed4ec42204aa4f56c5a4d82732ced6359f088c)

3 years agoAdded log message for not implemented WinPR SSPI_WINPR functions.
Armin Novak [Mon, 10 Aug 2020 12:59:07 +0000 (14:59 +0200)]
Added log message for not implemented WinPR SSPI_WINPR functions.

(cherry picked from commit a9d9908bdedb8f4f3fbf8956ac96eb06375798e2)

3 years agoAdded log message for not implemented WinPR SSPI functions.
Armin Novak [Mon, 10 Aug 2020 12:57:39 +0000 (14:57 +0200)]
Added log message for not implemented WinPR SSPI functions.

(cherry picked from commit 2686200c3b95d03d5d81be124159fed2be744797)

3 years agoAdded log message for not implemented WinPR SSPI GSS functions.
Armin Novak [Mon, 10 Aug 2020 12:57:27 +0000 (14:57 +0200)]
Added log message for not implemented WinPR SSPI GSS functions.

(cherry picked from commit ef791456e3281aee75ac736f66b7444c9e12ca7b)

3 years agoAdded log message for not implemented Schannel functions.
Armin Novak [Mon, 10 Aug 2020 12:48:51 +0000 (14:48 +0200)]
Added log message for not implemented Schannel functions.

(cherry picked from commit 65819a721577fd997e159b059a3c1fe4c153cdd2)

3 years agoAdded log message for not implemented CREDSSP functions.
Armin Novak [Mon, 10 Aug 2020 12:43:37 +0000 (14:43 +0200)]
Added log message for not implemented CREDSSP functions.

(cherry picked from commit 7837f517e5771a33b4bd00cdf948706ae3d8aa55)

3 years agoAdded log message for not implemented NEGOTIATE functions.
Armin Novak [Mon, 10 Aug 2020 12:42:05 +0000 (14:42 +0200)]
Added log message for not implemented NEGOTIATE functions.

(cherry picked from commit 7d0e54e5f8d8009f8c5655b45dccdf425b9ac8d6)

3 years agoAdded log message for not implemented NTLM functions.
Armin Novak [Mon, 10 Aug 2020 12:41:20 +0000 (14:41 +0200)]
Added log message for not implemented NTLM functions.

(cherry picked from commit 58f471c7d9fa1ffcb03198ac919a05e1f13aee03)

3 years agoImprove NLA error code logging.
Armin Novak [Mon, 10 Aug 2020 12:35:40 +0000 (14:35 +0200)]
Improve NLA error code logging.

(cherry picked from commit 32c9a519dfec5ee7c7bf815298c9650e5a7aabff)

4 years agoMerge pull request #6405 from akallabeth/an-stable-2.0
Martin Fleisz [Wed, 5 Aug 2020 10:21:48 +0000 (12:21 +0200)]
Merge pull request #6405 from akallabeth/an-stable-2.0

stable 2.0 backports

4 years agoUse freerdp_settings_[s|g]et* api to access proxy vaiables.
akallabeth [Tue, 4 Aug 2020 06:49:46 +0000 (08:49 +0200)]
Use freerdp_settings_[s|g]et* api to access proxy vaiables.

Fixes #6414

(cherry picked from commit 44ea09e7ad0123b8486428c1ceaeeb96b5c01d35)

4 years agoAdd GatewayMessageType to public API
Martin Fleisz [Tue, 4 Aug 2020 07:11:41 +0000 (09:11 +0200)]
Add GatewayMessageType to public API

(cherry picked from commit 174f3257c9213e77663020d0b8a41220889848fd)

4 years agoImplement gateway message callback for Windows, Wayland and X11 clients
Martin Fleisz [Mon, 3 Aug 2020 10:06:08 +0000 (12:06 +0200)]
Implement gateway message callback for Windows, Wayland and X11 clients

(cherry picked from commit 2fe8e762d2b6765b486513159d18ffd98e267873)

4 years agogateway: Add processing of consent and service messages with HTTP gateway
Martin Fleisz [Thu, 30 Jul 2020 13:22:40 +0000 (15:22 +0200)]
gateway: Add processing of consent and service messages with HTTP gateway

(cherry picked from commit 130494e34a26d0b7065a2daddb56dd7b63241647)

4 years agoclang-format
Gluzskiy Alexandr [Mon, 27 Jul 2020 07:34:40 +0000 (10:34 +0300)]
clang-format

(cherry picked from commit 481f3b32f6f0fd7fdc304e192f5661e2fa2e4aa9)

4 years agofixed build on freebsd
Gluzskiy Alexandr [Mon, 27 Jul 2020 06:01:35 +0000 (09:01 +0300)]
fixed build on freebsd

(cherry picked from commit 3bb5d57b70896dd677c8971c4c15dfade529ccd6)

4 years agoAdd support for getmntent support on Illumos
Marco van Wieringen [Thu, 23 Jul 2020 11:22:34 +0000 (13:22 +0200)]
Add support for getmntent support on Illumos

This implements reading mount entries on Solarish operating systems like
OpenIndiana etc using the somewhat different getmntent support available
there.

(cherry picked from commit 56260c0cdb24fb7e10e97a70160737c0652090fd)

4 years agoFix #6399: Call ConvertFromUnicode with length -1.
akallabeth [Thu, 30 Jul 2020 14:16:01 +0000 (16:16 +0200)]
Fix #6399: Call ConvertFromUnicode with length -1.

The input string has ensured NULL termination, so let the function
determine the correct length.

(cherry picked from commit 36499527e747283019c21dbc84c5eff0a564e1d8)

4 years agocliprdr_common.c: fix memory leak in certain error condition
Zhu Qun-Ying [Fri, 24 Jul 2020 16:16:18 +0000 (09:16 -0700)]
cliprdr_common.c: fix memory leak in certain error condition

(cherry picked from commit 2b315e8bfa50cbf8adaf64a82307cc7d0dded395)

4 years agoSet BIO data NULL on cleanup
Armin Novak [Thu, 23 Jul 2020 08:48:39 +0000 (10:48 +0200)]
Set BIO data NULL on cleanup

Recursive BIO free could double free, if the BIO data is not set
NULL when removed.

(cherry picked from commit 76d10561bbf24b82df43771e93a1692790c3dbbc)

4 years agoMerge pull request #6382 from bmiklautz/release_220 2.2.0
Martin Fleisz [Mon, 20 Jul 2020 13:38:46 +0000 (15:38 +0200)]
Merge pull request #6382 from bmiklautz/release_220

FreeRDP security and version 2.2.0 release

4 years agonew: Changelog for 2.2.0
Bernhard Miklautz [Mon, 20 Jul 2020 12:21:59 +0000 (14:21 +0200)]
new: Changelog for 2.2.0

4 years agocore: fix invalid inttype and reference
Norbert Federa [Mon, 20 Jul 2020 11:18:45 +0000 (13:18 +0200)]
core: fix invalid inttype and reference

The error message in tpdu_read_header() printed the pointer address and
used PRIu16 for an UINT8 type

(cherry picked from commit 54fdf7947d4d35589dab9ec3e37839606ffcc985)

Fixes #6380

4 years agoFixed missing input sanitation for GFX surfaces.
akallabeth [Fri, 3 Jul 2020 08:29:13 +0000 (10:29 +0200)]
Fixed missing input sanitation for GFX surfaces.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit 5592cb2e10da42592af98f5533d2e42181e86821)

4 years agoFixed input sanitation in rdpgfx_recv_solid_fill_pdu
akallabeth [Fri, 3 Jul 2020 08:26:38 +0000 (10:26 +0200)]
Fixed input sanitation in rdpgfx_recv_solid_fill_pdu

The input rectangle must be checked for plausibility.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit d862a03cbf88ec6e76e47b84eae7e214690cb607)

4 years agoFix seeking in Cache Brush and other Secondary Drawing Orders
Giovanni Panozzo [Tue, 14 Jul 2020 22:08:15 +0000 (00:08 +0200)]
Fix seeking in Cache Brush and other Secondary Drawing Orders

(cherry picked from commit 9f7e475c1652c2b1e30e0406ec0bc7ea3f2330ff)

Fixes #6374

4 years agoMerge pull request #6319 from akallabeth/stable-2.0-backports3
Bernhard Miklautz [Wed, 15 Jul 2020 14:42:24 +0000 (16:42 +0200)]
Merge pull request #6319 from akallabeth/stable-2.0-backports3

Stable 2 backports from master

4 years agoserver: proxy: add extern C for c++ plugins
Kobi Mizrachi [Wed, 8 Jul 2020 08:53:26 +0000 (11:53 +0300)]
server: proxy: add extern C for c++ plugins

(cherry picked from commit 755d20501bac9c935a88d0ba040a4410681c1aa7)

4 years agoserver: proxy: rail: Fix rail handshake flags sync issue at reconnect
Kobi Mizrachi [Tue, 7 Jul 2020 12:31:31 +0000 (15:31 +0300)]
server: proxy: rail: Fix rail handshake flags sync issue at reconnect

(cherry picked from commit cc9ef8f74e59f9351aca84a2a95048a4af274af6)

4 years agorail: server: add API to set railHandshakeExflags
Kobi Mizrachi [Tue, 7 Jul 2020 12:31:20 +0000 (15:31 +0300)]
rail: server: add API to set railHandshakeExflags

(cherry picked from commit 004c2f49e4068270cbd5cfb9f44c015c6fb931ea)

4 years agoserver: proxy: fix race issue
Kobi Mizrachi [Sun, 5 Jul 2020 06:11:56 +0000 (09:11 +0300)]
server: proxy: fix race issue

Proxy server might receive input updates while client side being
redirected (and reset), then a heap-after-free might occur. To solve
this, we register server input/update callbacks only after client is
fully activated.

(cherry picked from commit db0196fd01faa4234a4b2cabadb5f4cb16edeef1)

4 years agoUpdated version information for 2.2.0 release
akallabeth [Tue, 7 Jul 2020 08:56:21 +0000 (10:56 +0200)]
Updated version information for 2.2.0 release

4 years agoFixed urbdrc device path
Armin Novak [Mon, 6 Jul 2020 09:09:14 +0000 (11:09 +0200)]
Fixed urbdrc device path

(cherry picked from commit 63747000982f70bc169ff037bccb1bbcfd697747)

4 years agoFixed bDeviceClass check in udev_init
Armin Novak [Mon, 6 Jul 2020 07:59:15 +0000 (09:59 +0200)]
Fixed bDeviceClass check in udev_init

Use the proper constant  0xef (Miscellaneous) instead of
0xfe (Application Specific)
See https://www.usb.org/defined-class-codes

(cherry picked from commit b97cb4c95dd085142cadf1645505264632d1af21)

4 years agoReplaced malloc in urbdrc channel
akallabeth [Fri, 3 Jul 2020 14:20:12 +0000 (16:20 +0200)]
Replaced malloc in urbdrc channel

(cherry picked from commit 3ae6feeebe8638c3bea76fd270f3fd46ee768ff2)

4 years agoFixed discrepancy in string descriptor default
akallabeth [Fri, 3 Jul 2020 14:04:23 +0000 (16:04 +0200)]
Fixed discrepancy in string descriptor default

(cherry picked from commit 747513d901ae50c8223a5ddd5b447436bb782a66)

4 years agoReplaced memset in urbdrc
akallabeth [Fri, 3 Jul 2020 13:47:53 +0000 (15:47 +0200)]
Replaced memset in urbdrc

(cherry picked from commit e84c3829bf942b28cd6ef4d7cff4d5f8cca8a5f8)

4 years agoUnified logging for urbdrc libusb wrapper
akallabeth [Fri, 3 Jul 2020 13:14:15 +0000 (15:14 +0200)]
Unified logging for urbdrc libusb wrapper

(cherry picked from commit a81001c3a33818561bf0e6193e219b1b3245391d)

4 years agoInitialize variable in func_instance_id_generate
akallabeth [Fri, 3 Jul 2020 12:59:03 +0000 (14:59 +0200)]
Initialize variable in func_instance_id_generate

(cherry picked from commit a4a4992750085367e52623209c94ed3f1c66b25b)

4 years agoImproved error log for string descriptor read issues
akallabeth [Fri, 3 Jul 2020 12:48:07 +0000 (14:48 +0200)]
Improved error log for string descriptor read issues

(cherry picked from commit dd2589cebcac5b39c6af9bbe9f444f6451e9ad4b)

4 years agoReverted check for short usb descriptor
akallabeth [Fri, 3 Jul 2020 11:33:08 +0000 (13:33 +0200)]
Reverted check for short usb descriptor

(cherry picked from commit 6ba67a07beeb44878912851cf6ed6c6bf7443e09)

4 years agoAdded compile time urbdrc debug option
akallabeth [Fri, 3 Jul 2020 10:50:11 +0000 (12:50 +0200)]
Added compile time urbdrc debug option

(cherry picked from commit 5244efadcfb158c813d79b8e8c068fc33198f79b)

4 years agoDump USB channel data with log-level trace
akallabeth [Fri, 3 Jul 2020 10:41:59 +0000 (12:41 +0200)]
Dump USB channel data with log-level trace

(cherry picked from commit e32ba76deb8e16834a5bb0d099cc08d1ed44c04d)

4 years agoserver: proxy: proxy rdp heartbeats
Kobi Mizrachi [Tue, 7 Jul 2020 07:16:46 +0000 (10:16 +0300)]
server: proxy: proxy rdp heartbeats

(cherry picked from commit 659e4c772bbc7e3807dc94628934e8982f8efcf7)

4 years agolibfreerdp: core: add ServerHeartbeat callback
Kobi Mizrachi [Tue, 7 Jul 2020 07:16:28 +0000 (10:16 +0300)]
libfreerdp: core: add ServerHeartbeat callback

(cherry picked from commit 2096ede5cc8caa209c532438e3a1173f6b47e2c4)

4 years agoMoved pthread non portable function checks before ASAN
Armin Novak [Mon, 6 Jul 2020 13:37:37 +0000 (15:37 +0200)]
Moved pthread non portable function checks before ASAN

(cherry picked from commit 4d529f6f952c3632e13ba43261c263e5b83eca68)

4 years agoRefined asan checks
Armin Novak [Mon, 6 Jul 2020 11:51:08 +0000 (13:51 +0200)]
Refined asan checks

Find threads before ASAN checks as for android builds the check
might fail if done afterward.

(cherry picked from commit 44f2e869820c9a33e8875982d20e9bb561736ce1)

4 years agoRemoved unnecessary checks for asan
akallabeth [Fri, 3 Jul 2020 09:06:30 +0000 (11:06 +0200)]
Removed unnecessary checks for asan

check_c_compiler_flag is unreliable, only use where absolutely
necessary.

(cherry picked from commit 7864a985d48f0fba4d431b196464f2075ebacd4b)

4 years agorail: server: rename rail_send_pdu -> rail_server_send_pdu
Kobi Mizrachi [Mon, 6 Jul 2020 07:32:59 +0000 (10:32 +0300)]
rail: server: rename rail_send_pdu -> rail_server_send_pdu

(cherry picked from commit ec06a98e84690a9cf64d080145b71ca9a2e084fa)

4 years agorail_common.c: Fix rail_get_order_type_string
Kobi Mizrachi [Mon, 6 Jul 2020 05:37:14 +0000 (08:37 +0300)]
rail_common.c: Fix rail_get_order_type_string

(cherry picked from commit 5438b94c979728feeccd13374c77c4881eda8137)

4 years agorail: server: mark rail_send_pdu as static function
Kobi Mizrachi [Mon, 6 Jul 2020 05:27:13 +0000 (08:27 +0300)]
rail: server: mark rail_send_pdu as static function

(cherry picked from commit c3b28e8bced83dd992854e18b8f82eef7af9e54d)

4 years agoFixed #6335: windows client title length
Armin Novak [Mon, 6 Jul 2020 07:16:55 +0000 (09:16 +0200)]
Fixed #6335: windows client title length

(cherry picked from commit dfbeeb1e16d61734319dd32d25ee12e8715a1bc1)

4 years agoAdded hint for errors due to missing offscreen-cache
akallabeth [Mon, 29 Jun 2020 06:04:15 +0000 (08:04 +0200)]
Added hint for errors due to missing offscreen-cache

(cherry picked from commit 57e7a99393fd3db79cd2a78e6a447aaf2540c521)

4 years agoUse CMake to detect availability of getlogin_r
akallabeth [Fri, 26 Jun 2020 08:57:05 +0000 (10:57 +0200)]
Use CMake to detect availability of getlogin_r

(cherry picked from commit 3a5bfd2bd0eee134dbac4a98dcb3ed5227a8c6dc)

4 years agoFixed uninitialized value
Armin Novak [Tue, 23 Jun 2020 09:53:45 +0000 (11:53 +0200)]
Fixed uninitialized value

(cherry picked from commit dc112d19355491f1b5e23631c15c5d960746bfac)

4 years agoFilter GSM codec for microphone redirection
akallabeth [Mon, 29 Jun 2020 11:26:15 +0000 (13:26 +0200)]
Filter GSM codec for microphone redirection

(cherry picked from commit c5984ff811f40b0382a251e76fc5f3690339f80a)

4 years agonsc: Fix memory leak
Pascal Nowack [Fri, 26 Jun 2020 14:33:19 +0000 (16:33 +0200)]
nsc: Fix memory leak

Fixes the following memory leak:

==115716== 16,662,960 bytes in 459 blocks are definitely lost in loss record 3,504 of 3,504
==115716==    at 0x48396AF: malloc (vg_replace_malloc.c:306)
==115716==    by 0x4C6A4E2: nsc_context_initialize_encode (nsc_encode.c:77)
==115716==    by 0x4C6A4E2: nsc_compose_message (nsc_encode.c:497)

(cherry picked from commit 9bd457405095c94a24175bc54bd99947fcf6a33d)

4 years agoFixed creating release zip from folder
Armin Novak [Mon, 22 Jun 2020 10:57:26 +0000 (12:57 +0200)]
Fixed creating release zip from folder

(cherry picked from commit 16350dcdda73767c7012a2c8f09405944b39d09a)

4 years agoFixed #6298: Mask CACHED_BRUSH when checking brush style
Armin Novak [Tue, 23 Jun 2020 07:24:35 +0000 (09:24 +0200)]
Fixed #6298: Mask CACHED_BRUSH when checking brush style

(cherry picked from commit ce1a9d8d1969ecbb4d24b9f4812654638a44abc2)

4 years agoFixed spelling, print errors to stderr
Armin Novak [Tue, 23 Jun 2020 07:32:19 +0000 (09:32 +0200)]
Fixed spelling, print errors to stderr

(cherry picked from commit b50525d1fb47aa6b07450c10f8ad7b5245e523fa)

4 years agoFixed bug with creating release source_version
Armin Novak [Tue, 23 Jun 2020 07:30:08 +0000 (09:30 +0200)]
Fixed bug with creating release source_version

(cherry picked from commit 5490ce50992716d9230bd3ac84b3e819f1c5649f)

4 years agoMerge pull request #6285 from akallabeth/stable-backports2 2.1.2
Martin Fleisz [Mon, 22 Jun 2020 10:44:36 +0000 (12:44 +0200)]
Merge pull request #6285 from akallabeth/stable-backports2

Stable backports

4 years agoUpdated versions to 2.1.2
Armin Novak [Mon, 22 Jun 2020 10:26:08 +0000 (12:26 +0200)]
Updated versions to 2.1.2

4 years agoAdded changelog for 2.1.2
Armin Novak [Mon, 22 Jun 2020 09:58:07 +0000 (11:58 +0200)]
Added changelog for 2.1.2

(cherry picked from commit 5dc50f64183755862cca75cf151933c42fabbb90)

4 years agoFixed possible integer overflow in crypto_rsa_common
akallabeth [Mon, 15 Jun 2020 06:57:21 +0000 (08:57 +0200)]
Fixed possible integer overflow in crypto_rsa_common

Thanks @anticomputer for pointing this out

(cherry picked from commit 02c5ec66e5b47fe4cf2fc96e2cd387a18e3f2bb6)

4 years agoFixed fallback to getlogin for android
akallabeth [Tue, 2 Jun 2020 12:41:37 +0000 (14:41 +0200)]
Fixed fallback to getlogin for android

(cherry picked from commit caff01877d4df5f25a983b3aa5e57dde6a16a62f)

4 years agoRemoved duplicate semicolon
akallabeth [Tue, 2 Jun 2020 11:19:26 +0000 (13:19 +0200)]
Removed duplicate semicolon

(cherry picked from commit 308c2c3544763873a5bea4d18c72c9f62e1584cb)

4 years agoFixed OOB read in ntlm_av_pair_get
akallabeth [Tue, 2 Jun 2020 10:26:40 +0000 (12:26 +0200)]
Fixed OOB read in ntlm_av_pair_get

CVE-2020-11097 thanks to @antonio-morales for finding this.

(cherry picked from commit 58a3122250d54de3a944c487776bcd4d1da4721e)

4 years agoFixed broken const variable.
akallabeth [Tue, 2 Jun 2020 09:33:48 +0000 (11:33 +0200)]
Fixed broken const variable.

(cherry picked from commit 1c6a6923f87dcfb295c508963f21bebbbc4292ae)

4 years agoReset freed HGDI_DC
akallabeth [Tue, 2 Jun 2020 07:28:47 +0000 (09:28 +0200)]
Reset freed HGDI_DC

CVE-2020-4031 thanks to @antonio-morales for finding this.

(cherry picked from commit f753c25ad3d5dae7890fe73cfb3c091c015d97ed)

4 years agoFixed out of bound read in RLEDECOMPRESS
akallabeth [Tue, 2 Jun 2020 06:45:09 +0000 (08:45 +0200)]
Fixed out of bound read in RLEDECOMPRESS

CVE-2020-4033 thanks to @antonio-morales for finding this.

(cherry picked from commit 0a98c450c58ec150e44781c89aa6f8e7e0f571f5)

4 years agoFixed OOB read in update_recv_secondary_order
akallabeth [Wed, 27 May 2020 06:10:11 +0000 (08:10 +0200)]
Fixed OOB read in update_recv_secondary_order

CVE-2020-4032 thanks to @antonio-morales for finding this.

(cherry picked from commit e7bffa64ef5ed70bac94f823e2b95262642f5296)

4 years agoFixed TrioParse and trio_length limts.
akallabeth [Tue, 26 May 2020 14:12:58 +0000 (16:12 +0200)]
Fixed TrioParse and trio_length limts.

CVE-2020-4030 thanks to @antonio-morales for finding this.

(cherry picked from commit 05cd9ea2290d23931f615c1b004d4b2e69074e27)

4 years agoFixed OOB read in update_read_cache_bitmap_v3_order
akallabeth [Tue, 26 May 2020 05:50:55 +0000 (07:50 +0200)]
Fixed OOB read in update_read_cache_bitmap_v3_order

CVE-2020-11096 thanks @antonio-morales for finding this.

(cherry picked from commit b8beb55913471952f92770c90c372139d78c16c0)

4 years agoFixed invalid access in update_recv_primary_order
akallabeth [Tue, 26 May 2020 05:28:33 +0000 (07:28 +0200)]
Fixed invalid access in update_recv_primary_order

CVE-2020-11095 thanks @antonio-morales for finding this.

(cherry picked from commit 733ee3208306b1ea32697b356c0215180fc3f049)

4 years agoUse localtime_s on windows
akallabeth [Mon, 25 May 2020 12:20:23 +0000 (14:20 +0200)]
Use localtime_s on windows

(cherry picked from commit c3a1ed780cc4aed639e3391d7cafb9edc9dc623c)

4 years agoReplaced gmtime with gmtime_r
akallabeth [Mon, 25 May 2020 12:07:31 +0000 (14:07 +0200)]
Replaced gmtime with gmtime_r

(cherry picked from commit a45afe9db77a19e5a177fe1dc3e85119013f9587)

4 years agoFixed codition with side effects
akallabeth [Mon, 25 May 2020 12:04:17 +0000 (14:04 +0200)]
Fixed codition with side effects

(cherry picked from commit 1a02af5a12b400fcb6ad121a0a71e4440c2e9152)