Minji Park [Wed, 8 Jul 2015 07:59:27 +0000 (16:59 +0900)]
Add comments on bundle API headers for doxygen
Change-Id: I1bc859e37631a28fac7ce92d87b38c730c8457e6
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1579
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Wed, 8 Jul 2015 06:56:37 +0000 (15:56 +0900)]
Resource container build check for external libraries
There is now a check for libcurl and the Java environment.
If the external libraries are not available, instructions how to
install are provided.
Change-Id: Iee24b49f86ca64887cc84687d78998917177ce0a
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1576
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Wed, 8 Jul 2015 05:09:59 +0000 (14:09 +0900)]
Modify exception class and include guards of broker.
add exception for subscribe presence.
fix bug about Initialize of DevicePresence.
Change-Id: I4588e213e7b8a56e06a280225d00ce4583909a37
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1572
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
ChaJiwon [Wed, 8 Jul 2015 06:25:28 +0000 (15:25 +0900)]
Change thread model to std::thread
Use condition variable to check expired time.
Add lock_guard to insert & cancel timerCBList.
Change Singleton instance pointer from shared pointer to pointer.
Change-Id: I0fc13809777691396140910eac6648b0ea5cfe57
Signed-off-by: ChaJiwon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1570
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Minji Park [Wed, 8 Jul 2015 05:58:37 +0000 (14:58 +0900)]
update Resource Container
- update listBundleResources api
- modify unregisterResource in the container and sample bundles
- rearrange the order of methods in resourcecontainerImpl source code
Change-Id: Id7e0d401b96bafd6c781950258c10789cba40319
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1573
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Wed, 8 Jul 2015 06:03:28 +0000 (15:03 +0900)]
Modify resourceCacheManager
add function that erases the cache subscriber on the cache subscriber list when cancelResourceCache() is called
modify "InvalidParameter" name to "InvalidParmeterExecption"
Change-Id: Ide08a397036bbe1daf2922e1cff9f59a968dbe8c
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1574
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Tue, 7 Jul 2015 11:04:39 +0000 (20:04 +0900)]
Bundle deactivation
Implemented bundle deactivation which includes the removal of registered resources.
Modified ContainerTest to load, start and stop different bundles and test the
bundle activation/deactviation.
Change-Id: I5149851278aa457bee5f86c039f8f3a8320b8652
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1568
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Wed, 8 Jul 2015 04:00:50 +0000 (13:00 +0900)]
Add type class for ResourceAttriutes
The class helps distinguish types between Values
Change-Id: I7a02c290bb6b1f3fb7d26ef7cb1087268afa36ac
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1569
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Rami Jung [Tue, 7 Jul 2015 13:53:26 +0000 (22:53 +0900)]
adding functions in Server Builder
setAttributeUpdatedHandler
removeAddAttributeUpdatedHandler
Change-Id: I13bb7578b6bd92823c96d56866ae456030bacb3a
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1562
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Tue, 7 Jul 2015 10:49:30 +0000 (19:49 +0900)]
Arrange Cache module code and logic.
add namespace OIC::Service.
change parameter and return type of interfaces.
add exception handle in interfaces.
arrange duplicated code and logic.
add updateResourceCache().
Change-Id: I71302bc7cc0351626dd67790e2b4bf787c5b881e
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1558
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Minji Park [Tue, 7 Jul 2015 05:41:35 +0000 (14:41 +0900)]
resource container unit tests, updates for container
- unit tests for resource container
- update SConscript
- update bundleinfo and configuration in container
Change-Id: I0c92b15cb1229e5f16a7a7db18aab3cc32778bcc
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1555
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Tue, 7 Jul 2015 09:58:33 +0000 (18:58 +0900)]
Using build() as name to create a new instance of BundleInfo
Change-Id: Ib3408ff18a3fe872feffad4acc214feaa2a4926a
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1556
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Tue, 7 Jul 2015 11:00:40 +0000 (20:00 +0900)]
Fix build fail of broker module.
fix syntax error.
add expiryTimer's script in common sconscript.
Change-Id: I396c2249cc68568e81885f1e05a40cccf7f68662
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1560
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Tue, 7 Jul 2015 02:21:47 +0000 (11:21 +0900)]
Fix wrong unittests in RequestHandlerTest
The tests regarding AcceptanceMethod
Change-Id: Iaa18464b9059887c4ab229e8a5f2ca44bdad221f
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1549
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Sat, 4 Jul 2015 07:51:07 +0000 (16:51 +0900)]
Replace setAttribute with non-template methods.
To extract a common interface that manipulates attributes.
And add invokeOCFunc that takes multiple OCStackResult values considered as success.
Change-Id: I39fa49525e95739b7fdbbc06384782453e156f65
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1548
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Mon, 6 Jul 2015 05:59:05 +0000 (14:59 +0900)]
Modify header file name in the Resource Cache codes
rename PrimitiveTimer to ExpiryTimer
Change-Id: Ie1dda93d0857537b4b704b38a2c2bf51d7a3196c
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1528
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
doil.kwon [Fri, 3 Jul 2015 08:21:23 +0000 (17:21 +0900)]
Applied to "expiryTimer" for "ResourceBroker"
- Header's name is changed(primitiveTimer->expiryTimer)
- Added contents about expiryTimer in SConscript
- Modified variable's name about ExpiryTimer class
- Changed "relative path" to "absolute path" about included path
Change-Id: I4f5b3c125a7450f332d333f761c4010048ff7838
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1505
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Mon, 6 Jul 2015 06:46:53 +0000 (15:46 +0900)]
Using relative links in configuration files. Implemented listBundles to retrieve the current bundles available in the resource container.
Change-Id: Ia5d2f2b7e16cb2eb5f37bd866f33d437c03eb033
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1530
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Mon, 6 Jul 2015 06:01:47 +0000 (15:01 +0900)]
Applied IoTivity code style template on all Java source files
Change-Id: I8a72cc1d99e8705add20124f506013cb900110f2
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1529
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Minji Park [Mon, 6 Jul 2015 07:15:31 +0000 (16:15 +0900)]
Change the name of soft sensor sample bundle
change files and folder name of soft sensor sample bundle
Change-Id: I615a127d7f538b93895700a3cc3ad9a396fb5816
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1531
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Sat, 4 Jul 2015 03:48:25 +0000 (12:48 +0900)]
Refactor PrimitiveResponse and RequestHandler
Now PrimitiveSetResponse has AcceptanceMethod that indicates how to handle ResourceAttributes from request.
Belows are AcceptanceMehtod of PrimitiveSetResponse
Default : Follow handling policy of ResourceObject which will be implemented soon.
Ignore : Always ignore request attributes.
Accept : Always accept request attribuets, even if there is unknown value or different type with ResourceObject's attribute.
Change-Id: Ie67b9f8eeb6c56deace57a16e1535b9926fe3a5c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Sat, 4 Jul 2015 02:33:16 +0000 (11:33 +0900)]
Add missing methods to ResourceAttributes
operator!=(Not equal) methods for ResourceAttributes and ResourceAttributes::Value.
swap method for ResourceAttributes::Value
Change-Id: I83d259e4034cf5b2926c10ac969ab85fd081dde8
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1514
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Mon, 6 Jul 2015 03:27:20 +0000 (12:27 +0900)]
Resource container update, API seperation (container, bundle)
Update on resource container. Bundle templates for c++ or Java-based protocol
bridge bundles. Common XML-based configuration.
Separated APIs and project skeletons for container and bundle templates.
Change-Id: Iacf3cc7bc860cfa42c2a50ed901ac7b786741a52
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1512
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Uze Choi [Mon, 6 Jul 2015 02:42:54 +0000 (02:42 +0000)]
Merge "Merge branch 'master' into resource-manipulation" into resource-manipulation
Jay Sharma [Sat, 4 Jul 2015 14:51:34 +0000 (20:21 +0530)]
Updated Resource Client
- Updated as per new APIs.
Change-Id: I7c3118cdd6690911a26ad4aaddb67a6d10afec9f
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1524
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Sat, 4 Jul 2015 02:46:49 +0000 (11:46 +0900)]
Fix setting callback to use move operation in PrsenceSubscriber
It was copying callback which is unneccesary overhead.
Change-Id: Ic867a1e68225a95b2537737c9290ec0d3fe6354c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1516
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Sat, 4 Jul 2015 02:35:48 +0000 (11:35 +0900)]
Fix setting callback to use move operation in PrimitiveResource
It was copying callback which is unneccesary overhead.
Change-Id: Iee927bb1192de7d8b8af71922f948e0428073ca2
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1515
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
hunje.yeon [Mon, 6 Jul 2015 01:23:08 +0000 (10:23 +0900)]
Merge branch 'master' into resource-manipulation
Apply stack error fix from 'master' branch into 'resource-manipulation' branch
Change-Id: I768f2c4404985e2dd50855a665b6819fa6d97f43
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Ankur Bansal [Thu, 2 Jul 2015 13:09:17 +0000 (18:39 +0530)]
Fix memory leak in SSM Sensor Processor
Fix memory leak in CResourceFinder::onExecute. Delete resource handler
in case of Error.
Change-Id: I3d2363ed0b2585ffcbc403417fd73f60e89f1a88
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1490
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Mon, 29 Jun 2015 21:29:47 +0000 (23:29 +0200)]
protocol-plugin: sample-app: add missing lib to mqttclient
The mqttclient file does not link successfully on OpenWrt with boost
1.58.0. Without this patch I am getting this error message:
out/linux/arm/release/service/protocol-plugin/sample-app/linux/mqtt/mqttclient.o: In function `_GLOBAL__sub_I_mqttclient.cpp':
mqttclient.cpp:(.text.startup+0x7a0): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7a8): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7b0): undefined reference to `boost::system::system_category()'
out/linux/arm/release/libppm.a(PluginManager.o): In function `_GLOBAL__sub_I_PluginManager.cpp':
PluginManager.cpp:(.text.startup+0x8): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x1c): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x28): undefined reference to `boost::system::system_category()'
Change-Id: Ib5728b37609de6b9b426888c77eb3522eb5e0b7d
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1446
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 13:44:42 +0000 (19:14 +0530)]
stack: Fixes cppcheck issue in ocserverrequest
This patch fixes the the below issue reported by
cppcheck tool in stack dir:
"(error) Possible null pointer dereference:
ehResponse - otherwise it is redundant to check if
ehResponse is null at line 445
"
Dereferencing of ehResponse is done after NULL check.
Change-Id: I9cc20ce2386b5bdb08c4d9f9dbd2d143040f9a0f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1509
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 13:36:20 +0000 (19:06 +0530)]
csdk: Fixes issue reported by cppcheck tool
This patch fixes the the below issue reported by cppcheck tool:
"(error) Possible null pointer dereference: ReqInfo - otherwise it is
redundant to check if ReqInfo is null at line 234".
Null value check of ReqInfo is removed as it in unnecessary here, as this check is
already done and OIC_LOG_BUFFER is just printing the content of ReqInfo->info.token.
Change-Id: I8c15d8b582135c445fe89350dc67812e531c52d3
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Fri, 3 Jul 2015 05:22:36 +0000 (10:52 +0530)]
Integrated singlethread and multithread files of BLE adapter.
Removed all "_singlethread" files related to BLE adapter.
Change-Id: Idad8e8a488d7b2d742f7082116f9bd4895175d8f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hunje.yeon [Fri, 3 Jul 2015 07:21:44 +0000 (16:21 +0900)]
Merge branch 'master' into resource-manipulation
Update the lastest changes of 'master' into 'resource-manipulation' branch
Change-Id: I1ddc4f152f0408646c687fbc0ed9fdac0bd83291
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
coderhyme [Thu, 2 Jul 2015 10:54:27 +0000 (19:54 +0900)]
Change names of include-guards of primitiveResource headers
Add prefixes to include-guards to lower possibility of conflicts with others.
Fix a file name 'ResourceAttributesConverter.h', there was a typo.
Change-Id: I76345b4c444ed242e8b3d307a550ba1f0c043b69
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1501
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 2 Jul 2015 10:53:49 +0000 (19:53 +0900)]
Separate implementation of PrimitiveRequest
The class will be exposed as a part of the api.
Change-Id: I18b641ab5cf2dcb070db5bd302ffedb331f887f0
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1500
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 2 Jul 2015 10:48:57 +0000 (19:48 +0900)]
Change the class name of PrimitveServerResource to ResourceObject
Terminology of the Primitive is not specific.
Change-Id: I473310416076eb6929e00a1d4c47b05f7ae858fb
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1499
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
doil.kwon [Thu, 2 Jul 2015 09:05:26 +0000 (18:05 +0900)]
Distributed Resource Hosting Sample App and ResourceHosting for JAVA API folder.
- Added new folder in NotificationManager folder
- "/NotificationManger/android/resource_hosting"
Modified notification-manager's Sconscript
- ~_JNI.cpp file is not included in Sconscript.
Changed folder name : ResourceHostingSampleApp->SampleResourceHosting
Deleted files : resourceCoordinator_JNI.cpp and resourceCoordinator_JNI.h in Notification/src folder.
Modified about ResourceHosing_JNI.h path is relative path to absolute path in ResourceHosing_JNI.cpp
Added "OCProcessFunc"'s return value : none -> return;
Change-Id: I2c44c31f1399ca9722c4f2281ec2b8af1646ed21
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
ChaJiWon [Fri, 3 Jul 2015 06:32:06 +0000 (15:32 +0900)]
Add common module that expiryTimer.
check expiryTime & excute callback
destructor change to public type in ExpiryTimer.h
exclude the internal header code
Change-Id: Ic773fddaaf8332950a53eeb99e8a50a42ea75637
Signed-off-by: ChaJiWon <jw_wonny.cha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1467
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
vimala.v [Wed, 1 Jul 2015 05:28:31 +0000 (10:58 +0530)]
Integrated IP adapter Singlethread and Multithread files
Removed all "_singlethread" files related to IP adapter.
Change-Id: I8a096ca6b28f74afaa8d122bf416cb4b0733f185
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1010
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Juliet Cai [Thu, 2 Jul 2015 17:31:35 +0000 (10:31 -0700)]
Update to OICSensorboard example
Change OC_ALL to CT_DEFAULT in client.cpp to compile with the latest API
Change-Id: I4654afefc72f9a95a41a23e36ed4f3172afe414d
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1493
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Thu, 2 Jul 2015 09:56:36 +0000 (18:56 +0900)]
fixed memory leak in CA
As the uri is moved from Endpoint to CAInfo structure currently.
but 'free()' was not updated at that time.
so 'free()' is also need in here and there.
Change-Id: I1b3429c29c769c5920dd427688e97b517dd94f66
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1488
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Tue, 30 Jun 2015 13:42:43 +0000 (22:42 +0900)]
Fix send LE adapter sendRequestToAll
Change-Id: I5892851829b56e4a52d5b66d1711554b4b7c4530
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1458
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Tue, 30 Jun 2015 04:52:23 +0000 (10:22 +0530)]
Added camutex no operation file.
This change will be used for singlethread and multithread integration
to avoid the usage of #ifdef around camutex api's.
Change-Id: Ie483c16cd0ac1d194a77fd94a8b9dd459e75509a
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1455
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Wed, 1 Jul 2015 12:19:20 +0000 (17:49 +0530)]
Changed BLE UUID defined in Tizen according to OIC Spec
Change-Id: I92dd97c6176484c621f37d6d946aee683c3da35d
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jyong2.kim [Wed, 1 Jul 2015 08:12:51 +0000 (17:12 +0900)]
Apply namespace OIC::Service.
moved Broker's whole class into namespace OIC::Service.
added exception of Broker API.
changed hostResource return type to const type.
changed cancelHostResource return type to void.
aligned source and header files.
Added initializer for each class.
Change-Id: I65278e2eab1c3621240e9242bdd3f07d592f7911
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1472
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 2 Jul 2015 01:18:25 +0000 (10:18 +0900)]
Change vague variable name in ResourceAttributes
keyValues is not cleared for attribute map. It is changed to values.
Change-Id: I80116e2f017b4b5e1602e2b914389ca91df3f48c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1485
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 2 Jul 2015 01:17:40 +0000 (10:17 +0900)]
Add sid getter to PrimitiveResource
Add sid getter requested by broker
Change-Id: Ib00fb700ce25188d800abe637fe35395df25c313
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1484
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Wed, 1 Jul 2015 01:48:24 +0000 (10:48 +0900)]
Add missing methods to ResourceAttributes and test for one of them
Add missing move constructor definition and rval reference key accessor
Change-Id: I6ac5725fc223accdab8fbaea397f6567674264f9
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1466
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Wed, 1 Jul 2015 01:47:03 +0000 (10:47 +0900)]
Remove dependency on OC from serverBuilder tests using mock
To keep unit tests simple and quick
Change-Id: I0bed8dc4c47eecfff3eb5b7a8437bf020324e9c6
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1465
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Tue, 30 Jun 2015 02:37:07 +0000 (11:37 +0900)]
Add resource type parameter to server builder to prevent registerResource error
To prevent crash in unit test by an exception thrown by base when resource type is empty
Change-Id: I924f568593839a4ddf9ef39a1695452ad1c77549
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1451
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Wed, 1 Jul 2015 01:44:36 +0000 (10:44 +0900)]
Replace expectOCStackResultOK with invokeOCFunc which is safer
Add new methods to primitiveServeResource(removeAttribute and setAttribute with rval ref key)
Change-Id: I796599584fab56dfef697140b819069e3a9612b7
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1464
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Rahul Rahul [Mon, 29 Jun 2015 20:27:18 +0000 (13:27 -0700)]
Added platform information to the android code, as per the spec compliance changes
Change-Id: I78fba71991d8e9da92f706f26166be86a6704c7c
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Wed, 1 Jul 2015 20:44:41 +0000 (13:44 -0700)]
[CA] Fix for DTLS secure unicast port.
Not to set "reuse_address" option when secure unicast port is requested.
Change-Id: Ieffa4fda038946a02c500aa43a85041a2a3b77b3
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1440
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Moumita Ray [Tue, 23 Jun 2015 16:57:29 +0000 (09:57 -0700)]
Adding IPv6 changes in Sample Apps.
This change is part of Multiadaptor/IPv6. Sample Apps needs to be updated to allow available
and currently suppoted connectivity types.
Change-Id: I701027d599e53183673abe2afd7b0f1a5fade885
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1406
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Sat, 20 Jun 2015 22:28:04 +0000 (15:28 -0700)]
Restore host string behavior lost in IPv6 plumbing patch
Change-Id: Ia7120dd3d361e717f2a04782c3b59bdb841bc8bc
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1430
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 1 Jul 2015 07:42:54 +0000 (16:42 +0900)]
replaced uuids in Android BLE
I have replaced current uuids in android BLE
with new uuids which mentioned in OIC spec.
(https://workspace.openinterconnect.org/
apps/org/workgroup/oswg/download.php/1568/
OIC_BLE_Transport_Profile.pdf)
Change-Id: I409174458c0abc2c669f252e4e3ac44e9a040743
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ankur Bansal [Thu, 25 Jun 2015 05:18:36 +0000 (10:48 +0530)]
Fix memory leak in SSM QueryEngine
Fix memory leak in processQueryResult. Allocate pModelData only when
previous operations were successful.
Change-Id: I4829c729d10233ee263c75af533c22782a4659ee
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1428
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Tue, 30 Jun 2015 08:50:20 +0000 (17:50 +0900)]
Add Resource Cache feature that checks validation of the cached datas and if they are expired, refresh them
Modify Get & Observe Callback function to check expired time.
Change-Id: I7282ad485cebbf8f5c66eac10d24f8aaeac4be83
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1450
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
doil.kwon [Mon, 29 Jun 2015 05:07:58 +0000 (14:07 +0900)]
Added Supporting the logic about Non-Presence mode.
- timeoutCB : will be recieved callback message within SAFE_TIME(5sec)
- pollingCB : re-request 'get' to server and re-execute primitiveTimer that timeoutCB is registered.
Re-Aligned about functions and variables list in ".h" file.
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Change-Id: I4a60d455314d7488567ca218fe7cc6114b370796
Reviewed-on: https://gerrit.iotivity.org/gerrit/1437
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Tue, 30 Jun 2015 17:37:31 +0000 (10:37 -0700)]
Changed OCRandom.h's define name to remove lead underscore
The lead underscore is reserved for standard library authors. In
this case, including OCRandom.h from C++ conflicted with the C++
random.h file!
Change-Id: Iff8d06ab7e0838fe8cf9d8af7e67a1fae00c2e4b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Tue, 23 Jun 2015 13:14:45 +0000 (22:14 +0900)]
clean up endpoint methods.
- There are not flexible things in CA codes which
related to handling Endpoint.
: all endpoint objects will be managed by remotehandler.c
: all clone methods related to Endpoint will be managed
by remotehandler.c (not AdapterUtil)
- fixed previous Transport type in some endpoint method
since previous Type was still used in there (CA_LE / CA_EDR)
so i replaced it with
CA_ADAPTER_GATT_BTLE / CA_ADAPTER_RFCOMM_BTEDR
(already done by https://gerrit.iotivity.org/gerrit/#/c/1401/)
Change-Id: Ib8400bbea0c3b4c005b8bec68ded2ed66c337c7b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1404
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Wed, 3 Jun 2015 09:30:40 +0000 (18:30 +0900)]
IP adapter error handling
Ad dependencies got messed up, earlier patch set failed
Adding a fresh patch with right dependencies
Change-Id: Id55430b0d8ce502978e11e5102972fcb901e4472
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1181
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 30 Jun 2015 04:13:32 +0000 (09:43 +0530)]
Fix compile warnings in SimpleClientServer for Linux
SimpleClientServer application for Linux was trying to check the address of array
'clientResponse->rcvdVendorSpecificHeaderOptions' which will always evaluate to 'true'.
Corrected by removing such checks in the code.
Change-Id: Id7306af0792646887740ab3c7952d5fffe8c760b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Juliet Cai [Mon, 8 Jun 2015 20:50:47 +0000 (13:50 -0700)]
Updates to OICSensorboard example
* Updated OICSensorBoard client to work with the latest API
* Modified the server code for temperature conversion to reflect a minor circuit change
* Deleted OICSensorBoardREADME.pdf
* Added README and point to wiki page
Change-Id: Iab74e08f934e2a2c7c50c015b43e8fde8651bc85
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1221
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Charlie Lenahan [Fri, 12 Jun 2015 00:13:36 +0000 (20:13 -0400)]
Fix issue the previous CreateResourceWithHost change
resolve issue registerResource mangles the name properly
Change-Id: I1926a03aef98c79ca00e2605730e856ab1a07915
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Mon, 29 Jun 2015 21:06:44 +0000 (23:06 +0200)]
things-manager: sampleapp: fix typo in ConClientApp
This should be ConClientApp and not ConClientApp
Change-Id: Ib39ad167674e31e8a1088f4f23e62d213fa4948b
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1444
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Sat, 27 Jun 2015 10:01:18 +0000 (15:31 +0530)]
Updated Resource Client
1. Updated as per review comments.
2. Updated as per new folder structure.
Change-Id: I8fa634cd4d6923fd424429b4d9304cb2449f4d86
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Tue, 30 Jun 2015 02:38:04 +0000 (11:38 +0900)]
Modify server resource to make the class mockable
Change-Id: Ie55f6db28183f99aab19df9c3af8b7cbea7c9a81
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1452
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Tue, 30 Jun 2015 03:26:26 +0000 (12:26 +0900)]
Make a member variable of ResourceAttributes::Value private
Change-Id: Ibf0d522d1b33a48e119b4e5893fafa21c45826a3
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Tue, 30 Jun 2015 01:40:16 +0000 (10:40 +0900)]
Add Resource Cache feature that updates cache data periodically for the non-observable resource
Add Primitive Timer instance which checks the frequency and alarms
Add onTimer function to update cache data when Primitive timer alarms.
Change-Id: Ic5c9c0076058344829075e84084c75adb295eaad
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1449
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Thu, 25 Jun 2015 04:13:53 +0000 (13:13 +0900)]
Update Caching cancel logic.
Modify unused parameter in cancelResourceCache().
Change return type of cancelResourceCache() to CacheID
Fix Sconscript for Resource Manipulation.
Change-Id: I3723619599d40a081c58133d12a75d487ddcc8cc
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1421
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 12:22:24 +0000 (17:52 +0530)]
Fix NULL pointer deferencing in SimpleClientServer
Update PrintReceivedMsgInfo to print UNKNOWN when ehRequest is NULL.
Change-Id: Iaed6e2287efbcca2e41cc497545f21dcc6dc618a
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1356
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 26 Jun 2015 04:35:43 +0000 (13:35 +0900)]
CA linux/android sample modification for the secure message
In spite of selecting a secure, CA sample send the normal message.
I modified the CA sample to send secure message
Change-Id: I7725a0033b91dbc5159f9f27ee8147f4a3bfb174
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1425
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 29 Jun 2015 05:38:27 +0000 (11:08 +0530)]
Added one more unit test for OCCreateResource
* Unit test to exercise code path to check OCCreateResource() when the
resource policy is non-discoverable & non-observable.
Change-Id: Ifd95cd6f48a498fbc81c5c62fd7c8df91855f40b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1438
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Thu, 21 May 2015 12:22:54 +0000 (21:22 +0900)]
CA Error handling for LE adapter
This adds error handling from LE adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/
Change-Id: If7cceb4db3a0c47c1fee6cd6814fd1257fc856e8
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1069
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 1 Apr 2015 20:20:35 +0000 (13:20 -0700)]
Minimized hardcoding of CA transport adapter source file lists.
For each of the CA transport adapters, the single SConscript file that
handled construction of the source file list relied heavily and
needlessly on explicit target OS checks. Minimize such logic by
delegating construction of such lists to newly created target
OS-specific SConscript files. Each of those SConscript files will also
handle OS-specific CA transport adapter build configuration.
Change-Id: Iae493631491f6ce98521e36f1e4e790cee4d8186
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/820
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
koushik.girijala [Tue, 23 Jun 2015 10:35:49 +0000 (16:05 +0530)]
[CA] Fixed sample app code for Tizen and Arduino
Fixed build errors and run time errors w.r.to IPv6 and endpoint api changes
Change-Id: Ia2fc13cf2b0e60ee06e451725b1b283db99daa14
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 26 Jun 2015 06:14:46 +0000 (15:14 +0900)]
remove unnecessary code in caipserver
- remove unnecessary error check logic
- add the global variable initialization to fix the build warning
Change-Id: I1e02103b024a4b2a61d71f6e8403117069fe4b32
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1426
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
arafat.hsn [Wed, 24 Jun 2015 10:07:12 +0000 (16:07 +0600)]
[IOT-555]Add event logs to CA sample app
Fix spacing related issue and other missing Log added.
Change-Id: I07ccb79c38073c04bda5055fc07440445b8c124a
Signed-off-by: arafat.hsn <arafat.hsn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1277
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Fri, 22 May 2015 07:22:14 +0000 (16:22 +0900)]
CA Error handling for BT(EDR) Adapter
This adds error handling from BT adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/
Change-Id: I6ad67d5a4da4b65bba82c45bddbee3178fb06ef3
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 25 Jun 2015 05:13:26 +0000 (14:13 +0900)]
[IOT-583] fixed Option Parameter is not support
HeaderOption in RequestInfo and responseInfo parameter
was not supporting since there are no logic related to it
after IPv6 merged.
trus. i'll be support through SendRequest and SendResponse
Change-Id: Ic200ebe29e130baac95991570183beb8f9fb7148
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1422
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 24 Jun 2015 11:51:29 +0000 (20:51 +0900)]
[IOT-580] fixed RESET is not working
RESET on CoAP spec is not working in EDR
because OICStrcpyPartial(..) is supported only string format.
it have to be copied bytes to buffer
(https://gerrit.iotivity.org/gerrit/#/c/1208/8/
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrserver.c)
Change-Id: I01f4cabccdada80cccdc7efe6fb55fe203a09c99
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1416
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 24 Jun 2015 18:12:03 +0000 (11:12 -0700)]
Corrected error return value when parsing fragmentation header.
CAParseHeader() on error returned CA_STATUS_INVALID_PARAM, a
CAResult_t value, instead of a value that matches uint32_t return
type. Return zero on error instead.
Updated documentation accordingly.
Change-Id: I3dee0e2b562a272c5d41963e0049618d7bacd69e
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 23 Jun 2015 17:02:27 +0000 (13:02 -0400)]
Removed memory leaks in CA Unit Tests.
These memory leaks are reported by Valgrind on the build server. With
these removed, the threshold value for memory leaks can be lowered and
further commits will be more resilient.
Change-Id: I606ec487c0a4f0207b85556ed0c48b4f34873907
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Patrick C Lankswert [Wed, 24 Jun 2015 17:37:19 +0000 (13:37 -0400)]
Added documentation build script for Doxygen and JavaDoc
This change set adds a script (./build_docs.sh) to generate
the documenation for iotivity which is placed into the ./docs
directory. Currently, the script builds java and C/C++ API
documentation and includes checks for warnings and errors.
When all of the existing warnings and errors are addressed,
this should be added to the build script to fail validation
if/when a contributor breaks the API documentation.
Please consider cherry-picking to the 0.9.1 release branch.
Change-Id: I490fbfc83cf61c76c7f59ba2c00404a073b039e7
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1418
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
hunje.yeon [Wed, 24 Jun 2015 12:10:19 +0000 (21:10 +0900)]
Restruct resource-manipulation folders
change 'basis' to 'resource-manipulation'
add sub-folder 'modules' for resource common funcions
Change-Id: Iec5b700d2f68cb63807da4ee2e050cbb8c8dbcdb
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Rahul Rahul [Wed, 24 Jun 2015 20:47:21 +0000 (13:47 -0700)]
Updated android ResourceProperty to follow the same order as specified in octypes.h.
This fixes IOT-579.
Made a small correction in android build instructions
Change-Id: I5b2df5986ac8d0a75d9a987d8667f942a24ec2cf
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1420
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sachin Agrawal [Wed, 24 Jun 2015 15:49:33 +0000 (08:49 -0700)]
Fixed unicast failure bug due to faulty strcpy
Recent modifications in ParseRequestUri introduced a bug where
IP address was not copied properly in OCDevAddr data structure.
Change-Id: I40a322530a11ab3cdae89d015cd774f507ccfdab
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1408
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Ravi Nanjundappa [Wed, 24 Jun 2015 11:07:34 +0000 (16:37 +0530)]
Fix compile warnings in connectivity unittests
Unit test was emitting a warning due to unused variables in x86 Linux.
Corrected it by removing all unused varaibles.
Change-Id: I7f29487414e894149a8acc0620be4b7643f0f531
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1415
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Wed, 24 Jun 2015 08:35:51 +0000 (17:35 +0900)]
Remove unnecessary code in Android CA Sample
As some CA API(FindResource/AdvertiseResource) had removed
by IPv6 change.
the code in Android Sample related to the API is removed
in this patch
Change-Id: I9a69620656c62aef5a89117cb562a441d08a349a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1413
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jyong2.kim [Tue, 23 Jun 2015 10:00:15 +0000 (19:00 +0900)]
Add BrokerID for start and cancel Broker.
Implementation generate BrokerID.
Implementation cancelHostResource method.
Add resource and device delete logic.
Delete unused defined value.
Change-Id: I83ac5e2af16493ff9e81c757bc523ad934b281c0
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1400
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Wed, 24 Jun 2015 00:54:07 +0000 (09:54 +0900)]
Add pthread link to service common test
Change-Id: I5336e3d7a51f4ea45e784e532db366c8473654d0
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1409
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Tue, 23 Jun 2015 08:14:06 +0000 (17:14 +0900)]
Add unit test for discoverResource
Change-Id: I69a11e7f130d681bce41e4ff32cb1f0a67994fb5
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1397
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
hunje.yeon [Wed, 24 Jun 2015 07:34:16 +0000 (16:34 +0900)]
Merge branch 'master' into resource-manipulation
Update the last changes of 'master' into 'resource-manipulation' branch
Change-Id: I1ddfc5d14ea01a46e52f1e6d5efe73732225d67d
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Ravi Nanjundappa [Tue, 23 Jun 2015 04:52:05 +0000 (10:22 +0530)]
Added unit tests for StackResource
Unit test exercise code paths to check OCCreateResource() for
OC_LIENT mode and also to check if resource type name is invalid
i.e., null terminated or not.
This also includes the bug fix related to checking if resource type
name is invalid i.e., null terminated or not.
Change-Id: I7f8767a4e8b9586de9cb0926dd8a4afcd03b792c
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 22 Jun 2015 23:38:58 +0000 (16:38 -0700)]
Added missing DTLS #ifdef guard.
One of the functions only used for DTLS was missing #ifdef guards
resulting in compile warnings.
Change-Id: Ieb0082e1dba2547e8d73d0526cf0aab3bf3af589
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1333
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Tue, 23 Jun 2015 08:06:24 +0000 (17:06 +0900)]
removed duplicated code in Sample app
- Target Platform : Android, Linux
Change-Id: I7035a138cb9b83a6e653c213aaa4fc349b57545d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1395
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 23 Jun 2015 09:02:49 +0000 (14:32 +0530)]
Remove unused scons file in examples/OICMiddle/ for x86 linux build
Actual file used is examples/OICMiddle/SConscript, So removed the unused
scons file examples/OICMiddle/SConstruct from git.
Change-Id: I9c0d3c37d0f228ed3125763f05efa7b447e4e41b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1399
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Tue, 23 Jun 2015 10:55:55 +0000 (19:55 +0900)]
remove unnecessary code in messagehandler
- remove the duplicated log message for the debugging
- add the null check logic for token
Change-Id: Icfd74fcc350b6e1c9038acdac290cfcaf9d344e7
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1402
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>