platform/upstream/libSkiaSharp.git
10 years agoarm64_download script - fix error starting vm twice.
commit-bot@chromium.org [Tue, 15 Apr 2014 20:29:38 +0000 (20:29 +0000)]
arm64_download script - fix error starting vm twice.
R=epoger@google.com
TBR=epoger@google.com
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239653003

git-svn-id: http://skia.googlecode.com/svn/trunk@14210 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoarm64_download script waits for VM to boot before finishing.
commit-bot@chromium.org [Tue, 15 Apr 2014 20:05:24 +0000 (20:05 +0000)]
arm64_download script waits for VM to boot before finishing.

It may take an unknown amount of time to boot.

Also, add `set -e` to the script to simplify error handling.

BUG=skia:2425
NOTRY=true
R=epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239243005

git-svn-id: http://skia.googlecode.com/svn/trunk@14209 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 19:39:52 +0000 (19:39 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14208 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of rebaseline_server: multithreaded loading/diffing of images (https://coderev...
commit-bot@chromium.org [Tue, 15 Apr 2014 18:50:12 +0000 (18:50 +0000)]
Revert of rebaseline_server: multithreaded loading/diffing of images (https://codereview.chromium.org/235923002/)

Reason for revert:
Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server').  Reverting until I can figure it out.

Original issue's description:
> rebaseline_server: multithreaded loading/diffing of images
>
> BUG=skia:2414
> NOTRY=True
>
> Committed: http://code.google.com/p/skia/source/detail?r=14184

R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2414

Author: epoger@google.com

Review URL: https://codereview.chromium.org/239623002

git-svn-id: http://skia.googlecode.com/svn/trunk@14207 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 18:35:49 +0000 (18:35 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14206 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 18:24:58 +0000 (18:24 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14205 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinitialize bounds in this test
commit-bot@chromium.org [Tue, 15 Apr 2014 18:00:57 +0000 (18:00 +0000)]
initialize bounds in this test

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/238353007

git-svn-id: http://skia.googlecode.com/svn/trunk@14204 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix artifacts in distance field rendering due to bilerp
commit-bot@chromium.org [Tue, 15 Apr 2014 17:53:21 +0000 (17:53 +0000)]
Fix artifacts in distance field rendering due to bilerp

Because we were using the full distance field glyph rect, there were cases
when a neighboring texel might be set to full value (e.g. we might copy the
glyph over old data after a purge). This was giving artifacts, and insetting
the rect by 1 solves the problem. In doing this, I discovered that removing the
extra 1 texel pad around the glyph meant to handle bilerp, and insetting by 2,
works just as well and saves space in the glyph atlas.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/239333002

git-svn-id: http://skia.googlecode.com/svn/trunk@14203 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd cast for warning as error on Windows from r14201.
bungeman@google.com [Tue, 15 Apr 2014 16:08:29 +0000 (16:08 +0000)]
Add cast for warning as error on Windows from r14201.

git-svn-id: http://skia.googlecode.com/svn/trunk@14202 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix size of rotated text with FreeType.
bungeman@google.com [Tue, 15 Apr 2014 15:52:07 +0000 (15:52 +0000)]
Fix size of rotated text with FreeType.

This generalizes and shares the solution found for a similar issue with
GDI. The issue is that the text size is applied early, and the rest of
the transformation late. This allows us to isolate and independently
control the text size from the rest of the transformation.

R=reed@google.com

Review URL: https://codereview.chromium.org/213153006

git-svn-id: http://skia.googlecode.com/svn/trunk@14201 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake sure SkDrawLooper objects can only be allocated on the heap.
commit-bot@chromium.org [Tue, 15 Apr 2014 15:48:36 +0000 (15:48 +0000)]
Make sure SkDrawLooper objects can only be allocated on the heap.

Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.

BUG=2141
R=scroggo@google.com, reed@google.com, djsollen@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/232913003

git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd GL_CHROMIUM_map_sub functions to GrGLInterface and bit to GrGLCaps.
commit-bot@chromium.org [Tue, 15 Apr 2014 15:37:51 +0000 (15:37 +0000)]
Add GL_CHROMIUM_map_sub functions to GrGLInterface and bit to GrGLCaps.

BUG=skia:2402
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/231773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14199 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoignore Test-Linux-Bare-NoGPU-Arm8_64 GM failures
commit-bot@chromium.org [Tue, 15 Apr 2014 15:26:50 +0000 (15:26 +0000)]
ignore Test-Linux-Bare-NoGPU-Arm8_64 GM failures

(SkipBuildbotRuns)
BUG=skia:2422
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com
TBR=halcanary

Author: epoger@google.com

Review URL: https://codereview.chromium.org/239323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14198 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecord bug fixes
commit-bot@chromium.org [Tue, 15 Apr 2014 14:27:14 +0000 (14:27 +0000)]
SkRecord bug fixes

Optional arguments to SkCanvas calls leaked refs (but not memory) because we
didn't destruct the optional objects (really, just SkPaint: other optional args
are all POD).  This adds Optional and PODArray, where Optional makes sure to
call the destructor.

I overlooked that SkPictureRecord really does call paint.computeFastBounds().
Do the same in SkRecordDraw.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235983015

git-svn-id: http://skia.googlecode.com/svn/trunk@14197 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 15 Apr 2014 03:04:18 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14196 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore sanitizing input.
commit-bot@chromium.org [Tue, 15 Apr 2014 00:43:51 +0000 (00:43 +0000)]
More sanitizing input.

Also fix issue with parsing time on MySQL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235953008

git-svn-id: http://skia.googlecode.com/svn/trunk@14195 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate pathops gms for r14183.
bungeman@google.com [Mon, 14 Apr 2014 22:28:00 +0000 (22:28 +0000)]
Update pathops gms for r14183.

git-svn-id: http://skia.googlecode.com/svn/trunk@14194 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove distance field generation to the glyph cache.
commit-bot@chromium.org [Mon, 14 Apr 2014 22:05:07 +0000 (22:05 +0000)]
Move distance field generation to the glyph cache.

Distance fields are currently created in GrTextStrike, which is the wrong place. This moves that to the glyph cache where it belongs.

As part of my testing, I found that when we fall back to paths in the GrDistanceFieldTextContext it was not scaling them properly, so that's fixed in here too.

R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/227593010

git-svn-id: http://skia.googlecode.com/svn/trunk@14193 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: use SkCanvas::quickRejectY for text draws
commit-bot@chromium.org [Mon, 14 Apr 2014 20:35:12 +0000 (20:35 +0000)]
SkRecordDraw: use SkCanvas::quickRejectY for text draws

 PS 1) factor apart into canSkip, draw, updateClip
 PS 2) use quickRejectY for text

BUG=skia:2378
R=fmalita@chromium.org, reed@google.com, mtklein@google.com, tomhudson@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233493004

git-svn-id: http://skia.googlecode.com/svn/trunk@14192 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecord: turn on cull annotation pass in public API.
commit-bot@chromium.org [Mon, 14 Apr 2014 20:33:05 +0000 (20:33 +0000)]
SkRecord: turn on cull annotation pass in public API.

Also, switch Skia internal tools over to use the public headers where
possible.  Where it's not, the tools -Isrc/record explicitly now, and
if it's not obvious, note why they don't use SkRecording.h.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231853006

git-svn-id: http://skia.googlecode.com/svn/trunk@14191 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd /recent, a page that displays the last 20 tries.
commit-bot@chromium.org [Mon, 14 Apr 2014 20:12:08 +0000 (20:12 +0000)]
Add /recent, a page that displays the last 20 tries.

Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/236193011

git-svn-id: http://skia.googlecode.com/svn/trunk@14190 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange #if SK_DEBUG to #ifdef SK_DEBUG
commit-bot@chromium.org [Mon, 14 Apr 2014 19:49:53 +0000 (19:49 +0000)]
change #if SK_DEBUG to #ifdef SK_DEBUG

fix broken build

change #if DEBUG to #ifdef DEBUG (fixes canary)

NOTRY=true
R=reed@google.com
TBR=reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/237573002

git-svn-id: http://skia.googlecode.com/svn/trunk@14189 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline pathopsinverse GMs
commit-bot@chromium.org [Mon, 14 Apr 2014 18:56:43 +0000 (18:56 +0000)]
rebaseline pathopsinverse GMs
to account for https://skia.googlesource.com/skia.git/+/4431e7757cfcb8cfa99535eed0e9f156dabf95c2

NOTRY=True
R=caryclark@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/233253006

git-svn-id: http://skia.googlecode.com/svn/trunk@14188 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNow with permalinks.
commit-bot@chromium.org [Mon, 14 Apr 2014 18:53:10 +0000 (18:53 +0000)]
Now with permalinks.

Once we get a response from our XHR request update the URL to a permalink to that code.

This CL comes after https://codereview.chromium.org/235373002/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235323006

git-svn-id: http://skia.googlecode.com/svn/trunk@14187 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix broken build
commit-bot@chromium.org [Mon, 14 Apr 2014 18:33:03 +0000 (18:33 +0000)]
fix broken build

change 'char' to 'int8_t'

BUG=skia:

NOTRY=true
TBR=reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/237263004

git-svn-id: http://skia.googlecode.com/svn/trunk@14186 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of use templates instead of macros to build blitters (https://coderevi...
reed@google.com [Mon, 14 Apr 2014 18:27:18 +0000 (18:27 +0000)]
Revert "Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/120633004/)"

This reverts commit e9d2798fd37e2fb33b545d142a5baa21a4b747fe.

BUG=skia:

Review URL: https://codereview.chromium.org/236303008

git-svn-id: http://skia.googlecode.com/svn/trunk@14185 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: multithreaded loading/diffing of images
commit-bot@chromium.org [Mon, 14 Apr 2014 18:15:29 +0000 (18:15 +0000)]
rebaseline_server: multithreaded loading/diffing of images

BUG=skia:2414
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/235923002

git-svn-id: http://skia.googlecode.com/svn/trunk@14184 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMike R: please sanity check SkPostConfig.h
commit-bot@chromium.org [Mon, 14 Apr 2014 17:08:59 +0000 (17:08 +0000)]
Mike R: please sanity check SkPostConfig.h
Mike K: please sanity check Test.cpp and skia_test.cpp

Feel free to look at the rest, but I don't expect any in depth review of path ops innards.

Path Ops first iteration used QuickSort to order segments radiating from an intersection to compute the winding rule.

This revision uses a circular sort instead. Breaking out the circular sort into its own long-lived structure (SkOpAngle) allows doing less work and provides a home for caching additional sorting data.

The circle sort is more stable than the former sort, has a robust ordering and fewer exceptions. It finds unsortable ordering less often. It is less reliant on the initial curve  tangent, using convex hulls instead whenever it can.

Additional debug validation makes sure that the computed structures are self-consistent. A new visualization tool helps verify that the angle ordering is correct.

The 70+M tests pass with this change on Windows, Mac, Linux 32 and Linux 64 in debug and release.

R=mtklein@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/131103009

git-svn-id: http://skia.googlecode.com/svn/trunk@14183 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd conical special cases to GradientBench
commit-bot@chromium.org [Mon, 14 Apr 2014 16:02:31 +0000 (16:02 +0000)]
Add conical special cases to GradientBench

BUG=skia:
R=reed@google.com, bsalomon@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/234603006

git-svn-id: http://skia.googlecode.com/svn/trunk@14182 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow clients to specify an external SkImageFilter cache.
senorblanco@chromium.org [Mon, 14 Apr 2014 15:51:48 +0000 (15:51 +0000)]
Allow clients to specify an external SkImageFilter cache.

This change allows external callers to substitute their own
SkImageFilter cache for the default intra-frame cache in Skia. This
allows the caller to perform inter-frame caching for example, by the
maintaining a persistent cache between frames and doing custom
invalidation.

R=reed@google.com

Review URL: https://codereview.chromium.org/225903010

git-svn-id: http://skia.googlecode.com/svn/trunk@14181 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of use templates instead of macros to build blitters (https://codereview.chrom...
commit-bot@chromium.org [Mon, 14 Apr 2014 15:45:58 +0000 (15:45 +0000)]
Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/120633004/)

Reason for revert:
Broke build.

Original issue's description:
> use templates instead of macros to build blitters
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14178

R=mtklein@google.com, reed@google.com
TBR=mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/236593006

git-svn-id: http://skia.googlecode.com/svn/trunk@14180 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove currently unused code
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:50 +0000 (15:02 +0000)]
Remove currently unused code

This code is currently unused and is contrary to the way in which we seem to be moving towards accomplishing this (i.e., device-specific optimization passes).

This is a partial revert of r13704 (First version of bitmap use tracking in SkPictureRecord - https://codereview.chromium.org/187833003/)

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/237013002

git-svn-id: http://skia.googlecode.com/svn/trunk@14179 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse templates instead of macros to build blitters
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:35 +0000 (15:02 +0000)]
use templates instead of macros to build blitters

BUG=
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/120633004

git-svn-id: http://skia.googlecode.com/svn/trunk@14178 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoresize canvas for GM + typo
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:19 +0000 (15:02 +0000)]
resize canvas for GM + typo

This change resized the canvas for some GM cases. It is better to show the visual difference in viewer.html for these cases after the CL applied.

BUG=skia:2375
R=reed@google.com, djsollen@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/221953002

git-svn-id: http://skia.googlecode.com/svn/trunk@14177 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoXfermode: SSE2 implementation of a number of simple transfer modes
commit-bot@chromium.org [Mon, 14 Apr 2014 14:54:22 +0000 (14:54 +0000)]
Xfermode: SSE2 implementation of a number of simple transfer modes

These modes share some common code and not very complex, so group them
together. This CL yields about 50% performance improvement on desktop
i7-3770. Here are the data:
before:
   Xfermode_Screen   8888:  cmsecs =     30.25   565:  cmsecs =     46.81
 Xfermode_Modulate   8888:  cmsecs =     22.48   565:  cmsecs =     40.06
     Xfermode_Plus   8888:  cmsecs =     21.04   565:  cmsecs =     37.51
      Xfermode_Xor   8888:  cmsecs =     37.18   565:  cmsecs =     52.53
  Xfermode_DstATop   8888:  cmsecs =     28.97   565:  cmsecs =     46.42
  Xfermode_SrcATop   8888:  cmsecs =     29.74   565:  cmsecs =     46.25
   Xfermode_DstOut   8888:  cmsecs =      5.34   565:  cmsecs =     24.53
   Xfermode_SrcOut   8888:  cmsecs =     12.25   565:  cmsecs =     24.39
    Xfermode_DstIn   8888:  cmsecs =      5.30   565:  cmsecs =     24.50
    Xfermode_SrcIn   8888:  cmsecs =     12.05   565:  cmsecs =     25.40
  Xfermode_DstOver   8888:  cmsecs =     12.45   565:  cmsecs =      0.15
  Xfermode_SrcOver   8888:  cmsecs =      2.68   565:  cmsecs =      4.42
after:
   Xfermode_Screen   8888:  cmsecs =     13.68   565:  cmsecs =     21.73
 Xfermode_Modulate   8888:  cmsecs =     13.25   565:  cmsecs =     20.97
     Xfermode_Plus   8888:  cmsecs =      9.77   565:  cmsecs =     16.71
      Xfermode_Xor   8888:  cmsecs =     17.64   565:  cmsecs =     25.62
  Xfermode_DstATop   8888:  cmsecs =     15.99   565:  cmsecs =     23.74
  Xfermode_SrcATop   8888:  cmsecs =     15.69   565:  cmsecs =     23.40
   Xfermode_DstOut   8888:  cmsecs =      4.77   565:  cmsecs =     11.85
   Xfermode_SrcOut   8888:  cmsecs =      4.98   565:  cmsecs =     11.84
    Xfermode_DstIn   8888:  cmsecs =      4.68   565:  cmsecs =     11.72
    Xfermode_SrcIn   8888:  cmsecs =      4.93   565:  cmsecs =     11.79
  Xfermode_DstOver   8888:  cmsecs =      5.04   565:  cmsecs =      0.15
  Xfermode_SrcOver   8888:  cmsecs =      2.69   565:  cmsecs =      4.42

BUG=skia:
R=mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/232793002

git-svn-id: http://skia.googlecode.com/svn/trunk@14176 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd design for sql storage, implementation of db that stores the data, not retrieving...
commit-bot@chromium.org [Mon, 14 Apr 2014 14:54:07 +0000 (14:54 +0000)]
Add design for sql storage, implementation of db that stores the data, not retrieving yet.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235373002

git-svn-id: http://skia.googlecode.com/svn/trunk@14175 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore removal of duplicate framework defines.
commit-bot@chromium.org [Mon, 14 Apr 2014 14:53:58 +0000 (14:53 +0000)]
More removal of duplicate framework defines.

BUG=skia:1975
R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/228343003

git-svn-id: http://skia.googlecode.com/svn/trunk@14174 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove duplicate skia_android_framework defines.
commit-bot@chromium.org [Mon, 14 Apr 2014 14:53:53 +0000 (14:53 +0000)]
Remove duplicate skia_android_framework defines.

BUG=skia:1975
R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/225283022

git-svn-id: http://skia.googlecode.com/svn/trunk@14173 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Mon, 14 Apr 2014 03:04:57 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14172 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agosplit SkPictureRecorder out of SkPicture
robertphillips@google.com [Sun, 13 Apr 2014 19:09:42 +0000 (19:09 +0000)]
split SkPictureRecorder out of SkPicture

https://codereview.chromium.org/214953003/

git-svn-id: http://skia.googlecode.com/svn/trunk@14171 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding image-surface to ignored-tests.txt
robertphillips@google.com [Sun, 13 Apr 2014 18:01:01 +0000 (18:01 +0000)]
Adding image-surface to ignored-tests.txt

git-svn-id: http://skia.googlecode.com/svn/trunk@14170 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase test e93a4c0
commit-bot@chromium.org [Sat, 12 Apr 2014 13:35:46 +0000 (13:35 +0000)]
bench rebase test e93a4c0
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235913004

git-svn-id: http://skia.googlecode.com/svn/trunk@14169 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 12 Apr 2014 03:05:59 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14168 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: fix sorting by perceptual diff column
commit-bot@chromium.org [Fri, 11 Apr 2014 21:45:41 +0000 (21:45 +0000)]
rebaseline_server: fix sorting by perceptual diff column

(SkipBuildbotRuns)
BUG=skia:2410
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/235993002

git-svn-id: http://skia.googlecode.com/svn/trunk@14167 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase test 28fcae2
commit-bot@chromium.org [Fri, 11 Apr 2014 20:30:58 +0000 (20:30 +0000)]
bench rebase test 28fcae2
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235283005

git-svn-id: http://skia.googlecode.com/svn/trunk@14166 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFurther adjust bench expectations calculation.
commit-bot@chromium.org [Fri, 11 Apr 2014 19:54:16 +0000 (19:54 +0000)]
Further adjust bench expectations calculation.

BUG=skia:2225
TBR=robertphillips@google.com
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14165 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase test 1f75ab9
commit-bot@chromium.org [Fri, 11 Apr 2014 19:07:40 +0000 (19:07 +0000)]
bench rebase test 1f75ab9
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235483004

git-svn-id: http://skia.googlecode.com/svn/trunk@14164 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse the correct rowBytes so Debug build doesn't assert
commit-bot@chromium.org [Fri, 11 Apr 2014 19:06:46 +0000 (19:06 +0000)]
use the correct rowBytes so Debug build doesn't assert

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235453002

git-svn-id: http://skia.googlecode.com/svn/trunk@14163 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove dead code from SkPicturePlayback
commit-bot@chromium.org [Fri, 11 Apr 2014 19:05:22 +0000 (19:05 +0000)]
remove dead code from SkPicturePlayback

This is from an earlier iteration of the pull-forward task before we switched to doing the majority of the work in SkGpuDevice.

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/235473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14162 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoR=robertphillips@google.com
commit-bot@chromium.org [Fri, 11 Apr 2014 19:00:28 +0000 (19:00 +0000)]
R=robertphillips@google.com
TBR=robertphillips@google.com
BUG=skia:

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14161 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement intra-frame cacheing in image filters.
commit-bot@chromium.org [Fri, 11 Apr 2014 18:57:00 +0000 (18:57 +0000)]
Implement intra-frame cacheing in image filters.

When image filters are processed within Skia, they simply do
a blind recursion. This has the side-effect of turning the
DAG into a tree. I.e., nodes visited more than once during
the traversal will be processed more than once.

This change implements a very simple cacheing scheme: a
cache is created before traversing the DAG, and handed
into the processing traversal. Before recursing into a child
in SkImageFilter::filterImage(), the cache is checked for a
hit, and early-out is performed. Otherwise, the node is
processed, and its result bitmap and location (offset) are
cached, but only if it contains two or more children and
thus will be visited again during the traversal.

Currently, the child count is approximated with the
refcount. This is good enough in most cases (and exactly
correct for the Chrome use case). We could add an exact
child count to the image filter, but this will require
violating the immutability of image filters slightly in
order to bump the child count as nodes are connected. I
leave it up to the reviewer to decide which is better.

R=reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/230653005

git-svn-id: http://skia.googlecode.com/svn/trunk@14160 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove picture-backed surfaces
commit-bot@chromium.org [Fri, 11 Apr 2014 18:34:35 +0000 (18:34 +0000)]
remove picture-backed surfaces

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/233943002

git-svn-id: http://skia.googlecode.com/svn/trunk@14159 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark our territory with (C).
commit-bot@chromium.org [Fri, 11 Apr 2014 18:33:31 +0000 (18:33 +0000)]
Mark our territory with (C).

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235253002

git-svn-id: http://skia.googlecode.com/svn/trunk@14158 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate Android expectations to reflect the new default gamma for fonts.
djsollen@google.com [Fri, 11 Apr 2014 18:22:44 +0000 (18:22 +0000)]
Update Android expectations to reflect the new default gamma for fonts.

see https://code.google.com/p/skia/source/detail?r=14148 for the responsible CL.

R=epoger@google.com

Review URL: https://codereview.chromium.org/228323006

git-svn-id: http://skia.googlecode.com/svn/trunk@14157 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://coderev...
commit-bot@chromium.org [Fri, 11 Apr 2014 17:15:40 +0000 (17:15 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/)

Reason for revert:
Want to reland the original CL.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, bensong@google.com
TBR=bensong@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/235523003

git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse SkIntToScalar, fix windows build
commit-bot@chromium.org [Fri, 11 Apr 2014 16:13:54 +0000 (16:13 +0000)]
use SkIntToScalar, fix windows build

NOTRY=true
NOTREECHECKS=true
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/234913004

git-svn-id: http://skia.googlecode.com/svn/trunk@14155 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate bench to be able to preprocess skps
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:14 +0000 (15:54 +0000)]
Update bench to be able to preprocess skps

This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated.

R=jvanverth@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/233663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14154 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove guard for getTotalClip
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:06 +0000 (15:54 +0000)]
remove guard for getTotalClip

TBR=robertphilips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/235093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14153 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased)
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:47 +0000 (15:53 +0000)]
Rename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased)

This is mainly a renaming CL but it does add a ref-counted ptr  to the backing GrTexture for non-atlased layers (the only kind working right now)

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/233703003

git-svn-id: http://skia.googlecode.com/svn/trunk@14152 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd bench_playback, for quick profiling of SKR playback.
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:39 +0000 (15:53 +0000)]
Add bench_playback, for quick profiling of SKR playback.

It is not completely fair to compare --skr and --noskr numbers.  SKR looks
unfairly good because some optimizations are baked into our SKPs at record
time.  But, at least, by using a kWriteOnly_Mode SkRecorder, we prevent
SkPicturePlayback from compounding that unfairness.  SkRecordDraw must handle
its own playback-time optimizations (quickrejects) on its own.

This code should look suspiciously similar to bench_record.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233833002

git-svn-id: http://skia.googlecode.com/svn/trunk@14151 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd some .gitignores related to gm and tools
commit-bot@chromium.org [Fri, 11 Apr 2014 14:49:50 +0000 (14:49 +0000)]
add some .gitignores related to gm and tools

NOTREECHECKS=True
NOTRY=True
R=scroggo@google.com
TBR=scroggo

Author: epoger@google.com

Review URL: https://codereview.chromium.org/234603004

git-svn-id: http://skia.googlecode.com/svn/trunk@14150 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromi...
commit-bot@chromium.org [Fri, 11 Apr 2014 13:47:30 +0000 (13:47 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)

Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234833003

git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDisable SK_GAMMA_SRGB on android builds.
djsollen@google.com [Fri, 11 Apr 2014 13:09:21 +0000 (13:09 +0000)]
Disable SK_GAMMA_SRGB on android builds.

R=bungeman@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/229133003

git-svn-id: http://skia.googlecode.com/svn/trunk@14148 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSo apparently Chrome has an x86 iOS build...
commit-bot@chromium.org [Fri, 11 Apr 2014 12:52:44 +0000 (12:52 +0000)]
So apparently Chrome has an x86 iOS build...

and for some reason we don't bother to build or link our SSE2 opts
there.  So don't go looking for them when SK_BUILD_FOR_IOS is set.

BUG=skia:
NOTREECHECKS=true
NOTRY=true
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/225033003

git-svn-id: http://skia.googlecode.com/svn/trunk@14147 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a focused public API for src/record.
commit-bot@chromium.org [Thu, 10 Apr 2014 23:30:59 +0000 (23:30 +0000)]
Add a focused public API for src/record.

BUG=skia:2378
R=reed@google.com, robertphillips@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233053005

git-svn-id: http://skia.googlecode.com/svn/trunk@14146 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://coderev...
commit-bot@chromium.org [Thu, 10 Apr 2014 22:49:20 +0000 (22:49 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/)

Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/233813004

git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromi...
commit-bot@chromium.org [Thu, 10 Apr 2014 22:36:34 +0000 (22:36 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)

Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoClean up the default gamma settings.
bungeman@google.com [Thu, 10 Apr 2014 22:26:29 +0000 (22:26 +0000)]
Clean up the default gamma settings.

This makes it a compile error to specify both SK_GAMMA_EXPONENT
and SK_GAMMA_SRGB. It also ensures that SK_GAMMA_EXPONENT will
be set consistently.

R=djsollen@google.com, reed@google.com

Review URL: https://codereview.chromium.org/233003003

git-svn-id: http://skia.googlecode.com/svn/trunk@14143 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove two more effects that are now immutable
commit-bot@chromium.org [Thu, 10 Apr 2014 21:57:32 +0000 (21:57 +0000)]
remove two more effects that are now immutable

BUG=skia:
R=scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/233753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14142 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agowhen getClipBounds returns false, the out-param is uninitialized
reed@google.com [Thu, 10 Apr 2014 21:15:30 +0000 (21:15 +0000)]
when getClipBounds returns false, the out-param is uninitialized

BUG=skia:

Review URL: https://codereview.chromium.org/233933002

git-svn-id: http://skia.googlecode.com/svn/trunk@14141 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCast int to float.
commit-bot@chromium.org [Thu, 10 Apr 2014 21:09:33 +0000 (21:09 +0000)]
Cast int to float.

Get rid of warning->error.

TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233883002

git-svn-id: http://skia.googlecode.com/svn/trunk@14140 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCreate SkLayerRasterizer w/o destroying Builder.
commit-bot@chromium.org [Thu, 10 Apr 2014 20:42:53 +0000 (20:42 +0000)]
Create SkLayerRasterizer w/o destroying Builder.

Add a new method to SkLayerRasterizer::Builder that creates a new
SkLayerRasterizer without destroying the Builder. Necessary to
continue to support Android's API.

Also fix a bug where creating a Builder and never calling
detachRasterizer results in not calling the destructor for any SkPaints
in the Builder.

Add tests.

BUG=b/13729784
R=reed@google.com, dominikg@chromium.org

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233673002

git-svn-id: http://skia.googlecode.com/svn/trunk@14139 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: eliminate meaningless 404 errors while waiting for content to...
commit-bot@chromium.org [Thu, 10 Apr 2014 20:41:13 +0000 (20:41 +0000)]
rebaseline_server: eliminate meaningless 404 errors while waiting for content to load

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/231513004

git-svn-id: http://skia.googlecode.com/svn/trunk@14138 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFlesh out the list of includes, also fix up README markdown
commit-bot@chromium.org [Thu, 10 Apr 2014 20:24:14 +0000 (20:24 +0000)]
Flesh out the list of includes, also fix up README markdown

Currently only pulls in 'core' and 'effects'. Will add in gpu once we add an option to render via Mesa.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/232883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14137 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd MakeEmpty to GrIRect16
commit-bot@chromium.org [Thu, 10 Apr 2014 18:36:19 +0000 (18:36 +0000)]
Add MakeEmpty to GrIRect16

The GrLayerCache will use this capability.

R=jvanverth@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/232563007

git-svn-id: http://skia.googlecode.com/svn/trunk@14136 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a new bench that tests a simple image filter DAG.
senorblanco@chromium.org [Thu, 10 Apr 2014 16:16:13 +0000 (16:16 +0000)]
Add a new bench that tests a simple image filter DAG.

This bench exercises a blur filter connected to 5 inputs of the same
merge filter.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/233383002

git-svn-id: http://skia.googlecode.com/svn/trunk@14135 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix GPU-less build.
commit-bot@chromium.org [Thu, 10 Apr 2014 16:03:06 +0000 (16:03 +0000)]
Fix GPU-less build.

Do not include GrTBackendEffectFactory.h if SK_SUPPORT_GPU is
undefined.

R=egdaniel@google.com
TBR=egdaniel@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233093003

git-svn-id: http://skia.googlecode.com/svn/trunk@14134 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd explicit filepaths to render_pictures JSON summary
commit-bot@chromium.org [Thu, 10 Apr 2014 15:39:02 +0000 (15:39 +0000)]
add explicit filepaths to render_pictures JSON summary

BUG=skia:2230,skia:1942
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/226293002

git-svn-id: http://skia.googlecode.com/svn/trunk@14133 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove build guard to fix Android framework compile.
commit-bot@chromium.org [Thu, 10 Apr 2014 15:37:52 +0000 (15:37 +0000)]
Move build guard to fix Android framework compile.

After merging into the Android tree, this file was not compiling.
It turns out that it was because SK_SUPPORT_GPU was not defined. When
built by GYP, SK_SUPPORT_GPU is defined by GYP. When built by the
Android framework, we depend on SkUserConfig.h, which is included by
other files, to set SK_SUPPORT_GPU. Moving the includes outside of
#if SK_SUPPORT_GPU ensures that the dependency chain defining
SK_SUPPORT_GPU is included, so this code gets compiled as expected.

R=egdaniel@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/228893003

git-svn-id: http://skia.googlecode.com/svn/trunk@14132 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: allow user to specify which builders to process
commit-bot@chromium.org [Thu, 10 Apr 2014 15:05:24 +0000 (15:05 +0000)]
rebaseline_server: allow user to specify which builders to process

BUG=skia:1543,skia:1915
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/232103002

git-svn-id: http://skia.googlecode.com/svn/trunk@14131 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename README and DESIGN so their markdown gets picked up my GitHub.
commit-bot@chromium.org [Thu, 10 Apr 2014 14:13:23 +0000 (14:13 +0000)]
Rename README and DESIGN so their markdown gets picked up my GitHub.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231883008

git-svn-id: http://skia.googlecode.com/svn/trunk@14130 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd the chromium ninja builder to the list of trybots for a DEPS roll.
commit-bot@chromium.org [Thu, 10 Apr 2014 14:10:08 +0000 (14:10 +0000)]
Add the chromium ninja builder to the list of trybots for a DEPS roll.

R=robertphillips@google.com, borenet@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/227913005

git-svn-id: http://skia.googlecode.com/svn/trunk@14129 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorevert of 14111 to fix build
bensong@google.com [Thu, 10 Apr 2014 12:46:36 +0000 (12:46 +0000)]
revert of 14111 to fix build

git-svn-id: http://skia.googlecode.com/svn/trunk@14128 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 10 Apr 2014 03:05:44 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14127 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: don't bother clipping an empty clip down further
commit-bot@chromium.org [Thu, 10 Apr 2014 02:26:33 +0000 (02:26 +0000)]
SkRecordDraw: don't bother clipping an empty clip down further

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, fmalita@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231933003

git-svn-id: http://skia.googlecode.com/svn/trunk@14126 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of remove sprintf (https://codereview.chromium.org/230413005/)
commit-bot@chromium.org [Wed, 9 Apr 2014 23:38:57 +0000 (23:38 +0000)]
Revert of remove sprintf (https://codereview.chromium.org/230413005/)

Reason for revert:
Boo, hiss, SK_ARRAY_COUNT not defined in skia_launcher.cpp!

Original issue's description:
> remove sprintf
>
> Committed: http://code.google.com/p/skia/source/detail?r=14123

R=halcanary@google.com
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/232323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14125 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: skip draw ops when the clip is empty
commit-bot@chromium.org [Wed, 9 Apr 2014 23:30:28 +0000 (23:30 +0000)]
SkRecordDraw: skip draw ops when the clip is empty

   - Adds tests for SkRecordDraw's two main features: cull- and clip- based skipping.
   - Adds full SkCanvas semantic mode to SkRecorder, so it can be used as a target for SkRecordDraw.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231653002

git-svn-id: http://skia.googlecode.com/svn/trunk@14124 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove sprintf
commit-bot@chromium.org [Wed, 9 Apr 2014 23:22:44 +0000 (23:22 +0000)]
remove sprintf

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/230413005

git-svn-id: http://skia.googlecode.com/svn/trunk@14123 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReal fix for SK_API / Windows shared lib problems.
mtklein@google.com [Wed, 9 Apr 2014 22:54:57 +0000 (22:54 +0000)]
Real fix for SK_API / Windows shared lib problems.

Ben reviewed this over my shoulder, and we tested on his machine.

git-svn-id: http://skia.googlecode.com/svn/trunk@14122 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCleaned up the start page, added wait cursor, disabled Run button while waiting for...
commit-bot@chromium.org [Wed, 9 Apr 2014 22:54:02 +0000 (22:54 +0000)]
Cleaned up the start page, added wait cursor, disabled Run button while waiting for results.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14121 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSK_API for SkXfermode_opts_SSE2 so Chrome can initialize flattenables.
commit-bot@chromium.org [Wed, 9 Apr 2014 21:43:27 +0000 (21:43 +0000)]
SK_API for SkXfermode_opts_SSE2 so Chrome can initialize flattenables.

BUG=skia:2401
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231423003

git-svn-id: http://skia.googlecode.com/svn/trunk@14120 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoI got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have...
commit-bot@chromium.org [Wed, 9 Apr 2014 21:35:18 +0000 (21:35 +0000)]
I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header.

Also forgot one last place that referenced syscall_reporter.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14119 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement drawDRRect for GPU
commit-bot@chromium.org [Wed, 9 Apr 2014 21:26:11 +0000 (21:26 +0000)]
Implement drawDRRect for GPU

BUG=skia:2259
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/220233011

git-svn-id: http://skia.googlecode.com/svn/trunk@14118 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename kPMColor_SkColorType to kN32_SkColorType.
commit-bot@chromium.org [Wed, 9 Apr 2014 20:45:29 +0000 (20:45 +0000)]
Rename kPMColor_SkColorType to kN32_SkColorType.

The new name better represents what this flag means.

BUG=skia:2384
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/227433009

git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore SkPictureShader baselines.
fmalita@google.com [Wed, 9 Apr 2014 19:31:48 +0000 (19:31 +0000)]
More SkPictureShader baselines.

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/231563002

git-svn-id: http://skia.googlecode.com/svn/trunk@14116 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBaselines for the SkPictureShader GM.
fmalita@google.com [Wed, 9 Apr 2014 19:14:23 +0000 (19:14 +0000)]
Baselines for the SkPictureShader GM.

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/230443007

git-svn-id: http://skia.googlecode.com/svn/trunk@14115 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInitial code for webtry, a web application for allowing users to try out Skia.
commit-bot@chromium.org [Wed, 9 Apr 2014 18:59:44 +0000 (18:59 +0000)]
Initial code for webtry, a web application for allowing users to try out Skia.

Currently running at http://108.170.220.126:8000/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/228693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14114 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoenable developers to provide their own android toolchain
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:42 +0000 (18:57 +0000)]
enable developers to provide their own android toolchain

R=halcanary@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/227673003

git-svn-id: http://skia.googlecode.com/svn/trunk@14113 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjusts the bench expectations calculation to consider average value.
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:02 +0000 (18:57 +0000)]
Adjusts the bench expectations calculation to consider average value.

BUG=skia:2225
NOTRY=true
R=borenet@google.com
TBR=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/231513002

git-svn-id: http://skia.googlecode.com/svn/trunk@14112 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agono more callers of getTotalClip -- except in android
reed@google.com [Wed, 9 Apr 2014 18:47:28 +0000 (18:47 +0000)]
no more callers of getTotalClip -- except in android

git-svn-id: http://skia.googlecode.com/svn/trunk@14111 2bbb7eff-a529-9590-31e7-b0007b416f81