Marcel Hollerbach [Wed, 20 Mar 2019 07:34:33 +0000 (08:34 +0100)]
efl_con: fixup copy'n paste error
please see https://phab.enlightenment.org/D8411#151797, it appears here
was a copy and paste error. This fixes the ecore_con test suite
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8419
Lauro Moura [Wed, 20 Mar 2019 13:12:35 +0000 (14:12 +0100)]
efl: Add missing docs to parameters.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8422
Yeongjong Lee [Wed, 20 Mar 2019 11:45:00 +0000 (12:45 +0100)]
efl.pack_table: inherit efl.pack instead of efl.pack_linear
Summary:
>>! In T5301#110572, @jpeg wrote:
> Quick recap before I leave.
> ...
> ...
> - Pack interfaces - T5328
>
> Table does not need to inherit from "linear" (1d) layout: this brings unnecessary complexity, for a dubious use case.
We don't have linear layout policy of table(2d) layout. furthermore, i don't
think it will be clearly defined. it is enough for Efl.Pack_Table to support
`efl_pack` which work the same as `efl_pack_end`.
ref T5719, T5328
Test Plan:
- make
- elementary_test -to 'efl.ui.table'
- elementary_test -to 'efl.ui.table(linear api)'
Reviewers: zmike, woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, jpeg, #committers
Tags: #efl
Maniphest Tasks: T5719, T5328
Differential Revision: https://phab.enlightenment.org/D8420
Lauro Moura [Wed, 20 Mar 2019 10:26:49 +0000 (11:26 +0100)]
csharp: Remove missing doc warning by filling them.
Summary:
Added basic documentation for things that were missing.
Some other files are silent due to a pragma disabling CS1591. They
should be handled later.
Also, removed `Efl.Io.Positioner` from the blacklist as it is referenced
from the `Efl.Io.Reader.eos` event documentation.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: felipealmeida, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8370
Xavi Artigas [Wed, 20 Mar 2019 10:24:05 +0000 (11:24 +0100)]
Remove dead code
Xavi Artigas [Wed, 20 Mar 2019 09:47:22 +0000 (10:47 +0100)]
mono-docs: Use @since tags properly
Summary:
Only the number was being used, and in places were it should not be.
Now the Since version appears only in <summary> tags, with proper
context (Since EFL 1.22).
Test Plan: make && gendoc should produce DocFX pages which make more sense.
Reviewers: lauromoura, zmike, bu5hm4n
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8012
Jaehyun Cho [Wed, 20 Mar 2019 02:24:51 +0000 (11:24 +0900)]
eolian_mono: apply indentation of if scope
Mike Blumenkrantz [Tue, 19 Mar 2019 20:32:02 +0000 (16:32 -0400)]
efl_io_*: apply new event calling convention
Summary:
ref T7758
Depends on D8409
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8410
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:55 +0000 (16:31 -0400)]
efl_ui_focus_object: apply new event calling convention
Summary:
ref T7758
Depends on D8408
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8409
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:50 +0000 (16:31 -0400)]
evas: apply new event calling convention
Summary:
ref T7758
Depends on D8407
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8408
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:45 +0000 (16:31 -0400)]
efl_ui_tags: apply new event calling convention
Summary:
it appears that this event calling is a bit fishy, the value of the
second callback call was never set, i think the shrink flag here is what
we want to return here.
T7758
Depends on D8406
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8407
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:39 +0000 (16:31 -0400)]
efl_ui_win: apply new event calling convention
Summary:
ref T7758
Depends on D8405
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8406
Marcel Hollerbach [Tue, 19 Mar 2019 20:31:34 +0000 (16:31 -0400)]
efl_ui_focus_manager_sub: apply new event calling convention
Summary: ref T7758
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7758
Differential Revision: https://phab.enlightenment.org/D8405
Marcel Hollerbach [Tue, 19 Mar 2019 20:30:19 +0000 (16:30 -0400)]
efl_ui: rename select and unselected of efl_ui_selectable
Summary:
this was conflicting with a model event. Prefixing it with "item,"
resolves this, and describes better what it does.
Depends on D8413
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8414
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:45 +0000 (16:29 -0400)]
elm: do not use eo events here
Summary:
we want to rename it, and this would break legacy behaviour, so better
this way.
Depends on D8412
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8413
Change-Id: Iab72a30628e5864c64e7059434f11e19d5576c05
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:39 +0000 (16:29 -0400)]
Revert "efl_ui_selectable: namespace events to avoid conflicts"
Summary:
This reverts commit
f629f11bedad7b137b012d36102ad5bb1f2b4b4f.
This breaks legacy events. As the selected event is used in legacy
widgets. Also this commits mixed up two different concepts, selection in
a entry etc. and selection of a item.
Depends on D8411
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8412
Change-Id: Ia3b3ce930bb5b46dfa4a2beaa26ddb201d494f02
Marcel Hollerbach [Tue, 19 Mar 2019 20:29:34 +0000 (16:29 -0400)]
efl_net: resolve cases where we passed something as event_info
Summary: but the event was annotated to *not* contain any event_info.
Reviewers: cedric, segfaultxavi, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8411
Marcel Hollerbach [Tue, 19 Mar 2019 20:28:10 +0000 (16:28 -0400)]
efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8415
Stefan Schmidt [Tue, 19 Mar 2019 19:10:33 +0000 (20:10 +0100)]
release: Update NEWS and bump version for 1.22.0-beta2 release
Yeongjong Lee [Fri, 15 Mar 2019 10:52:32 +0000 (10:52 +0000)]
efl_ui_text_alert_popup: use correct theme klass name
text_alert_popup is not scroll_alert_popup.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8364
Mike Blumenkrantz [Mon, 18 Mar 2019 18:13:39 +0000 (14:13 -0400)]
elm_code: add theme alias for layout group
with the rename of this (beta) widget, the efl/ group name is set so
add this to the theme for now until more work can be done here to resolve
the rest of the theme namespacing issues which will only be an issue
if the widget is ever made stable
ref T7713
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8393
Xavi Artigas [Tue, 19 Mar 2019 15:50:13 +0000 (16:50 +0100)]
Revert "efl_ui_widget: resolve warning about multiple defines"
This reverts commit
9012742f9a6e0ac09f34b7df23b1ac8d166239e1.
I landed this too hastily.
Marcel Hollerbach [Tue, 19 Mar 2019 15:39:59 +0000 (16:39 +0100)]
efl_ui_widget: resolve warning about multiple defines
Summary:
the difference here is, that the macro before did not print ERR's the
one now does. Hence this commit remove two error messages.
Depends on D8394
Reviewers: zmike, segfaultxavi, cedric, devilhorns
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8395
Lauro Moura [Tue, 19 Mar 2019 14:50:50 +0000 (15:50 +0100)]
csharp: rename add/remove event handler
Summary:
Conform to C# API conventions.
Ref T7752
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7752
Differential Revision: https://phab.enlightenment.org/D8396
Christopher Michael [Tue, 19 Mar 2019 12:57:59 +0000 (08:57 -0400)]
eldbus: Fix resource leak
Summary:
Coverity reports that we leak 'data' here (which can happen if we
error on 'eina_value_dup(value)'). Iniitalize 'data' to NULL, and add a
'free' call to cleanup 'data' before we return a rejected future.
Fixes Coverity CID1399097
@fix
Depends on D8350
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8352
Christopher Michael [Tue, 19 Mar 2019 12:33:01 +0000 (08:33 -0400)]
efl_ui_widget: Remove duplicate definition of ELM_WIDGET_DATA_GET
Patch
28400e3260b3c6af56ce6b added a define for ELM_WIDGET_DATA_GET
which is available for all widgets so we do not need to redefine it
here.
Christopher Michael [Tue, 19 Mar 2019 12:31:03 +0000 (08:31 -0400)]
elm_entry: Add missing EINA_UNUSED
'sd' is an unused parameter here so add missing EINA_UNUSED
Christopher Michael [Mon, 18 Mar 2019 19:19:21 +0000 (15:19 -0400)]
elementary: Use efl_data_scope_safe_get when trying to get widget data
As per bu5hm4n, these macros should be using efl_data_scope_safe_get
when trying to get widget data
Christopher Michael [Mon, 18 Mar 2019 19:13:36 +0000 (15:13 -0400)]
elementary: Add ELM_WIDGET_DATA_GET macro
There are cases, such as
2abe5ad9bc6d30f0c29381dca7e where we do not
always want to return if we fail to get the elm widget data (as we may
have to cleanup leaks, etc). As such, add a macro we can call which
will just try to fetch the elm_widget data.
Ali Alzyod [Mon, 18 Mar 2019 18:40:10 +0000 (19:40 +0100)]
Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string
Summary:
Fix issue where **_entry_has_new_line** will not detect '<br>' or '<ps>' inside markup text as new lines indicators.
this functionlity effect following public function:
**elm_entry_single_line_set()**
Reviewers: woohyun, bowonryu, ManMower, cedric, raster, segfaultxavi
Reviewed By: bowonryu, segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8323
Christopher Michael [Mon, 18 Mar 2019 18:47:58 +0000 (14:47 -0400)]
elm_focus_legacy: Fix resource leaks
Summary:
Coverity reports 2 resource leaks here because old_chain & new_chain
are never freed if we fail to return widget data. Use just
ELM_WIDGET_DATA_GET, manually check for valid 'ppd' and if false we
can just break out of the for loop here.
Fixes Coverity CID1399096, CID1399095
@fix
Depends on D8352
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric, bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8353
Yeongjong Lee [Mon, 18 Mar 2019 12:50:19 +0000 (08:50 -0400)]
efl_ui_layout: call efl_del instead of efl_unref when text part does not exist
Summary:
Because `efl_isa` doesn't call _efl_object_call_end, the part object is not
removed. it occurs a bunch of efl_unref error message.
Test Plan:
1. elementary_test -to 'efl.ui.box'
2. exit window.
3. check there is no efl_unref error message.
Reviewers: zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8385
Marcel Hollerbach [Mon, 18 Mar 2019 11:45:42 +0000 (12:45 +0100)]
examples_checks: add more configurations to how to run examples
Summary:
this adds the options, which are needed to execute those examples.
Depends on D8379
Reviewers: cedric, zmike, stefan_schmidt, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8380
Marcel Hollerbach [Mon, 18 Mar 2019 11:41:19 +0000 (12:41 +0100)]
edje-multisense: add the theme file
Summary:
the theme file was forgotten here, and not probebly build
Depends on D8378
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8379
Marcel Hollerbach [Mon, 18 Mar 2019 11:37:28 +0000 (12:37 +0100)]
edje-swallow2: differeniate between build dir and source dir
Summary:
the source dir is used for the bubble.png file, the rest is coming from
the actaull build dir
Depends on D8377
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8378
Marcel Hollerbach [Mon, 18 Mar 2019 11:30:34 +0000 (12:30 +0100)]
inwin_example: shot can never be the preferend engine
Summary:
"shot" is just the content from ELM_DISPLAY, but never the prefered
engine. Additionally, prefered engine can be NULL, which will cause a
SEGV. This now just uses the getenv to check if we run in the shot
engine.
Depends on D8376
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8377
Marcel Hollerbach [Mon, 18 Mar 2019 11:19:16 +0000 (12:19 +0100)]
index_example_02: fix index example
Summary:
If this is not initialized, then the reuse function will be != NULL
which causes a SEGV
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8376
Daniel Kolesa [Mon, 18 Mar 2019 11:13:41 +0000 (12:13 +0100)]
efl: remove EFL_EO_API_SUPPORT macro
Summary:
Since we're now going to be shipping some eo classes as stable,
there is no point in keeping the eo api behind a macro, and it
should be enabled by default. Another case is beta classes, but
those are behind the EFL_BETA_API_SUPPORT guard.
This also changes includes around the place where things are
clearly broken (such as an included header needing something
from another header but that other header being guarded, notably
efl_ui_widget.h needing focus manager but focus manager being
behind beta in Elementary.h)
Reviewers: zmike, cedric, bu5hm4n, stefan_schmidt, segfaultxavi
Reviewed By: cedric, segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8322
Change-Id: I2161b4b1aa388f968641fa6b0d318597bd30d964
Marcel Hollerbach [Sun, 17 Mar 2019 14:30:23 +0000 (15:30 +0100)]
elm_focus: document that focus_region_show_mode more
it appears that this API is only implemented in Elm_Gengrid, this patch
adds documentation for this.
ref D8286
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8383
Lauro Moura [Sun, 17 Mar 2019 15:09:20 +0000 (16:09 +0100)]
csharp: Rename register_event_proxies.
Summary:
To better adhere to C# conventions and state it is for generated code
only.
Ref T7702
Reviewers: vitor.sousa, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7702
Differential Revision: https://phab.enlightenment.org/D8369
Lauro Moura [Sun, 17 Mar 2019 14:59:38 +0000 (15:59 +0100)]
cshar: Remove unused variables.
Summary:
The nativeInherit field was replaced by using a C# attribute to declare
the native class.
Ref T7702
Reviewers: segfaultxavi, vitor.sousa
Reviewed By: segfaultxavi, vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7702
Differential Revision: https://phab.enlightenment.org/D8368
Christopher Michael [Fri, 15 Mar 2019 16:57:18 +0000 (12:57 -0400)]
efl_ui_focus_manager_calc: Fix resource leaks
Summary:
Coverity reports that we leak old_chain & chain variables here if we return.
Add an eina_array_free for both to clean this up.
Fixes Coverity CID1396984,CID1396965
@fix
Depends on D8353
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8355
Jiyoun Park [Thu, 14 Mar 2019 08:53:50 +0000 (08:53 +0000)]
evas_gl_generic: fix wrong gl context set
example:
...
im=evas_object_image_add()
evas_gl_surface_create
...
evas_object_image_native_surface_set(im, xx)-> MAIN CONTEXT
evas_gl_make_current -> CONTEXT A
.....
evas_object_image_size_set(im, x,x) ->WRONG CONTEXT A
evas_object_image_size_set of image have native_surface finally calls
eng_image_size_set function of gl_generic.
eng_image_size_set cannot get the proper context related with
evas_gl_common_image_native_enable.
It ruined gl context and texture of main context has gone wrong.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8338
Christopher Michael [Fri, 15 Mar 2019 16:14:18 +0000 (12:14 -0400)]
eldbus: Fix dereference after null check
Summary:
Coverity reports we are passing NULL variable 'properties' to
eina_array_pop here which dereferences it. Wrap the 'end' block in an
if which checks for valid 'properties' variable
Fixes Coverity CID1399422
@fix
Depends on D8350
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8351
Christopher Michael [Fri, 15 Mar 2019 16:14:05 +0000 (12:14 -0400)]
efl_ui_text: Fix resource leak
Summary:
Coverity reports a resource leak here. When we return due to invalid
selection, we should free the 'ldata' that we previously allocated
Fixes Coverity CID1396998
@fix
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8320
Lauro Moura [Fri, 15 Mar 2019 14:30:24 +0000 (11:30 -0300)]
csharp: Support Efl.Class for interfaces
Summary:
The `GetEflClassStatic` method for interface is in their Concrete
sidekick.
Previously, passing a valid Eo interface as a type caused the binding to
complain that `Type is not an Efl.Object`.
Test Plan: run test case
Reviewers: vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8360
Christopher Michael [Fri, 15 Mar 2019 12:58:17 +0000 (08:58 -0400)]
efreet: Fix resource leak
Summary:
Coverity reports that we leak 'exec' here when we return. Add
IF_FREE(exec) to remove the leak.
Fixes Coverity CID1399090
@fix
Depends on D8353
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8354
Christopher Michael [Fri, 15 Mar 2019 12:58:04 +0000 (08:58 -0400)]
efl_ui_win: Fix dereference null return value
Summary:
Coverity reports efl_data_scope_safe_get returns NULL here (checked
273 out of 285 times). Add an EINA_SAFETY check here before trying to
use 'sd'.
Fixes Coverity CID1399425
@fix
Depends on D8348
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8349
Christopher Michael [Fri, 15 Mar 2019 12:57:54 +0000 (08:57 -0400)]
efl_ui_win: Fix dereference null return
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check before trying
to use 'sd'.
Fixes Coverity CID1399426
@fix
Depends on D8347
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8348
Christopher Michael [Fri, 15 Mar 2019 12:57:44 +0000 (08:57 -0400)]
efl_ui_win: Fix dereference null return
Summary:
Coverity reports that efl_data_scope_safe_get returns NULL here
(checked 273 out of 285 times). Add an EINA_SAFETY check here before
trying to use 'sd'.
Fixes Coverity CID1399427
@fix
Depends on D8346
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8347
Christopher Michael [Fri, 15 Mar 2019 12:57:34 +0000 (08:57 -0400)]
efl_ui_win: Fix dereference null return value
Summary:
Coverity reports efl_data_scope_safe_get returns NULL here (checked
273 out of 285 times). Add an EINA_SAFETY check here for a null return.
Fixes Coverity CID1399428
@fix
Depends on D8345
Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8346
Cedric BAIL [Fri, 15 Mar 2019 10:42:41 +0000 (11:42 +0100)]
eo: efl_object_legacy_only_event_description_get is an internal only function, make it so.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8361
Lauro Moura [Fri, 15 Mar 2019 09:52:41 +0000 (10:52 +0100)]
csharp: Remove uneeded legacy event declaration.
Reviewers: cedric, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8330
Lauro Moura [Fri, 15 Mar 2019 09:35:10 +0000 (10:35 +0100)]
meson: Enable generation of C# docs.
Summary:
In order to correctly install the xml file alongside the dll, a install
script is used to work around meson's limitation of tracking files
generated by library() other than the dll.
Fixes T7722
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7722
Differential Revision: https://phab.enlightenment.org/D8331
Mike Blumenkrantz [Thu, 14 Mar 2019 19:14:19 +0000 (20:14 +0100)]
ci: add missing double quote for osx autotools
Summary:
so there I was, out at the pub after a hard release cycle, drinking
GNU's finest, and a " comes over and challenges me to a duel--
editors at 50pt. the " cheats and gets me right in the repo before
the countdown ends and then I'm out cold.
I wake up the next day with CI (still) failing, hundreds of pings on IRC
asking where I've been, and my refrigerator is somehow filled with ethernet
cables (cat7) which I have no memory of purchasing. my computer has doodles
in permanent marker all over the screen, and my cat is somehow stuck in a
ceiling vent which I also have no memory of seeing. also this isn't my house.
I leave the building, which turns out to be a fast food franchise a few blocks
away from my gym, and the cops roll up (https://i.imgur.com/JnOI4Jz.gifv)
asking to see some identification. I show them my credentials (ssh RSA4096),
and they cuff me. I'm under arrest for failing to close a double quote and
submitting a patch which impersonated a fix to a failing CI job.
the moral of this story is to always reread your patches and make sure you've
matched up all your punctuation.
ref D8340
Reviewers: devilhorns, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8356
Marcel Hollerbach [Thu, 14 Mar 2019 18:26:34 +0000 (14:26 -0400)]
elementary: add compile checks for the efl_ui.h header
Summary:
we should check if the header actaully compiles without the beta
defines.
Depends on D8342
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8343
Marcel Hollerbach [Thu, 14 Mar 2019 18:26:20 +0000 (14:26 -0400)]
meson: be a bit more helpfull when it comes to bindings
Summary:
for now meson would have just used the order that you pass in via
-Dbindings=mono,cxx. However this leads to bugs, as cxx for example must
be declared before mono can be declared. This fixes this error by
forcing a order.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8341
Xavi Artigas [Thu, 14 Mar 2019 18:15:28 +0000 (19:15 +0100)]
docfx: Hide *Concrete classes from docs
Ref T7702
Mike Blumenkrantz [Thu, 14 Mar 2019 16:43:33 +0000 (12:43 -0400)]
autotools: add option to enable eo file install
Summary:
eolian is not stable so these files should not be distributed by default
in order to discourage relying on something which may break later
fix T7676
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7676
Differential Revision: https://phab.enlightenment.org/D8339
Marcel Hollerbach [Thu, 14 Mar 2019 16:43:51 +0000 (12:43 -0400)]
build: add a option to disable eo file installation
Summary:
this is done because .eo files are not stable, and in order to stop
people depending on it, its better for now to disable the installation
of them for now.
ref T7676
Reviewers: stefan_schmidt, cedric, zmike, devilhorns
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7676
Differential Revision: https://phab.enlightenment.org/D7897
Mike Blumenkrantz [Thu, 14 Mar 2019 15:53:50 +0000 (11:53 -0400)]
ci: force osx libffi dep to be found
this is also really, really stupid.
ref D8305
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D8340
Yeongjong Lee [Thu, 14 Mar 2019 15:11:32 +0000 (11:11 -0400)]
efl_ui_layout: fix elm_layout_text_set behavior
Summary:
Since commit
649433560b5b, elm_layout_text_set didn't work on some widgets.
This patch fixes invisible text issues.
Test Plan:
1. make check
2. elementary_test -to 'popup'
Reviewers: zmike, segfaultxavi, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, herb, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8326
Change-Id: I76bf8b4c615a90b691e4ed43fdcc10dd7d01f219
Christopher Michael [Thu, 14 Mar 2019 11:22:54 +0000 (07:22 -0400)]
ecore_con: Fix dereferencing of null pointer
Summary:
Coverity reports that 'svr' might be NULL here, so we should check it
is valid before trying to use it.
Fixes Coverity CID1396990
@fix
Depends on D8320
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8321
Christopher Michael [Thu, 14 Mar 2019 11:22:44 +0000 (07:22 -0400)]
efl_ui_grid: Fix dereferencing null pointer
Summary:
Coverity reports EFL_UI_GRID_ITEM_DATA_GET can return NULL (checked
273 out of 281 times). As such, we should verify that 'id' is not NULL
here before trying to dereference it.
Fixes Coverity CID1397000
@fix
Depends on D8318
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8319
Christopher Michael [Thu, 14 Mar 2019 11:22:26 +0000 (07:22 -0400)]
efl_ui_datepicker: Fix uninitialized scalar value
Summary:
Coverity reports field t.tm_sec is unitialized when calling
efl_datetime_manager_value_set, so this patch uninitializes it to 0.
Fixes Coverity CID1397006
@fix
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8318
Marcel Hollerbach [Wed, 13 Mar 2019 16:15:45 +0000 (17:15 +0100)]
meson: fix subdir in the installation
we did a completly wrong thing here, and it only worked by accident.
We passed a absolut path into a parameter where only a number should be
passed. This is now fixed.
This fixes meson build with meson-0.50 and bindings enabled
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8328
Marcel Hollerbach [Wed, 13 Mar 2019 15:59:17 +0000 (16:59 +0100)]
examples_check: fix for meson-0.50
meson changed behaviour ... the json output is slightly different, the
paths are now absolut. This fixes the behaviour and makes it work with
new and old versions.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8327
Yeongjong Lee [Mon, 11 Mar 2019 21:21:22 +0000 (21:21 +0000)]
ui.widget: fix theme_apply working in sub_object_add
It seems that theme_apply in sub_object_add haven't worked since commit
f6fa1ef6120fdebcdaf1568674c48b9d17f76f64.
scale, theme property will be set properly when the parent is changed.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8283
Marcel Hollerbach [Mon, 11 Mar 2019 20:57:45 +0000 (21:57 +0100)]
Revert "ui.widget: fix theme_apply working in sub_object_add"
This only works with a new libcheck, but not with a old one, revisiting
it.
This reverts commit
da0ff534716774b35a98c359e8c7fd7bdde7a3d2.
Yeongjong Lee [Mon, 11 Mar 2019 09:44:16 +0000 (09:44 +0000)]
ui.widget: fix theme_apply working in sub_object_add
It seems that theme_apply in sub_object_add haven't worked since commit
f6fa1ef6120fdebcdaf1568674c48b9d17f76f64.
scale, theme property will be set properly when the parent is changed.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8283
Marcel Hollerbach [Sun, 3 Mar 2019 15:30:53 +0000 (16:30 +0100)]
build: do not reply on header checking libinotify.h
but rather use the sys_bsd flag. The reason why relying on the header
existance is bad, is that bsd decided to install this header, with the
essential difference, that on bsd we require to link against libinotify,
which makes the compilation fail.
ref T7710
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8093
Yeongjong Lee [Mon, 11 Mar 2019 00:59:07 +0000 (00:59 +0000)]
ui.widget: add exception handling code and unit test of sub_object_add/del function
Add missing exception check code with unit test.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8282
Christopher Michael [Tue, 12 Mar 2019 14:22:26 +0000 (10:22 -0400)]
efl_ui_stack: Fix dereference null return value
Coverity reports that efl_data_scope_safe_get returns NULL here (273
out of 281 times). _end_anim dereferences pd directly, so we should
check for a valid 'pd' before calling _end_anim function.
Fixes Coverity CID1399082
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8315
Christopher Michael [Tue, 12 Mar 2019 14:15:00 +0000 (10:15 -0400)]
evas_device: Fix dereferencing null pointer
Coverity reports that 'pos' could be null here and we are potentially
dereferencing a NULL pointer, so lets add a check for 'pos' here
before trying to use it.
Fixes Coverity CID1399091
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8313
Christopher Michael [Tue, 12 Mar 2019 14:11:21 +0000 (10:11 -0400)]
efl_ui_selection_manager: Fix unchecked return value
This patch fixes an issue where the return value from ecore_x_init is
not checked. If we fail to initialize ecore_x, then we should print
out an error and get out.
Fixes Coverity CID1399092
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8312
Christopher Michael [Tue, 12 Mar 2019 14:07:26 +0000 (10:07 -0400)]
efl_core_command_line: Fix dereference before NULL check
This patch fixes an issue detected by Coverity where
pd->string_command is dereferenced before a NULL check.
Fixes Coverity CID1399098
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8311
Christopher Michael [Tue, 12 Mar 2019 13:45:18 +0000 (09:45 -0400)]
efl_core_command_line: Fix dereference before null check
Coverity reports a dereference before NULL check here. In the for
loop, we are NULL checking 'array', however it has already been
dereferenced before the 'for' loop in eina_array_new above. This patch
fixes the issue by NULL checking 'array' before we ever try to use it.
Fixes Coverity CID1399083
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8307
Yeongjong Lee [Tue, 12 Mar 2019 07:14:06 +0000 (07:14 +0000)]
elm_conform: remove duplicated constructor call
It is duplicated in commit
ccbc27f24da1f6fd1494f478f36359aaf1502dc2.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8303
Vincent Torri [Wed, 13 Mar 2019 13:53:17 +0000 (09:53 -0400)]
eina_error: On Windows strerror_s() is the same than POSIX strerror_r()
Summary: strerror_r() does not exist on Windows, but strerror_s() does
Test Plan: compilation
Reviewers: cedric, bu5hm4n, zmike
Reviewed By: zmike
Subscribers: zmike, bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8279
Christopher Michael [Tue, 12 Mar 2019 14:18:17 +0000 (10:18 -0400)]
efl_ui_widget_common: Fix potential resource leak
Coverity reports that we potentially leak the storage of
'tree_iterator' here because we allocate the space for it, but
potentially juse return due to use of ELM_WIDGET_DATA_GET_OR_RETURN.
To fix this, just move the allocation to after the above macro is
called.
Fixes Coverity CID1399088
@fix
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8314
Christopher Michael [Tue, 12 Mar 2019 13:57:33 +0000 (09:57 -0400)]
elm_config: Fix unchecked return value
Small patch to check the return value of ecore_file_cp. Coverity
reports this as an unchecked return value, so let's just add a simple
check here.
Fixes Coverity CID1399101
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8309
Christopher Michael [Tue, 12 Mar 2019 13:51:25 +0000 (09:51 -0400)]
efl_core_command_line: Fix resource leak
Small patch to fix a resource leak. Variable 'command' goes out of
scope here which causes a leak.
Fixes Coverity CID1399085
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8308
Christopher Michael [Tue, 12 Mar 2019 13:41:00 +0000 (09:41 -0400)]
efl_core_command_line: Fix logically dead code
Small patch to remove logically dead code. Coverity reports that
execution cannot reach the expression 0U inside this for statement. At
this point in execution, 'array' cannot be NULL, so checking for its
existence is a logically dead check.
Fixes Coverity CID1399106
@fix
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8306
Christopher Michael [Tue, 12 Mar 2019 15:31:51 +0000 (11:31 -0400)]
eolian: Fix resource leak
Summary:
Small patch to fix a resource leak detected by Coverity. Coverity
reports that 'refls' going out of scope leaks the storage it points
to, so let's free it before we leave the function.
Fixes Coverity CID1399099
Depends on D8309
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8310
Mike Blumenkrantz [Tue, 12 Mar 2019 14:33:31 +0000 (10:33 -0400)]
ci: force osx libffi dep to be found
this is really, really stupid.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D8305
Christopher Michael [Tue, 12 Mar 2019 14:59:04 +0000 (10:59 -0400)]
eo: Fix missing varags cleanup
Summary:
Coverity reports that va_end is never called for p_list when we error
out of this function. This patch adds a missing va_end before we error
out of here.
Fixes Coverity CID1399080
@fix
Depends on D8315
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8316
Stefan Schmidt [Tue, 12 Mar 2019 13:38:11 +0000 (14:38 +0100)]
release: Update NEWS and bump version for 1.22.0-beta1 release
Mike Blumenkrantz [Tue, 12 Mar 2019 13:17:23 +0000 (14:17 +0100)]
Efl_Core.h include Efl.h unconditionally
Summary: this was added by accident in D8244
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8304
Stefan Schmidt [Tue, 12 Mar 2019 12:27:22 +0000 (13:27 +0100)]
examples: bg_cxx: disable win.background in example
Since commit
ceb4c04d3b8f8eb94d63174b7b6f43641ea508a8 the parts block in
efl.ui.widget is disabled which leads to compile errors of the example.
Stefan Schmidt [Tue, 12 Mar 2019 11:48:33 +0000 (12:48 +0100)]
tests: eolian_cxx: make sure we add beta_class.eo to dist
Since commit
2a003420f83134331c8b404df1905cba538cfad6 we need
beta_class.eo for the eolain cxx test suite. I never was added to the
files for dist, thus breaking distcheck.
Jaehyun Cho [Tue, 12 Mar 2019 05:42:28 +0000 (14:42 +0900)]
efl_ui_navigation_layout: fix bar value to be Efl.Ui.Layout_Base
Since Efl.Ui.Layout is renamed to Efl.Ui.Layout_Base, the bar value is
fixed to be Efl.Ui.Layout_Base.
Jaehyun Cho [Tue, 12 Mar 2019 05:39:06 +0000 (14:39 +0900)]
Efl_Ui.h: move stack and navigation headers to Efl_Ui.h
The following efl ui headers move from Elementary.h to Efl_Ui.h.
efl_ui_navigation_bar.eo.h
efl_ui_navigation_bar_part.eo.h
efl_ui_navigation_bar_part_back_button.eo.h
efl_ui_navigation_layout.eo.h
efl_ui_stack.eo.h
Marcel Hollerbach [Tue, 26 Feb 2019 14:38:28 +0000 (15:38 +0100)]
efl_ui_widget: refactor sub_object handling
efl_ui_widget has a property called widget_parent. The setter for this
function is called is exactly once, and this is within the constructor,
to a value which is not even set to the actaul field parent_obj. Which
shows, that in the sitation right now, the setter of the property is a
bit disconnected and lags some real aspects.
As we are heading towards eo-api stabilization we should beat some sense
into this setter, as people using our classes might overwrite the setter
and except calls to it, whenever the widget_parent is changed, and
implementation as in elm_menu show that this might makes sense sometime.
In order to achive this, the sub_object registering code of elm is
adjusted a bit.
sub_object_add/del is now used to differenciate between evas objects and
efl.ui.widget objects as subobject. In case of a widget, the
widget_parent of this object is set, most of the widget specific code is
then executed in the actaul setter. In case of an evas object, the
parent reference is added. In the end both end up in the subobject
children list. The later is also a requirement for widget_parent_set to
be successfull.
ref T7553
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8031
Change-Id: I32ee38e867668e8fef486dc4807d42cc2c3a589c
Yeongjong Lee [Tue, 12 Mar 2019 04:15:49 +0000 (13:15 +0900)]
elm_object: Restore child_can_focus
child_can_focus is needed for legacy focus.
@tizen_fix
Change-Id: Ifa36e5065af4b0a9d7ccc9983bae0be144d4daa2
Wonki Kim [Tue, 2 Apr 2019 02:25:29 +0000 (11:25 +0900)]
meson: fix typo for elementary meson definition
there is a typo error on a meson defintion for elementary
this patch fixes it
Change-Id: Ie263b82f87da6f8d4f6b7f8298dab380b0042b5c
Wonki Kim [Wed, 27 Mar 2019 14:18:33 +0000 (10:18 -0400)]
entry: move a point to do 'auto_save' to another place
Summary:
By reworking on efl_file, logic flow for entry has been changed.
and it causes autosave making a file that is passed to elm_entry_file_set empty.
Test Plan:
1. call elm_entry_file_set for a file.
2. check the file is not empty after calling the function.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8362
Change-Id: I96a4c9602e9a3e74c2c3cec24e4b5f3e5a1dbc13
Hermet Park [Mon, 1 Apr 2019 10:40:53 +0000 (19:40 +0900)]
Revert "entry: move a point to do 'auto_save' to another place"
This reverts commit
01225c04d2cc94feceabe317b4338c11c9ea7e45.
Official patch will be cherry-picked instead.
Change-Id: Ieead7bc19595efdb7e059e5c16e683bb0a27d5be
Wonki Kim [Mon, 1 Apr 2019 07:58:16 +0000 (16:58 +0900)]
meson: fix meson definitions for keeping compat
this patch fixes meson definitions to keep it making same output like autotools
Change-Id: I8d72d9ac1267f1ddd278d4c57159e95455739451
Radoslaw Cybulski [Fri, 29 Mar 2019 11:58:17 +0000 (12:58 +0100)]
Fix for not working atspi
Some ATSPI flags were missing in elm_states_to_atspi_state table,
which prevent HIGHLIGHTABLE and HIGHLIGHTED flags from showing up.
Which prevented screen-reader / universal switch from operating on
anything completely.
Change-Id: I8eee2cf19897d064a49b632786821110933836b7
Radoslaw Cybulski [Tue, 26 Mar 2019 13:04:16 +0000 (14:04 +0100)]
fix for crash in _sort_items function due to sorting NULL pointers
Fixes issue in TDAF-835 on fridges. Calling elm_gengrid_clear would
cause crash due to sorting atspi elements. Comparision function would
get two NULLs and trying to derefence them would issue a crash
Change-Id: Ib1771503fcc467c26f3c550188ea65eaeaf495df
projects / platform / upstream / efl.git / log