platform/upstream/coreclr.git
7 years agoDisable tests to get jit32 jobs green
jashoo [Fri, 12 Aug 2016 17:25:09 +0000 (10:25 -0700)]
Disable tests to get jit32 jobs green

See issues #6720, #6718, #6714 for more information

7 years agoMerge pull request #6637 from smile21prc/coreclr-perf
smile21prc [Thu, 11 Aug 2016 17:45:10 +0000 (10:45 -0700)]
Merge pull request #6637 from smile21prc/coreclr-perf

Automate the perf data collection for JIT CodeQuality benchmarks on Windows.

7 years agoMerge pull request #6657 from gkhanna79/UpdateVer
Gaurav Khanna [Thu, 11 Aug 2016 16:27:01 +0000 (09:27 -0700)]
Merge pull request #6657 from gkhanna79/UpdateVer

Update package versions to 1.1.0

7 years agoARM: disable stack unwinding using DWARF (#6700)
hqueue [Thu, 11 Aug 2016 16:21:41 +0000 (01:21 +0900)]
ARM: disable stack unwinding using DWARF (#6700)

libunwind for ARM does not interpret ARM vfpv3/NEON
registers in DWARF format correctly.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years agoMerge pull request #6699 from dotnet-bot/UpdateDependencies20160811052348
Gaurav Khanna [Thu, 11 Aug 2016 13:43:38 +0000 (06:43 -0700)]
Merge pull request #6699 from dotnet-bot/UpdateDependencies20160811052348

Updating External dependencies to beta-24411-00

7 years agoMerge pull request #6691 from ramarag/ResolveWorkerChainLookupAsmStubFix
Rama krishnan Raghupathy [Thu, 11 Aug 2016 08:26:51 +0000 (01:26 -0700)]
Merge pull request #6691 from ramarag/ResolveWorkerChainLookupAsmStubFix

Preserving ResolveCacheElem in X9

7 years agoUpdating External dependencies to beta-24411-00
dotnet-bot [Thu, 11 Aug 2016 05:23:48 +0000 (05:23 +0000)]
Updating External dependencies to beta-24411-00

7 years agoMerge pull request #6285 from JosephTremoulet/LenProp
Joseph Tremoulet [Thu, 11 Aug 2016 00:16:31 +0000 (20:16 -0400)]
Merge pull request #6285 from JosephTremoulet/LenProp

Propagate known array lengths to more places

7 years agoPreserving ResolveCacheElem in X9
Rama Krishnan Raghupathy [Wed, 10 Aug 2016 22:02:35 +0000 (15:02 -0700)]
Preserving ResolveCacheElem in X9

7 years agoUpdate Arm32 package version reference
Gaurav Khanna [Wed, 10 Aug 2016 21:58:00 +0000 (14:58 -0700)]
Update Arm32 package version reference

7 years agoAutomate the perf data collection for JIT CodeQuality benchmarks on Windows.
Smile Wei [Wed, 3 Aug 2016 22:20:15 +0000 (15:20 -0700)]
Automate the perf data collection for JIT CodeQuality benchmarks on Windows.

Fix a quote.

7 years agoPropagate known array lengths to more places
Joseph Tremoulet [Thu, 23 Jun 2016 20:21:13 +0000 (16:21 -0400)]
Propagate known array lengths to more places

Earlyprop limits its propagation of array lengths to blocks marked
BBF_HAS_INDX, for throughput reasons.  The importer sets that flag on
blocks that store/load array elements, but not blocks that simply extract
an array's length.  This change renames the flag to BBF_HAS_IDX_LEN, and
updates the importer to set it also on blocks with ldlen operations.  This
change also updates fgOptWhileLoop to propagate the flag when it
copies such an expression as part of a zero-trip test.

Fixes #2325.

7 years agoMerge pull request #6682 from JosephTremoulet/ConstantIndex
Joseph Tremoulet [Wed, 10 Aug 2016 20:30:53 +0000 (16:30 -0400)]
Merge pull request #6682 from JosephTremoulet/ConstantIndex

Update FieldSeq annotations in EarlyProp

7 years agoMerge pull request #6671 from gkhanna79/FixLFAN
Gaurav Khanna [Wed, 10 Aug 2016 19:24:33 +0000 (12:24 -0700)]
Merge pull request #6671 from gkhanna79/FixLFAN

Fix LoadFromAssemblyName to invoke fallback context

7 years agoMerge pull request #6606 from rahku/arm64todo
Rahul Kumar [Wed, 10 Aug 2016 18:47:47 +0000 (11:47 -0700)]
Merge pull request #6606 from rahku/arm64todo

ARM64: Fix for ARM64TODO

7 years agoARM64: Fix for ARM64TODO
Rahul Kumar [Thu, 4 Aug 2016 18:43:21 +0000 (11:43 -0700)]
ARM64: Fix for ARM64TODO

7 years agoMerge pull request #6683 from jashook/remove_unreachable_code
Jarret Shook [Wed, 10 Aug 2016 17:48:49 +0000 (10:48 -0700)]
Merge pull request #6683 from jashook/remove_unreachable_code

Fix unreachable code in flowgraph

7 years agoAdd StackCrawl reference marker to each of the Assembly.Load implementations.
Gaurav Khanna [Wed, 10 Aug 2016 16:26:04 +0000 (09:26 -0700)]
Add StackCrawl reference marker to each of the Assembly.Load implementations.

7 years agoFix unreachable code in flowgraph
jashoo [Wed, 10 Aug 2016 16:19:53 +0000 (09:19 -0700)]
Fix unreachable code in flowgraph

There is debugging information that is expected to be printed; however,
unreachable because the function returns before printing under debug.

Fixed by moved the return past the debug log.

7 years agoImprove Enum.ToString performance (#6645)
Ben Adams [Wed, 10 Aug 2016 15:17:37 +0000 (16:17 +0100)]
Improve Enum.ToString performance (#6645)

Reduces allocations by 66%; increases performance by 600% (x7)

With these changes ToString no longer boxes the value and doesn't create an empty array for `CustomAttributeRecords` when the enum is not flagged; also caches whether the enum is flagged.

It still boxes the enum to Enum to make the ToString virtual call however.

Using the @jkotas enummark :wink:

```csharp
enum MyEnum { One, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten };
public static void Main(string[] args)
{
    (MyEnum.Seven).ToString();
    int start = Environment.TickCount;
    for (int i = 0; i < 10000000; i++)
    {
        (MyEnum.Seven).ToString();
    }
    int end = Environment.TickCount;
    Console.WriteLine((end - start).ToString());
}
```
Pre: 5828ms, 5828ms, 5829ms (1.7M/s)
Post: 828ms, 828ms, 828ms (12.1M/s)

7 years agoMerge pull request #6678 from dotnet-bot/UpdateDependencies20160810052139
Gaurav Khanna [Wed, 10 Aug 2016 14:32:05 +0000 (07:32 -0700)]
Merge pull request #6678 from dotnet-bot/UpdateDependencies20160810052139

Updating External dependencies to beta-24410-00

7 years agoFix for VCR 190024210 and Win SDK 10.0.14393.0 (#6674)
Peter Jas [Wed, 10 Aug 2016 06:12:51 +0000 (09:12 +0300)]
Fix for VCR 190024210 and Win SDK 10.0.14393.0 (#6674)

7 years agoUpdating External dependencies to beta-24410-00
dotnet-bot [Wed, 10 Aug 2016 05:21:39 +0000 (05:21 +0000)]
Updating External dependencies to beta-24410-00

7 years agoMerge pull request #6653 from echesakov/StackAllocation
Egor Chesakov [Tue, 9 Aug 2016 22:25:45 +0000 (15:25 -0700)]
Merge pull request #6653 from echesakov/StackAllocation

Work towards objects stack allocation

7 years agoTypeSystem generics test cases (#6663)
Fadi Hanna [Tue, 9 Aug 2016 20:08:02 +0000 (13:08 -0700)]
TypeSystem generics test cases (#6663)

TypeSystem generics test cases (TypeGenerator tests)

7 years agoFix LoadFromAssemblyName to invoke fallback context (analogous to static assembly...
Gaurav Khanna [Mon, 1 Aug 2016 19:03:26 +0000 (12:03 -0700)]
Fix LoadFromAssemblyName to invoke fallback context (analogous to static assembly loads within the context)

7 years agoUpdate FieldSeq annotations in EarlyProp
Joseph Tremoulet [Fri, 5 Aug 2016 18:01:35 +0000 (14:01 -0400)]
Update FieldSeq annotations in EarlyProp

When morph expands `ldelem`s, it annotates local vars and int constants
that contribute linearly to the index.  When value-numbering runs,
ParseArrayAddress must still be able to discover annotations.  EarlyProp
runs between morph and value-numbering, and might replace a `ldlen` that
happens to be in an array index expression with a constant.  This change
updates EarlyProp to call LabelIndex in such cases to annotate the
constants appropriately for their new context.

In order to ensure that EarlyProp can determine whether a replacement is
in an array index context or not, this change also adds a new flag
`GTF_ARRLEN_ARR_IDX`, which LabelIndex sets on GT_ARR_LENGTH nodes and
EarlyProp can subsequently check.

Fixes #6649.

7 years agoThe call to LOG expects a pointer argument, but the actual argument was of class...
vinnyrom [Tue, 9 Aug 2016 13:21:11 +0000 (06:21 -0700)]
The call to LOG expects a pointer argument, but the actual argument was of class type 'ComCallWrapperPtr'. (#6665)

7 years agoMerge pull request #6668 from dotnet-bot/UpdateDependencies20160809052353
Gaurav Khanna [Tue, 9 Aug 2016 06:46:52 +0000 (23:46 -0700)]
Merge pull request #6668 from dotnet-bot/UpdateDependencies20160809052353

Updating External dependencies to beta-24409-00

7 years agoUpdating External dependencies to beta-24409-00
dotnet-bot [Tue, 9 Aug 2016 05:23:53 +0000 (05:23 +0000)]
Updating External dependencies to beta-24409-00

7 years agoWork towards objects stack allocation: moved allocation part of newobj-lowering into...
Egor Chesakov [Thu, 21 Jul 2016 22:37:41 +0000 (15:37 -0700)]
Work towards objects stack allocation: moved allocation part of newobj-lowering into separate phase

1. Introduced `GT_ALLOCOBJ` node to mark places where object allocation happens
2. In `importer.cpp` changed lowering of allocation part of newobj instruction from an allocation helper call to a `GT_ALLOCOBJ` node creation
3. Created new phase `ObjectAllocator` (`PHASE_ALLOCATE_OBJECTS`) and put it right after dominator computing (we will need the information for escape analysis)
4. Current implementation of ObjectAllocator walks over all basic blocks having flag `BBF_HAS_NEWOBJ` set and replaces `GT_ALLOCOBJ` with  an allocation helper call

7 years agoMerge pull request #6662 from rahku/disabletransparencychecks
Rahul Kumar [Tue, 9 Aug 2016 00:50:14 +0000 (17:50 -0700)]
Merge pull request #6662 from rahku/disabletransparencychecks

Disable few more transparency checks for .net core

7 years agoMerge pull request #6660 from rahku/stackwalkerFix
Rahul Kumar [Tue, 9 Aug 2016 00:01:30 +0000 (17:01 -0700)]
Merge pull request #6660 from rahku/stackwalkerFix

Port CS#1596330 from netfxdev1 (bug#119959)

7 years agoMerge pull request #6659 from rahku/warning
Rahul Kumar [Mon, 8 Aug 2016 23:39:10 +0000 (16:39 -0700)]
Merge pull request #6659 from rahku/warning

Fix compiler warnings

7 years agoDisable few more transparency checks for .net core
Rahul Kumar [Mon, 8 Aug 2016 22:50:15 +0000 (15:50 -0700)]
Disable few more transparency checks for .net core

7 years agoMerge pull request #6656 from jashook/arm_link_fix
Jarret Shook [Mon, 8 Aug 2016 22:50:13 +0000 (15:50 -0700)]
Merge pull request #6656 from jashook/arm_link_fix

Fix for missing symbol OnHijackTripThread

7 years agoMerge pull request #6652 from JohnChen0/crossgen-createpdb
John Chen [Mon, 8 Aug 2016 22:37:35 +0000 (15:37 -0700)]
Merge pull request #6652 from JohnChen0/crossgen-createpdb

Modify "crossgen -createpdb" to skip loading clrjit.dll (#6607)

7 years agoFix compiler warnings
Rahul Kumar [Mon, 8 Aug 2016 21:35:40 +0000 (14:35 -0700)]
Fix compiler warnings

7 years agoPort CS#1596330 from netfxdev1 (bug#119959)
Rahul Kumar [Mon, 8 Aug 2016 22:06:30 +0000 (15:06 -0700)]
Port CS#1596330 from netfxdev1 (bug#119959)

7 years agoRefresh mscorlib reference assembly based on what is in S.P.C (#6655)
Wes Haggard [Mon, 8 Aug 2016 21:40:41 +0000 (14:40 -0700)]
Refresh mscorlib reference assembly based on what is in S.P.C (#6655)

Split mscorlib.cs into mscorlib.manual.cs for the internal
members we needed to expose. Used the genapi tool from
https://github.com/dotnet/buildtools/tree/master/src/GenAPI.Desktop
to generate mscorlib.cs. It doesn't exactly match due to some
much easier just by running genapi against S.P.CoreLib.

7 years agoUpdate package versions to 1.1.0
Gaurav Khanna [Thu, 4 Aug 2016 19:27:34 +0000 (12:27 -0700)]
Update package versions to 1.1.0

7 years agoModify "crossgen -createpdb" to skip loading clrjit.dll (#6607)
John Chen (CLR) [Fri, 5 Aug 2016 23:08:18 +0000 (16:08 -0700)]
Modify "crossgen -createpdb" to skip loading clrjit.dll (#6607)

The -JITPath option doesn't work properly when CrossGen is used to
create a PDB file (issue #6607). Since clrjit.dll isn't really
needed for creating PDB files, the issue is fixed by modifying
CrossGen to skip loading clrjit.dll when -createpdb option is given.

Also following suggestion from issue #6607, added a new switch
-diasymreaderPath to CrossGen, to allow loading diasymreader.dll
from an alternative path.

7 years agoFix for missing symbol OnHijackTripThread
jashoo [Mon, 8 Aug 2016 17:07:15 +0000 (10:07 -0700)]
Fix for missing symbol OnHijackTripThread

PR #6522 changed from OnHijackScalarTripThread to OnHijackTripThread; however,
missed changing this definition for arm windows.

7 years agoAdd Title (so that web searches work better) (#6654)
Vance Morrison [Mon, 8 Aug 2016 20:18:12 +0000 (13:18 -0700)]
Add Title (so that web searches work better) (#6654)

Also added a very short description

7 years agoMerge pull request #6582 from alsemenn/fixrefreg
Sasha Semennikov [Mon, 8 Aug 2016 19:08:00 +0000 (12:08 -0700)]
Merge pull request #6582 from alsemenn/fixrefreg

For helper method frame DAC doesn't read register pointers. So set them to NULL to not use "wrong" data.

7 years agoCheck PAL_VirtualUnwind failure during GC (#6598)
Jonghyun Park [Mon, 8 Aug 2016 01:35:54 +0000 (10:35 +0900)]
Check PAL_VirtualUnwind failure during GC (#6598)

As discussed in #6525, PAL_VirtualUnwind sometimes fails during GC.

This GC failure leads to very unpredicatble behavior (which is very hard to
analyze).

This commit tries to stop the execution at the point where error
happens.

7 years agoDon't overwrite crossgen log in build.cmd script (#6639)
James Ko [Sun, 7 Aug 2016 15:21:30 +0000 (11:21 -0400)]
Don't overwrite crossgen log in build.cmd script (#6639)

7 years agoFix compile error (#6641)
Guo Xiao [Sun, 7 Aug 2016 15:20:52 +0000 (10:20 -0500)]
Fix compile error (#6641)

error: cannot initialize return object of type 'void *' with an lvalue
of type 'void ()'

7 years agoMerge pull request #6619 from BruceForstall/Fix6517
Bruce Forstall [Sat, 6 Aug 2016 17:39:06 +0000 (10:39 -0700)]
Merge pull request #6619 from BruceForstall/Fix6517

Fix #6517

7 years agoMerge pull request #6630 from dotnet-bot/UpdateDependencies20160805073043
Gaurav Khanna [Sat, 6 Aug 2016 02:33:50 +0000 (19:33 -0700)]
Merge pull request #6630 from dotnet-bot/UpdateDependencies20160805073043

Updating External dependencies to beta-24405-00

7 years agoMerge pull request #6631 from erozenfeld/NullCheckFolding
Eugene Rozenfeld [Sat, 6 Aug 2016 02:09:04 +0000 (19:09 -0700)]
Merge pull request #6631 from erozenfeld/NullCheckFolding

Null check folding.

7 years agoDecrease writes to local variables in Buffer.MemoryCopy (#6627)
James Ko [Sat, 6 Aug 2016 02:06:59 +0000 (22:06 -0400)]
Decrease writes to local variables in Buffer.MemoryCopy (#6627)

In `Buffer.MemoryCopy` currently we are making 4 writes every time we copy some data; 1 to update `*dest`, 1 to update `dest`, 1 to update `src` and 1 to update `len`. I've decreased it to 2; one to update a new local variable `i`, which keeps track of how many bytes we are into the buffer. All writes are now made using

```cs
*(dest + i + x) = *(src + i + x)
```

which has no additional overhead since they're converted to using memory addressing operands by the jit.

Another change I made was to add a few extra cases for the switch-case at the beginning that does copying for small sizes without any branches. It now covers sizes 0-22. This is beneficial to the main codepath, since we can convert the unrolled loop to a `do..while` loop and save an extra branch at the beginning. (max 7 bytes for alignment, 16 for 1 iteration of the loop, so the min bytes we can copy without checking whether we should stop is 23.) This adds

This PR increases the performance of `MemoryCopy` by 10-20% for most buffer sizes on x86; you can see the performance test/results (and the generated assembly for each version) [here](https://gist.github.com/jamesqo/337852c8ce09205a8289ce1f1b9b5382). (Note that this codepath is also used by `wstrcpy` at the moment, so this directly affects many common String operations.)

7 years agoMerge pull request #6636 from AndyAyersMS/MoreObservations
Andy Ayers [Sat, 6 Aug 2016 02:03:53 +0000 (19:03 -0700)]
Merge pull request #6636 from AndyAyersMS/MoreObservations

Inliner: add a few more observations

7 years agoFix #6517
Bruce Forstall [Fri, 5 Aug 2016 06:52:25 +0000 (23:52 -0700)]
Fix #6517

My previous change #6342 to implement tailcall-via-helper for RyuJIT/x86
also changed non-x86 for Delegate Invoke calls, to avoid creating a
temp where we already had a local. However, this temp is needed if the
local is a field (with an offset). Even if it is not a field, I saw it
needed in a JitStressRegs case. So I'm returning it to the previous logic
for non-x86, non-tailcall cases. It is still required for tailcall cases
to preserve some delicate ordering constraints on the special tailcall
argument values.

7 years agoInliner: add a few more observations
Andy Ayers [Fri, 5 Aug 2016 21:49:02 +0000 (14:49 -0700)]
Inliner: add a few more observations

Now that we can trust `optMethodFlags`, note if the root caller has
newarr or newobj. We can't yet tell if these operations might feed
a particular call's arguments but their presence in the root method
alone might be enough to build correlations with performance changes.

Count number of returns in the callee. Note if callee has same this
as the (root) caller. Note when callee is a class constructor.

Add code to dump out the new observations. No policies act on these yet.

7 years agoMerge pull request #6522 from swaroop-sridhar/gcinfov2
Swaroop Sridhar [Fri, 5 Aug 2016 22:48:42 +0000 (15:48 -0700)]
Merge pull request #6522 from swaroop-sridhar/gcinfov2

Implement GcInfo v2

7 years agoNull check folding.
Eugene Rozenfeld [Fri, 5 Aug 2016 20:14:58 +0000 (13:14 -0700)]
Null check folding.

1. Added a null check folding optimization to early prop. The optimization tries to fold
GT_NULLCHECK(y) nodes  into GT_IND(x) nodes where x=y+const
in the same block (where const is sufficiently small). The algorithm uses SSA use-def info
to go from x to its def and then tries to match the pattern x = COMMA(NULLCHECK(y), ADD(y, const))).
If such a pattern is found, the algorithm checks the trees and statements that are between the use
and the def in execution order to see if they have unsafe side effects: calls, exception sources, and
assignments (all assignment if we are in a try and assignments to global memory if we are not).
If there are no nodes with unsafe side effects, the null check is removed.

2. Made several improvements to null check elimination in assertion propagation.
..* Added a new kind for op1: O1K_VALUE_NUMBER
..* Non-null assertions can now be made about arbitrary value numbers, not just locals
..* Fixed code that was trying to find a ref given a byref: the code now handles an arbitrary number of
    offsets and checks whether the total offsetof is small enough.
..* Added similar code that tries to find a ref VN given a byref VN

This addresses part of the suboptimal code generated for #1226: null check is no longer emitted.

Correctness: ran full desktop and CoreCLR testing.

Throughput: no measurable throughput impact (verified by running internal CQNgenTP several times).

Code size in CoreCLR:

Framework assemblies:

Total bytes of diff: -805 (-0.01 % of base)
    diff is an improvement.
Total byte diff includes 0 bytes from reconciling methods
        Base had    0 unique methods,        0 unique bytes
        Diff had    0 unique methods,        0 unique bytes
Top file improvements by size (bytes):
        -352 : System.Private.CoreLib.dasm (-0.01 % of base)
        -306 : Microsoft.CodeAnalysis.CSharp.dasm (-0.01 % of base)
         -58 : Microsoft.CodeAnalysis.dasm (-0.01 % of base)
         -48 : System.Numerics.Vectors.dasm (-0.08 % of base)
         -14 : System.Xml.XmlDocument.dasm (-0.01 % of base)
7 total files with size differences.
Top method improvements by size (bytes):
         -30 : System.Numerics.Vectors.dasm - System.Numerics.Matrix4x4:ToString():ref:this
         -30 : System.Private.CoreLib.dasm - System.DateTimeParse:ParseByFormat(byref,byref,byref,ref,byref):bool
         -24 : Microsoft.CodeAnalysis.CSharp.dasm - <GetMethodsToEmit>d__68:MoveNext():bool:this
         -18 : System.Private.CoreLib.dasm - System.DateTimeParse:Lex(int,byref,byref,byref,byref,byref,int):bool
         -18 : System.Private.CoreLib.dasm - System.DateTimeParse:ProcessDateTimeSuffix(byref,byref,byref):bool
243 total methods with size differences.

JIT Code quality benchmarks in CoreCLR:

Total bytes of diff: -29 (-0.01 % of base)
    diff is an improvement.
Total byte diff includes 0 bytes from reconciling methods
        Base had    0 unique methods,        0 unique bytes
        Diff had    0 unique methods,        0 unique bytes
Top file improvements by size (bytes):
         -25 : Bytemark\Bytemark\Bytemark.dasm (-0.03 % of base)
          -4 : BenchmarksGame\pidigits\pi-digits\pi-digits.dasm (-0.21 % of base)
2 total files with size differences.
Top method improvements by size (bytes):
          -9 : Bytemark\Bytemark\Bytemark.dasm - AssignJagged:second_assignments(ref,ref)
          -6 : Bytemark\Bytemark\Bytemark.dasm - EMFloat:MultiplyInternalFPF(byref,byref,byref)
          -4 : Bytemark\Bytemark\Bytemark.dasm - EMFloat:AddSubInternalFPF(ubyte,byref,byref,byref)
          -2 : Bytemark\Bytemark\Bytemark.dasm - EMFloat:denormalize(byref,int)
          -2 : Bytemark\Bytemark\Bytemark.dasm - EMFloat:DivideInternalFPF(byref,byref,byref)
8 total methods with size differences.

In internal SPMI:

3915 methods with diffs, almost everything -- code size improvements
13,715 bytes code size reduction overall 0.51% on affected methods

CQ_Perf: 85 methods with diffs, 84 code size improvements, no regressions
Benchmarks with code size diffs:
Roslyn 59
TrueTypeBench 19
mono-pi-digits 2
mono-chameneos-redux 2
ByteMark\assign_jagged 1
Json_Serialize 1
SharpChess 1
BenchI\mulmtx 1

Internal CQPerf didn't report any runtime wins for these benchmarks.

7 years agoImplement GcInfo v2
Swaroop Sridhar [Wed, 20 Jul 2016 23:50:22 +0000 (16:50 -0700)]
Implement GcInfo v2
Ref #4379

This change implements GcInfo version 2 for all platforms that use the
GcInfo library (all architectures other than X86).

Changes are:
1) Defines ReturnKind enumeration for all platforms
2) Change the GcInfo encoder library to encode the ReturnKind and ReversePInvokeFrame slot
3) Change the CM's GcInfo decoder to encode the ReturnKind and ReversePInvokeFrame slot for GCINFO_VERSION 2
4) Some corrections to GCINFO_MEASUREments
5) Changes to RYU Jit to provide the correct information to the encoder
6) Changes to the VM to use the ReturnKind information while hijacking a thread
   - If ReturnKind is available from GcInfo, new hijack routines are used
   - Otherwise, fall back to old method (for compatibility)
7) Rework and simplify the thread hijack routines by scanning HijackFrames directly for gcroots
8) Supporting code to implement the above features.

Returning Structs in multiple registers

Hijacking for StructInRegs is currently only implemented for
Unix SystemV ABI Multi-reg struct returns. However, the hijack-workers that use
ReturnKind are ready to handle other platforms (ex: ARM/ARM64 Windows)
once the corresponding HijackTripThread() assembly routines are defined.

The New feature flag: FEATURE_MULTIREG_RETURN is set for platforms where a struct value
can be returned in multiple registers [ex: Windows/Unix ARM/ARM64, Unix-AMD64]
FEATURE_UNIX_AMD64_STRUCT_PASSING is a specific kind of FEATURE_MULTIREG_RETURN
specified by SystemV ABI for AMD64

Compatibility with other JITs

- All new GCInfo generated by RYU Jit is in GcInfo version 2
- All Ngen images must be regenerated with the new GcInfo version.
- Ready-to-run images with old GcInfo will continue to work.
- Jit64/X64 uses the GcInfo library, so it generates GcInfo version 2.
  However, it doesn't (yet) provide the data to encode the correct ReturnKind
  Similar is the case for ARM32 code running on JIT32, and any other JITs
  that may be using GcInfo library but not yet modified to use the new API.
  So, compatibility is achived using RT_Unset flag.

When ReturnKind is RT_Unset, it means that the JIT did not set
the ReturnKind in the GCInfo, and therefore the VM cannot rely on it,
and must use other mechanisms (similar to GcInfo ver 1) to determine
the Return type's GC information.

Implement GC root scanning for Hijack-frames

This change implements GCScanRoots() method for Hijacke-frames
based on the ReturnKind information available from the GcInfo.
If the exact ReturnKind is not available in the GcInfo, the
thread-suspension logic will compute the ReturnKind based on
the method-signature.

As a result of this change, several hijack-helpers in the VM
are cleaned up. There's only one implementation of HijackWorker()
to handle all returnKinds.

This change also simplifies the thread-hijack logic by using a
single assembly helper OnHijackTripThread() in most cases.
The only other helper used is for X86 floating point return values
for save/restoring the top of the FP stack.

ARM64

Only GcIndfo v2 is reliably supported for ARM64 platform.
The changes to thread-hijack mechanism fixes #6494 for ARM64.

No measurable change in JIT throughput, performance or native-image
size from this change.

7 years agoFor helper method frame DAC doesn't read register pointers. So set them to NULL to...
Sasha Semennikov [Tue, 2 Aug 2016 23:45:21 +0000 (16:45 -0700)]
For helper method frame DAC doesn't read register pointers. So set them to NULL to not user "wrong" data.

Moved context pointers NULL assignment to gmsamd64.cpp

Squash commits

7 years agoMerge pull request #6629 from JosephTremoulet/DeadFlag
Joseph Tremoulet [Fri, 5 Aug 2016 20:06:09 +0000 (16:06 -0400)]
Merge pull request #6629 from JosephTremoulet/DeadFlag

Remove GTF_REDINDEX_CHECK

7 years agoUpdating External dependencies to beta-24405-00
dotnet-bot [Fri, 5 Aug 2016 19:30:43 +0000 (19:30 +0000)]
Updating External dependencies to beta-24405-00

7 years agoMerge pull request #6628 from vancem/WCF_ExplictChannels
Vance Morrison [Fri, 5 Aug 2016 18:53:13 +0000 (11:53 -0700)]
Merge pull request #6628 from vancem/WCF_ExplictChannels

Wcf explict channels

7 years agoMerge pull request #6495 from briansull/cleanup
Brian Sullivan [Fri, 5 Aug 2016 18:44:20 +0000 (11:44 -0700)]
Merge pull request #6495 from briansull/cleanup

Followup work from codereview feedback

7 years agoMerge pull request #6617 from adityamandaleeka/fix_sos
Aditya Mandaleeka [Fri, 5 Aug 2016 18:04:45 +0000 (11:04 -0700)]
Merge pull request #6617 from adityamandaleeka/fix_sos

Fix bug in SymbolReader initialization in SOS

7 years agoMerge pull request #6620 from hqueue/fix/typo_20160805
Aditya Mandaleeka [Fri, 5 Aug 2016 18:04:00 +0000 (11:04 -0700)]
Merge pull request #6620 from hqueue/fix/typo_20160805

Fix misleading comment in codegenlegacy.cpp

7 years agoRemove GTF_REDINDEX_CHECK
Joseph Tremoulet [Fri, 5 Aug 2016 17:41:30 +0000 (13:41 -0400)]
Remove GTF_REDINDEX_CHECK

This flag is unused.  Its description also sounds like it's redundant with
the GTF_ARR_BOUND_INBND flag, so the latter flag could be used if a new
need to convey this information arises in the future.

Preserving GTF_ARR_BOUND_INBND and removing GTF_REDINDEX_CHECK makes more
sense than the other way around since GTF_ARR_BOUND_INBND is specific to
the relevant opcode.

7 years agoMerge pull request #6577 from lukasztomczyk/threadpool-spinwaitconfig
Koundinya Veluri [Fri, 5 Aug 2016 17:37:02 +0000 (10:37 -0700)]
Merge pull request #6577 from lukasztomczyk/threadpool-spinwaitconfig

Expose ThreadPool_UnfairSemaphoreSpinLimit config

7 years agoMerge pull request #6609 from AndyAyersMS/InlineSummaryData
Andy Ayers [Fri, 5 Aug 2016 16:48:48 +0000 (09:48 -0700)]
Merge pull request #6609 from AndyAyersMS/InlineSummaryData

Inliner: gather summary stats and dump to Jit CSV log

7 years agoFix typo/comments
Vance Morrison [Fri, 5 Aug 2016 16:28:06 +0000 (09:28 -0700)]
Fix typo/comments

7 years agoMerge pull request #6618 from hseok-oh/struct8byte
Brian Sullivan [Fri, 5 Aug 2016 15:59:29 +0000 (08:59 -0700)]
Merge pull request #6618 from hseok-oh/struct8byte

disable pass/return struct(float, float) using register in 32bit arch

7 years agoFix invalid checks for CONTEXT_XSTATE (#6621)
Jan Vorlicek [Fri, 5 Aug 2016 10:48:03 +0000 (12:48 +0200)]
Fix invalid checks for CONTEXT_XSTATE (#6621)

Checks for context flags containing CONTEXT_XSTATE were incorrect at two places.
The issue was that CONTEXT_XSTATE is not a single bit flag, but contains two
bits set - it is CONTEXT_AMD64 | 0x40. So testing the flag using
(contextFlags & CONTEXT_XSTATE) != 0 was always true, since context flags
on AMD64 always contain CONTEXT_AMD64 and so the `&` result is always non-zero.

7 years agoFix Issue 6585: Add offset to struct field arg (#6616)
Carol Eidt [Fri, 5 Aug 2016 08:38:44 +0000 (01:38 -0700)]
Fix Issue 6585: Add offset to struct field arg (#6616)

When the child of a GT_OBJ is a lclFldAddr, genConsumePutStructArgStk()
was not adding the offset of the struct field to the base address of
the local.

7 years agoFix misleading comment in codegenlegacy.cpp
Hyung-Kyu Choi [Fri, 5 Aug 2016 07:30:08 +0000 (16:30 +0900)]
Fix misleading comment in codegenlegacy.cpp

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
7 years agodisable pass/return struct(float, float) using register in 32bit architecture
Hyeongseok Oh [Fri, 5 Aug 2016 03:42:52 +0000 (12:42 +0900)]
disable pass/return struct(float, float) using register in 32bit architecture

7 years agoClean up some SOS code.
Aditya Mandaleeka [Fri, 5 Aug 2016 02:31:07 +0000 (19:31 -0700)]
Clean up some SOS code.

7 years agoCache failure to initialize SymbolReader logic in SOS.
Aditya Mandaleeka [Fri, 5 Aug 2016 02:19:21 +0000 (19:19 -0700)]
Cache failure to initialize SymbolReader logic in SOS.

7 years agoMerge pull request #6103 from mikedn/nothrowinl
Andy Ayers [Fri, 5 Aug 2016 02:14:57 +0000 (19:14 -0700)]
Merge pull request #6103 from mikedn/nothrowinl

Do not inline methods that never return

7 years agoFollowup work from codereview feedback
Brian Sullivan [Thu, 28 Jul 2016 00:39:15 +0000 (17:39 -0700)]
Followup work from codereview feedback

For PR  #6467 - Enable multireg returns on Arm64

7 years agoMerge pull request #6597 from yizhang82/test-warnings
Yi Zhang (CLR) [Fri, 5 Aug 2016 00:41:47 +0000 (17:41 -0700)]
Merge pull request #6597 from yizhang82/test-warnings

Fix warnings in interop tests

7 years agoMerge pull request #6572 from JosephTremoulet/starg
Joseph Tremoulet [Fri, 5 Aug 2016 00:31:03 +0000 (20:31 -0400)]
Merge pull request #6572 from JosephTremoulet/starg

Allow inlining when inlinee has `starg`

7 years agoAllow inlining when inlinee has `starg`
Joseph Tremoulet [Fri, 29 Jul 2016 17:54:37 +0000 (13:54 -0400)]
Allow inlining when inlinee has `starg`

The inliner's restriction that methods that make use of the `starg` opcode
cannot be inlined is somewhat artificial.  The comments indicate that the
reason for this excluion is because the inliner forward-substitutes
argument expressions in place of parameter references, but the codepaths
required to force evaluating an argument expression at the callsite and
reference that result in place of parameter references is already in place
to handle `ldarga` and complex argument expressions.

This change
 - adds an `argHasStargOp` flag to the `inlArgInfo` type, similar
   to the existing `argHasLdargaOp` flag
 - removes the `CALLEE_STORES_TO_ARGUMENT` inline observation and instead
   sets the new flag for `starg` cases
 - updates `impInlineFetchArg` to force evaluation to a temp for arguments
   that are marked `argHasStargOp`
 - updates `starg` processing in the importer to store to the
   corresponding temp when importing for an inlinee

Resolves #6014.

7 years agoMerge pull request #6579 from CarolEidt/LessConservativeGtObj
Carol Eidt [Fri, 5 Aug 2016 00:04:15 +0000 (17:04 -0700)]
Merge pull request #6579 from CarolEidt/LessConservativeGtObj

Less Conservative GtObj

7 years agoMerge pull request #6608 from dotnet-bot/from-tfs
Aditya Mandaleeka [Thu, 4 Aug 2016 21:40:42 +0000 (14:40 -0700)]
Merge pull request #6608 from dotnet-bot/from-tfs

Merge changes from TFS

7 years agoFix newly introduced typo in Documentation/README
Aditya Mandaleeka [Thu, 4 Aug 2016 21:14:20 +0000 (14:14 -0700)]
Fix newly introduced typo in Documentation/README

7 years agoFix warnings in interop tests and disable IsComObject(null) scenario as it is failing...
Yi Zhang [Thu, 4 Aug 2016 05:03:53 +0000 (22:03 -0700)]
Fix warnings in interop tests and disable IsComObject(null) scenario as it is failing in non-Windows

7 years agoFix link to all BotR chapters in table of contents
Aditya Mandaleeka [Thu, 4 Aug 2016 21:05:50 +0000 (14:05 -0700)]
Fix link to all BotR chapters in table of contents

7 years agoMerge pull request #6612 from vancem/Doc_Add_BOTR_TOC
Vance Morrison [Thu, 4 Aug 2016 21:00:10 +0000 (14:00 -0700)]
Merge pull request #6612 from vancem/Doc_Add_BOTR_TOC

Add a table of contents to the book of the runtime

7 years agoPull Request feedback
Vance Morrison [Thu, 4 Aug 2016 20:59:33 +0000 (13:59 -0700)]
Pull Request feedback

7 years agoAdd a table of contents to the book of the runtime
Vance Morrison [Thu, 4 Aug 2016 20:13:19 +0000 (13:13 -0700)]
Add a table of contents to the book of the runtime

 (so you have one link to go to that represents the entire book)

7 years agoAdding support to the following generic dictionary entry slots for R2R: (#6291)
Fadi Hanna [Thu, 4 Aug 2016 19:51:18 +0000 (12:51 -0700)]
Adding support to the following generic dictionary entry slots for R2R: (#6291)

DeclaringTypeHandleSlot
ConstrainedMethodEntrySlot

7 years agoFix contract violation (violation caused by a copy/paste bug in PR 6200
Fadi Hanna [Thu, 4 Aug 2016 19:21:28 +0000 (12:21 -0700)]
Fix contract violation (violation caused by a copy/paste bug in PR 6200

[tfs-changeset: 1620960]

7 years agoMerge pull request #6558 from bryanar/dumpling_ci2
Bryan P. Arant [Thu, 4 Aug 2016 19:17:53 +0000 (12:17 -0700)]
Merge pull request #6558 from bryanar/dumpling_ci2

Collect core dump URLs from dumpling service to raise up to CI.

7 years agoon fail: create local_dumplings.txt with the url of the uploaded core dump file if...
Bryan Arant [Mon, 1 Aug 2016 20:25:57 +0000 (13:25 -0700)]
on fail: create local_dumplings.txt with the url of the uploaded core dump file if dumpling is enabled. After, concatenate all of the local_dumplings.txt in to $(PWD)/dumplings.txt

7 years agoInliner: gather summary stats and dump to Jit CSV log
Andy Ayers [Wed, 3 Aug 2016 22:37:32 +0000 (15:37 -0700)]
Inliner: gather summary stats and dump to Jit CSV log

Collect per-method summary stats about inlining: number of calls,
number of candidates, etc.

7 years agoUpdating External dependencies to beta-24404-00 (#6601)
dotnet bot [Thu, 4 Aug 2016 18:36:43 +0000 (11:36 -0700)]
Updating External dependencies to beta-24404-00 (#6601)

7 years agoAdded additional comments to AppendFormatHelper to explain the parsing. (#1261)
Adam Speight [Thu, 4 Aug 2016 17:38:05 +0000 (18:38 +0100)]
Added additional comments to AppendFormatHelper to explain the parsing. (#1261)

* Added additional comments to AppendFormatHelper to explain the parsing.
* Create private static readonly properties for Index Limit and Width Limit.

7 years agoAdd a throw/inline benchmark
Mike Danes [Tue, 5 Jul 2016 20:45:49 +0000 (23:45 +0300)]
Add a throw/inline benchmark

7 years agoDo not inline methods that never return
Mike Danes [Wed, 3 Aug 2016 19:51:36 +0000 (22:51 +0300)]
Do not inline methods that never return

Methods that do not contain return blocks can't ever exit normally, they either throw or loop indefinitely. Inlining is not beneficial in such cases as it increases the code size without providing any speed benefits. In the particular case of throws the inlined code can easily be 10 times larger than the call site.

The call to fgMoreThanOneReturnBlock has been replaced with code that does the same thing but also detects the existence of at least one return block. This avoids walking the basic block list twice.

Note that BBJ_RETURN blocks are also generated for CEE_JMP. Methods exiting via CEE_JMP instead of CEE_RET will continue to be inlined (assuming they were inlined before this change).

7 years agoMerge pull request #6596 from yizhang82/interop-api
Yi Zhang (CLR) [Thu, 4 Aug 2016 04:41:34 +0000 (21:41 -0700)]
Merge pull request #6596 from yizhang82/interop-api

Add more interop API into System.Runtime

7 years agoMerge pull request #6589 from briansull/issue-5954
Brian Sullivan [Thu, 4 Aug 2016 01:40:15 +0000 (18:40 -0700)]
Merge pull request #6589 from briansull/issue-5954

Fix for Issue 5954