platform/upstream/llvm.git
3 years ago[DAGCombiner] Relax an assertion to an early return
Fraser Cormack [Thu, 13 May 2021 11:18:36 +0000 (12:18 +0100)]
[DAGCombiner] Relax an assertion to an early return

The select-of-constants transform was asserting that its constant vector
inputs did not implicitly truncate their input without that as an
explicit precondition to the function. This patch relaxes that assertion
into an early return to skip the optimization.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D102393

3 years ago[libcxx] NFC. Add missed articles to _LIPCPP_ASSERT messages in <list>
Kristina Bessonova [Sat, 15 May 2021 11:15:56 +0000 (13:15 +0200)]
[libcxx] NFC. Add missed articles to _LIPCPP_ASSERT messages in <list>

3 years ago[dexter] Remove requirement for a condition in DexLimitSteps
OCHyams [Mon, 17 May 2021 08:07:46 +0000 (09:07 +0100)]
[dexter] Remove requirement for a condition in DexLimitSteps

Currently the DexLimitSteps command requires at least one condition. This patch
lets users elide the condition to specify that the breakpoint range should
always be activated when the leading line is stepped on. This patch also
updates the terminology used in the `ConditionalController` class from the
terms 'conditional' and 'unconditional' to 'leading' and 'trailing' when
referring to the breakpoints in the DexLimitSteps range because the leading
breakpoint can now be unconditional.

Reviewed By: chrisjackson

Differential Revision: https://reviews.llvm.org/D101438

3 years ago[dexter] Remove unnecessary double check on conditional breakpoints
OCHyams [Mon, 17 May 2021 07:57:43 +0000 (08:57 +0100)]
[dexter] Remove unnecessary double check on conditional breakpoints

Remove the `ConditionalController._conditional_met` method. This was missed in
the recent ConditionalController refactor (D98699). We don't need to check that
the conditions for a conditional breakpoint have been met because
`DebuggerBase.get_triggered_breakpoint_ids` returns the set of ids for
breakpoints which have been triggered.

To get the "triggered breakpoints" from lldb we use `GetStopReasonDataCount`
and `GetStopReasonDataAtIndex`. It seems that these functions count all
breakpoints associated with the location which lldb has stopped at, regardless
of their condition. i.e. Even if we have two breakpoints at the same source
location that have mutually exclusive conditions, both will be found this way
when either condition is true. To get around this, we store a map of breakpoint
{id: condition} `_breakpoint_conditions` and evaluate the conditions of the
triggered breakpoints to filter the set down to those which are unconditional
or have a condition which evaluates to true.

Essentially we are just moving the condition double check from a general
debugger controller into the lldb specific wrapper. This tidy up will help make
upcoming patches simpler.

Reviewed By: chrisjackson

Differential Revision: https://reviews.llvm.org/D101431

3 years ago[LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags
Mateusz Mikuła [Mon, 17 May 2021 07:39:59 +0000 (10:39 +0300)]
[LLD][MinGW] Add --fatal-warnings and --no-fatal-warnings flags

Differential Revision: https://reviews.llvm.org/D102514

3 years ago[clang] NFC: Remove CompilerInstance::getInvocationPtr
Jan Svoboda [Mon, 17 May 2021 07:29:42 +0000 (09:29 +0200)]
[clang] NFC: Remove CompilerInstance::getInvocationPtr

This member function was introduced in 0a92e09c ([clang][deps] Generate the full command-line for modules) in order to keep the CompilerInvocation object alive after CompilerInstance goes out of scope. However, d3fb4b90 ([clang][deps] NFC: Report modules' context hash) removes that use-case, making this function dead.

3 years ago[PowerPC] add a testcase for reverse memory op; nfc
Chen Zheng [Mon, 17 May 2021 07:12:16 +0000 (03:12 -0400)]
[PowerPC] add a testcase for reverse memory op; nfc

3 years ago[clang][deps] NFC: Report modules' context hash
Jan Svoboda [Mon, 17 May 2021 07:16:25 +0000 (09:16 +0200)]
[clang][deps] NFC: Report modules' context hash

This patch eagerly constructs and modifies CompilerInvocation of modular dependencies in order to report the correct context hash instead of the hash of the original translation unit.

No functionality change here, since we currently don't modify CompilerInvocation in a way that affects the context hash.

Depends on D102473.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D102482

3 years ago[clang][deps] NFC: Stop assuming the TU's context hash
Jan Svoboda [Mon, 17 May 2021 06:50:49 +0000 (08:50 +0200)]
[clang][deps] NFC: Stop assuming the TU's context hash

The context hash of modular dependencies can be different from the context hash of the original translation unit if we modify their `CompilerInvocation`s.

Stop assuming the TU's context hash everywhere.

No functionality change here, since we're still currently using the unmodified TU CompilerInvocation to compute the context hash.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D102473

3 years agoAdd support for complex constants to MLIR core.
Adrian Kuegel [Fri, 14 May 2021 11:00:38 +0000 (13:00 +0200)]
Add support for complex constants to MLIR core.

BEGIN_PUBLIC
Add support for complex constants to MLIR core.
END_PUBLIC

Differential Revision: https://reviews.llvm.org/D101908

3 years ago[mlir] Lower permutation maps on TransferWriteOps
Matthias Springer [Mon, 17 May 2021 06:30:07 +0000 (15:30 +0900)]
[mlir] Lower permutation maps on TransferWriteOps

Add TransferWritePermutationLowering, which replaces permutation maps of TransferWriteOps with vector.transpose.

Differential Revision: https://reviews.llvm.org/D102548

3 years ago[mlir] Fix in_bounds attr handling in TransferReadPermutationLowering
Matthias Springer [Mon, 17 May 2021 06:26:26 +0000 (15:26 +0900)]
[mlir] Fix in_bounds attr handling in TransferReadPermutationLowering

The in_bounds attribute should also be transposed.

Differential Revision: https://reviews.llvm.org/D102572

3 years ago[CSSPGO] Update pseudo probe distribution factor based on inline context.
Hongtao Yu [Thu, 13 May 2021 18:06:44 +0000 (11:06 -0700)]
[CSSPGO] Update pseudo probe distribution factor based on inline context.

With prelink inlining, pseudo probes with same ID can come from different inline contexts. Such probes should not share samples and their factors should be fixed up separately.

I'm seeing 0.3% speedup for SPEC2017 overall. Benchmark 631.deepsjeng_s benefits the most, about 4%.

Reviewed By: wenlei, wmi

Differential Revision: https://reviews.llvm.org/D102429

3 years agoRevert "[TargetLowering] Only inspect attributes in the arguments for ArgListEntry"
Arthur Eubanks [Mon, 17 May 2021 05:02:10 +0000 (22:02 -0700)]
Revert "[TargetLowering] Only inspect attributes in the arguments for ArgListEntry"

This reverts commit 16748bd2fb1fe10d7d097961f1988327338f3f9f.

Causes https://crbug.com/1209013

3 years agoRevert "[NFC] Use ArgListEntry indirect types more in ISel lowering"
Arthur Eubanks [Mon, 17 May 2021 05:00:54 +0000 (22:00 -0700)]
Revert "[NFC] Use ArgListEntry indirect types more in ISel lowering"

This reverts commit 85af8a8c1b574faa0d5d57d189ae051debdfada8.

3 years ago[SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched
Pan, Tao [Mon, 17 May 2021 03:22:47 +0000 (11:22 +0800)]
[SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

ScheduleDAGFast.cpp is compiled to object file, but the ScheduleDAGFast
object file isn't linked into clang executable file as no symbol is
referred by outside. Add calling to createXxx of ScheduleDAGFast.cpp,
then the ScheduleDAGFast object file will be linked into clang
executable file. The static RegisterScheduler will register scheduler
fast and linearize at clang boot time.

Reviewed By: pengfei

Differential Revision: https://reviews.llvm.org/D101601

3 years ago[RISCV] Optimize or/xor with immediate in the zbs extension
Ben Shi [Mon, 17 May 2021 02:59:52 +0000 (10:59 +0800)]
[RISCV] Optimize or/xor with immediate in the zbs extension

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D102398

3 years ago[NFC][sanitizer] Fix 'macro redefined' warning in test
Vitaly Buka [Mon, 17 May 2021 01:59:19 +0000 (18:59 -0700)]
[NFC][sanitizer] Fix 'macro redefined' warning in test

3 years ago[RISCV][test] Add new tests of or/xor in the zbs extension
Ben Shi [Mon, 17 May 2021 01:47:23 +0000 (09:47 +0800)]
[RISCV][test] Add new tests of or/xor in the zbs extension

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D102396

3 years ago[lld][X86] Restore gotEntrySize.
Harald van Dijk [Sun, 16 May 2021 23:13:00 +0000 (00:13 +0100)]
[lld][X86] Restore gotEntrySize.

D62727 removed GotEntrySize and GotPltEntrySize with a comment that they
are always equal to wordsize(), but that is not entirely true: X32 has a
word size of 4, but needs 8-byte GOT entries. This restores gotEntrySize
for both, adjusted for current naming conventions, but defaults it to
config->wordsize to keep things simple for architectures other than
x86_64.

This partially reverts D62727.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D102509

3 years agoFix some deprecated copy ops in google mock
David Blaikie [Sun, 16 May 2021 22:58:40 +0000 (15:58 -0700)]
Fix some deprecated copy ops in google mock

3 years ago[RISCV] Replace AddiPair ComplexPattern with a PatLeaf. NFC
Craig Topper [Sun, 16 May 2021 19:17:47 +0000 (12:17 -0700)]
[RISCV] Replace AddiPair ComplexPattern with a PatLeaf. NFC

The ComplexPattern is looking for an immediate in a certain range
that has a single use. This can be handled with a PatLeaf since
we aren't matching multiple patterns or checking any complicated
relationships between nodes.

This shrinks the isel table a little bit since tablegen no longer
has to generate patterns with commuted operands. With the PatLeaf,
tablegen can see we're matching an immediate which should always
be on the right hand side of add.

Reviewed By: benshi001

Differential Revision: https://reviews.llvm.org/D102510

3 years ago[test] Improve CodeGen/*/semantic-interposition-asm.ll
Fangrui Song [Sun, 16 May 2021 18:17:09 +0000 (11:17 -0700)]
[test] Improve CodeGen/*/semantic-interposition-asm.ll

3 years ago[BPF] add support for 32 bit registers in inline asm
Alessandro Decina [Sun, 16 May 2021 16:32:36 +0000 (09:32 -0700)]
[BPF] add support for 32 bit registers in inline asm

Add "w" constraint type which allows selecting 32 bit registers.
32 bit registers were added in https://reviews.llvm.org/rGca31c3bb3ff149850b664838fbbc7d40ce571879.

Differential Revision: https://reviews.llvm.org/D102118

3 years agoRecommit "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."
Florian Hahn [Sun, 16 May 2021 11:03:36 +0000 (12:03 +0100)]
Recommit "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."

Recommit D102489, with the test case requiring the AArch64 backend.

This reverts the revert 59b419adc6e608db8d7c31efcc37f34c0b57b7d0.

3 years ago[clang] Fix ternary operator in the second for loop statement
Danila Kutenin [Fri, 14 May 2021 23:56:48 +0000 (16:56 -0700)]
[clang] Fix ternary operator in the second for loop statement

Fix ternary operator in for loop argument, it was by mistake not set as CanBeForRangeDecl and led to incorrect codegen. It fixes https://bugs.llvm.org/show_bug.cgi?id=50038. I don't have commit rights. Danila Kutenin. kutdanila@yandex.ru

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D102502

3 years ago[JITLink] Fix symbol comparator in LinkGraph::dump.
Lang Hames [Sun, 16 May 2021 17:09:35 +0000 (10:09 -0700)]
[JITLink] Fix symbol comparator in LinkGraph::dump.

The existing implementation did not provide a strict weak ordering.

3 years ago[CPG][ARM] Optimize towards branch on zero in codegenprepare
David Green [Sun, 16 May 2021 16:54:06 +0000 (17:54 +0100)]
[CPG][ARM] Optimize towards branch on zero in codegenprepare

This adds a simple fold into codegenprepare that converts comparison of
branches towards comparison with zero if possible. For example:
  %c = icmp ult %x, 8
  br %c, bla, blb
  %tc = lshr %x, 3
becomes
  %tc = lshr %x, 3
  %c = icmp eq %tc, 0
  br %c, bla, blb

As a first order approximation, this can reduce the number of
instructions needed to perform the branch as the shift is (often) needed
anyway. At the moment this does not effect very much, as llvm tends to
prefer the opposite form. But it can protect against regressions from
commits like rG9423f78240a2.

Simple cases of Add and Sub are added along with Shift, equally as the
comparison to zero can often be folded with cpsr flags.

Differential Revision: https://reviews.llvm.org/D101778

3 years agoRevert "Do actual DCE in LoopUnroll (try 2)"
Philip Reames [Sun, 16 May 2021 16:29:25 +0000 (09:29 -0700)]
Revert "Do actual DCE in LoopUnroll (try 2)"

This reverts commit 653fa0b46ae34c06495b542414b704b30381cd02.

Reported to trigger pr50354.  Reverting until investigated.

3 years ago[ARM] Extra branch on zero tests. NFC
David Green [Sun, 16 May 2021 16:22:52 +0000 (17:22 +0100)]
[ARM] Extra branch on zero tests. NFC

3 years ago[Utils] Fix indentation error in utils/wciia.py
Kai Luo [Sun, 16 May 2021 14:34:09 +0000 (22:34 +0800)]
[Utils] Fix indentation error in utils/wciia.py

Running this script gives
```
"llvm-project/llvm/./utils/wciia.py", line 56
    if word == "N:":
TabError: inconsistent use of tabs and spaces in indentation
```
Under emacs' whitespace-mode, it shows
```
for·line·in·code_owners_file:$
····for·word·in·line.split():$
»       if·word·==·"N:":$
»       »       name·=·line[2:].strip()$
»       »       if·code_owner:$
»       »       »       process_code_owner(code_owner)$
»       »       »       code_owner·=·{}$
```
I use `yapf` to format this script directly and it's running correctly.

3 years ago[CaptureTracking] Simplify reachability check (NFCI)
Nikita Popov [Sun, 16 May 2021 14:04:10 +0000 (16:04 +0200)]
[CaptureTracking] Simplify reachability check (NFCI)

This code was re-implementing the same-BB case of
isPotentiallyReachable(). Historically, this was done because
CaptureTracking used additional caching for local dominance
queries. Now that it is no longer needed, the code is effectively
the same as isPotentiallyReachable().

The only difference are extra checks for invoke/phis. These are
misleading checks related to dominance in the value availability
sense that are not relevant for control reachability. The invoke
check was correct but redundant in that invokes are always
terminators, so `I` could never come before the invoke. The phi
check is a matter of interpretation (should an earlier phi node be
considered reachable from a later phi node in the same block?)
but ultimately doesn't matter because phis don't capture anyway.

3 years agoReapply [CaptureTracking] Do not check domination
Nikita Popov [Sun, 16 May 2021 08:40:02 +0000 (10:40 +0200)]
Reapply [CaptureTracking] Do not check domination

Reapply after adjusting the synchronized.m test case, where the
TODO is now resolved. The pointer is only captured on the exception
handling path.

-----

For the CapturesBefore tracker, it is sufficient to check that
I can not reach BeforeHere. This does not necessarily require
that BeforeHere dominates I, it can also occur if the capture
happens on an entirely disjoint path.

This change was previously accepted in D90688, but had to be
reverted due to large compile-time impact in some cases: It
increases the number of reachability queries that are performed.

After recent changes, the compile-time impact is largely mitigated,
so I'm reapplying this patch. The remaining compile-time impact
is largely proportional to changes in code-size.

3 years ago[Matrix] Fix some newpm check lines, which fail on some bots. (2)
Florian Hahn [Sun, 16 May 2021 13:11:09 +0000 (14:11 +0100)]
[Matrix] Fix some newpm check lines, which fail on some bots. (2)

3 years ago[X86][SSE] Pull out combineToHorizontalAddSub helper from inside (F)ADD/SUB combines...
Simon Pilgrim [Sun, 16 May 2021 09:53:04 +0000 (10:53 +0100)]
[X86][SSE] Pull out combineToHorizontalAddSub helper from inside (F)ADD/SUB combines (REAPPLIED). NFCI.

The intention is to be able to run this from additional locations (such as shuffle combining) in the future.

Reapplies rGb95a103808ac (after reversion at rGc012a388a15b), with SSE3/SSSE3 typo fix, test added at rG0afb10de1449.

3 years ago[Matrix] Fix some newpm check lines, which fail on some bots.
Florian Hahn [Sun, 16 May 2021 12:47:40 +0000 (13:47 +0100)]
[Matrix] Fix some newpm check lines, which fail on some bots.

3 years ago[Matrix] Extend test to also check new PM pipeline.
Florian Hahn [Sun, 16 May 2021 12:08:51 +0000 (13:08 +0100)]
[Matrix] Extend test to also check new PM pipeline.

3 years ago[PhaseOrdering] Add test for insert/extract code for matrixes.
Florian Hahn [Sun, 16 May 2021 10:45:30 +0000 (11:45 +0100)]
[PhaseOrdering] Add test for insert/extract code for matrixes.

3 years ago[VectorCombine] Add tests with and & urem guaranteeing idx is valid.
Florian Hahn [Sun, 16 May 2021 10:12:55 +0000 (11:12 +0100)]
[VectorCombine] Add tests with and & urem guaranteeing idx is valid.

3 years ago[NFC][X86][Costmodel] Add tests for load/store with i1 element type
Roman Lebedev [Sun, 16 May 2021 10:58:07 +0000 (13:58 +0300)]
[NFC][X86][Costmodel] Add tests for load/store with i1 element type

3 years agoRevert "[CaptureTracking] Do not check domination"
Nikita Popov [Sun, 16 May 2021 09:04:45 +0000 (11:04 +0200)]
Revert "[CaptureTracking] Do not check domination"

This reverts commit 6b8b43e7af3074124e3c9e429e1fb08165799be4.

This causes clang test to fail (CodeGenObjC/synchronized.m).
Revert until I can figure out whether that's an expected change.

3 years ago[CaptureTracking] Do not check domination
Nikita Popov [Sun, 16 May 2021 08:40:02 +0000 (10:40 +0200)]
[CaptureTracking] Do not check domination

For the CapturesBefore tracker, it is sufficient to check that
I can not reach BeforeHere. This does not necessarily require
that BeforeHere dominates I, it can also occur if the capture
happens on an entirely disjoint path.

This change was previously accepted in D90688, but had to be
reverted due to large compile-time impact in some cases: It
increases the number of reachability queries that are performed.

After recent changes, the compile-time impact is largely mitigated,
so I'm reapplying this patch. The remaining compile-time impact
is largely proportional to changes in code-size.

3 years ago[MemCpyOpt] Add test for unreachable capture (NFC)
Nikita Popov [Sun, 16 May 2021 08:35:30 +0000 (10:35 +0200)]
[MemCpyOpt] Add test for unreachable capture (NFC)

This is based on the test from D90688, without the argmemonly
attribute. The argmemonly attribute would guaranteed no modref
by itself and the question of captures would not arise in the
first place.

3 years ago[MLIR][PYTHON] Provide opt level for ExecutionEngine Python binding
Uday Bondhugula [Wed, 5 May 2021 02:44:31 +0000 (08:14 +0530)]
[MLIR][PYTHON] Provide opt level for ExecutionEngine Python binding

Provide an option to specify optimization level when creating an
ExecutionEngine via the MLIR JIT Python binding. Not only is the
specified optimization level used for code generation, but all LLVM
optimization passes at the optimization level are also run prior to
machine code generation (akin to the mlir-cpu-runner tool).

Default opt level continues to remain at level two (-O2).

Contributions in part from Prashant Kumar <prashantk@polymagelabs.com>
as well.

Differential Revision: https://reviews.llvm.org/D102551

3 years ago[Matrix] Implement static cast for matrix types
Saurabh Jha [Sun, 9 May 2021 07:17:10 +0000 (08:17 +0100)]
[Matrix] Implement static cast for matrix types

This patch implements static casts for matrix types. This patch finishes all the work needed for https://bugs.llvm.org/show_bug.cgi?id=47141

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D102125

3 years ago[MLIR][NFC] Fix clang-tidy warnings in IntegerSet.h
Uday Bondhugula [Sun, 16 May 2021 06:55:25 +0000 (12:25 +0530)]
[MLIR][NFC] Fix clang-tidy warnings in IntegerSet.h

Fix clang-tidy warnings and some comments in IntegerSet.h. NFC.

Differential Revision: https://reviews.llvm.org/D102387

3 years ago[AIX][compiler-rt] Build and install standalone libatomic
Kai Luo [Sun, 16 May 2021 05:03:10 +0000 (05:03 +0000)]
[AIX][compiler-rt] Build and install standalone libatomic

On AIX, we have to ship `libatomic.a` for compatibility. First, a new `clang_rt.atomic` is added. Second, use added cmake modules for AIX, we are able to build a compatible libatomic.a for AIX. The second step can't be perfectly implemented with cmake now since AIX's archive approach is kinda unique, i.e., archiving shared libraries into a static archive file.

Reviewed By: jsji

Differential Revision: https://reviews.llvm.org/D102155

3 years ago[AIX][AsmPrinter] Print Global Variable in comments
Jinsong Ji [Sun, 16 May 2021 03:04:44 +0000 (03:04 +0000)]
[AIX][AsmPrinter] Print Global Variable in comments

The default AsmPrinter print GV in comments,
AIX should do so too.

This also fix LLVM :: CodeGen/Generic/inline-asm-mem-clobber.ll.

Reviewed By: hubert.reinterpretcast

Differential Revision: https://reviews.llvm.org/D102534

3 years ago[AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as
Hubert Tong [Sun, 16 May 2021 02:38:42 +0000 (22:38 -0400)]
[AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

This patch replaces the `powerpc64` token with the `system-aix` one in
the UNSUPPORTED line of a test. The `powerpc64` token was originally
added temporarily in 71a0609a2b53.

If AIX uses integrated-as by default and it works both for 32-bit and
64-bit objects, then the issues encountered so far (see comments in
D96033) would be mostly solved.

As it is, marking the test as expected-to-fail (as opposed to
unsupported) on AIX might cause more trouble in the form of 32-bit
versus 64-bit differences. I am not aware of other situations where LIT
tests are dependent on whether the LLVM build is 64-bit or 32-bit.

Reviewed By: jsji

Differential Revision: https://reviews.llvm.org/D102560

3 years ago[Demangle][Rust] Parse trait definitions
Tomasz Miąsko [Sat, 15 May 2021 21:33:24 +0000 (23:33 +0200)]
[Demangle][Rust] Parse trait definitions

Part of https://reviews.llvm.org/D102549

3 years ago[Demangle][Rust] Parse trait implementations
Tomasz Miąsko [Sat, 15 May 2021 21:25:24 +0000 (23:25 +0200)]
[Demangle][Rust] Parse trait implementations

Part of https://reviews.llvm.org/D102549

3 years ago[Demangle][Rust] Parse inherent implementations
Tomasz Miąsko [Sat, 15 May 2021 21:24:16 +0000 (23:24 +0200)]
[Demangle][Rust] Parse inherent implementations

Part of https://reviews.llvm.org/D102549

3 years ago[Attributor] Call site specific AAValueSimplification and AAIsDead.
Kuter Dinel [Sat, 15 May 2021 16:28:50 +0000 (16:28 +0000)]
[Attributor] Call site specific AAValueSimplification and AAIsDead.

This patch makes it possible to do call site specific deductions
for AAValueSimplification and AAIsDead.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D84722

3 years ago[X86] Remove unused check-prefixes
Simon Pilgrim [Sat, 15 May 2021 21:04:49 +0000 (22:04 +0100)]
[X86] Remove unused check-prefixes

3 years ago[CaptureTracking] Only check reachability for capture candidates
Nikita Popov [Sat, 15 May 2021 17:05:08 +0000 (19:05 +0200)]
[CaptureTracking] Only check reachability for capture candidates

Reachability queries are very expensive, and currently performed
for each instruction we look at, even though most of them will
not lead to a capture and are thus ultimately irrelevant. It is
more efficient to walk a few unnecessary instructions than to
perform unnecessary reachability queries.

Theoretically, this may produce worse results, because the additional
instructions considered may cause us to hit the use count limit
earlier. In practice, this does not appear to be a problem, e.g.
on test-suite O3 we report only one more captured-before with this
change, with no resulting codegen differences.

This makes PointerMayBeCapturedBefore() significantly cheaper in
practice, hopefully allowing it to be used in more places.

3 years ago[X86][SSE] Add SSE3 coverage to PHADD/SUB generation tests
Simon Pilgrim [Sat, 15 May 2021 20:25:34 +0000 (21:25 +0100)]
[X86][SSE] Add SSE3 coverage to PHADD/SUB generation tests

This would have caught the regression identified in rGc012a388a15b.

3 years agoNFC. Refactored DIPrinter for support embedded source.
Alex Orlov [Sat, 15 May 2021 19:01:12 +0000 (23:01 +0400)]
NFC. Refactored DIPrinter for support embedded source.

This patch introduces source loading and pruning functions.
It will allow to use the DWARF embedded source and use the same code for JSON printout.
No functional changes.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D102539

3 years ago[Compiler-rt] Downgrade another fatal error to warning
Dan Liew [Sat, 15 May 2021 18:09:34 +0000 (11:09 -0700)]
[Compiler-rt] Downgrade another fatal error to warning

https://reviews.llvm.org/D101681 landed a change to check the testing
configuration which relies on using the `-print-runtime-dir` flag of
clang to determine where the runtime testing library is.

The patch treated not being able to find the path reported by clang
as an error. Unfortunately this seems to break the
`llvm-clang-win-x-aarch64` bot. Either the bot is misconfigured or
clang is reporting a bogus path.

To temporarily unbreak the bot downgrade the fatal error to a warning.
While we're here also print information about the command used to
determine the path to aid debugging.

3 years ago[Compiler-rt] Downgrade fatal error about unsupported test configuration
Dan Liew [Sat, 15 May 2021 17:52:10 +0000 (10:52 -0700)]
[Compiler-rt] Downgrade fatal error about unsupported test configuration
to a warning.

https://reviews.llvm.org/D101681 introduced a check to make sure the
compiler and compiler-rt were using the same library path when
`COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON`, i.e. the developer's
intention is to test the just built libs rather that shipped with the
compiler used for testing.

It seems this broken some bots that are likely misconfigured.

So to unbreak them, for now let's make this a warning so the bot
owners can investigate without breaking their builds.

3 years agoSupport GCC's -fstack-usage flag
Pengxuan Zheng [Wed, 14 Apr 2021 20:54:47 +0000 (13:54 -0700)]
Support GCC's -fstack-usage flag

This patch adds support for GCC's -fstack-usage flag. With this flag, a stack
usage file (i.e., .su file) is generated for each input source file. The format
of the stack usage file is also similar to what is used by GCC. For each
function defined in the source file, a line with the following information is
produced in the .su file.

<source_file>:<line_number>:<function_name> <size_in_byte> <static/dynamic>

"Static" means that the function's frame size is static and the size info is an
accurate reflection of the frame size. While "dynamic" means the function's
frame size can only be determined at run-time because the function manipulates
the stack dynamically (e.g., due to variable size objects). The size info only
reflects the size of the fixed size frame objects in this case and therefore is
not a reliable measure of the total frame size.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D100509

3 years agoRevert "[X86][SSE] Pull out combineToHorizontalAddSub helper from inside (F)ADD/SUB...
Nico Weber [Sat, 15 May 2021 16:18:35 +0000 (12:18 -0400)]
Revert "[X86][SSE] Pull out combineToHorizontalAddSub helper from inside (F)ADD/SUB combines. NFCI."

This reverts commit b95a103808acfd8f33290d3e80e28af434454b28.
Makes clang assert very early in a Chromium build. See
https://bugs.chromium.org/p/chromium/issues/detail?id=1209490#c1
for a standalone repro.

3 years ago[ARM] Add an extra memset test showing reverted WLSTP loops. NFC
David Green [Sat, 15 May 2021 15:48:58 +0000 (16:48 +0100)]
[ARM] Add an extra memset test showing reverted WLSTP loops. NFC

3 years ago[X86] X86OptimizeLEAPass::replaceDebugValue - take a copy of the DebugLoc not a refer...
Simon Pilgrim [Sat, 15 May 2021 15:28:20 +0000 (16:28 +0100)]
[X86] X86OptimizeLEAPass::replaceDebugValue - take a copy of the DebugLoc not a reference as it may be deleted.

Fixes msan warning due to rG9ca2c50b3601

3 years ago[X86] X86CmovConverterPass::convertCmovInstsToBranches - take a copy of the DebugLoc...
Simon Pilgrim [Sat, 15 May 2021 15:13:34 +0000 (16:13 +0100)]
[X86] X86CmovConverterPass::convertCmovInstsToBranches - take a copy of the DebugLoc not a reference as it may be deleted.

Fixes msan warning due to rG9ca2c50b3601

3 years agoRevert rG632668c1c0e7dcf97154d2e377491cdc8cb6963c : "[TableGen] TreePatternNode:...
Simon Pilgrim [Sat, 15 May 2021 14:49:14 +0000 (15:49 +0100)]
Revert rG632668c1c0e7dcf97154d2e377491cdc8cb6963c : "[TableGen] TreePatternNode::isIsomorphicTo - early out for matching leafs. NFCI."

Revert premature (and very broken....) experimental commit.

3 years ago[TableGen] TreePatternNode::isIsomorphicTo - early out for matching leafs. NFCI.
Simon Pilgrim [Sat, 15 May 2021 14:34:43 +0000 (15:34 +0100)]
[TableGen] TreePatternNode::isIsomorphicTo - early out for matching leafs. NFCI.

If the leafs are the same then no need to perform DefInit matching.

3 years agoX86SpeculativeLoadHardeningPass::hardenValueInRegister - assert that we have a i8...
Simon Pilgrim [Sat, 15 May 2021 14:13:28 +0000 (15:13 +0100)]
X86SpeculativeLoadHardeningPass::hardenValueInRegister - assert that we have a i8/i16/i32/i64 sized register. NFCI.

Silence static analyzer warning for out-of-range access to the SubRegImms[] array.

3 years agoSampleProfileLoader::inlineHotFunctionsWithPriority - Fix uninitialized variable...
Simon Pilgrim [Sat, 15 May 2021 14:02:52 +0000 (15:02 +0100)]
SampleProfileLoader::inlineHotFunctionsWithPriority - Fix uninitialized variable warning. NFCI.

findIndirectCallFunctionSamples will leave Sum uninitialized if it returns an empty vector, we don't really use Sum in this case (but we do make a copy that isn't used either) - so ensure we initialize the value to zero to at least silence the static analysis warning.

3 years agoIfConverter::MeetIfcvtSizeLimit - Fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Sat, 15 May 2021 13:51:37 +0000 (14:51 +0100)]
IfConverter::MeetIfcvtSizeLimit - Fix uninitialized variable warnings. NFCI.

Ensure the duplication instruction counts are initialized to zero (even though they aren't used) to silence static analysis warnings.

3 years ago[CFG] Move reachable from entry checks into basic block variant
Nikita Popov [Sat, 15 May 2021 11:05:18 +0000 (13:05 +0200)]
[CFG] Move reachable from entry checks into basic block variant

These checks are not specific to the instruction based variant of
isPotentiallyReachable(), they are equally valid for the basic
block based variant. Move them there, to make sure that switching
between the instruction and basic block variants cannot introduce
regressions.

3 years ago[X86][Atom] Fix vector integer multiplication resource/throughputs
Simon Pilgrim [Sat, 15 May 2021 13:25:48 +0000 (14:25 +0100)]
[X86][Atom] Fix vector integer multiplication resource/throughputs

Match whats documented in the Intel AOM (and Agner/instlatx64 agree) - vector integer multiplies are pipelined - all Port0, throughput = 2 @ 128bits, 1 @ 64bits.

Noticed while checking reduction costs - now that we can use in-order models in llvm-mca, the atom model is the "worst case scenario" we have in x86.

3 years ago[Local] collectBitParts - bail out if we find more than one root input value.
Simon Pilgrim [Sat, 15 May 2021 12:58:42 +0000 (13:58 +0100)]
[Local] collectBitParts - bail out if we find more than one root input value.

All the uses that we have for collectBitParts revolve around us matching down to an operation with a single root value - I don't think we're intending to change that (and a lot of collectBitParts assumes it).

The binops cases (OR/FSHL/FSHR) already check if the providers are the same, but that would still mean we waste time collecting through unaryops before getting to them.

3 years ago[InstCombine] InstCombinerImpl::visitOr - enable bitreverse matching
Simon Pilgrim [Sat, 15 May 2021 12:39:09 +0000 (13:39 +0100)]
[InstCombine] InstCombinerImpl::visitOr - enable bitreverse matching

Currently we only match bswap intrinsics from or(shl(),lshr()) style patterns when we could often match bitreverse intrinsics almost as cheaply.

Differential Revision: https://reviews.llvm.org/D90170

3 years ago[X86] Try to pass DebugLoc by const-ref to avoid costly TrackingMDNodeRef copies...
Simon Pilgrim [Sat, 15 May 2021 12:23:28 +0000 (13:23 +0100)]
[X86] Try to pass DebugLoc by const-ref to avoid costly TrackingMDNodeRef copies (REAPPLIED). NFCI.

Reapply rG5ed56a821c06 (after reverted by rG7aa89c4a22fd) - don't take reference from struct that will be erased in X86FrameLowering::eliminateCallFramePseudoInstr

3 years ago[Local] collectBitParts - early-out from binops. NFCI.
Simon Pilgrim [Fri, 14 May 2021 18:09:33 +0000 (19:09 +0100)]
[Local] collectBitParts - early-out from binops. NFCI.

Minor speedup by not bothering to attempt to collect the second operand's bit parts if we already know its failed in the first operand.

3 years ago[GlobalOpt] add tests for store alignment (PR50253); NFC
Sanjay Patel [Sat, 15 May 2021 11:31:45 +0000 (07:31 -0400)]
[GlobalOpt] add tests for store alignment (PR50253); NFC

3 years ago[GlobalOpt] add test checks; NFC
Sanjay Patel [Sat, 15 May 2021 11:11:16 +0000 (07:11 -0400)]
[GlobalOpt] add test checks; NFC

I'm also adding an explicit data layout, so we can
confirm that alignment requirements/prefs are met.

I tried to use complete/scripted CHECK lines here,
but that fails with 1 of the globals, and not sure why.

3 years ago[IR] Add BasicBlock::isEntryBlock() (NFC)
Nikita Popov [Sat, 15 May 2021 10:38:27 +0000 (12:38 +0200)]
[IR] Add BasicBlock::isEntryBlock() (NFC)

This is a recurring and somewhat awkward pattern. Add a helper
method for it.

3 years ago[clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the Column...
mydeveloperday [Sat, 15 May 2021 10:29:56 +0000 (11:29 +0100)]
[clang-format]  PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit

https://bugs.llvm.org/show_bug.cgi?id=50326

{D93626} caused a regression in terms of formatting a function ptr, incorrectly thinking it was a C-Style cast.

This cased a formatter regression between clang-format-11 and clang-format-12

```
void bar()
{
    size_t foo = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

    size_t foo = function(
        Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
        FoooooooooLooooong);

    size_t foo = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

    size_t foo = (*(
        function))(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong,
        BarrrrrrrrrrrrLong, FoooooooooLooooong);
}
```

became

```
void bar()
{
    size_t foo1 = function(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong);

    size_t foo2 = function(
        Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong,
        FoooooooooLooooong);

    size_t foo3 = (*(function))(Foooo, Barrrrr, Foooo, FoooooooooLooooong);

    size_t foo4 = (*(
        function))(Foooo, Barrrrr, Foooo, Barrrr, FoooooooooLooooong, BarrrrrrrrrrrrLong, FoooooooooLooooong);
}
```

This fixes this issue by simplify the clause to be specific about what is wanted rather than what is not.

Reviewed By: curdeius, HazardyKnusperkeks

Differential Revision: https://reviews.llvm.org/D102392

3 years ago[CFG] Use comesBefore() (NFC)
Nikita Popov [Sat, 15 May 2021 10:14:30 +0000 (12:14 +0200)]
[CFG] Use comesBefore() (NFC)

Use comesBefore() instead of performing an instruction walk. In
line with the previous implementation, instructions are considered
to reach themselves.

3 years ago[CaptureTracking] Clean up same instruction check (NFC)
Nikita Popov [Sat, 15 May 2021 09:57:01 +0000 (11:57 +0200)]
[CaptureTracking] Clean up same instruction check (NFC)

Check the BeforeHere == I case once in shouldExplore, instead of
handling it in four different places.

3 years ago[Demangle][Rust] Parse char constants
Tomasz Miąsko [Fri, 14 May 2021 00:00:00 +0000 (00:00 +0000)]
[Demangle][Rust] Parse char constants

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D102524

3 years ago[Demangle][Rust] Parse bool constants
Tomasz Miąsko [Fri, 14 May 2021 00:00:00 +0000 (00:00 +0000)]
[Demangle][Rust] Parse bool constants

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D102518

3 years agoVerifier: second attempt to fix what I broke with swiftasync.
Tim Northover [Sat, 15 May 2021 07:03:43 +0000 (08:03 +0100)]
Verifier: second attempt to fix what I broke with swiftasync.

During a rebase I messed up this array, so trying to put it back to as it was
before with just one SwiftAsync entry.

3 years agoRevert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."
Douglas Yung [Sat, 15 May 2021 05:39:12 +0000 (22:39 -0700)]
Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."

This reverts commit 187a14e1f39942545b905679a8452365dfd87af8.

The test added in this commit is failing on several build bots:

https://lab.llvm.org/buildbot/#/builders/139/builds/4059
https://lab.llvm.org/buildbot/#/builders/132/builds/5605

3 years ago[sanitizer] Disable test on Android
Vitaly Buka [Sat, 15 May 2021 05:04:35 +0000 (22:04 -0700)]
[sanitizer] Disable test on Android

readelf needs access to the actual compiled binary, but it's replaced
by a wrapper script.

3 years agoFix "is not used" warning
Vitaly Buka [Sat, 15 May 2021 03:58:12 +0000 (20:58 -0700)]
Fix "is not used" warning

3 years ago[llvm-jitlink] Link libnetwork on Haiku in llvm-jitlink
Lang Hames [Sat, 15 May 2021 03:46:47 +0000 (20:46 -0700)]
[llvm-jitlink] Link libnetwork on Haiku in llvm-jitlink

The system's network API is in libnetwork.so, so we explicitly need to link to
them on Haiku. This patch is similar to https://reviews.llvm.org/D97633.

Patch by Niels Reedijk. Thanks Niels!

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D98405

3 years ago[mlir][sparse] remove accidental debug code
Aart Bik [Sat, 15 May 2021 02:26:50 +0000 (19:26 -0700)]
[mlir][sparse] remove accidental debug code

Differential Revision: https://reviews.llvm.org/D102545

3 years ago[gn build] (manually) port ad7e12226f6b
Nico Weber [Sat, 15 May 2021 02:24:39 +0000 (22:24 -0400)]
[gn build] (manually) port ad7e12226f6b

3 years ago[mlir][sparse] prepare runtime support lib for multiple dim level types
Aart Bik [Sat, 15 May 2021 02:11:39 +0000 (19:11 -0700)]
[mlir][sparse] prepare runtime support lib for multiple dim level types

We are moving from just dense/compressed to more general dim level
types, so we need more than just an "i1" array for annotations.

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D102520

3 years agoExtract a helper routine to simplify D91481 [NFC]
Philip Reames [Sat, 15 May 2021 01:40:23 +0000 (18:40 -0700)]
Extract a helper routine to simplify D91481 [NFC]

3 years ago[MC] Add the ability to pass MCRegisterInfo to dump_pretty.
Hendrik Greving [Thu, 13 May 2021 15:22:27 +0000 (08:22 -0700)]
[MC] Add the ability to pass MCRegisterInfo to dump_pretty.

Adds the ability to pass MCRegisterInfo to dump_pretty and to the print functions,
so that if present, target specific enums names are printed instead of enum values.

3 years ago[Compiler-rt] Distinguish between testing just built runtime libraries and the librar...
Dan Liew [Fri, 30 Apr 2021 23:24:33 +0000 (16:24 -0700)]
[Compiler-rt] Distinguish between testing just built runtime libraries and the libraries shipped with the compiler.

The path to the runtime libraries used by the compiler under test
is normally identical to the path where just built libraries are
created. However, this is not necessarily the case when doing standalone
builds. This is because the external compiler used by tests may choose
to get its runtime libraries from somewhere else.

When doing standalone builds there are two types of testing we could be
doing:

* Test the just built runtime libraries.
* Test the runtime libraries shipped with the compile under test.

Both types of testing are valid but it confusingly turns out compiler-rt
actually did a mixture of these types of testing.

* The `test/builtins/Unit/` test suite always tested the just built runtime
  libraries.
* All other testsuites implicitly use whatever runtime library the
  compiler decides to link.

There is no way for us to infer which type of testing the developer
wants so this patch introduces a new
`COMPILER_RT_TEST_STANDALONE_BUILD_LIBS` CMake
option which explicitly declares which runtime libraries should be
tested. If it is `ON` then the just built libraries should be tested,
otherwise the libraries in the external compiler should be tested.

When testing starts the lit test suite queries the compiler used for
testing to see where it will get its runtime libraries from.  If these
paths are identical no action is taken (the common case). If the paths
are not identical then we check the value of
`COMPILER_RT_TEST_STANDALONE_BUILD_LIBS` (progated into the config as
`test_standalone_build_libs`) and check if the test suite supports testing in the
requested configuration.

* If we want to test just built libs and the test suite supports it
  (currently only `test/builtins/Unit`) then testing proceeds without any changes.
* If we want to test the just built libs and the test suite doesn't
  support it we emit a fatal error to prevent the developer from
  testing the wrong runtime libraries.
* If we are testing the compiler's built libs then we adjust
  `config.compiler_rt_libdir` to point at the compiler's runtime
  directory. This makes the `test/builtins/Unit` tests use the
  compiler's builtin library. No other changes are required because
  all other testsuites implicitly use the compiler's built libs.

To make the above work the
`test_suite_supports_overriding_runtime_lib_path` test suite config
option has been introduced so we can identify what each test suite
supports.

Note all of these checks **have to be performed** when lit runs.
We cannot run the checks at CMake generation time because
multi-configuration build systems prevent us from knowing what the
paths will be.

We could perhaps support `COMPILER_RT_TEST_STANDALONE_BUILD_LIBS` being
`ON` for most test suites (when the runtime library paths differs) in
the future by specifiying a custom compiler resource directory path.
Doing so is out of scope for this patch.

rdar://77182297

Differential Revision: https://reviews.llvm.org/D101681

3 years ago[GlobalISel][CallLowering] Fix crash when handling a v3s32 type that's being passed...
Amara Emerson [Fri, 14 May 2021 23:21:53 +0000 (16:21 -0700)]
[GlobalISel][CallLowering] Fix crash when handling a v3s32 type that's being passed as v2s64.

3 years ago[lld][WebAssembly] Remove unused method declaration. NFC
Sam Clegg [Fri, 14 May 2021 21:58:00 +0000 (14:58 -0700)]
[lld][WebAssembly] Remove unused method declaration. NFC

This method was removed in https://reviews.llvm.org/D102265
but the declaration was missed.

3 years agoReinstate gtest fix from 4f0b0bf5c6731e3d370558be08c9261801263b09
Benjamin Kramer [Fri, 14 May 2021 22:35:13 +0000 (00:35 +0200)]
Reinstate gtest fix from 4f0b0bf5c6731e3d370558be08c9261801263b09

I missed this when merging gtest 1.10.0, breaking all asan tests :|

3 years ago[LowerConstantIntrinsics] reuse isManifestLogic from ConstantFolding
Nick Desaulniers [Fri, 14 May 2021 19:36:41 +0000 (12:36 -0700)]
[LowerConstantIntrinsics] reuse isManifestLogic from ConstantFolding

GlobalVariables are Constants, yet should not unconditionally be
considered true for __builtin_constant_p.

Via the LangRef
https://llvm.org/docs/LangRef.html#llvm-is-constant-intrinsic:

    This intrinsic generates no code. If its argument is known to be a
    manifest compile-time constant value, then the intrinsic will be
    converted to a constant true value. Otherwise, it will be converted
    to a constant false value.

    In particular, note that if the argument is a constant expression
    which refers to a global (the address of which _is_ a constant, but
    not manifest during the compile), then the intrinsic evaluates to
    false.

Move isManifestConstant from ConstantFolding to be a method of
Constant so that we can reuse the same logic in
LowerConstantIntrinsics.

pr/41459

Reviewed By: rsmith, george.burgess.iv

Differential Revision: https://reviews.llvm.org/D102367

3 years ago[libcxx][ranges] Add `contiguous_iterator`.
zoecarver [Tue, 27 Apr 2021 15:53:17 +0000 (08:53 -0700)]
[libcxx][ranges] Add `contiguous_iterator`.

Differential Revision: https://reviews.llvm.org/D101396

3 years ago[compiler-rt] Fix deprection warnings on INSTANTIATE_TEST_CASE_P
Benjamin Kramer [Fri, 14 May 2021 22:24:02 +0000 (00:24 +0200)]
[compiler-rt] Fix deprection warnings on INSTANTIATE_TEST_CASE_P