platform/upstream/ibus.git
13 years agoAdd function comments to bus/panelproxy.[ch].
Yusuke Sato [Fri, 26 Nov 2010 01:15:08 +0000 (10:15 +0900)]
Add function comments to bus/panelproxy.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3293042

13 years agoFix unexpected client capabilities in ibus-daemon.
Yusuke Sato [Thu, 25 Nov 2010 08:54:19 +0000 (17:54 +0900)]
Fix unexpected client capabilities in ibus-daemon.

BUG=none
TEST=manually

Review URL: http://codereview.appspot.com/3323041

13 years agoChange the order of engine method calls for consistency.
Yusuke Sato [Thu, 25 Nov 2010 08:40:43 +0000 (17:40 +0900)]
Change the order of engine method calls for consistency.

BUG=none
TEST=manually

Review URL: http://codereview.appspot.com/3304042

13 years agoAdd function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch].
Yusuke Sato [Thu, 25 Nov 2010 07:55:04 +0000 (16:55 +0900)]
Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch].

Removed a temporary hack for PREEDIT_CONDITION by adding bus_ibus_impl_is_embed_preedit_text function to ibusimpl.c.

BUG=none
TEST=manually

Review URL: http://codereview.appspot.com/3321041

13 years agoRe-enable the use_sys_layout feature.
Yusuke Sato [Wed, 24 Nov 2010 09:50:57 +0000 (18:50 +0900)]
Re-enable the use_sys_layout feature.

Currently use_sys_layout cannot be disabled.

BUG=none
TEST=manually

Review URL: http://codereview.appspot.com/3306041

13 years agoPass cancellable object to bus_factory_proxy_create_engine
Peng Huang [Wed, 24 Nov 2010 08:46:12 +0000 (17:46 +0900)]
Pass cancellable object to bus_factory_proxy_create_engine

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3304041

13 years agoClean up the code of focus switch logic, and fix a crash when focused context is...
Peng Huang [Wed, 24 Nov 2010 02:33:10 +0000 (11:33 +0900)]
Clean up the code of focus switch logic, and fix a crash when focused context is destroyed.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3192042

13 years agoFix some crashs when engine processes are killed.
Peng Huang [Wed, 24 Nov 2010 02:29:19 +0000 (11:29 +0900)]
Fix some crashs when engine processes are killed.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3152042

13 years agoUse g_object_add_weak_pointer to make code simpler.
Peng Huang [Wed, 24 Nov 2010 01:29:26 +0000 (10:29 +0900)]
Use g_object_add_weak_pointer to make code simpler.

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3252041

14 years agoAdd generated files into .gitignore
Jim Huang [Sun, 21 Nov 2010 17:37:04 +0000 (01:37 +0800)]
Add generated files into .gitignore

14 years agoAvoid comparison of unsigned expression
Jim Huang [Sun, 21 Nov 2010 17:24:08 +0000 (01:24 +0800)]
Avoid comparison of unsigned expression

comparison of unsigned expression < 0 is always false

14 years agoAdd assertions to connection_destroy callback
Jim Huang [Sun, 21 Nov 2010 17:15:25 +0000 (01:15 +0800)]
Add assertions to connection_destroy callback

14 years agoRemove some unused header files.
Peng Huang [Sun, 21 Nov 2010 10:13:34 +0000 (19:13 +0900)]
Remove some unused header files.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3218041

14 years agoFix NULL of focused input context
fujiwarat [Thu, 18 Nov 2010 03:23:45 +0000 (12:23 +0900)]
Fix NULL of focused input context

14 years agoAdd comments to bus/connection.[ch].
Yusuke Sato [Wed, 17 Nov 2010 10:15:38 +0000 (19:15 +0900)]
Add comments to bus/connection.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3164041

14 years agoAdd comments to bus/factoryproxy.[ch].
Yusuke Sato [Wed, 17 Nov 2010 10:14:44 +0000 (19:14 +0900)]
Add comments to bus/factoryproxy.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3163041

14 years agoAdd comments to bus/registry.[ch].
Yusuke Sato [Wed, 17 Nov 2010 08:34:29 +0000 (17:34 +0900)]
Add comments to bus/registry.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3162041

14 years agoAdd comments about thread safety.
Yusuke Sato [Wed, 17 Nov 2010 08:12:32 +0000 (17:12 +0900)]
Add comments about thread safety.

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3156041

14 years agoAdd comments to bus/component.[ch].
Yusuke Sato [Wed, 17 Nov 2010 07:01:17 +0000 (16:01 +0900)]
Add comments to bus/component.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3161041

14 years agoAdd comments to bus/ibusimpl.[ch].
Yusuke Sato [Wed, 17 Nov 2010 04:49:55 +0000 (13:49 +0900)]
Add comments to bus/ibusimpl.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3154041

14 years agoFix no defined '_' in EngineAbout
fujiwarat [Tue, 16 Nov 2010 09:11:37 +0000 (18:11 +0900)]
Fix no defined '_' in EngineAbout

14 years agoAdd introspection data for org.freedesktop.IBus.Panel and remove Destroy method.
Peng Huang [Tue, 16 Nov 2010 08:59:48 +0000 (17:59 +0900)]
Add introspection data for org.freedesktop.IBus.Panel and remove Destroy method.

Add introspection data for org.freedesktop.IBus.Panel interface.
And remove Destroy method from Panel interface, because it is moved to
org.freedesktop.IBus.Service interface.

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3137041

14 years agoAdd comments to bus/dbusimpl.[ch].
Yusuke Sato [Tue, 16 Nov 2010 06:43:12 +0000 (15:43 +0900)]
Add comments to bus/dbusimpl.[ch].

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3132041

14 years agoMake sure send the reply of method IBus.Exit out before the daemon exits.
Peng Huang [Tue, 16 Nov 2010 05:22:23 +0000 (14:22 +0900)]
Make sure send the reply of method IBus.Exit out before the daemon exits.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3133041

14 years agoAdd global variable DOMAINNAME to replace "ibus10" in everywhere.
Peng Huang [Tue, 16 Nov 2010 05:02:34 +0000 (14:02 +0900)]
Add global variable DOMAINNAME to replace "ibus10" in everywhere.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3093042

14 years agoFix ibus_version in configure and translation domain in ibus-setup.
fujiwarat [Tue, 16 Nov 2010 03:08:53 +0000 (12:08 +0900)]
Fix ibus_version in configure and translation domain in ibus-setup.

14 years agoAlways read Window as 32 bits integer to fix problem in ppc64.
fujiwarat [Thu, 11 Nov 2010 09:09:52 +0000 (18:09 +0900)]
Always read Window as 32 bits integer to fix problem in ppc64.

14 years agoUse "org.freedesktop.IBus" instead of "org.freedesktop.DBus" for the well-known bus...
Yusuke Sato [Tue, 16 Nov 2010 02:17:33 +0000 (11:17 +0900)]
Use "org.freedesktop.IBus" instead of "org.freedesktop.DBus" for the well-known bus name for the input context proxy.

Though "org.freedesktop.DBus" works fine, since bus_dbus_impl_connection_filter_cb in bus/dbusimpl.c treats the two bus names equally, "org.freedesktop.IBus" which matches the interface name looks more natural.

BUG=none
TEST=manually done

Review URL: http://codereview.appspot.com/3128041

14 years agoRemove block call in ibus-daemon, and use async call instead and clean up code.
Peng Huang [Tue, 16 Nov 2010 01:24:03 +0000 (10:24 +0900)]
Remove block call in ibus-daemon, and use async call instead and clean up code.

1. Do not use poll factory of a component. Sometime, it will cause a dead lock of ibus: ibus-daemon are waiting reply from engine, and engine are also waiting for reply from ibus-daemon.
2. Move some API from IBusComponent to BusComponent, Because of those API is for internal using only
3. Add a fake input context in server side to support switching input method when no context has focus.
4. Remove fake input context in imcontext, because we added the server side fake context

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/3077042

14 years agoAdd function comments to bus/server.[ch]
Yusuke Sato [Mon, 15 Nov 2010 08:39:51 +0000 (17:39 +0900)]
Add function comments to bus/server.[ch]

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3040041

14 years agoAdd function comments to bus/main.c.
Yusuke Sato [Mon, 15 Nov 2010 04:05:27 +0000 (13:05 +0900)]
Add function comments to bus/main.c.

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3036041

14 years agoDelete src/ibusserver.[ch] that are no longer used.
Yusuke Sato [Mon, 15 Nov 2010 04:02:23 +0000 (13:02 +0900)]
Delete src/ibusserver.[ch] that are no longer used.

BUG=none
TEST=none

Review URL: http://codereview.appspot.com/3018042

14 years agoDisable snooper in chromium, chrome, firefox and gnome-do
Peng Huang [Fri, 12 Nov 2010 01:12:22 +0000 (10:12 +0900)]
Disable snooper in chromium, chrome, firefox and gnome-do

Those applications has problems with snooper enabled. So update the
NO_SNOOPER_APPS to disable snooper for those applications by default.

BUG=ibus:1140
TEST=manual

14 years agoRemove a debug output
Peng Huang [Thu, 4 Nov 2010 03:58:13 +0000 (12:58 +0900)]
Remove a debug output

14 years agoRemove GDK_DISPLAY, this macro has been removed in gtk3
fujiwarat [Tue, 2 Nov 2010 05:12:06 +0000 (14:12 +0900)]
Remove GDK_DISPLAY, this macro has been removed in gtk3

http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B

14 years agoUpdate python test scripts for gobject-introspection
Peng Huang [Thu, 4 Nov 2010 03:05:39 +0000 (12:05 +0900)]
Update python test scripts for gobject-introspection

14 years agoRemove the ability to attach to a status icon with libnotify 0.7.0
fujiwarat [Thu, 4 Nov 2010 02:07:36 +0000 (11:07 +0900)]
Remove the ability to attach to a status icon with libnotify 0.7.0

14 years agoRefine some code and remove some dead code.
Peng Huang [Thu, 4 Nov 2010 00:38:23 +0000 (09:38 +0900)]
Refine some code and remove some dead code.

14 years agoFix some issues within codereview.
Peng Huang [Wed, 3 Nov 2010 04:37:57 +0000 (13:37 +0900)]
Fix some issues within codereview.

14 years agoFix crash when icon of property is Null
Peng Huang [Tue, 2 Nov 2010 11:30:02 +0000 (20:30 +0900)]
Fix crash when icon of property is Null

14 years agoFix UnsetValue name.
fujiwarat [Mon, 1 Nov 2010 09:16:25 +0000 (18:16 +0900)]
Fix UnsetValue name.

14 years agoFix serialized order.
fujiwarat [Mon, 1 Nov 2010 07:13:55 +0000 (16:13 +0900)]
Fix serialized order.

14 years agoRename ibus_engine_desc_new2 and ibus_component_new2 to *_new_varargs.
Peng Huang [Mon, 1 Nov 2010 06:05:29 +0000 (15:05 +0900)]
Rename ibus_engine_desc_new2 and ibus_component_new2 to *_new_varargs.

wip.

14 years agoFix a typo.
Peng Huang [Mon, 1 Nov 2010 05:03:17 +0000 (14:03 +0900)]
Fix a typo.

14 years agoFix a typo in client/gtk3/Makefile.am
Peng Huang [Fri, 29 Oct 2010 08:28:13 +0000 (17:28 +0900)]
Fix a typo in client/gtk3/Makefile.am

14 years agoFix some problems in debian packages.
Peng Huang [Fri, 29 Oct 2010 08:08:38 +0000 (17:08 +0900)]
Fix some problems in debian packages.

14 years agoAdd i18n.py.
Peng Huang [Fri, 29 Oct 2010 05:25:50 +0000 (14:25 +0900)]
Add i18n.py.

14 years agoFix some merge failed.
Peng Huang [Fri, 29 Oct 2010 03:16:52 +0000 (12:16 +0900)]
Fix some merge failed.

14 years agoRewrite memconf in c languages.
Peng Huang [Thu, 28 Oct 2010 04:00:54 +0000 (13:00 +0900)]
Rewrite memconf in c languages.

14 years agoEmit NameOwnerChanged signal with non-zero serial to make libdbus happy.
Peng Huang [Wed, 27 Oct 2010 05:36:30 +0000 (14:36 +0900)]
Emit NameOwnerChanged signal with non-zero serial to make libdbus happy.

14 years agoAdd metadata file to fix some object ownership correctly
Peng Huang [Wed, 27 Oct 2010 05:35:36 +0000 (14:35 +0900)]
Add metadata file to fix some object ownership correctly

14 years agoAdd vala test for config module
Peng Huang [Tue, 26 Oct 2010 04:50:36 +0000 (13:50 +0900)]
Add vala test for config module

14 years agoFix vala and gir build issues.
Peng Huang [Thu, 21 Oct 2010 12:03:37 +0000 (21:03 +0900)]
Fix vala and gir build issues.

14 years agoRemove ibusdbus.h
Peng Huang [Wed, 20 Oct 2010 11:48:07 +0000 (20:48 +0900)]
Remove ibusdbus.h

14 years agowip.
Peng Huang [Wed, 20 Oct 2010 10:48:01 +0000 (19:48 +0900)]
wip.

14 years agowip.
Peng Huang [Wed, 20 Oct 2010 08:15:56 +0000 (17:15 +0900)]
wip.

14 years agoFix some runtime errors.
Peng Huang [Tue, 19 Oct 2010 12:19:06 +0000 (21:19 +0900)]
Fix some runtime errors.

14 years agoChange version to 1.3.99
Peng Huang [Tue, 19 Oct 2010 09:23:19 +0000 (18:23 +0900)]
Change version to 1.3.99

14 years agoUse va_list in IBusEngineDesc and IBusComponent for back compatibility.
Peng Huang [Tue, 19 Oct 2010 01:26:08 +0000 (10:26 +0900)]
Use va_list in IBusEngineDesc and IBusComponent for back compatibility.

Provided by fujiwarat <takao.fujiwara1@gmail.com>

Conflicts:

bus/engineproxy.c
bus/factoryproxy.c
bus/ibusimpl.c
src/ibuscomponent.c
src/ibusenginedesc.c
src/test-bus.c
src/tests/ibus-global-engine.c

14 years agoUse gdbus in glib, and get rid of libdbus
Peng Huang [Wed, 16 Jun 2010 15:47:09 +0000 (23:47 +0800)]
Use gdbus in glib, and get rid of libdbus

14 years agoReplace s/gdk_drawable_get_size/gdk_window_get_height/ for GTK3.
fujiwarat [Tue, 2 Nov 2010 02:21:24 +0000 (11:21 +0900)]
Replace s/gdk_drawable_get_size/gdk_window_get_height/ for GTK3.

14 years agoUse block mode of g_main_context_iteration to avoid consuming too much cpu time.
Peng Huang [Fri, 29 Oct 2010 09:46:07 +0000 (18:46 +0900)]
Use block mode of g_main_context_iteration to avoid consuming too much cpu time.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/2768043

14 years agoUse the automake 1.10 in autogen.sh
Peng Huang [Tue, 26 Oct 2010 10:27:56 +0000 (19:27 +0900)]
Use the automake 1.10 in autogen.sh

BUG=ibus:1039
TEST=manual

Review URL: http://codereview.appspot.com/2746041

14 years agosort combo box by locale strcoll
Peng Wu [Mon, 25 Oct 2010 06:52:21 +0000 (14:52 +0800)]
sort combo box by locale strcoll

14 years agoFix s/python/@PYTHON@/ in libexec scripts.
fujiwarat [Tue, 26 Oct 2010 02:49:48 +0000 (11:49 +0900)]
Fix s/python/@PYTHON@/ in libexec scripts.

The patch is provided by federico.schwindt@google.com

14 years agoFix ENV value for NetBSD
fujiwarat [Tue, 26 Oct 2010 02:45:29 +0000 (11:45 +0900)]
Fix ENV value for NetBSD

14 years agoBump the version to 1.3.8 1.3.8
Peng Huang [Fri, 22 Oct 2010 06:15:39 +0000 (15:15 +0900)]
Bump the version to 1.3.8

14 years agoComment out test-keymap test case.
Peng Huang [Fri, 22 Oct 2010 06:15:12 +0000 (15:15 +0900)]
Comment out test-keymap test case.

Comment out test-keymap test case, because it is not automatic test
case. it will cause make distcheck failed.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/2667041

14 years agoLimit typing rate to 800 hits/minutes, and fix make distcheck error.
Peng Huang [Fri, 22 Oct 2010 05:56:12 +0000 (14:56 +0900)]
Limit typing rate to 800 hits/minutes, and fix make distcheck error.

The old version test-stress will send key events to ibus-daemon as fast as possible. It will take all CPU resources, and the daemon, UI and input methods will not get enouch CPU resources to process those events. So all key events will be putted in the buffer. It will causes out of system memory. So I add a limitation of typing rate as 800 hits/minute.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/2662042

14 years agoCatch exceptions from os.kill.
Peng Huang [Fri, 22 Oct 2010 03:27:37 +0000 (12:27 +0900)]
Catch exceptions from os.kill.

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/2659042

14 years agoFix CPU 100% usage with signal.SIGCHLD
fujiwarat [Thu, 21 Oct 2010 09:44:40 +0000 (18:44 +0900)]
Fix CPU 100% usage with signal.SIGCHLD

14 years agoFix keyval and state in __keycode_button_clicked_cb
fujiwarat [Thu, 21 Oct 2010 08:30:42 +0000 (17:30 +0900)]
Fix keyval and state in __keycode_button_clicked_cb

14 years agoDestroy existing connection before creating a new connection, and only create the...
Peng Huang [Thu, 21 Oct 2010 08:27:12 +0000 (17:27 +0900)]
Destroy existing connection before creating a new connection, and only create the fake context once.

BUG=chromium-os:7998
TEST=manual

Review URL: http://codereview.appspot.com/2640041

14 years agoMove the candidate window just above the cursor when the window and a preedit string...
Yusuke Sato [Thu, 21 Oct 2010 04:27:06 +0000 (13:27 +0900)]
Move the candidate window just above the cursor when the window and a preedit string overlap.

BUG=http://code.google.com/p/ibus/issues/detail?id=1106
TEST=manually done.

Review URL: http://codereview.appspot.com/2599041

14 years agoRemove compiler warnings.
Yusuke Sato [Thu, 21 Oct 2010 01:35:07 +0000 (10:35 +0900)]
Remove compiler warnings.

BUG=none
TEST=checked by ./autogen.sh && make

Review URL: http://codereview.appspot.com/2632041

14 years agoEnable key snooper by default again, except Chrome/Chromium browsers, to fix applicat...
Yusuke Sato [Wed, 20 Oct 2010 13:21:00 +0000 (22:21 +0900)]
Enable key snooper by default again, except Chrome/Chromium browsers, to fix application compatibility issues like 1068.

This change is logically a revert of http://github.com/ibus/ibus/commit/7e715146794d5fa5324885f8d1dcebb8805bc31b

The new behavior is:

1) If IBUS_DISABLE_SNOOPER environment variable is set, and the value of the variable is "" (an empty string) or "0" or "false" or "False" or "FALSE", key snooper is enabled.
2) If IBUS_DISABLE_SNOOPER environment variable is set, and the value of the variable is other than the 5 above, e.g. "1", "true", .., key snooper is disabled.
3) If IBUS_DISABLE_SNOOPER environment variable is not set, and ibus-daemon is explicitly configured with --disable-key-snooper, key snooper is disabled.
4) If IBUS_DISABLE_SNOOPER environment variable is not set, and ibus-daemon is not configured with --disable-key-snooper, the GTK_IM_MODULE, im-ibus.so, checks IBUS_NO_SNOOPER_APPS environment variable:
  4-a) if IBUS_NO_SNOOPER_APPS environment variable is not set, and the application name matches ".*chrome", key snooper is disabled.
  4-b) if IBUS_NO_SNOOPER_APPS environment variable, which should be comma-separated regexps, is set, and one of the regexps matches the application name, key snooper is disabled.
  4-c) otherwise, key snooper is enabled.

Please note that when no configure options nor no environment variables are set, key snooper is enabled on all applications except Chrome/Chromium web browsers. For example, key snooper would be enabled on xchat and gedit by default. I believe the new default behavior would satisfy both Linux desktop and Chromium OS requirements.

Test:

- With ibus built without --disable-key-snooper:

yusukes@harapeko:~$ gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER= gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER=0 gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="0" gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="false" gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="False" gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="FALSE" gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="1" gedit  # no-snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="true" gedit  # no-snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="unknownstring" gedit  # no-snoop

yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=gedit gedit  # no-snoop
yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS='g.*dit' gedit  # no-snoop
yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS='foobar,g.*dit' gedit  # no-snoop
yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar gedit  # snoop

yusukes@harapeko:~$ google-chrome  # no-snoop
yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar google-chrome  # snoop

- With ibus built with --disable-key-snooper:

yusukes@harapeko:~$ gedit  # no-snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="false" gedit  # snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="true" gedit  # no-snoop
yusukes@harapeko:~$ IBUS_DISABLE_SNOOPER="unknownstring" gedit  # no-snoop
yusukes@harapeko:~$ IBUS_NO_SNOOPER_APPS=foobar gedit   # no-snoop, because IBUS_NO_SNOOPER_APPS is ignored when --disable-key-snooper is specified.

BUG=http://code.google.com/p/ibus/issues/detail?id=1068
TEST=manually done. see above.

Review URL: http://codereview.appspot.com/2568043

14 years agoAlways consume the hotkey, even if the hotkey associated engine already activated.
Peng Huang [Wed, 20 Oct 2010 11:53:36 +0000 (20:53 +0900)]
Always consume the hotkey, even if the hotkey associated engine already activated.

BUG=6376
TEST=manual

Review URL: http://codereview.appspot.com/2596042

14 years agoFix race condition in bus_ibus_impl_create_engine()
Yusuke Sato [Tue, 19 Oct 2010 11:30:09 +0000 (20:30 +0900)]
Fix race condition in bus_ibus_impl_create_engine()

If the bus_ibus_impl_create_engine() function is called right after an ibus_component_start() call, the function might fail getting a factory object.

To avoid the problem, we should use the busy-wait logic even when ibus_component_is_running() returns true.

BUG=http://crosbug.com/7244
TEST=see the bug (comment #4,7,9)

Review URL: http://codereview.appspot.com/2562041

14 years agoFix a build error of IBus-1.0.gir with gobject-introspection 0.9.6
fujiwarat [Wed, 13 Oct 2010 05:05:02 +0000 (14:05 +0900)]
Fix a build error of IBus-1.0.gir with gobject-introspection 0.9.6

14 years agoFix a typo.
Peng Huang [Tue, 12 Oct 2010 23:14:58 +0000 (08:14 +0900)]
Fix a typo.

14 years agoRemove unused dbus-1 package in gir includes
Peng Huang [Fri, 8 Oct 2010 02:41:41 +0000 (10:41 +0800)]
Remove unused dbus-1 package in gir includes

BUG=none
TEST=manual

Review URL: http://codereview.appspot.com/2331041

14 years agoImplement stress tool for ibus.
Hirotake Kobayashi [Fri, 1 Oct 2010 15:45:49 +0000 (00:45 +0900)]
Implement stress tool for ibus.

A test-stress.c sends key message each time by client.
Client.h and client.c store modifier key and send key event.
They check ibus-daemon and engine is alive.

Review URL: http://codereview.appspot.com/2204051
Patch from Hirotake Kobayashi <hkobayash@google.com>.

14 years agoFix a build error with GTK3 gdkkeysyms.h
fujiwarat [Thu, 30 Sep 2010 01:58:31 +0000 (10:58 +0900)]
Fix a build error with GTK3 gdkkeysyms.h

14 years agoUpdate gu.po from Sweta Kothari <swkothar@redhat.com>
Peng Huang [Mon, 20 Sep 2010 22:57:10 +0000 (06:57 +0800)]
Update gu.po from Sweta Kothari <swkothar@redhat.com>

14 years agoFix g_assertion failure in bus_ibus_impl_{load,save}_global_engine_name functions.
Yusuke Sato [Fri, 17 Sep 2010 13:26:50 +0000 (22:26 +0900)]
Fix g_assertion failure in bus_ibus_impl_{load,save}_global_engine_name functions.

Add NULL checks to the functions so they don't abort with assertion failure even if the functions are called before the ibus configuration daemon gets ready.
See http://code.google.com/p/chromium-os/issues/detail?id=6689#c27 for details.

14 years agoAdd some comments about registry
Peng Huang [Fri, 10 Sep 2010 11:04:25 +0000 (19:04 +0800)]
Add some comments about registry

BUG=none
TEST=built fine

Review URL: http://codereview.appspot.com/2159046

14 years agoAdd Emacs modeline for .c and .h files.
Satoru Takabayashi [Thu, 9 Sep 2010 04:24:42 +0000 (13:24 +0900)]
Add Emacs modeline for .c and .h files.

/* -*- mode: C; c-basic-offset: 4; indent-tabs-mode: nil; -*- */

TEST=confirmed that the modelines for vim and emacs both worked.
BUG=none

Review URL: http://codereview.appspot.com/2168042

14 years agoMove the log handler code from bus/main.cc to src/ibusshare.cc.
Satoru Takabayashi [Thu, 9 Sep 2010 02:05:55 +0000 (11:05 +0900)]
Move the log handler code from bus/main.cc to src/ibusshare.cc.

The log handler is useful for IBus client programs. For instance,
the log handler was used inside the chromium browser for debugging
IBus startup issue:

http://code.google.com/p/chromium-os/issues/detail?id=6375#c29

(chrome:11824): IBUS-DEBUG: 00:00:46.929430: The socket file is now created (monitoring done).

BUG=none
TEST=manually ran ibus-daemon with and without -v

Review URL: http://codereview.appspot.com/2122047

14 years agoAdd codereview.settings.
Satoru Takabayashi [Wed, 8 Sep 2010 06:58:31 +0000 (15:58 +0900)]
Add codereview.settings.

This is for us to use codereview.appspot.com for code reviews.

Instructions to use codereview.appspot.com:

1. Get depot_tools and add PATH to the directory
http://dev.chromium.org/developers/how-tos/depottools

2. In your local IBus git repository,

% git checkout master
% git checkout -b somefix
make changes
% git cl upload
do code reviews at codereview.appspot.com
once it's done, run "git cl push" if you can commit.
otherwise, ask committers to commit on behalf.

Review URL: http://codereview.appspot.com/2166043

14 years agoAdd time info in log message from satorux@chromium.org
Peng Huang [Tue, 7 Sep 2010 00:35:03 +0000 (08:35 +0800)]
Add time info in log message from satorux@chromium.org

14 years agoFix memory leak in ibus_input_context_process_key_event by Fujiwarat
Peng Huang [Mon, 6 Sep 2010 09:17:24 +0000 (17:17 +0800)]
Fix memory leak in ibus_input_context_process_key_event by Fujiwarat

14 years agoFix segv in bus_engine_proxy_process_key_event_reply_cb
fujiwarat [Thu, 2 Sep 2010 03:58:42 +0000 (12:58 +0900)]
Fix segv in bus_engine_proxy_process_key_event_reply_cb

14 years agoSet CFLAGS to "-Wall -Werror" in autogen.sh
Peng Huang [Mon, 6 Sep 2010 08:16:51 +0000 (16:16 +0800)]
Set CFLAGS to "-Wall -Werror" in autogen.sh

14 years agoFix property issue.
Peng Huang [Thu, 12 Aug 2010 07:22:00 +0000 (15:22 +0800)]
Fix property issue.

14 years agoUpdate fr.po
Peng Huang [Fri, 6 Aug 2010 06:02:25 +0000 (14:02 +0800)]
Update fr.po

14 years agoFix a build warning
Peng Huang [Thu, 5 Aug 2010 09:13:56 +0000 (17:13 +0800)]
Fix a build warning

14 years agoRelease 1.3.7 1.3.7
Peng Huang [Tue, 3 Aug 2010 08:59:32 +0000 (16:59 +0800)]
Release 1.3.7

14 years agoUpdate ko.po
Peng Huang [Tue, 3 Aug 2010 06:43:42 +0000 (14:43 +0800)]
Update ko.po

14 years agoUpdate po files.
Peng Huang [Tue, 3 Aug 2010 02:04:19 +0000 (10:04 +0800)]
Update po files.

14 years agoMake sure that we won't wrongly match a hotkey after losing and getting focus.
James Su [Tue, 29 Jun 2010 02:39:31 +0000 (19:39 -0700)]
Make sure that we won't wrongly match a hotkey after losing and getting focus.

BUG=http://crosbug.com/3892
TEST=manually

Review URL: http://codereview.chromium.org/2884006