Mike Blumenkrantz [Thu, 20 Oct 2022 14:26:48 +0000 (10:26 -0400)]
zink: ZINK_DESCRIPTOR_TYPES -> ZINK_DESCRIPTOR_BASE_TYPES
slightly more clear
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19205>
Mike Blumenkrantz [Thu, 20 Oct 2022 14:15:46 +0000 (10:15 -0400)]
zink: rename some variables in descriptor code
this is more accurate
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19205>
Qiang Yu [Thu, 16 Jun 2022 08:19:46 +0000 (16:19 +0800)]
radeonsi: implement nir shader query enabled intrinsics
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Qiang Yu [Thu, 16 Jun 2022 08:12:13 +0000 (16:12 +0800)]
radeonsi: implement llvm abi atomic_add_prim_count
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Qiang Yu [Fri, 1 Jul 2022 03:38:00 +0000 (11:38 +0800)]
ac/nir/ngg: add streamout emitted primitive query
For radeonsi to implement GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Qiang Yu [Wed, 15 Jun 2022 08:50:13 +0000 (16:50 +0800)]
ac/nir/ngg: add query param to ac_nir_lower_ngg_gs
radeonsi may disable it. gfx_level will also be used by latter
vertex param export when gfx11.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Qiang Yu [Tue, 25 Oct 2022 06:20:04 +0000 (14:20 +0800)]
nir: add nir_load_prim_xfb_query_enabled_amd
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Qiang Yu [Thu, 16 Jun 2022 07:54:54 +0000 (15:54 +0800)]
nir,ac,radv: add primitive count add intrinsics
radeonsi use shader buffer, but radv use gds for the query
result storage.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17457>
Samuel Pitoiset [Mon, 24 Oct 2022 08:27:15 +0000 (08:27 +0000)]
radv: disable dual source blending in more situations
According to PAL, there is more restrictions that RADV doesn't have.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19278>
Pierre-Eric Pelloux-Prayer [Tue, 18 Oct 2022 09:37:22 +0000 (11:37 +0200)]
radeonsi: handle sqtt pipeline in shader prefetch
When sqtt is enabled, the shader code lives in the pipeline bo,
not in the shader bo.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Tue, 18 Oct 2022 09:36:58 +0000 (11:36 +0200)]
radeonsi: store the shader gpu adress in si_shader
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Tue, 18 Oct 2022 09:35:25 +0000 (11:35 +0200)]
radeonsi/sqtt: simplify condition to determine if sqtt is on
We don't need to load screen->debug_flags because sctx->thread_trace
is already telling us if sqtt is enabled.
Furthermore we can perform this check only for GFX9 because sqtt
isn't supported currently on older chips.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Tue, 18 Oct 2022 09:03:24 +0000 (11:03 +0200)]
radeonsi: simplify si_prefetch_shaders
Since
93cd96b5237 the only used value of si_L2_prefetch_mode
was PREFETCH_ALL so we can remove some dead code in si_prefetch_shaders.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Tue, 4 Oct 2022 08:33:52 +0000 (10:33 +0200)]
radeonsi/tests: update expected results for polaris11
Using the latest released LLVM version 15.0.1.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Mon, 3 Oct 2022 12:19:37 +0000 (14:19 +0200)]
radeonsi/tests: update expected results for navi10
Using the latest released LLVM version 15.0.1.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Wed, 28 Sep 2022 12:44:51 +0000 (14:44 +0200)]
radeonsi/tests: update expected results for navi21
Using the latest released LLVM version 15.0.1.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Thu, 29 Sep 2022 13:21:07 +0000 (15:21 +0200)]
radeonsi/tests: simplify the script
And use exit(0) on success, exit(1) on failure.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Thu, 29 Sep 2022 13:20:00 +0000 (15:20 +0200)]
radeonsi/tests: handle flakes file for all test suite
And a generic flakes file that applies to all GPUs.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Mon, 26 Sep 2022 12:43:24 +0000 (14:43 +0200)]
radeonsi/sqtt: allow to disable spm counters
And fix rgp capture on GFX9 (where spm was disabled by default).
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Mon, 26 Sep 2022 12:34:03 +0000 (14:34 +0200)]
radeonsi/sqtt: re-export shaders in a single bo
RGP expects a pipeline's shaders to be all stored sequentially, eg:
[vs][ps][gs]
As such, it assumes a single bo is dumped to the .rgp file, with
the following info:
* va of the bo
* offset to each shader inside the bo
For radeonsi, the shaders are stored individually, so we may have
a big gap between the shaders forming a pipeline => we can produce
very large file because the layout in the file must match the one
in memory (see the warning in ac_rgp_file_write_elf_text).
This commit implements a workaround: gfx shaders are re-exported as a
pipeline.
To update the shader address, a new state is created (sqtt_pipeline),
which will overwrite the needed _PGM_LO_* registers.
This reduces DeuxEX rgp captures from 150GB+ to less than 100MB.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Pierre-Eric Pelloux-Prayer [Mon, 26 Sep 2022 09:34:16 +0000 (11:34 +0200)]
radeonsi/sqtt: notify sqtt when we skip a flush
Otherwise we may not produce any data because
si_handle_thread_trace is never called.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18865>
Yonggang Luo [Thu, 20 Oct 2022 19:56:49 +0000 (03:56 +0800)]
util: #include "c11/threads.h" instead of #include "util/u_cpu_detect.h" u_format.c
As it does not access any symbols in util/u_cpu_detect.h but accessed symbols in "c11/threads.h"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266>
Yonggang Luo [Thu, 20 Oct 2022 19:18:35 +0000 (03:18 +0800)]
util: Move UTIL_MAX_CPUS from u_thread.h to u_cpu_detect.h
UTIL_MAX_CPUS is not used by u_thread.* anymore after commit
"util: replace UTIL_MAX_CPUS by util_cpu_caps.num_cpu_mask_bits"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266>
Yonggang Luo [Thu, 20 Oct 2022 19:16:14 +0000 (03:16 +0800)]
util: Merge duplicated function prototype in u_thread.h that named with util_barrier*
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266>
Yonggang Luo [Thu, 20 Oct 2022 19:15:02 +0000 (03:15 +0800)]
util: Remove non used UTIL_MAX_L3_CACHES in u_thread.h
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19266>
Karmjit Mahil [Mon, 10 Oct 2022 09:26:24 +0000 (10:26 +0100)]
pvr: Change pvr_get_hw_clear_color() to pack based on accum formats.
`pvr_get_hw_clear_color()` now packs formats based on the accum
format which is how the hw deals with the formats internally and
might not line up exactly with the vk format representation.
E.g. R5G6B5_UNORM_PACK16 uses the U8 accum format so the USC will
internally use 3 bytes (1 per component) to deal with it instead
of 2 bytes which the vk format specifies. On USC EMITPIX, the PBE
will pack the results to 2 bytes using PACKMODE_R5G6B5 resulting
in the final value being in the vk format representation.
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19218>
Karmjit Mahil [Mon, 5 Sep 2022 08:45:54 +0000 (09:45 +0100)]
pvr: Add PBE accum format size in bytes.
This will be used later on to implement
vkCmdClearAttachments() where we'll need to pick the
appropriate clear color shader based on the dwords used.
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19218>
Erik Faye-Lund [Thu, 20 Oct 2022 10:09:59 +0000 (12:09 +0200)]
docs: vmware -> VMware
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:41:05 +0000 (11:41 +0200)]
docs: healthcheck -> health check
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:14:32 +0000 (11:14 +0200)]
docs: dependant -> dependent
We generally prefer US English in the docs, so let's correct this.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:02:41 +0000 (11:02 +0200)]
docs: virtualisation -> virtualization
We generally perfer US English spelling in our docs, so let's fix up
this one word.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:38:35 +0000 (11:38 +0200)]
docs: Linux fbdev -> Linux Framebuffer
It's either "fbdev" or "Linux Framebuffer", not "Linux fbdev". Since we
can spare the extra letters here, let's spell it out.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:56:54 +0000 (10:56 +0200)]
docs: servo -> Servo
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 07:47:18 +0000 (09:47 +0200)]
docs: skqp -> SkQP
This seems to be the official styling of the name.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:38:01 +0000 (17:38 +0200)]
docs: lava -> LAVA
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 13:30:44 +0000 (15:30 +0200)]
docs: hw -> HW
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 13:28:13 +0000 (15:28 +0200)]
docs: xyzw -> XYZW
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:15:01 +0000 (17:15 +0200)]
docs: Gitlab -> GitLab
While we're at it, also fixup a single case of "Ci" -> "CI"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 14:06:16 +0000 (16:06 +0200)]
docs: meson -> Meson
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:44:04 +0000 (10:44 +0200)]
docs: ArchLinux -> Arch Linux
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 11:04:11 +0000 (13:04 +0200)]
docs: autotools -> Autotools
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:58:09 +0000 (14:58 +0200)]
docs: ppir -> PPIR
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:57:31 +0000 (14:57 +0200)]
docs: lima -> Lima
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:26:56 +0000 (17:26 +0200)]
docs: vulkan -> Vulkan
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:45:29 +0000 (11:45 +0200)]
docs: llvmpipe -> LLVMpipe
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:53:01 +0000 (10:53 +0200)]
docs: nouveau -> Nouveau
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:49:22 +0000 (10:49 +0200)]
docs: radeon -> Radeon
Let's also do radeonsi -> RadeonSI while we're at it.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 10:48:46 +0000 (12:48 +0200)]
docs: adreno -> Adreno
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:28:39 +0000 (11:28 +0200)]
docs: freedreno -> Freedreno
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:13:13 +0000 (10:13 +0200)]
docs: lavapipe -> Lavapipe
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 10:00:58 +0000 (12:00 +0200)]
docs: perfetto -> Perfetto
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:46:52 +0000 (14:46 +0200)]
docs: rgb -> RGB
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:52:02 +0000 (10:52 +0200)]
docs: gpu -> GPU
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:59:19 +0000 (14:59 +0200)]
docs: cpu -> CPU
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 09:46:20 +0000 (11:46 +0200)]
docs: pci -> PCI
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 09:36:52 +0000 (11:36 +0200)]
docs: xorg -> X.Org
Also one case of Xorg
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:05:58 +0000 (11:05 +0200)]
docs: irc -> IRC
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 08:38:57 +0000 (10:38 +0200)]
docs: ip -> IP
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 08:12:57 +0000 (10:12 +0200)]
docs: use consistent casing for dEQP
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 14:26:11 +0000 (16:26 +0200)]
docs: consistently spell Haswell in camel-case
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 14:05:07 +0000 (16:05 +0200)]
docs: consistently spell VirGL in camel-case
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 14:02:19 +0000 (16:02 +0200)]
docs: consistently spell API all-caps
While we're at it, drop an incorrect apostrophe.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 13:59:33 +0000 (15:59 +0200)]
docs: consistently use CMake
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 15:18:44 +0000 (17:18 +0200)]
docs: consistently spell OK in allcaps
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 15:14:37 +0000 (17:14 +0200)]
docs: consistently spell URL in allcaps
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 13:49:44 +0000 (15:49 +0200)]
docs: consistently spell ANV in allcaps
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 08:24:59 +0000 (10:24 +0200)]
docs: consistently spell DRI in all-caps
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Tue, 18 Oct 2022 12:19:19 +0000 (14:19 +0200)]
docs: consistently upper-case VC4, V3D etc
This is how we're doing this elsewhere in the docs, and upper-casing is
a clear indication that this is a name.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:37:49 +0000 (14:37 +0200)]
docs: XOR'd -> XORed
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 09:25:48 +0000 (11:25 +0200)]
docs: eg. -> e.g.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 09:23:21 +0000 (11:23 +0200)]
docs: use the official spelling of SHA-1
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:30:43 +0000 (11:30 +0200)]
docs: spell out "distribution"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 11:08:10 +0000 (13:08 +0200)]
docs: spell out "environment variable"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 10:04:56 +0000 (12:04 +0200)]
docs: spell out "SHA256 checksum"
This isn't such a magical word, no need to quote it.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 09:58:05 +0000 (11:58 +0200)]
docs: spell out "build directory"
This is a bit less cryptic than "builddir", and it's the same wording as
the meson docs uses.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 08:40:36 +0000 (10:40 +0200)]
docs: correct spelling of "Copr"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:07:39 +0000 (17:07 +0200)]
docs: correct spelling of "Gouraud"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:02:07 +0000 (17:02 +0200)]
docs: correct spelling of "specifies"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 15:00:12 +0000 (17:00 +0200)]
docs: correct spelling of "semantic"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 12:43:41 +0000 (14:43 +0200)]
docs: correct spelling of "irrespective"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Thu, 20 Oct 2022 09:53:56 +0000 (11:53 +0200)]
docs: correct spelling of "passes"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Erik Faye-Lund [Wed, 19 Oct 2022 10:52:56 +0000 (12:52 +0200)]
docs: correct spelling of "addition"
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19191>
Fabian Vogt [Fri, 21 Oct 2022 09:20:31 +0000 (11:20 +0200)]
gallivm: Fix LLVM optimization with the new pass manager
The previous list of passes contained several errors: "constprop" does not
exist anymore and a trailing ',' is not allowed. This made LLVMRunPasses
fail, but the error is silently ignored. Thus none of the listed passes
ran at all.
https://reviews.llvm.org/D85159 suggests "InstSimplify really should be
used anywhere ConstProp is being used" so replace constprop with
instsimplify and remove the trailing comma.
By enabling pass logging with
LLVMPassBuilderOptionsSetDebugLogging(opts, true),
the difference is visible. Before:
Running pass: AlwaysInlinerPass on [module]
Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module> on [module]
Running analysis: ProfileSummaryAnalysis on [module]
Running pass: CoroConditionalWrapper on [module]
Running pass: AnnotationRemarksPass on fs_variant_partial (1162 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_partial
Running pass: AnnotationRemarksPass on fs_variant_whole (1110 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_whole
After:
Running pass: AlwaysInlinerPass on [module]
Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module> on [module]
Running analysis: ProfileSummaryAnalysis on [module]
Running pass: CoroConditionalWrapper on [module]
Running pass: AnnotationRemarksPass on fs_variant_partial (1162 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_partial
Running pass: AnnotationRemarksPass on fs_variant_whole (1110 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_whole
Running analysis: InnerAnalysisManagerProxy<llvm::FunctionAnalysisManager, llvm::Module> on [module]
Running pass: SROAPass on fs_variant_partial (1162 instructions)
Running analysis: DominatorTreeAnalysis on fs_variant_partial
Running analysis: AssumptionAnalysis on fs_variant_partial
Running analysis: TargetIRAnalysis on fs_variant_partial
Running pass: EarlyCSEPass on fs_variant_partial (1111 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_partial
Running pass: SimplifyCFGPass on fs_variant_partial (961 instructions)
Running pass: ReassociatePass on fs_variant_partial (961 instructions)
Running pass: PromotePass on fs_variant_partial (897 instructions)
Running pass: InstCombinePass on fs_variant_partial (897 instructions)
Running analysis: OptimizationRemarkEmitterAnalysis on fs_variant_partial
Running analysis: AAManager on fs_variant_partial
Running analysis: BasicAA on fs_variant_partial
Running analysis: ScopedNoAliasAA on fs_variant_partial
Running analysis: TypeBasedAA on fs_variant_partial
Running analysis: OuterAnalysisManagerProxy<llvm::ModuleAnalysisManager, llvm::Function> on fs_variant_partial
Running pass: SROAPass on fs_variant_whole (1110 instructions)
Running analysis: DominatorTreeAnalysis on fs_variant_whole
Running analysis: AssumptionAnalysis on fs_variant_whole
Running analysis: TargetIRAnalysis on fs_variant_whole
Running pass: EarlyCSEPass on fs_variant_whole (1059 instructions)
Running analysis: TargetLibraryAnalysis on fs_variant_whole
Running pass: SimplifyCFGPass on fs_variant_whole (912 instructions)
Running pass: ReassociatePass on fs_variant_whole (912 instructions)
Running pass: PromotePass on fs_variant_whole (844 instructions)
Running pass: InstCombinePass on fs_variant_whole (844 instructions)
Running analysis: OptimizationRemarkEmitterAnalysis on fs_variant_whole
Running analysis: AAManager on fs_variant_whole
Running analysis: BasicAA on fs_variant_whole
Running analysis: ScopedNoAliasAA on fs_variant_whole
Running analysis: TypeBasedAA on fs_variant_whole
Running analysis: OuterAnalysisManagerProxy<llvm::ModuleAnalysisManager, llvm::Function> on fs_variant_whole
Fixes:
2037c34f245 ("gallivm: move to new pass manager to handle coroutines change.")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19217>
Daniel Schürmann [Fri, 21 Oct 2022 09:09:46 +0000 (11:09 +0200)]
aco: change thread_local memory resource to pointer
Apparently the TLS constructor doesn't work well if RADV
is instantiated multiple times and/or used by a program with
already existing threads.
Fixes:
a128d444cbf4f74b0bdd4a8ae3f1cd2a52dee122 ('aco: use monotonic_buffer_resource for instructions')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19219>
Roman Gilg [Sun, 23 Jan 2022 13:04:05 +0000 (14:04 +0100)]
loader/dri3: Add DRI performance option to wait for next buffer on swap
For simple clients using the swap chain contention back pressure to regulate
their drawing and that don't query buffer age introduce a new DRI option with
which set to true (the default is false) we block the client until a new buffer
is available. This way we stall the client's execution until a new buffer is
available and the redrawing of the client starts only at this point and not
before.
The motivation for that is to reduce latency for clients that regulate their
drawing by swapchain contention back pressure. These clients draw whenever
possible and their drawing is implicitly stopping whenever we block. When we
block at the end of the swap and return only when a new buffer is available
the client can draw and we directly present. Otherwise the client would draw,
we block on the buffer becoming available, and only then show what the client
had drawn, usually one frame later.
Co-authored-by: Michel Dänzer <michel@daenzer.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14684>
Roman Gilg [Mon, 24 Jan 2022 16:14:44 +0000 (17:14 +0100)]
loader/dri3: Simplify buffer age query
The ternary operator is hard to read. Instead initialize the return variable
to zero and adjust its value in an if-clause.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14684>
David Heidelberg [Sat, 22 Oct 2022 19:41:49 +0000 (21:41 +0200)]
ci/linker: update mold to 1.6 and enable on s390x
Since 1.6 is s390x supported platform.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19254>
Eric Engestrom [Fri, 5 Aug 2022 12:45:47 +0000 (13:45 +0100)]
vc4: don't use imprecise_32bit_lowering for idiv lowering
This is known to produce bogus results for certain combinations of
operands, so don't use it. See this issue for details:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/6555
None of the shaders in shaderdb are affected by this change, as all of
the shaders containing an integer division require a higher GLSL version
than vc4 supports and are therefore all skipped.
This is port of the v3d change
73e8fc3efbfe4a46bfd5ca5b3269d06f086bc224
to vc4; we expect the impact to be the same as for v3d, based on testing
a custom shader.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18019>
Eric Engestrom [Fri, 5 Aug 2022 12:47:22 +0000 (13:47 +0100)]
vc4: don't lower uadd_carry
We can produce slightly better code for these in the backend, so
do that.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18019>
Qiang Yu [Mon, 10 Oct 2022 08:35:06 +0000 (16:35 +0800)]
ac/nir/ngg,radv: use different counters for shader queries
VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT should count for each
stream.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7409
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19015>
Qiang Yu [Mon, 10 Oct 2022 03:08:40 +0000 (11:08 +0800)]
nir,ac/nir/ngg,radv: split shader_query_enabled_amd
For used by different counter.
Vulkan:
1. VK_QUERY_PIPELINE_STATISTIC_GEOMETRY_SHADER_PRIMITIVES_BIT,
sum generated primitives of all 4 streams when GS.
2. VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT, count generated
primitives for all 4 streams when VS/TES/GS.
3. VK_QUERY_TYPE_TRANSFORM_FEEDBACK_STREAM_EXT, count generated
and streamout primitives for all 4 streams when VS/TES/GS.
OpenGL:
1. GL_GEOMETRY_SHADER_PRIMITIVES_EMITTED_ARB, sum generated
primitives for all 4 streams when GS.
2. GL_PRIMITIVES_GENERATED, count generated primitives for all 4
streams when VS/TES/GS.
3. GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN, count streamout
primitives for all 4 streams when VS/TES/GS.
pipeline_stat_query_enabled_amd is for Vulkan 1 and OpenGL 1.
xfb_query_enabled_amd is for Vulkan 2/3 and OpenGL 2/3.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19015>
Qiang Yu [Mon, 10 Oct 2022 02:52:27 +0000 (10:52 +0800)]
radv: split active_pipeline_gds_queries
For different enabling of pipeline stat and prims gen.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19015>
Qiang Yu [Mon, 10 Oct 2022 02:39:29 +0000 (10:39 +0800)]
radv: count gen_prims_queries_enabled
User can enable/disable multi VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT
queries with same or different index.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19015>
Mike Blumenkrantz [Fri, 21 Oct 2022 15:43:56 +0000 (11:43 -0400)]
zink: delete unused zink descriptor mode
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Mon, 24 Oct 2022 17:40:58 +0000 (13:40 -0400)]
zink: support multiple heaps per memory type
some allocations require a different memory heap even when using the
same memory bits, so allow iterating over heaps of the same memory type
to find the one that works
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Mon, 24 Oct 2022 17:26:31 +0000 (13:26 -0400)]
zink: allocate/place memory using memoryTypeIndex directly
it's possible for drivers to have multiple heaps with identical flags,
so this will enable passing the heap that should actually be used for
allocation
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Mon, 24 Oct 2022 15:58:13 +0000 (11:58 -0400)]
zink: allow direct memory mapping for any COHERENT+CACHED buffer
some drivers may provide this in heaps that get used by non-staging resources,
so avoid extra copies in that case
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Mon, 24 Oct 2022 14:03:55 +0000 (10:03 -0400)]
zink: don't flag ubo0 as used in shaders with indirect ubo access
ubo0 is not a regular ubo, so avoid setting the hint here
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Sun, 23 Oct 2022 14:36:34 +0000 (10:36 -0400)]
zink: decrement ZINK_FBFETCH_BINDING
there's no reason this shouldn't be contiguous with the other gfx stages
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19281>
Mike Blumenkrantz [Thu, 20 Oct 2022 16:23:04 +0000 (12:23 -0400)]
zink: fix gpl compile optimization
this is supposed to create the non-optimized pipeline first and then
compile the optimized version in the background, not the other way around
facepalm.
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19201>