Mike Blumenkrantz [Wed, 29 May 2019 13:18:15 +0000 (09:18 -0400)]
elm: don't attempt to load clouseau when running in tree
Summary:
clouseau doesn't work anyway
Depends on D8964
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8965
Mike Blumenkrantz [Wed, 29 May 2019 13:18:09 +0000 (09:18 -0400)]
elm/hovers: don't trigger more errors when setting null hover parent
Summary:
null is not a valid subobject, do not attempt to add it
@fix
Depends on D8963
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8964
Mike Blumenkrantz [Wed, 29 May 2019 13:18:01 +0000 (09:18 -0400)]
elm/gengrid: handle focus events when no previous focus item was set
Summary:
this triggers fewer error messages
@fix
Depends on D8962
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8963
Mike Blumenkrantz [Wed, 29 May 2019 13:17:55 +0000 (09:17 -0400)]
elm/gengrid: more null checks for setting mirrored state during construction
Summary:
sd->obj is only non-null later in construction, so add even more checks for it
here
@fix
Depends on D8961
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8962
Mike Blumenkrantz [Wed, 29 May 2019 13:17:24 +0000 (09:17 -0400)]
elm/gengrid: handle cache item deletion without errors
Summary:
@fix
Depends on D8959
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8960
Mike Blumenkrantz [Wed, 29 May 2019 13:17:18 +0000 (09:17 -0400)]
elm/entry: use edje functions directly for interacting with edje objects
Summary:
this eliminates a number of errors triggered when processing class hierarchy
to reach the desired subobject with these edje functions
@fix
Depends on D8958
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8959
Mike Blumenkrantz [Wed, 29 May 2019 13:17:12 +0000 (09:17 -0400)]
elm/diskselector: trigger sizing eval during theme set only if finalized
Summary:
this can't be successfully completed until the object has been fully constructed
@fix
Depends on D8957
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8958
Mike Blumenkrantz [Wed, 29 May 2019 13:17:07 +0000 (09:17 -0400)]
elm/diskselector: fix handling in theme data setup
Summary:
the previous code checked for the object which was required to execute
the remainder of the function, then returned if that object existed instead
of continuing with the function. hello?
@fix
Depends on D8956
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8957
Mike Blumenkrantz [Wed, 29 May 2019 13:17:00 +0000 (09:17 -0400)]
elm/colorselector: return early from theme apply if object is not yet finalized
Summary:
the remainder of this function cannot be handled until objects are set up
later in construction
@fix
Depends on D8955
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8956
Mike Blumenkrantz [Wed, 29 May 2019 13:16:53 +0000 (09:16 -0400)]
elm/layout: do not trigger sizing eval at end of canvas_group_add
Summary:
this can never succeed as there will never be an object to successfully
size with at this point
@fix
Depends on D8954
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8955
Mike Blumenkrantz [Wed, 29 May 2019 13:16:48 +0000 (09:16 -0400)]
elm/layout: do not trigger sizing eval on subobj deletion if no resize_obj set
Summary:
this has no effect since the resize_obj is what determines sizing
@fix
Depends on D8953
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8954
Mike Blumenkrantz [Wed, 29 May 2019 13:16:41 +0000 (09:16 -0400)]
efl_ui_focus_manager/calc: handle redirect setting if no previous redirect set
Summary:
use same pointer for conditional to improve readability, avoid passing null to
efl_ui_focus_manager_reset_history() which cannot be passed null
@fix
Depends on D8952
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8953
Mike Blumenkrantz [Wed, 29 May 2019 13:16:35 +0000 (09:16 -0400)]
eina/prefix: ignore magic files when running in tree
Summary:
this just can't work.
@fix
Depends on D8951
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8952
Mike Blumenkrantz [Wed, 29 May 2019 13:16:30 +0000 (09:16 -0400)]
eina/file: use INFO log level when eina_file_open fails
Summary:
this function is commonly used to detect the existence of files using
its return value. for this purpose, printing warnings any time the file
cannot be opened is spammy and not very helpful in the context of detecting
actual errors.
Depends on D8950
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8951
Mike Blumenkrantz [Wed, 29 May 2019 13:15:13 +0000 (09:15 -0400)]
efl_canvas_layout: permit part_type_get on invalid parts
Summary:
this is the only way to determine whether a part is invalid, so it should
be usable without triggering errors
@fix
Depends on D8948
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8949
Mike Blumenkrantz [Wed, 29 May 2019 13:15:06 +0000 (09:15 -0400)]
edje/load: (more) correctly handle part updates after changing edje group
Summary:
if a part changes its type, verify that the new type is compatible AND
exists before attempting to re-set the previous state, otherwise take
action and print warning
@fix
Depends on D8947
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8948
Mike Blumenkrantz [Wed, 29 May 2019 13:14:56 +0000 (09:14 -0400)]
ecore/timer: fix handling of timer freeze during construction
Summary:
timer has no loop pointer until it is finalized
@fix
Depends on D8918
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8947
Mike Blumenkrantz [Wed, 29 May 2019 13:14:08 +0000 (09:14 -0400)]
gl_generic: handle image orientation setting when texture has not been created
Summary:
this occurs when orientation is set during image construction
@fix
Reviewers: segfaultxavi, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8916
Mike Blumenkrantz [Wed, 29 May 2019 13:13:10 +0000 (09:13 -0400)]
edje/calc: correctly handle swallow/group objects as clippers for state clips
Summary:
in the case where the clipper being set was an indirect object, it's necessary
to resolve the lookup for that part and use the actual part object to avoid
setting a placeholder rect as the clipper
@fix
Depends on D8850
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8851
Xavi Artigas [Wed, 29 May 2019 13:13:32 +0000 (15:13 +0200)]
Efl.Ui.Flip: Silence warning
The Efl.Ui.Orientation enum is actually made of flags, which we can OR
together, and it includes bitmasks for easier manipulation.
gcc expects switch() statemenets to include all enum values and nothing
but the valid enum values, which is abit too restrictive for flags.
Casting to int removes the warning.
Yeongjong Lee [Wed, 29 May 2019 08:24:30 +0000 (17:24 +0900)]
efl_ui_relative_layout: prevent infinite loop in chain calculation
Test Plan:
test code
```
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Eo *win, *layout, *btn1, *btn2, *btn3;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get());
layout = efl_add(EFL_UI_RELATIVE_LAYOUT_CLASS, win,
efl_content_set(win, efl_added));
btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout);
btn2 = efl_add(EFL_UI_BUTTON_CLASS, layout);
efl_ui_relative_layout_relation_right_set(layout, btn1, btn2, 0.0);
efl_ui_relative_layout_relation_right_set(layout, btn2, btn1, 0.0);
efl_ui_relative_layout_relation_left_set(layout, btn2, btn1, 1.0);
efl_ui_relative_layout_relation_left_set(layout, btn1, btn2, 1.0);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9032
Yeongjong Lee [Wed, 29 May 2019 08:24:21 +0000 (17:24 +0900)]
efl_ui_relative_layout: allow to respect the min size of its child
Summary: It will have the same policy as the Efl.Ui.Box, Table.
Test Plan: elementary_test -to 'efl.ui.relative_layout'
Reviewers: Jaehyun_Cho, herb
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9029
Jaehyun Cho [Fri, 31 May 2019 12:26:06 +0000 (21:26 +0900)]
fix migration build error of missing efl_ui_clickable
efl_ui_clickable.c and efl_ui_clickable_util.c are moved in elementary
so Makefile_Elementary_Tizen.am should contain these files.
Change-Id: Ie273c58fe3e00bd517a274dccc7f56b08e6140a1
JunsuChoi [Thu, 30 May 2019 10:55:01 +0000 (19:55 +0900)]
Edje_types: Remove @beta mark
Change-Id: I72fc1f20c87df11cb6e59a7d42790c2144b1e96b
JunsuChoi [Thu, 30 May 2019 01:17:24 +0000 (10:17 +0900)]
fix migration build errors
Gerrit efl HEAD :
4f51631cff14e68c3c37c227b3f575d0113b945d
Opensource efl HEAD :
4f51631cff14e68c3c37c227b3f575d0113b945d
Change-Id: Ibb873816d1fd38e08b58826fc674d3b0db78152e
Marcel Hollerbach [Tue, 28 May 2019 16:01:57 +0000 (12:01 -0400)]
efl_ui: add a helper for not tollerating errors in a testsuite
Summary:
We now also fail in the focus tests
Depends on D9021
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9022
Marcel Hollerbach [Tue, 28 May 2019 16:01:50 +0000 (12:01 -0400)]
efl_ui_suite: fix errors in focus tests
Summary:
there have been a few cases where things were just wrong. Like missing
regular nodes in a focus manager that received focus, and stuff like
this. This now fixes all those cases.
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9021
Vincent Torri [Tue, 28 May 2019 15:37:03 +0000 (11:37 -0400)]
Evil: fix infinite loop with setlocale
Summary: evil_setlocale was defined as setlocale in evil_private.h *before* evil_setlocale, hence evil_setlocale was calling itself. The solution was to not call evil_private.h in evil_locale.c
Test Plan: compialtion and elementary_test
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7985
Differential Revision: https://phab.enlightenment.org/D9030
Xavi Artigas [Tue, 28 May 2019 15:13:49 +0000 (17:13 +0200)]
eolian: allow parts named like methods
Summary:
The C# bindings turn parts into class properties, so part names cannot clash
with method names.
However, a "Part" prefix has been recently added, just like it was done for
events, and therefore this eolian restriction can be lifted.
With this patch part name clashes are only checked among parts, just like it
is done for events.
Relates to D8582
Test Plan: Everything still builds, because we have no part-method name clashes in the tree, but now they are possible.
Reviewers: q66, SanghyeonLee
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9031
Alastair Poole [Sun, 26 May 2019 23:59:56 +0000 (23:59 +0000)]
build: Fix on OpenBSD.
This adds support for OpenBSD with meson build
system. Also use better paths. This resolves
further issues when building EFL.`
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9028
Vincent Torri [Mon, 27 May 2019 06:58:51 +0000 (15:58 +0900)]
ecore_evas win32: fix warning reported by clang
Test Plan: compilation
Reviewers: zmike, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9025
Vincent Torri [Mon, 27 May 2019 06:56:41 +0000 (15:56 +0900)]
Evas gesture: do not use abs when dealing with double, use fabs instead
Summary: clang reports a warning here. We compare the result of abs (casting to an int, returning an int) to a double value. Hence we should use fabs instead
Test Plan: compilation
Reviewers: Jaehyun, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9024
Hermet Park [Mon, 27 May 2019 05:36:44 +0000 (14:36 +0900)]
efl_ui_textpath: redraw text properly.
It needs redraw since text draw depends on the obj' size.
Daniel Kolesa [Sun, 26 May 2019 16:35:48 +0000 (18:35 +0200)]
eolian: add runtime API to get file format version
This is useful for FFI based bindings (like the Lua or Python ones)
and so on.
Daniel Kolesa [Sun, 26 May 2019 16:30:02 +0000 (18:30 +0200)]
eolian: prevent parsing when eo file version is too new
Daniel Kolesa [Sun, 26 May 2019 16:24:40 +0000 (18:24 +0200)]
eolian: add test for file versioning
Daniel Kolesa [Sun, 26 May 2019 16:21:27 +0000 (18:21 +0200)]
elua: add version_get API for units in eolian bindings
Daniel Kolesa [Sun, 26 May 2019 16:19:20 +0000 (18:19 +0200)]
eolian: add API to query unit version
Daniel Kolesa [Sun, 26 May 2019 16:09:34 +0000 (18:09 +0200)]
eolian: initial versioning implementation
This implements initial support for specifying unit versions.
The default version is 1, specifying the basic feature level.
If you want to specify another version, you need to specify
something like `#version 2` at the beginning of the .eo or
.eot file; the version number must be higher than 0 and lower
than USHRT_MAX (typically 65536).
The beginning of the file is now called the "header section";
other things may be added into the header section later.
Version cannot be specified twice, and it cannot be specified
once other contents (like types or class definition) appear.
Comments do not count as other contents, so those are fine
to appear before #version.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:41:22 +0000 (17:41 +0200)]
eolian: rename @warn_unused and its associated API
@warn_unused in syntax is now called @no_unused - this is because
"warning about unused" is a C thing (or rather, an extension to C)
and various languages might want to use stricter behavior for this.
Its associated API does the reverse now - it lets you query whether
being unused is allowed at all. This is to match future behavior
of Eolian (once it supports versioning) that will likely reverse it.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:25:15 +0000 (17:25 +0200)]
eolian: remove param @nonull
This has been deprecated for a while and is not strictly necessary
- as a part of an effort to stabilize Eolian, remove this. Eolian
will eventually gain support for versioning and use a reversed
behavior (i.e. no NULL by default), but the API it wlll use for
that will be very different. Features can always be added, it's
much harder to drop them.
@feature
Xavi Artigas [Fri, 24 May 2019 16:30:31 +0000 (12:30 -0400)]
Rename Efl.Ui.Direction -> Efl.Ui.Layout_Orientation
Summary:
This clarifies a bit the whole Orientation vs. Direction confusion, at the
expense of longer names (Image_Orientation vs. Layout_Orientation).
Also, the interfaces are now adjectives (Orientable) and the enums have long
names (*_Orientation).
Pretty big patch, but no functional changes.
Relates to T7863
Test Plan:
Everything builds and passes tests.
Elementary_tests show same behavior, including the "inverted" widgets, which
are the only parts which received a bit of code changes.
Proof:
https://travis-ci.org/Enlightenment/efl/builds/
536277282
Reviewers: zmike, bu5hm4n, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8946
Xavi Artigas [Fri, 24 May 2019 09:26:06 +0000 (11:26 +0200)]
Fix last missing reference to old efl_orientation headers
This is now efl_gfx_orientable.
We are not building the C++ examples, so I did not pick this up sooner.
Travis does not build C++ bidings at all.
Jaehyun Cho [Fri, 24 May 2019 08:46:16 +0000 (17:46 +0900)]
efl_mono: fix autogen make check error
Previously, autogen make check error happened because
some .eo.h files were not generated but were included in
libefl_mono_native_test.h.
Now, all .eo.c and .eo.h files are generated.
Also CLEANFILES are fixed to include all the generated files.
Lauro Moura [Thu, 23 May 2019 23:45:29 +0000 (20:45 -0300)]
csharp: Fix autotools build
Summary: After the tests split
Reviewers: vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9015
Mike Blumenkrantz [Thu, 23 May 2019 17:55:50 +0000 (13:55 -0400)]
efl/gesture: include .h file in private header, not .c file
Summary:
a generated eolian c file cannot be included multiple times or else it will
create multiple definitions of symbols defined in that file and break the build
ref
54175998d538e0b2173fc023bb822f1e6536e58f
fix T7960
Reviewers: devilhorns, vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Maniphest Tasks: T7960
Differential Revision: https://phab.enlightenment.org/D8945
Mike Blumenkrantz [Thu, 23 May 2019 13:32:11 +0000 (09:32 -0400)]
elm_widget_item_static_focus: mark param as used
Summary: Depends on D8935
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8936
Mike Blumenkrantz [Thu, 23 May 2019 13:32:00 +0000 (09:32 -0400)]
efl_ui_focus_manager_sub: handle manager change when tree is set to unfocusable
Summary:
in this case, the event is emitted and no manager exists because the objects
are not focusable
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8935
Mike Blumenkrantz [Thu, 23 May 2019 13:31:50 +0000 (09:31 -0400)]
elm_color_class: use legacy event for genlist selection
Summary:
this fixes the selection callback and makes the widget work again
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D8913
Mike Blumenkrantz [Thu, 23 May 2019 13:31:42 +0000 (09:31 -0400)]
evas/render: fix proxy clipping when source_clip is disabled
Summary:
when source_clip is disabled, the clipper used should be the one used by
the proxy object. previously this would never be the case, meaning that
disabling source_clip had no effect
@fix
Depends on D8879
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8880
Vincent Torri [Thu, 23 May 2019 11:25:27 +0000 (20:25 +0900)]
Emotion gst1 module: fix "empty if statement" warning
Summary: the macro GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS can be undefined (see gst core doc), hence the if statement may have no body
Test Plan: compilation
Reviewers: zmike, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8939
Vincent Torri [Thu, 23 May 2019 11:24:46 +0000 (20:24 +0900)]
Emotion gst1 module: remove whitespaces
Reviewers: zmike, cedric, raster, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8938
Shinwoo Kim [Thu, 23 May 2019 11:11:44 +0000 (20:11 +0900)]
Efl.Ui.Textpath: fix a size problem
Summary:
Textpath set its hint_size using its position and calulated path information.
The path information is calculated using center postion, radius & start angle.
For example, if textpath position is 0,0 and center positon of path is 100,100
and radius 50, then text will be located on the rigth side of textpath object.
Moreover there is another problem.
[Step to reproduce]
1. Launch elementary_test
2. open Efl.Ui.Textpath
3. see circle is not center aligned.
4. click Clockwise 1 ~ 2 times center position is changed repeatedly.
This occurs because textpath size is calculated by position_set.
It does not make sense that changing postion defines its size.
So this patch is setting textpath hint_size using only given center position.
The text will position on the middle of textpath object always.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8930
Lauro Moura [Wed, 22 May 2019 20:21:02 +0000 (17:21 -0300)]
csharp: Split test files
Summary: Make it easier to add new tests
Reviewers: vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8937
Xavi Artigas [Wed, 22 May 2019 18:16:16 +0000 (14:16 -0400)]
Rename Efl.Gfx.Orientation -> Efl.Gfx.Image_Orientation
Summary:
This will help disambiguate later on when we rename Efl.Ui.Direction
to Efl.Ui.Layout_Orientation.
Relates to T7919
Test Plan: Everything still builds and passes tests.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8934
Christopher Michael [Wed, 22 May 2019 12:45:24 +0000 (08:45 -0400)]
benchmarks: Fix copy-paste error
Coverity reports this as a copy-paste error, and checking the code it
certainly looks that way, so lets call the proper hash function here
Fixes CID1401052
@fix
Hosang Kim [Wed, 22 May 2019 12:01:58 +0000 (08:01 -0400)]
ecore_ipc: close dialer io closer when dialer is deleted.
Summary:
dialer uses copier class, so dialer's close on invalidate flag is EINA_FALSE.
Therefore dialer io closer is not closed automatically.
Reviewers: barbieri, raster, Hermet, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8922
Vincent Torri [Wed, 22 May 2019 11:59:05 +0000 (07:59 -0400)]
include evil_private.h in last files, and disable symbolic links on Windows in a couple of files
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8933
Christopher Michael [Wed, 22 May 2019 11:37:36 +0000 (07:37 -0400)]
ecore-evas-drm: Check if vblank is supported
Small patch to check if the video driver supports drmWaitVBlank. If
not, we can fall back to timer based animators and avoid freezing (due
to usage of vsync'd animators).
@fix
Christopher Michael [Wed, 22 May 2019 11:35:45 +0000 (07:35 -0400)]
ecore-drm2: Add API to check if vblank is supported
This patch adds a small API that we can use to check if the current
video driver supports the usage of drmWaitVBlank. This check is
required for certain drivers (like vbox) which do not support
drmWaitVBlank and thus are causing our animators in ecore_evas to
freeze. We can now use this API from within Ecore_Evas to disable
vsync'd animators and fall back to timer based ones.
@feature
Xavi Artigas [Tue, 21 May 2019 18:23:17 +0000 (20:23 +0200)]
evas/scale_sample: even more code deduplication
Summary:
how many times was this block of code copied around???
no functional changes
Depends on D8848
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8849
Mike Blumenkrantz [Tue, 21 May 2019 18:23:16 +0000 (20:23 +0200)]
evas/scale_sample: remove unnecessary clamping to mask geometry
Summary:
this is now handled entirely in the masking helper function
no functional changes
Depends on D8847
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8848
Mike Blumenkrantz [Tue, 21 May 2019 18:23:15 +0000 (20:23 +0200)]
evas/scale_sample: further deduplicate masking code
Summary:
by adding a couple extra params to existing functions, we can reuse
existing code instead of copying it around and adding more bugs
no functional changes
Depends on D8846
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8847
Mike Blumenkrantz [Tue, 21 May 2019 18:23:13 +0000 (20:23 +0200)]
evas/scale_sample: deduplicate masking code
Summary:
these functions provide identical functionality to the inline blocks
no functional changes
Depends on D8841
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8846
Vincent Torri [Tue, 21 May 2019 17:35:01 +0000 (13:35 -0400)]
Eio: avoid symbolic link on Windows
Summary: On Windows, symbolic links do not exist
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8931
Marcel Hollerbach [Tue, 21 May 2019 16:28:47 +0000 (12:28 -0400)]
eina: move builtin detection to eina_config.h
Summary: this means we don't need to handle this in the buildtool at all.
Reviewers: vtorri, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8553
Daniel Kolesa [Tue, 21 May 2019 14:01:07 +0000 (16:01 +0200)]
eolian: remove @nullable keyword
This was an experiment that never properly took off and was never
used by any generator. Its use was highly variable, so it could
not be relied upon. We will still want to reverse the current
behavior eventually (no null by default), but that will be
done with eo file versioning in the future.
@feature
Daniel Kolesa [Tue, 21 May 2019 13:43:02 +0000 (15:43 +0200)]
docs: remove obsolete docgen from the tree
This has long been replaced with tools/edocgen.git and most likely
does not even work.
Shinwoo Kim [Tue, 21 May 2019 05:31:12 +0000 (14:31 +0900)]
Efl.Ui.Textpath: support center align for each direction
Summary:
The textpath draws text from the start_angle. User needs to set correct
start_angle to center the text. This start_angle could be changed according to
each parameters of circle_set such as x, y, radius, direction and text itself.
So this patch is introducing direction EFL_UI_TEXTPATH_DIRECTION_CC(W)_CENTER.
The center of textpath will be located at the start_angle with this direction.
Test Plan: I will add example if this patch is acceptable.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8892
Shinwoo Kim [Tue, 21 May 2019 01:47:58 +0000 (10:47 +0900)]
Efl.Ui.Textpath: draw text immediately in the position.set
Summary:
Efl.Ui.Textpath was drawing its text on the job. Because of this, textpath was
slower than other objects which are scrolling on the same scroller.
So this patch makes textpath not use job in the position.set.
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8924
Xavi Artigas [Mon, 20 May 2019 18:25:19 +0000 (20:25 +0200)]
autotools: add new ui_image tests to proper makefile
Mike Blumenkrantz [Mon, 20 May 2019 15:34:51 +0000 (17:34 +0200)]
elm_test: add efl.ui.image tests which mimic elm_image tests
Summary:
these should look and feel the same as the original tests.
should.
Depends on D8914
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8915
Mike Blumenkrantz [Mon, 20 May 2019 15:52:20 +0000 (11:52 -0400)]
elm_test: fix some bugs in elm_image tests
Summary:
* passing label object to elm_image_file_get
* using fill hint during weight set
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8914
Xavi Artigas [Mon, 20 May 2019 15:52:10 +0000 (11:52 -0400)]
Rename Efl.Orient -> Efl.Gfx.Orientation
Summary:
And the Efl.Orientation interface -> Efl.Gfx.Orientable
(with proper c_prefix so it is not too cumbersome to use from C).
Also, turned the theme_rotation_apply() parameter into an int to avoid confusion.
Fixes T7919
Depends on D8912
Test Plan: Everything continues to build and pass tests
Reviewers: zmike, bu5hm4n, cedric, Hermet, Jaehyun_Cho
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7919
Differential Revision: https://phab.enlightenment.org/D8926
Xavi Artigas [Mon, 20 May 2019 15:51:56 +0000 (11:51 -0400)]
Merge Efl.Orient and Efl.Flip into the same enum
Summary:
This is similar to how it is in Evas, and simplifies the Efl.Orientation
interface, which only needs one property now.
Relates to T7919
Test Plan: Everything builds and tests pass. There's only one example of efl_orientation_set() so there's not much to test yet.
Reviewers: zmike, bu5hm4n, cedric, Hermet, Jaehyun_Cho
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7919
Differential Revision: https://phab.enlightenment.org/D8912
Vincent Torri [Mon, 20 May 2019 13:10:00 +0000 (09:10 -0400)]
remove Evil.h when not necessary, include evil_private.h when necessary
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8925
Hermet Park [Mon, 20 May 2019 12:52:11 +0000 (08:52 -0400)]
evas example: add a png scale down example.
Reviewers: cedric, #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8886
Marcel Hollerbach [Mon, 20 May 2019 12:48:29 +0000 (08:48 -0400)]
meson: fix installed .eo files and fix cross compile
Summary:
if things are a array in a array, then flattening only seems to work
when the first element is a target object. But not when the first
element is then also an string, then the string in the array gets
concatted and added to root array. This is a meson bug, investigation
going on. Additionally, this fixes installed .eo files, as we might want
to installed gesture files when we require them in other objects.
Reviewers: Jaehyun_Cho, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8910
Vincent Torri [Mon, 20 May 2019 12:46:02 +0000 (08:46 -0400)]
Evas: remove Evil.h when not needed and use evil_private when needed
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8921
Xavi Artigas [Thu, 16 May 2019 11:03:33 +0000 (13:03 +0200)]
Efl.Pack_Table: remove table_direction
Summary:
The only implementation of this interface, `Efl.Ui.Table`, only supports two fill
directions (horizontal or vertical), therefore the table_direction property which
supports primary and secondary directions is unnecessarily complicated. Remove it
and use only `Efl.Ui.Direction.direction` to select the fill direction.
Also, expanded the documentation.
Fixes T7962
Test Plan:
Everything builds and tests pass. Efl.Ui.Table elementary_test still work.
Examples need to be adjusted to stop using table_direction.
Reviewers: zmike, YOhoho, bu5hm4n, SanghyeonLee, Jaehyun_Cho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7962
Differential Revision: https://phab.enlightenment.org/D8902
Vincent Torri [Fri, 17 May 2019 18:02:21 +0000 (14:02 -0400)]
bin/ecore_evas: remove useless inclusion of Evil.h
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8917
Vincent Torri [Fri, 17 May 2019 17:51:50 +0000 (13:51 -0400)]
bin/eet and ecore_con: remove Evil.h when not necessary and include evil_private.h when necessary
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8911
Daniel Kolesa [Fri, 17 May 2019 14:08:23 +0000 (16:08 +0200)]
eolian tests: rename owning.eo.c to clear confusion
Jaehyun Cho [Fri, 17 May 2019 08:35:00 +0000 (17:35 +0900)]
efl_mono: generate efl_canvas_text.eo.cs
To use canvas text in efl csharp bindings, it is permitted to generate
efl_canvas_text.eo.cs.
Vincent Torri [Fri, 17 May 2019 10:52:58 +0000 (11:52 +0100)]
Eet: remove useless inclusion of Evil.h
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8909
Vincent Torri [Fri, 17 May 2019 10:52:41 +0000 (11:52 +0100)]
bin/efl and ecore: include evil_private.h when appropriate
Test Plan: compilation
Reviewers: raster, zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8908
Jaehyun Cho [Fri, 17 May 2019 10:32:24 +0000 (19:32 +0900)]
evas_gesture: fix meson.build to build and install correctly
Vincent Torri [Thu, 16 May 2019 17:49:39 +0000 (13:49 -0400)]
Evil: remove fall through warning
Summary: gcc and clang support the usage of "fall through" comment to suppress this warning
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8904
Vincent Torri [Thu, 16 May 2019 17:48:59 +0000 (13:48 -0400)]
Eina: replace Evil.h with evil_private.h and remove Evil.h when not necessary
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8903
Xavi Artigas [Thu, 16 May 2019 16:06:46 +0000 (18:06 +0200)]
docfx: Use the public repo url for www-content
Otherwise, you need to have credentials, etc.
Daniel Kolesa [Thu, 16 May 2019 13:57:39 +0000 (15:57 +0200)]
eolian: rename eolian_event_c_name_get
This is for consistency with the new eolian_class_c_macro_get
as well as for better clarity, as c_name_get is already provided
by Object and refers to something else.
Daniel Kolesa [Thu, 16 May 2019 13:52:46 +0000 (15:52 +0200)]
eolian: rename eolian_typedecl_enum_field_c_name_get
This is to allow for better object oriented APIs, as the `c_name`
field would be inherited from Object. This also makes it more
clear in C.
Daniel Kolesa [Thu, 16 May 2019 13:31:37 +0000 (15:31 +0200)]
eolian: add API to retrieve the C name of an object
This is to prepare for type/class renaming support. This adds
the necessary API to retrieve C-specific names. Other refactoring
is necessary elsewhere for now.
This also renames the old API eolian_class_c_name_get to
eolian_class_c_macro_get to avoid conflict as well as clarify
the intention.
Vincent Torri [Thu, 16 May 2019 12:36:12 +0000 (14:36 +0200)]
Eo: replace Evil.h with evil_private.h
Test Plan: compilation
Reviewers: q66, raster, zmike
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8905
WooHyun Jung [Thu, 16 May 2019 08:02:28 +0000 (10:02 +0200)]
csharp: fix formatting in generated .eo.cs codes
Summary: There was duplicated scope_tab, so I removed it.
Test Plan:
- ./autogen --enable-csharp-bindings
- make
Reviewers: lauromoura, felipealmeida, Jaehyun_Cho, YOhoho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8901
Marcel Hollerbach [Wed, 15 May 2019 15:45:56 +0000 (17:45 +0200)]
theme: add a macro file for making themes easier
CLICKABLE_SIGNAL_EMITS now can be used to setup all the events required
to have automatically emission of all the clickable events
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8899
Mike Blumenkrantz [Wed, 15 May 2019 16:44:27 +0000 (12:44 -0400)]
meson: enforce 61s timeout for tests, remove explicit timeouts from build files
unit tests automatically abort with info after 60s, and tests should be run with
an appropriate timeout to avoid conflict with the test runner's default 30s timeout
set explicit timeout in eio test for now because there's still frequent bugs here
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8894
Marcel Hollerbach [Wed, 15 May 2019 13:49:48 +0000 (09:49 -0400)]
Revert "remove vpath test for user dir the test was broken and fixing is insane"
Summary:
This reverts commit
954a534bc0e7f30e66cc7dfd15ac79544e92671f.
It appears that the concerns from this commit are invalid. The case of
~asdf/ does not have any fallback case, if there is no getpwent on this
system, then there will be simply an error, same for the case of a
missing user. In such a case nothing will be written in the buffer /
returned by eina_vpath. The windows build problem can be
fixed by a simple #ifdef'ing the test code.
Reviewers: raster, zmike, cedric, vtorri
Reviewed By: vtorri
Subscribers: vtorri, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8671
Carsten Haitzler (Rasterman) [Wed, 15 May 2019 13:26:11 +0000 (14:26 +0100)]
meson buildtype - use plain not debug as debug will be insanely slow
eina cow backtraces on write make this impractically slow to use
debug. also the switch back to dev mode was not the reverse of
switching to release mode. this fixes that.
Marcel Hollerbach [Wed, 15 May 2019 13:09:04 +0000 (09:09 -0400)]
efl_ui_frame: migrate to efl.ui.clickable
Summary:
frame now uses efl.ui.clickable, which ensures correct click emittion.
The click event is not needed in the event anymore. However, now
efl,action,press / efl,action,unpress is needed.
Depends on D8825
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8826