Gaurav Khanna [Thu, 23 Jun 2016 19:53:08 +0000 (12:53 -0700)]
Merge pull request dotnet/corefx#9639 from gkhanna79/Fix5837FX
Add test to validate binding using Resolving event using static binding
Commit migrated from https://github.com/dotnet/corefx/commit/
5b054c439a262c0d9b96c7ab01772dd39ce366bb
Eric StJohn [Thu, 23 Jun 2016 19:09:30 +0000 (12:09 -0700)]
Merge pull request dotnet/corefx#9638 from ericstj/updateBaselinePackageVersion
Update Microsoft.Private.PackageBaseline to 1.0.1
Commit migrated from https://github.com/dotnet/corefx/commit/
3ce8fd68880bc09c46d894054282705810656d39
David Shulman [Thu, 23 Jun 2016 18:33:50 +0000 (11:33 -0700)]
Merge pull request dotnet/corefx#9624 from davidsh/null_safehandle
Fix logic with setting response body receive timeout
Commit migrated from https://github.com/dotnet/corefx/commit/
8b50545824d7a7f7e7f44b666938f74d2581be7c
Matt Ellis [Thu, 23 Jun 2016 17:47:15 +0000 (10:47 -0700)]
Merge pull request dotnet/corefx#9614 from ellismg/add-build-id-linker-flag
Pass --build-id=sha1 to linker explicitly
Commit migrated from https://github.com/dotnet/corefx/commit/
6e9e499889768d4f17ab1baddf5dd080652e2c33
Stephen Toub [Thu, 23 Jun 2016 17:46:10 +0000 (13:46 -0400)]
Merge pull request dotnet/corefx#9625 from dotnet-bot/UpdateDependencies20160623042734
Updating CoreClr dependencies to beta-24223-03
Commit migrated from https://github.com/dotnet/corefx/commit/
21e99c99a256e11828a66043a047c046474cce97
Gaurav Khanna [Fri, 17 Jun 2016 13:30:31 +0000 (06:30 -0700)]
Add test to validate binding using Resolving event using static binding
Commit migrated from https://github.com/dotnet/corefx/commit/
04c8661e3e4ec98da8cfcbf467523fba471bfdae
Eric St. John [Thu, 23 Jun 2016 17:42:40 +0000 (10:42 -0700)]
Update Microsoft.Private.PackageBaseline to 1.0.1
We stopped publishing this because we didn't increment the version.
Commit migrated from https://github.com/dotnet/corefx/commit/
02891b921f4b5c88a8d92398d56204123a2c8f23
David Shulman [Thu, 23 Jun 2016 16:11:22 +0000 (09:11 -0700)]
Fix logic with setting response body receive timeout
Due to code moving around with PR dotnet/corefx#8996, the `state.RequestHandle` was
already null when trying to set the receive timeout for the response
body. This generated an exception which was caught internally.
This fix moves the setting of the receive timeout so that it has a valid
`state.RequestHandle` to use.
Fixes dotnet/corefx#9578
Commit migrated from https://github.com/dotnet/corefx/commit/
5657fdbce9b4c77d486525a40733f872e2f95f1b
dotnet-bot [Thu, 23 Jun 2016 16:27:34 +0000 (16:27 +0000)]
Updating CoreClr dependencies to beta-24223-03
Commit migrated from https://github.com/dotnet/corefx/commit/
ffb3936af68a238f34de72c220337bb23cfdda4f
Stephen Toub [Thu, 23 Jun 2016 16:19:18 +0000 (12:19 -0400)]
Merge pull request dotnet/corefx#9616 from dotnet-bot/UpdateDependencies20160623051816
Updating External dependencies to beta-24223-00
Commit migrated from https://github.com/dotnet/corefx/commit/
cc416f8b7b3900fb082d88d480769da4fb5c9d7a
Stephen Toub [Thu, 23 Jun 2016 16:19:07 +0000 (12:19 -0400)]
Merge pull request dotnet/corefx#9617 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/corefx/commit/
37cc76c6fab5bbeb21e017e77ad83752e874e8e9
Atsushi Kanamori [Thu, 23 Jun 2016 15:13:03 +0000 (08:13 -0700)]
Merge pull request dotnet/corefx#9546 from yfakariya/dispatchproxy-emit-properties-and-events
Make DispatchProxy declares Property and EventInfos of the interface
Commit migrated from https://github.com/dotnet/corefx/commit/
8d2ac6fa9d3f41a83b63b8336133d9253a226c20
yfakariya [Sat, 18 Jun 2016 09:19:38 +0000 (18:19 +0900)]
Make DispatchProxy declares Property/EventInfos of the interface.
This commit adds code to declare properties and events
to generating proxy type as well.
Note
* Because declaring properties and events requires accessor methods,
this commit changes AddMethodImpl to return created MethodBuilder.
* This declares EqualityComparer for MethodInfo to avoid reference based
comparison.
* The test case now uses System.Reflection.Emit to generate the event
with raise_ method which is not supported in C#.
Commit migrated from https://github.com/dotnet/corefx/commit/
e8f650d67a67003786c04b916dc4805678237c0a
dotnet-bot [Thu, 23 Jun 2016 05:18:16 +0000 (05:18 +0000)]
Updating External dependencies to beta-24223-00
Commit migrated from https://github.com/dotnet/corefx/commit/
386b4d5d9aff596bed8d8ec37d8e4978b50cb09b
Eric St. John [Thu, 23 Jun 2016 06:54:36 +0000 (23:54 -0700)]
Replace source projects with depprojs
Now that we have stable packages we can redistribute the previously
built binaries rather than rebuilding them.
Also cleaning up some unused projects.
[tfs-changeset: 1614403]
Commit migrated from https://github.com/dotnet/corefx/commit/
9eb1e7d6939c79459e84651a69c03a11887ff9f5
Eric StJohn [Thu, 23 Jun 2016 14:44:44 +0000 (07:44 -0700)]
Merge pull request dotnet/corefx#9622 from dotnet-bot/UpdateDependencies20160623011710
Updating CoreFx dependencies to beta-24223-03
Commit migrated from https://github.com/dotnet/corefx/commit/
6c36a16d60f6a4eca9692cbfb697a24341f10184
Eric St. John [Thu, 23 Jun 2016 13:47:24 +0000 (06:47 -0700)]
Update dependenices in InteropServices to 4.2.0
Commit migrated from https://github.com/dotnet/corefx/commit/
0963237884ff018380db6a4d5a9da27792ea8088
Stephen Toub [Thu, 23 Jun 2016 13:18:44 +0000 (09:18 -0400)]
Update FxCop and Framework Design Guidelines links
Commit migrated from https://github.com/dotnet/corefx/commit/
935018d4c6089871c82d66c43482b24cafd3b58a
dotnet-bot [Thu, 23 Jun 2016 13:17:10 +0000 (13:17 +0000)]
Updating CoreFx dependencies to beta-24223-03
Commit migrated from https://github.com/dotnet/corefx/commit/
de7fe45c006d4079d458e595543189d2b4dad4f2
Stephen Toub [Thu, 23 Jun 2016 12:17:54 +0000 (08:17 -0400)]
Merge pull request dotnet/corefx#9619 from dotnet-bot/UpdateDependencies20160623082700
Updating CoreClr dependencies to beta-24223-02
Commit migrated from https://github.com/dotnet/corefx/commit/
6fdadbe803c198637f9cb2866d8310664ab121b7
dotnet-bot [Thu, 23 Jun 2016 08:27:00 +0000 (08:27 +0000)]
Updating CoreClr dependencies to beta-24223-02
Commit migrated from https://github.com/dotnet/corefx/commit/
233c7bbb34ea75440e3b25694fc43123acf183ba
Eric StJohn [Thu, 23 Jun 2016 06:57:18 +0000 (23:57 -0700)]
Merge pull request dotnet/corefx#9595 from dotnet-bot/UpdateDependencies20160622081834
Updating CoreClr dependencies to beta-24222-02
Commit migrated from https://github.com/dotnet/corefx/commit/
223c9b41099fa2b8ba8c2db5eb4c303ce2842a91
Eric St. John [Wed, 22 Jun 2016 15:15:52 +0000 (08:15 -0700)]
Fix reference to CoreCLR packages
Commit migrated from https://github.com/dotnet/corefx/commit/
8ba82df3cb11d84e1719b63599ba164450257ac1
dotnet-bot [Wed, 22 Jun 2016 08:18:34 +0000 (08:18 +0000)]
Updating CoreClr dependencies to beta-24222-02
Commit migrated from https://github.com/dotnet/corefx/commit/
d7b14074d654799db85feca1535b6d7063751587
Stephen Toub [Thu, 23 Jun 2016 02:33:48 +0000 (22:33 -0400)]
Merge pull request dotnet/corefx#9592 from lemmaa/add-makeargs-to-build.sh
Add `makeargs <args>` option to passing extra options to `make`
Commit migrated from https://github.com/dotnet/corefx/commit/
ee8f1e7041b15bbd088cfbd05c131a6f0e8adab2
Stephen Toub [Thu, 23 Jun 2016 02:33:23 +0000 (22:33 -0400)]
Merge pull request dotnet/corefx#9610 from stephentoub/safebiohandle_lifetime
Fix SafeSslHandle<->SafeBioHandle lifetime management
Commit migrated from https://github.com/dotnet/corefx/commit/
d38b101403f62906045b03c8755a74e12157dae9
Stephen Toub [Thu, 23 Jun 2016 02:31:43 +0000 (22:31 -0400)]
Merge pull request dotnet/corefx#9612 from stephentoub/move_etw_test
Move Dataflow ETW test into its own process
Commit migrated from https://github.com/dotnet/corefx/commit/
56f95c97855f4ad98f5380737d755359a5b81338
Gaurav Khanna [Thu, 23 Jun 2016 01:17:35 +0000 (18:17 -0700)]
Merge pull request dotnet/corefx#9602 from gkhanna79/Fix6889
Add RID for Windows Arm64
Commit migrated from https://github.com/dotnet/corefx/commit/
3b1c6990aa62e0673e887cdd9867f35953c3a9ec
Stephen Toub [Wed, 22 Jun 2016 23:32:44 +0000 (19:32 -0400)]
Move Dataflow ETW test into its own process
Fixes an issue where if another test accidentally overlaps (e.g. if the test doesn't ensure all queued async operations have completed), ETW events may fire in a way not expected by the tests.
This also eliminates the reason we had disabled parallelism for the suite, so I re-enabled it, which also results in the tests running several seconds faster.
Commit migrated from https://github.com/dotnet/corefx/commit/
80072898844934493efbe879c034edf8dbb9caa5
Matt Ellis [Thu, 23 Jun 2016 00:40:56 +0000 (17:40 -0700)]
Pass --build-id=sha1 to linker explicitly
On some platforms, a build-id was not being added to native artifacts
and we would like it to be present. Explicitly pass --build-id=sha1 to
the linker.
Related: dotnet/coreclrdotnet/corefx#5796
Commit migrated from https://github.com/dotnet/corefx/commit/
72efebeca9e062c4f257125574911df9ce9c8d0c
Stephen Toub [Wed, 22 Jun 2016 23:35:39 +0000 (19:35 -0400)]
Merge pull request dotnet/corefx#9609 from dotnet-bot/UpdateDependencies20160622071151
Updating CoreFx dependencies to beta-24222-04
Commit migrated from https://github.com/dotnet/corefx/commit/
3ff324e225a884c6de0df5d1b9c6a9cedd557e8b
Stephen Toub [Wed, 22 Jun 2016 21:05:28 +0000 (17:05 -0400)]
Address PR feedback, and additional cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
43c7f54f40a095ff71ff2e90a1c620b85b429a77
Stephen Toub [Wed, 22 Jun 2016 19:57:11 +0000 (15:57 -0400)]
Fix SafeSslHandle<->SafeBioHandle lifetime management
SafeSslHandles reference two SafeBioHandles, one for reading and one for writing. The SafeSslHandle represents an underlying SSL structure which via SSL_set_bio has the two BIO pointers represented by those SafeBioHandles stored into it. Once that happens, the SafeBioHandles no longer "own" the underlying pointers, as instead calling SSL_destroy on the SSL structure will also clean up those BIO handles. But the lifetime of these handles is not being managed correctly. The SafeSslHandle is add-ref'ing each of the SafeBioHandles when they're transferred into it; that prevents the SafeBioHandle from closing the underlying handle until the SafeSslHandle is closed, but this is backwards. We need the SafeBioHandles to keep the SafeSslHandle from being destroyed until the SafeBioHandles are no longer being used. Otherwise, we can end up in a situation where the SafeBioHandles are passed to some P/Invoke, and while they're being used, the SafeSslHandle is disposed/finalized, destroying the state that the P/Invoke is actively using.
This commit inverts the relationship. When the SafeBioHandle ownership is transferred to the SafeSslHandle, the SafeBioHandle will no longer attempt to close the underlying handle. It also add-refs the parent SafeSslHandle, rather than the other way around, so that the SafeSslHandle can't destroy the underlying SSL structure while the SafeBioHandles are being used.
Commit migrated from https://github.com/dotnet/corefx/commit/
bd7e9b5a417de5970289a20431d1d75340b4a35a
dotnet-bot [Wed, 22 Jun 2016 19:11:51 +0000 (19:11 +0000)]
Updating CoreFx dependencies to beta-24222-04
Commit migrated from https://github.com/dotnet/corefx/commit/
c202a00f9b3994ebf2387490f5fec9340820071c
David Mason [Wed, 22 Jun 2016 19:03:30 +0000 (12:03 -0700)]
Merge pull request dotnet/corefx#9591 from davmason/master
Update EventSource tests to dispose EventListeners
Commit migrated from https://github.com/dotnet/corefx/commit/
44dbc57aa4afea8bc4897bb7a753e94acba1b3f7
tijoytom [Wed, 22 Jun 2016 18:04:50 +0000 (11:04 -0700)]
Merge pull request dotnet/corefx#8607 from tijoytom/master
Updating contracts for new UTF8 string marshalling APIs
Commit migrated from https://github.com/dotnet/corefx/commit/
926bdd0e860b9bb4f13e6c562575e59aee2ff9d0
Wes Haggard [Wed, 22 Jun 2016 17:37:53 +0000 (10:37 -0700)]
Merge pull request dotnet/corefx#9601 from dotnet-bot/UpdateDependencies20160622010859
Updating CoreFx dependencies to beta-24222-03
Commit migrated from https://github.com/dotnet/corefx/commit/
dab51783edcc970f9cfb7d38b12d49fb7ff0fbcb
David Mason [Wed, 22 Jun 2016 03:53:05 +0000 (20:53 -0700)]
update EventSource tests to dispose EventListeners
Commit migrated from https://github.com/dotnet/corefx/commit/
0392a60f9183607a07ba211ee026565ff9343306
Wes Haggard [Wed, 22 Jun 2016 16:39:30 +0000 (09:39 -0700)]
Update S.T.RegularExpressions to version 4.2.0
Commit migrated from https://github.com/dotnet/corefx/commit/
9ce507c4f5c570619709c051573fb65d81c63977
Tijoy Tom Kalathiparambil [Tue, 17 May 2016 17:04:22 +0000 (10:04 -0700)]
Updating contracts for new UTF8 string marshalling APIs
We're adding a new API version which needs to be OOB on desktop.
Ensure we continue to build the 4.6.2 version.
Right now we're lying and saying .NETCoreApp1.0 supports the latest API.
Once we have a netcoreapp1.1/netstandard1.7 we'll need to update to use
that and either redistribute or cross compile for netstandard1.5/
netcoreapp1.0.
Commit migrated from https://github.com/dotnet/corefx/commit/
1ba2d172367729f7472324c7197cae02f4796874
Gaurav Khanna [Wed, 22 Jun 2016 15:33:07 +0000 (08:33 -0700)]
Add RID for Windows Arm64
Commit migrated from https://github.com/dotnet/corefx/commit/
d341f82a5155006a779ae780e400693cfc8e3393
dotnet-bot [Wed, 22 Jun 2016 13:08:58 +0000 (13:08 +0000)]
Updating CoreFx dependencies to beta-24222-03
Commit migrated from https://github.com/dotnet/corefx/commit/
087ec74b9e436299974dce655741a3dcc98f5d1c
Stephen Toub [Wed, 22 Jun 2016 11:23:38 +0000 (07:23 -0400)]
Merge pull request dotnet/corefx#9593 from dotnet-bot/UpdateDependencies20160622051918
Updating External dependencies to beta-24222-00
Commit migrated from https://github.com/dotnet/corefx/commit/
a181783ef0c51da547144d78b81bb07f77923228
dotnet-bot [Wed, 22 Jun 2016 05:19:18 +0000 (05:19 +0000)]
Updating External dependencies to beta-24222-00
Commit migrated from https://github.com/dotnet/corefx/commit/
90dac98c837b7624a743c7a6c9a0e3a2cf27b504
Stephen Toub [Wed, 22 Jun 2016 01:24:50 +0000 (21:24 -0400)]
Merge pull request dotnet/corefx#9586 from Priya91/fixprocess
Add NERR_UserNotFound code to check on netuserdel.
Commit migrated from https://github.com/dotnet/corefx/commit/
848e16f42cbce0f7f2f15171fadf065baa6e577a
Lakshmi Priya Sekar [Wed, 22 Jun 2016 00:14:09 +0000 (17:14 -0700)]
Add usernotfound code to check on netuserdel.
Commit migrated from https://github.com/dotnet/corefx/commit/
f16267c5ebbc0930604074f06ad85680395dd482
Eric Eilebrecht [Tue, 21 Jun 2016 22:16:53 +0000 (15:16 -0700)]
Disable SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds on Fedora 23, while we investigate why this test has been failing. (dotnet/corefx#9580)
Commit migrated from https://github.com/dotnet/corefx/commit/
21936668c71cd9e3951f7ab4e9c8ac253ca79d4e
Lakshmi Priya [Tue, 21 Jun 2016 21:44:28 +0000 (14:44 -0700)]
Merge pull request dotnet/corefx#9526 from Priya91/regexgroup
Bring in Group.Name API from future branch, to be supported for net463
Commit migrated from https://github.com/dotnet/corefx/commit/
a85d1f1f46f53f2e249d84bef0f2083fc19f1a84
Stephen Toub [Tue, 21 Jun 2016 20:37:20 +0000 (16:37 -0400)]
Merge pull request dotnet/corefx#9575 from dotnet-bot/UpdateDependencies20160621062520
Updating CoreFx dependencies to beta-24221-04
Commit migrated from https://github.com/dotnet/corefx/commit/
c3a7bcabaa4bf82299d9f486c8b3529f9c04c93b
Stephen Toub [Tue, 21 Jun 2016 19:21:53 +0000 (15:21 -0400)]
Merge pull request dotnet/corefx#9573 from dotnet-bot/UpdateDependencies20160621052041
Updating External dependencies to beta-24221-00
Commit migrated from https://github.com/dotnet/corefx/commit/
053ee23b44e87b533119b9a5ccb741cdd142e2a8
Stephen Toub [Tue, 21 Jun 2016 18:31:35 +0000 (14:31 -0400)]
Merge pull request dotnet/corefx#9565 from stephentoub/ws_refactoring
Several more WebSocket tweaks
Commit migrated from https://github.com/dotnet/corefx/commit/
cded4394fee8bbfaad624e2e1816bf3c9c72207f
dotnet-bot [Tue, 21 Jun 2016 18:25:20 +0000 (18:25 +0000)]
Updating CoreFx dependencies to beta-24221-04
Commit migrated from https://github.com/dotnet/corefx/commit/
82aa3ea6236d6990a50770fb77b79ffb4e06c0b5
dotnet-bot [Tue, 21 Jun 2016 17:20:41 +0000 (17:20 +0000)]
Updating External dependencies to beta-24221-00
Commit migrated from https://github.com/dotnet/corefx/commit/
84134e5d027d30efcdc4bf3824b63fc7607b8e6f
Stephen Toub [Tue, 21 Jun 2016 14:08:08 +0000 (10:08 -0400)]
Merge pull request dotnet/corefx#9569 from dotnet-bot/UpdateDependencies20160621011417
Updating CoreFx dependencies to beta-24221-03
Commit migrated from https://github.com/dotnet/corefx/commit/
3b6f18783574dae9ec58f50e5adacc5302330b69
dotnet-bot [Tue, 21 Jun 2016 13:14:17 +0000 (13:14 +0000)]
Updating CoreFx dependencies to beta-24221-03
Commit migrated from https://github.com/dotnet/corefx/commit/
6e72d3c127cae0a175c63dc942b8c7d8ac5da38b
Stephen Toub [Tue, 21 Jun 2016 10:15:51 +0000 (06:15 -0400)]
Merge pull request dotnet/corefx#9567 from dotnet-bot/UpdateDependencies20160621071747
Updating CoreFx dependencies to beta-24221-02
Commit migrated from https://github.com/dotnet/corefx/commit/
42cb374a130ea3116322e1854aa88ffb3cf15801
dotnet-bot [Tue, 21 Jun 2016 07:17:46 +0000 (07:17 +0000)]
Updating CoreFx dependencies to beta-24221-02
Commit migrated from https://github.com/dotnet/corefx/commit/
818ad5af9340661114d112e6f7d511e380bc4f81
Karthik Rajasekaran [Tue, 21 Jun 2016 07:05:26 +0000 (00:05 -0700)]
Merge pull request dotnet/corefx#9566 from karajas/updateBT
Update BuildTools to version 1.0.26-prerelease-00521-01
Commit migrated from https://github.com/dotnet/corefx/commit/
ee647f58be1c45710c2cffbf7a01075756a84f48
Karthik Rajasekaran [Tue, 21 Jun 2016 05:48:55 +0000 (22:48 -0700)]
Update BuildTools to version 1.0.26-prerelease-00521-01
Commit migrated from https://github.com/dotnet/corefx/commit/
145461779618b860165ba21f93d8890eb9b1ed17
Matt Galbraith [Tue, 21 Jun 2016 03:54:30 +0000 (20:54 -0700)]
Merge pull request dotnet/corefx#9560 from MattGal/Update_Xunit_Console_NetCore
Update BuildTools.TestSuite and Xunit.Console.NetCore runner
Commit migrated from https://github.com/dotnet/corefx/commit/
e3b708058ff90c760c7ac32d93c9f492fab95b21
Matt Galbraith [Mon, 20 Jun 2016 22:51:34 +0000 (15:51 -0700)]
Update references to Microsoft.DotNet.BuildTools.TestSuite to a version that understands uap10.0, add version validation rule for same.
Update reference to Xunit.Console.Netcore to pick up new version which does not throw if Console Color APIs do.
Commit migrated from https://github.com/dotnet/corefx/commit/
91260ea102e681b16864596f0b9b2f14d3be82be
Matt Ellis [Mon, 20 Jun 2016 23:25:18 +0000 (16:25 -0700)]
Merge pull request dotnet/corefx#9530 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/corefx/commit/
dd029f5f09cca533e27a3c52005182781aa0c2f2
Matt Ellis [Mon, 20 Jun 2016 22:38:23 +0000 (15:38 -0700)]
Merge remote-tracking branch 'upstream/master' into from-tfs
Commit migrated from https://github.com/dotnet/corefx/commit/
ee647a1b03d8a5cdd9cc75ec58619fce4ce1d68b
Lakshmi Priya Sekar [Mon, 20 Jun 2016 21:17:25 +0000 (14:17 -0700)]
Respond to PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
b21352ae3809a129e38468bbc44be35ebcac34f7
Stephen Toub [Mon, 20 Jun 2016 21:03:27 +0000 (17:03 -0400)]
Delete now dead code
Commit migrated from https://github.com/dotnet/corefx/commit/
107ee39aadfef438779d8de382fd95756e18d7a1
Stephen Toub [Mon, 20 Jun 2016 20:56:37 +0000 (16:56 -0400)]
Handle more bad protocol cases
These weren't flagged by the test suite, but they better match the spec.
Commit migrated from https://github.com/dotnet/corefx/commit/
028b5807d9de87652847956f24d52ed76cd70db5
Stephen Toub [Mon, 20 Jun 2016 20:06:52 +0000 (16:06 -0400)]
Merge pull request dotnet/corefx#9548 from ellismg/port-http2-debian-test-fix
Allow the HTTP2 protocol test to pass with untrusted chains on Debian.
Commit migrated from https://github.com/dotnet/corefx/commit/
12f1d055b4ac1ed41b1e4501e2a10a3cc24fc305
Stephen Toub [Mon, 20 Jun 2016 20:06:34 +0000 (16:06 -0400)]
Capture exception from send method into returned task
Rather than allowing it to escape synchronously from the method.
Commit migrated from https://github.com/dotnet/corefx/commit/
f1a6ea4ef8dbf61f840c247fba2bb2d481e25bdc
Stephen Toub [Mon, 20 Jun 2016 20:05:50 +0000 (16:05 -0400)]
Small refactorings/fixes in WebSockets managed client
- Separate handling of close and ping/pong messages into their own functions. This helps to keep the main receive function a bit more streamlined, and helping with the more common case we care to optimize for, sending and receiving.
- Remove two locals from the receive async function; this shrinks the size of that async state machine when yielding by a few bytes.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef8fd9e532190dff3d6c343e40b8b0fba5684217
Stephen Toub [Mon, 20 Jun 2016 19:33:08 +0000 (15:33 -0400)]
Merge pull request dotnet/corefx#9537 from stephentoub/http_test_parallel
Allow default xunit parallelization for System.Net.Http.Functional.Tests
Commit migrated from https://github.com/dotnet/corefx/commit/
958a18a4976510ec8947abc1d0d1d8ab4efee9f5
Tomáš Matoušek [Mon, 20 Jun 2016 19:24:48 +0000 (12:24 -0700)]
Merge pull request dotnet/corefx#9531 from tmat/MetadataBuilderTests
MetadataBuilder tests, API polish, docs
Commit migrated from https://github.com/dotnet/corefx/commit/
e9d7ee6389d67bff036f02712651ae2f30e0a3e4
Stephen Toub [Mon, 20 Jun 2016 18:48:11 +0000 (14:48 -0400)]
Mark another ActiveIssue
Commit migrated from https://github.com/dotnet/corefx/commit/
daa30fcf33d57203456ed6c0ce8c42650074d5db
Stephen Toub [Mon, 20 Jun 2016 02:59:54 +0000 (22:59 -0400)]
Separate diagnostics tests into their own class
The only change to the logic is that the tests now use RemoteInvoke to run each test in its own process, so as to avoid EventSource and DiagnosticSource interference.
Also removed the xunit attributes from the assembly that prevented parallelization. It's no longer needed as of this change.
Commit migrated from https://github.com/dotnet/corefx/commit/
542d85e15bfe5fdeb59d7e6f7fb3b15a08640ebd
Stephen Toub [Mon, 20 Jun 2016 02:01:54 +0000 (22:01 -0400)]
Add remote executor support for an async method
Commit migrated from https://github.com/dotnet/corefx/commit/
4dff47ae9dde3a0ec40af9f3d8ba0c485c1384e0
Jeremy Barton [Sun, 12 Jun 2016 03:01:26 +0000 (20:01 -0700)]
Allow the HTTP2 protocol test to pass with untrusted chains on Debian.
The TLS context is set up to make this chain:
CN=http2.akamai.com, O=Akamai Technologies Inc., L=Santa Clara, S=CA, C=US
CN=Verizon Akamai SureServer CA G14-SHA2, OU=Cybertrust, O=Verizon Enterprise Solutions, L=Amsterdam, C=NL
CN=Baltimore CyberTrust Root, OU=CyberTrust, O=Baltimore, C=IE
CN=GTE CyberTrust Global Root, OU="GTE CyberTrust Solutions, Inc.", O=GTE Corporation, C=US
making use of the cross-signed Baltimore CyberTrust Root certificate.
Unfortunately, that chain is not trusted on Debian 8.4 (GTE CyberTrust Global Root was removed), and a combination of data and installed software results in the valid chain using the self-signed Baltimore root is never built.
To prevent this situation from making the tests show as a failure, selectively allow Debian 8 to succeed on an incomplete chain.
Commit migrated from https://github.com/dotnet/corefx/commit/
316370ac1d58a90f6788ecb924b41cc93aec043e
Stephen Toub [Mon, 20 Jun 2016 17:27:22 +0000 (13:27 -0400)]
Merge pull request dotnet/corefx#9544 from stephentoub/clientcert_test
Tweak HTTP client certificates test and add ActiveIssue
Commit migrated from https://github.com/dotnet/corefx/commit/
f42926c99b7d5311b61065b347fc05f7b911671a
Tomas Matousek [Mon, 20 Jun 2016 16:29:36 +0000 (09:29 -0700)]
MetadataBuilder tests, API polish, docs
Commit migrated from https://github.com/dotnet/corefx/commit/
0029217ed7fe886eff04deb9c2ea6529ef025885
Eric StJohn [Mon, 20 Jun 2016 16:22:44 +0000 (09:22 -0700)]
Merge pull request dotnet/corefx#9524 from ericstj/Update-beta-24217-04
Update CoreFx packages to beta-24217-04
Commit migrated from https://github.com/dotnet/corefx/commit/
2c42a8f7b759f5f3973a05e7abf54144bba6702d
Eric St. John [Mon, 20 Jun 2016 15:44:38 +0000 (08:44 -0700)]
Fix reference assembly non-stable refs
Commit migrated from https://github.com/dotnet/corefx/commit/
d6b3393cb53b1775fd88db37ccebea3aafae5f18
Eric St. John [Mon, 20 Jun 2016 14:26:27 +0000 (07:26 -0700)]
Fix product binary non-stable refs
Commit migrated from https://github.com/dotnet/corefx/commit/
73e6c557b8e4e94c1b3f9bb27c78fbe18685aaac
Eric St. John [Mon, 20 Jun 2016 13:29:02 +0000 (06:29 -0700)]
Ensure we reference the latest Lineup package.
Commit migrated from https://github.com/dotnet/corefx/commit/
26bd9740848d45888bf9cb7b472201856ed36f62
Stephen Toub [Mon, 20 Jun 2016 12:37:30 +0000 (08:37 -0400)]
Tweak HTTP client certificates test and add ActiveIssue
With forced GC/finalization at the right moment, the test currently fails on Windows.
Commit migrated from https://github.com/dotnet/corefx/commit/
4cdb8dc1ba73ef02ef719b9a0ee336dbefca3b10
Stephen Toub [Mon, 20 Jun 2016 02:08:41 +0000 (22:08 -0400)]
Merge pull request dotnet/corefx#9536 from stephentoub/add_ws_retry
Add retry to GetConnectedWebSocket
Commit migrated from https://github.com/dotnet/corefx/commit/
2bcc5419a37f7444805d4620e3af109a53b0d4f2
Stephen Toub [Sun, 19 Jun 2016 11:55:54 +0000 (07:55 -0400)]
Add retry to GetConnectedWebSocket
To hopefully avoid spurious failures when connecting to the Azure endpoint.
Commit migrated from https://github.com/dotnet/corefx/commit/
13512b795e811b10f2deac1e8af2632fe0e10853
Jeremy Barton [Sun, 19 Jun 2016 20:46:15 +0000 (13:46 -0700)]
Merge pull request dotnet/corefx#9510 from bartonjs/unix_x509_finalization
Significantly reduce SafeX509Handle finalizations
Commit migrated from https://github.com/dotnet/corefx/commit/
c2c725978f726e2058c61232d6d66628ab600366
Jeremy Barton [Sun, 19 Jun 2016 17:37:46 +0000 (10:37 -0700)]
Seal the remaining X509 Unix PAL types
The Unix PAL was about half and half on whether the internal sealable types
were sealed. Did a pass over them to ensure they all were.
Commit migrated from https://github.com/dotnet/corefx/commit/
6bdd3ac9e36c1b313e82baea34de674c7ff7764a
Jeremy Barton [Sun, 19 Jun 2016 05:42:49 +0000 (22:42 -0700)]
Split new PAL types into new files
Commit migrated from https://github.com/dotnet/corefx/commit/
86aa3ca4babb0a97bc9f3634c1fec347564af0d4
Jeremy Barton [Sun, 19 Jun 2016 04:56:53 +0000 (21:56 -0700)]
Split IStorePal into IStorePal, IExportPal, ILoaderPal
Various finalization and other lifetime problems were present because the
PAL layer assumed a Windows CAPI certificate store implementation.
There are three different types of thing happening:
1) A persistent repository of X.509 certificates and optional private keys.
Characteristics:
* Every call to read certificates should give back distinct objects, because
the .NET Framework implementation is a thin wrapper over the CAPI
CertEnumCertificatesInStore function.
* Data may be read any number of times (including not at all)
Previously this was handled by DirectoryBasedStoreProvider for user stores, and
CollectionBackedStoreProvider for machine stores. The user stores correctly met
the model, but the machine stores did a prepared copy on access and no further
copies. So two reads of the Certificates property from the same X509Store
instance could interefere with each other, and loading the store to an exception
(by asking for write permissions) would send all of the pre-clones off to the
finalizer queue.
Now CollectionBackedStoreProvider holds the original collection forever, and
does a clone on read.
2) The means of exporting certificates
Characteristics:
* The input certificate objects came from a user, they should not be disposed.
* Exactly one call to Export is expected
Previously this was handled by CollectionBackedStoreProvider. As part of
clarifying the object liftime model this was split off to ExportProvider.
3) The means of importing certificates
Characteristics:
* Exactly one call to read the data is expected
* If no call is made, the certificate objects will become unrooted, so they
should then get disposed with the PAL object.
Previously this was accomplished by CollectionBackedStoreProvider. Now loading
a single certificate is accomplished by SingleCertLoader (to avoid allocating
extra arrays) and plural loads are accomplished by CertCollectionLoader.
To codify the relationships of these three different purposes, the IStorePal
interface was split into IStorePal (persistent store), IExportPal (export), and
ILoaderPal (loading/import). For the Windows implementation the StorePal class
will continue to provide all three behaviors, therefore it implements all three
interfaces.
Commit migrated from https://github.com/dotnet/corefx/commit/
c191cfcb4d600dd9b09572af3fa38cd854a217c7
Stephen Toub [Sun, 19 Jun 2016 11:13:32 +0000 (07:13 -0400)]
Merge pull request dotnet/corefx#9534 from stephentoub/ws_improvements
Several managed WebSockets tweaks
Commit migrated from https://github.com/dotnet/corefx/commit/
4adc0dddf188552dbb6822e78751485f67baa584
Jeremy Barton [Sun, 19 Jun 2016 04:33:38 +0000 (21:33 -0700)]
Make System.Linq.Expressions share Common ReferenceEqualityComparer
Commit migrated from https://github.com/dotnet/corefx/commit/
28c54cbc31016acc3b4cf229a48f8d1593c093f1
Jeremy Barton [Fri, 17 Jun 2016 17:33:24 +0000 (10:33 -0700)]
Clean up unnecessary finalization in building Unix X509Chains
The chain processor has a copy of every certificate in the LM\Root, LM\CA,
CU\Root, CU\CA stores, as well as whatever certs were passed in by the
user via extraStore.
From this massive set a set of candidates are chosen, which are any
certificates which plausibly make up the chain. The rest were garbage
collected, with their SafeHandles being sent off for Finalization. Then,
anything that was chosen from candidates was cloned, making everything
still in that set likely to be Finalized.
Fixes:
* Since the Certificates collections from each of the stores is a copy, call Dispose on any member
which is not (under reference comparison) in the candidates set (hundreds per call).
* The re-wrapped input certificate gets cloned again by the chain building, dispose it (one per call).
* Everything from candidates which was not (under reference equality) provided by the user has either been cloned by the chain or was irrelevant; but either way it is now an untracked SafeHandle, so Dispose it (~2-4 per call).
Commit migrated from https://github.com/dotnet/corefx/commit/
130c9d22fe9240a00a132fd69781c89a9b1e7488
Jeremy Barton [Fri, 17 Jun 2016 16:45:22 +0000 (09:45 -0700)]
Add ReferenceEqualityComparer to Common
In X509Chain building some internally-managed X509Certificate2 objects
are mixed in with some user-owned objects. After mining for the required
data any unused internally-managed objects should be Disposed, but it's
not straightforward to identify if it's a internal object or a user object being
passed to the next stage of the pipeline because they .Equals the same.
Commit migrated from https://github.com/dotnet/corefx/commit/
cce156aedf83249d2b1152315202de1a66136bf0
Stephen Toub [Sat, 18 Jun 2016 03:17:02 +0000 (23:17 -0400)]
Several managed WebSockets tweaks
- When we fail to connect due to a abort/cancellation, ensure the inner exception of the WebSocketException is an OperationCanceledException rather than an ObjectDisposedException.
- When sending a keep-alive ping, if the send lock is already held, that means we're actively sending something, so there's no value in also sending a keep-alive; we can simply make it a nop.
- Only create the keep-alive timer if asked for.
- Make a field readonly.
- Ensure that we propagate exceptions as inner exceptions whenever possible
Commit migrated from https://github.com/dotnet/corefx/commit/
9257f10f0cb457ad161144ddc757cda2450b627f
Stephen Toub [Sat, 18 Jun 2016 22:24:41 +0000 (18:24 -0400)]
Merge pull request dotnet/corefx#9513 from stephentoub/numerics_testtime
Reduce System.Runtime.Numerics outerloop test time from ~180s to ~90s
Commit migrated from https://github.com/dotnet/corefx/commit/
723912ea9c771de3c3507b643e92464cfe2ee095
Stephen Toub [Sat, 18 Jun 2016 19:01:40 +0000 (15:01 -0400)]
Merge pull request dotnet/corefx#9519 from stephentoub/interop_testtime
Reduce S.R.InteropServices outerloop test time from ~100s to ~0.2s
Commit migrated from https://github.com/dotnet/corefx/commit/
f243108600fc7994a6b0c23fdf2f8b05a10a4cd1
David Zucker [Sat, 18 Jun 2016 14:32:27 +0000 (22:32 +0800)]
Add support to statically link (dotnet/corefx#8982)
* Add support to statically link curl to System.Net.Http.Native.so
* Update pull request following @ellismg comment
* remove the temporary variable staticCurl
* Change the argument to 'staticliblink'
* Change the CMAKE variable CMAKE_STATIC_CURL to a generic CMAKE_STATIC_LIB_LINK
* Add build Static link support of openSsl library
* clean up CMakeLists.txt content
* Update Build.sh to remove spacing. CMakeLists.txt remove non required link request
* Remove the set of CMAKE_EXE_LINKER_FLAGS which are not required in our case
* Remove the uninitialize variable staticurl
Commit migrated from https://github.com/dotnet/corefx/commit/
9a12086ad7da016e52747f2ba2e5b34f1a62cb3c
Cory Rivera [Sat, 18 Jun 2016 04:37:11 +0000 (21:37 -0700)]
Merge pull request dotnet/corefx#9523 from corivera/FixManualTestsBreak
Fix test break in SqlClient.ManualTests
Commit migrated from https://github.com/dotnet/corefx/commit/
0532442d684e62fa26f4dc849da7f9f2acd1ea38
Aditya Mandaleeka [Sat, 18 Jun 2016 00:09:38 +0000 (17:09 -0700)]
Merge pull request dotnet/corefx#9517 from adityamandaleeka/update_buildtools_version
Update BuildTools version to 1.0.26-prerelease-00517-04
Commit migrated from https://github.com/dotnet/corefx/commit/
765e8e3e10e04e6f038817e1346bf6add1772bba
Eric Eilebrecht [Fri, 17 Jun 2016 23:43:47 +0000 (16:43 -0700)]
Convert CredentialCache perf tests to xunit.performance (dotnet/corefx#9527)
These tests were running for a long time, and then ignoring the result. These tests run for ~2 minutes in our test passes, even though we're not getting useful data out of them.
This change converts the tests to use xunit.performance. This will greatly reduce their runtime when not running as performance tests (we just run one iteration in that case). It will also enable them to produce useful results in our perf lab, where we *do* have the infrastructure to find regressions in both throughput and GC counts for xunit.performance-based tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
0a246874eedb78c346df5fee658bf12052d2c94e
Lakshmi Priya Sekar [Fri, 17 Jun 2016 21:47:56 +0000 (14:47 -0700)]
Add package authoring for 4.2.0.0 Regex contract.
Commit migrated from https://github.com/dotnet/corefx/commit/
02ff405cf11b84adb979521c03027600618c409a