Adrian Szyndela [Mon, 6 Nov 2017 13:53:11 +0000 (14:53 +0100)]
kdbus: handle sending messages with any number of vectors
Bugfix. Sending function had an arbitrary limit for kdbus_msg structure size.
Any additional vector added 32 bytes to the structure. Due to the way glib
handles data, in some specific cases number of vectors could increase
significantly, eventually exhausting the limit.
The fix removes the arbitrary limit, exchanging it to standard system memory
limits, by precalculating and allocating needed space, instead of allocating
fixed amount of memory.
Change-Id: I5aa483e26f6bababababadd79422b7abe0b46b7d
INSUN PYO [Fri, 3 Nov 2017 05:38:46 +0000 (14:38 +0900)]
Modify indentation
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I6d8118bb36541bc8a17bbf915aafa68687e45e8c
Adrian Szyndela [Wed, 18 Oct 2017 09:30:14 +0000 (11:30 +0200)]
switch compilation mode fom Thumb to ARM
This is needed to be able to put uprobes in the library code as
the uprobes in current kernel versions work only with ARM code.
Change-Id: I0868bf63128900230c849cca48c5601d42b80bfa
Michal Bloch [Mon, 18 Sep 2017 12:05:52 +0000 (14:05 +0200)]
Fix build warnings.
Change-Id: I25b3cbbde5f4f8b7016556c2b9c203a743bb6632
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
INSUN PYO [Thu, 14 Sep 2017 02:08:15 +0000 (11:08 +0900)]
API: Deprecated Gdbus APIs in Tizen Public #2 - fix build error.
Many processes, such as aul, tlm and gli, generate the following error.
======================================================================
In file included from /usr/include/glib-2.0/gio/gio.h:50:0,
from corrupt.c:30:
/usr/include/glib-2.0/gio/gdbusaddress.h:29:51: fatal error: tizen.h: No such file or directory
include <tizen.h> /* for TIZEN_DEPRECATED_API */
======================================================================
To solve this problem, glib include own macro file.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Iea4077919fec54626b2ef063e2c5223025e95ac6
INSUN PYO [Tue, 12 Sep 2017 03:10:06 +0000 (12:10 +0900)]
API: Deprecated Gdbus APIs in Tizen Public
In Tizen Public, Gdbus APIs have been deprecated since Tizen 2.4.
This patch shows warning messages to Tizen Public SDK developers.
https://developer.tizen.org/development/api-references/native-application?redirect=https://developer.tizen.org/dev-guide/3.0.0/org.tizen.native.mobile.apireference/group__OPENSRC__GLIB__FRAMEWORK.html
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I07de7c48e6b94caa4d9f31af98b180a218d11275
sanghyeok.oh [Mon, 17 Jul 2017 06:00:49 +0000 (15:00 +0900)]
kdbus: libdbuspolicy: To perform policy check, pass unique name to libdbuspolicy
In case of signal broadcasting, message has null destination,
To perform policy check correctly, gdbus should pass unique name to libdbuspolicy as destination.
Change-Id: I563f7ad5ab99a9c91b5180350bb32259d3fed2b6
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
MyoungJune Park [Wed, 12 Jul 2017 08:32:03 +0000 (17:32 +0900)]
avoid compilation error from -Wshadow gcc option
- if arg name of an inline function at a header file is identical to
other simbol, gcc make warnings and turn it into failing build.
Change-Id: I73390d0d55574089d1a045be821edcbfc2a7a8f6
Signed-off-by: MyoungJune Park <mj2004.park@samsung.com>
sanghyeok.oh [Fri, 9 Jun 2017 07:16:13 +0000 (16:16 +0900)]
kdbus: pass sender to dbuspolicy1_check_out
Change-Id: I741f2dedc77654889362b3853728dba54a5cef0b
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Adrian Szyndela [Tue, 9 May 2017 08:16:53 +0000 (10:16 +0200)]
gkdbus bugfix: allow long names
D-Bus names, paths, interfaces, members may be longer than
127 characters now.
Change-Id: Id917c77f638d72fd0c7c618fe02a3181b57321b4
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Adrian Szyndela [Thu, 1 Jun 2017 11:08:22 +0000 (13:08 +0200)]
gkdbus: make error messages more consistent with libdbus
Change-Id: I5b21152f84ccc43ae8d72fe83e9e6d32aba58002
Adrian Szyndela [Tue, 9 May 2017 12:50:14 +0000 (14:50 +0200)]
kdbus: bugfix for return codes on call to non-existing destination
Calling a method on non-existing destination with auto start disabled
caused error org.freedesktop.DBus.ServiceUnknown.
Non-kdbus implementation gives org.freedesktop.DBus.NameHasNoOwner.
This patch makes kdbus return the same error as non-kdbus implementation.
Change-Id: I0320adf1205e2db11259e3f544eef27873acf8b0
Adrian Szyndela [Fri, 26 May 2017 12:31:59 +0000 (14:31 +0200)]
gkdbus: allow payloads larger than 2M in signals
In kdbus signals can't use memfd - only vectors. There is
2M size limit for kdbus vectors. We divide message data
into GVariantVectors, but they were matched 1:1 to kdbus vectors
even if their size was larger than 2M.
This patch divides GVariantVectors larger than 2M into multiple
kdbus vectors when sending a message.
Change-Id: Ided2de80535cf039ea53bd1ab9d4d68c71b6c478
Adrian Szyndela [Mon, 29 May 2017 11:37:07 +0000 (13:37 +0200)]
gkdbus: preserving NUM_UNIX_FDS header field
NUM_UNIX_FDS was discarded during sending, but it is needed
to handle file descriptors properly in libdbus.
It is also preserved by sd-bus.
Change-Id: I35ba0535bb7e92748edd51e09085f0321724de2e
Adrian Szyndela [Mon, 29 May 2017 13:48:26 +0000 (15:48 +0200)]
gkdbus: fix special rule for name signals
Sender_unique_name can never be NULL. However, it is checked
if it is NULL. It should be tested for emptiness,
but not for being NULL, but for being an empty string.
Change-Id: I2c968d614f34d7d388a629e0ce4bc9148b7e148e
Adrian Szyndela [Thu, 25 May 2017 10:01:25 +0000 (12:01 +0200)]
Bump to glib 2.52.2
tests: add gdbus-peer test back
Glib 2.51.1 moved gdbus-peer to programs compiled
only when dbus-daemon is detected. We can't easily make
dbus-daemon to be detected without creating a cycle in
the packages dependencies. Thus, I added an option
to force building programs dependent on dbus-daemon
without checking its presence.
Change-Id: Iac77bc4491ff4cadd7263edf510153bd4a38838a
Adrian Szyndela [Thu, 25 May 2017 09:50:11 +0000 (11:50 +0200)]
Merge tag 'upstream/2.52.2' into tizen
upstream/2.52.2
Change-Id: I60b56ce4eaa45877acc7e53ac4551d0a31234f7e
DongHun Kwak [Fri, 19 May 2017 00:26:29 +0000 (09:26 +0900)]
Imported Upstream version 2.52.2
Change-Id: I71ac7d11a2d40ffe74a13b1d190dbe652cba140a
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:26:07 +0000 (09:26 +0900)]
Imported Upstream version 2.52.1
Change-Id: Idca68df633e439e8492a9e0d40f78b49d689d84b
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:57 +0000 (09:25 +0900)]
Imported Upstream version 2.52.0
Change-Id: I7fdddaaf827f7a4f314ba570ff45b481406f5c67
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:27 +0000 (09:25 +0900)]
Imported Upstream version 2.51.5
Change-Id: If8ad379b8e3c0268a99759a5bf621c201926d3fe
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:25:12 +0000 (09:25 +0900)]
Imported Upstream version 2.51.4
Change-Id: I0a090d45ab8f1805c5f98fd4d804da23a4033a41
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:56 +0000 (09:24 +0900)]
Imported Upstream version 2.51.3
Change-Id: I69068bfdeb46efddb7a09fa8c19386aedca2dd71
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:38 +0000 (09:24 +0900)]
Imported Upstream version 2.51.2
Change-Id: I134d2267df41e44bec49ca802fe31ad39a8874b2
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:24:21 +0000 (09:24 +0900)]
Imported Upstream version 2.51.1
Change-Id: Id21981348a71b1395dc86225b819cd1ea103428e
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:23:56 +0000 (09:23 +0900)]
Imported Upstream version 2.51.0
Change-Id: I4219f1e9924abb0277e06eb3575732907a86e82d
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Fri, 19 May 2017 00:20:59 +0000 (09:20 +0900)]
Imported Upstream version 2.50.3
Change-Id: Ib95600d2b9af114ede0d7291f53745bf373c8b26
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
DongHun Kwak [Mon, 27 Mar 2017 07:02:20 +0000 (16:02 +0900)]
Add license file
- Add license file all packages
[Model] ALL
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Occurrence Version] N/A
[Problem] license file does not exist at package
[Cause & Measure] add license file at each package
[Checking Method] N/A
[Team] Open Source Management and Setting Part
[Developer] dh0128.kwak
[Solution company] Samsung
[Change Type] N/A
Change-Id: Idddce1432c3b140537864a95950dff65f67ae8bf
MyungJoo Ham [Tue, 7 Mar 2017 03:53:17 +0000 (12:53 +0900)]
[4.0] Remove OBS Project Dependency (kdbus/TV)
- Please add "libgio-extension-kdbus" for TV/arm-wayland images via JIRA-TRE issue.
- Without this commit, this package won't be built correctly in Tizen 4.0.
Change-Id: I42182599e930499fdd9b862f4a2e87bede2db33f
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Adrian Szyndela [Mon, 6 Feb 2017 11:16:44 +0000 (12:16 +0100)]
tests: generating coverage version of the libraries
Change-Id: I2cb0a26bc55cd0f932d59a8fc14da96349aa0b8a
Konrad Lipinski [Thu, 2 Feb 2017 11:58:31 +0000 (12:58 +0100)]
gbs incremental build support
Change-Id: Ic7d7bab4aa03f6707e1bf5482cfc16460b950584
DongHun Kwak [Fri, 3 Feb 2017 01:24:10 +0000 (10:24 +0900)]
Imported Upstream version 2.50.2
Change-Id: I83acaeb7a15edec96b064845383396695b865613
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Lukasz Skalski [Tue, 27 Sep 2016 12:24:15 +0000 (14:24 +0200)]
gdbus: add support for 'dbus-integration-tests' framework
Change-Id: Icd3e73b5221996945b0b9e6e34813aba2ebf0ab5
INSUN PYO [Thu, 29 Dec 2016 02:26:43 +0000 (11:26 +0900)]
gdbus:fix race condition between signal callback and g_bus_unwatch_name function
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ia19381a866674a3343503dab7feab0950bb49238
(cherry picked from commit
9002008efdce0bbf351dae5338fbe782369c3e20)
Adrian Szyndela [Thu, 22 Dec 2016 11:57:32 +0000 (12:57 +0100)]
name watching: fix for freeing client prematurely
on_name_owner_changed() is called with user_data being client
with no additional reference kept (ref_count is most probably 1,
taken with one of g_bus_watch_name*() functions).
This function calls user code through call_vanished_handler()
and call_appeared_handler(). The handlers may decrease client's
reference count by calling g_bus_unwatch_name().
Thus, we need to keep this reference locally to prevent freeing
client.
Note: this is also a bug in upstream glib, but it needs two things to happen:
1. call_vanished_handler must call user code that in turn calls g_bus_unwatch_name().
2. signal NameOwnerChanged for watched name, with not empty old and new owner
- it happens when a name changes its owner.
Note: if g_bus_unwatch_name() is called from other thread than the thread,
whose main context was default while calling g_bus_watch_name*, race condition
may appear. This is not changed. This is glib's design:
https://developer.gnome.org/glib/stable/glib-Threads.html
Quote:
[...] individual data structure instances are not automatically
locked for performance reasons. For example, you must coordinate accesses
to the same GHashTable from multiple threads.
It seems the same applies for data structures kept in global data, but for which
users keep their id, as in the above case.
Change-Id: Iaa125555f6908e05f999e407fb3ba9364995b21b
Konrad Lipinski [Thu, 22 Dec 2016 10:26:01 +0000 (11:26 +0100)]
kdbus: set error when dbuspolicy1_init fails
Change-Id: I99466bde6f7cecd62d6f911cf39bf9204b81d6de
Karol Lewandowski [Thu, 15 Dec 2016 13:13:14 +0000 (14:13 +0100)]
kdbus: Do not use fstat() to determinte memfd size
Memfd size is available via kdbus metadata so there is no need to use fstat.
This fixes failure on Smack system:
[ 5352.471226] audit: type=1400 audit(
946690155.785:99): lsm=SMACK fn=smack_inode_getattr action=denied subject="USER::server" object="USER::client" requested=r pid=13139 comm="gkdbus" path=2F6D656D66643A6B64627573202864656C657465642
Original idea by Insun Pyo <insun.pyo@samsung.com>
Change-Id: Ia7fe30c9604277d5ccf7cafedb0909a2c62b0d59
Adrian Szyndela [Mon, 5 Dec 2016 14:38:08 +0000 (15:38 +0100)]
fix for race condition in watching names
Change-Id: I11fa92a6dae62cb3bdaa4159db0da160752063d1
(cherry picked from commit
f1f2e5e4df63f06cac53148e5c91a27a56eea9ca)
Hyotaek Shim [Thu, 1 Dec 2016 07:01:21 +0000 (23:01 -0800)]
Revert "kdbus: fix race-condition in GDBusNameWatching component"
This reverts commit
f942d75a0ae909ef1f7419f093edb7826148a23d.
Change-Id: Ic13b87efa9e8a73bf5e7a968fbfa4d9813071796
(cherry picked from commit
d071aa0a622f39aeb066d468278f30c45070e016)
INSUN PYO [Thu, 1 Dec 2016 02:11:03 +0000 (11:11 +0900)]
kdbus: fix g_dbus_connection_call_sync ("NameHasOwner") failure
The caller _dbus_daemon_synthetic_reply function uses the error for a special purpose.
So, _g_kdbus_NamehasOwner never makes error and only return FALSE even if an error occurs.
================ the call stck of failure =====================================
0 g_kdbus_NameHasOwner_internal (worker=worker@entry=0x42a40, name=name@entry=0x5df78 "org.not.existing.busname") at gkdbus.c:1190
1 0xb6f18a0c in _g_kdbus_NameHasOwner (worker=worker@entry=0x42a40, name=0x5df78 "org.not.existing.busname", error=error@entry=0xbefff6d0) at gkdbus.c:1314 ==> generate gdbus error
2 0xb6f1a526 in _dbus_daemon_synthetic_reply (worker=worker@entry=0x42a40, message=message@entry=0x57c60) at gkdbusfakedaemon.c:542 ==> This function only check error value rather than return value. So, after appling patch, this logic has been changed.
3 0xb6f19a9c in _g_kdbus_worker_send_message_sync (worker=0x42a40, message=message@entry=0x57c60, out_reply=out_reply@entry=0xbefff768, timeout_msec=timeout_msec@entry=-1, cancellable=cancellable@entry=0x0, error=error@entry=0xbefff7ac) at gkdbus.c:3888
4 0xb6f3fe78 in g_dbus_connection_send_message_with_reply_sync (connection=connection@entry=0x421e0, message=message@entry=0x57c60, flags=G_DBUS_SEND_MESSAGE_FLAGS_NONE, timeout_msec=timeout_msec@entry=-1, out_serial=0xbefff76c, out_serial@entry=0x0, cancellable=0x0, error=error@entry=0xbefff7ac) at gdbusconnection.c:3019
5 0xb6f4013e in g_dbus_connection_call_sync_internal (connection=0x421e0, bus_name=<optimized out>, object_path=0x24058 "/org/freedesktop/DBus", interface_name=0x24040 "org.freedesktop.DBus", method_name=method_name@entry=0x24030 "NameHasOwner", parameters=parameters@entry=0x3d6a8, reply_type=reply_type@entry=0x24130, flags=flags@entry=G_DBUS_CALL_FLAGS_NONE, timeout_msec=timeout_msec@entry=-1, fd_list=fd_list@entry=0x0, out_fd_list=out_fd_list@entry=0x0, cancellable=cancellable@entry=0x0, error=error@entry=0xbefff83c) at gdbusconnection.c:6641
6 0xb6f4187a in g_dbus_connection_call_sync (connection=<optimized out>, bus_name=<optimized out>, object_path=<optimized out>, interface_name=<optimized out>, method_name=0x24030 "NameHasOwner", parameters=0x3d6a8, reply_type=0x24130, flags=G_DBUS_CALL_FLAGS_NONE, timeout_msec=-1, cancellable=0x0, error=0xbefff83c) at gdbusconnection.c:6868
==============================================================================
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I4959eaeeaad79de641f6b0c1ce10020ae9fe3760
MyungJoo Ham [Thu, 1 Dec 2016 05:16:24 +0000 (14:16 +0900)]
Remove Profile Build Dependency
Apply Tizen-TV profile optimization for ALL Tizen profiles
because it would not have side effects on the correctness.
(simply ref/unref a Tizen-wide "dbus")
Change-Id: I209f9bf798b02f674a95dfc38142b4a44e194883
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
sanghyeok.oh [Wed, 30 Nov 2016 09:43:21 +0000 (18:43 +0900)]
gdbus:add null check for error variable
Change-Id: Ib51dd62ebc066b9393ae7c59f2f63d3330a16518
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
(cherry picked from commit
22aff71838c2aafc27196886fff317d146f749e1)
Hyotaek Shim [Fri, 25 Nov 2016 10:04:10 +0000 (19:04 +0900)]
Kdbus: Fix for handling EPERM errors
Change-Id: I63b35469d0fe660a33880ac02b9dcb405ceeafac
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Thu, 24 Nov 2016 09:01:34 +0000 (18:01 +0900)]
kdbus: check return status of KDBUS_CMD_FREE iotcl
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I35ae1afffc01aaf1df54d6d2466cb0ecb3417c73
Lukasz Skalski [Wed, 23 Nov 2016 11:18:07 +0000 (12:18 +0100)]
kdbus: check return status of KDBUS_CMD_CONN_INFO iotcl
Change-Id: If6ea3c1825333aca2af4a2599b0187b1ff931b34
sanghyeok.oh [Tue, 22 Nov 2016 08:19:13 +0000 (17:19 +0900)]
gdbus: change timeout error code from 'gdbus error' to 'gio error'
sync/async call return different error code when timeout was occured
modify it to return G_IO_ERROR_TIMED_OUT
Change-Id: I7b9fb847240311ce40f59ab7d552aaa2efeecb45
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
(cherry picked from commit
7a6fcd470025060f220b51ed8a4ecd57cf2b84b7)
Lukasz Skalski [Mon, 31 Oct 2016 10:49:11 +0000 (11:49 +0100)]
kdbus: fix race-condition in GDBusNameWatching component
To avoid race-condition between GetNameOwner replay and
NameOwnerChanged signal in GDBusNameWatching component,
let's always use GetNameOwner sync call on kdbus bus.
Change-Id: Iebb780737d753d989a7d928f65d433d86d79284a
sanghyeok.oh [Tue, 11 Oct 2016 01:21:55 +0000 (10:21 +0900)]
coding style:errno must referenced right after calling standard function
Change-Id: I8eff8b174ecb621acbbe73734aa5c35cf5c60bfc
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Wed, 28 Sep 2016 03:38:26 +0000 (12:38 +0900)]
Fix for missing g_source_unref(Gkdbus worker source)
Change-Id: Ia5fb338b8b69b76c52d2dee8f6ccbb39e101a1c7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 27 Sep 2016 09:28:51 +0000 (18:28 +0900)]
glib:remove self-join deadlock:change to g_thread_unref
Change-Id: I1b98bed183510ca79c3448da5e2bd2a4115de709
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Tue, 27 Sep 2016 02:33:36 +0000 (11:33 +0900)]
glib:remove self-join deadlock
Change-Id: Ia9fffe62c90d596efe29929c50e835d4a93fac52
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Mon, 26 Sep 2016 11:16:33 +0000 (20:16 +0900)]
fix double unref
Allocated memory by g_thread_new() is freed by g_thread_join() or g_thread_unref()
It is not needed to use both g_thread_join() and g_thread_unref().
Change-Id: Ic6d13ecfa9f6c8d265bf516f4438e7a83bbd0e9c
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Tue, 13 Sep 2016 07:42:45 +0000 (16:42 +0900)]
kdbus: Add a null teminated string for GetConnectionCredentials (LinuxSecurityLabel) method.
The result of LinuxSecurityLabel item should end to null.
Dbus spec : https://dbus.freedesktop.org/doc/dbus-specification.html
Legacy dbus daemon : dbus/bus/driver.c. _dbus_asv_add_byte_array (&array_iter, "LinuxSecurityLabel", s, strlen (s) + 1))
libdbus kdbus : dbus-transport-kdbus.c. dbus_bool_t res = _dbus_asv_add_byte_array (&array_iter, "LinuxSecurityLabel", info.sec_label, strlen (info.sec_label)+1);
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Idff013ca4c56d93a6207bcb7365b36da86f7c1c2
Jonghwa Lee [Thu, 8 Sep 2016 04:30:39 +0000 (13:30 +0900)]
gkdbus: Fix wrong return value of _g_kdbus_quit_loop()
_g_kdbus_quit_loop() which is used as a callback function in
g_main_context_invoke() always return 'TRUE'. This is not correct.
Returnning 'TRUE' means its functionality isn't completed. And it
results infinite loop time to time.
This patch fixes the function's return value correctly.
Change-Id: I08ea4c3a7c294774163c63983b48b458aa1d5c43
Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
Hyotaek Shim [Wed, 7 Sep 2016 05:20:29 +0000 (22:20 -0700)]
Merge "kdbus: fix for GetConnectionSELinuxSecurityContext method call" into tizen
INSUN PYO [Mon, 5 Sep 2016 09:32:46 +0000 (18:32 +0900)]
kdbus: fix build error for 64 bit architecture
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I25c8313c5cf8e22702fe61703445a7640fad9298
Lukasz Skalski [Mon, 5 Sep 2016 09:06:03 +0000 (11:06 +0200)]
kdbus: fix for GetConnectionSELinuxSecurityContext method call
To keep compatibility with dbus1, GetConnectionSELinuxSecurityContext
method call should always return SELinuxSecurityContextUnknown error
on systems without SELinux (even if other LSM systems, like for example
SMACK, are available on platform).
Change-Id: Iaff5afad798b06179c298e65955f90038882b54f
INSUN PYO [Mon, 5 Sep 2016 03:14:43 +0000 (12:14 +0900)]
kdbus: enable KDBUS_MEMORY_POOL_SIZE environment to support adjustable memory pool
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ic593bc76914ef0aba3b448924d40a52e276df529
INSUN PYO [Thu, 1 Sep 2016 03:28:52 +0000 (20:28 -0700)]
Merge "change KDBUS_INFINITE_TIMEOUT_NS to 0x3ff.. to avoid wraparound - will work for 144 years of uptime" into tizen
Hyotaek Shim [Thu, 1 Sep 2016 02:06:34 +0000 (19:06 -0700)]
Merge "kdbus: always use well-known names for proxy" into tizen
Konrad Lipinski [Wed, 31 Aug 2016 15:06:31 +0000 (17:06 +0200)]
change KDBUS_INFINITE_TIMEOUT_NS to 0x3ff.. to avoid wraparound - will work for 144 years of uptime
Change-Id: I597460ffb82d5551f221de0554c0f81746f5dee9
Hyotaek Shim [Wed, 31 Aug 2016 07:06:29 +0000 (16:06 +0900)]
Detailed error information on KDBUS_CMD_SEND failures
Change-Id: Ied09920c30f014bcbfe2b7160fb9b13cc8297f09
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Lukasz Skalski [Mon, 29 Aug 2016 14:17:54 +0000 (16:17 +0200)]
kdbus: always use well-known names for proxy
If proxy->priv->name is a well-known name (what just means that we
created proxy for well-known name) then proxy->priv->name_owner points
to current name owner (unique id or NULL if name currently doesn't have
any owner). If we have following scenario:
1) server termination
2) g_dbus_proxy_call() to server
2a) get_destination_for_call()
3) on_name_owner callback, which set proxy->priv->name_owner to NULL
then get_destination_for_call() function will return
proxy->priv->name_owner value (which is unique id of previous name
owner). To avoid above race condition it will be better if we 'always'
return well-known name (without checking name_owner value).
Change-Id: I31f7edb56d8434e26a15efe260c1b737486da93e
INSUN PYO [Tue, 23 Aug 2016 04:11:44 +0000 (13:11 +0900)]
kdbus:remove not necessary(dbuplicated) code - kdbus timeout
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ia5a027ed30ccda95c3fa034fc793a9d2d8023526
MyoungJune Park [Mon, 22 Aug 2016 11:52:14 +0000 (04:52 -0700)]
Merge "global construction for dbusconnection only on _TV_PROFILE" into tizen
INSUN PYO [Mon, 22 Aug 2016 03:34:17 +0000 (12:34 +0900)]
Revert (Build Error) : speed up incremental builds: %reconfigure instead of autogen
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I6933e2aa5fca4d23a5c9c63ceb9d915081f9dc5d
INSUN PYO [Mon, 22 Aug 2016 02:34:27 +0000 (11:34 +0900)]
kdbus: fixed(build error) memory leak in hello command - #2
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I62a2b60968ba08409790b61bd670be9804334cbe
Konrad Lipinski [Tue, 16 Aug 2016 15:35:33 +0000 (17:35 +0200)]
gkdbus reply timeout changes
- drop userspace timeouts on unix/kdbus (rely on kdbus instead)
- propagate user-provided timeouts to kdbus
- translate infinite timeouts (G_MAXINT) into 0x7fffffffffffffff ns
(292 years)
Change-Id: Id769802925522cf82c26354dae9d8ee29fcb972d
Hyotaek Shim [Wed, 17 Aug 2016 05:14:26 +0000 (22:14 -0700)]
Merge "modify signal subscription rule" into tizen
sanghyeok.oh [Tue, 16 Aug 2016 11:28:26 +0000 (20:28 +0900)]
modify signal subscription rule
Change-Id: I8ab485f0a59e041ef735ff8cc74909cf9b7db91f
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Wed, 17 Aug 2016 02:33:10 +0000 (19:33 -0700)]
Merge "kdbus: fixed memory leak in "hello" command." into tizen
Konrad Lipinski [Thu, 11 Aug 2016 12:27:41 +0000 (14:27 +0200)]
speed up incremental builds: %reconfigure instead of autogen
Change-Id: I90aa6c14568fbefc981650c7c1beb56f26c66747
Hyotaek Shim [Tue, 16 Aug 2016 09:43:46 +0000 (02:43 -0700)]
Merge "modify signal subscribtion rule" into tizen
Adrian Szyndela [Tue, 16 Aug 2016 09:39:58 +0000 (11:39 +0200)]
kdbus: fixed memory leak in "hello" command.
Change-Id: I0e411bc9dbaf0b08bb622650596e1c491d85d3e5
sanghyeok.oh [Tue, 16 Aug 2016 08:18:57 +0000 (17:18 +0900)]
modify signal subscribtion rule
Change-Id: I77ca7dc2222077ea0253aed7179582149b320b65
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Tue, 16 Aug 2016 08:13:19 +0000 (01:13 -0700)]
Merge "kdbus: policy: add more detailed errors desciriptions" into tizen
Hyotaek Shim [Tue, 16 Aug 2016 07:58:56 +0000 (00:58 -0700)]
Merge "Sync calls are now performed without lock held" into tizen
Adrian Szyndela [Thu, 11 Aug 2016 15:38:34 +0000 (17:38 +0200)]
Sync calls are now performed without lock held
Sync calls were performed by function _g_kdbus_worker_send_message_sync()
called under connection lock. It was not necessary to hold the lock,
and it had side effects: holding another threads that wanted to call
something synchronically.
First argument of the function is connection->kdbus_worker. It is safe
to access this member, because it is read-only and outer context must keep
a reference to the connection, anyway. Worker itself is in turn kept
by reference from the connection.
The function uses only worker's read-only members, which are initialized
once at the creation of worker or connection. The only exception is
'matches' field, which is also modified in 'AddMatch'/'RemoveMatch'
method calls handler.
To sum up: I moved call to _g_kdbus_worker_send_message_sync() out of
connection lock and I have added a dedicated mutex for 'matches'.
Change-Id: I5895e591a9f32f085958b5b422d8b81110bd6c4d
sanghyeok.oh [Wed, 10 Aug 2016 07:29:04 +0000 (16:29 +0900)]
modify signal subscribe rule to allow-none
modified to allow signal subscribe for NameOwnerChanged by 'allow-none' setting(sender, path, interface)
Change-Id: I94d57ad4ca5a7db0bc5f734275835d04fe99a540
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Wed, 10 Aug 2016 02:55:25 +0000 (11:55 +0900)]
set KDBUS_DEFAULT_TIMEOUT_NS to 25 seconds
Change-Id: Ibff1b1c07d94a3b7679752d6c2fa1fe8fdd15d44
Lukasz Skalski [Wed, 3 Aug 2016 14:38:12 +0000 (16:38 +0200)]
kdbus: policy: add more detailed errors desciriptions
Change-Id: I2bb44b798e2456809665205baec82d8436e935cd
MyoungJune Park [Tue, 2 Aug 2016 05:29:18 +0000 (14:29 +0900)]
global construction for dbusconnection only on _TV_PROFILE
Change-Id: Ie2430ed9210984ea012b37fa455229fc13895cdb
Signed-off-by: MyoungJune Park <mj2004.park@samsung.com>
INSUN PYO [Tue, 19 Jul 2016 01:55:58 +0000 (10:55 +0900)]
Subject: [PATCH 1/2] kdbus: Fix the overflow for timeout calculation
The maximum value of unsigned long is
4294967295 which is too small
for storing nano second. It makes the overflow in calculation.
Use LLU instead of LU for timeout calculation.
======================================================================
Subject: [PATCH 2/2] kdbus: adjust the default value for timeout to 50 sec
This definition is used by the default value for timeout value.
But in the other places, 50 sec is used by default value for timeout,
instead of using it.
Let's align it with the others.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I9fb9839a311daf0c5839c87cdde793c2a4118869
sanghyeok.oh [Wed, 6 Jul 2016 06:37:14 +0000 (15:37 +0900)]
svace:
[gio/gkdbus.c]
1. delete unreachable code
2. expand error check range
Change-Id: Ia36937b81d2e86111f9ce8a1f232ab0c842300e7
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Tue, 28 Jun 2016 00:49:45 +0000 (17:49 -0700)]
Merge "kdbus: don't close the same memfd item twice" into tizen
Hyotaek Shim [Tue, 28 Jun 2016 00:49:31 +0000 (17:49 -0700)]
Merge "kdbus: fix sending memfd items" into tizen
Lukasz Skalski [Fri, 24 Jun 2016 11:46:35 +0000 (13:46 +0200)]
kdbus: don't close the same memfd item twice
Change-Id: I28e39b9dbbf58cb6fb16ba9721e5023208752777
INSUN PYO [Fri, 24 Jun 2016 06:40:22 +0000 (15:40 +0900)]
Bug fix for signal hash(bloom filter) operations in gdbus-transport-kdbus
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ic051ee89a2e7bfb3c105be289082ebc5b6a94e88
Lukasz Skalski [Wed, 1 Jun 2016 13:19:41 +0000 (15:19 +0200)]
kdbus: fix sending memfd items
Change-Id: Ibedc35ea0f3d443a8a3bde5151f145111a1eacf5
DongHun Kwak [Tue, 10 May 2016 06:22:43 +0000 (15:22 +0900)]
Merge branch 'upstream' of ssh://review.tizen.org:29418/platform/upstream/glib into upstream
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Conflicts:
gio/inotify/ginotifydirectorymonitor.c
gio/tests/.gitignore
glib/tests/.gitignore
Change-Id: If6fc8d87e436f1c57686a4b39b42804136a940c3
Ryan Lortie [Mon, 16 Mar 2015 19:22:03 +0000 (15:22 -0400)]
Imported Upstream version 2.48.0
Change-Id: Ie8c1fa7173d48588524ed4e85cffd9e9af340d97
Signed-off-by: DongHun Kwak <dh0128.kwak@samsung.com>
Lukasz Skalski [Wed, 27 Apr 2016 09:32:05 +0000 (11:32 +0200)]
kdbus: catch up with latest libdbuspolicy API changes
Change-Id: I6bfb75785c7e817ad7a063f989671ab6d4279dc2
Hyotaek Shim [Tue, 12 Apr 2016 05:10:05 +0000 (22:10 -0700)]
Merge "gdbus-codegen: avoid warnings when generated code is compiled with -Wunused-parameter" into tizen
Hyotaek Shim [Tue, 12 Apr 2016 01:42:47 +0000 (18:42 -0700)]
Merge "Revert "Temporarily removing BuildRequires to libdbuspolicy to check cyclic build dep."" into tizen
Hyotaek Shim [Tue, 12 Apr 2016 01:41:38 +0000 (18:41 -0700)]
Revert "Temporarily removing BuildRequires to libdbuspolicy to check cyclic build dep."
This reverts commit
af3acf0be463fad4d470dbbab4b61b825edce0cf.
Change-Id: I5db890ca0e86f78d10736ec50ab82e0ab2f95c1d
Lukasz Skalski [Mon, 11 Apr 2016 15:19:30 +0000 (17:19 +0200)]
gdbus-codegen: avoid warnings when generated code is compiled with -Wunused-parameter
Change-Id: Id62df4e7c7f7059a47ee7ee32aa054d91c6847a1
Lukasz Skalski [Mon, 11 Apr 2016 13:07:10 +0000 (15:07 +0200)]
kdbus: don't check 'out' policy for method return
Change-Id: I7ac8abb8eebbc51d2dd20f632f0bc5d798fe4eae
Lukasz Skalski [Fri, 8 Apr 2016 12:27:39 +0000 (14:27 +0200)]
kdbus: fix 'check in' policy
Change-Id: If3e39fc8fb9890c35f788a466346471785d578b8
Hyotaek Shim [Fri, 8 Apr 2016 05:32:17 +0000 (14:32 +0900)]
Temporarily removing BuildRequires to libdbuspolicy to check cyclic build dep.
Change-Id: Ic4bd089219fc91ba3b514879be1232a4bf2dddad
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 5 Apr 2016 01:59:59 +0000 (18:59 -0700)]
Merge "Add BuildRequires to the libdbuspolicy package" into tizen